Megan Marsh
dfe8aa51b0
Merge pull request #9845 from hashicorp/run_and_stream_helper_func
...
move runAndStream into a generalized helper function to enable easy l…
2020-09-04 12:19:37 -07:00
Megan Marsh
5120ad9d9a
add test file
2020-09-04 11:56:32 -07:00
Megan Marsh
20d62654ae
move runAndStream into a generalized helper function to enable easy local exectution in other places than just the docker builder
2020-09-04 11:56:32 -07:00
Lars Lehtonen
03a0beb683
builder/vmware/common: simplify type assertion switch ( #9893 )
2020-09-04 16:25:19 +02:00
Sylvia Moss
ba74602d63
Allows publishing to a Shared Image Gallery with a different subscription id ( #9875 )
2020-09-03 17:13:32 +02:00
catsby
7a7d3ff350
Remove comments about sharing with catsby
2020-09-03 09:14:40 -05:00
Troy Lindsay
d1a61cac33
Add NVMe controller support to vsphere-iso builder ( #9880 )
2020-09-03 11:14:58 +02:00
Troy Lindsay
602729ac23
Fix vsphere-iso acceptance tests ( #9878 ) ( #9881 )
2020-09-03 10:17:49 +02:00
Rae Krantz
ab23e839c8
update sharing test to req aws account id
2020-09-02 11:44:38 -04:00
Sylvia Moss
903deb9e6a
vSphere StepHardware tests ( #9866 )
2020-09-02 10:19:57 +02:00
Megan Marsh
e96cc07a1a
Merge pull request #9853 from remyleone/boottype_local
...
change default scaleway boottype to local
2020-09-01 10:44:42 -07:00
Sylvia Moss
24dbd0a28b
Fix iso_path validation regex ( #9855 )
2020-09-01 10:11:48 +02:00
Wilken Rivera
f4556fd3f1
Merge pull request #9831 from hashicorp/remedial_remote_export_config_tests
...
add tests to make sure prepare for export defaults properly
2020-08-31 15:47:05 -04:00
js-g
f74a425661
feat (builder/oracle-oci): pass CreateVnicDetails to instance
2020-08-31 13:13:33 -04:00
Sylvia Moss
58a0bdd780
Look for a default resource pool when root resource pool is not found ( #9809 )
2020-08-31 16:26:48 +02:00
Wilken Rivera
03a374f4b6
Fix linting issues for SA6005 check ( #9854 )
...
Before change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
builder/profitbricks/step_create_server.go:254:22: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/oneandone/config.go:97:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/vmware/common/driver_parser.go:1199:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
```
After change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
```
2020-08-31 15:44:42 +02:00
GennadySpb
804fefef17
yandex-import: allow set custom API endpoint ( #9850 )
...
* Separate Access Config from yandex builder Config
* make use of Access Config explicit
* Move `MaxRetries` into AccessConfig
* NewDriverYC use AccessConfig instead Config
* yandex-import PP use common Access Config
Now support set custom API Endpoint
* yandex-export PP use common Access Config
Now support set custom API Endpoint too (as yandex-import)
* fix test
* Tiny doc updates.
2020-08-31 15:29:20 +02:00
OblateSpheroid
0ad26cce01
Feat (oracle-oci): allow freeform and defined tags to be added instance ( #9802 )
...
* feat (oracle-oci): allow freeform and defined tags to be added to instance (#6313 )
* docs (oracle-oci): add descriptions for instance_tags and instance_defined_tags (#6313 )
* fix: fmt
* fix: generate hcl2spec
2020-08-31 14:36:09 +02:00
Rémy Léone
ecd1a49a35
change default scaleway boottype to local
2020-08-31 13:15:37 +02:00
Andreas Botzner
e4f975fae1
Allows for the mounting of ISOs when a Proxmox VM s created. Same as … ( #9653 )
...
Allows the mounting of additional ISOs when the VM is created. The config option was taken from PR #9055 and slightly changed. Users can specify an array of bus names, bus numbers and filenames.
"cd_drive":[
{
"bus": "ide",
"bus_number": 3,
"filename": "isos:iso/virtio-win-0.1.187.iso"
},
{
"bus": "sata",
"bus_number": 3,
"filename": "isos:iso/someother.iso"
}
]
Closes : #7950
Co-authored-by: Calle Pettersson <carlpett@users.noreply.github.com>
2020-08-31 10:48:24 +02:00
Sylvia Moss
942bfbf221
Add driver mocks and write tests to steps Remote Upload and Create VM ( #9833 )
2020-08-31 10:34:41 +02:00
Megan Marsh
1c5bc41beb
refactor ovftool validation into vmware driver
2020-08-27 10:55:57 -07:00
Megan Marsh
bbc3a5b0d1
add tests to make sure prepare for export defaults properly
2020-08-27 10:55:57 -07:00
Marin Salinas
e0badb3fb7
refactor: update step_update_omi_attributes and create_tags to new OSC SDK
2020-08-26 12:25:46 -05:00
Megan Marsh
a6d5106cd7
Allow "export" to ovf/ova for local vmware builds in addition to esx ones.
...
Refactor step_export and the driver interface to move the ovftool call
into the vmware driver. This refactor allows us to add meaningful tests
to step_export, which I have also added here.
2020-08-26 09:45:12 -07:00
Megan Marsh
e9b526ee2d
Move step_create_disk into common folder, and add to vmx builder ( #9815 )
...
Pull additional disk related config options into their own file.
2020-08-26 10:13:11 +02:00
Marin Salinas
8885a5ef31
refactor: update step_create_omi to new OSC SDK
2020-08-25 18:02:11 -05:00
Marin Salinas
f0dc26613a
Merge pull request #7 from marinsalinas/step_deregister_omi
...
Step Deregister OMI
2020-08-25 17:22:58 -05:00
Adrien Delorme
0d0bd9ce75
name fields of PolicyDocument correctly in HCL ( #9812 )
...
withouth this fix we would have had to do
```hcl
temporary_iam_instance_profile_policy_document {
statement {
action = ["*"]
effect = "Allow"
resource = ["*"]
}
version = "2012-10-17"
}
```
instead of the same document but with capitalised fields
2020-08-25 10:53:56 +02:00
Adrien Delorme
a0c09e85df
retry spot instance creation when an "Invalid IAM Instance Profile name" error pops up ( #9810 )
...
PutRolePolicy & AddRoleToInstanceProfile are eventually consistent but it is not possible to wait for them to be done here: 0785c2f6fc/builder/amazon/common/step_iam_instance_profile.go (L117-L134)
which was causing the `CreateFleet` to fail (100% for me). So for now we retry a bit later. Waiting 5 seconds after the previously linked code also fixed this.
Test file:
```json
{
"builders": [
{
"type": "amazon-ebs",
"region": "eu-west-1",
"ami_name": "ubuntu-16.04 test {{timestamp}}",
"ami_description": "Ubuntu 16.04 LTS - expand root partition",
"source_ami_filter": {
"filters": {
"virtualization-type": "hvm",
"name": "ubuntu/images/*/ubuntu-xenial-16.04-amd64-server-*",
"root-device-type": "ebs"
},
"owners": [
"099720109477"
],
"most_recent": true
},
"spot_price": "0.03",
"spot_instance_types": [
"t2.small"
],
"encrypt_boot": true,
"ssh_username": "ubuntu",
"ssh_interface": "session_manager",
"temporary_iam_instance_profile_policy_document": {
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"*"
],
"Resource": "*"
}
]
},
"communicator": "ssh"
}
]}
```
2020-08-25 10:10:32 +02:00
Sylvia Moss
2152fa3313
Accept content library path in iso_paths ( #9801 )
2020-08-24 16:54:30 +02:00
Marin Salinas
8166dad533
Merge pull request #5 from marinsalinas/step_cleanup_volumes
...
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-21 15:03:47 -05:00
PacoDw
8274d4848c
chore: added forece_deregister in the test case to verify the step_deregister_omi
2020-08-21 13:30:21 -05:00
PacoDw
071854ea4a
chore: implemented OSC API in step_deregister_omi
2020-08-21 13:29:41 -05:00
PacoDw
a13dfe1f42
chore: added GetRegion() and NewOSCClientByRegion functions
2020-08-21 13:29:27 -05:00
PacoDw
60bd61dc18
chore: removed security group filter function, it was moved to step_security_group file
2020-08-21 11:31:00 -05:00
PacoDw
c3a4b60ea5
chore: implemented OSC API in step_security_group
2020-08-21 11:30:10 -05:00
Marin Salinas
7a45e4c8b0
refactor: change step tag bsu volumes to new OSC SDK
2020-08-21 10:40:14 -05:00
Marin Salinas
c58d6f9b33
refactor: migrate run vm step to new SDK
2020-08-21 10:10:25 -05:00
Marin Salinas
6f0bb33c9a
refactor: change tags ssh file to new OSC SDK
2020-08-20 20:35:51 -05:00
Marin Salinas
e5c14044fb
refactor: change tags file to new OSC SDK
2020-08-20 19:12:38 -05:00
Marin Salinas
addc3dd6e7
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-20 18:33:02 -05:00
Marin Salinas
d9a7626249
Merge pull request #4 from marinsalinas/step_public_ip
...
Step public ip
2020-08-20 18:04:03 -05:00
PacoDw
7745369dce
chore: set true associate_public_ip_address attribute to test the step_public_ip
2020-08-20 14:00:13 -05:00
PacoDw
86966ecfee
:chore: implemented OSC API in pre_public_ip step
2020-08-20 13:59:25 -05:00
Sylvia Moss
ada2a431ef
Modularise vCenter rest client ( #9793 )
2020-08-20 17:55:25 +02:00
Sylvia Moss
99800619b7
Add HCL2 examples to the virtualbox builders ( #9788 )
2020-08-20 15:43:38 +02:00
Sylvia Moss
a1524bf96a
Add option to also import OVF templates to the Content Library ( #9755 )
2020-08-19 13:20:25 +02:00
PacoDw
232d5a3ce6
chore: changed oapi to osc
2020-08-18 15:06:00 -05:00
Megan Marsh
a2cfaace59
extract output dir configuration and defaulting into the step_output_dir, using pointers to make sure they get set properly back on the main config
2020-08-18 12:50:06 -07:00
Megan Marsh
3b2bedf794
implement a remote_output_directory option, and heavily comment output code
2020-08-18 12:50:00 -07:00
PacoDw
43e9d43ebd
chore: removed API attribute
2020-08-18 13:52:49 -05:00
Marin Salinas
8b2cdc5821
refactor: change step_network_info to new OSC SDK
2020-08-18 13:33:45 -05:00
Marin Salinas
8649496c6c
refactor: change new sdk on step_source_omi_info
2020-08-18 13:33:45 -05:00
PacoDw
4431bb87b2
:chore: added api key to specify the API connection
2020-08-18 13:33:45 -05:00
PacoDw
823b957a1f
:chore: implemented OSC connection in pre_validate file
2020-08-18 13:33:45 -05:00
PacoDw
22481d1ac2
:chore: added OSC Connection in builder file
2020-08-18 13:32:38 -05:00
PacoDw
1fbe715c13
:chore: added OSC Connection in builder file
2020-08-18 12:23:39 -05:00
Megan Marsh
b0d2201d55
Merge pull request #9782 from hashicorp/fix_9151
...
fully destroy vm if it was cancelled or errored
2020-08-18 07:22:18 -07:00
Megan Marsh
0a5cd953fc
fully destroy vm if it was cancelled or errored
2020-08-17 14:07:58 -07:00
Megan Marsh
aa2418cf01
add progress tracker to vmware-esx iso upload. Add colored prefix to … ( #9779 )
...
* add progress tracker to vmware-esx iso upload. Add colored prefix to tracker to make it clear which build a tracker belongs to.
* fix mock; fix tests
2020-08-17 14:35:42 -04:00
Megan Marsh
d74b47b734
Merge pull request #9777 from hashicorp/fix_9756
...
Add aws_polling config option to override env variables
2020-08-17 10:49:38 -07:00
sylviamoss
1a0d5a93ee
fix max_attempts typo
2020-08-17 17:58:22 +02:00
sylviamoss
788dc32598
add aws_polling config option to override env variables
2020-08-17 17:15:32 +02:00
PacoDw
1bfb2d9170
:chore: implemented transport file to make the OSC API Connection
2020-08-17 10:04:28 -05:00
PacoDw
1055007cba
:chore: added OSC API Client Connection
2020-08-17 10:02:00 -05:00
Isaac Buckman
46a26a3d9e
Fix Hyper-V boot command refs #5291 ( #9765 )
2020-08-17 16:00:43 +02:00
Megan Marsh
8b4993e44c
fix docs for kms key ids ( #9766 )
2020-08-14 11:35:35 +02:00
PacoDw
74f868da37
:chore: changed the AMI with an existing AMI to work fine with the test case
2020-08-13 17:03:32 -05:00
Megan Marsh
acba3ea3e7
Document network path ( #9762 )
2020-08-13 11:26:40 -04:00
Megan Marsh
e97c56dc72
Merge pull request #9559 from hashicorp/fix_9482
...
builder/azure-arm: Remove duplicate resource deletion steps
2020-08-12 12:43:09 -07:00
Wilken Rivera
55812fe8a5
Handle error of deferred deletion
2020-08-12 11:30:15 -04:00
Wilken Rivera
5700f74c8c
Handle lease not present error
2020-08-12 11:27:07 -04:00
Wilken Rivera
d91839b93e
Update deletion logic for OS disks
...
* Add an ResourceNotFound error check
* Add logic to break temporary disk lease before deleting it
2020-08-12 11:03:51 -04:00
Wilken Rivera
ba6d11d518
Remove StepDeleteOSDisk in favor of StepDeployTemplate#Cleanup
2020-08-12 11:03:03 -04:00
Megan Marsh
54469c4728
Add all of the custom AWS template engines to GeneratedData for use b… ( #9751 )
2020-08-12 10:43:15 +02:00
Sylvia Moss
e475db6a66
check for ip after timeout ( #9748 )
2020-08-12 10:39:12 +02:00
Wilken Rivera
aed97e1a8b
Ensure any active leases are brokend before deleting
2020-08-11 16:41:28 -04:00
Wilken Rivera
920da9d0a4
Fix up code to remove some additional steps
2020-08-11 16:40:51 -04:00
Megan Marsh
f8bb9008c0
Merge pull request #9697 from backerman/personal/backerman/9695
...
Add FreeBSD support to azure/chroot
2020-08-10 12:47:48 -07:00
Wilken Rivera
7c28d5590c
Remove StepDeleteResourceGroup in favor of StepDeploymentTemplate#Cleanup
2020-08-10 12:57:11 -04:00
Sylvia Moss
80960d7a64
Fix vsphere boot command and check for context cancelation when waiting for ip ( #9739 )
2020-08-10 18:16:19 +02:00
Brad Ackerman
23d5432333
Revert inadvertently-changed import.
2020-08-09 14:31:54 -07:00
Brad Ackerman
109b2a0ca9
Build constraints don't seem to work on test.
2020-08-09 14:12:58 -07:00
Brad Ackerman
94c9b87431
Only run on platforms supported by chroot.
2020-08-09 13:53:21 -07:00
Brad Ackerman
33eb8483ba
Get some tests in here.
2020-08-09 13:39:29 -07:00
Megan Marsh
8f362656ee
Update builder/amazon/ebs/step_create_ami.go
...
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-08-07 08:02:57 -07:00
Megan Marsh
484dbfe6ad
improve error handling when waiting for image so that the resourcenotready error is bubbled up more clearly without verbose logging turned on
2020-08-06 14:58:05 -07:00
Megan Marsh
04d7a10aa0
Merge pull request #9714 from hashicorp/fix_9688
...
provide more helpful error message than the one returned by the clien…
2020-08-06 10:54:21 -07:00
Megan Marsh
4964c54f60
update docs to state resource id must be fully qualified
2020-08-06 10:41:18 -07:00
Megan Marsh
25f2ec48d3
add network_name option to vmware builder to make it match the network option on the vsphere builder, so vmware users needn't update vmx data just for the network name ( #9718 )
2020-08-06 13:19:55 +02:00
Megan Marsh
3f61498704
Merge pull request #9704 from ntoofu/f-vsphere-export-permission
...
Add `directory_permission` config option to `vsphere` builder
2020-08-05 10:57:30 -07:00
Sylvia Moss
dcacf7ad4c
Add vSphere HCL examples to the docs ( #9674 )
2020-08-05 19:23:52 +02:00
Megan Marsh
aede34079d
provide more helpful error message than the one returned by the client, without context
2020-08-05 09:52:11 -07:00
ntoofu
a53e81d9a2
Make docs more clear
...
https://github.com/hashicorp/packer/pull/9704#discussion_r465393240
2020-08-06 01:11:02 +09:00
jhawk28
6b8d086e94
alt, ctrl, and shift should be outside variables ( #9702 )
2020-08-05 17:36:40 +02:00
Megan Marsh
825deef43d
Merge pull request #9665 from hashicorp/vsphere_clone_customization
...
Add step to customize cloned VM
2020-08-05 08:30:31 -07:00
Sylvia Moss
dd37a10355
fix configuration_parameters ( #9713 )
2020-08-05 16:57:12 +02:00
ntoofu
5493285f65
Add `directory_permission` config option to `vsphere` builder
2020-08-02 15:02:31 +09:00
Brad Ackerman
fb1a4bd86f
Add placeholder diskattacher for other OSes.
2020-08-01 21:59:43 -07:00
Brad Ackerman
5ce6c8564c
Fix ordering to match master for better diffs.
2020-08-01 21:30:44 -07:00
Brad Ackerman
13a4e47efe
Increase wait time for device to be created.
2020-08-01 21:22:50 -07:00
Brad Ackerman
364c415294
Add FreeBSD support.
2020-08-01 21:22:50 -07:00
Etan Reisner
a28edbaa0b
Fix skip_save_build_region in the ebssurrogate builder. ( #9666 )
2020-07-31 16:01:46 -04:00
Megan Marsh
ea45efc9b8
Merge pull request #9677 from hashicorp/b-scaleway-user-agent-config
...
builder/scaleway: Remove mapstructure configuration for the UserAgent runtime-only field
2020-07-31 10:26:36 -07:00
sylviamoss
fc2e94554a
add qemu hcl examples
2020-07-31 17:32:08 +02:00
Wilken Rivera
a76c6c55a9
Remove HCL config for runtime field `UserAgent`
...
Results before change
```
⇶ packer build /tmp/minimal.pkr.hcl
Error: 1 error occurred:
* unknown configuration key: '"user_agent"'
on /tmp/minimal.pkr.hcl line 1:
(source code not available)
==> Builds finished but no artifacts were created.
```
Results after change
```
⇶ packer build /tmp/minimal.pkr.hcl
scaleway.required: output will be in this color.
==> scaleway.required: Creating temporary ssh key for server...
==> scaleway.required: Creating server...
```
2020-07-31 11:22:55 -04:00
Wilken Rivera
980f02ce5d
Add mapstructure tag for UserAgent field
...
Closes : #9676
2020-07-30 16:08:24 -04:00
Li Kexian
94a32dc282
tencentcloud cvm use CLOUD_PREMIUM disk by default ( #9663 )
2020-07-29 15:10:00 +02:00
sylviamoss
c6e9bde97b
add step customize and docs
2020-07-29 15:07:44 +02:00
jhawk28
3370c91cf2
add some additional messaging when a boot command fails to type ( #9661 )
2020-07-29 15:06:45 +02:00
Megan Marsh
883339be25
Set project via project flag, not setting in the config ( #9662 )
...
* set project via project flag, not setting in the config + tests
2020-07-29 10:50:11 +02:00
Megan Marsh
b695615d7d
fix local file stating ( #9660 )
2020-07-29 10:26:09 +02:00
Megan Marsh
b40490c3c1
Merge pull request #9610 from chilversc/winrm-via-iap-tunnel
...
Support using WinRM over an IAP tunnel
2020-07-28 14:27:43 -07:00
Megan Marsh
395a0c472e
improve postprocessor stdout
2020-07-25 08:24:21 -07:00
Megan Marsh
b3c3e3ed63
Merge pull request #9589 from hashicorp/fix_9184
...
post-processor/vsphere: Fix password encoding in vsphere post-processor ovftool call
2020-07-25 08:23:54 -07:00
Adrien Delorme
44616d3bff
refactor initialization out from packer configs + tests ( #9627 )
...
The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost.
This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too.
fix #9478
2020-07-24 10:58:03 +02:00
Megan Marsh
74aef3c819
apply same url encoding to other places we call ovftool
2020-07-23 17:03:42 -07:00
Megan Marsh
a687d6fe12
ci/tech-debt: Fix vmware acceptance tests ( #9636 )
...
* add kex algorithm option to ssh config
* regenerate code
* This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts:
1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed.
2) It modifies logic in reading and defaulting hardware config values, which was crashing.
3) It adds a new acceptance test with a preseed file to test loading from an http directory.
2020-07-23 09:40:57 +02:00
Megan Marsh
0a66f19dbe
fix minimal json example to use new checksumming ( #9633 )
2020-07-23 09:39:57 +02:00
Megan Marsh
ec5a2b87af
Merge pull request #9619 from piggona/master
...
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-22 10:29:30 -07:00
Megan Marsh
f9df185ef1
Merge pull request #9579 from hashicorp/fix_9562
...
wrap CreateImage call in a retry to account for eventual consistencey…
2020-07-22 08:43:10 -07:00
Chris Chilvers
63eedf841e
Fix failing tests due to IAP communicator host name
...
Moved setting the host from ApplyIAPTunnel to Config.Prepare but forgot to
update the related tests.
2020-07-22 12:58:05 +01:00
Megan Marsh
1f3b3f8fd9
change retry func to a 15 min timeout
2020-07-21 15:55:39 -07:00
Megan Marsh
a56942d3c7
change isAwsErr to an exported func so I can use it in other aws modules.
2020-07-21 15:30:45 -07:00
Megan Marsh
036ea238bf
wrap CreateImage call in a retry to account for eventual consistencey issues with image state
2020-07-21 15:30:45 -07:00
piggona
22b49c1a92
delete cvm-filter configuration
2020-07-21 11:04:41 +08:00
piggona
ecfce6ef4c
delete cvm-filter configuration
2020-07-21 11:04:32 +08:00
piggona
38563df35c
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-21 11:04:11 +08:00
piggona
a1b6f809c7
add:argument key SourceImageName to get source image by name.
2020-07-21 11:02:30 +08:00
Adrien Delorme
810f161d22
builder/amazon/common/block_device.go: replace tabs with words
2020-07-20 16:34:13 +02:00
Adrien Delorme
966b17d2b5
builder/amazon/common/access_config.go: replace tabs with words
2020-07-20 16:31:23 +02:00
Adrien Delorme
5c4901c2c2
builder/amazon/common/run_config.go: replace tabs with words
2020-07-20 16:28:14 +02:00
Adrien Delorme
1455a29f2b
remove tabs for security_group_filter too
2020-07-20 16:24:47 +02:00
Adrien Delorme
191094edcc
better `disable_stop_instance` docs
2020-07-20 16:21:43 +02:00
Chris Chilvers
37544f4d5f
Support using WinRM over an IAP tunnel
...
This avoids the need to expose WinRM ports on the internet and allows
using instances with only an internal private IP address.
When using a WinRM tunnel there is a race condition between the tunnel
connection attempt timing out and packer assuming the connection was
successful. To allow for this, when using WinRM the default success
timeout is increased to 40 seconds.
2020-07-19 01:28:31 +01:00
Megan Marsh
530f5e3f63
more additions to partials
2020-07-17 15:52:11 -07:00
Megan Marsh
a1651977b3
add tabs to generated docs from access_config and run_config structs
2020-07-17 15:10:55 -07:00
Megan Marsh
8964367eb5
Merge pull request #9603 from paulmey/disable-password
...
[azure-arm] Disable ssh password authentication unless password is explicitly specified
2020-07-17 09:32:38 -07:00
Megan Marsh
0883e185a2
Merge pull request #9594 from GennadySpb/yndx-image-min-disk-size
...
yandex: Add new property 'min_disk_size' of built image
2020-07-17 09:31:48 -07:00
Megan Marsh
9f34241b5c
Merge pull request #9597 from romantomjak/multiqueue-net-option
...
builder/proxmox: add support for multiple NIC packet queues
2020-07-17 09:07:04 -07:00
Paul Meyer
708ca1c126
Add some error checking
2020-07-16 23:22:24 +00:00
Paul Meyer
deca28c158
Disable password auth on ssh key Linux builds
2020-07-16 22:26:06 +00:00
Paul Meyer
5fd68374fe
Optionally disable password authentication for Linux builds
2020-07-16 19:44:01 +00:00
Roman Tomjak
a2220e5f08
make linter happy
2020-07-16 18:19:22 +01:00
Roman Tomjak
d3d7cc3e59
configure packet queues on nics
2020-07-16 17:56:58 +01:00
Roman Tomjak
a65157a91b
use helper method for mandatory config
2020-07-16 17:41:56 +01:00
Gennady Lipenkov
03a0bf26f2
Rename config key name
2020-07-16 17:29:45 +03:00
Gennady Lipenkov
9c565a97c0
Add new property 'min_disk_size' of built image
2020-07-16 17:10:22 +03:00
Megan Marsh
c0270c9f19
Merge pull request #9587 from romantomjak/disable-kvm-flag
...
Add option to disable KVM hardware virtualization in proxmox builder
2020-07-15 15:23:09 -07:00
Roman Tomjak
7ed8709483
add option to configure network adapter multiqueue support
2020-07-15 23:07:02 +01:00
Roman Tomjak
376b8c045e
use the value of disable kvm flag when creating the VM
2020-07-15 19:12:01 +01:00
Roman Tomjak
be7251f185
add option to disable kvm hardware virtualization
2020-07-15 18:47:24 +01:00
Megan Marsh
8bb2cb44c0
rename launch timeout to launch wait
2020-07-15 10:24:55 -07:00
Megan Marsh
6e9eaa1edd
generate code
2020-07-15 10:20:50 -07:00
Megan Marsh
af009c2aa0
make tunnel timeout configurable
2020-07-15 10:17:13 -07:00
Megan Marsh
cf5537d5d2
Merge pull request #9565 from mk0x9/docker/builder-add-runner-params
...
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs, --device
2020-07-15 10:16:13 -07:00
Megan Marsh
c59d0b0283
Merge pull request #9584 from hashicorp/azr-fix-esxi-checksum
...
esx5driver.VerifyChecksum: try checksum remote file instead of local file
2020-07-15 10:07:17 -07:00
Adrien Delorme
1edd848877
esx5driver.VerifyChecksum: try checksum remote file instead of local file
...
fix #9456
2020-07-15 18:21:08 +02:00
Michael Kuryshev
37d0f48599
builder/docker: reference to docker docs regarding capabilities
2020-07-15 03:04:13 +02:00
Megan Marsh
a414e7cdb9
convert relative to absolute path in prepare
2020-07-14 15:59:53 -07:00
Megan Marsh
bb43b5cac4
improve validation and error handling around synced_folder
2020-07-14 11:34:40 -07:00
Michael Kuryshev
6e77d9d3a9
builder/docker: runner support for --device
2020-07-14 10:37:44 -07:00
Michael Kuryshev
791a86c45e
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs
2020-07-14 10:34:10 -07:00
Megan Marsh
f5031a1eb5
Merge pull request #9573 from zhsj/bump-gophercloud
...
Bump gophercloud to latest version
2020-07-14 10:11:06 -07:00
Megan Marsh
aa4933c28a
Merge pull request #9574 from jhawk28/vsphere_usb_controllers
...
(vsphere) add ability to add a xhci/usb3 controller
2020-07-14 10:09:33 -07:00
Joshua Foster
b49c844637
ignore false and 0 in case someone defined the field as "false" or false
2020-07-14 12:11:24 -04:00
Sylvia Moss
5a006f226a
Don't use Packer context as vSphere driver context ( #9576 )
2020-07-14 11:45:19 +02:00
Sylvia Moss
eb5c3c3efb
fix file size descriptor ( #9568 )
2020-07-14 11:36:49 +02:00
Sylvia Moss
3a0dfa1259
add option to destroy vm after deploy to content library ( #9569 )
2020-07-14 10:07:20 +02:00
Joshua Foster
b0fa05704a
change usb controllers to a list. add ability to set as a usb3
...
Closes #8874
2020-07-13 20:54:46 -04:00
Shengjing Zhu
4fe9a92058
Bump gophercloud to latest version
2020-07-14 00:01:37 +08:00
Roger Hu
28f8241a05
update generated files
2020-07-10 16:58:06 -07:00
Moss
921078ccc0
add force_bios_setup configuration option
2020-07-10 12:30:22 +02:00
jhawk28
ae5156a70d
add ability to define multiple disk controllers ( #9519 )
2020-07-10 12:25:46 +02:00
Sylvia Moss
9c1409dbba
Add content_library_destination to import VM template to a Content Library ( #9551 )
2020-07-10 11:01:10 +02:00
Megan Marsh
61b79b6e53
Merge pull request #9542 from jhawk28/bug_9511
...
clean up folder path so that it is what vsphere expects
2020-07-09 16:08:18 -07:00
Megan Marsh
e1e37ad025
Merge pull request #9555 from yandex-cloud/yandex-export-templating
...
yandex-export: templating
2020-07-09 15:50:04 -07:00
Megan Marsh
b7f1aedf96
Merge pull request #9556 from hashicorp/fix_9107
...
Match network to host when multiple networks are found
2020-07-09 14:52:32 -07:00
Joshua Foster
765d96e8eb
unset HardwareConfig.Firmware since CreateConfig.Firmware configures the firmware in StepCreateVM
2020-07-09 10:34:48 -04:00
Moss
b74e28a479
match network to host when multiple networks are found
2020-07-09 15:59:15 +02:00
Gennady Lipenkov
378c9746fa
Fill up build variables (aka `generated_data`)
...
See description at https://packer.io/docs/extending/custom-builders#build-variables
2020-07-09 16:21:21 +03:00
Megan Marsh
e08c1a461a
Merge pull request #9553 from GennadySpb/yandex-import-post-processor
...
[WIP] Yandex Import post-processor
2020-07-08 16:25:08 -07:00
Megan Marsh
4d3b2cea96
Merge pull request #9480 from adongy/master
...
aws: retry fetching blockdevicemapping if empty
2020-07-08 12:32:12 -07:00
Gennady Lipenkov
420beb333b
make inner image accessible from other packages
2020-07-08 22:01:52 +03:00
Megan Marsh
a885e620ee
don't error for no mappings if no mappings were set.
2020-07-08 11:55:56 -07:00
Wei Cheng
e5606d483d
builder/googlecompute: add support for oslogin ( #9339 )
...
* feat: add support for oslogin
Signed-off-by: Wei Cheng <calvinpohwc@gmail.com>
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-07-08 06:30:25 -04:00
Megan Marsh
d4a7dd24d9
fix link in deprecation warning ( #9544 )
2020-07-08 11:59:39 +02:00
Sylvia Moss
268e95364f
Adds vApp properties config and save public ssh key to a vApp property ( #9507 )
2020-07-08 10:33:45 +02:00
Megan Marsh
673858a63c
Merge pull request #9513 from hashicorp/undocument_ssh_temp_key
...
Undocument ssh options not used by all builders
2020-07-07 14:26:21 -07:00
Wilken Rivera
892413b7ea
docs/builder/vsphere-iso: Add documentation for BootConfig ( #9538 )
...
* docs/builder/vsphere-iso: Add documentation for BootConfig
* Add documenation for http_ip
* Remove duplicate build configuration section
2020-07-07 13:57:51 -04:00
Wilken Rivera
eeb6f017bd
Merge pull request #9505 from hashicorp/f-googlecompute-wrap_startup_script-option
...
builder/googlecompute: Add WrapStartupScriptFile configuration option
2020-07-07 13:17:02 -04:00
Joshua Foster
a6170b0c35
clean up folder path so that it is what vsphere expects
2020-07-07 12:25:14 -04:00
Lyle Franklin
a4d1afb83a
Add 'cdrom_interface' option to QEMU builder ( #9483 )
...
- This option allows the user to select the interface type for the CDROM
drive, e.g. `virtio-scsi`, rather than the default `virtio`
- Background: Installation of Ubuntu 20.04 on ARM64 fails as it can't mount the
installation CDROM. While the default `virtio` CDROM fails, setting
`cdrom_interface: virtio-scsi` with this PR succeeds. Some links:
- ISO link: http://cdimage.ubuntu.com/ubuntu-legacy-server/releases/20.04/release/ubuntu-20.04-legacy-server-arm64.iso
- https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1605407
- https://superuser.com/a/1376628/230508
2020-07-07 16:22:30 +02:00
Wilken Rivera
4462c0b5ab
builder/googlecompute: Add WrapStartupScriptFile configuration option
...
By default the Google builder will wrap any provided startup script file
in order to track its execution via custom metadata. The wrapper script
can add a bit of complexity to the start script file so a new option is
being added `wrap_startup_script`. This option allows a user to disable
the script wrapping and just let GCE do its own thing when executing a
startup script.
2020-07-07 07:08:09 -04:00
Megan Marsh
6095fb2a62
Merge pull request #9515 from jhawk28/vsphere_tools_fix
...
fix vsphere ToolsSyncTime and ToolsUpgradePolicy
2020-07-02 14:19:41 -07:00
Joshua Foster
500ec5ccc7
fix return
2020-07-02 12:55:10 -04:00
Joshua Foster
e4dffeed35
clean up if logic
2020-07-02 12:33:28 -04:00
Moss
8ea64c5b35
undocument ssh_keypair_name and ssh_agent_auth
2020-07-02 14:55:58 +02:00
Megan Marsh
445cf12b65
Merge pull request #9489 from ad-m/hyperone-freebsd
...
builder/hyperone: Allow skip chroot device discovery
2020-07-01 15:48:03 -07:00
Joshua Foster
63f9282f5c
fix vshere ToolsSyncTime and ToolsUpgradePolicy
2020-07-01 13:58:50 -04:00
Moss
41edd09d3c
undocument temporary_key_pair_name and ssh_private_key_file
2020-07-01 16:33:18 +02:00
Megan Marsh
af9d2e6f22
Merge pull request #9509 from hashicorp/fix_9508
...
make statement an array of strings
2020-06-30 13:15:51 -07:00
Megan Marsh
50c65847d1
Merge pull request #9497 from ad-m/hyperone-username
...
builder/hyperone: Add support for custom username in vm create
2020-06-30 10:51:25 -07:00
Megan Marsh
122e80f591
generated code
2020-06-30 10:12:50 -07:00
Megan Marsh
0122530a07
make statement an array of strings
2020-06-30 10:01:49 -07:00
Roman Tomjak
212200c88f
Proxmox NIC firewall flag ( #9487 )
...
* add test for firewall toggle
* generate hcl config
* send firewall toggle to proxmox
* update docs
* drop the pointer to bool
* use setDeviceParamIfDefined
2020-06-30 11:04:19 +02:00
Adam Dobrawy
80d49a1509
builder/hyperone: Add support for custom username in vm create
2020-06-29 03:17:38 +02:00
Adam Dobrawy
4692cdd55c
builder/hyperone: Allow skip chroot device discovery
2020-06-26 15:04:08 +02:00
Anthony Dong
2322d3ae6b
aws: retry fetching blockdevicemapping if empty
2020-06-25 10:48:24 +02:00
Wilken Rivera
85bffc40da
Merge pull request #9479 from hashicorp/fix_9475
...
only set up localhost port forwarding if skipnatmapping is false.
2020-06-24 14:11:23 -04:00
Megan Marsh
f8e21db9bc
Merge pull request #9450 from jhawk28/vsphere_multi_ip_wait
...
(vsphere) look at all IPs when waiting for the IP
2020-06-24 10:43:11 -07:00
Megan Marsh
cd5cf77998
only set up localhost port forwarding if skipnatmapping is false.
2020-06-24 10:40:42 -07:00
Wilken Rivera
38eef12b83
Merge pull request #9467 from ArseniiPetrovich/patch-1
...
Fix data disks URI
2020-06-24 11:50:58 -04:00
Wilken Rivera
8d209caf34
Fix spacing and line endings
2020-06-24 09:20:32 -04:00
Arsenii Petrovich
f3c33f9a27
remove spaces
2020-06-24 16:08:48 +03:00
mingsheng.su
8a8abdf615
update ucloud-uhost builder ( #9466 )
...
* update ucloud-uhost builder, docs and deps
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>
2020-06-24 14:31:05 +02:00
Ivo van Geel
e54ad3f1fb
Add boot_command support to vsphere-clone builder, including support … ( #9397 )
2020-06-24 11:14:30 +02:00
Arsenii Petrovich
c2f352ee6e
Update JSONs to fix tests and make them work with the latest URL changes
2020-06-24 01:35:35 +03:00
Wilken Rivera
a8dfb66d6c
docs/builder/amazon: Add WinRM unsupported note to Session Manager docs
...
Closes #9451
Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>
2020-06-23 07:41:21 -04:00
Arsenii Petrovich
d7b8d50acd
Fix data disks URI
...
Fixing bug appeared in 0589f57d4d
2020-06-23 12:58:53 +03:00
Adrien Delorme
b2320ca911
HCL2: add singular run_volume_tag block to ebs & ebssurrogate builders ( #9457 )
...
close #9280
related to #8889
2020-06-23 10:49:50 +02:00
Megan Marsh
a96194081a
Merge pull request #9453 from hashicorp/fix_ssh
...
Allow users to provide a list of ciphers that they want Packer to support.
2020-06-18 11:58:53 -07:00
Wilken Rivera
aa91ef7edf
Merge pull request #9455 from hashicorp/fix_9393
...
docs/builder/google: Add note about boolean values for compute instance metadata
2020-06-18 13:05:30 -04:00
Wilken Rivera
ce6284f760
docs/builder/google: Add note about boolean values for compute instance metadata
...
Closes #9393
2020-06-18 09:50:40 -04:00
Megan Marsh
801c827058
create parent dirs of target ( #9452 )
2020-06-18 10:25:04 +02:00
Megan Marsh
4f77bb0c4a
add new ssh_ciphers option
2020-06-17 16:48:23 -07:00
Megan Marsh
e951b3731a
Merge pull request #9441 from jhawk28/vsphere_httpip_default
...
use ip_wait_address range to determine the default for the http server IP
2020-06-17 14:46:04 -07:00
Joshua Foster
50b6c86b1c
look at all the IPs of the VM when waiting for an IP
2020-06-17 17:40:21 -04:00
Joshua Foster
dd40c68ff8
fix default IP address in test to all ipv4 addresses
2020-06-17 16:00:38 -04:00
Joshua Foster
fb159e7060
add test cases for Network
2020-06-17 11:40:39 -04:00
Gennady Lipenkov
5cb2ef6e9d
Fix test
2020-06-17 17:23:52 +03:00
Gennady Lipenkov
1157f0dcfe
Add acceptance test
2020-06-17 17:06:05 +03:00
Gennady Lipenkov
77ff387e25
Terraform code to quick provision instance with assigned SA.
...
Will be used for (local) acceptance test runs.
2020-06-17 16:23:54 +03:00
Gennady Lipenkov
a6ec1fa135
Support Instance SA authentication
2020-06-17 12:41:11 +03:00
Gennady Lipenkov
744fffab5d
Rename test data dir
2020-06-17 12:28:01 +03:00
Megan Marsh
88c94cc987
Fix 8904 ( #9435 )
2020-06-17 11:04:45 +02:00
Joshua Foster
7fc2ea8422
add a fallback to an ipv4 address if the the range can't find one
2020-06-17 01:46:30 -04:00
Joshua Foster
aaf9103330
use the ip_wait_address range to determine the default for the http server IP
2020-06-17 01:36:55 -04:00
Megan Marsh
4178625afb
re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.
2020-06-16 10:27:30 -07:00
Megan Marsh
004ace4340
Merge pull request #9406 from hashicorp/fix_9084
...
Add usb_driver to common boot_command and use it on vsphere
2020-06-15 15:55:54 -07:00
Calle Pettersson
0bcfefd0bc
Update Proxmox storagePoolTypes ( #9418 )
2020-06-15 14:00:32 +02:00
Moss
c1c350a657
remove comments
2020-06-12 14:51:52 +02:00
Moss
45058847c0
return BootConfig prepare err
2020-06-12 14:51:52 +02:00
Moss
653eb95bdb
adds tests to usb_driver and step_http_ip_discover
2020-06-12 14:51:52 +02:00
Moss
65cfb880fd
Fix boot_command and update docs
2020-06-12 14:51:52 +02:00
Moss
ba767d1663
remove duplicated press
2020-06-12 14:51:52 +02:00
Moss
585a86fe03
Add usb_driver to common boot_command and use it on vsphere
2020-06-12 14:51:52 +02:00
Charlie Kenney
70a2c7d364
upgrade linodego to v0.14.0 ( #9395 )
...
* upgrade linodego to v0.14.0
* fix builder/linode linter errors
* Update go.mod
Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>
2020-06-12 11:36:54 +02:00
Conlan
4afcc794be
Fix typo in VSphere Docs ( #9405 )
...
* Fix typo in VSphere Docs
* Update ConfigParamsConfig-not-required.mdx
Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>
2020-06-12 11:18:51 +02:00
Joshua Foster
e59fab952d
create the folders if they don't exist
2020-06-11 10:37:24 -04:00
Megan Marsh
8aeaf28bf3
Merge pull request #9380 from hashicorp/azr-docs-remove-duplicate-guest-additions-mode-docfield
...
docs: virtualbox/iso: remove duplicate guest_additions_mode field ( it's already defined in `GuestAdditionsConfig` )
2020-06-10 11:08:17 -07:00
Megan Marsh
dc14e6a1e2
Merge pull request #9390 from jhawk28/bug_8766
...
use datacenter inventory path for find folder
2020-06-10 10:52:17 -07:00
Megan Marsh
3a13eafa61
Merge pull request #9387 from arizvisa/GH-9382
...
Fixed a race in the ReadNetworkingConfig implementation from the vmware builders
2020-06-10 09:53:16 -07:00
Svetlin
49bf9c9d37
[gcp] Fixup for the deprecated Secure Boot guest OS feature ( #9371 )
...
GCP informed us that the GuestOsFeature SECURE_BOOT is deprecated and
that they are using UEFI_COMPATIBLE instead. This means, using an image
with 'UEFI_COMPATIBLE' guest OS feature confirms the 'secureBoot'
feature compatibility.
2020-06-10 16:21:11 +02:00
Joshua Foster
f5a795a22e
use path.Join to make a cleaner path
2020-06-10 09:12:21 -04:00
Joshua Foster
c7a6315ca4
use datacenter inventory path for find folder
2020-06-10 08:24:23 -04:00
Ali Rizvi-Santiago
3da5a64a8d
Fixed a race in the ReadNetworkingConfig implementation from the parsers belonging to the vmware builders that existed between reading the version and consuming tokens from the rest of the file.
2020-06-09 19:37:38 -05:00
Adrien Delorme
63896b98ec
docs: virtualbox/iso: remove duplicate guest_additions_mode field ( it's already defined in `GuestAdditionsConfig` )
2020-06-09 15:12:13 +02:00
Megan Marsh
5d67183c4c
fix test
2020-06-05 14:05:59 -07:00
Megan Marsh
48b448dfd5
Merge pull request #9366 from hashicorp/fix_9248
...
Add ToolSyncTime and ToolUpgradePolicy to vSphere
2020-06-05 13:03:58 -07:00
Megan Marsh
7fcd702b45
Merge pull request #9358 from jhawk28/bug_9349
...
(vsphere-iso) add the ability to check if the IP is within the an IP range
2020-06-05 12:18:51 -07:00
Megan Marsh
093cfcfd9f
Merge pull request #9322 from arizvisa/GH-8528
...
Fix the VMware builders when the guest platform's dhcpcd switches the ip address in-between a build
2020-06-05 10:58:00 -07:00
Ali Rizvi-Santiago
8985ba077c
Re-added the (mistakenly removed) host override to the CommHost for the vmware builders.
2020-06-05 12:39:20 -05:00
Megan Marsh
4cd3429914
add ssh override test
2020-06-05 10:15:11 -07:00
Moss
112638da01
Add ToolSyncTime and ToolUpgradePolicy to vSphere
2020-06-05 17:20:44 +02:00
Sylvia Moss
1422085ede
Validate host and network when looking for network ( #9361 )
2020-06-05 11:01:58 +02:00
Joshua Foster
d87e53b841
return false instead of continue to match logic from govmomi
2020-06-05 00:09:57 -04:00
Joshua Foster
3a6d42e0df
ip check should continue if the ip is NOT in the range
2020-06-04 23:17:02 -04:00
Joshua Foster
90463e5394
make default for wait address to be any ipv4 address. add some better documentation
2020-06-04 23:13:46 -04:00
Ali Rizvi-Santiago
9c5a65263f
Added @SwampDragons' suggestion to the `CommHost()` implementation for the vmware builders which uses the communicator config's `Config.Port()` function to determine the communication port-number independent of the configured protocol.
2020-06-04 19:04:12 -05:00
Megan Marsh
baed65156c
Merge pull request #9319 from arizvisa/GH-8528.refactor
...
This refactors the dhcpd lease parser in the vmware builders and adds unit tests for everything.
2020-06-04 12:18:49 -07:00
Joshua Foster
27a1ceef6d
add example for any ipv4 address
2020-06-04 12:15:53 -04:00
Sylvia Moss
aa52e690ee
Update go-getter and add samba shared files tests to step_download ( #8954 )
2020-06-04 15:00:18 +02:00
Ali Rizvi-Santiago
898321bcfe
Added suggestions from @SwampDragons to the parsers from the vmware builders, included unit-tests and sample file for fusion's networking file, and fixed a few situations where the channel wasn't being closed.
2020-06-04 05:07:18 -05:00
Joshua Foster
1fb22a7b7b
add the ability to check if the IP is within the an IP range
2020-06-04 01:55:25 -04:00
Joshua Foster
d35f342319
add the ability to configure the http bind address. defaults to 0.0.0.0.
2020-06-03 16:40:18 -07:00
Megan Marsh
02590f6c44
Merge pull request #9329 from hashicorp/je.website-maintenance-5-29-20
...
🌷 Website Spring Maintenance
2020-06-03 16:25:23 -07:00
Megan Marsh
f520ced2a8
Merge pull request #9356 from GennadySpb/remove-platform-validation-for-instances-with-gpu
...
Do not require 'gpu-standard-v1' platform_id for any GPU-based config.
2020-06-03 14:52:36 -07:00
Paul Meyer
e260212be3
Merge pull request #9323 [azure-chroot] copy data disks between shared image galleries
...
[azure-chroot] copy data disks between shared image galleries
2020-06-03 12:32:19 -07:00
Gennady Lipenkov
542819c464
Remove test
2020-06-03 21:17:12 +03:00
Gennady Lipenkov
df371b7e25
Do not require 'gpu-standard-v1' platform_id for any GPU-based config.
...
Support use another kind of GPU platforms.
2020-06-03 20:58:39 +03:00
Sylvia Moss
434c9bcae0
Check if task result is nil and return error ( #9354 )
2020-06-03 17:37:30 +02:00
Megan Marsh
df37918467
Merge pull request #9303 from arizvisa/GH-8528.unit-tests
...
Unit tests for the driver_parser.go functionality of the vmware builder
2020-06-02 15:28:13 -07:00
Jeff Escalante
f4d7b5f493
fix some stuff
2020-06-02 17:22:40 -04:00
Wei Cheng
e0cfb404fb
builder/googlecompute: add support to specify storage location for GCP images ( #9326 )
...
* feat: add support to specify storage location for GCP images
Signed-off-by: Wei Cheng <calvinpohwc@gmail.com>
2020-06-02 13:42:33 -04:00
Megan Marsh
e851757e5f
Merge pull request #9342 from jhawk28/bug_9328
...
(vsphere-iso) use the Datacenter's VmFolder
2020-06-02 10:24:48 -07:00
Sylvia Moss
ce45a1990a
Refactor communicator config for Qemu and add SkipNatMapping option ( #9307 )
2020-06-02 11:56:36 +02:00
Joshua Foster
30bff17799
use the Datacenter's VmFolder instead of hand generating it
2020-06-01 19:53:54 -04:00
RedTail72
374f82b978
buidler/vsphere-iso: ISOUrl Fix ( #9321 )
...
* ISOUrl Fix
Added the check for ISOUrls back in addition to a check for RawSingleISOUrl. This should allow both ISOUrls[] or ISOUrl to work while not requiring them all the time.
* Update config.go
Fixed formatting.
2020-06-01 15:27:26 -04:00
Ali Rizvi-Santiago
e5b6d8c37c
Didn't know that WinRM uses a different variable for the port number when trying to determine the communication host in `CommHost`...now it's fixed.
2020-05-30 02:17:21 -05:00
Megan Marsh
5efb1a195e
update docs for configuration_paramaters to explain what it actually is.
2020-05-29 15:07:34 -07:00
Jeff Escalante
9a38fbe2c7
patch source for a couple code block changes
2020-05-29 17:22:16 -04:00
Megan Marsh
184dc6cc44
Merge pull request #9260 from hashicorp/fix_9256
...
make package_include match output_vagrantfile parsing and abspath cal…
2020-05-29 10:41:26 -07:00
Megan Marsh
8a9833f5b1
Merge pull request #9287 from rgl/feature-qemu-add-timeout-wait-for-ip-address
...
builder/qemu: timeout waiting for the guest to become available in the network bridge
2020-05-29 09:47:06 -07:00
Paul Meyer
2288ab3b53
fix typo
2020-05-29 04:15:53 +00:00
Feiyu Shi
1c1991c073
fix a bug
2020-05-28 19:17:22 -07:00
Feiyu Shi
f86f5b958a
Merge remote-tracking branch 'origin/master' into identity
2020-05-28 19:03:44 -07:00
Megan Marsh
03b2c4355e
include Wilken's suggestion
2020-05-28 16:46:33 -07:00
Paul Meyer
53e5137411
[bug] Fix test error message
2020-05-28 23:38:17 +00:00
Paul Meyer
83851bc9aa
[bug] fix diskset type in Artifact creation
2020-05-28 23:38:17 +00:00
Paul Meyer
aa8250bcc8
give temp data disks lun suffix
2020-05-28 23:38:17 +00:00
Paul Meyer
4c96847683
log data disks in images
2020-05-28 23:38:17 +00:00
Paul Meyer
f0cd60b5fa
[bug] provide data disk prefix to disk creation
2020-05-28 23:38:17 +00:00
Paul Meyer
af96cf7881
Generated files
2020-05-28 23:38:14 +00:00
Paul Meyer
ac3d19ee23
Use separate caching/sku for data disks
2020-05-28 23:37:44 +00:00
Paul Meyer
f601f54d0b
Use all disks in managed image
2020-05-28 23:37:43 +00:00
Paul Meyer
de4839b66e
Use all snapshots when creating a shared image
2020-05-28 23:37:43 +00:00
Paul Meyer
c6b995a34d
create snapshots for all disks in a diskset
2020-05-28 23:37:43 +00:00
Paul Meyer
0ee77f8b0e
Add datadisks to disk set when using SIG as source
2020-05-28 23:37:43 +00:00
Paul Meyer
12f746b2b5
Move to using a diskset
...
Need to store lun numbers for data disks as well
2020-05-28 23:37:43 +00:00
Paul Meyer
3a3e6e525b
Shift names to diskset
...
Instead of one disk, we'll be working with a set of disks.
2020-05-28 23:37:43 +00:00
Paul Meyer
c9284d03aa
Add config for data disk/snapshot naming
2020-05-28 23:37:38 +00:00
Ali Rizvi-Santiago
229b5d17ff
Re-worked the vmware builder drivers so that they're able to check multiple ip addresses when trying to connect via the CommHost.
2020-05-28 15:36:45 -05:00
Ali Rizvi-Santiago
0609909f1a
Fixed some lint issues.
2020-05-28 13:53:49 -05:00
Ali Rizvi-Santiago
ad7194c920
Rewrote the GuestIP implementation in the vmware builder to use the new dhcpd lease parsers instead of the old regexp-based logic.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
020b005522
Finished implementing the final dhcpd lease entries parser for the vmware builders and also included its own unit tests.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
cf5332fa20
Updated the dhcpd lease entry parser in the vmware builder to return errors if any are encountered.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
afa4696985
Tightened the regular expressions used by the vmware builder to parse the dhcpd leases, and added support for parsing the weekdays.
2020-05-28 13:22:58 -05:00
Ali Rizvi-Santiago
e2a7c317eb
Implemented the dhcpd lease entry decoder and the address decoder for the vmware builder.
2020-05-28 13:22:57 -05:00
Ali Rizvi-Santiago
efb775accb
Added a number of parsing combinators to the vmware builder and some minor tests for them to help with parsing dhcpd leases.
2020-05-28 13:22:57 -05:00
Ali Rizvi-Santiago
f17007d546
Removed the sentinelSignaller chan from the vmware builder parsers and its unit-tests, and also commented all of the goroutines that are used.
2020-05-28 13:22:56 -05:00
Ali Rizvi-Santiago
159ea595df
More lint issues fixed...
2020-05-28 13:12:42 -05:00
Ali Rizvi-Santiago
32b64e0576
Fixed some lint issues in the unit tests for the vmware builder driver parsers.
2020-05-28 13:07:54 -05:00
Adrien Delorme
40947c2bf6
HCL2: generate hcl tags with go-cty tags too ( #9306 )
...
This will allow to generate the config files:
```go
package main
import (
"fmt"
"github.com/hashicorp/hcl/v2/gohcl"
"github.com/hashicorp/hcl/v2/hclwrite"
"github.com/hashicorp/packer/builder/alicloud/ecs"
)
func main() {
name := "name"
app := ecs.FlatConfig{
AlicloudImageName: &name,
ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{
DiskName: &name,
},
}
f := hclwrite.NewEmptyFile()
block := gohcl.EncodeAsBlock(&app, `source "something" "something"`)
f.Body().AppendBlock(block)
fmt.Printf("%s", f.Bytes())
}
```
Will output:
```
source "something" "something" {
packer_user_variables = null
packer_sensitive_variables = null
image_name = "name"
image_share_account = null
image_unshare_account = null
image_copy_regions = null
image_copy_names = null
tags = null
tag = null
system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri
ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_
snapshot_id = null }
image_disk_mappings = null
ssh_remote_tunnels = null
ssh_local_tunnels = null
ssh_public_key = null
ssh_private_key = null
}
```
This is a good first step for #9015 and #9282
fix #9304
2020-05-28 11:19:00 +02:00
Adrien Delorme
0fa60c68fb
Drop the iso_checksum_type & iso_checksum_url fields ( #8437 )
...
* Drop the iso_checksum_type & iso_checksum_url fields
In favor of simply using iso_checksum that will know what to do.
* fix after master merge
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* remove checksum lowercasing tests
* Update builder_test.go
* Update builder_test.go
* better docs
* Update builder_test.go
* even better docs
* Update config.go
* Update builder_test.go
* Update step_create_vmx_test.go
* make generate
* better docs
* fix imports
* up tests
* Update _ISOConfig-required.html.md
* Update builder_test.go
* don't use sha1.Sum("none") as a caching path
* Update builder_test.go
* better docs
* Update iso_config_test.go
remove ISOChecksumType/ISOChecksumURL references
* Update step_download_test.go
* add iso_checksum_url and iso_checksum_type fixers + tests
* add concrete examples of checksum values
* add examples of checksumming from local file
* update go-getter dep
* up deps
* use new go-getter version
* up ESX5Driver.VerifyChecksum: use go-getter's checksumming
* ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum
* Update iso_config.go
* get go-getter from v2 branch
* Update driver_esx5.go
add more comments
* Update driver_esx5.go
* show better error message when the checksum is invalid
* Update builder_test.go
put in a valid checksum to fix tests, checksum is md5("packer")
* Update builder_test.go
test invalid and valid checksum
* more test updating
* fix default md5 string to be a valid md5
* TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming
* Update iso_config_test.go
* Update iso_config_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update go.mod
* Update go.mod
* Update CHANGELOG.md
2020-05-28 11:02:09 +02:00
Joshua Foster
828440d852
rebase and run generate
2020-05-27 15:05:23 -07:00
Joshua Foster
43714049e8
add set_host_for_datastore_uploads flag
2020-05-27 15:00:08 -07:00
Joshua Foster
9895f90451
dont set the host for the datastore upload
2020-05-27 15:00:08 -07:00
Ali Rizvi-Santiago
2a8bc45bc4
Added unit-tests for the netmap parsing components in the vmware builder.
2020-05-26 23:03:30 -05:00
Ali Rizvi-Santiago
7c1ad4adcf
Added unit-tests for the dhcpd configuration components in the vmware builder, and fixed a few discovered race conditions.
2020-05-26 22:59:35 -05:00
Feiyu Shi
fdb0b2ab03
Revert "validate if user assigned identity exists"
...
This reverts commit 9bd19df040
.
2020-05-26 17:17:48 -07:00
Feiyu Shi
c016f3752a
upgrade SIG source api-version to match identity api-version to avoid potential setback for identity
2020-05-26 16:08:00 -07:00
Megan Marsh
01839e272e
Merge pull request #9277 from nitrocode/add-source-ami-creation-date
...
Added SourceAMICreationDate
2020-05-26 12:24:47 -07:00
nitrocode
6d29ec956b
Added SourceAMICreationDate
2020-05-26 15:04:03 -04:00
Rui Lopes
4839b9189d
builder/qemu: timeout waiting for the guest to become available in the network bridge
2020-05-26 07:46:06 +01:00
Feiyu Shi
3fdab998f8
check error
2020-05-25 12:33:33 -07:00
Megan Marsh
5dfd2a763e
send logs about floppy failure directly to UI not just logs ( #9272 )
2020-05-25 12:02:29 +02:00
Feiyu Shi
9bd19df040
validate if user assigned identity exists
2020-05-24 19:05:46 -07:00
Feiyu Shi
b334458b91
use empty struct for UserAssignedIdentities map value; omitempty
2020-05-24 19:05:45 -07:00
Feiyu Shi
c5e2eff847
change to []*Resource
2020-05-24 19:05:45 -07:00
Feiyu Shi
3e3fdaa24e
make generate
2020-05-24 19:05:45 -07:00
Feiyu Shi
76a7ab25e2
add SetIdentity test
2020-05-24 19:05:45 -07:00
Feiyu Shi
764f99ec7b
add correct api-version
2020-05-24 19:05:45 -07:00
Feiyu Shi
f7f033a7fd
add config validation test
2020-05-24 19:05:45 -07:00
Feiyu Shi
10b0a4548f
add identity resource id validation
2020-05-24 19:05:45 -07:00
Feiyu Shi
7c1a62dfed
set identity field in the template
2020-05-24 19:05:45 -07:00
Feiyu Shi
d9c9bfbae8
add identity field to the template
2020-05-24 19:05:45 -07:00
Feiyu Shi
b5b2982772
add user_assigned_managed_identities to the config
2020-05-24 19:05:45 -07:00
Megan Marsh
082d806b1f
fix httpip acquisition
2020-05-21 09:39:54 -07:00
Rui Lopes
06fad6cc4f
qemu: add support for using a network bridge
2020-05-20 16:46:32 -07:00
Megan Marsh
266bba279b
linting
2020-05-19 16:45:14 -07:00
Megan Marsh
aadd95497a
fix tests
2020-05-19 16:39:17 -07:00
Megan Marsh
a892d13d56
make package_include match output_vagrantfile parsing and abspath calculation
2020-05-19 16:32:54 -07:00
Megan Marsh
58b32ebefa
Merge pull request #9251 from hashicorp/fix_9249
...
builder/azure-arm: Update runtime constants with a valid DataDiskName
2020-05-19 11:00:44 -07:00
jhawk28
820f353573
(vsphere-iso) remove deprecated network and disk fields ( #9149 )
...
* remove deprecated network and disk fields
2020-05-19 10:06:12 -04:00
Sylvia Moss
1c30a71d09
Replace file shared state by statebag ( #9238 )
2020-05-19 11:49:48 +02:00
Wilken Rivera
c954831bb2
builder/azure-arm: Update runtime constants with a valid DataDiskName
...
This change fixes an issue where using the `disk_additional_size` configuration option would cause builds to fail.
Build results before the change
```
==> Builds finished but no artifacts were created.
Build 'azure-arm' errored: Code="DeploymentFailed" Message="At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details." Details=[{"code":"BadRequest","message":"{\r\n \"error\": {\r\n \"code
\": \"InvalidParameter\",\r\n \"message\": \"The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\\\\W][\\\\w-._]{0,79}(?\u003c![-.])$.\",\r\n \"target\": \"dataDisk.name\"\r\n }\r\n}"}]
```
Build results after change
```
Build 'azure-arm' finished.
==> Builds finished. The artifacts of successful builds are:
--> azure-arm: Azure.ResourceManagement.VMImage:
OSType: Linux
ManagedImageResourceGroupName: test-pkr
ManagedImageName: wilkenPacker9249
```
Closes #9249
2020-05-18 14:57:20 -04:00
Wilken Rivera
f31f5bc61b
docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
...
Closes #9199
2020-05-14 13:31:40 -04:00
Evan Digby
e4eaff6bba
s/Directoty/Directory ( #9221 )
2020-05-14 15:00:27 +02:00
Megan Marsh
0d900fd007
Merge pull request #9198 from hashicorp/fix_9190
...
don't error if metadata can't be set. Old versions of openstack don't…
2020-05-13 14:45:18 -07:00
Megan Marsh
a17ef01ea9
Merge pull request #9212 from andrewsomething/asb/do-image-id
...
builder/digitalocean: Use correct image type for Droplet creates.
2020-05-13 14:43:13 -07:00
Megan Marsh
37d953881f
Merge pull request #9219 from hashicorp/azr_autodoc_alicloud_pp
...
alicloud: better docs + autogenerated post processor docs
2020-05-13 14:41:44 -07:00
Andrew Starr-Bochicchio
84f0079c3a
Move to a new func to make testable.
2020-05-13 13:29:22 -04:00
Andrew Starr-Bochicchio
a1f334daff
Use constant and move check to template generator.
2020-05-13 13:28:44 -04:00
Andrew Starr-Bochicchio
bf0ab6b722
Force test to be skipped unless PACKER_ACC set.
2020-05-13 11:48:49 -04:00
Wilken Rivera
b5639d4697
tests/builder/amazon: Enhance the test coverage for SSM Tunnel related steps ( #9213 )
...
* test/builder/amazon: Update mocks to properly test SSM tunnel and driver code base
* Update mod files
2020-05-13 10:10:55 -04:00
Adrien Delorme
a50c27c05d
single `
2020-05-13 15:51:18 +02:00
Adrien Delorme
c2d3e494b6
alicloud: better docs + autogenerated post processor docs
2020-05-13 15:49:34 +02:00
Megan Marsh
fe472f45ae
don't put error in state, or we'll fail.
2020-05-12 16:51:40 -07:00
Megan Marsh
807a09a770
don't error if metadata can't be set. Old versions of openstack don't seem to play nicely with this API call
2020-05-12 16:51:40 -07:00
Wilken Rivera
6f5f6bf999
builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds
...
Tests before change
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1392ca2]
goroutine 299 [running]:
github.com/hashicorp/packer/builder/amazon/common.(*StepCreateSSMTunnel).Cleanup(0xc0003dc460, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/builder/amazon/common/step_create_ssm_tunnel.go:95 +0xf2
github.com/hashicorp/packer/helper/multistep.(*BasicRunner).Run(0xc0006e98f0, 0x4d408c0, 0xc00065fcc0, 0x4d1a4c0, 0xc0006e9800)
/home/wilken/Development/packer/helper/multistep/basic_runner.go:79 +0x2c6
github.com/hashicorp/packer/builder/amazon/ebs.(*Builder).Run(0xc000726800, 0x4d408c0, 0xc00065fcc0, 0x4d5e300, 0xc0006e8d80, 0x4cc7220, 0xc000434120, 0x0, 0x0, 0x0, ...)
/home/wilken/Development/packer/builder/amazon/ebs/builder.go:330 +0x17e2
github.com/hashicorp/packer/packer.(*CoreBuild).Run(0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/wilken/Development/packer/packer/build.go:287 +0x7ef
github.com/hashicorp/packer/command.(*BuildCommand).RunContext.func1(0xc0004d14d0, 0xc0003dc3c0, 0xc000441500, 0xa, 0x4d5e1e0, 0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, ...)
/home/wilken/Development/packer/command/build.go:290 +0x189
created by github.com/hashicorp/packer/command.(*BuildCommand).RunContext
/home/wilken/Development/packer/command/build.go:284 +0xd5a
FAIL github.com/hashicorp/packer/provisioner/shell 188.335s
FAIL
```
Test After change
```
--- PASS: TestShellProvisioner (212.39s)
--- PASS: TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner (212.39s)
PASS
```
2020-05-12 14:49:57 -04:00
Andrew Starr-Bochicchio
05d56034dd
builder/digitalocean: Add acceptance test for creating Droplet using image ID.
2020-05-12 14:15:35 -04:00
Andrew Starr-Bochicchio
374a29d75c
builder/digitalocean: Add logging of Droplet create attributes.
2020-05-12 12:38:51 -04:00
Andrew Starr-Bochicchio
80b4e0425e
builder/digitalocean: Use correct type for image for Droplet creates.
2020-05-12 11:46:58 -04:00
Andrew Starr-Bochicchio
e8783873d0
builder/digitalocean: Fix failing acceptance test.
2020-05-12 11:37:07 -04:00
Adrien Delorme
4ebcbad332
update consul and vault dependencies ( #9205 )
...
* update consul and vault dependencies
* update triton sign call accorting to https://github.com/joyent/triton-go/pull/135
* Delete readme.md
* put back github.com/mitchellh/reflectwalk to v1.0.0 and explain why
* fix/fixer_pp_docker_tag_tags.go: simplify deduplication loop and keep seen/stable order
2020-05-11 15:26:01 -04:00
Megan Marsh
480c938162
generate virtualbox-vm docs instead of letting them be copy pasted
2020-05-08 15:58:36 -07:00
Megan Marsh
4ef34f7fba
fix iso config prepare
2020-05-08 14:11:51 -07:00
Megan Marsh
9476aa03de
Merge pull request #9105 from hashicorp/google_iap
...
Implement iap proxy for googlecompute
2020-05-08 12:40:42 -07:00
Megan Marsh
fcef10fd2f
Merge pull request #9082 from hashicorp/f-amazon_builder-ssm-session-tunnel-poc
...
builder/amazon: Add SSM Session Manager as a SSH interface connection
2020-05-08 12:40:03 -07:00
Megan Marsh
a55b73473a
fix logic
2020-05-08 10:24:28 -07:00
Megan Marsh
dde162622d
use local port in listener config, when set
2020-05-08 10:20:47 -07:00
Megan Marsh
81e043f2b0
fix windows tests
2020-05-08 10:13:43 -07:00
Megan Marsh
60600e6cf6
make windows work with account files containing spaces
2020-05-08 10:13:43 -07:00
Megan Marsh
dae60799bc
fix tests
2020-05-08 10:13:43 -07:00
Megan Marsh
fda55fe928
deduplicate excess code
2020-05-08 10:13:43 -07:00
Megan Marsh
54b33ad8d1
fix tests
2020-05-08 10:13:43 -07:00
Megan Marsh
850303b8b8
get gcloud integration working on Windows
2020-05-08 10:13:43 -07:00
Megan Marsh
c578afc62c
working on windows
2020-05-08 10:13:43 -07:00
Megan Marsh
32752d4577
fix linting and tests
2020-05-08 10:13:43 -07:00
Megan Marsh
b5744efb42
add config prepare tests
2020-05-08 10:13:43 -07:00
Megan Marsh
f583674cd6
linding
2020-05-08 10:13:43 -07:00
Megan Marsh
4fc92d7858
add tests
2020-05-08 10:13:42 -07:00
Megan Marsh
937a4859d4
Make retries a bit smarter, clean up language to be gentler, and give up on parsing stdout for tunnel launch
2020-05-08 10:13:42 -07:00
Megan Marsh
3e1ddad0c7
fix behavior when not using IAP, try to use more sophisticated streaming than buffer.String()
2020-05-08 10:13:42 -07:00
Megan Marsh
9353635b43
send sigint instead of sigkill; we can at least ask the tunnel nicely to shut down.
2020-05-08 10:13:42 -07:00
Megan Marsh
f67a8ab431
revert unneeded changes to driver roles
2020-05-08 10:13:42 -07:00
Megan Marsh
80ecd2013d
basic untested implementation for Windows. May leave zombie processes lying around
2020-05-08 10:13:42 -07:00
Megan Marsh
3cd28e98a7
linting
2020-05-08 10:13:42 -07:00