Rickard von Essen
bd1961b927
Correctly fail if no Image matches filter
2018-08-21 12:46:42 +02:00
Tom Carrio
c5fe1e9e34
Updated to @rickard-von-essen's code review suggestions, including:
...
- filter build and error checking in Prepare stage (multiErr created in the original function will be returned to Prepare and appended, so all errors show).
- source_image overrides source_image_filter.
- Doc edit
2018-08-19 18:47:07 -04:00
Tom Carrio
5ca5c037eb
Updated filter parser to log all invalid values/fields provided by user
2018-08-19 18:45:22 -04:00
Tom Carrio
fc19cd8d28
Updated limit logic, removed limiter, updated test cases and sort field used
2018-08-19 18:45:22 -04:00
Tom Carrio
4147062802
Internally handling most_recent logic.
2018-08-19 18:45:22 -04:00
Tom Carrio
2d5d1890d4
Switching sort method
2018-08-19 18:45:22 -04:00
Tom Carrio
8d98237a15
I should have a git-status alias to make fmt
2018-08-19 18:45:22 -04:00
Tom Carrio
036918b81b
Updated to comments in PR#6490 - Thanks @haxorof
2018-08-19 18:45:22 -04:00
Tom Carrio
db3d2682b5
Updated allowed filters to tags, visibility, owner, and name. Test cases updated and passed
2018-08-19 18:45:22 -04:00
tcarrio
e9e58e6b2b
Tags field parsed from "tags" and updated test case
2018-08-19 18:45:22 -04:00
Tom Carrio
c8fd53d60b
make fmt
2018-08-19 18:45:22 -04:00
Tom Carrio
de9999ecb9
Updated tag to slice, docs, comments, only active images, source_image_name supercedes filter name
2018-08-19 18:45:22 -04:00
tcarrio
e776ad51a9
Removing statement from old image erroring logic
2018-08-19 18:45:22 -04:00
tcarrio
3a6ab0fc0e
Updated test logic and Error->Errof for formatted output.
2018-08-19 18:45:22 -04:00
tcarrio
6dc71590eb
Updated OpenStack Builder docs and tests
2018-08-19 18:45:22 -04:00
tcarrio
94018c691c
Fixed step interface, added step to builder, passing all tests for new image_query.go
2018-08-19 18:45:22 -04:00
Tom Carrio
a87c8fec38
Fixing up reflection issues on ListOpts builder
2018-08-19 18:39:42 -04:00
Tom Carrio
810a602a1b
Added testing on query helper functions
2018-08-19 18:39:42 -04:00
Tom Carrio
33caed3531
Completed filters and most_recent processing using OpenStack imageservice API
2018-08-19 18:39:42 -04:00
Megan Marsh
5dbd71b857
Merge pull request #6593 from hashicorp/iso_inplace
...
allow to use ISO images in-place v.s. copying them
2018-08-17 10:27:50 -07:00
Andrei Ozerov
6bf442f039
OpenStack builder: fix floating IP docs
...
Update website documentation about "floating_ip_network" parameter.
Add new inline comment about alghoritm that is used for checking
floatingIP-related configuration parameters.
2018-08-17 07:55:31 +03:00
Andrei Ozerov
103403db48
OpenStack builder: do not always use floating IPs
...
Only associate floating IPs if user provided "floating_ip_network" or
"floating_ip".
Remove FindExternalNetwork helper method because it won't be used.
2018-08-17 00:49:06 +03:00
Andrei Ozerov
5d6ba4301d
OpenStack builder: fix floating_ip_pool validation
...
Only use "floating_ip_pool" if "floating_ip_network" wasn't set.
Update unit test for the OpenStack builder parameters.
2018-08-17 00:15:18 +03:00
Andrei Ozerov
1af899248b
OpenStack builder: allow floating IP network name
...
Add support for the external network reference by it's name apart from
ID.
Include external network id in a log message of
the openstack/step_allocate_ip.
2018-08-16 23:38:41 +03:00
Andrei Ozerov
c9047cbfbe
OpenStack builder: update floating IP params
...
Rename "floating_network" to the "floating_ip_network".
Return old "floating_ip_pool" parameter for backward compatibility with
old configuration files. It's value will be passed to the
"floating_ip_network" parameter.
2018-08-16 22:18:48 +03:00
Andrei Ozerov
0eef9b4292
OpenStack builder: floating IP refactoring
...
Remove usage of the deprecated OpenStack Compute service floating IP
management and add methods to work with the OpenStack Networking
service floating IPs API.
Remove usage of the deprecated OpenStack Compute service floating IP
pools and add methods to work with the OpenStack Networking service
external networks API.
Move reusable logic of working with the OpenStack Networking service API
to a separate methods in the networking.go file.
Pass error messages from the API services to the ui messages in the
allocate IP step.
2018-08-16 22:15:26 +03:00
zhuzhih2017
2eafdb33a2
Merge pull request #6588 from xiaozhu36/master
...
Support describing and checking source image coming from marketplace
2018-08-16 20:58:52 +08:00
Andrei Ozerov
3316d40527
OpenStack builder: make volume type optional
...
Volume type parameter should be optional as described in API reference:
https://developer.openstack.org/api-ref/block-storage/v3/#create-a-volume
It should be enforced by the OpenStack cluster if not specified.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
572cdeecd1
OpenStack builder: create image from blockstorage
...
Allow to create final image from the Block Storage service volume.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
c0ffe7eb89
OpenStack builder: add StepDetachVolume
...
Add a step of detaching Compute instance volume if it's created using
the Block Storage service.
It is needed to create a final image.
This commit also moves common volume functions to a different file and
fixes some messages in the StepCreateVolume.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
005f7e56a7
OpenStack builder: cleanup blockDeviceMappingV2
...
There is no need to indicate type of the list elements, remove it.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
d51e683bf7
OpenStack builder: add Block Storage volumes
...
This commit allows user to use the Block Storage v3 volume as the
Compute instance root volume.
Also it adds new volume-related parameters to the builder.
2018-08-16 12:40:11 +02:00
Megan Marsh
ac3554a37f
Merge pull request #6594 from rickard-von-essen/mode-check
...
Check that only certain files are executable
2018-08-15 13:07:00 -07:00
Megan Marsh
3362897c44
Merge pull request #6585 from hashicorp/do_6584
...
fix security hole with ami filter
2018-08-15 10:26:40 -07:00
Rickard von Essen
074b170ed4
Fixed exec bit
2018-08-15 16:13:34 +02:00
Rickard von Essen
25452945d7
Merge pull request #6546 from mzupan/do-add-tags
...
Add tags to DigitalOcean Droplets
2018-08-15 15:52:32 +02:00
Adrien Delorme
17f2949e36
remove stuttering; ISOConfig.InplaceISO -> Inplace
2018-08-15 15:51:25 +02:00
Rickard von Essen
889c89ec79
Validate tags
2018-08-15 15:27:00 +02:00
Adrien Delorme
82e480a285
allow to use ISO images inplace v.s. copying them
2018-08-15 14:37:38 +02:00
Rickard von Essen
9e9f0d2ab9
Merge pull request #6570 from cb-oath/openstack-builder-ports
...
add support for ports to the OpenStack builder
2018-08-15 13:35:48 +02:00
Rickard von Essen
c962e7b856
Simplified loop code
2018-08-15 13:12:47 +02:00
Megan Marsh
71cad4f2a9
fix tests
2018-08-14 12:30:05 -07:00
He Guimin
1a17b799f1
Support describing and checking source image coming from marketplace
2018-08-15 00:14:02 +08:00
Megan Marsh
250da0ab49
fix security hole with ami filter
2018-08-13 17:01:13 -07:00
Christopher Boumenot
39fc8593de
Merge pull request #6576 from double16/vagrant-azure
...
Add to vagrant post-processor support for Azure
2018-08-09 12:36:22 -07:00
Patrick Double
2868971a9b
Fixes per code review
2018-08-09 07:14:14 -05:00
Patrick Double
d796edc783
Add to vagrant post-processor support for Azure
2018-08-08 10:04:28 -05:00
Megan Marsh
5585855265
Merge pull request #5165 from bennu/esxi-remote-cache
...
vmware-iso:esxi5 using ISO files uploaded by packer to datastore
2018-08-06 14:31:19 -07:00
Megan Marsh
99d1a1a297
Merge pull request #6541 from rsclarke/qemu-ssh-agent
...
add ssh agent support for qemu builder
2018-08-06 13:43:26 -07:00
Megan Marsh
57dd1c3ca2
Merge pull request #6543 from thedrow/lxc-root-path
...
Determine lxc root according to the running user
2018-08-06 11:34:01 -07:00