Commit Graph

11607 Commits

Author SHA1 Message Date
Stephen Fox 415ef26768 Removed TODO about key pair description per review feedback. 2019-02-28 09:30:30 -05:00
Chris Marget 0f1bde760c
Merge pull request #4 from stephen-fox/refactor-ssh-key-pair-logic
Initial take on code review feedback from @azr.
2019-02-27 17:05:44 -05:00
Stephen Fox 2ef6b9247d Initial take on code review feedback from @azr.
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
2019-02-25 17:16:24 -05:00
Stephen Fox 2ab2ea6ef1 Fixed interface documentation typo. 2019-02-12 10:29:43 -05:00
Stephen Fox ed1d224b97 Remove defaultKeyPair type. Be more specific in errors. 2019-02-07 11:09:53 -05:00
Chris Marget 08eb4615d4
Merge pull request #2 from stephen-fox/vbox-doc-issue-7225
Initial documentation for VirtualBox SSH key pair vars.
2019-02-06 16:10:49 -05:00
Stephen Fox 0378f3ad35 Initial documentation for VirtualBox SSH key pair vars. 2019-02-06 16:03:40 -05:00
stephen-fox b7719650ae
Merge pull request #1 from stephen-fox/parse-user-supplied-keypair
Parse user supplied keypair
2019-02-06 15:07:04 -05:00
chris marget 97268b3041 . 2019-02-06 15:05:56 -05:00
chris marget 3515afa994 better variable names in test function 2019-02-06 14:39:39 -05:00
chris marget 75bd3c6951 constants don't need to be [P]ublic 2019-02-06 14:36:38 -05:00
chris marget b476e54db1 whitespace 2019-02-06 14:34:09 -05:00
chris marget be01ca70f4 on error return empty defaultKeyPair{} rather than nil 2019-02-06 14:02:26 -05:00
chris marget 484aa4768f Remove unused keyheader data type 2019-02-06 13:58:26 -05:00
chris marget 53c0376dfd don't print keypair to the user's screen 2019-02-06 13:54:05 -05:00
chris marget 13cc73d600 keypair parsing and testing 2019-02-06 13:46:55 -05:00
Stephen Fox 354fcc5cc6 Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'. 2019-02-05 16:16:51 -05:00
Stephen Fox 72b7d63a6a Restructured the SSH key pair's description.
Now include the key pair name (if any), and make it more "readable".
2019-02-05 13:37:09 -05:00
Stephen Fox e40aa515f2 Added TODO about public key removal logic. 2019-02-05 12:00:01 -05:00
Stephen Fox f9d24ccda0 Allow user to get public key straight up, or URL encoded. 2019-02-05 11:59:13 -05:00
Stephen Fox 4b649f7ce4 Use individual key pair implementations.
This allows us to store more information about the key pair.
In particular, we can query the private key for its bits of
entropy - avoiding the possibility of hardcoding the wrong value.
2019-02-05 11:53:12 -05:00
Stephen Fox d7510ecdf7 Tweaked 'PublicKeyAuthorizedKeysLine()' comment. 2019-02-05 09:54:38 -05:00
Stephen Fox 58c692a587 Get bits from private key rather than user input. 2019-02-05 09:52:46 -05:00
Adrien Delorme 9787e787d4
Merge pull request #7276 from paulmey/fix-7267
Fix Azure interactive authentication
2019-02-05 10:34:50 +01:00
Paul Meyer 68516fc05c Fix Azure interactive authentication
Builder looks up tenant ID before asking for token. Client config did
not allow that. Also found that token provider was not properly
initialized.

Fixes 7267
2019-02-05 02:35:12 +00:00
Megan Marsh 9f93fb2748
Merge pull request #7264 from rhtyd/go-cloudstack-vendor-update
vendor: update go-cloudstack v2.4.1
2019-02-04 14:02:01 -08:00
Megan Marsh ee2ed063e9
Merge pull request #7265 from danowar2k/master
FIX for PR #7254
2019-02-04 13:58:06 -08:00
Megan Marsh 2d3f84abf0
Merge pull request #7271 from hashicorp/make_generate
make generate
2019-02-04 13:11:24 -08:00
Stephen Fox f3128143fa Simplified building of authorized_keys public key. 2019-02-04 14:27:59 -05:00
Stephen Fox f2c11b55be Renamed authorized_keys public key function. 2019-02-04 14:27:14 -05:00
Stephen Fox d465231e63 Fixed bad curve ecdsa curve bug. 2019-02-04 14:25:37 -05:00
Rickard von Essen 36546c5dfe
Merge pull request #7274 from rickard-von-essen/ansible-docs
Ansible docs
2019-02-04 20:19:39 +01:00
Stephen Fox 9328c9f9e0 Renamed "new*" SSH key pair methods. 2019-02-04 14:12:18 -05:00
Megan Marsh 6c2e60ffa9
Merge pull request #7266 from hashicorp/fix_7259
quote variables in powershell script to account for spaces
2019-02-04 10:34:55 -08:00
Rickard von Essen 26aa0144e6
ansible: Change the doc navigator to Ansible (Remote) 2019-02-04 18:56:52 +01:00
Stephen Fox ea2a7c3fe9 Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'. 2019-02-04 12:47:42 -05:00
Rickard von Essen 52b55fb899
ansible: change local_port to uint instead of string 2019-02-04 18:47:42 +01:00
Stephen Fox 01c98f3d82 Tweaked debug SSH private key file name for vbox. 2019-02-04 12:47:18 -05:00
Stephen Fox f8db84334d Alias 'golang.org/x/crypto/ssh' as 'gossh'. 2019-02-04 12:29:47 -05:00
Stephen Fox 9a9bc18fab Renamed SSH key pair source files per pattern.
There appears to be a pattern of naming SSH key pair related
source files "*_key_pair*".
2019-02-04 12:25:00 -05:00
Stephen Fox 7f6b307dd6 Remove 'Ssh' suffix from 'KeyPairType' constants. 2019-02-04 12:23:42 -05:00
Stephen Fox c6ae8654d9 Moved SSH key pair code into 'helper/ssh'. 2019-02-04 12:21:58 -05:00
Rickard von Essen 6d700d34df
ansible: some doc style fixes 2019-02-04 18:21:44 +01:00
Stephen Fox 25775886a8 Properly set SSH key pair name. 2019-02-04 12:12:18 -05:00
Stephen Fox 4c2851013e Fixed 'sed' regex to remove public key by magic string. 2019-02-04 12:10:17 -05:00
Stephen Fox be081944b1 Moved new key pair funcs closer to builder funcs. 2019-02-04 12:09:23 -05:00
Stephen Fox b1b67ecffa Added support for setting a name in SSH key pair.
Also refactored how new SSH key pairs are created, and how the
tests are structured.
2019-02-04 12:07:32 -05:00
Stephen Fox 5893134c61 Updated comment for 'PrivateKeyPemBlock()'. 2019-02-04 10:02:07 -05:00
Adrien Delorme 8621949e01 make generate 2019-02-04 15:16:38 +01:00
Adrien Delorme 9f1ec211a0
Merge pull request #7268 from mayn/docs-updates-v144
docs - minor fixes
2019-02-04 10:45:20 +01:00