DanHam
4cc078256d
Fixer for templates affected by auto escape of special powershell chars
2018-02-08 12:03:19 +00:00
DanHam
2d830d5d43
Auto escape chars special to PowerShell in user supplied data
2018-02-08 12:03:19 +00:00
DanHam
aaf7102b9a
Tests for escape of chars special to PowerShell in user supplied data
2018-02-08 12:03:18 +00:00
DanHam
e982bc4ea5
Fix copy/paste of description from shell provisioner
2018-02-08 12:03:18 +00:00
DanHam
2b1aa04583
Update docs to reflect new upload and dot source of env var for std ps cmd
2018-02-08 12:03:18 +00:00
DanHam
a7b118ed94
Fix tests post changes. Add test for upload func.
2018-02-08 12:03:18 +00:00
DanHam
478589abec
Extend upload and subsequent 'dot sourcing' of env vars to std PS command
...
* Wrap funcs to flatten and upload env vars with new func prepareEnvVars.
While the wrapped funcs could be combined, keeping them separate
simplifies testing.
* Configure/refactor std and elevated PS to use new funcs to prepare,
upload and dot source env vars.
* Dot sourcing the env vars in this way avoids the need to embed them
directly in the command string. This avoids the need to escape the env
vars to ensure the command string is correctly parsed.
* Characters within the env vars that are special to PS (such as $'s
and backticks) will still need to be escaped to allow them to be
correctly interpreted by PS.
* The std and elevated PS commands now inject env vars into the remote
env via the same mechanism. This ensures consistent behaviour across the
two command types.
Fixes #5471
2018-02-08 12:03:18 +00:00
Matthew Hooker
84190acec7
Merge pull request #5869 from Daemoen/bugfix-5852
...
Bugfix 5852
2018-02-07 19:57:09 -08:00
Marc Mercer
d3c7d43f20
Small typo correction
2018-02-07 19:47:01 -08:00
Marc Mercer
5d67f77f43
Fixing 5852
2018-02-07 19:41:01 -08:00
Matthew Hooker
5b5210837f
Merge pull request #5867 from hashicorp/atlas-dep
...
add atlas deprecation warnings.
2018-02-07 19:19:38 -08:00
Matthew Hooker
c03ce222b2
add atlas deprecation warnings.
2018-02-07 15:45:00 -08:00
Matthew Hooker
51dcf9ffb1
Merge pull request #5864 from hashicorp/workaround_5257
...
add workaround for azure bug.
2018-02-07 13:38:53 -08:00
Megan Marsh
974d9974fe
add workaround for azure bug.
2018-02-07 11:34:18 -08:00
Matthew Hooker
735d2511c6
Merge pull request #5858 from hashicorp/fix_winrm_azure
...
use winrmcp logic when creating new winrm client for uploads and down…
2018-02-07 11:14:57 -08:00
Megan Marsh
f8f256354f
use winrmcp logic when creating new winrm client for uploads and downloads
2018-02-07 09:56:10 -08:00
Matthew Hooker
11846b5152
Merge pull request #5859 from jamesearl/fix-docs-chroot-mounts
...
fix docs mountpoint typo
2018-02-06 22:47:04 -08:00
James Cunningham
2ae73162e5
fix docs mountpoint typo
2018-02-06 19:58:54 -07:00
Matthew Hooker
578de6ea89
update changelog
2018-02-06 17:39:28 -08:00
Edward
c918e4113f
Add the version note in OpenStack builder section
2018-02-06 17:36:48 -08:00
Edward
c29e5de381
Remove the deprecated extensions
...
The Nova extension API was deprecated from OpenStack N release.
this parts of code cannot work well with the newest OpenStack version.
This patch is to remove the relative parts:
1. Remove the step_load_extensions.go
2. Remove the step of extension from builder.go
3. Remove the parameter parsing from step_stop_server.go
Resolves : #5581
2018-02-06 17:36:47 -08:00
Matthew Hooker
8510f072a9
Merge pull request #5841 from hashicorp/fix5447
...
Add volume and run tags if in us-gov/china
2018-02-05 17:29:12 -08:00
Matthew Hooker
21812fa17f
Add volume and run tags if in us-gov/china
...
We can't tag on instance creation when we're in "restricted" regions,
so let's add the tags after the resources have been created.
Adds methods to AccessConfig to detect if we're in China or US Gov
regions (i.e. "restricted").
Also turns tag:tag maps into a type, and moves methods around validating
and converting them to ec2Tags to methods of the type.
2018-02-05 16:39:20 -08:00
Matthew Hooker
b651571b30
update changelog
2018-02-05 15:44:25 -08:00
Matthew Hooker
ff64ccda55
Merge pull request #5426 from hashicorp/fix_4915
...
Fix 4915
2018-02-05 14:54:27 -08:00
Matthew Hooker
8827df1ed2
update go-aws-sdk to v1.12.71
2018-02-05 14:21:44 -08:00
SwampDragons
7d5d62d748
Merge pull request #2906 from arizvisa/GH-2377
...
Improved support for downloading and validating a uri containing a Windows UNC path or a relative file:// scheme
2018-02-05 09:53:47 -08:00
Matthew Hooker
79ef50327b
Merge pull request #5842 from KohlsTechnology/googlecompute-licenses
...
Support specifying licenses for Google Compute images
2018-02-05 09:52:07 -08:00
Matthew Hooker
625201c819
Merge pull request #4148 from minimum2scp/features/googlecompute-export-application-default-credential
...
googlecompute-export: use application default credential
2018-02-05 09:51:21 -08:00
Sean Malloy
22deb5045d
Remove extra new line from googlecompute docs
2018-02-04 01:16:34 -06:00
Sean Malloy
c75db88f6b
Add documentation for new googlecompute builder image_licenses configuration option
2018-02-03 15:56:29 -06:00
Sean Malloy
1c9f18603c
Fix Google Compute Builder Documentation
...
Added required configuration option ssh_username to basic config
example.
2018-02-03 15:32:10 -06:00
Petr Hosek
eaef2961cb
Support specifying licenses for Google Compute images
...
This is needed to enable features such as the nested virtualization:
https://cloud.google.com/compute/docs/instances/enable-nested-virtualization-vm-instances
2018-02-03 14:15:16 -06:00
Ali Rizvi-Santiago
9eb2f37429
Ack! Forgot to include the test-fixtures/SomeDir/myfile.txt file...
2018-02-02 20:44:22 -06:00
Ali Rizvi-Santiago
d4b00b722a
Removed an extra '/' from the TestFileExistsLocally test in common/config_test.go
2018-02-02 20:36:08 -06:00
Ali Rizvi-Santiago
efc97dbda2
Fixed TestFileExistsLocally tests in common/config_test.go so that they're actually being run. Added a non-existent-protocol:// test.
2018-02-02 20:29:10 -06:00
Ali Rizvi-Santiago
c366a1e160
Inverted the logic of FileExistsLocally as suggested by @SwampDragons as remote URLs are assumed to exist locally.
2018-02-02 20:17:24 -06:00
Ali Rizvi-Santiago
c98a074f0d
Renamed common/config.go's SupportedURL to SupportedProtocol as suggested by @SwampDragons.
2018-02-02 18:58:42 -06:00
SwampDragons
ff1ffd90e0
Merge pull request #5840 from hashicorp/docs-oracle-builders
...
group oracle builders under a single heading.
2018-02-02 14:31:33 -08:00
SwampDragons
8ae8f31a52
Merge pull request #5681 from mcandre/super-key
...
add super key (vmware builder)
2018-02-02 13:33:11 -08:00
Matthew Hooker
399431c00b
group oracle builders under a single heading.
2018-02-02 12:39:45 -08:00
SwampDragons
997f8e4a2a
Merge pull request #5318 from hashicorp/sigtermcleanup
...
Gracefully clean up on SIGTERM
2018-02-02 11:56:56 -08:00
SwampDragons
caea770af1
Merge pull request #5819 from hashicorp/oracle-oci-builder
...
Oracle oci builder
2018-02-02 11:56:18 -08:00
SwampDragons
736e17d198
Merge pull request #5822 from SharePointOscar/master
...
Updated to use latest Azure CLI
2018-02-02 11:55:35 -08:00
Matthew Hooker
56c5216efb
Merge pull request #5839 from hashicorp/fix-freebsd-vagrant
...
vagrant: Correct name of vim package for FreeBSD
2018-02-02 11:26:59 -08:00
James Nugent
c132bd867e
vagrant: Correct name of vim package
...
The non-X11-linked version of vim recently changed name from vim-lite to
vim-console, which was preventing bootstrap.
2018-02-02 13:14:13 -06:00
Megan Marsh
addedbb680
Revert "Merge pull request #5515 from DanHam/dot-source-env-vars"
...
revert so we can use a branch that's had more recent work done
This reverts commit e56849c605
, reversing
changes made to 6d14eb6ea4
.
2018-02-02 09:58:39 -08:00
Megan Marsh
79fe900378
Revert "Merge pull request #5376 from DanHam/ps-escapes"
...
Revert so that we can merge a different branch that's had more recent work instead
This reverts commit ba518637d4
, reversing
changes made to e56849c605
.
2018-02-02 09:57:36 -08:00
Megan Marsh
30a4998a81
branding
2018-02-01 16:35:10 -08:00
SwampDragons
ec64cb3a1e
Merge pull request #5709 from BenPhegan/hyperv_mac_address
...
Allow MAC address specification for HyperV Builders
2018-02-01 16:23:29 -08:00