77817f80a2
Merge pull request #9956 from hashicorp/do_6734
...
builder/qemu: Add qemu_img_args option to set special cli flags for our calls to qemu-img
2020-09-18 11:24:34 -07:00
b7b43a41f3
review cleanup
2020-09-18 10:56:28 -07:00
778d77e4a2
add floppy and cd to vsphere-clone
2020-09-18 17:09:01 +02:00
d347bbec4c
Retry fleet creating only on invalid IAM instance profile ( #9946 )
2020-09-18 17:05:36 +02:00
eca9b2f30d
aws ebs_surrogate: fix unhonored kms_key_id ( #9959 )
2020-09-18 12:39:07 +02:00
ce2047f30b
vSphere StepAddCDRom tests ( #9955 )
2020-09-18 09:57:01 +02:00
1d218d9e65
add QemuImgArgs option to set specialized flags in qemu-img
...
convert, resize, and create commands. Add tests. Refactor steps to
not require config pulled from statebag.
2020-09-17 15:15:04 -07:00
1052733fca
Skip qemu-img convert if format of output file matches format of input file.
...
This works around an osx bug in qemu-img convert in osx.
2020-09-17 11:21:04 -07:00
83ee4e7d13
miscellaneous qemu cleanup. Fix generator strings; generate code
...
fix diskimage logic
linting
fix tests
2020-09-17 09:57:45 -07:00
3577c4a283
refactor multistep array construction in qemu builder to push majority of conditionals into their steps rather than the multistep constructor code.
2020-09-17 09:57:45 -07:00
9ac76be190
clean up step_run
2020-09-17 09:57:45 -07:00
5b714497e6
qemu: split config and config tests into their own files to match best practices from other builders
2020-09-17 09:57:45 -07:00
6c0c603fbf
stub out test
2020-09-17 09:57:45 -07:00
9737b85bbc
Remove usb_keyboard option ( #9945 )
2020-09-17 10:38:33 +02:00
b4be598148
Fix static check issues SA1019 for googlecompute plugins ( #9950 )
...
This change replaces the deprecated constructors `New` with
`NewService`.
Static check before the change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google
- post-processor/googlecompute-import/post-processor.go:183:18: SA1019:
storage.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- post-processor/googlecompute-import/post-processor.go:219:18: SA1019:
compute.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- post-processor/googlecompute-import/post-processor.go:273:18: SA1019:
storage.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- builder/googlecompute/driver_gce.go:127:18: SA1019: compute.New is
deprecated: please use NewService instead. To provide a custom HTTP
client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- builder/googlecompute/driver_gce.go:132:25: SA1019: oslogin.New is
deprecated: please use NewService instead. To provide a custom HTTP
client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
```
Static check after change
```
[go-1.15.2] [1] wilken@automaton in ~/Development/packer/
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google
```
2020-09-17 10:14:41 +02:00
7736ae6c67
Add VMware vnc_over_websocket option ( #9938 )
2020-09-16 11:02:46 +02:00
bdd736b800
Interpolate vagrantfile_template on Vagrant post-processor ( #9923 )
2020-09-16 10:08:44 +02:00
bc69db2433
Merge pull request #9941 from hashicorp/cd_files_vsphere
...
add cd_files to vsphere builder
2020-09-15 11:25:01 -07:00
ef01bb5ba6
generated code
2020-09-14 15:35:38 -07:00
e70e8c8651
add cd_files
2020-09-14 14:59:51 -07:00
5d15f5e2f4
No longer need a 15 second sleep
2020-09-14 13:36:26 -07:00
f28cabb162
Merge pull request #9940 from hashicorp/fix_9936
...
skip slot 7 in disk creation so we don't use reserved slot
2020-09-14 13:36:16 -07:00
b08dd28b85
skip slot 7 in disk creation so we don't use reserved slot
2020-09-14 13:13:59 -07:00
e00f6afff8
Merge pull request #9918 from hashicorp/fix_7408
...
skip compaction when backing file is used, to prevent conversion that…
2020-09-14 13:09:13 -07:00
6d2df7fb55
Merge pull request #9932 from hashicorp/cd_files_on_virtualbox
...
Implement cd_files for virtualbox builders.
2020-09-14 13:08:23 -07:00
3c9969d841
cleanup goimports for linter
2020-09-14 12:49:38 -07:00
eab7672519
regenerate code
2020-09-14 12:16:56 -07:00
e723609ef1
regenerate hcl config
2020-09-14 12:16:56 -07:00
6935f47809
add tests for disk defaulting
2020-09-14 12:16:56 -07:00
eae3fda901
refactor out disk defaulting so it can be used to default the vmx cdrom too
2020-09-14 12:16:56 -07:00
9140985ab0
implement cd_files for qemu builder
2020-09-14 12:16:56 -07:00
f774983d36
implement on hyperv
2020-09-14 12:16:56 -07:00
018a1a5da0
Correct full clone logic
2020-09-14 12:15:07 -07:00
681d0f8467
Correct builder ID
2020-09-14 11:59:47 -07:00
99c3872a48
run go fmt
2020-09-14 11:58:50 -07:00
698bef434f
track whether we've detached disks so we don't duplicate work
2020-09-14 11:00:35 -07:00
a92491d17b
capitalization
2020-09-14 10:40:07 -07:00
c032d463d3
Bootcommand Fix For Proxmox Builder ( #9885 )
2020-09-14 17:17:38 +02:00
caf65781d7
Add vsphere-clone mac_address option ( #9930 )
...
* add vsphere-clone mac_address option
* check on prepare if network is set together with mac_address
2020-09-14 13:18:39 +02:00
3739970b84
Adds ability to specify interfaces for http_directroy and VM for the Proxmox builder ( #9874 )
...
Adds two config options to the Proxmox builder:
```
http_interface
vm_interface
```
Both give the user the ability to specify an interface whos IP will be set as the `.HTTPIP` and VMIP respectively.
This is useful when the VM and or the machine executing Packer has multiple interfaces.
Until now Packer would accept the first non-loopback IP as the `.HTTPIP` and VMIP.
I'm open to suggestions and any kind of feedback.
* Added ability to define the NIC where the HTTPIP is taken from.
* Added VM interface config option
* fmt and documentation
* Moved HTTPInterface into HTTPCommon
* Build Fix
* Documentation Fix
2020-09-14 12:24:01 +02:00
aa5eb770d0
DEV: use proper interfaces for vmCreator
2020-09-11 16:45:16 -07:00
b73825bb72
Implement cd_files for virtualbox builders.
...
Since the work to mount isos was duplicated already across the
step_mount_iso and step_mount_guest_additions, this required a
refactor to prevent further code duplication and make the
ports and devices easier to follow
2020-09-11 16:23:29 -07:00
abdb4bcfbf
refactor: change ssh host to osc ssh host
2020-09-11 12:11:52 -05:00
645e5afa36
refactor: change bsuvolume builder to new SDK
2020-09-11 12:11:24 -05:00
b844b7f1c7
refactor: change bsusurrogate builder to new SDK
2020-09-11 10:38:13 -05:00
007f6cce4c
feat: add wait funtions for snapshot and omi in osc builders
2020-09-11 09:47:08 -05:00
31f08909b4
Add usb_scan_codes option to use USB scancodes instead of VNC for remote builds ( #9895 )
2020-09-11 16:46:33 +02:00
eed047b83b
feat: add proxy support to osc builder
2020-09-11 09:46:04 -05:00
cfece501d0
Implement proxmox-clone
2020-09-09 23:55:35 -07:00
8b9009c571
Merge pull request #9856 from OblateSpheroid/add_vnic_details
...
Feat (builder/oracle-oci): Add VNIC details to launch details
2020-09-09 16:15:48 -07:00
8ffa0d2060
Merge pull request #9842 from jason-azze/patch-1
...
Builders vsphere-iso and vsphere-clone - CPUs is actually for cores, not sockets.
2020-09-09 16:03:45 -07:00
ca650c9602
fix struct comment for generation
2020-09-09 16:01:30 -07:00
0a02bd5b2a
skip compaction when backing file is used, to prevent conversion that would make backing file pointless
2020-09-09 15:26:10 -07:00
9d5dedc3db
tests: add some fields to config_test
2020-09-09 09:25:58 -04:00
f8e31bff12
feat(builder): bump scaleway to new sdk ( #9902 )
2020-09-09 10:27:48 +02:00
0719f906d4
Replace if/else with simple if ( #9913 )
2020-09-09 10:24:17 +02:00
8aaa1bd7a6
Merge pull request #9796 from hashicorp/do_8778
...
create secondary iso containing user's desired files
2020-09-08 15:05:48 -07:00
dd54651125
fix (builder/oracle-oci): add freeform and defined tags to create_vnic_details
2020-09-08 14:40:21 -04:00
b4ff0ea4bc
[builder/qemu] Skip resize step when skip_resize_disk is enable #9860 ( #9896 )
...
* [builder/qemu] Skip resize step when skip_resize_disk is enable #9860
* Update builder/qemu/builder_test.go
Improve the code quality
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
* Update files for unit tests
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-09-08 14:32:08 -04:00
f5dc260cf5
refactor (builder/oracle-oci): pass CreateVnicDetails as struct instead of map
2020-09-08 12:03:18 -04:00
7335695c84
qemu vnc: hardcoded lowerbound leaves negative ports
...
```hcl2
vnc_port_min = 5000
vnc_port_max = 5500
```
Build returns faulty:
```
qemu.one: view the screen of the VM, connect via VNC to vnc://127.0.0.1:5138
(...)
2020/09/06 19:09:52 packer-builder-qemu plugin: Qemu stderr: qemu-system-x86_64: -vnc 127.0.0.1:-762,password: can't convert to a number: -762
```
2020-09-06 21:18:12 +02:00
905869308d
Split proxmox builder into a common part and iso/clone builders
...
Clone builder is still just a stub. Proof-of-concept for #9626
Signed-off-by: Calle Pettersson <calle@cape.nu>
2020-09-04 23:53:09 +02:00
d2dd158fe2
Implement cd_files option. The Addfile code is modified from the floppy_files
...
tooling. Tested on OSX, `Windows, and Linux. Documented command line dependencies.
Added acceptance tests (behind testacc flag, since there are dependencies).
This option is only implemented for the vmware and hyperv iso builders. It will be
implemented for others in later PRs in order to make review easier.
2020-09-04 12:20:19 -07:00
dfe8aa51b0
Merge pull request #9845 from hashicorp/run_and_stream_helper_func
...
move runAndStream into a generalized helper function to enable easy l…
2020-09-04 12:19:37 -07:00
5120ad9d9a
add test file
2020-09-04 11:56:32 -07:00
20d62654ae
move runAndStream into a generalized helper function to enable easy local exectution in other places than just the docker builder
2020-09-04 11:56:32 -07:00
03a0beb683
builder/vmware/common: simplify type assertion switch ( #9893 )
2020-09-04 16:25:19 +02:00
ba74602d63
Allows publishing to a Shared Image Gallery with a different subscription id ( #9875 )
2020-09-03 17:13:32 +02:00
7a7d3ff350
Remove comments about sharing with catsby
2020-09-03 09:14:40 -05:00
d1a61cac33
Add NVMe controller support to vsphere-iso builder ( #9880 )
2020-09-03 11:14:58 +02:00
602729ac23
Fix vsphere-iso acceptance tests ( #9878 ) ( #9881 )
2020-09-03 10:17:49 +02:00
ab23e839c8
update sharing test to req aws account id
2020-09-02 11:44:38 -04:00
903deb9e6a
vSphere StepHardware tests ( #9866 )
2020-09-02 10:19:57 +02:00
e96cc07a1a
Merge pull request #9853 from remyleone/boottype_local
...
change default scaleway boottype to local
2020-09-01 10:44:42 -07:00
24dbd0a28b
Fix iso_path validation regex ( #9855 )
2020-09-01 10:11:48 +02:00
f4556fd3f1
Merge pull request #9831 from hashicorp/remedial_remote_export_config_tests
...
add tests to make sure prepare for export defaults properly
2020-08-31 15:47:05 -04:00
f74a425661
feat (builder/oracle-oci): pass CreateVnicDetails to instance
2020-08-31 13:13:33 -04:00
58a0bdd780
Look for a default resource pool when root resource pool is not found ( #9809 )
2020-08-31 16:26:48 +02:00
03a374f4b6
Fix linting issues for SA6005 check ( #9854 )
...
Before change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
builder/profitbricks/step_create_server.go:254:22: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/oneandone/config.go:97:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/vmware/common/driver_parser.go:1199:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
```
After change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
```
2020-08-31 15:44:42 +02:00
804fefef17
yandex-import: allow set custom API endpoint ( #9850 )
...
* Separate Access Config from yandex builder Config
* make use of Access Config explicit
* Move `MaxRetries` into AccessConfig
* NewDriverYC use AccessConfig instead Config
* yandex-import PP use common Access Config
Now support set custom API Endpoint
* yandex-export PP use common Access Config
Now support set custom API Endpoint too (as yandex-import)
* fix test
* Tiny doc updates.
2020-08-31 15:29:20 +02:00
0ad26cce01
Feat (oracle-oci): allow freeform and defined tags to be added instance ( #9802 )
...
* feat (oracle-oci): allow freeform and defined tags to be added to instance (#6313 )
* docs (oracle-oci): add descriptions for instance_tags and instance_defined_tags (#6313 )
* fix: fmt
* fix: generate hcl2spec
2020-08-31 14:36:09 +02:00
ecd1a49a35
change default scaleway boottype to local
2020-08-31 13:15:37 +02:00
e4f975fae1
Allows for the mounting of ISOs when a Proxmox VM s created. Same as … ( #9653 )
...
Allows the mounting of additional ISOs when the VM is created. The config option was taken from PR #9055 and slightly changed. Users can specify an array of bus names, bus numbers and filenames.
"cd_drive":[
{
"bus": "ide",
"bus_number": 3,
"filename": "isos:iso/virtio-win-0.1.187.iso"
},
{
"bus": "sata",
"bus_number": 3,
"filename": "isos:iso/someother.iso"
}
]
Closes : #7950
Co-authored-by: Calle Pettersson <carlpett@users.noreply.github.com>
2020-08-31 10:48:24 +02:00
942bfbf221
Add driver mocks and write tests to steps Remote Upload and Create VM ( #9833 )
2020-08-31 10:34:41 +02:00
1c5bc41beb
refactor ovftool validation into vmware driver
2020-08-27 10:55:57 -07:00
bbc3a5b0d1
add tests to make sure prepare for export defaults properly
2020-08-27 10:55:57 -07:00
e0badb3fb7
refactor: update step_update_omi_attributes and create_tags to new OSC SDK
2020-08-26 12:25:46 -05:00
a6d5106cd7
Allow "export" to ovf/ova for local vmware builds in addition to esx ones.
...
Refactor step_export and the driver interface to move the ovftool call
into the vmware driver. This refactor allows us to add meaningful tests
to step_export, which I have also added here.
2020-08-26 09:45:12 -07:00
e9b526ee2d
Move step_create_disk into common folder, and add to vmx builder ( #9815 )
...
Pull additional disk related config options into their own file.
2020-08-26 10:13:11 +02:00
8885a5ef31
refactor: update step_create_omi to new OSC SDK
2020-08-25 18:02:11 -05:00
f0dc26613a
Merge pull request #7 from marinsalinas/step_deregister_omi
...
Step Deregister OMI
2020-08-25 17:22:58 -05:00
0d0bd9ce75
name fields of PolicyDocument correctly in HCL ( #9812 )
...
withouth this fix we would have had to do
```hcl
temporary_iam_instance_profile_policy_document {
statement {
action = ["*"]
effect = "Allow"
resource = ["*"]
}
version = "2012-10-17"
}
```
instead of the same document but with capitalised fields
2020-08-25 10:53:56 +02:00
a0c09e85df
retry spot instance creation when an "Invalid IAM Instance Profile name" error pops up ( #9810 )
...
PutRolePolicy & AddRoleToInstanceProfile are eventually consistent but it is not possible to wait for them to be done here: 0785c2f6fc/builder/amazon/common/step_iam_instance_profile.go (L117-L134)
2020-08-25 10:10:32 +02:00
2152fa3313
Accept content library path in iso_paths ( #9801 )
2020-08-24 16:54:30 +02:00
8166dad533
Merge pull request #5 from marinsalinas/step_cleanup_volumes
...
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-21 15:03:47 -05:00
8274d4848c
chore: added forece_deregister in the test case to verify the step_deregister_omi
2020-08-21 13:30:21 -05:00
071854ea4a
chore: implemented OSC API in step_deregister_omi
2020-08-21 13:29:41 -05:00
a13dfe1f42
chore: added GetRegion() and NewOSCClientByRegion functions
2020-08-21 13:29:27 -05:00
60bd61dc18
chore: removed security group filter function, it was moved to step_security_group file
2020-08-21 11:31:00 -05:00
c3a4b60ea5
chore: implemented OSC API in step_security_group
2020-08-21 11:30:10 -05:00
7a45e4c8b0
refactor: change step tag bsu volumes to new OSC SDK
2020-08-21 10:40:14 -05:00
c58d6f9b33
refactor: migrate run vm step to new SDK
2020-08-21 10:10:25 -05:00
6f0bb33c9a
refactor: change tags ssh file to new OSC SDK
2020-08-20 20:35:51 -05:00
e5c14044fb
refactor: change tags file to new OSC SDK
2020-08-20 19:12:38 -05:00
addc3dd6e7
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-20 18:33:02 -05:00
d9a7626249
Merge pull request #4 from marinsalinas/step_public_ip
...
Step public ip
2020-08-20 18:04:03 -05:00
7745369dce
chore: set true associate_public_ip_address attribute to test the step_public_ip
2020-08-20 14:00:13 -05:00
86966ecfee
:chore: implemented OSC API in pre_public_ip step
2020-08-20 13:59:25 -05:00
ada2a431ef
Modularise vCenter rest client ( #9793 )
2020-08-20 17:55:25 +02:00
99800619b7
Add HCL2 examples to the virtualbox builders ( #9788 )
2020-08-20 15:43:38 +02:00
a1524bf96a
Add option to also import OVF templates to the Content Library ( #9755 )
2020-08-19 13:20:25 +02:00
232d5a3ce6
chore: changed oapi to osc
2020-08-18 15:06:00 -05:00
a2cfaace59
extract output dir configuration and defaulting into the step_output_dir, using pointers to make sure they get set properly back on the main config
2020-08-18 12:50:06 -07:00
3b2bedf794
implement a remote_output_directory option, and heavily comment output code
2020-08-18 12:50:00 -07:00
43e9d43ebd
chore: removed API attribute
2020-08-18 13:52:49 -05:00
8b2cdc5821
refactor: change step_network_info to new OSC SDK
2020-08-18 13:33:45 -05:00
8649496c6c
refactor: change new sdk on step_source_omi_info
2020-08-18 13:33:45 -05:00
4431bb87b2
:chore: added api key to specify the API connection
2020-08-18 13:33:45 -05:00
823b957a1f
:chore: implemented OSC connection in pre_validate file
2020-08-18 13:33:45 -05:00
22481d1ac2
:chore: added OSC Connection in builder file
2020-08-18 13:32:38 -05:00
1fbe715c13
:chore: added OSC Connection in builder file
2020-08-18 12:23:39 -05:00
b0d2201d55
Merge pull request #9782 from hashicorp/fix_9151
...
fully destroy vm if it was cancelled or errored
2020-08-18 07:22:18 -07:00
0a5cd953fc
fully destroy vm if it was cancelled or errored
2020-08-17 14:07:58 -07:00
aa2418cf01
add progress tracker to vmware-esx iso upload. Add colored prefix to … ( #9779 )
...
* add progress tracker to vmware-esx iso upload. Add colored prefix to tracker to make it clear which build a tracker belongs to.
* fix mock; fix tests
2020-08-17 14:35:42 -04:00
d74b47b734
Merge pull request #9777 from hashicorp/fix_9756
...
Add aws_polling config option to override env variables
2020-08-17 10:49:38 -07:00
1a0d5a93ee
fix max_attempts typo
2020-08-17 17:58:22 +02:00
788dc32598
add aws_polling config option to override env variables
2020-08-17 17:15:32 +02:00
1bfb2d9170
:chore: implemented transport file to make the OSC API Connection
2020-08-17 10:04:28 -05:00
1055007cba
:chore: added OSC API Client Connection
2020-08-17 10:02:00 -05:00
46a26a3d9e
Fix Hyper-V boot command refs #5291 ( #9765 )
2020-08-17 16:00:43 +02:00
8b4993e44c
fix docs for kms key ids ( #9766 )
2020-08-14 11:35:35 +02:00
74f868da37
:chore: changed the AMI with an existing AMI to work fine with the test case
2020-08-13 17:03:32 -05:00
acba3ea3e7
Document network path ( #9762 )
2020-08-13 11:26:40 -04:00
e97c56dc72
Merge pull request #9559 from hashicorp/fix_9482
...
builder/azure-arm: Remove duplicate resource deletion steps
2020-08-12 12:43:09 -07:00
55812fe8a5
Handle error of deferred deletion
2020-08-12 11:30:15 -04:00
5700f74c8c
Handle lease not present error
2020-08-12 11:27:07 -04:00
d91839b93e
Update deletion logic for OS disks
...
* Add an ResourceNotFound error check
* Add logic to break temporary disk lease before deleting it
2020-08-12 11:03:51 -04:00
ba6d11d518
Remove StepDeleteOSDisk in favor of StepDeployTemplate#Cleanup
2020-08-12 11:03:03 -04:00
54469c4728
Add all of the custom AWS template engines to GeneratedData for use b… ( #9751 )
2020-08-12 10:43:15 +02:00
e475db6a66
check for ip after timeout ( #9748 )
2020-08-12 10:39:12 +02:00
aed97e1a8b
Ensure any active leases are brokend before deleting
2020-08-11 16:41:28 -04:00
920da9d0a4
Fix up code to remove some additional steps
2020-08-11 16:40:51 -04:00
f8bb9008c0
Merge pull request #9697 from backerman/personal/backerman/9695
...
Add FreeBSD support to azure/chroot
2020-08-10 12:47:48 -07:00
7c28d5590c
Remove StepDeleteResourceGroup in favor of StepDeploymentTemplate#Cleanup
2020-08-10 12:57:11 -04:00
80960d7a64
Fix vsphere boot command and check for context cancelation when waiting for ip ( #9739 )
2020-08-10 18:16:19 +02:00
23d5432333
Revert inadvertently-changed import.
2020-08-09 14:31:54 -07:00
109b2a0ca9
Build constraints don't seem to work on test.
2020-08-09 14:12:58 -07:00
94c9b87431
Only run on platforms supported by chroot.
2020-08-09 13:53:21 -07:00
33eb8483ba
Get some tests in here.
2020-08-09 13:39:29 -07:00
8f362656ee
Update builder/amazon/ebs/step_create_ami.go
...
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-08-07 08:02:57 -07:00
484dbfe6ad
improve error handling when waiting for image so that the resourcenotready error is bubbled up more clearly without verbose logging turned on
2020-08-06 14:58:05 -07:00
04d7a10aa0
Merge pull request #9714 from hashicorp/fix_9688
...
provide more helpful error message than the one returned by the clien…
2020-08-06 10:54:21 -07:00
4964c54f60
update docs to state resource id must be fully qualified
2020-08-06 10:41:18 -07:00
25f2ec48d3
add network_name option to vmware builder to make it match the network option on the vsphere builder, so vmware users needn't update vmx data just for the network name ( #9718 )
2020-08-06 13:19:55 +02:00
3f61498704
Merge pull request #9704 from ntoofu/f-vsphere-export-permission
...
Add `directory_permission` config option to `vsphere` builder
2020-08-05 10:57:30 -07:00
dcacf7ad4c
Add vSphere HCL examples to the docs ( #9674 )
2020-08-05 19:23:52 +02:00
aede34079d
provide more helpful error message than the one returned by the client, without context
2020-08-05 09:52:11 -07:00
a53e81d9a2
Make docs more clear
...
https://github.com/hashicorp/packer/pull/9704#discussion_r465393240
2020-08-06 01:11:02 +09:00
6b8d086e94
alt, ctrl, and shift should be outside variables ( #9702 )
2020-08-05 17:36:40 +02:00
825deef43d
Merge pull request #9665 from hashicorp/vsphere_clone_customization
...
Add step to customize cloned VM
2020-08-05 08:30:31 -07:00
dd37a10355
fix configuration_parameters ( #9713 )
2020-08-05 16:57:12 +02:00
5493285f65
Add `directory_permission` config option to `vsphere` builder
2020-08-02 15:02:31 +09:00
fb1a4bd86f
Add placeholder diskattacher for other OSes.
2020-08-01 21:59:43 -07:00
5ce6c8564c
Fix ordering to match master for better diffs.
2020-08-01 21:30:44 -07:00
13a4e47efe
Increase wait time for device to be created.
2020-08-01 21:22:50 -07:00
364c415294
Add FreeBSD support.
2020-08-01 21:22:50 -07:00
a28edbaa0b
Fix skip_save_build_region in the ebssurrogate builder. ( #9666 )
2020-07-31 16:01:46 -04:00
ea45efc9b8
Merge pull request #9677 from hashicorp/b-scaleway-user-agent-config
...
builder/scaleway: Remove mapstructure configuration for the UserAgent runtime-only field
2020-07-31 10:26:36 -07:00
fc2e94554a
add qemu hcl examples
2020-07-31 17:32:08 +02:00
a76c6c55a9
Remove HCL config for runtime field `UserAgent`
...
Results before change
```
⇶ packer build /tmp/minimal.pkr.hcl
Error: 1 error occurred:
* unknown configuration key: '"user_agent"'
on /tmp/minimal.pkr.hcl line 1:
(source code not available)
==> Builds finished but no artifacts were created.
```
Results after change
```
⇶ packer build /tmp/minimal.pkr.hcl
scaleway.required: output will be in this color.
==> scaleway.required: Creating temporary ssh key for server...
==> scaleway.required: Creating server...
```
2020-07-31 11:22:55 -04:00
980f02ce5d
Add mapstructure tag for UserAgent field
...
Closes : #9676
2020-07-30 16:08:24 -04:00
94a32dc282
tencentcloud cvm use CLOUD_PREMIUM disk by default ( #9663 )
2020-07-29 15:10:00 +02:00
c6e9bde97b
add step customize and docs
2020-07-29 15:07:44 +02:00
3370c91cf2
add some additional messaging when a boot command fails to type ( #9661 )
2020-07-29 15:06:45 +02:00
883339be25
Set project via project flag, not setting in the config ( #9662 )
...
* set project via project flag, not setting in the config + tests
2020-07-29 10:50:11 +02:00
b695615d7d
fix local file stating ( #9660 )
2020-07-29 10:26:09 +02:00
b40490c3c1
Merge pull request #9610 from chilversc/winrm-via-iap-tunnel
...
Support using WinRM over an IAP tunnel
2020-07-28 14:27:43 -07:00
395a0c472e
improve postprocessor stdout
2020-07-25 08:24:21 -07:00
b3c3e3ed63
Merge pull request #9589 from hashicorp/fix_9184
...
post-processor/vsphere: Fix password encoding in vsphere post-processor ovftool call
2020-07-25 08:23:54 -07:00
44616d3bff
refactor initialization out from packer configs + tests ( #9627 )
...
The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost.
This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too.
fix #9478
2020-07-24 10:58:03 +02:00
74aef3c819
apply same url encoding to other places we call ovftool
2020-07-23 17:03:42 -07:00
a687d6fe12
ci/tech-debt: Fix vmware acceptance tests ( #9636 )
...
* add kex algorithm option to ssh config
* regenerate code
* This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts:
1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed.
2) It modifies logic in reading and defaulting hardware config values, which was crashing.
3) It adds a new acceptance test with a preseed file to test loading from an http directory.
2020-07-23 09:40:57 +02:00
0a66f19dbe
fix minimal json example to use new checksumming ( #9633 )
2020-07-23 09:39:57 +02:00
ec5a2b87af
Merge pull request #9619 from piggona/master
...
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-22 10:29:30 -07:00
f9df185ef1
Merge pull request #9579 from hashicorp/fix_9562
...
wrap CreateImage call in a retry to account for eventual consistencey…
2020-07-22 08:43:10 -07:00
63eedf841e
Fix failing tests due to IAP communicator host name
...
Moved setting the host from ApplyIAPTunnel to Config.Prepare but forgot to
update the related tests.
2020-07-22 12:58:05 +01:00
1f3b3f8fd9
change retry func to a 15 min timeout
2020-07-21 15:55:39 -07:00
a56942d3c7
change isAwsErr to an exported func so I can use it in other aws modules.
2020-07-21 15:30:45 -07:00
036ea238bf
wrap CreateImage call in a retry to account for eventual consistencey issues with image state
2020-07-21 15:30:45 -07:00
22b49c1a92
delete cvm-filter configuration
2020-07-21 11:04:41 +08:00
ecfce6ef4c
delete cvm-filter configuration
2020-07-21 11:04:32 +08:00
38563df35c
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-21 11:04:11 +08:00
a1b6f809c7
add:argument key SourceImageName to get source image by name.
2020-07-21 11:02:30 +08:00
810f161d22
builder/amazon/common/block_device.go: replace tabs with words
2020-07-20 16:34:13 +02:00
966b17d2b5
builder/amazon/common/access_config.go: replace tabs with words
2020-07-20 16:31:23 +02:00
5c4901c2c2
builder/amazon/common/run_config.go: replace tabs with words
2020-07-20 16:28:14 +02:00
1455a29f2b
remove tabs for security_group_filter too
2020-07-20 16:24:47 +02:00
191094edcc
better `disable_stop_instance` docs
2020-07-20 16:21:43 +02:00
37544f4d5f
Support using WinRM over an IAP tunnel
...
This avoids the need to expose WinRM ports on the internet and allows
using instances with only an internal private IP address.
When using a WinRM tunnel there is a race condition between the tunnel
connection attempt timing out and packer assuming the connection was
successful. To allow for this, when using WinRM the default success
timeout is increased to 40 seconds.
2020-07-19 01:28:31 +01:00
530f5e3f63
more additions to partials
2020-07-17 15:52:11 -07:00
a1651977b3
add tabs to generated docs from access_config and run_config structs
2020-07-17 15:10:55 -07:00
8964367eb5
Merge pull request #9603 from paulmey/disable-password
...
[azure-arm] Disable ssh password authentication unless password is explicitly specified
2020-07-17 09:32:38 -07:00
0883e185a2
Merge pull request #9594 from GennadySpb/yndx-image-min-disk-size
...
yandex: Add new property 'min_disk_size' of built image
2020-07-17 09:31:48 -07:00
9f34241b5c
Merge pull request #9597 from romantomjak/multiqueue-net-option
...
builder/proxmox: add support for multiple NIC packet queues
2020-07-17 09:07:04 -07:00
708ca1c126
Add some error checking
2020-07-16 23:22:24 +00:00
deca28c158
Disable password auth on ssh key Linux builds
2020-07-16 22:26:06 +00:00
5fd68374fe
Optionally disable password authentication for Linux builds
2020-07-16 19:44:01 +00:00
a2220e5f08
make linter happy
2020-07-16 18:19:22 +01:00
d3d7cc3e59
configure packet queues on nics
2020-07-16 17:56:58 +01:00
a65157a91b
use helper method for mandatory config
2020-07-16 17:41:56 +01:00
03a0bf26f2
Rename config key name
2020-07-16 17:29:45 +03:00
9c565a97c0
Add new property 'min_disk_size' of built image
2020-07-16 17:10:22 +03:00
c0270c9f19
Merge pull request #9587 from romantomjak/disable-kvm-flag
...
Add option to disable KVM hardware virtualization in proxmox builder
2020-07-15 15:23:09 -07:00
7ed8709483
add option to configure network adapter multiqueue support
2020-07-15 23:07:02 +01:00
376b8c045e
use the value of disable kvm flag when creating the VM
2020-07-15 19:12:01 +01:00
be7251f185
add option to disable kvm hardware virtualization
2020-07-15 18:47:24 +01:00
8bb2cb44c0
rename launch timeout to launch wait
2020-07-15 10:24:55 -07:00
6e9eaa1edd
generate code
2020-07-15 10:20:50 -07:00
af009c2aa0
make tunnel timeout configurable
2020-07-15 10:17:13 -07:00
cf5537d5d2
Merge pull request #9565 from mk0x9/docker/builder-add-runner-params
...
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs, --device
2020-07-15 10:16:13 -07:00
c59d0b0283
Merge pull request #9584 from hashicorp/azr-fix-esxi-checksum
...
esx5driver.VerifyChecksum: try checksum remote file instead of local file
2020-07-15 10:07:17 -07:00
1edd848877
esx5driver.VerifyChecksum: try checksum remote file instead of local file
...
fix #9456
2020-07-15 18:21:08 +02:00
37d0f48599
builder/docker: reference to docker docs regarding capabilities
2020-07-15 03:04:13 +02:00
a414e7cdb9
convert relative to absolute path in prepare
2020-07-14 15:59:53 -07:00
bb43b5cac4
improve validation and error handling around synced_folder
2020-07-14 11:34:40 -07:00
6e77d9d3a9
builder/docker: runner support for --device
2020-07-14 10:37:44 -07:00
791a86c45e
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs
2020-07-14 10:34:10 -07:00
f5031a1eb5
Merge pull request #9573 from zhsj/bump-gophercloud
...
Bump gophercloud to latest version
2020-07-14 10:11:06 -07:00
aa4933c28a
Merge pull request #9574 from jhawk28/vsphere_usb_controllers
...
(vsphere) add ability to add a xhci/usb3 controller
2020-07-14 10:09:33 -07:00
b49c844637
ignore false and 0 in case someone defined the field as "false" or false
2020-07-14 12:11:24 -04:00
5a006f226a
Don't use Packer context as vSphere driver context ( #9576 )
2020-07-14 11:45:19 +02:00
eb5c3c3efb
fix file size descriptor ( #9568 )
2020-07-14 11:36:49 +02:00
3a0dfa1259
add option to destroy vm after deploy to content library ( #9569 )
2020-07-14 10:07:20 +02:00
b0fa05704a
change usb controllers to a list. add ability to set as a usb3
...
Closes #8874
2020-07-13 20:54:46 -04:00
4fe9a92058
Bump gophercloud to latest version
2020-07-14 00:01:37 +08:00
28f8241a05
update generated files
2020-07-10 16:58:06 -07:00
921078ccc0
add force_bios_setup configuration option
2020-07-10 12:30:22 +02:00
ae5156a70d
add ability to define multiple disk controllers ( #9519 )
2020-07-10 12:25:46 +02:00
9c1409dbba
Add content_library_destination to import VM template to a Content Library ( #9551 )
2020-07-10 11:01:10 +02:00
61b79b6e53
Merge pull request #9542 from jhawk28/bug_9511
...
clean up folder path so that it is what vsphere expects
2020-07-09 16:08:18 -07:00
e1e37ad025
Merge pull request #9555 from yandex-cloud/yandex-export-templating
...
yandex-export: templating
2020-07-09 15:50:04 -07:00
b7f1aedf96
Merge pull request #9556 from hashicorp/fix_9107
...
Match network to host when multiple networks are found
2020-07-09 14:52:32 -07:00
765d96e8eb
unset HardwareConfig.Firmware since CreateConfig.Firmware configures the firmware in StepCreateVM
2020-07-09 10:34:48 -04:00
b74e28a479
match network to host when multiple networks are found
2020-07-09 15:59:15 +02:00
378c9746fa
Fill up build variables (aka `generated_data`)
...
See description at https://packer.io/docs/extending/custom-builders#build-variables
2020-07-09 16:21:21 +03:00
e08c1a461a
Merge pull request #9553 from GennadySpb/yandex-import-post-processor
...
[WIP] Yandex Import post-processor
2020-07-08 16:25:08 -07:00
4d3b2cea96
Merge pull request #9480 from adongy/master
...
aws: retry fetching blockdevicemapping if empty
2020-07-08 12:32:12 -07:00
420beb333b
make inner image accessible from other packages
2020-07-08 22:01:52 +03:00
a885e620ee
don't error for no mappings if no mappings were set.
2020-07-08 11:55:56 -07:00
e5606d483d
builder/googlecompute: add support for oslogin ( #9339 )
...
* feat: add support for oslogin
Signed-off-by: Wei Cheng <calvinpohwc@gmail.com>
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-07-08 06:30:25 -04:00
d4a7dd24d9
fix link in deprecation warning ( #9544 )
2020-07-08 11:59:39 +02:00
268e95364f
Adds vApp properties config and save public ssh key to a vApp property ( #9507 )
2020-07-08 10:33:45 +02:00
673858a63c
Merge pull request #9513 from hashicorp/undocument_ssh_temp_key
...
Undocument ssh options not used by all builders
2020-07-07 14:26:21 -07:00
892413b7ea
docs/builder/vsphere-iso: Add documentation for BootConfig ( #9538 )
...
* docs/builder/vsphere-iso: Add documentation for BootConfig
* Add documenation for http_ip
* Remove duplicate build configuration section
2020-07-07 13:57:51 -04:00
eeb6f017bd
Merge pull request #9505 from hashicorp/f-googlecompute-wrap_startup_script-option
...
builder/googlecompute: Add WrapStartupScriptFile configuration option
2020-07-07 13:17:02 -04:00
a6170b0c35
clean up folder path so that it is what vsphere expects
2020-07-07 12:25:14 -04:00
a4d1afb83a
Add 'cdrom_interface' option to QEMU builder ( #9483 )
...
- This option allows the user to select the interface type for the CDROM
drive, e.g. `virtio-scsi`, rather than the default `virtio`
- Background: Installation of Ubuntu 20.04 on ARM64 fails as it can't mount the
installation CDROM. While the default `virtio` CDROM fails, setting
`cdrom_interface: virtio-scsi` with this PR succeeds. Some links:
- ISO link: http://cdimage.ubuntu.com/ubuntu-legacy-server/releases/20.04/release/ubuntu-20.04-legacy-server-arm64.iso
- https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1605407
- https://superuser.com/a/1376628/230508
2020-07-07 16:22:30 +02:00
4462c0b5ab
builder/googlecompute: Add WrapStartupScriptFile configuration option
...
By default the Google builder will wrap any provided startup script file
in order to track its execution via custom metadata. The wrapper script
can add a bit of complexity to the start script file so a new option is
being added `wrap_startup_script`. This option allows a user to disable
the script wrapping and just let GCE do its own thing when executing a
startup script.
2020-07-07 07:08:09 -04:00
6095fb2a62
Merge pull request #9515 from jhawk28/vsphere_tools_fix
...
fix vsphere ToolsSyncTime and ToolsUpgradePolicy
2020-07-02 14:19:41 -07:00
500ec5ccc7
fix return
2020-07-02 12:55:10 -04:00
e4dffeed35
clean up if logic
2020-07-02 12:33:28 -04:00
8ea64c5b35
undocument ssh_keypair_name and ssh_agent_auth
2020-07-02 14:55:58 +02:00
445cf12b65
Merge pull request #9489 from ad-m/hyperone-freebsd
...
builder/hyperone: Allow skip chroot device discovery
2020-07-01 15:48:03 -07:00
63f9282f5c
fix vshere ToolsSyncTime and ToolsUpgradePolicy
2020-07-01 13:58:50 -04:00
41edd09d3c
undocument temporary_key_pair_name and ssh_private_key_file
2020-07-01 16:33:18 +02:00
af9d2e6f22
Merge pull request #9509 from hashicorp/fix_9508
...
make statement an array of strings
2020-06-30 13:15:51 -07:00
50c65847d1
Merge pull request #9497 from ad-m/hyperone-username
...
builder/hyperone: Add support for custom username in vm create
2020-06-30 10:51:25 -07:00
122e80f591
generated code
2020-06-30 10:12:50 -07:00
0122530a07
make statement an array of strings
2020-06-30 10:01:49 -07:00
212200c88f
Proxmox NIC firewall flag ( #9487 )
...
* add test for firewall toggle
* generate hcl config
* send firewall toggle to proxmox
* update docs
* drop the pointer to bool
* use setDeviceParamIfDefined
2020-06-30 11:04:19 +02:00
80d49a1509
builder/hyperone: Add support for custom username in vm create
2020-06-29 03:17:38 +02:00
4692cdd55c
builder/hyperone: Allow skip chroot device discovery
2020-06-26 15:04:08 +02:00
2322d3ae6b
aws: retry fetching blockdevicemapping if empty
2020-06-25 10:48:24 +02:00
85bffc40da
Merge pull request #9479 from hashicorp/fix_9475
...
only set up localhost port forwarding if skipnatmapping is false.
2020-06-24 14:11:23 -04:00
f8e21db9bc
Merge pull request #9450 from jhawk28/vsphere_multi_ip_wait
...
(vsphere) look at all IPs when waiting for the IP
2020-06-24 10:43:11 -07:00
cd5cf77998
only set up localhost port forwarding if skipnatmapping is false.
2020-06-24 10:40:42 -07:00
38eef12b83
Merge pull request #9467 from ArseniiPetrovich/patch-1
...
Fix data disks URI
2020-06-24 11:50:58 -04:00
8d209caf34
Fix spacing and line endings
2020-06-24 09:20:32 -04:00
f3c33f9a27
remove spaces
2020-06-24 16:08:48 +03:00
8a8abdf615
update ucloud-uhost builder ( #9466 )
...
* update ucloud-uhost builder, docs and deps
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>
2020-06-24 14:31:05 +02:00
e54ad3f1fb
Add boot_command support to vsphere-clone builder, including support … ( #9397 )
2020-06-24 11:14:30 +02:00
c2f352ee6e
Update JSONs to fix tests and make them work with the latest URL changes
2020-06-24 01:35:35 +03:00
a8dfb66d6c
docs/builder/amazon: Add WinRM unsupported note to Session Manager docs
...
Closes #9451
Co-authored-by: Adrien Delorme <azr@users.noreply.github.com>
2020-06-23 07:41:21 -04:00
d7b8d50acd
Fix data disks URI
...
Fixing bug appeared in 0589f57d4d
2020-06-23 12:58:53 +03:00
b2320ca911
HCL2: add singular run_volume_tag block to ebs & ebssurrogate builders ( #9457 )
...
close #9280
related to #8889
2020-06-23 10:49:50 +02:00
a96194081a
Merge pull request #9453 from hashicorp/fix_ssh
...
Allow users to provide a list of ciphers that they want Packer to support.
2020-06-18 11:58:53 -07:00
aa91ef7edf
Merge pull request #9455 from hashicorp/fix_9393
...
docs/builder/google: Add note about boolean values for compute instance metadata
2020-06-18 13:05:30 -04:00
ce6284f760
docs/builder/google: Add note about boolean values for compute instance metadata
...
Closes #9393
2020-06-18 09:50:40 -04:00
801c827058
create parent dirs of target ( #9452 )
2020-06-18 10:25:04 +02:00
4f77bb0c4a
add new ssh_ciphers option
2020-06-17 16:48:23 -07:00
e951b3731a
Merge pull request #9441 from jhawk28/vsphere_httpip_default
...
use ip_wait_address range to determine the default for the http server IP
2020-06-17 14:46:04 -07:00
50b6c86b1c
look at all the IPs of the VM when waiting for an IP
2020-06-17 17:40:21 -04:00
dd40c68ff8
fix default IP address in test to all ipv4 addresses
2020-06-17 16:00:38 -04:00
fb159e7060
add test cases for Network
2020-06-17 11:40:39 -04:00
5cb2ef6e9d
Fix test
2020-06-17 17:23:52 +03:00
1157f0dcfe
Add acceptance test
2020-06-17 17:06:05 +03:00
77ff387e25
Terraform code to quick provision instance with assigned SA.
...
Will be used for (local) acceptance test runs.
2020-06-17 16:23:54 +03:00
a6ec1fa135
Support Instance SA authentication
2020-06-17 12:41:11 +03:00
744fffab5d
Rename test data dir
2020-06-17 12:28:01 +03:00
88c94cc987
Fix 8904 ( #9435 )
2020-06-17 11:04:45 +02:00
7fc2ea8422
add a fallback to an ipv4 address if the the range can't find one
2020-06-17 01:46:30 -04:00
aaf9103330
use the ip_wait_address range to determine the default for the http server IP
2020-06-17 01:36:55 -04:00
4178625afb
re-add winrm_no_proxy option. Winrm code needs to be modified in order to read no_proxy env var when client is created rather than when net/http library is instantiated.
2020-06-16 10:27:30 -07:00
004ace4340
Merge pull request #9406 from hashicorp/fix_9084
...
Add usb_driver to common boot_command and use it on vsphere
2020-06-15 15:55:54 -07:00
0bcfefd0bc
Update Proxmox storagePoolTypes ( #9418 )
2020-06-15 14:00:32 +02:00
c1c350a657
remove comments
2020-06-12 14:51:52 +02:00
45058847c0
return BootConfig prepare err
2020-06-12 14:51:52 +02:00
653eb95bdb
adds tests to usb_driver and step_http_ip_discover
2020-06-12 14:51:52 +02:00
65cfb880fd
Fix boot_command and update docs
2020-06-12 14:51:52 +02:00
ba767d1663
remove duplicated press
2020-06-12 14:51:52 +02:00
585a86fe03
Add usb_driver to common boot_command and use it on vsphere
2020-06-12 14:51:52 +02:00
70a2c7d364
upgrade linodego to v0.14.0 ( #9395 )
...
* upgrade linodego to v0.14.0
* fix builder/linode linter errors
* Update go.mod
Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>
2020-06-12 11:36:54 +02:00
4afcc794be
Fix typo in VSphere Docs ( #9405 )
...
* Fix typo in VSphere Docs
* Update ConfigParamsConfig-not-required.mdx
Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>
2020-06-12 11:18:51 +02:00
e59fab952d
create the folders if they don't exist
2020-06-11 10:37:24 -04:00
8aeaf28bf3
Merge pull request #9380 from hashicorp/azr-docs-remove-duplicate-guest-additions-mode-docfield
...
docs: virtualbox/iso: remove duplicate guest_additions_mode field ( it's already defined in `GuestAdditionsConfig` )
2020-06-10 11:08:17 -07:00
dc14e6a1e2
Merge pull request #9390 from jhawk28/bug_8766
...
use datacenter inventory path for find folder
2020-06-10 10:52:17 -07:00
3a13eafa61
Merge pull request #9387 from arizvisa/GH-9382
...
Fixed a race in the ReadNetworkingConfig implementation from the vmware builders
2020-06-10 09:53:16 -07:00
49bf9c9d37
[gcp] Fixup for the deprecated Secure Boot guest OS feature ( #9371 )
...
GCP informed us that the GuestOsFeature SECURE_BOOT is deprecated and
that they are using UEFI_COMPATIBLE instead. This means, using an image
with 'UEFI_COMPATIBLE' guest OS feature confirms the 'secureBoot'
feature compatibility.
2020-06-10 16:21:11 +02:00
f5a795a22e
use path.Join to make a cleaner path
2020-06-10 09:12:21 -04:00
c7a6315ca4
use datacenter inventory path for find folder
2020-06-10 08:24:23 -04:00
3da5a64a8d
Fixed a race in the ReadNetworkingConfig implementation from the parsers belonging to the vmware builders that existed between reading the version and consuming tokens from the rest of the file.
2020-06-09 19:37:38 -05:00
63896b98ec
docs: virtualbox/iso: remove duplicate guest_additions_mode field ( it's already defined in `GuestAdditionsConfig` )
2020-06-09 15:12:13 +02:00
5d67183c4c
fix test
2020-06-05 14:05:59 -07:00
48b448dfd5
Merge pull request #9366 from hashicorp/fix_9248
...
Add ToolSyncTime and ToolUpgradePolicy to vSphere
2020-06-05 13:03:58 -07:00
7fcd702b45
Merge pull request #9358 from jhawk28/bug_9349
...
(vsphere-iso) add the ability to check if the IP is within the an IP range
2020-06-05 12:18:51 -07:00
093cfcfd9f
Merge pull request #9322 from arizvisa/GH-8528
...
Fix the VMware builders when the guest platform's dhcpcd switches the ip address in-between a build
2020-06-05 10:58:00 -07:00
8985ba077c
Re-added the (mistakenly removed) host override to the CommHost for the vmware builders.
2020-06-05 12:39:20 -05:00
4cd3429914
add ssh override test
2020-06-05 10:15:11 -07:00
112638da01
Add ToolSyncTime and ToolUpgradePolicy to vSphere
2020-06-05 17:20:44 +02:00
1422085ede
Validate host and network when looking for network ( #9361 )
2020-06-05 11:01:58 +02:00
d87e53b841
return false instead of continue to match logic from govmomi
2020-06-05 00:09:57 -04:00
3a6d42e0df
ip check should continue if the ip is NOT in the range
2020-06-04 23:17:02 -04:00
90463e5394
make default for wait address to be any ipv4 address. add some better documentation
2020-06-04 23:13:46 -04:00
9c5a65263f
Added @SwampDragons' suggestion to the `CommHost()` implementation for the vmware builders which uses the communicator config's `Config.Port()` function to determine the communication port-number independent of the configured protocol.
2020-06-04 19:04:12 -05:00
baed65156c
Merge pull request #9319 from arizvisa/GH-8528.refactor
...
This refactors the dhcpd lease parser in the vmware builders and adds unit tests for everything.
2020-06-04 12:18:49 -07:00
27a1ceef6d
add example for any ipv4 address
2020-06-04 12:15:53 -04:00
aa52e690ee
Update go-getter and add samba shared files tests to step_download ( #8954 )
2020-06-04 15:00:18 +02:00
898321bcfe
Added suggestions from @SwampDragons to the parsers from the vmware builders, included unit-tests and sample file for fusion's networking file, and fixed a few situations where the channel wasn't being closed.
2020-06-04 05:07:18 -05:00
1fb22a7b7b
add the ability to check if the IP is within the an IP range
2020-06-04 01:55:25 -04:00
d35f342319
add the ability to configure the http bind address. defaults to 0.0.0.0.
2020-06-03 16:40:18 -07:00
02590f6c44
Merge pull request #9329 from hashicorp/je.website-maintenance-5-29-20
...
🌷 Website Spring Maintenance
2020-06-03 16:25:23 -07:00
f520ced2a8
Merge pull request #9356 from GennadySpb/remove-platform-validation-for-instances-with-gpu
...
Do not require 'gpu-standard-v1' platform_id for any GPU-based config.
2020-06-03 14:52:36 -07:00
e260212be3
Merge pull request #9323 [azure-chroot] copy data disks between shared image galleries
...
[azure-chroot] copy data disks between shared image galleries
2020-06-03 12:32:19 -07:00
542819c464
Remove test
2020-06-03 21:17:12 +03:00
df371b7e25
Do not require 'gpu-standard-v1' platform_id for any GPU-based config.
...
Support use another kind of GPU platforms.
2020-06-03 20:58:39 +03:00
434c9bcae0
Check if task result is nil and return error ( #9354 )
2020-06-03 17:37:30 +02:00
df37918467
Merge pull request #9303 from arizvisa/GH-8528.unit-tests
...
Unit tests for the driver_parser.go functionality of the vmware builder
2020-06-02 15:28:13 -07:00
f4d7b5f493
fix some stuff
2020-06-02 17:22:40 -04:00
e0cfb404fb
builder/googlecompute: add support to specify storage location for GCP images ( #9326 )
...
* feat: add support to specify storage location for GCP images
Signed-off-by: Wei Cheng <calvinpohwc@gmail.com>
2020-06-02 13:42:33 -04:00
e851757e5f
Merge pull request #9342 from jhawk28/bug_9328
...
(vsphere-iso) use the Datacenter's VmFolder
2020-06-02 10:24:48 -07:00
ce45a1990a
Refactor communicator config for Qemu and add SkipNatMapping option ( #9307 )
2020-06-02 11:56:36 +02:00
30bff17799
use the Datacenter's VmFolder instead of hand generating it
2020-06-01 19:53:54 -04:00
374f82b978
buidler/vsphere-iso: ISOUrl Fix ( #9321 )
...
* ISOUrl Fix
Added the check for ISOUrls back in addition to a check for RawSingleISOUrl. This should allow both ISOUrls[] or ISOUrl to work while not requiring them all the time.
* Update config.go
Fixed formatting.
2020-06-01 15:27:26 -04:00
e5b6d8c37c
Didn't know that WinRM uses a different variable for the port number when trying to determine the communication host in `CommHost`...now it's fixed.
2020-05-30 02:17:21 -05:00
5efb1a195e
update docs for configuration_paramaters to explain what it actually is.
2020-05-29 15:07:34 -07:00
9a38fbe2c7
patch source for a couple code block changes
2020-05-29 17:22:16 -04:00
184dc6cc44
Merge pull request #9260 from hashicorp/fix_9256
...
make package_include match output_vagrantfile parsing and abspath cal…
2020-05-29 10:41:26 -07:00
8a9833f5b1
Merge pull request #9287 from rgl/feature-qemu-add-timeout-wait-for-ip-address
...
builder/qemu: timeout waiting for the guest to become available in the network bridge
2020-05-29 09:47:06 -07:00
2288ab3b53
fix typo
2020-05-29 04:15:53 +00:00
1c1991c073
fix a bug
2020-05-28 19:17:22 -07:00
f86f5b958a
Merge remote-tracking branch 'origin/master' into identity
2020-05-28 19:03:44 -07:00
03b2c4355e
include Wilken's suggestion
2020-05-28 16:46:33 -07:00
53e5137411
[bug] Fix test error message
2020-05-28 23:38:17 +00:00
83851bc9aa
[bug] fix diskset type in Artifact creation
2020-05-28 23:38:17 +00:00
aa8250bcc8
give temp data disks lun suffix
2020-05-28 23:38:17 +00:00
4c96847683
log data disks in images
2020-05-28 23:38:17 +00:00
f0cd60b5fa
[bug] provide data disk prefix to disk creation
2020-05-28 23:38:17 +00:00
af96cf7881
Generated files
2020-05-28 23:38:14 +00:00
ac3d19ee23
Use separate caching/sku for data disks
2020-05-28 23:37:44 +00:00
f601f54d0b
Use all disks in managed image
2020-05-28 23:37:43 +00:00
de4839b66e
Use all snapshots when creating a shared image
2020-05-28 23:37:43 +00:00
c6b995a34d
create snapshots for all disks in a diskset
2020-05-28 23:37:43 +00:00
0ee77f8b0e
Add datadisks to disk set when using SIG as source
2020-05-28 23:37:43 +00:00
12f746b2b5
Move to using a diskset
...
Need to store lun numbers for data disks as well
2020-05-28 23:37:43 +00:00
3a3e6e525b
Shift names to diskset
...
Instead of one disk, we'll be working with a set of disks.
2020-05-28 23:37:43 +00:00
c9284d03aa
Add config for data disk/snapshot naming
2020-05-28 23:37:38 +00:00
229b5d17ff
Re-worked the vmware builder drivers so that they're able to check multiple ip addresses when trying to connect via the CommHost.
2020-05-28 15:36:45 -05:00
0609909f1a
Fixed some lint issues.
2020-05-28 13:53:49 -05:00
ad7194c920
Rewrote the GuestIP implementation in the vmware builder to use the new dhcpd lease parsers instead of the old regexp-based logic.
2020-05-28 13:22:58 -05:00
020b005522
Finished implementing the final dhcpd lease entries parser for the vmware builders and also included its own unit tests.
2020-05-28 13:22:58 -05:00
cf5332fa20
Updated the dhcpd lease entry parser in the vmware builder to return errors if any are encountered.
2020-05-28 13:22:58 -05:00
afa4696985
Tightened the regular expressions used by the vmware builder to parse the dhcpd leases, and added support for parsing the weekdays.
2020-05-28 13:22:58 -05:00
e2a7c317eb
Implemented the dhcpd lease entry decoder and the address decoder for the vmware builder.
2020-05-28 13:22:57 -05:00
efb775accb
Added a number of parsing combinators to the vmware builder and some minor tests for them to help with parsing dhcpd leases.
2020-05-28 13:22:57 -05:00
f17007d546
Removed the sentinelSignaller chan from the vmware builder parsers and its unit-tests, and also commented all of the goroutines that are used.
2020-05-28 13:22:56 -05:00
159ea595df
More lint issues fixed...
2020-05-28 13:12:42 -05:00
32b64e0576
Fixed some lint issues in the unit tests for the vmware builder driver parsers.
2020-05-28 13:07:54 -05:00
40947c2bf6
HCL2: generate hcl tags with go-cty tags too ( #9306 )
...
This will allow to generate the config files:
```go
package main
import (
"fmt"
"github.com/hashicorp/hcl/v2/gohcl"
"github.com/hashicorp/hcl/v2/hclwrite"
"github.com/hashicorp/packer/builder/alicloud/ecs"
)
func main() {
name := "name"
app := ecs.FlatConfig{
AlicloudImageName: &name,
ECSSystemDiskMapping: &ecs.FlatAlicloudDiskDevice{
DiskName: &name,
},
}
f := hclwrite.NewEmptyFile()
block := gohcl.EncodeAsBlock(&app, `source "something" "something"`)
f.Body().AppendBlock(block)
fmt.Printf("%s", f.Bytes())
}
```
Will output:
```
source "something" "something" {
packer_user_variables = null
packer_sensitive_variables = null
image_name = "name"
image_share_account = null
image_unshare_account = null
image_copy_regions = null
image_copy_names = null
tags = null
tag = null
system_disk_mapping = { disk_category = null, disk_delete_with_instance = null, disk_descri
ption = null, disk_device = null, disk_encrypted = null, disk_name = "name", disk_size = null, disk_
snapshot_id = null }
image_disk_mappings = null
ssh_remote_tunnels = null
ssh_local_tunnels = null
ssh_public_key = null
ssh_private_key = null
}
```
This is a good first step for #9015 and #9282
fix #9304
2020-05-28 11:19:00 +02:00
0fa60c68fb
Drop the iso_checksum_type & iso_checksum_url fields ( #8437 )
...
* Drop the iso_checksum_type & iso_checksum_url fields
In favor of simply using iso_checksum that will know what to do.
* fix after master merge
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* remove checksum lowercasing tests
* Update builder_test.go
* Update builder_test.go
* better docs
* Update builder_test.go
* even better docs
* Update config.go
* Update builder_test.go
* Update step_create_vmx_test.go
* make generate
* better docs
* fix imports
* up tests
* Update _ISOConfig-required.html.md
* Update builder_test.go
* don't use sha1.Sum("none") as a caching path
* Update builder_test.go
* better docs
* Update iso_config_test.go
remove ISOChecksumType/ISOChecksumURL references
* Update step_download_test.go
* add iso_checksum_url and iso_checksum_type fixers + tests
* add concrete examples of checksum values
* add examples of checksumming from local file
* update go-getter dep
* up deps
* use new go-getter version
* up ESX5Driver.VerifyChecksum: use go-getter's checksumming
* ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum
* Update iso_config.go
* get go-getter from v2 branch
* Update driver_esx5.go
add more comments
* Update driver_esx5.go
* show better error message when the checksum is invalid
* Update builder_test.go
put in a valid checksum to fix tests, checksum is md5("packer")
* Update builder_test.go
test invalid and valid checksum
* more test updating
* fix default md5 string to be a valid md5
* TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming
* Update iso_config_test.go
* Update iso_config_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update go.mod
* Update go.mod
* Update CHANGELOG.md
2020-05-28 11:02:09 +02:00
828440d852
rebase and run generate
2020-05-27 15:05:23 -07:00
43714049e8
add set_host_for_datastore_uploads flag
2020-05-27 15:00:08 -07:00
9895f90451
dont set the host for the datastore upload
2020-05-27 15:00:08 -07:00
2a8bc45bc4
Added unit-tests for the netmap parsing components in the vmware builder.
2020-05-26 23:03:30 -05:00
7c1ad4adcf
Added unit-tests for the dhcpd configuration components in the vmware builder, and fixed a few discovered race conditions.
2020-05-26 22:59:35 -05:00
fdb0b2ab03
Revert "validate if user assigned identity exists"
...
This reverts commit 9bd19df040
2020-05-26 17:17:48 -07:00
c016f3752a
upgrade SIG source api-version to match identity api-version to avoid potential setback for identity
2020-05-26 16:08:00 -07:00
01839e272e
Merge pull request #9277 from nitrocode/add-source-ami-creation-date
...
Added SourceAMICreationDate
2020-05-26 12:24:47 -07:00
6d29ec956b
Added SourceAMICreationDate
2020-05-26 15:04:03 -04:00
4839b9189d
builder/qemu: timeout waiting for the guest to become available in the network bridge
2020-05-26 07:46:06 +01:00
3fdab998f8
check error
2020-05-25 12:33:33 -07:00
Megan Marsh
sylviamoss
Anthony Dong
Wilken Rivera
Jeff Wong
Andreas Botzner
Marin Salinas
js-g
Patrik
Richard Turc
Ronald van Zantvoort
Calle Pettersson
Lars Lehtonen
catsby
Troy Lindsay
Rae Krantz
GennadySpb
Rémy Léone
Adrien Delorme
PacoDw
Isaac Buckman
Brad Ackerman
ntoofu
jhawk28
Etan Reisner
Li Kexian
Chris Chilvers
piggona
Adrien Delorme
Paul Meyer
Roman Tomjak
Michael Kuryshev
Shengjing Zhu
Roger Hu
Wei Cheng
Lyle Franklin
Joshua Foster
Adam Dobrawy
Arsenii Petrovich
mingsheng.su
Ivo van Geel
Calle Pettersson
Charlie Kenney
Conlan
Svetlin
Ali Rizvi-Santiago
Jeff Escalante
RedTail72
Feiyu Shi
nitrocode
Rui Lopes