7a7d3ff350
Remove comments about sharing with catsby
2020-09-03 09:14:40 -05:00
d1a61cac33
Add NVMe controller support to vsphere-iso builder ( #9880 )
2020-09-03 11:14:58 +02:00
602729ac23
Fix vsphere-iso acceptance tests ( #9878 ) ( #9881 )
2020-09-03 10:17:49 +02:00
ab23e839c8
update sharing test to req aws account id
2020-09-02 11:44:38 -04:00
903deb9e6a
vSphere StepHardware tests ( #9866 )
2020-09-02 10:19:57 +02:00
e96cc07a1a
Merge pull request #9853 from remyleone/boottype_local
...
change default scaleway boottype to local
2020-09-01 10:44:42 -07:00
24dbd0a28b
Fix iso_path validation regex ( #9855 )
2020-09-01 10:11:48 +02:00
f4556fd3f1
Merge pull request #9831 from hashicorp/remedial_remote_export_config_tests
...
add tests to make sure prepare for export defaults properly
2020-08-31 15:47:05 -04:00
f74a425661
feat (builder/oracle-oci): pass CreateVnicDetails to instance
2020-08-31 13:13:33 -04:00
58a0bdd780
Look for a default resource pool when root resource pool is not found ( #9809 )
2020-08-31 16:26:48 +02:00
03a374f4b6
Fix linting issues for SA6005 check ( #9854 )
...
Before change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
builder/profitbricks/step_create_server.go:254:22: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/oneandone/config.go:97:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/vmware/common/driver_parser.go:1199:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
```
After change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
```
2020-08-31 15:44:42 +02:00
804fefef17
yandex-import: allow set custom API endpoint ( #9850 )
...
* Separate Access Config from yandex builder Config
* make use of Access Config explicit
* Move `MaxRetries` into AccessConfig
* NewDriverYC use AccessConfig instead Config
* yandex-import PP use common Access Config
Now support set custom API Endpoint
* yandex-export PP use common Access Config
Now support set custom API Endpoint too (as yandex-import)
* fix test
* Tiny doc updates.
2020-08-31 15:29:20 +02:00
0ad26cce01
Feat (oracle-oci): allow freeform and defined tags to be added instance ( #9802 )
...
* feat (oracle-oci): allow freeform and defined tags to be added to instance (#6313 )
* docs (oracle-oci): add descriptions for instance_tags and instance_defined_tags (#6313 )
* fix: fmt
* fix: generate hcl2spec
2020-08-31 14:36:09 +02:00
ecd1a49a35
change default scaleway boottype to local
2020-08-31 13:15:37 +02:00
e4f975fae1
Allows for the mounting of ISOs when a Proxmox VM s created. Same as … ( #9653 )
...
Allows the mounting of additional ISOs when the VM is created. The config option was taken from PR #9055 and slightly changed. Users can specify an array of bus names, bus numbers and filenames.
"cd_drive":[
{
"bus": "ide",
"bus_number": 3,
"filename": "isos:iso/virtio-win-0.1.187.iso"
},
{
"bus": "sata",
"bus_number": 3,
"filename": "isos:iso/someother.iso"
}
]
Closes : #7950
Co-authored-by: Calle Pettersson <carlpett@users.noreply.github.com>
2020-08-31 10:48:24 +02:00
942bfbf221
Add driver mocks and write tests to steps Remote Upload and Create VM ( #9833 )
2020-08-31 10:34:41 +02:00
1c5bc41beb
refactor ovftool validation into vmware driver
2020-08-27 10:55:57 -07:00
bbc3a5b0d1
add tests to make sure prepare for export defaults properly
2020-08-27 10:55:57 -07:00
a6d5106cd7
Allow "export" to ovf/ova for local vmware builds in addition to esx ones.
...
Refactor step_export and the driver interface to move the ovftool call
into the vmware driver. This refactor allows us to add meaningful tests
to step_export, which I have also added here.
2020-08-26 09:45:12 -07:00
e9b526ee2d
Move step_create_disk into common folder, and add to vmx builder ( #9815 )
...
Pull additional disk related config options into their own file.
2020-08-26 10:13:11 +02:00
0d0bd9ce75
name fields of PolicyDocument correctly in HCL ( #9812 )
...
withouth this fix we would have had to do
```hcl
temporary_iam_instance_profile_policy_document {
statement {
action = ["*"]
effect = "Allow"
resource = ["*"]
}
version = "2012-10-17"
}
```
instead of the same document but with capitalised fields
2020-08-25 10:53:56 +02:00
a0c09e85df
retry spot instance creation when an "Invalid IAM Instance Profile name" error pops up ( #9810 )
...
PutRolePolicy & AddRoleToInstanceProfile are eventually consistent but it is not possible to wait for them to be done here: 0785c2f6fc/builder/amazon/common/step_iam_instance_profile.go (L117-L134)
2020-08-25 10:10:32 +02:00
2152fa3313
Accept content library path in iso_paths ( #9801 )
2020-08-24 16:54:30 +02:00
ada2a431ef
Modularise vCenter rest client ( #9793 )
2020-08-20 17:55:25 +02:00
99800619b7
Add HCL2 examples to the virtualbox builders ( #9788 )
2020-08-20 15:43:38 +02:00
a1524bf96a
Add option to also import OVF templates to the Content Library ( #9755 )
2020-08-19 13:20:25 +02:00
a2cfaace59
extract output dir configuration and defaulting into the step_output_dir, using pointers to make sure they get set properly back on the main config
2020-08-18 12:50:06 -07:00
3b2bedf794
implement a remote_output_directory option, and heavily comment output code
2020-08-18 12:50:00 -07:00
b0d2201d55
Merge pull request #9782 from hashicorp/fix_9151
...
fully destroy vm if it was cancelled or errored
2020-08-18 07:22:18 -07:00
0a5cd953fc
fully destroy vm if it was cancelled or errored
2020-08-17 14:07:58 -07:00
aa2418cf01
add progress tracker to vmware-esx iso upload. Add colored prefix to … ( #9779 )
...
* add progress tracker to vmware-esx iso upload. Add colored prefix to tracker to make it clear which build a tracker belongs to.
* fix mock; fix tests
2020-08-17 14:35:42 -04:00
d74b47b734
Merge pull request #9777 from hashicorp/fix_9756
...
Add aws_polling config option to override env variables
2020-08-17 10:49:38 -07:00
1a0d5a93ee
fix max_attempts typo
2020-08-17 17:58:22 +02:00
788dc32598
add aws_polling config option to override env variables
2020-08-17 17:15:32 +02:00
46a26a3d9e
Fix Hyper-V boot command refs #5291 ( #9765 )
2020-08-17 16:00:43 +02:00
8b4993e44c
fix docs for kms key ids ( #9766 )
2020-08-14 11:35:35 +02:00
acba3ea3e7
Document network path ( #9762 )
2020-08-13 11:26:40 -04:00
e97c56dc72
Merge pull request #9559 from hashicorp/fix_9482
...
builder/azure-arm: Remove duplicate resource deletion steps
2020-08-12 12:43:09 -07:00
55812fe8a5
Handle error of deferred deletion
2020-08-12 11:30:15 -04:00
5700f74c8c
Handle lease not present error
2020-08-12 11:27:07 -04:00
d91839b93e
Update deletion logic for OS disks
...
* Add an ResourceNotFound error check
* Add logic to break temporary disk lease before deleting it
2020-08-12 11:03:51 -04:00
ba6d11d518
Remove StepDeleteOSDisk in favor of StepDeployTemplate#Cleanup
2020-08-12 11:03:03 -04:00
54469c4728
Add all of the custom AWS template engines to GeneratedData for use b… ( #9751 )
2020-08-12 10:43:15 +02:00
e475db6a66
check for ip after timeout ( #9748 )
2020-08-12 10:39:12 +02:00
aed97e1a8b
Ensure any active leases are brokend before deleting
2020-08-11 16:41:28 -04:00
920da9d0a4
Fix up code to remove some additional steps
2020-08-11 16:40:51 -04:00
f8bb9008c0
Merge pull request #9697 from backerman/personal/backerman/9695
...
Add FreeBSD support to azure/chroot
2020-08-10 12:47:48 -07:00
7c28d5590c
Remove StepDeleteResourceGroup in favor of StepDeploymentTemplate#Cleanup
2020-08-10 12:57:11 -04:00
80960d7a64
Fix vsphere boot command and check for context cancelation when waiting for ip ( #9739 )
2020-08-10 18:16:19 +02:00
23d5432333
Revert inadvertently-changed import.
2020-08-09 14:31:54 -07:00
109b2a0ca9
Build constraints don't seem to work on test.
2020-08-09 14:12:58 -07:00
94c9b87431
Only run on platforms supported by chroot.
2020-08-09 13:53:21 -07:00
33eb8483ba
Get some tests in here.
2020-08-09 13:39:29 -07:00
8f362656ee
Update builder/amazon/ebs/step_create_ami.go
...
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-08-07 08:02:57 -07:00
484dbfe6ad
improve error handling when waiting for image so that the resourcenotready error is bubbled up more clearly without verbose logging turned on
2020-08-06 14:58:05 -07:00
04d7a10aa0
Merge pull request #9714 from hashicorp/fix_9688
...
provide more helpful error message than the one returned by the clien…
2020-08-06 10:54:21 -07:00
4964c54f60
update docs to state resource id must be fully qualified
2020-08-06 10:41:18 -07:00
25f2ec48d3
add network_name option to vmware builder to make it match the network option on the vsphere builder, so vmware users needn't update vmx data just for the network name ( #9718 )
2020-08-06 13:19:55 +02:00
3f61498704
Merge pull request #9704 from ntoofu/f-vsphere-export-permission
...
Add `directory_permission` config option to `vsphere` builder
2020-08-05 10:57:30 -07:00
dcacf7ad4c
Add vSphere HCL examples to the docs ( #9674 )
2020-08-05 19:23:52 +02:00
aede34079d
provide more helpful error message than the one returned by the client, without context
2020-08-05 09:52:11 -07:00
a53e81d9a2
Make docs more clear
...
https://github.com/hashicorp/packer/pull/9704#discussion_r465393240
2020-08-06 01:11:02 +09:00
6b8d086e94
alt, ctrl, and shift should be outside variables ( #9702 )
2020-08-05 17:36:40 +02:00
825deef43d
Merge pull request #9665 from hashicorp/vsphere_clone_customization
...
Add step to customize cloned VM
2020-08-05 08:30:31 -07:00
dd37a10355
fix configuration_parameters ( #9713 )
2020-08-05 16:57:12 +02:00
5493285f65
Add `directory_permission` config option to `vsphere` builder
2020-08-02 15:02:31 +09:00
fb1a4bd86f
Add placeholder diskattacher for other OSes.
2020-08-01 21:59:43 -07:00
5ce6c8564c
Fix ordering to match master for better diffs.
2020-08-01 21:30:44 -07:00
13a4e47efe
Increase wait time for device to be created.
2020-08-01 21:22:50 -07:00
364c415294
Add FreeBSD support.
2020-08-01 21:22:50 -07:00
a28edbaa0b
Fix skip_save_build_region in the ebssurrogate builder. ( #9666 )
2020-07-31 16:01:46 -04:00
ea45efc9b8
Merge pull request #9677 from hashicorp/b-scaleway-user-agent-config
...
builder/scaleway: Remove mapstructure configuration for the UserAgent runtime-only field
2020-07-31 10:26:36 -07:00
fc2e94554a
add qemu hcl examples
2020-07-31 17:32:08 +02:00
a76c6c55a9
Remove HCL config for runtime field `UserAgent`
...
Results before change
```
⇶ packer build /tmp/minimal.pkr.hcl
Error: 1 error occurred:
* unknown configuration key: '"user_agent"'
on /tmp/minimal.pkr.hcl line 1:
(source code not available)
==> Builds finished but no artifacts were created.
```
Results after change
```
⇶ packer build /tmp/minimal.pkr.hcl
scaleway.required: output will be in this color.
==> scaleway.required: Creating temporary ssh key for server...
==> scaleway.required: Creating server...
```
2020-07-31 11:22:55 -04:00
980f02ce5d
Add mapstructure tag for UserAgent field
...
Closes : #9676
2020-07-30 16:08:24 -04:00
94a32dc282
tencentcloud cvm use CLOUD_PREMIUM disk by default ( #9663 )
2020-07-29 15:10:00 +02:00
c6e9bde97b
add step customize and docs
2020-07-29 15:07:44 +02:00
3370c91cf2
add some additional messaging when a boot command fails to type ( #9661 )
2020-07-29 15:06:45 +02:00
883339be25
Set project via project flag, not setting in the config ( #9662 )
...
* set project via project flag, not setting in the config + tests
2020-07-29 10:50:11 +02:00
b695615d7d
fix local file stating ( #9660 )
2020-07-29 10:26:09 +02:00
b40490c3c1
Merge pull request #9610 from chilversc/winrm-via-iap-tunnel
...
Support using WinRM over an IAP tunnel
2020-07-28 14:27:43 -07:00
395a0c472e
improve postprocessor stdout
2020-07-25 08:24:21 -07:00
b3c3e3ed63
Merge pull request #9589 from hashicorp/fix_9184
...
post-processor/vsphere: Fix password encoding in vsphere post-processor ovftool call
2020-07-25 08:23:54 -07:00
44616d3bff
refactor initialization out from packer configs + tests ( #9627 )
...
The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost.
This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too.
fix #9478
2020-07-24 10:58:03 +02:00
74aef3c819
apply same url encoding to other places we call ovftool
2020-07-23 17:03:42 -07:00
a687d6fe12
ci/tech-debt: Fix vmware acceptance tests ( #9636 )
...
* add kex algorithm option to ssh config
* regenerate code
* This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts:
1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed.
2) It modifies logic in reading and defaulting hardware config values, which was crashing.
3) It adds a new acceptance test with a preseed file to test loading from an http directory.
2020-07-23 09:40:57 +02:00
0a66f19dbe
fix minimal json example to use new checksumming ( #9633 )
2020-07-23 09:39:57 +02:00
ec5a2b87af
Merge pull request #9619 from piggona/master
...
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-22 10:29:30 -07:00
f9df185ef1
Merge pull request #9579 from hashicorp/fix_9562
...
wrap CreateImage call in a retry to account for eventual consistencey…
2020-07-22 08:43:10 -07:00
63eedf841e
Fix failing tests due to IAP communicator host name
...
Moved setting the host from ApplyIAPTunnel to Config.Prepare but forgot to
update the related tests.
2020-07-22 12:58:05 +01:00
1f3b3f8fd9
change retry func to a 15 min timeout
2020-07-21 15:55:39 -07:00
a56942d3c7
change isAwsErr to an exported func so I can use it in other aws modules.
2020-07-21 15:30:45 -07:00
036ea238bf
wrap CreateImage call in a retry to account for eventual consistencey issues with image state
2020-07-21 15:30:45 -07:00
22b49c1a92
delete cvm-filter configuration
2020-07-21 11:04:41 +08:00
ecfce6ef4c
delete cvm-filter configuration
2020-07-21 11:04:32 +08:00
38563df35c
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-21 11:04:11 +08:00
a1b6f809c7
add:argument key SourceImageName to get source image by name.
2020-07-21 11:02:30 +08:00
810f161d22
builder/amazon/common/block_device.go: replace tabs with words
2020-07-20 16:34:13 +02:00
966b17d2b5
builder/amazon/common/access_config.go: replace tabs with words
2020-07-20 16:31:23 +02:00
5c4901c2c2
builder/amazon/common/run_config.go: replace tabs with words
2020-07-20 16:28:14 +02:00
1455a29f2b
remove tabs for security_group_filter too
2020-07-20 16:24:47 +02:00
191094edcc
better `disable_stop_instance` docs
2020-07-20 16:21:43 +02:00
37544f4d5f
Support using WinRM over an IAP tunnel
...
This avoids the need to expose WinRM ports on the internet and allows
using instances with only an internal private IP address.
When using a WinRM tunnel there is a race condition between the tunnel
connection attempt timing out and packer assuming the connection was
successful. To allow for this, when using WinRM the default success
timeout is increased to 40 seconds.
2020-07-19 01:28:31 +01:00
530f5e3f63
more additions to partials
2020-07-17 15:52:11 -07:00
a1651977b3
add tabs to generated docs from access_config and run_config structs
2020-07-17 15:10:55 -07:00
8964367eb5
Merge pull request #9603 from paulmey/disable-password
...
[azure-arm] Disable ssh password authentication unless password is explicitly specified
2020-07-17 09:32:38 -07:00
0883e185a2
Merge pull request #9594 from GennadySpb/yndx-image-min-disk-size
...
yandex: Add new property 'min_disk_size' of built image
2020-07-17 09:31:48 -07:00
9f34241b5c
Merge pull request #9597 from romantomjak/multiqueue-net-option
...
builder/proxmox: add support for multiple NIC packet queues
2020-07-17 09:07:04 -07:00
708ca1c126
Add some error checking
2020-07-16 23:22:24 +00:00
deca28c158
Disable password auth on ssh key Linux builds
2020-07-16 22:26:06 +00:00
5fd68374fe
Optionally disable password authentication for Linux builds
2020-07-16 19:44:01 +00:00
a2220e5f08
make linter happy
2020-07-16 18:19:22 +01:00
d3d7cc3e59
configure packet queues on nics
2020-07-16 17:56:58 +01:00
a65157a91b
use helper method for mandatory config
2020-07-16 17:41:56 +01:00
03a0bf26f2
Rename config key name
2020-07-16 17:29:45 +03:00
9c565a97c0
Add new property 'min_disk_size' of built image
2020-07-16 17:10:22 +03:00
c0270c9f19
Merge pull request #9587 from romantomjak/disable-kvm-flag
...
Add option to disable KVM hardware virtualization in proxmox builder
2020-07-15 15:23:09 -07:00
7ed8709483
add option to configure network adapter multiqueue support
2020-07-15 23:07:02 +01:00
376b8c045e
use the value of disable kvm flag when creating the VM
2020-07-15 19:12:01 +01:00
be7251f185
add option to disable kvm hardware virtualization
2020-07-15 18:47:24 +01:00
8bb2cb44c0
rename launch timeout to launch wait
2020-07-15 10:24:55 -07:00
6e9eaa1edd
generate code
2020-07-15 10:20:50 -07:00
af009c2aa0
make tunnel timeout configurable
2020-07-15 10:17:13 -07:00
cf5537d5d2
Merge pull request #9565 from mk0x9/docker/builder-add-runner-params
...
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs, --device
2020-07-15 10:16:13 -07:00
c59d0b0283
Merge pull request #9584 from hashicorp/azr-fix-esxi-checksum
...
esx5driver.VerifyChecksum: try checksum remote file instead of local file
2020-07-15 10:07:17 -07:00
1edd848877
esx5driver.VerifyChecksum: try checksum remote file instead of local file
...
fix #9456
2020-07-15 18:21:08 +02:00
37d0f48599
builder/docker: reference to docker docs regarding capabilities
2020-07-15 03:04:13 +02:00
a414e7cdb9
convert relative to absolute path in prepare
2020-07-14 15:59:53 -07:00
bb43b5cac4
improve validation and error handling around synced_folder
2020-07-14 11:34:40 -07:00
6e77d9d3a9
builder/docker: runner support for --device
2020-07-14 10:37:44 -07:00
791a86c45e
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs
2020-07-14 10:34:10 -07:00
f5031a1eb5
Merge pull request #9573 from zhsj/bump-gophercloud
...
Bump gophercloud to latest version
2020-07-14 10:11:06 -07:00
aa4933c28a
Merge pull request #9574 from jhawk28/vsphere_usb_controllers
...
(vsphere) add ability to add a xhci/usb3 controller
2020-07-14 10:09:33 -07:00
b49c844637
ignore false and 0 in case someone defined the field as "false" or false
2020-07-14 12:11:24 -04:00
5a006f226a
Don't use Packer context as vSphere driver context ( #9576 )
2020-07-14 11:45:19 +02:00
eb5c3c3efb
fix file size descriptor ( #9568 )
2020-07-14 11:36:49 +02:00
3a0dfa1259
add option to destroy vm after deploy to content library ( #9569 )
2020-07-14 10:07:20 +02:00
b0fa05704a
change usb controllers to a list. add ability to set as a usb3
...
Closes #8874
2020-07-13 20:54:46 -04:00
4fe9a92058
Bump gophercloud to latest version
2020-07-14 00:01:37 +08:00
28f8241a05
update generated files
2020-07-10 16:58:06 -07:00
921078ccc0
add force_bios_setup configuration option
2020-07-10 12:30:22 +02:00
ae5156a70d
add ability to define multiple disk controllers ( #9519 )
2020-07-10 12:25:46 +02:00
9c1409dbba
Add content_library_destination to import VM template to a Content Library ( #9551 )
2020-07-10 11:01:10 +02:00
61b79b6e53
Merge pull request #9542 from jhawk28/bug_9511
...
clean up folder path so that it is what vsphere expects
2020-07-09 16:08:18 -07:00
e1e37ad025
Merge pull request #9555 from yandex-cloud/yandex-export-templating
...
yandex-export: templating
2020-07-09 15:50:04 -07:00
b7f1aedf96
Merge pull request #9556 from hashicorp/fix_9107
...
Match network to host when multiple networks are found
2020-07-09 14:52:32 -07:00
765d96e8eb
unset HardwareConfig.Firmware since CreateConfig.Firmware configures the firmware in StepCreateVM
2020-07-09 10:34:48 -04:00
b74e28a479
match network to host when multiple networks are found
2020-07-09 15:59:15 +02:00
378c9746fa
Fill up build variables (aka `generated_data`)
...
See description at https://packer.io/docs/extending/custom-builders#build-variables
2020-07-09 16:21:21 +03:00
e08c1a461a
Merge pull request #9553 from GennadySpb/yandex-import-post-processor
...
[WIP] Yandex Import post-processor
2020-07-08 16:25:08 -07:00
catsby
Troy Lindsay
Rae Krantz
Sylvia Moss
Megan Marsh
Wilken Rivera
js-g
GennadySpb
Rémy Léone
Andreas Botzner
Adrien Delorme
Isaac Buckman
Brad Ackerman
ntoofu
jhawk28
Etan Reisner
Li Kexian
Chris Chilvers
piggona
Adrien Delorme
Paul Meyer
Roman Tomjak
Michael Kuryshev
Shengjing Zhu
Roger Hu