Commit Graph

15498 Commits

Author SHA1 Message Date
Adrien Delorme 741a6e4182
HCL2 only: Make provisioners and post-processors reprepare themselves with build data (#9534)
#9444 allows to share builder infos with provisioners and post-processor by re-starting new provisioners and post-processors once the build has started; #9490 allows to 'excpect/only' on a full build blocks (after naming a block), merged together, the tests of #9490 fail. This means we would have to reimplement the only/except logic. While this could have worked, re-using the already started provisioners and post-processor for HCL2 is better/simpler IMO as we won't have to maintain a feature parity.

Also with HCL2 and go-cty all struct ( here provisioner/post-processor) fields are set at the moment of configuring so we should not get weird 'default value' behaviour issue.

This PR reverts some parts of #9444 and implement #9444 in a different manner: I created specific HCL2Provisioner and HCL2PostProcessor structs that both re-prepare themselves right before provisioning. I think this makes the code a little simpler and lays a nice ground for improvement.
2020-07-07 12:10:02 +02:00
Adrien Delorme b0238e6f4a Update build_windows_test.go 2020-07-07 12:00:36 +02:00
Adrien Delorme 3fb7ddf509 Update provisioner.go 2020-07-07 11:52:08 +02:00
Adrien Delorme 12c9959db2 Revert "null builder: say that we are returnin the ID value"
This reverts commit 8e923977f0.
2020-07-07 11:46:43 +02:00
Adrien Delorme d84d956e36 add language coment ! 2020-07-07 11:43:13 +02:00
Adrien Delorme a15ad19411 test builds can be 'excepted' 2020-07-07 11:41:24 +02:00
Adrien Delorme c1c8b8d22a complete -> recipes 2020-07-07 11:31:19 +02:00
Adrien Delorme 34ff3d0c8f hcl2 GetBuilds: use packer.BuilderDataCommonKeys to avoid forcing all builders to return exactly what they will return
It would have been a bit nicer if all builder were more specific in order for hcl to tell wether a value will be set during the first prepare time but that also totally works !
2020-07-07 11:29:27 +02:00
Adrien Delorme ab54f48247 add BuilderDataCommonKeys var to see what common keys a builder can return 2020-07-07 11:28:07 +02:00
Megan Marsh 93cd7e40bc
add note about ansibles configuration powershell script in our docs (#9526)
* add note about ansibles configuration powershell script in our docs

* Update website/pages/docs/provisioners/ansible.mdx

Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-07-06 15:23:29 -04:00
Wilken Rivera b02a2b1c27
Merge pull request #9537 from geofftrojans/import-image-retry
Adding retry for ImportImage call in amazon-import post-processor.
2020-07-06 15:18:40 -04:00
Adrien Delorme 10e5d952ac unquote 'cooking...' 2020-07-06 18:08:51 +02:00
Adrien Delorme 0475b0529d tests: fix line endings in windows 2020-07-06 17:58:22 +02:00
Adrien Delorme 0deaa5d2a5 add a complete tests for builder variables + only/except 2020-07-06 17:01:55 +02:00
Adrien Delorme 8e923977f0 null builder: say that we are returnin the ID value 2020-07-06 16:53:06 +02:00
Geoff Schultz 8010a23b34 Adding retry for ImportImage call in amazon-import post-processor. 2020-07-06 09:41:13 -05:00
Adrien Delorme 0293f69fa1 default build values to be unknown 2020-07-06 16:07:46 +02:00
Adrien Delorme eaf63e3bb5 pass source name from local source name too 2020-07-06 16:07:29 +02:00
Adrien Delorme cf514d31f2 avoid passing generatedVars down during first prepare 2020-07-06 15:14:17 +02:00
Adrien Delorme 0ed10f921f add test 2020-07-06 11:48:39 +02:00
Adrien Delorme 90610dcf04 docs 2020-07-06 11:38:12 +02:00
Adrien Delorme 1b669ff2ab woops 2020-07-06 11:18:02 +02:00
Adrien Delorme 39261f3671 add hcl2 post processor type that reprepares itself 2020-07-06 10:32:39 +02:00
Megan Marsh 7ad140ef50 update changelog 2020-07-02 14:40:11 -07:00
Megan Marsh 6095fb2a62
Merge pull request #9515 from jhawk28/vsphere_tools_fix
fix vsphere ToolsSyncTime and ToolsUpgradePolicy
2020-07-02 14:19:41 -07:00
Jonathan Neal 4a669e829c Update package-lock.json 2020-07-02 14:25:09 -04:00
Jonathan Neal 01f93d8adb Bump internal hashicorp dependencies 2020-07-02 14:25:09 -04:00
Joshua Foster 500ec5ccc7 fix return 2020-07-02 12:55:10 -04:00
Joshua Foster e4dffeed35 clean up if logic 2020-07-02 12:33:28 -04:00
Adrien Delorme db6c3adbba add hcl2 provisioner type that reprepares itself 2020-07-02 18:02:19 +02:00
Adrien Delorme c88cb098a1 Update post-processor.go 2020-07-02 16:04:38 +02:00
Adrien Delorme 6a108fa3f6 bring docs from master 2020-07-02 16:03:57 +02:00
Adrien Delorme 284d46a1e0 WIP 2020-07-02 15:56:49 +02:00
Adrien Delorme 7969b690de Revert "Share build info with Provisioner and Post-Processor via HCL2 variables (#9444)"
This reverts commit 99046c9178.
2020-07-02 15:07:29 +02:00
Adrien Delorme 3d371a2d5d
Add complete HCL2 examples + allow to name a singular build.source blocks (#9490)
* in the examples/hcl folder
* add possibility to name singular build.source blocks to differentiate their output and to filter on them
2020-07-02 11:07:59 +02:00
Megan Marsh 445cf12b65
Merge pull request #9489 from ad-m/hyperone-freebsd
builder/hyperone: Allow skip chroot device discovery
2020-07-01 15:48:03 -07:00
Joshua Foster 63f9282f5c fix vshere ToolsSyncTime and ToolsUpgradePolicy 2020-07-01 13:58:50 -04:00
Megan Marsh af9d2e6f22
Merge pull request #9509 from hashicorp/fix_9508
make statement an array of strings
2020-06-30 13:15:51 -07:00
Megan Marsh 50c65847d1
Merge pull request #9497 from ad-m/hyperone-username
builder/hyperone: Add support for custom username in vm create
2020-06-30 10:51:25 -07:00
Megan Marsh 122e80f591 generated code 2020-06-30 10:12:50 -07:00
Megan Marsh 0122530a07 make statement an array of strings 2020-06-30 10:01:49 -07:00
Roman Tomjak 212200c88f
Proxmox NIC firewall flag (#9487)
* add test for firewall toggle

* generate hcl config

* send firewall toggle to proxmox

* update docs

* drop the pointer to bool

* use setDeviceParamIfDefined
2020-06-30 11:04:19 +02:00
Kevin Pruett 1454f4f6a1
Merge pull request #9503 from hashicorp/pruett.algolia-index-ci
Add Algolia indexing to CI
2020-06-29 16:34:17 -04:00
Kevin Pruett 4f59693be8
Add Algolia indexing to CI 2020-06-29 15:43:35 -04:00
Sylvia Moss 3dc7a53125
Correct check if PackerHttpAddr is implemented or not (#9498) 2020-06-29 16:17:21 +02:00
Rae Krantz cf25ec965d
Merge pull request #9499 from hashicorp/ci/increase-resource-image-size
increase resource size for sigkills
2020-06-29 09:48:17 -04:00
Rae Krantz d690d0f6a6 increase resource size for sigkills 2020-06-29 09:12:03 -04:00
Sylvia Moss 99046c9178
Share build info with Provisioner and Post-Processor via HCL2 variables (#9444) 2020-06-29 13:44:57 +02:00
Neil Kidd c9d546a7ea
Fix broken external link (#9496) 2020-06-29 11:02:37 +02:00
Adam Dobrawy 80d49a1509 builder/hyperone: Add support for custom username in vm create 2020-06-29 03:17:38 +02:00