0609909f1a
Fixed some lint issues.
2020-05-28 13:53:49 -05:00
ad7194c920
Rewrote the GuestIP implementation in the vmware builder to use the new dhcpd lease parsers instead of the old regexp-based logic.
2020-05-28 13:22:58 -05:00
020b005522
Finished implementing the final dhcpd lease entries parser for the vmware builders and also included its own unit tests.
2020-05-28 13:22:58 -05:00
cf5332fa20
Updated the dhcpd lease entry parser in the vmware builder to return errors if any are encountered.
2020-05-28 13:22:58 -05:00
afa4696985
Tightened the regular expressions used by the vmware builder to parse the dhcpd leases, and added support for parsing the weekdays.
2020-05-28 13:22:58 -05:00
e2a7c317eb
Implemented the dhcpd lease entry decoder and the address decoder for the vmware builder.
2020-05-28 13:22:57 -05:00
efb775accb
Added a number of parsing combinators to the vmware builder and some minor tests for them to help with parsing dhcpd leases.
2020-05-28 13:22:57 -05:00
f17007d546
Removed the sentinelSignaller chan from the vmware builder parsers and its unit-tests, and also commented all of the goroutines that are used.
2020-05-28 13:22:56 -05:00
159ea595df
More lint issues fixed...
2020-05-28 13:12:42 -05:00
32b64e0576
Fixed some lint issues in the unit tests for the vmware builder driver parsers.
2020-05-28 13:07:54 -05:00
0fa60c68fb
Drop the iso_checksum_type & iso_checksum_url fields ( #8437 )
...
* Drop the iso_checksum_type & iso_checksum_url fields
In favor of simply using iso_checksum that will know what to do.
* fix after master merge
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* remove checksum lowercasing tests
* Update builder_test.go
* Update builder_test.go
* better docs
* Update builder_test.go
* even better docs
* Update config.go
* Update builder_test.go
* Update step_create_vmx_test.go
* make generate
* better docs
* fix imports
* up tests
* Update _ISOConfig-required.html.md
* Update builder_test.go
* don't use sha1.Sum("none") as a caching path
* Update builder_test.go
* better docs
* Update iso_config_test.go
remove ISOChecksumType/ISOChecksumURL references
* Update step_download_test.go
* add iso_checksum_url and iso_checksum_type fixers + tests
* add concrete examples of checksum values
* add examples of checksumming from local file
* update go-getter dep
* up deps
* use new go-getter version
* up ESX5Driver.VerifyChecksum: use go-getter's checksumming
* ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum
* Update iso_config.go
* get go-getter from v2 branch
* Update driver_esx5.go
add more comments
* Update driver_esx5.go
* show better error message when the checksum is invalid
* Update builder_test.go
put in a valid checksum to fix tests, checksum is md5("packer")
* Update builder_test.go
test invalid and valid checksum
* more test updating
* fix default md5 string to be a valid md5
* TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming
* Update iso_config_test.go
* Update iso_config_test.go
* Update builder_test.go
* Update builder_test.go
* Update builder_test.go
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update go.mod
* Update go.mod
* Update CHANGELOG.md
2020-05-28 11:02:09 +02:00
2a8bc45bc4
Added unit-tests for the netmap parsing components in the vmware builder.
2020-05-26 23:03:30 -05:00
7c1ad4adcf
Added unit-tests for the dhcpd configuration components in the vmware builder, and fixed a few discovered race conditions.
2020-05-26 22:59:35 -05:00
1c30a71d09
Replace file shared state by statebag ( #9238 )
2020-05-19 11:49:48 +02:00
e8f8ebf132
builder/vmware: Add some additional debug logging to the driver version check ( #9064 )
2020-04-15 10:34:48 +02:00
a48c0ecf49
update docs for headless to help users know they may need to launch the gui
2020-04-08 13:53:19 -07:00
2999934326
fix generation script, bugfixes in source comments, update website paths in primary codebase
2020-04-07 17:53:22 -04:00
9165be87da
packer.io prefix removal, html extension remove for in-code errors
2020-04-07 17:53:22 -04:00
4afd107eeb
patch source files for extensions changes
2020-04-07 17:50:51 -04:00
b17b211aa9
Add cleanup_remote_cache config option to vmware-iso ( #8917 )
2020-03-24 16:16:25 +01:00
88297c796d
Merge branch 'master' into hcl2_singular_blocks
2020-03-17 14:47:17 +01:00
94a1f0bcb6
go fmt
2020-03-17 12:05:37 +01:00
c3d793255e
Do not test if NIC is reachable when ssh bastion is required
...
Relates to https://github.com/hashicorp/packer/issues/8866
2020-03-11 19:27:48 -04:00
e1a46ec293
Fix gosimple S1025 linting errors ( #8838 )
...
Remove unneeded use of fmt.Sprintf for variables that are already strings.
2020-03-04 15:31:30 -05:00
9ec8b67392
Add golangci-lint to project ( #8686 )
...
* Add golangci-lint as linting tool
* Disable failing staticchecks to start; GitHub issue to handle coming soon
* Run `goimports -w` to repair all source files that have improperly
formatted imports
* makefile: Add ci-lint target to run on travis
This change adds a new make target for running golangci-lint on newly
added Go files only. This target is expected to run during Packer ci builds.
* .github/contributing: Add code linting instructions
* travis: Update job configuration to run parallel builds
2020-02-14 11:42:29 -05:00
dc31bad539
Sharing info with post-processors via artifact ( #8632 )
2020-01-30 11:27:58 +01:00
61bee60ecf
Add StepHttpIpDiscover tests
2020-01-28 10:31:17 +01:00
df38d11270
Fix compilation error
2020-01-27 17:15:13 +01:00
0566f1f999
Extract http ip discover to a new step
2020-01-27 17:06:56 +01:00
8c8de27509
add note about error abort to vmware warning
2020-01-24 09:02:30 -08:00
d6a351b173
Rename communicator config variables and remove deprecated code ( #8584 )
2020-01-09 08:37:30 -08:00
be3c1ef106
bump the timeout to a very high level to protect against laggy CI machines
2020-01-07 09:59:25 -08:00
84063d2132
implement ID and Type values in the provisioner template info sharing
2019-12-13 11:57:01 -08:00
c66219084e
Fix error message when ovftool is missing
2019-11-14 23:11:16 +00:00
5f02150e05
builder/vmware/common: defer close after testing for errors
2019-11-06 14:28:17 -08:00
9924d16fc3
builder/vmware/common: remove unused testHWConfig()
2019-11-01 19:13:26 -07:00
2b795053b4
builder/vmware: fix dropped test errors
2019-09-27 16:05:12 -07:00
c24693372d
Merge pull request #8132 from scienty/support_floppy_vmx_esxi
...
Support floppy_files for vmx on esxi
2019-09-23 12:20:49 -07:00
67be007f45
Support floppy_files for vmx on esxi
2019-09-20 00:23:28 +05:30
ba9ffcbf73
re-indent HWConfig struct comments
2019-09-03 17:35:29 +02:00
b3cdf2ac8f
remove docs typo
2019-08-27 15:16:33 +02:00
4cb7c30987
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-08-21 16:44:23 +02:00
991cf22504
Prevent endless reading of closed file in vmware plugin
2019-07-16 16:02:57 +03:00
4a61dc3670
vmware: document using partials
2019-06-20 15:28:27 +02:00
c11ef90cb6
use interpolate.NewContext() instead of testConfigTemplate(t)
...
because it's what's happenning there
2019-06-14 12:17:28 +02:00
926c8bbaa6
refactor ShutdownConfig into a single struct
2019-06-14 12:17:28 +02:00
4bf6a56d71
split communitacor.SSH & communitacor.WinRM to facilitate documentation
...
put doc for communicator into the struct
2019-06-06 16:55:24 +02:00
4399684372
make fmt autogenerated docs
2019-06-06 16:29:25 +02:00
e6cbb013ba
add // go:generate struct-markdown to all previously edited files
2019-06-05 16:42:18 +02:00
f1917edd34
generate the comments for config struct of builders scraping doc website
2019-06-05 16:42:17 +02:00
f7c1b5e940
add 30 minute timeout for destroying a VM
2019-04-23 12:55:59 -07:00
56c7593725
fix panic in StepConfigureVNC
...
When the driver is the esx5 driver s.l won't be set at all. Meaning this will crash.
In the esx5 driver we try to dial possible ports to see if it works so it doesn't make sense to use packer's `net.ListenRangeConfig`. It could make sense to have a net.DialRangeConfig but this sounds a bit too specific and not broad enough to do.
fix #7505
2019-04-16 15:32:05 +02:00
f555e7a9f2
allow a provisioner to timeout
...
* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
2019-04-08 20:09:21 +02:00
c4f3dccc14
rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts
2019-04-03 15:56:15 +02:00
ac92916b01
StepConfigureVNC: close listener only once
2019-03-26 10:58:51 +01:00
a3838ecfad
error on negative ports
2019-03-19 15:21:09 +01:00
5a6dffde9a
use port as ints
2019-03-19 15:01:12 +01:00
f828b72c10
step configure vnc: allow to use ESX5Driver again
2019-03-19 12:54:15 +01:00
c214f6735b
make everything a uint
2019-03-19 12:54:15 +01:00
b5d78d47f5
vmware StepConfigureVNC: use common/net pkg to find open port
2019-03-19 12:54:15 +01:00
cef3d0eb24
Ran make fmt per Megan's request.
2019-03-01 14:16:00 -05:00
109ba2c54c
After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty.
2019-02-28 21:36:25 -05:00
e74a81e27b
Deny the copying of .vmxf from the source VM to the target VM. If this file gets copied over to the new VM once the VM gets deleted the .vmxf and the folder for the VM stay on the datastore. This causes Packer to hang because the folder on the datastore does not go away during the cleanup process.
2019-02-28 16:47:46 -05:00
1127096beb
Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted.
2019-02-28 16:43:47 -05:00
5cc442872e
Merge pull request #7314 from hashicorp/fix_7234
...
add noSSLVerify to ovftool args
2019-02-19 16:54:48 -08:00
bbc52f9a7d
add noSSLVerify to ovftool args
2019-02-14 12:10:58 -08:00
bd3339f1f9
also strip \r to work around windows file ending strangeness
2019-02-13 15:41:37 -08:00
6ea64bc378
Merge pull request #7191 from arizvisa/GH-7190
...
Adds support to the vmware builders for specifying the number of cores per socket via the `cores` option.
2019-01-31 15:27:52 -08:00
ce8f5c31df
escape query as suggested in issue #7200
2019-01-23 11:04:14 -08:00
9d2f98394e
Revert "Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`."
...
This reverts commit 0c37a3c68f
2019-01-17 14:49:07 -06:00
0c37a3c68f
Renamed the terse option, `cores`, to to the less-terse version `cores_per_socket`.
2019-01-17 10:39:19 -06:00
062c62eed8
Added support for specifying the number of cores as `cores` to vmware-common.
2019-01-17 10:39:19 -06:00
0821653256
Fix 'nil' dir in VMware artifact when building locally
2018-12-14 13:21:41 +00:00
96bdf17d2e
Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders.
2018-12-03 18:03:02 -06:00
fa4998e1ec
Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image.
2018-12-03 17:50:40 -06:00
3512c3c5ea
Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later.
2018-12-03 17:48:05 -06:00
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
...
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
ec75913412
fix crash that occurs when dir is nil
2018-11-27 16:34:26 -08:00
f8c23c1808
Updated things related to the vmware-iso builder to include @azr's suggestions.
2018-11-22 21:03:06 -06:00
61ee3a44f5
Modified the cpus and memory options for the vmware builders to only apply them if they were specified.
2018-11-21 00:43:14 -06:00
fb7ce9f2b5
Renamed both `cpu_count` and `memory_size` to `cpus` and `memory` (respective).
2018-11-17 06:36:02 -06:00
cd45248eaa
Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize.
2018-11-17 06:08:08 -06:00
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
...
Closes #5317
2018-11-17 09:32:15 +01:00
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
...
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
89184ae384
rework if/else to simplify main code body.
2018-11-12 13:21:25 -08:00
536e0501ac
Validate username/password for ovftool during prepare.
...
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
...
add new display_name template option
2018-11-12 08:49:38 -08:00
f1fa28847f
remove debug line.
...
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
e5c4a4a6fb
create export directories for vmx and ovf file types, too.
2018-11-09 11:45:36 -08:00
68c9e34bfe
add new display_name template option
2018-11-09 10:54:31 -08:00
790d5661c5
escape username
2018-11-06 11:30:45 -08:00
96d628eef1
fix silliness with pointers
2018-11-06 09:50:28 -08:00
5c2ca450bd
fix tests
2018-11-02 15:44:27 -07:00
5815b376b4
remove unnecessary checks; we always default format to ovf if it is unset.
...
fix exportoutputdir
2018-11-02 14:22:01 -07:00
c3144c2d0a
add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build.
2018-11-02 14:22:01 -07:00
c3d6d45696
modify test so that it accesses CommConfig the same way we really do within the driver
2018-11-02 14:22:01 -07:00
f18bb19f96
remove redundant config; CommConfig was already a part of the SSSHConfig struct
2018-11-02 14:22:01 -07:00
fa12113eaf
remove unused NewLocalArtifact
...
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
2ae235a28a
fix tests
2018-10-25 14:41:01 -07:00
290f4a7c4c
cleanup to make it actually build after that monstrous rebase
2018-10-25 14:17:35 -07:00
Ali Rizvi-Santiago
Adrien Delorme
Sylvia Moss
Wilken Rivera
Megan Marsh
Jeff Escalante
Adrien Delorme
Paul Cichonski (pcichons)
Stephen Tawn
Lars Lehtonen
Prakash Sidaraddi
Vladislav Rassokhin
Eric Mowry
DanHam
Rickard von Essen