sylviamoss
2de3f2755a
add step_remove_floppy tests
2020-09-23 12:00:28 +02:00
sylviamoss
7cd6ee2b3b
add FindDatastore driver test
2020-09-22 17:42:35 +02:00
sylviamoss
b881a59bc8
refactor vcenter simulator setup
2020-09-22 16:48:53 +02:00
sylviamoss
7b1af2c4e8
add step_add_floppy unit tests
2020-09-22 16:23:11 +02:00
sylviamoss
b46f587450
vsphere-clone use common step_add_cdrom
2020-09-22 11:34:49 +02:00
upodroid
be56632f7e
fix vendoring
2020-09-20 16:50:03 +01:00
upodroid
9b121e85f9
fix dodgy pointers
2020-09-20 15:31:45 +01:00
Upo
3f6230470b
Merge branch 'master' into google-impersonation
2020-09-20 15:23:04 +01:00
upodroid
2faacfd5d7
add service account impersonation
2020-09-20 15:18:37 +01:00
Marco Molteni
4d7e42220b
scaleway: add pre validate step (check image and snapshot names) ( #9840 )
...
* Implement Stringer inteface for multistep.StepAction
* scaleway: add pre validate step (check image and snapshot names)
Before, it was possible to create multiple images with the same name,
leading to a confusing and wasteful situation (same for snapshots).
Now, we perform the same kind of checks done by the AWS EC2 builder,
and refuse to proceed if there is an existing image with the same name
(same for snapshots).
As usual, invoking `packer build -force` will bypass the checks.
Closes #9839 .
2020-09-18 15:37:48 -04:00
Megan Marsh
77817f80a2
Merge pull request #9956 from hashicorp/do_6734
...
builder/qemu: Add qemu_img_args option to set special cli flags for our calls to qemu-img
2020-09-18 11:24:34 -07:00
Megan Marsh
b7b43a41f3
review cleanup
2020-09-18 10:56:28 -07:00
sylviamoss
778d77e4a2
add floppy and cd to vsphere-clone
2020-09-18 17:09:01 +02:00
Sylvia Moss
d347bbec4c
Retry fleet creating only on invalid IAM instance profile ( #9946 )
2020-09-18 17:05:36 +02:00
Anthony Dong
eca9b2f30d
aws ebs_surrogate: fix unhonored kms_key_id ( #9959 )
2020-09-18 12:39:07 +02:00
Sylvia Moss
ce2047f30b
vSphere StepAddCDRom tests ( #9955 )
2020-09-18 09:57:01 +02:00
Megan Marsh
1d218d9e65
add QemuImgArgs option to set specialized flags in qemu-img
...
convert, resize, and create commands. Add tests. Refactor steps to
not require config pulled from statebag.
2020-09-17 15:15:04 -07:00
Megan Marsh
1052733fca
Skip qemu-img convert if format of output file matches format of input file.
...
This works around an osx bug in qemu-img convert in osx.
2020-09-17 11:21:04 -07:00
Megan Marsh
83ee4e7d13
miscellaneous qemu cleanup. Fix generator strings; generate code
...
fix diskimage logic
linting
fix tests
2020-09-17 09:57:45 -07:00
Megan Marsh
3577c4a283
refactor multistep array construction in qemu builder to push majority of conditionals into their steps rather than the multistep constructor code.
2020-09-17 09:57:45 -07:00
Megan Marsh
9ac76be190
clean up step_run
2020-09-17 09:57:45 -07:00
Megan Marsh
5b714497e6
qemu: split config and config tests into their own files to match best practices from other builders
2020-09-17 09:57:45 -07:00
Megan Marsh
6c0c603fbf
stub out test
2020-09-17 09:57:45 -07:00
Sylvia Moss
9737b85bbc
Remove usb_keyboard option ( #9945 )
2020-09-17 10:38:33 +02:00
Wilken Rivera
b4be598148
Fix static check issues SA1019 for googlecompute plugins ( #9950 )
...
This change replaces the deprecated constructors `New` with
`NewService`.
Static check before the change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google
- post-processor/googlecompute-import/post-processor.go:183:18: SA1019:
storage.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- post-processor/googlecompute-import/post-processor.go:219:18: SA1019:
compute.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- post-processor/googlecompute-import/post-processor.go:273:18: SA1019:
storage.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- builder/googlecompute/driver_gce.go:127:18: SA1019: compute.New is
deprecated: please use NewService instead. To provide a custom HTTP
client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- builder/googlecompute/driver_gce.go:132:25: SA1019: oslogin.New is
deprecated: please use NewService instead. To provide a custom HTTP
client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
```
Static check after change
```
[go-1.15.2] [1] wilken@automaton in ~/Development/packer/
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google
```
2020-09-17 10:14:41 +02:00
Sylvia Moss
7736ae6c67
Add VMware vnc_over_websocket option ( #9938 )
2020-09-16 11:02:46 +02:00
Sylvia Moss
bdd736b800
Interpolate vagrantfile_template on Vagrant post-processor ( #9923 )
2020-09-16 10:08:44 +02:00
Megan Marsh
bc69db2433
Merge pull request #9941 from hashicorp/cd_files_vsphere
...
add cd_files to vsphere builder
2020-09-15 11:25:01 -07:00
Megan Marsh
ef01bb5ba6
generated code
2020-09-14 15:35:38 -07:00
Megan Marsh
e70e8c8651
add cd_files
2020-09-14 14:59:51 -07:00
Jeff Wong
5d15f5e2f4
No longer need a 15 second sleep
2020-09-14 13:36:26 -07:00
Megan Marsh
f28cabb162
Merge pull request #9940 from hashicorp/fix_9936
...
skip slot 7 in disk creation so we don't use reserved slot
2020-09-14 13:36:16 -07:00
Megan Marsh
b08dd28b85
skip slot 7 in disk creation so we don't use reserved slot
2020-09-14 13:13:59 -07:00
Megan Marsh
e00f6afff8
Merge pull request #9918 from hashicorp/fix_7408
...
skip compaction when backing file is used, to prevent conversion that…
2020-09-14 13:09:13 -07:00
Megan Marsh
6d2df7fb55
Merge pull request #9932 from hashicorp/cd_files_on_virtualbox
...
Implement cd_files for virtualbox builders.
2020-09-14 13:08:23 -07:00
Jeff Wong
3c9969d841
cleanup goimports for linter
2020-09-14 12:49:38 -07:00
Megan Marsh
eab7672519
regenerate code
2020-09-14 12:16:56 -07:00
Megan Marsh
e723609ef1
regenerate hcl config
2020-09-14 12:16:56 -07:00
Megan Marsh
6935f47809
add tests for disk defaulting
2020-09-14 12:16:56 -07:00
Megan Marsh
eae3fda901
refactor out disk defaulting so it can be used to default the vmx cdrom too
2020-09-14 12:16:56 -07:00
Megan Marsh
9140985ab0
implement cd_files for qemu builder
2020-09-14 12:16:56 -07:00
Megan Marsh
f774983d36
implement on hyperv
2020-09-14 12:16:56 -07:00
Jeff Wong
018a1a5da0
Correct full clone logic
2020-09-14 12:15:07 -07:00
Jeff Wong
681d0f8467
Correct builder ID
2020-09-14 11:59:47 -07:00
Jeff Wong
99c3872a48
run go fmt
2020-09-14 11:58:50 -07:00
Megan Marsh
698bef434f
track whether we've detached disks so we don't duplicate work
2020-09-14 11:00:35 -07:00
Megan Marsh
a92491d17b
capitalization
2020-09-14 10:40:07 -07:00
Andreas Botzner
c032d463d3
Bootcommand Fix For Proxmox Builder ( #9885 )
2020-09-14 17:17:38 +02:00
Sylvia Moss
caf65781d7
Add vsphere-clone mac_address option ( #9930 )
...
* add vsphere-clone mac_address option
* check on prepare if network is set together with mac_address
2020-09-14 13:18:39 +02:00
Andreas Botzner
3739970b84
Adds ability to specify interfaces for http_directroy and VM for the Proxmox builder ( #9874 )
...
Adds two config options to the Proxmox builder:
```
http_interface
vm_interface
```
Both give the user the ability to specify an interface whos IP will be set as the `.HTTPIP` and VMIP respectively.
This is useful when the VM and or the machine executing Packer has multiple interfaces.
Until now Packer would accept the first non-loopback IP as the `.HTTPIP` and VMIP.
I'm open to suggestions and any kind of feedback.
* Added ability to define the NIC where the HTTPIP is taken from.
* Added VM interface config option
* fmt and documentation
* Moved HTTPInterface into HTTPCommon
* Build Fix
* Documentation Fix
2020-09-14 12:24:01 +02:00
Jeff Wong
aa5eb770d0
DEV: use proper interfaces for vmCreator
2020-09-11 16:45:16 -07:00
Megan Marsh
b73825bb72
Implement cd_files for virtualbox builders.
...
Since the work to mount isos was duplicated already across the
step_mount_iso and step_mount_guest_additions, this required a
refactor to prevent further code duplication and make the
ports and devices easier to follow
2020-09-11 16:23:29 -07:00
Marin Salinas
abdb4bcfbf
refactor: change ssh host to osc ssh host
2020-09-11 12:11:52 -05:00
Marin Salinas
645e5afa36
refactor: change bsuvolume builder to new SDK
2020-09-11 12:11:24 -05:00
Marin Salinas
b844b7f1c7
refactor: change bsusurrogate builder to new SDK
2020-09-11 10:38:13 -05:00
Marin Salinas
007f6cce4c
feat: add wait funtions for snapshot and omi in osc builders
2020-09-11 09:47:08 -05:00
Sylvia Moss
31f08909b4
Add usb_scan_codes option to use USB scancodes instead of VNC for remote builds ( #9895 )
2020-09-11 16:46:33 +02:00
Marin Salinas
eed047b83b
feat: add proxy support to osc builder
2020-09-11 09:46:04 -05:00
Jeff Wong
cfece501d0
Implement proxmox-clone
2020-09-09 23:55:35 -07:00
Megan Marsh
8b9009c571
Merge pull request #9856 from OblateSpheroid/add_vnic_details
...
Feat (builder/oracle-oci): Add VNIC details to launch details
2020-09-09 16:15:48 -07:00
Megan Marsh
8ffa0d2060
Merge pull request #9842 from jason-azze/patch-1
...
Builders vsphere-iso and vsphere-clone - CPUs is actually for cores, not sockets.
2020-09-09 16:03:45 -07:00
Megan Marsh
ca650c9602
fix struct comment for generation
2020-09-09 16:01:30 -07:00
Megan Marsh
0a02bd5b2a
skip compaction when backing file is used, to prevent conversion that would make backing file pointless
2020-09-09 15:26:10 -07:00
js-g
9d5dedc3db
tests: add some fields to config_test
2020-09-09 09:25:58 -04:00
Patrik
f8e31bff12
feat(builder): bump scaleway to new sdk ( #9902 )
2020-09-09 10:27:48 +02:00
Wilken Rivera
0719f906d4
Replace if/else with simple if ( #9913 )
2020-09-09 10:24:17 +02:00
Megan Marsh
8aaa1bd7a6
Merge pull request #9796 from hashicorp/do_8778
...
create secondary iso containing user's desired files
2020-09-08 15:05:48 -07:00
js-g
dd54651125
fix (builder/oracle-oci): add freeform and defined tags to create_vnic_details
2020-09-08 14:40:21 -04:00
Richard Turc
b4ff0ea4bc
[builder/qemu] Skip resize step when skip_resize_disk is enable #9860 ( #9896 )
...
* [builder/qemu] Skip resize step when skip_resize_disk is enable #9860
* Update builder/qemu/builder_test.go
Improve the code quality
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
* Update files for unit tests
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-09-08 14:32:08 -04:00
js-g
f5dc260cf5
refactor (builder/oracle-oci): pass CreateVnicDetails as struct instead of map
2020-09-08 12:03:18 -04:00
Ronald van Zantvoort
7335695c84
qemu vnc: hardcoded lowerbound leaves negative ports
...
```hcl2
vnc_port_min = 5000
vnc_port_max = 5500
```
Build returns faulty:
```
qemu.one: view the screen of the VM, connect via VNC to vnc://127.0.0.1:5138
(...)
2020/09/06 19:09:52 packer-builder-qemu plugin: Qemu stderr: qemu-system-x86_64: -vnc 127.0.0.1:-762,password: can't convert to a number: -762
```
2020-09-06 21:18:12 +02:00
Calle Pettersson
905869308d
Split proxmox builder into a common part and iso/clone builders
...
Clone builder is still just a stub. Proof-of-concept for #9626
Signed-off-by: Calle Pettersson <calle@cape.nu>
2020-09-04 23:53:09 +02:00
Megan Marsh
d2dd158fe2
Implement cd_files option. The Addfile code is modified from the floppy_files
...
tooling. Tested on OSX, `Windows, and Linux. Documented command line dependencies.
Added acceptance tests (behind testacc flag, since there are dependencies).
This option is only implemented for the vmware and hyperv iso builders. It will be
implemented for others in later PRs in order to make review easier.
2020-09-04 12:20:19 -07:00
Megan Marsh
dfe8aa51b0
Merge pull request #9845 from hashicorp/run_and_stream_helper_func
...
move runAndStream into a generalized helper function to enable easy l…
2020-09-04 12:19:37 -07:00
Megan Marsh
5120ad9d9a
add test file
2020-09-04 11:56:32 -07:00
Megan Marsh
20d62654ae
move runAndStream into a generalized helper function to enable easy local exectution in other places than just the docker builder
2020-09-04 11:56:32 -07:00
Lars Lehtonen
03a0beb683
builder/vmware/common: simplify type assertion switch ( #9893 )
2020-09-04 16:25:19 +02:00
Sylvia Moss
ba74602d63
Allows publishing to a Shared Image Gallery with a different subscription id ( #9875 )
2020-09-03 17:13:32 +02:00
catsby
7a7d3ff350
Remove comments about sharing with catsby
2020-09-03 09:14:40 -05:00
Troy Lindsay
d1a61cac33
Add NVMe controller support to vsphere-iso builder ( #9880 )
2020-09-03 11:14:58 +02:00
Troy Lindsay
602729ac23
Fix vsphere-iso acceptance tests ( #9878 ) ( #9881 )
2020-09-03 10:17:49 +02:00
Rae Krantz
ab23e839c8
update sharing test to req aws account id
2020-09-02 11:44:38 -04:00
Sylvia Moss
903deb9e6a
vSphere StepHardware tests ( #9866 )
2020-09-02 10:19:57 +02:00
Megan Marsh
e96cc07a1a
Merge pull request #9853 from remyleone/boottype_local
...
change default scaleway boottype to local
2020-09-01 10:44:42 -07:00
Sylvia Moss
24dbd0a28b
Fix iso_path validation regex ( #9855 )
2020-09-01 10:11:48 +02:00
Wilken Rivera
f4556fd3f1
Merge pull request #9831 from hashicorp/remedial_remote_export_config_tests
...
add tests to make sure prepare for export defaults properly
2020-08-31 15:47:05 -04:00
js-g
f74a425661
feat (builder/oracle-oci): pass CreateVnicDetails to instance
2020-08-31 13:13:33 -04:00
Sylvia Moss
58a0bdd780
Look for a default resource pool when root resource pool is not found ( #9809 )
2020-08-31 16:26:48 +02:00
Wilken Rivera
03a374f4b6
Fix linting issues for SA6005 check ( #9854 )
...
Before change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
builder/profitbricks/step_create_server.go:254:22: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/oneandone/config.go:97:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/vmware/common/driver_parser.go:1199:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
```
After change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
```
2020-08-31 15:44:42 +02:00
GennadySpb
804fefef17
yandex-import: allow set custom API endpoint ( #9850 )
...
* Separate Access Config from yandex builder Config
* make use of Access Config explicit
* Move `MaxRetries` into AccessConfig
* NewDriverYC use AccessConfig instead Config
* yandex-import PP use common Access Config
Now support set custom API Endpoint
* yandex-export PP use common Access Config
Now support set custom API Endpoint too (as yandex-import)
* fix test
* Tiny doc updates.
2020-08-31 15:29:20 +02:00
OblateSpheroid
0ad26cce01
Feat (oracle-oci): allow freeform and defined tags to be added instance ( #9802 )
...
* feat (oracle-oci): allow freeform and defined tags to be added to instance (#6313 )
* docs (oracle-oci): add descriptions for instance_tags and instance_defined_tags (#6313 )
* fix: fmt
* fix: generate hcl2spec
2020-08-31 14:36:09 +02:00
Rémy Léone
ecd1a49a35
change default scaleway boottype to local
2020-08-31 13:15:37 +02:00
Andreas Botzner
e4f975fae1
Allows for the mounting of ISOs when a Proxmox VM s created. Same as … ( #9653 )
...
Allows the mounting of additional ISOs when the VM is created. The config option was taken from PR #9055 and slightly changed. Users can specify an array of bus names, bus numbers and filenames.
"cd_drive":[
{
"bus": "ide",
"bus_number": 3,
"filename": "isos:iso/virtio-win-0.1.187.iso"
},
{
"bus": "sata",
"bus_number": 3,
"filename": "isos:iso/someother.iso"
}
]
Closes : #7950
Co-authored-by: Calle Pettersson <carlpett@users.noreply.github.com>
2020-08-31 10:48:24 +02:00
Sylvia Moss
942bfbf221
Add driver mocks and write tests to steps Remote Upload and Create VM ( #9833 )
2020-08-31 10:34:41 +02:00
Megan Marsh
1c5bc41beb
refactor ovftool validation into vmware driver
2020-08-27 10:55:57 -07:00
Megan Marsh
bbc3a5b0d1
add tests to make sure prepare for export defaults properly
2020-08-27 10:55:57 -07:00
Marin Salinas
e0badb3fb7
refactor: update step_update_omi_attributes and create_tags to new OSC SDK
2020-08-26 12:25:46 -05:00
Megan Marsh
a6d5106cd7
Allow "export" to ovf/ova for local vmware builds in addition to esx ones.
...
Refactor step_export and the driver interface to move the ovftool call
into the vmware driver. This refactor allows us to add meaningful tests
to step_export, which I have also added here.
2020-08-26 09:45:12 -07:00
Megan Marsh
e9b526ee2d
Move step_create_disk into common folder, and add to vmx builder ( #9815 )
...
Pull additional disk related config options into their own file.
2020-08-26 10:13:11 +02:00
Marin Salinas
8885a5ef31
refactor: update step_create_omi to new OSC SDK
2020-08-25 18:02:11 -05:00
Marin Salinas
f0dc26613a
Merge pull request #7 from marinsalinas/step_deregister_omi
...
Step Deregister OMI
2020-08-25 17:22:58 -05:00
Adrien Delorme
0d0bd9ce75
name fields of PolicyDocument correctly in HCL ( #9812 )
...
withouth this fix we would have had to do
```hcl
temporary_iam_instance_profile_policy_document {
statement {
action = ["*"]
effect = "Allow"
resource = ["*"]
}
version = "2012-10-17"
}
```
instead of the same document but with capitalised fields
2020-08-25 10:53:56 +02:00
Adrien Delorme
a0c09e85df
retry spot instance creation when an "Invalid IAM Instance Profile name" error pops up ( #9810 )
...
PutRolePolicy & AddRoleToInstanceProfile are eventually consistent but it is not possible to wait for them to be done here: 0785c2f6fc/builder/amazon/common/step_iam_instance_profile.go (L117-L134)
which was causing the `CreateFleet` to fail (100% for me). So for now we retry a bit later. Waiting 5 seconds after the previously linked code also fixed this.
Test file:
```json
{
"builders": [
{
"type": "amazon-ebs",
"region": "eu-west-1",
"ami_name": "ubuntu-16.04 test {{timestamp}}",
"ami_description": "Ubuntu 16.04 LTS - expand root partition",
"source_ami_filter": {
"filters": {
"virtualization-type": "hvm",
"name": "ubuntu/images/*/ubuntu-xenial-16.04-amd64-server-*",
"root-device-type": "ebs"
},
"owners": [
"099720109477"
],
"most_recent": true
},
"spot_price": "0.03",
"spot_instance_types": [
"t2.small"
],
"encrypt_boot": true,
"ssh_username": "ubuntu",
"ssh_interface": "session_manager",
"temporary_iam_instance_profile_policy_document": {
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"*"
],
"Resource": "*"
}
]
},
"communicator": "ssh"
}
]}
```
2020-08-25 10:10:32 +02:00
Sylvia Moss
2152fa3313
Accept content library path in iso_paths ( #9801 )
2020-08-24 16:54:30 +02:00
Marin Salinas
8166dad533
Merge pull request #5 from marinsalinas/step_cleanup_volumes
...
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-21 15:03:47 -05:00
PacoDw
8274d4848c
chore: added forece_deregister in the test case to verify the step_deregister_omi
2020-08-21 13:30:21 -05:00
PacoDw
071854ea4a
chore: implemented OSC API in step_deregister_omi
2020-08-21 13:29:41 -05:00
PacoDw
a13dfe1f42
chore: added GetRegion() and NewOSCClientByRegion functions
2020-08-21 13:29:27 -05:00
PacoDw
60bd61dc18
chore: removed security group filter function, it was moved to step_security_group file
2020-08-21 11:31:00 -05:00
PacoDw
c3a4b60ea5
chore: implemented OSC API in step_security_group
2020-08-21 11:30:10 -05:00
Marin Salinas
7a45e4c8b0
refactor: change step tag bsu volumes to new OSC SDK
2020-08-21 10:40:14 -05:00
Marin Salinas
c58d6f9b33
refactor: migrate run vm step to new SDK
2020-08-21 10:10:25 -05:00
Marin Salinas
6f0bb33c9a
refactor: change tags ssh file to new OSC SDK
2020-08-20 20:35:51 -05:00
Marin Salinas
e5c14044fb
refactor: change tags file to new OSC SDK
2020-08-20 19:12:38 -05:00
Marin Salinas
addc3dd6e7
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-20 18:33:02 -05:00
Marin Salinas
d9a7626249
Merge pull request #4 from marinsalinas/step_public_ip
...
Step public ip
2020-08-20 18:04:03 -05:00
PacoDw
7745369dce
chore: set true associate_public_ip_address attribute to test the step_public_ip
2020-08-20 14:00:13 -05:00
PacoDw
86966ecfee
:chore: implemented OSC API in pre_public_ip step
2020-08-20 13:59:25 -05:00
Sylvia Moss
ada2a431ef
Modularise vCenter rest client ( #9793 )
2020-08-20 17:55:25 +02:00
Sylvia Moss
99800619b7
Add HCL2 examples to the virtualbox builders ( #9788 )
2020-08-20 15:43:38 +02:00
Sylvia Moss
a1524bf96a
Add option to also import OVF templates to the Content Library ( #9755 )
2020-08-19 13:20:25 +02:00
PacoDw
232d5a3ce6
chore: changed oapi to osc
2020-08-18 15:06:00 -05:00
Megan Marsh
a2cfaace59
extract output dir configuration and defaulting into the step_output_dir, using pointers to make sure they get set properly back on the main config
2020-08-18 12:50:06 -07:00
Megan Marsh
3b2bedf794
implement a remote_output_directory option, and heavily comment output code
2020-08-18 12:50:00 -07:00
PacoDw
43e9d43ebd
chore: removed API attribute
2020-08-18 13:52:49 -05:00
Marin Salinas
8b2cdc5821
refactor: change step_network_info to new OSC SDK
2020-08-18 13:33:45 -05:00
Marin Salinas
8649496c6c
refactor: change new sdk on step_source_omi_info
2020-08-18 13:33:45 -05:00
PacoDw
4431bb87b2
:chore: added api key to specify the API connection
2020-08-18 13:33:45 -05:00
PacoDw
823b957a1f
:chore: implemented OSC connection in pre_validate file
2020-08-18 13:33:45 -05:00
PacoDw
22481d1ac2
:chore: added OSC Connection in builder file
2020-08-18 13:32:38 -05:00
PacoDw
1fbe715c13
:chore: added OSC Connection in builder file
2020-08-18 12:23:39 -05:00
Megan Marsh
b0d2201d55
Merge pull request #9782 from hashicorp/fix_9151
...
fully destroy vm if it was cancelled or errored
2020-08-18 07:22:18 -07:00
Megan Marsh
0a5cd953fc
fully destroy vm if it was cancelled or errored
2020-08-17 14:07:58 -07:00
Megan Marsh
aa2418cf01
add progress tracker to vmware-esx iso upload. Add colored prefix to … ( #9779 )
...
* add progress tracker to vmware-esx iso upload. Add colored prefix to tracker to make it clear which build a tracker belongs to.
* fix mock; fix tests
2020-08-17 14:35:42 -04:00
Megan Marsh
d74b47b734
Merge pull request #9777 from hashicorp/fix_9756
...
Add aws_polling config option to override env variables
2020-08-17 10:49:38 -07:00
sylviamoss
1a0d5a93ee
fix max_attempts typo
2020-08-17 17:58:22 +02:00
sylviamoss
788dc32598
add aws_polling config option to override env variables
2020-08-17 17:15:32 +02:00
PacoDw
1bfb2d9170
:chore: implemented transport file to make the OSC API Connection
2020-08-17 10:04:28 -05:00
PacoDw
1055007cba
:chore: added OSC API Client Connection
2020-08-17 10:02:00 -05:00
Isaac Buckman
46a26a3d9e
Fix Hyper-V boot command refs #5291 ( #9765 )
2020-08-17 16:00:43 +02:00
Megan Marsh
8b4993e44c
fix docs for kms key ids ( #9766 )
2020-08-14 11:35:35 +02:00
PacoDw
74f868da37
:chore: changed the AMI with an existing AMI to work fine with the test case
2020-08-13 17:03:32 -05:00
Megan Marsh
acba3ea3e7
Document network path ( #9762 )
2020-08-13 11:26:40 -04:00
Megan Marsh
e97c56dc72
Merge pull request #9559 from hashicorp/fix_9482
...
builder/azure-arm: Remove duplicate resource deletion steps
2020-08-12 12:43:09 -07:00
Wilken Rivera
55812fe8a5
Handle error of deferred deletion
2020-08-12 11:30:15 -04:00
Wilken Rivera
5700f74c8c
Handle lease not present error
2020-08-12 11:27:07 -04:00
Wilken Rivera
d91839b93e
Update deletion logic for OS disks
...
* Add an ResourceNotFound error check
* Add logic to break temporary disk lease before deleting it
2020-08-12 11:03:51 -04:00
Wilken Rivera
ba6d11d518
Remove StepDeleteOSDisk in favor of StepDeployTemplate#Cleanup
2020-08-12 11:03:03 -04:00
Megan Marsh
54469c4728
Add all of the custom AWS template engines to GeneratedData for use b… ( #9751 )
2020-08-12 10:43:15 +02:00
Sylvia Moss
e475db6a66
check for ip after timeout ( #9748 )
2020-08-12 10:39:12 +02:00
Wilken Rivera
aed97e1a8b
Ensure any active leases are brokend before deleting
2020-08-11 16:41:28 -04:00
Wilken Rivera
920da9d0a4
Fix up code to remove some additional steps
2020-08-11 16:40:51 -04:00
Megan Marsh
f8bb9008c0
Merge pull request #9697 from backerman/personal/backerman/9695
...
Add FreeBSD support to azure/chroot
2020-08-10 12:47:48 -07:00
Wilken Rivera
7c28d5590c
Remove StepDeleteResourceGroup in favor of StepDeploymentTemplate#Cleanup
2020-08-10 12:57:11 -04:00
Sylvia Moss
80960d7a64
Fix vsphere boot command and check for context cancelation when waiting for ip ( #9739 )
2020-08-10 18:16:19 +02:00
Brad Ackerman
23d5432333
Revert inadvertently-changed import.
2020-08-09 14:31:54 -07:00
Brad Ackerman
109b2a0ca9
Build constraints don't seem to work on test.
2020-08-09 14:12:58 -07:00
Brad Ackerman
94c9b87431
Only run on platforms supported by chroot.
2020-08-09 13:53:21 -07:00
Brad Ackerman
33eb8483ba
Get some tests in here.
2020-08-09 13:39:29 -07:00
Megan Marsh
8f362656ee
Update builder/amazon/ebs/step_create_ami.go
...
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-08-07 08:02:57 -07:00
Megan Marsh
484dbfe6ad
improve error handling when waiting for image so that the resourcenotready error is bubbled up more clearly without verbose logging turned on
2020-08-06 14:58:05 -07:00
Megan Marsh
04d7a10aa0
Merge pull request #9714 from hashicorp/fix_9688
...
provide more helpful error message than the one returned by the clien…
2020-08-06 10:54:21 -07:00
Megan Marsh
4964c54f60
update docs to state resource id must be fully qualified
2020-08-06 10:41:18 -07:00
Megan Marsh
25f2ec48d3
add network_name option to vmware builder to make it match the network option on the vsphere builder, so vmware users needn't update vmx data just for the network name ( #9718 )
2020-08-06 13:19:55 +02:00
Megan Marsh
3f61498704
Merge pull request #9704 from ntoofu/f-vsphere-export-permission
...
Add `directory_permission` config option to `vsphere` builder
2020-08-05 10:57:30 -07:00
Sylvia Moss
dcacf7ad4c
Add vSphere HCL examples to the docs ( #9674 )
2020-08-05 19:23:52 +02:00
Megan Marsh
aede34079d
provide more helpful error message than the one returned by the client, without context
2020-08-05 09:52:11 -07:00
ntoofu
a53e81d9a2
Make docs more clear
...
https://github.com/hashicorp/packer/pull/9704#discussion_r465393240
2020-08-06 01:11:02 +09:00
jhawk28
6b8d086e94
alt, ctrl, and shift should be outside variables ( #9702 )
2020-08-05 17:36:40 +02:00
Megan Marsh
825deef43d
Merge pull request #9665 from hashicorp/vsphere_clone_customization
...
Add step to customize cloned VM
2020-08-05 08:30:31 -07:00
Sylvia Moss
dd37a10355
fix configuration_parameters ( #9713 )
2020-08-05 16:57:12 +02:00
ntoofu
5493285f65
Add `directory_permission` config option to `vsphere` builder
2020-08-02 15:02:31 +09:00
Brad Ackerman
fb1a4bd86f
Add placeholder diskattacher for other OSes.
2020-08-01 21:59:43 -07:00
Brad Ackerman
5ce6c8564c
Fix ordering to match master for better diffs.
2020-08-01 21:30:44 -07:00
Brad Ackerman
13a4e47efe
Increase wait time for device to be created.
2020-08-01 21:22:50 -07:00
Brad Ackerman
364c415294
Add FreeBSD support.
2020-08-01 21:22:50 -07:00
Etan Reisner
a28edbaa0b
Fix skip_save_build_region in the ebssurrogate builder. ( #9666 )
2020-07-31 16:01:46 -04:00
Megan Marsh
ea45efc9b8
Merge pull request #9677 from hashicorp/b-scaleway-user-agent-config
...
builder/scaleway: Remove mapstructure configuration for the UserAgent runtime-only field
2020-07-31 10:26:36 -07:00
sylviamoss
fc2e94554a
add qemu hcl examples
2020-07-31 17:32:08 +02:00
Wilken Rivera
a76c6c55a9
Remove HCL config for runtime field `UserAgent`
...
Results before change
```
⇶ packer build /tmp/minimal.pkr.hcl
Error: 1 error occurred:
* unknown configuration key: '"user_agent"'
on /tmp/minimal.pkr.hcl line 1:
(source code not available)
==> Builds finished but no artifacts were created.
```
Results after change
```
⇶ packer build /tmp/minimal.pkr.hcl
scaleway.required: output will be in this color.
==> scaleway.required: Creating temporary ssh key for server...
==> scaleway.required: Creating server...
```
2020-07-31 11:22:55 -04:00
Wilken Rivera
980f02ce5d
Add mapstructure tag for UserAgent field
...
Closes : #9676
2020-07-30 16:08:24 -04:00
Li Kexian
94a32dc282
tencentcloud cvm use CLOUD_PREMIUM disk by default ( #9663 )
2020-07-29 15:10:00 +02:00
sylviamoss
c6e9bde97b
add step customize and docs
2020-07-29 15:07:44 +02:00
jhawk28
3370c91cf2
add some additional messaging when a boot command fails to type ( #9661 )
2020-07-29 15:06:45 +02:00
Megan Marsh
883339be25
Set project via project flag, not setting in the config ( #9662 )
...
* set project via project flag, not setting in the config + tests
2020-07-29 10:50:11 +02:00
Megan Marsh
b695615d7d
fix local file stating ( #9660 )
2020-07-29 10:26:09 +02:00
Megan Marsh
b40490c3c1
Merge pull request #9610 from chilversc/winrm-via-iap-tunnel
...
Support using WinRM over an IAP tunnel
2020-07-28 14:27:43 -07:00
Megan Marsh
395a0c472e
improve postprocessor stdout
2020-07-25 08:24:21 -07:00
Megan Marsh
b3c3e3ed63
Merge pull request #9589 from hashicorp/fix_9184
...
post-processor/vsphere: Fix password encoding in vsphere post-processor ovftool call
2020-07-25 08:23:54 -07:00
Adrien Delorme
44616d3bff
refactor initialization out from packer configs + tests ( #9627 )
...
The initialization of packer core in JSON also validates that `null` variables were set, except in the case of `packer validate --syntax-only` , but after the refactor to allow to have all commands work with HCL2 and JSON this subtlety was lost.
This refactors the initialisation of the core in order to allow to have `packer validate --syntax-only` not error in case a variable is not set. Since these calls are refactored this works for HCL2 too.
fix #9478
2020-07-24 10:58:03 +02:00
Megan Marsh
74aef3c819
apply same url encoding to other places we call ovftool
2020-07-23 17:03:42 -07:00
Megan Marsh
a687d6fe12
ci/tech-debt: Fix vmware acceptance tests ( #9636 )
...
* add kex algorithm option to ssh config
* regenerate code
* This commit fixes old vmware acceptance tests that have not been run in some time. It does this in two parts:
1) It modifies the minimal vmware build configuration to use a custom kex algorithm, which enables the ssh connection to succeed.
2) It modifies logic in reading and defaulting hardware config values, which was crashing.
3) It adds a new acceptance test with a preseed file to test loading from an http directory.
2020-07-23 09:40:57 +02:00
Megan Marsh
0a66f19dbe
fix minimal json example to use new checksumming ( #9633 )
2020-07-23 09:39:57 +02:00
Megan Marsh
ec5a2b87af
Merge pull request #9619 from piggona/master
...
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-22 10:29:30 -07:00
Megan Marsh
f9df185ef1
Merge pull request #9579 from hashicorp/fix_9562
...
wrap CreateImage call in a retry to account for eventual consistencey…
2020-07-22 08:43:10 -07:00
Chris Chilvers
63eedf841e
Fix failing tests due to IAP communicator host name
...
Moved setting the host from ApplyIAPTunnel to Config.Prepare but forgot to
update the related tests.
2020-07-22 12:58:05 +01:00
Megan Marsh
1f3b3f8fd9
change retry func to a 15 min timeout
2020-07-21 15:55:39 -07:00
Megan Marsh
a56942d3c7
change isAwsErr to an exported func so I can use it in other aws modules.
2020-07-21 15:30:45 -07:00
Megan Marsh
036ea238bf
wrap CreateImage call in a retry to account for eventual consistencey issues with image state
2020-07-21 15:30:45 -07:00
piggona
22b49c1a92
delete cvm-filter configuration
2020-07-21 11:04:41 +08:00
piggona
ecfce6ef4c
delete cvm-filter configuration
2020-07-21 11:04:32 +08:00
piggona
38563df35c
builder/tencent: add key source_image_name to get source image by name when creating image.#9548
2020-07-21 11:04:11 +08:00
piggona
a1b6f809c7
add:argument key SourceImageName to get source image by name.
2020-07-21 11:02:30 +08:00
Adrien Delorme
810f161d22
builder/amazon/common/block_device.go: replace tabs with words
2020-07-20 16:34:13 +02:00
Adrien Delorme
966b17d2b5
builder/amazon/common/access_config.go: replace tabs with words
2020-07-20 16:31:23 +02:00
Adrien Delorme
5c4901c2c2
builder/amazon/common/run_config.go: replace tabs with words
2020-07-20 16:28:14 +02:00
Adrien Delorme
1455a29f2b
remove tabs for security_group_filter too
2020-07-20 16:24:47 +02:00
Adrien Delorme
191094edcc
better `disable_stop_instance` docs
2020-07-20 16:21:43 +02:00
Chris Chilvers
37544f4d5f
Support using WinRM over an IAP tunnel
...
This avoids the need to expose WinRM ports on the internet and allows
using instances with only an internal private IP address.
When using a WinRM tunnel there is a race condition between the tunnel
connection attempt timing out and packer assuming the connection was
successful. To allow for this, when using WinRM the default success
timeout is increased to 40 seconds.
2020-07-19 01:28:31 +01:00
Megan Marsh
530f5e3f63
more additions to partials
2020-07-17 15:52:11 -07:00
Megan Marsh
a1651977b3
add tabs to generated docs from access_config and run_config structs
2020-07-17 15:10:55 -07:00
Megan Marsh
8964367eb5
Merge pull request #9603 from paulmey/disable-password
...
[azure-arm] Disable ssh password authentication unless password is explicitly specified
2020-07-17 09:32:38 -07:00
Megan Marsh
0883e185a2
Merge pull request #9594 from GennadySpb/yndx-image-min-disk-size
...
yandex: Add new property 'min_disk_size' of built image
2020-07-17 09:31:48 -07:00
Megan Marsh
9f34241b5c
Merge pull request #9597 from romantomjak/multiqueue-net-option
...
builder/proxmox: add support for multiple NIC packet queues
2020-07-17 09:07:04 -07:00
Paul Meyer
708ca1c126
Add some error checking
2020-07-16 23:22:24 +00:00
Paul Meyer
deca28c158
Disable password auth on ssh key Linux builds
2020-07-16 22:26:06 +00:00
Paul Meyer
5fd68374fe
Optionally disable password authentication for Linux builds
2020-07-16 19:44:01 +00:00
Roman Tomjak
a2220e5f08
make linter happy
2020-07-16 18:19:22 +01:00
Roman Tomjak
d3d7cc3e59
configure packet queues on nics
2020-07-16 17:56:58 +01:00
Roman Tomjak
a65157a91b
use helper method for mandatory config
2020-07-16 17:41:56 +01:00
Gennady Lipenkov
03a0bf26f2
Rename config key name
2020-07-16 17:29:45 +03:00
Gennady Lipenkov
9c565a97c0
Add new property 'min_disk_size' of built image
2020-07-16 17:10:22 +03:00
Megan Marsh
c0270c9f19
Merge pull request #9587 from romantomjak/disable-kvm-flag
...
Add option to disable KVM hardware virtualization in proxmox builder
2020-07-15 15:23:09 -07:00
Roman Tomjak
7ed8709483
add option to configure network adapter multiqueue support
2020-07-15 23:07:02 +01:00
Roman Tomjak
376b8c045e
use the value of disable kvm flag when creating the VM
2020-07-15 19:12:01 +01:00
Roman Tomjak
be7251f185
add option to disable kvm hardware virtualization
2020-07-15 18:47:24 +01:00
Megan Marsh
8bb2cb44c0
rename launch timeout to launch wait
2020-07-15 10:24:55 -07:00
Megan Marsh
6e9eaa1edd
generate code
2020-07-15 10:20:50 -07:00
Megan Marsh
af009c2aa0
make tunnel timeout configurable
2020-07-15 10:17:13 -07:00
Megan Marsh
cf5537d5d2
Merge pull request #9565 from mk0x9/docker/builder-add-runner-params
...
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs, --device
2020-07-15 10:16:13 -07:00
Megan Marsh
c59d0b0283
Merge pull request #9584 from hashicorp/azr-fix-esxi-checksum
...
esx5driver.VerifyChecksum: try checksum remote file instead of local file
2020-07-15 10:07:17 -07:00
Adrien Delorme
1edd848877
esx5driver.VerifyChecksum: try checksum remote file instead of local file
...
fix #9456
2020-07-15 18:21:08 +02:00
Michael Kuryshev
37d0f48599
builder/docker: reference to docker docs regarding capabilities
2020-07-15 03:04:13 +02:00
Megan Marsh
a414e7cdb9
convert relative to absolute path in prepare
2020-07-14 15:59:53 -07:00
Megan Marsh
bb43b5cac4
improve validation and error handling around synced_folder
2020-07-14 11:34:40 -07:00
Michael Kuryshev
6e77d9d3a9
builder/docker: runner support for --device
2020-07-14 10:37:44 -07:00
Michael Kuryshev
791a86c45e
builder/docker: runner support for --cap-add, --cap-drop, --tmpfs
2020-07-14 10:34:10 -07:00
Megan Marsh
f5031a1eb5
Merge pull request #9573 from zhsj/bump-gophercloud
...
Bump gophercloud to latest version
2020-07-14 10:11:06 -07:00
Megan Marsh
aa4933c28a
Merge pull request #9574 from jhawk28/vsphere_usb_controllers
...
(vsphere) add ability to add a xhci/usb3 controller
2020-07-14 10:09:33 -07:00
Joshua Foster
b49c844637
ignore false and 0 in case someone defined the field as "false" or false
2020-07-14 12:11:24 -04:00
Sylvia Moss
5a006f226a
Don't use Packer context as vSphere driver context ( #9576 )
2020-07-14 11:45:19 +02:00
Sylvia Moss
eb5c3c3efb
fix file size descriptor ( #9568 )
2020-07-14 11:36:49 +02:00
Sylvia Moss
3a0dfa1259
add option to destroy vm after deploy to content library ( #9569 )
2020-07-14 10:07:20 +02:00
Joshua Foster
b0fa05704a
change usb controllers to a list. add ability to set as a usb3
...
Closes #8874
2020-07-13 20:54:46 -04:00
Shengjing Zhu
4fe9a92058
Bump gophercloud to latest version
2020-07-14 00:01:37 +08:00
Roger Hu
28f8241a05
update generated files
2020-07-10 16:58:06 -07:00
Moss
921078ccc0
add force_bios_setup configuration option
2020-07-10 12:30:22 +02:00
jhawk28
ae5156a70d
add ability to define multiple disk controllers ( #9519 )
2020-07-10 12:25:46 +02:00
Sylvia Moss
9c1409dbba
Add content_library_destination to import VM template to a Content Library ( #9551 )
2020-07-10 11:01:10 +02:00
Megan Marsh
61b79b6e53
Merge pull request #9542 from jhawk28/bug_9511
...
clean up folder path so that it is what vsphere expects
2020-07-09 16:08:18 -07:00