Commit Graph

15065 Commits

Author SHA1 Message Date
Megan Marsh a568ffce0a generated 2020-05-19 16:54:03 -07:00
Megan Marsh 266bba279b linting 2020-05-19 16:45:14 -07:00
Megan Marsh aadd95497a fix tests 2020-05-19 16:39:17 -07:00
Megan Marsh a892d13d56 make package_include match output_vagrantfile parsing and abspath calculation 2020-05-19 16:32:54 -07:00
Megan Marsh 1c214628ed
Merge pull request #9234 from hashicorp/hcl_force_and_debug
enable force, debug, and on-error for hcl2 builds
2020-05-19 16:02:06 -07:00
Adam Dobrawy df86b14572
Add CODEOWNERS of bats tests (#9259) 2020-05-19 15:05:57 -04:00
Megan Marsh 58b32ebefa
Merge pull request #9251 from hashicorp/fix_9249
builder/azure-arm: Update runtime constants with a valid DataDiskName
2020-05-19 11:00:44 -07:00
Wilken Rivera 3cd13ae1e5
update changelog
Add 9238 to list of bug fixes
2020-05-19 11:05:59 -04:00
Wilken Rivera 508f6497bb
update changelog
Minor formatting changes
2020-05-19 10:40:51 -04:00
Wilken Rivera fd0a511eb2 update changelog 2020-05-19 10:37:19 -04:00
jhawk28 820f353573
(vsphere-iso) remove deprecated network and disk fields (#9149)
* remove deprecated network and disk fields
2020-05-19 10:06:12 -04:00
Adam Dobrawy 541ec89654
Add CODEOWNERS for examples (#9255) 2020-05-19 12:28:16 +02:00
Sylvia Moss 1c30a71d09
Replace file shared state by statebag (#9238) 2020-05-19 11:49:48 +02:00
Wilken Rivera c954831bb2 builder/azure-arm: Update runtime constants with a valid DataDiskName
This change fixes an issue where using the `disk_additional_size` configuration option would cause builds to fail.

Build results before the change
```
==> Builds finished but no artifacts were created.
Build 'azure-arm' errored: Code="DeploymentFailed" Message="At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details." Details=[{"code":"BadRequest","message":"{\r\n  \"error\": {\r\n    \"code
\": \"InvalidParameter\",\r\n    \"message\": \"The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\\\\W][\\\\w-._]{0,79}(?\u003c![-.])$.\",\r\n    \"target\": \"dataDisk.name\"\r\n  }\r\n}"}]

```

Build results after change
```
Build 'azure-arm' finished.

==> Builds finished. The artifacts of successful builds are:
--> azure-arm: Azure.ResourceManagement.VMImage:

OSType: Linux
ManagedImageResourceGroupName: test-pkr
ManagedImageName: wilkenPacker9249
```

Closes #9249
2020-05-18 14:57:20 -04:00
Megan Marsh 170520dcca update changelog 2020-05-15 14:22:59 -07:00
Megan Marsh c6ca83bf9b
Merge pull request #9240 from rberlind/master
replace clean_image_name with clean_resource_name
2020-05-15 14:17:48 -07:00
Roger Berlind fdca7175fc replace clean_image_name with clean_resource_name
The change was mostly made except in one example for Google
2020-05-15 16:33:27 -04:00
Wilken Rivera c5e38a2699
docs/amazon-ebssurrogate: Add Session Manager documentation (#9236) 2020-05-15 14:58:10 +02:00
Megan Marsh ee5635722b enable force, debug, and on-error for hcl2 builds 2020-05-14 16:22:51 -07:00
Megan Marsh e3635566eb
Merge pull request #9232 from hashicorp/d-amazon-ssm-doc-updates
docs/builder/amazon: Add Session Manager Connection documentation to supported builders
2020-05-14 13:23:03 -07:00
Wilken Rivera bcaf9f124f docs/builder/amazon: Add Session Manager Connection documentation to supported builders 2020-05-14 15:17:22 -04:00
Megan Marsh 2661f7e0f1
Merge pull request #9229 from hashicorp/d-azure_arm-custom_managed_image_resource_update
docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
2020-05-14 11:54:33 -07:00
Megan Marsh 533fbc1381
Merge pull request #9139 from hashicorp/hcl2_commands_refactor
Hcl2 commands refactor
2020-05-14 11:16:12 -07:00
Megan Marsh bdd0141526
Merge pull request #9226 from hashicorp/powershell-cleanup-retry-logic
provisioner/powershell: Update cleanup logic
2020-05-14 11:03:46 -07:00
Wilken Rivera f31f5bc61b docs/builder/azure-arm: Fix a small typo for the custom_managed_image_* config options
Closes #9199
2020-05-14 13:31:40 -04:00
Wilken Rivera c330d2f04c provisioner/powershell: Update cleanup logic
This change reduces the retry timeout from 5m to 1m, and sets the
RetryDelay to 10s for a total of 6 retries. In additional to the retry
time reduction the cleanup script will now check to see if the
provisioner script created by Packer exists before trying to delete to
prevent any file not found issues.

Closes #9181
Closes #9189
2020-05-14 10:21:45 -04:00
Sylvia Moss df3bac3104
remove codecov status (#9225) 2020-05-14 16:02:51 +02:00
Evan Digby e4eaff6bba
s/Directoty/Directory (#9221) 2020-05-14 15:00:27 +02:00
Adrien Delorme 2f26168adc ConsoleCommand.ParseArgs: don't fail if no buildfile was passed 2020-05-14 12:21:42 +02:00
Megan Marsh cd5925ebbd update changelog 2020-05-13 15:43:51 -07:00
Megan Marsh 0d900fd007
Merge pull request #9198 from hashicorp/fix_9190
don't error if metadata can't be set. Old versions of openstack don't…
2020-05-13 14:45:18 -07:00
Megan Marsh a17ef01ea9
Merge pull request #9212 from andrewsomething/asb/do-image-id
builder/digitalocean: Use correct image type for Droplet creates.
2020-05-13 14:43:13 -07:00
Megan Marsh 37d953881f
Merge pull request #9219 from hashicorp/azr_autodoc_alicloud_pp
alicloud: better docs + autogenerated post processor docs
2020-05-13 14:41:44 -07:00
Andrew Starr-Bochicchio 84f0079c3a Move to a new func to make testable. 2020-05-13 13:29:22 -04:00
Andrew Starr-Bochicchio a1f334daff Use constant and move check to template generator. 2020-05-13 13:28:44 -04:00
Megan Marsh 481ef0bf82 add andrewsomething to codeowners for do 2020-05-13 10:06:16 -07:00
Andrew Starr-Bochicchio bf0ab6b722 Force test to be skipped unless PACKER_ACC set. 2020-05-13 11:48:49 -04:00
Adrien Delorme a1bff83afb Update Config-required.mdx 2020-05-13 16:22:46 +02:00
Wilken Rivera aa2c069067
Update post-processor/alicloud-import/post-processor.go 2020-05-13 10:19:55 -04:00
Wilken Rivera b5639d4697
tests/builder/amazon: Enhance the test coverage for SSM Tunnel related steps (#9213)
* test/builder/amazon: Update mocks to properly test SSM tunnel and driver code base

* Update mod files
2020-05-13 10:10:55 -04:00
Adrien Delorme 57395b8812
show a better error message in ssh.scpSession (#9217) 2020-05-13 15:57:05 +02:00
Adrien Delorme a50c27c05d single ` 2020-05-13 15:51:18 +02:00
Adrien Delorme c2d3e494b6 alicloud: better docs + autogenerated post processor docs 2020-05-13 15:49:34 +02:00
Christian Frichot e2a02636bc
website: npm audit fix (#9218) 2020-05-13 13:49:19 +02:00
Kennith Leung 6a1737847d
Update vagrant.mdx (#9215)
If the `output_dir` is not set, the folder will be set to `output-` plus buildname.
2020-05-13 10:17:26 +02:00
Megan Marsh fe472f45ae don't put error in state, or we'll fail. 2020-05-12 16:51:40 -07:00
Megan Marsh 807a09a770 don't error if metadata can't be set. Old versions of openstack don't seem to play nicely with this API call 2020-05-12 16:51:40 -07:00
Megan Marsh cccf74d755 update changelog 2020-05-12 16:50:26 -07:00
Megan Marsh 5b6f4a3286
Merge pull request #9209 from hashicorp/ssm-panic-fix
builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds
2020-05-12 15:16:34 -07:00
Wilken Rivera 6f5f6bf999 builder/amazon Fix invalid pointer issue for non SSMAgengtEnabled builds
Tests before change
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1392ca2]

goroutine 299 [running]:
github.com/hashicorp/packer/builder/amazon/common.(*StepCreateSSMTunnel).Cleanup(0xc0003dc460, 0x4d1a4c0, 0xc0006e9800)
        /home/wilken/Development/packer/builder/amazon/common/step_create_ssm_tunnel.go:95 +0xf2
github.com/hashicorp/packer/helper/multistep.(*BasicRunner).Run(0xc0006e98f0, 0x4d408c0, 0xc00065fcc0, 0x4d1a4c0, 0xc0006e9800)
        /home/wilken/Development/packer/helper/multistep/basic_runner.go:79 +0x2c6
github.com/hashicorp/packer/builder/amazon/ebs.(*Builder).Run(0xc000726800, 0x4d408c0, 0xc00065fcc0, 0x4d5e300, 0xc0006e8d80, 0x4cc7220, 0xc000434120, 0x0, 0x0, 0x0, ...)
        /home/wilken/Development/packer/builder/amazon/ebs/builder.go:330 +0x17e2
github.com/hashicorp/packer/packer.(*CoreBuild).Run(0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, 0x0, 0x0, 0x0, 0x0, 0x0)
        /home/wilken/Development/packer/packer/build.go:287 +0x7ef
github.com/hashicorp/packer/command.(*BuildCommand).RunContext.func1(0xc0004d14d0, 0xc0003dc3c0, 0xc000441500, 0xa, 0x4d5e1e0, 0xc000720500, 0x4d408c0, 0xc00065fcc0, 0x4d5e180, 0xc0006fe510, ...)
        /home/wilken/Development/packer/command/build.go:290 +0x189
created by github.com/hashicorp/packer/command.(*BuildCommand).RunContext
        /home/wilken/Development/packer/command/build.go:284 +0xd5a
FAIL    github.com/hashicorp/packer/provisioner/shell   188.335s
FAIL
```

Test After change
```
--- PASS: TestShellProvisioner (212.39s)
    --- PASS: TestShellProvisioner/testing_amazon-ebs_builder_against_shell_provisioner (212.39s)
PASS

```
2020-05-12 14:49:57 -04:00