12764 Commits

Author SHA1 Message Date
Stephen Fox
a6830f8348 Move 'ui' variable closer to invocation. 2019-07-31 14:08:40 -04:00
Stephen Fox
e362d2f3ee Use 'log.Printf()' for StepDownload debug instead of 'ui.Say()'. 2019-07-31 14:02:57 -04:00
Megan Marsh
a0a11bd109
Merge pull request #7934 from briancain/replace-token-name-in-docs
Update vagrant cloud post processor token example
2019-07-31 09:13:34 -07:00
Brian Cain
85278342fb
Update vagrant cloud post processor token example
This commit updates the Vagrant Cloud post processor example to use the
proper token name rather than the old Atlas one.
2019-07-31 08:46:07 -07:00
Megan Marsh
f97df6721e
Merge pull request #7927 from hashicorp/fix_googlecompute_crash_7921
code changed recently so that sometimes the conf is nil.
2019-07-30 09:55:09 -07:00
Megan Marsh
84fff30122
Merge pull request #7923 from DanHam/fix-ebssurrogate-panic
Fix a panic encountered when using the Amazon ebssurrogate builder
2019-07-30 09:36:29 -07:00
Megan Marsh
96366ac814
Merge pull request #7922 from stephen-fox/honor-comment-existing-ssh-key-pair
Honor value of 'Comment' field in 'ssh.KeyPairFromPrivateKey()'.
2019-07-29 13:22:46 -07:00
Megan Marsh
7c93a5c51e code changed recently so that sometimes the conf is nil. 2019-07-29 13:19:43 -07:00
Megan Marsh
b42701380c add test for nil case 2019-07-29 12:11:59 -07:00
DanHam
088151e51d
Type assertion safety - fix panic when key cannot be retrieved from statebag 2019-07-28 10:44:24 +01:00
Stephen Fox
9592211bcf Honor value of 'Comment' field in 'ssh.KeyPairFromPrivateKey()'.
The 'ssh.KeyPairFromPrivateKey()' function in the 'ssh' helper
library was not honoring the value of the 'Comment' field in the
'FromPrivateKeyConfig' struct. This commit fixes the issue, and
updates unit tests to catch the issue if it happens again.
2019-07-27 15:52:13 -04:00
Megan Marsh
903a422020
Merge pull request #7917 from hashicorp/cleanup_unused_cancel_funcs
These cancel functions have been obsolete since March 2019
2019-07-26 14:42:06 -07:00
Megan Marsh
7ac17126a0
Merge pull request #7913 from hashicorp/red_herring_EOF_abort
[WIP] Red herring eof abort
2019-07-26 14:36:14 -07:00
Megan Marsh
0f704fb5b2 These cancel functions have been obsolete since merge of c7ce4d598e50d455e8b8383c36dc2ac3b324ebd3 2019-07-26 14:12:58 -07:00
Megan Marsh
90c5da40f2 implement abort logic and printing for the askstep implementation as well 2019-07-26 12:24:03 -07:00
Megan Marsh
a99c0802be
Merge pull request #7914 from shawnmssu/fix_ucloud_builder
UCloud Builder: update api about stop instance
2019-07-26 11:37:36 -07:00
mingsheng.su
66f142adf1 update docs 2019-07-26 17:27:58 +08:00
mingsheng.su
59c8911cd5 update api about stop instance 2019-07-26 17:03:57 +08:00
Megan Marsh
9912e569e1 deduplicate loglines that stream both to ui ERROR call and to streaming logs when PACKER_LOG=1 2019-07-25 16:33:02 -07:00
Megan Marsh
54034689ef On abort, return gracefully rather than exiting so that the subprocess doesn't unexpectedly disconnect from the parent and cause a confusing EOF error in the logs 2019-07-25 16:32:16 -07:00
Megan Marsh
d21f4eb888
Merge pull request #7908 from muesli/typo-fixes
Fixed various typos
2019-07-25 12:21:20 -07:00
Megan Marsh
3d22535742
Merge pull request #7884 from jprorama/fix-7171
[WIP] Fix #7171: select instance network on which to assign floating ip
2019-07-25 11:57:24 -07:00
Megan Marsh
166f1de5fd
Merge pull request #7887 from xunleii/f-scaleway-autoremove-volume
Allow removing volume after image creation for Scaleway builder
2019-07-25 11:56:23 -07:00
Megan Marsh
aeceba5fd2
Merge pull request #7906 from grahamking/patch-1
plugins.html.md: Unix dir packer.d -> .packer.d
2019-07-25 11:54:38 -07:00
Megan Marsh
e4c1979708
Merge pull request #7907 from grahamking/patch-2
plugins.html.md: Update docs example to match code example.
2019-07-25 11:53:58 -07:00
Megan Marsh
175d0b817d
Merge pull request #7905 from hashicorp/set_config_dir
make sure we create the temp dir explicitly when we are setting up th…
2019-07-25 11:35:50 -07:00
Christian Muehlhaeuser
216afbaa8b
Fixed various typos
Just a bunch of nit-picky typo fixes.
2019-07-25 06:49:51 +02:00
Graham King
5d470ae731
plugins.html.md: Update docs example to match code example.
`plugin.RegisterBuilder` doesn't seem to exist. Instead the [example](https://github.com/hashicorp/packer/blob/master/plugin/example/main.go) and the tests use `plugin.Server`.
2019-07-24 20:46:37 -07:00
Graham King
efd70c8dce
plugins.html.md: Unix dir packer.d -> .packer.d
To match https://github.com/hashicorp/packer/blob/master/packer/config_file_unix.go#L7
2019-07-24 20:33:56 -07:00
Megan Marsh
140785f088 make sure we create the temp dir explicitly when we are setting up the config dir in docker. Otherwise, we create it with root later on and it causes permissions failures. 2019-07-24 16:51:38 -07:00
Alexandre NICOLAIE
a338dab8fc docs: add Scaleway documentation
Signed-off-by: Alexandre NICOLAIE <alexandre.nicolaie@gmail.com>
2019-07-24 21:25:17 +02:00
Megan Marsh
c4806e2fe4
Merge pull request #7903 from devenney/devenney-fixer-housekeeping
Fixer Housekeeping
2019-07-24 12:21:06 -07:00
Alexandre NICOLAIE
6835a12cb3
fix: fix typo in comment
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
2019-07-24 21:19:53 +02:00
Brendan Devenney
2b16b5cae4
Move fixer test to fix package
Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>
2019-07-24 18:04:17 +01:00
Brendan Devenney
6520814a6c
Ensure help output is consistently formatted
Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>
2019-07-24 17:41:57 +01:00
Brendan Devenney
75d8d7fce5
Update and futureproof fix command usage
* Dynamically generate the fixer documentation (in order) from
FixerOrder
* Update fixers which used linebreaks in their Synopsis

Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>
2019-07-24 17:18:07 +01:00
Brendan Devenney
91b7d8c572
Add test to ensure all fixers are enabled
Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>
2019-07-24 16:52:07 +01:00
Brendan Devenney
9f0bc29db5
Test that Fixers and FixerOrder are equal length
Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>
2019-07-24 16:51:39 +01:00
Brendan Devenney
556492fb0d
Add fixers erroneously removed by e8f04c3
Signed-off-by: Brendan Devenney <brendan.devenney@form3.tech>
2019-07-24 16:28:08 +01:00
John-Paul Robinson
c428154c6d Document instance_floating_ip_net attribute
This attribute selects a preferred network on which to associate the
instance floating ip.
2019-07-23 16:41:44 -05:00
Megan Marsh
a6072626c9 update changelog 2019-07-23 11:01:52 -07:00
Megan Marsh
2934e0c621
Merge pull request #7893 from StefanScherer/inspec-input-file
Use inspec --input-file instead of --attrs to avoid deprecation warning
2019-07-22 12:34:10 -07:00
Megan Marsh
8fe8fd4798
Merge pull request #7290 from y-kuno/openstack-add-min_disk
Add openstack image min_disk option
2019-07-22 12:21:46 -07:00
Megan Marsh
54a7b4f377 update comments and docs 2019-07-22 11:54:42 -07:00
y-kuno
6305c555df Add openstack image min_disk option 2019-07-22 11:44:34 -07:00
Megan Marsh
b33ea0f7e0
Merge pull request #7888 from hashicorp/double_slash_madness
fix double slash conundrum
2019-07-22 10:36:25 -07:00
Megan Marsh
e9549d2688 add test for local fs download 2019-07-22 09:17:48 -07:00
Stefan Scherer
35dae5791c
Use --input-file instead of --attrs.
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
2019-07-22 10:17:01 +02:00
Alexandre NICOLAIE
b010442e07 fix: delete volume only after snapshot step
Signed-off-by: Alexandre NICOLAIE <alexandre.nicolaie@gmail.com>
2019-07-21 10:42:34 +02:00
Megan Marsh
197a283b5e actually check for filepath being present 2019-07-19 10:35:50 -07:00