Megan Marsh
a734aa2255
Revert "mux_broker_test.go: make non blocking errChan"
...
This reverts commit d9e32d437c
. It turns out that it was already non-blocking with a length of one.
2018-12-17 13:49:47 -08:00
Megan Marsh
3cba3da163
Merge pull request #7121 from DanHam/contributing-link
...
Fix a link in the contributing doc
2018-12-17 11:03:05 -08:00
Adrien Delorme
06152d2c83
Update CHANGELOG.md
2018-12-17 12:36:15 +01:00
Adrien Delorme
895d49ca10
Merge pull request #7119 from hashicorp/fix_race
...
try to remove race condition in mux test
2018-12-17 11:42:55 +01:00
Adrien Delorme
d9e32d437c
mux_broker_test.go: make non blocking errChan
...
* in case of Dial errors to avoid a deadlocks
2018-12-17 11:09:56 +01:00
Adrien Delorme
2944030daf
mux_broker_test.go: range over chan for simplicity
2018-12-17 11:01:46 +01:00
Adrien Delorme
9a31d0de58
mux_broker_test.go: defer close chan
2018-12-17 10:58:32 +01:00
DanHam
d75a580952
Fix link
2018-12-15 11:36:47 +00:00
Megan Marsh
70c6fcb824
Merge pull request #7078 from aspectcapital/issue-5478
...
Elevated support for puppet-* & chef-client provisioners
2018-12-14 19:06:46 -08:00
Megan Marsh
fd988e67a6
Merge pull request #7118 from wizurijyq/patch-1
...
Make sure sshkey is not nil
2018-12-14 15:48:42 -08:00
Megan Marsh
a4f9c04d4f
Merge pull request #7115 from mr-karan/ssh_extra
...
feat(provisioner/ansible): Provide extra SSH args
2018-12-14 15:09:19 -08:00
Megan Marsh
f6070de070
fix test
2018-12-14 13:59:26 -08:00
Megan Marsh
52176ecf2d
try to remove race condition in mux test
2018-12-14 13:53:39 -08:00
wizurijyq
8184fcb99a
Make sure sshkey is not nil
2018-12-14 22:30:26 +01:00
Adrien Delorme
74abd80c4f
Merge pull request #7116 from DanHam/fix-nil-artifact-dir
...
VMware-ISO: Fix bug caused by 'nil' dir field in artifact struct when building locally
2018-12-14 17:06:47 +01:00
mr-karan
01cdd18fd3
feat(provisioner/ansible): Provide extra SSH args
...
Adds `-o IdentitiesOnly=yes` as a default flag to extra vargs
in Ansible provisoner.
Closes https://github.com/hashicorp/packer/issues/5329
2018-12-14 19:07:54 +05:30
DanHam
0821653256
Fix 'nil' dir in VMware artifact when building locally
2018-12-14 13:21:41 +00:00
Megan Marsh
2045390e74
Merge pull request #7108 from hashicorp/revert_hddorder_setting
...
Revert hddorder setting
2018-12-13 16:27:31 -08:00
Megan Marsh
e3895e9074
Merge pull request #7109 from hashicorp/revert-7107-patch-2
...
Revert "Fix previous change introduced in patch #7030"
2018-12-13 11:34:58 -08:00
Megan Marsh
6e09f1623f
Revert "Fix previous change introduced in patch #7030"
2018-12-13 11:34:37 -08:00
Megan Marsh
84e8adacc5
Merge pull request #7107 from pgrmega/patch-2
...
Fix previous change introduced in patch #7030
2018-12-13 11:25:52 -08:00
Megan Marsh
7d5ea43f41
revert the hddorder being added to the vmx template, since it's breaking things for some of our users.
2018-12-13 09:58:24 -08:00
pgrmega
954c6d2bdf
Fix previous change in patch #7030
...
The fix is to use -Copy option, not to delete this option which is equivalent to the original -Copy:$false
2018-12-13 18:45:14 +01:00
Megan Marsh
b95123f457
add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work.
2018-12-13 09:12:23 -08:00
Matt Dainty
845d29b458
s/provider/provisioner/
2018-12-13 10:32:36 +00:00
Matt Dainty
451709b956
Elevated support for chef-client provisioner
...
Fixes #4661
2018-12-13 10:25:12 +00:00
Adrien Delorme
47257c0d07
Merge pull request #7104 from hashicorp/revert_docker_changes
...
revert changes to docker entrypoint; since this is a backwards-breaki…
2018-12-13 10:23:18 +01:00
Megan Marsh
ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508
...
Move logging about aws waiters to the access config prepare() so that…
2018-12-12 15:42:37 -08:00
Megan Marsh
806ad60a64
Merge pull request #7103 from mmillican/patch-1
...
Add note about using ssh_interface for WinRM
2018-12-12 15:37:33 -08:00
Megan Marsh
2a79d64ae0
revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release
2018-12-12 15:30:24 -08:00
Megan Marsh
e253892434
Merge pull request #7056 from hashicorp/fix_6799
...
Add registry key check for windows-restart provisioner
2018-12-12 13:14:05 -08:00
Matt Millican
15986a9d4f
Add note about using ssh_interface for WinRM
2018-12-12 15:10:57 -06:00
Megan Marsh
d5854a9574
add option to test registry for certain keys to make sure windows is done with a reboot cycle
2018-12-12 12:52:14 -08:00
Megan Marsh
279949ddcc
Merge pull request #7090 from tomelliff/validate-kms-key-id
...
Check that the KMS key ID is valid
2018-12-12 10:04:22 -08:00
Tom Elliff
12bf7fc4d6
Check that the KMS key ID is valid
...
KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias.
Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.
2018-12-12 11:41:58 +00:00
Megan Marsh
a17f33e494
Merge pull request #7099 from hashicorp/gomod_verify
...
go mod tidy/verify & go get github.com/hetznercloud/hcloud-go
2018-12-11 16:10:01 -08:00
Megan Marsh
a6956e4f30
Merge pull request #7100 from anish/comm_cleanup
...
Better fix for StepCleanupTempKeys #7095
2018-12-11 15:51:13 -08:00
Anish Bhatt
d5f88b154f
Better fix for #7095
2018-12-11 10:34:07 -08:00
Adrien Delorme
6b6bfac87e
go mod verify & go get github.com/hetznercloud/hcloud-go
2018-12-11 17:46:54 +01:00
Adrien Delorme
82fb7aac5e
Merge pull request #7095 from anish/comm_cleanup
...
Don't run StepCleanupTempKeys when communicator is set to none
2018-12-11 17:41:21 +01:00
Adrien Delorme
dfa284c02b
Merge pull request #7094 from hashicorp/fix_7087
...
fix virtualbox 6.0 beta command options
2018-12-11 11:54:56 +01:00
Adrien Delorme
5e5ed9793f
Merge pull request #7092 from arizvisa/vmware-builders.halt-duplicate-code
...
Tiny fix to replace some duplicate code with usage of the already defined `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-11 11:53:26 +01:00
Anish Bhatt
916375183b
Don't run StepCleanupTempKeys when communicator is set to none
2018-12-10 15:33:19 -08:00
Megan Marsh
a819217c93
fix virtualbox 6.0 beta command options
2018-12-10 15:18:21 -08:00
Ali Rizvi-Santiago
1a36458e9e
Tiny fix to replace some duplicate code with usage of the `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-10 16:24:27 -06:00
Megan Marsh
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920
...
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
2018-12-10 13:25:34 -08:00
Ali Rizvi-Santiago
a6af04417e
Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument.
2018-12-10 15:09:56 -06:00
Megan Marsh
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920
...
Updated docker's default config to use regular bourne shell instead of bourne again.
2018-12-10 11:29:27 -08:00
Adrien Delorme
9d32a75104
Merge pull request #7089 from aspectcapital/puppet-path-spaces
...
Document how to pass spaces in `puppet_bin_dir`
2018-12-10 12:58:31 +01:00
Adrien Delorme
ecc20cf816
Merge pull request #7084 from hashicorp/packer_inspect_sensitive
...
make packer inspect not print sensitive variables.
2018-12-10 12:16:55 +01:00