Adrien Delorme
c4b28d6ddc
Revert "use golang:1.12 instead of cicleci/golang:1.12"
...
This reverts commit 6381f31113c59f4c73336a74f6078adacbd9cef6.
2019-03-04 11:17:58 +01:00
Adrien Delorme
07dfab5e3c
use golang:1.12 instead of cicleci/golang:1.12
2019-03-04 11:17:58 +01:00
Adrien Delorme
9c9d5cd688
Update appveyor.yml
...
remove obsolete setenv
2019-03-04 11:17:58 +01:00
Adrien Delorme
662f2f845a
travis.yml: use go 1.12
2019-03-04 11:17:58 +01:00
Adrien Delorme
6e872fc40b
.circleci/config.yml: use go 1.12
2019-03-04 11:17:58 +01:00
Megan Marsh
eb98840f18
Merge pull request #7357 from e-mow/issue-7140
...
Issue 7140
2019-03-01 15:51:39 -08:00
Eric Mowry
cef3d0eb24
Ran make fmt per Megan's request.
2019-03-01 14:16:00 -05:00
Megan Marsh
ec3b0a5138
fix conflict from mergeing too many things to master at once
2019-03-01 11:13:32 -08:00
Megan Marsh
34a0edccbb
Merge pull request #7359 from Adezandee/gce-export-network
...
googlecompute-export: set network project id to builder
2019-03-01 10:28:48 -08:00
Megan Marsh
9d2b06bd61
Merge pull request #7342 from hashicorp/fix_7316
...
swap region copy and encryption steps
2019-03-01 10:26:43 -08:00
Megan Marsh
0abd16527e
Merge pull request #7337 from sargun/fix-chroot-builder
...
Amazon-chroot: Fix building PV images and where mount_partition is set
2019-03-01 10:25:04 -08:00
Stephen Fox
d51e300fcd
Clarified comment for 'defaultRsaBits' constant.
...
That *is* a lot of bits.
2019-03-01 12:17:13 -05:00
Stephen Fox
7e1cbc6d89
Rename references to key pair name to comment.
...
Per the OpenSSH manual, the field is for a comment.
2019-03-01 10:00:29 -05:00
Arnaud Dezandee
f9ae926d8f
googlecompute-export: set network project id to builder
2019-03-01 15:12:31 +01:00
Eric Mowry
109ba2c54c
After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty.
2019-02-28 21:36:25 -05:00
Megan Marsh
04d5276040
Merge pull request #7339 from devenney/feature/7322
...
Add functionality to marshal a Template to valid Packer JSON
2019-02-28 15:32:20 -08:00
Megan Marsh
3b6ff0fe3e
Merge pull request #7106 from hashicorp/revert_docker_changes
...
docker: user /bin/sh by default
2019-02-28 15:31:53 -08:00
Megan Marsh
0371e2a1b4
Merge pull request #7074 from hashicorp/fix_3329
...
vmware-iso (esxi) Add check that "format" is not being set when remote_type is empty.
2019-02-28 15:30:54 -08:00
Megan Marsh
424a6a3a7e
Merge pull request #6983 from hashicorp/revert-6979-revert-6925-organization_renaming
...
DONT MERGE YET: Revert "Revert "Rename attribute api_access_key to organization_id""
2019-02-28 15:30:25 -08:00
Megan Marsh
d3ed89ab86
Merge pull request #6787 from hashicorp/nilable_encrypt
...
amazon: Nilable encrypt setting
2019-02-28 15:29:40 -08:00
Megan Marsh
ca2300cb03
update to v1.4.0-dev
2019-02-28 15:14:40 -08:00
Megan Marsh
542cb1d872
Cut version 1.3.5
2019-02-28 14:58:54 -08:00
Megan Marsh
58f0b8c22e
remove vet which seems to have been broken in golang v1.12
2019-02-28 14:51:29 -08:00
Megan Marsh
09df6a733d
cut release 1.3.5
2019-02-28 14:49:36 -08:00
Megan Marsh
64d5ef8709
update changelog date
2019-02-28 14:39:05 -08:00
Stephen Fox
61a8968b22
Use 'os.OpenFile' to atomically create debug key file.
...
Per code review feedback.
2019-02-28 17:23:33 -05:00
Stephen Fox
094c87e395
Remove 'SSHPublicKeyUrlEncoded', use 'urlquery' instead.
...
Per code review feedback, the Go template library supports
encoding variables in URL query format. Instead of exposing
two different public key formats (unmodified string and a
URL encoded string), just have the user apply the 'urlquery'
modifier to their template.
2019-02-28 17:06:51 -05:00
Eric Mowry
e74a81e27b
Deny the copying of .vmxf from the source VM to the target VM. If this file gets copied over to the new VM once the VM gets deleted the .vmxf and the folder for the VM stay on the datastore. This causes Packer to hang because the folder on the datastore does not go away during the cleanup process.
2019-02-28 16:47:46 -05:00
Eric Mowry
1127096beb
Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted.
2019-02-28 16:43:47 -05:00
Megan Marsh
49a6436c18
fix wording in changelog
2019-02-28 13:02:19 -08:00
Megan Marsh
7dbd42c7f3
update changelog
2019-02-28 11:50:39 -08:00
Megan Marsh
1e47421ba1
Merge pull request #7351 from hashicorp/move_pause_before_connection
...
move pause to after connection can be established.
2019-02-28 10:56:11 -08:00
Stephen Fox
56c17941fe
Added comment to authorized_keys 'sed' calls per review.
2019-02-28 10:54:14 -05:00
Stephen Fox
856810e82e
Coalesce private key type switch cases per review feedback.
2019-02-28 09:56:11 -05:00
Stephen Fox
672b22bd13
Move 'CreateKeyPairConfig' closer to callers.
...
Per review feedback.
2019-02-28 09:44:25 -05:00
Stephen Fox
302828905d
Move 'FromPrivateKeyConfig' closer to caller.
...
Per review feedback.
2019-02-28 09:42:20 -05:00
Stephen Fox
ed06656613
Update 'authorizedKeysLine' doc per review feedback.
2019-02-28 09:40:00 -05:00
Stephen Fox
415ef26768
Removed TODO about key pair description per review feedback.
2019-02-28 09:30:30 -05:00
Adrien Delorme
22df491c67
mock tty using interfaces to test more easily
2019-02-28 14:40:55 +01:00
Chris Marget
0f1bde760c
Merge pull request #4 from stephen-fox/refactor-ssh-key-pair-logic
...
Initial take on code review feedback from @azr.
2019-02-27 17:05:44 -05:00
Brendan Devenney
328cbf4e42
Merge branch 'master' into feature/7322
2019-02-27 19:29:18 +00:00
Adrien Delorme
7f5c794e5f
add go-tty vendor
2019-02-27 17:01:02 +01:00
Adrien Delorme
239a0c633f
use go-tty in ui.Ask to fix #7299
2019-02-27 16:59:59 +01:00
Adrien Delorme
c588a8a24d
Revert "cheggaaa.pb: try to not open tty at init to see if it causes #7299"
...
This reverts commit 4e55278839
.
2019-02-27 16:52:55 +01:00
Adrien Delorme
f535464097
up a test
2019-02-27 11:17:56 +01:00
Adrien Delorme
f03cbd8a10
aws: allow to pass nil bool as encryption parameter
...
to retain current encryption settings
this changes the fields :
* ami_config.encrypt_boot
* block_device.encrypted
This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy
2019-02-27 11:17:56 +01:00
Adrien Delorme
ce8532e94b
aws: document ValidateRegion better
2019-02-27 11:17:08 +01:00
Adrien Delorme
6af621c37a
aws: StepAMIRegionCopy call waitgroup.add only once
2019-02-27 11:17:08 +01:00
Adrien Delorme
0e8afa37d5
Merge pull request #7347 from amphied/master
...
Fix support for aws-us-gov
2019-02-27 10:57:53 +01:00
Michael F
01a0b0c766
kmsArnStartPattern - fix support for aws-us-gov
...
While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration.
For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html
Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.
2019-02-26 16:54:54 -08:00