Adrien Delorme
7384b86e95
windows plugin: prioritize AppData over default user directory ( UserProfile )
...
It was the default behaviour before.
It is also standard for a binary to use files from the AppData directory. ex: c453e0c757/google/default.go (L104)
More on home: https://en.wikipedia.org/wiki/Home_directory
2019-01-04 14:14:38 +01:00
Megan Marsh
a734aa2255
Revert "mux_broker_test.go: make non blocking errChan"
...
This reverts commit d9e32d437c
. It turns out that it was already non-blocking with a length of one.
2018-12-17 13:49:47 -08:00
Adrien Delorme
895d49ca10
Merge pull request #7119 from hashicorp/fix_race
...
try to remove race condition in mux test
2018-12-17 11:42:55 +01:00
Adrien Delorme
d9e32d437c
mux_broker_test.go: make non blocking errChan
...
* in case of Dial errors to avoid a deadlocks
2018-12-17 11:09:56 +01:00
Adrien Delorme
2944030daf
mux_broker_test.go: range over chan for simplicity
2018-12-17 11:01:46 +01:00
Adrien Delorme
9a31d0de58
mux_broker_test.go: defer close chan
2018-12-17 10:58:32 +01:00
Megan Marsh
70c6fcb824
Merge pull request #7078 from aspectcapital/issue-5478
...
Elevated support for puppet-* & chef-client provisioners
2018-12-14 19:06:46 -08:00
Megan Marsh
f6070de070
fix test
2018-12-14 13:59:26 -08:00
Megan Marsh
52176ecf2d
try to remove race condition in mux test
2018-12-14 13:53:39 -08:00
Matt Dainty
19bd28cd72
Fix/add tests
2018-12-07 16:23:03 +00:00
Adrien Delorme
d876978337
Fixed misspelling in a comment residing in packer/config_file.go as suggested by @azr.
...
Co-Authored-By: arizvisa <arizvisa@users.noreply.github.com>
2018-12-05 17:34:09 -06:00
Ali Rizvi-Santiago
ecf45d4740
Added tests for packer.ExpandUser in packer/config_file_test.go.
2018-12-04 16:54:49 -06:00
Ali Rizvi-Santiago
040a33567e
Trying again one more time to prevent import cycles.. Moved common.ExpandUser into packer.ExpandUser..
2018-12-04 16:54:47 -06:00
Adrien Delorme
1055c119bc
make code of homeDir, configFile & configDir not os specific anymore
2018-11-30 15:47:43 +01:00
Adrien Delorme
5147ac0364
use Getenv instead of LookupEnv so users can set USER="" and HOME="" + lookup different username only if it is different thant the current username
2018-11-30 14:56:53 +01:00
Ali Rizvi-Santiago
eec68e319e
Replaced unsafe method of determining a user's home directory with an implementation based on os/user.
2018-11-24 00:56:53 -06:00
Rémi Jouannet
118a9cb8c6
more explicit message
2018-11-09 14:44:34 +01:00
Matthew Hooker
098764d8ac
WIP
2018-10-26 16:59:20 -07:00
Adrien Delorme
c393ccb7ca
fix progress bar termination typo
2018-10-26 11:29:15 +02:00
Adrien Delorme
25775cd266
fix more race conditions
2018-10-15 16:31:59 +02:00
Adrien Delorme
27f4b9e4a1
pb/testing: triger more race condition by having the progress bar refresh more often
2018-10-15 15:28:46 +02:00
Adrien Delorme
4cae413a29
remove unedded atomic call ( protected by a lock )
2018-10-15 15:28:08 +02:00
Adrien Delorme
56ccba86c7
fix some race conditions
2018-10-15 13:53:59 +02:00
Adrien Delorme
cf2c309c5e
add race conditions triggers for progress bar
2018-10-15 13:53:51 +02:00
Adrien Delorme
611610c89d
BasicProgresssBar: protect add with a lock
...
to avoid weird race conditions.
2018-10-02 16:57:16 +02:00
Ashley Lowde
2884f6fab6
improve formatting and documentation for PR#6784
2018-10-02 20:00:45 +09:30
Ashley Lowde
12496e3702
add optional timestamps to build log
2018-09-29 22:39:24 +09:30
Megan Marsh
3f8407d95f
Revert "Merge pull request #6700 from hashicorp/multi_progressbar"
...
This reverts commit 5470c08345
, reversing
changes made to c427486bca
.
2018-09-20 13:14:17 -07:00
Adrien Delorme
be27775a3c
start the pool only once
2018-09-12 17:04:10 -07:00
Adrien Delorme
dfeca9f0df
split progressbars per object
2018-09-12 16:21:58 -07:00
Megan Marsh
77980a7b53
fix progress bar mutex
2018-09-12 10:53:15 -07:00
Megan Marsh
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879
.
2018-09-10 16:48:42 -07:00
Adrien Delorme
0ac7b64364
fix panic of the future using a mutex instead of some atomic calls + more docs
2018-09-06 18:12:15 +02:00
Adrien Delorme
8a851efcc8
progressbar: more godocs
2018-09-06 17:01:14 +02:00
Adrien Delorme
bb59a70e8f
progressbar: use int64 instead of uint64
...
* it's what's used for file sizes and used lib
2018-09-06 16:49:15 +02:00
Adrien Delorme
f3c923c47d
add tests for progress bar rpc calls
2018-09-06 16:15:09 +02:00
Adrien Delorme
6d3e36e6ea
simplify remote progress bar as we are using a single instance
2018-09-06 16:14:59 +02:00
Adrien Delorme
d89e1133c3
use freshly merged random.AlphaNum instead of our own random
2018-09-06 15:55:19 +02:00
Adrien Delorme
42561cf777
packer/rpc/ui_test.go: test progress bar too
2018-09-06 15:53:59 +02:00
Adrien Delorme
7efe3cac3d
todos
2018-09-06 15:53:59 +02:00
Adrien Delorme
408578507f
also prefix bar with number of items processing
2018-09-06 15:53:59 +02:00
Adrien Delorme
541c68aed5
add StackableProgressBar struct that will refresh/show dl status for multiple files
...
* simplified the downloader interface, and removed the total/current values from them
* downloaders use a proxy reader that will add all read bytes to progress
* removed unused const mtu
* DownloadClient doesn't need a downloader, so I removed it too
2018-09-06 15:53:59 +02:00
Adrien Delorme
9b07d7670e
use no ops for ansible ui & MachineReadableUi
2018-09-06 15:53:59 +02:00
Adrien Delorme
fd7cb47adc
use proxy reader for download progress & stop storing total/current in downloaders
2018-09-06 15:53:59 +02:00
Adrien Delorme
ddd96c513b
first draft at self refreshing loading bar centralized/controlled by Ui
2018-09-06 15:53:59 +02:00
Megan Marsh
8fbce8c40c
Merge pull request #6357 from ladar/master
...
Added a 'split' function to parse template variables.
2018-08-24 15:18:36 -07:00
Megan Marsh
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
Megan Marsh
8a6441a7a5
add tests for SensitiveVars
2018-08-21 10:28:22 -07:00
Megan Marsh
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Matthew Hooker
31fcfe4bc2
PoC for filtering logs
2018-08-20 15:20:21 -07:00