5e14089851
tests/builder/amazon: Add basic testing for session_manager
...
* Add a test to ensure the proper host is returned when using session_manager
* Add a basic driver test for the validating that the SSMDriver will fail if the plugin is not in the path.
2020-05-08 09:32:48 -04:00
60e0ba7e68
Update iam instance profile name
2020-05-08 09:32:48 -04:00
d5a0262d6c
builder/amazon/instance: Add session manager support
2020-05-08 09:32:48 -04:00
e515aefee3
Add validation checks for session_manager
...
* Session manager connectivity only supported via SSH
* Session manager requires the use of an iam instance profile with system manager permissions
2020-05-08 09:32:48 -04:00
c1d2477d18
builder/amzon: Update port configuration for WinRM
...
Connectivity for WinRM works for the initial connection, but fails to upload any provisioning scripts - need to dive in deeper.
For now connectivity over SSH works as expected.
2020-05-08 09:32:48 -04:00
fbffbd1899
docs/builder/amazon: Add short blurb for connecting via the AWS session_manager interface
2020-05-08 09:32:48 -04:00
520061dee6
builder/amazon: Update Session Manger connectivity
...
* Update security group creation step skip ingress rules if using session manager
* Update create ssm tunnel step to dynamically set a session port
* Add SSHPort function to common to return session-manager tunnel port
* Update SSHHost to return proper host for session-manager
2020-05-08 09:32:48 -04:00
3dd46eb5f4
Add PoC of connectivity using session-manager-plugin
...
* Add a bunch of hard coded values for testing on port 8081; ssh configs
are set to localhost and 8081
* Add a base drive for communicating with the session manager plugin
* Update step for creating tunnel to actually create SSM session tunnel via driver
2020-05-08 09:32:48 -04:00
16604373ac
initial ssm tunnel changes - not working
2020-05-08 09:32:48 -04:00
b86efe7604
Vbox Checksum Bugfix ( #9101 )
...
* attempting to repro github issue 9049
* update vbox ovf configtest to table test for mixedcase bug
2020-05-07 19:08:52 -04:00
26d05abd4f
Merge pull request #9182 from hashicorp/fix_9131
...
support pushing multiple tags
2020-05-07 12:09:19 -07:00
62556c464c
Update builder/docker/artifact_import.go
2020-05-07 11:39:09 +02:00
02c1cf5b28
support pushing multiple tags
2020-05-06 16:39:41 -07:00
49af617be3
Merge pull request #9179 from hashicorp/fix_9177
...
fix docs for video_ram to use correct units
2020-05-06 09:53:40 -07:00
279fbb45ab
Merge pull request #9174 from hashicorp/do_9145
...
output_filename virtualbox option.
2020-05-06 09:40:33 -07:00
9baf2edd94
fix docs for video_ram to use correct units
2020-05-06 09:39:41 -07:00
5b4de6b16f
fix tests
2020-05-06 09:27:20 -07:00
aa09c52059
generated docs
2020-05-06 09:23:15 -07:00
2e2374b6be
add tests
2020-05-05 18:52:31 -07:00
f0d2680426
remove spot_price_auto_product from docs ( #9173 )
2020-05-05 20:48:27 -04:00
73eda08540
allow user defined output filename
2020-05-05 16:09:05 -07:00
6a682aca2e
Merge pull request #9124 from GennadySpb/yandex-export-post-processor
...
[WIP] Yandex export post processor
2020-05-05 11:01:13 -07:00
7e0cfd8b77
add undocumented tag to struct-markdown generator so that we can leave internal-use-only fields out of docs
2020-05-01 10:31:38 -07:00
3f8ee2b426
add exported files to VSphere artifact ( #9020 )
...
* add exported files to VSphere artifact
* clean up grammar for vsphere template docs
* add to vsphere clone
2020-04-30 15:22:57 -04:00
86ac132056
hyperv: add support for setting the boot order ( #9046 )
2020-04-30 13:31:41 +02:00
86ab71f56e
test/azure/arm: Add regression test case for ssh_username overrides ( #9136 )
...
This test is for the regression fixed in #9103
Before fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
--- FAIL: TestConfigUserNameOverride (0.42s)
config_test.go:75: Expected 'c.Comm.SSHPassword' to be set to generated password, but found ""!
config_test.go💯 Expected 'UserName' to be set to 'override_winrm_username', but found "packer"!
FAIL
FAIL github.com/hashicorp/packer/builder/azure/arm 0.425s
FAIL
```
After fix
```
⇶ go test ./builder/azure/arm/... -run=TestConfigUserNameOverride
ok github.com/hashicorp/packer/builder/azure/arm 0.379s
```
* Fix variable names in error messages
2020-04-30 10:49:58 +02:00
30061b3def
Merge pull request #9095 from VladRassokhin/vsphere-disable-shutdown
...
Add disable_shutdown option to VSphere builders
2020-04-29 15:18:24 -07:00
2a560a517e
Merge pull request #8946 from thor/feature/vgpu-profiles
...
Add support for specifying vGPU profiles
2020-04-29 13:27:19 -07:00
03c4bebf00
Add disable_shutdown option to VSphere builders
...
Also don't try to shut down VM if it's already off, otherwise VSphere would raise an error: "The attempted operation cannot be performed in the current state (Powered off)."
2020-04-29 14:19:43 +03:00
aa595fa1aa
Rename arg
2020-04-27 02:37:10 +03:00
9489a46f32
Make some steps exportable, add 'GetInstanceMetadata' method
2020-04-27 02:19:08 +03:00
c43a52aafe
fix issue where -force is not working with vsphere builders ( #9039 )
...
* add better error support to check if vm exists use path.Join so that it looks up the VM correctly turn off VM if it is still running
* fix the vsphere-clone also
* add a common precleanvm to the driver to dedupe iso and clone logic, reduce the if nesting
2020-04-23 08:07:07 -04:00
e0d2f4fd69
builder/azure-arm: Fix SSH connection for temporary admin users specified in `ssh_username` ( #9103 )
2020-04-23 11:04:49 +02:00
26d768f429
[builder/azure-chroot] Shared image source ( #9070 )
2020-04-23 11:03:17 +02:00
ab119d3270
builder/azure/chroot: fix dropped error ( #9106 )
2020-04-23 10:53:13 +02:00
da4a5224be
HCL2 singular blocks: use key/value or name/value depending on how the service names things ( #9078 )
...
* make sure keyvalue and namevalue filters are using the same naming as the service being used
* make docs a bit more readable for KeyValues too
* Update website/pages/docs/from-1.5/expressions.mdx
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
Co-authored-by: Megan Marsh <megan@hashicorp.com>
2020-04-23 10:46:49 +02:00
50823e2573
Merge pull request #9093 from Hakujou/osc-bsu-fix
...
Compliance with oAPI spec for Outscale osc-bsu builder
2020-04-21 10:49:46 -07:00
761abdda4e
Updating documentation for azure-arm builder ( #9097 )
2020-04-21 10:47:48 +02:00
1155ab8e3c
Add 'target_image_folder_id' for builder/yandex ( #9080 )
...
Add 'target_image_folder_id' for builder/yandex
Closes #9079
2020-04-20 15:20:05 +02:00
1f4e8785f3
Compliance with oAPI spec for Outscale OSC-BSU
2020-04-20 15:00:51 +02:00
5d2fee04b2
builder/azure: enable boot Diagnostics ( #9053 )
...
* enable boot Diagnostics
2020-04-20 07:29:13 -04:00
cc367bd0b7
Merge pull request #9045 from lausser/cloud-init
...
feat(proxmox): add ability to add a cloud-init drive
2020-04-17 14:09:02 -04:00
89f3aa0bd6
[builder/azure-arm] Use VM/build location for image location ( #9068 )
...
* [builder/azure-arm] Use VM/build location for image locationThe builder was using the location of the containing resource group asthe image location, but the API call can only create images in the samelocation as the source VM that is being captured.
2020-04-17 05:43:03 -04:00
855808ec6f
Merge pull request #8970 from szamfirov/shielded_vm_support
...
Adding custom shielded images support (GCP)
2020-04-16 16:32:04 -07:00
b706f02408
Fixing auto-generated code errors
2020-04-16 16:22:42 -07:00
d827f4f757
Adding custom shielded images support (GCP)
...
Adds `enable_secure_boot`, `enable_vtpm` and `enable_integrity_monitoring`
config options to enable building of custom Shielded GCP Compute images.
Feedback on this is more than welcome as this is my first attempt in
contributing to anything Packer related.
Packer is great for us to build custom images on top of GCP but we would
like to enhance that to support Shielded VM images. This will allow us
to have more secure and trusted images which our team(s) will be using.
2020-04-16 16:22:41 -07:00
08787ba31f
Merge pull request #9028 from vijayrajah/set_azure_custom_res_names
...
Set Custom Resource Names for Azure-Arm builds
2020-04-16 15:58:41 -07:00
da7382980a
Fix failing test & format code
2020-04-17 00:17:39 +05:30
fff06353b7
Update builder/azure/arm/tempname.go
...
refactor the code.. thanks for the suggestion @sylviamoss
Co-Authored-By: Sylvia Moss <sylviamoss.m@gmail.com>
2020-04-17 00:04:39 +05:30
73242e8de4
make sure keyvalue and namevalue filters are using the same naming as the service being used
2020-04-16 17:22:13 +02:00
dc2813c8e2
feat(proxmox): add ability to add a cloud-init drive
2020-04-15 22:00:42 +02:00
d580ea7950
Merge pull request #9069 from tencentyun/master
...
builder/tencent: fixed InstanceOperationInProgress error #9054
2020-04-15 07:21:33 -04:00
ebfc5bcdcb
Merge branch 'master' into feature/vgpu-profiles
2020-04-15 12:02:37 +02:00
e8f8ebf132
builder/vmware: Add some additional debug logging to the driver version check ( #9064 )
2020-04-15 10:34:48 +02:00
632610d9c0
fixed InstanceOperationInProgress error #9054
2020-04-15 12:38:50 +08:00
440f540e28
fix merge issues with generated code
2020-04-14 10:31:57 -07:00
5f2849b5b4
builder/vsphere-clone: support firmware changing
2020-04-14 10:28:43 -07:00
91a1ad63fa
builder/vsphere-iso: support EFI Secure Boot using another value in `firmware` ( #8873 )
2020-04-14 10:28:22 -07:00
840e67f775
HCL2: when we see a map generate an attribute spec instead of a block spec ( #9035 )
...
* mapstructure-to-hcl2: when we see a map generate an attribute spec and not a block spec
this will alow to do
tags = {
key = "value"
}
instead of
tags {
key = "value"
}
This will also enable using variables directly for those tags
* generate code
* update tests
2020-04-14 16:05:13 +02:00
7f0dbdebb2
clean up documentation for new NIC and storage params
...
adding examples, updating .gitattributes so *.mdx files have LF endings for windows
2020-04-13 14:28:50 -04:00
df47fd5076
Merge pull request #9021 from paulmey/azure-chroot-shared-image-destination
...
[azure/chroot] Add azure-chroot shared image destination
2020-04-09 14:42:13 -07:00
621bd8ccac
Fix error message grammar
2020-04-09 20:55:10 +00:00
89a8238a07
Fix artifact output
2020-04-09 20:54:50 +00:00
47107e6355
Default polling delay 5 sec
2020-04-09 20:37:23 +00:00
9209826bfe
Update the doc with more info
2020-04-10 00:34:56 +05:30
4ffe5611b8
Add more tests
2020-04-08 21:05:26 +00:00
a48c0ecf49
update docs for headless to help users know they may need to launch the gui
2020-04-08 13:53:19 -07:00
1e66a1b355
Fix linting & code generation
2020-04-09 00:00:13 +05:30
56bf8bd686
Merge branch 'set_azure_custom_res_names' of github.com:vijayrajah/packer into set_azure_custom_res_names
2020-04-08 23:54:21 +05:30
a3c580f2ac
Merge branch 'master' into set_azure_custom_res_names
2020-04-08 23:51:58 +05:30
53f54000e6
generate spec & fix typo
2020-04-08 23:42:49 +05:30
2a40f471b7
Add vgpu_profile support for using GRID vGPUs
...
It hooks directly into Configure, common for both vsphere-clone and
vsphere-iso.
Note that acceptance tests are still missing.
2020-04-08 17:11:14 +02:00
b12aedcda9
Remove lint
2020-04-07 23:09:42 +00:00
5c89d22fa2
generated & docs
2020-04-07 23:05:09 +00:00
2240ead39c
[azure/chroot] Add shared image output
2020-04-07 22:49:24 +00:00
73edd9d3d2
Make skip_cleanup generic
2020-04-07 22:49:24 +00:00
90188bb18d
add func for searching string slice
2020-04-07 22:49:24 +00:00
a3d8bf27e1
Add snapshot and gallery clients
2020-04-07 22:49:24 +00:00
cfe37057bd
Use const for statebag key
2020-04-07 22:49:24 +00:00
f3703a775f
Use subscription id from client set
2020-04-07 22:49:24 +00:00
6131301fdd
Standardize compute SDK version
2020-04-07 22:49:24 +00:00
f73a673b99
Extract build steps generation
...
Add tests for build step generation
2020-04-07 22:49:21 +00:00
c167ef91ce
Move PIR :latest resolution to step
2020-04-07 22:49:21 +00:00
f0ec912ba6
Make VirtualMachineImagesClient easier to mock
2020-04-07 22:49:21 +00:00
a3b49cdc08
Stub metadata service for builder tests
2020-04-07 22:49:21 +00:00
b3e361a139
Extract testUI func
2020-04-07 22:49:20 +00:00
81b08898ba
update generated pages after rebase
2020-04-07 17:53:26 -04:00
2999934326
fix generation script, bugfixes in source comments, update website paths in primary codebase
2020-04-07 17:53:22 -04:00
9165be87da
packer.io prefix removal, html extension remove for in-code errors
2020-04-07 17:53:22 -04:00
af257c2bb9
fix all local relative links
2020-04-07 17:50:53 -04:00
4afd107eeb
patch source files for extensions changes
2020-04-07 17:50:51 -04:00
37300c7203
fix backtick errors
2020-04-07 17:50:47 -04:00
bcc848a83d
were rendering yay
2020-04-07 17:50:47 -04:00
92d4553890
initial port
2020-04-07 17:50:46 -04:00
07be1a0a30
Merge pull request #8986 from vijayrajah/feature/datadisk-change_name
...
datadisk name change
2020-04-07 11:06:35 -07:00
185deeeb38
Fix provisioner acc-test builder and provisioner store
2020-04-06 16:52:24 -04:00
b183c5498f
provisioner/powershell: Add basic Powershell provisioner acceptance tests
...
* Modifies the amazon-ebs builder with a windows build configuration
```
⇶ ACC_TEST_BUILDERS=amazon-ebs ACC_TEST_PROVISIONERS=powershell go test -v ./provisioner/powershell/... -run=TestPowershellProvisioner_Inline
--- PASS: TestPowershellProvisioner_Inline (256.50s)
--- PASS: TestPowershellProvisioner_Inline/testing_amazon-ebs_builder_against_powershell_provisioner (256.50s)
PASS
ok github.com/hashicorp/packer/provisioner/powershell 256.525s
```
2020-04-06 16:52:05 -04:00
cd41ad1a40
change resource names
2020-04-07 02:17:50 +05:30
90a0c5ec49
fix more typos ( ')]' )
2020-04-06 22:02:43 +05:30
620c791473
Merge branch 'master' into feature/datadisk-change_name
2020-04-06 21:52:43 +05:30
1009e8c983
fix more typos
2020-04-06 21:50:05 +05:30
1314d69b51
fix typo (add missing ')]' )
2020-04-06 11:40:05 +05:30
0589f57d4d
Update tests for datadisk name change
2020-04-05 01:16:24 +05:30
b804e5a8f5
Merge pull request #8987 from VaijanathB/azure-devtestlabs-take2
...
Building Azure devtestlabs Images using Packer - update
2020-04-03 11:14:31 -07:00
665330de92
Write generic Builder-Provisioner acceptance test logic ( #8963 )
2020-04-03 18:17:09 +02:00
aba9797730
Fix :: allow Managed data disks to be used with azure shared image gallery image Sources ( #8912 )
2020-04-03 10:18:02 +02:00
20379c9eff
Rebasing with origin/master and fixing issues
2020-04-02 18:15:08 -07:00
8194b664af
Fixing issues due to merge.
2020-04-02 17:25:41 -07:00
b7d85b8a23
Added acceptance tests for DTL. Fixed couple of issues with DTL root resource group not set to new directory
2020-04-02 17:23:21 -07:00
69015b1870
Fixing the linting errors
2020-04-02 17:22:39 -07:00
fd21b669db
Fixing the linting errors now required for merging
2020-04-02 17:22:16 -07:00
d43fb441b9
Updating the credentials to be picked up from environment variables.
2020-04-02 17:18:00 -07:00
e726902116
Fixing the latest changes from the merge
2020-04-02 17:16:31 -07:00
645cdf1a59
Updating the modules to include update to autorest 12.4
2020-04-02 17:13:36 -07:00
0f9415297f
Merge pull request #8679 from kwibus/gcp-fallback-image
...
[WIP] fix #8589 gcp public fallback image
2020-04-02 16:49:50 -07:00
5340af4d49
Merge remote-tracking branch 'upstream/master' into feature/datadisk-change_name
2020-04-02 21:53:47 +05:30
d82475566a
change datadisk names -- WIP
2020-04-02 21:28:38 +05:30
b0c7fe491c
Remove net_device prepare validation ( #8979 )
2020-04-02 11:34:05 +02:00
1963f3aa6f
Merge pull request #8893 from itzimourakas/feature7379
...
[WIP] Feature7379 - https://github.com/hashicorp/packer/issues/7379
2020-04-01 09:33:25 -07:00
cf3c448d17
disk_size should not be required if storage is defined
2020-03-31 11:47:09 -04:00
0dc92991f4
Merge pull request #8945 from hashicorp/fix_8777
...
only set NoDevice if NoEphemeral is set; otherwise, legit block devic…
2020-03-27 10:07:27 -07:00
413e19b842
Merge pull request #8942 from desolatorxxl/google-fix-ssh-keys-metadata
...
[builder/google] Use "ssh-keys" metadata rather than deprecated "sshKeys"
2020-03-24 14:49:31 -04:00
8ae6256c03
add test of NoEphemeral
2020-03-24 09:10:31 -07:00
fc36a37db8
only set NoDevice if NoEphemeral is set; otherwise, legit block device mappings get destroyed
2020-03-24 08:51:32 -07:00
c387dc2c53
builder/vsphere-clone: Find the vm within the folder ( #8938 )
2020-03-24 11:28:00 -04:00
b17b211aa9
Add cleanup_remote_cache config option to vmware-iso ( #8917 )
2020-03-24 16:16:25 +01:00
e6368b9246
Fix azure winrm_password attribution and allow to set winrm_username ( #8928 )
2020-03-24 14:43:24 +01:00
87f7160084
[builder/google] Use "ssh-keys" metadata rather than deprecated "sshKeys"
2020-03-24 08:33:55 +01:00
2c6f0968b3
Allow accepting image for the members in OpenStack builder ( #8931 )
...
* Allow accepting image for the members in OS builder
* Add more documentation to image_auto_accept_members parameter
2020-03-23 17:07:00 -04:00
e78dfdddd1
feat(proxmox): add onboot directive support
...
Closes #8934
2020-03-22 17:25:48 -07:00
a7c5daf80d
vsphere/iso: Add support for ovf export options
...
* Fix generated documentation for the additional export options field
2020-03-19 14:46:30 -04:00
99b0b98311
Add ovf export capability to vsphere builders ( #8764 )
...
* add ovf export capability to vsphere builders
* remove unneeded floppy ejection
* add prepare step for export. updated output directory to be the actual destination directory
* add step export documentation
* add extra export options
* add ui messages for export step
Co-authored-by: Megan Marsh <megan@hashicorp.com>
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-03-19 13:51:43 -04:00
dd04108ac8
Fix :: allow Managed data disks to be used with azure shared image gallery image Sources
2020-03-19 12:11:34 +05:30
3dae5df6e4
Merge pull request #8905 from hashicorp/fix_8493
...
Fix azure key vault cleanup failure
2020-03-18 15:29:38 -07:00
be1a6c9f35
return error when LoadSnapshots turns up empty
2020-03-18 14:03:22 -07:00
28797dd709
replace the homegrown vault delete functions in azure with the sdk ones.
2020-03-18 13:48:54 -07:00
e7dba3e55e
fix error cleaning up existing keyvault
2020-03-18 13:48:54 -07:00
23f56036a4
Merge pull request #8889 from hashicorp/hcl2_singular_blocks
...
Hcl2 singular blocks
2020-03-17 12:39:04 -07:00
fab344a1fc
Update ami_config.go
...
quote string in err
2020-03-17 15:41:58 +01:00
4ccf158fbf
Update image_config.go
2020-03-17 15:26:18 +01:00
88297c796d
Merge branch 'master' into hcl2_singular_blocks
2020-03-17 14:47:17 +01:00
834f44190f
go generate
2020-03-17 12:30:36 +01:00
94a1f0bcb6
go fmt
2020-03-17 12:05:37 +01:00
911dc5ad95
wip
2020-03-17 11:33:11 +01:00
b5e8750f5f
Change key/value to name/value to remain consistent with Terraform
2020-03-17 11:23:11 +01:00
e503afb9da
feat(proxmox): add ability to specific vga adapter
...
Resolves #8867
2020-03-16 15:58:46 -07:00
3cae1a81ef
up tests
2020-03-16 17:54:52 +01:00
d532bb376c
wip
2020-03-16 17:47:44 +01:00
c845436e32
KeyValues.CopyOn: make sure a receiving nil map is set too
2020-03-16 15:46:08 +01:00
87d6b2433f
make generate
2020-03-16 15:21:29 +01:00
9a74ce60d5
Update config.go
2020-03-16 15:12:13 +01:00
e1c84806cc
rewrap
2020-03-16 14:55:03 +01:00
ac7cc8c5ac
Update target_image_config.go
2020-03-16 14:53:06 +01:00
5c91c7aae6
Update source_machine_config.go
2020-03-16 12:42:56 +01:00
bd387edf5a
Update run_config.go
2020-03-16 12:40:09 +01:00
392afa30cf
Update block_device.go
2020-03-16 12:37:36 +01:00
fc837e3698
Update run_config.go
2020-03-16 12:36:20 +01:00
ce8d3d3747
wip
2020-03-16 12:35:25 +01:00
a9ed8eac2a
Update config.go
2020-03-16 12:32:57 +01:00
0cbf80dafe
wip
2020-03-16 12:26:03 +01:00
45695608b5
WIP
2020-03-16 12:21:46 +01:00
dab689ce2e
WIP
2020-03-16 12:19:34 +01:00
dbb4981d66
WIP
2020-03-16 12:13:05 +01:00
0f2cb45fc6
added instance principals support for oci builder
2020-03-15 17:22:06 +00:00
6008f911fd
Merge pull request #8847 from takaishi/support-keyboard-interactive
...
communicator/ssh: support keyboard-interactive auth to connect bastion
2020-03-13 11:48:12 -07:00
56045619d4
Merge pull request #8877 from paulcichonski/remote-esxi-bastion
...
vmware-iso esxi: Do not test if NIC is reachable when ssh bastion is required
2020-03-13 11:40:40 -07:00
6f2f17c400
WIP
2020-03-13 18:07:55 +01:00
6e6490d688
WIP
2020-03-13 18:04:48 +01:00
260dc59500
use the hcl2template.KVFilter where we can
2020-03-13 17:17:46 +01:00
b4efd13a4d
aws: use the empty func when possible
2020-03-13 17:17:24 +01:00
f50ff1d270
make generate
2020-03-13 11:29:42 +09:00
aeedc9af7a
Merge pull request #8879 from mbrancato/specify_keyvault_sku
...
Add support for configurable KeyVault SKU
2020-03-12 13:47:51 -07:00
49bd57ee12
add the remote iso first so that it is first in boot order
2020-03-12 11:29:19 -04:00
7b705545d9
docs: Various doc clean-ups to fix code block formatting and syntax highlighting ( #8868 )
2020-03-12 15:05:08 +01:00
ebb161ae41
Fix config documentation
2020-03-11 21:43:37 -04:00
892622987c
Add KeyVault parameter and fix whitespace
2020-03-11 21:13:10 -04:00
0f09638f7a
Add HCL2 spec for KeyVault SKU
2020-03-11 20:48:34 -04:00
3c6b248bd5
Fix formatting
2020-03-11 20:45:44 -04:00
926e3ac2e4
Add support for configurable KeyVault SKU
2020-03-11 20:33:57 -04:00
c3d793255e
Do not test if NIC is reachable when ssh bastion is required
...
Relates to https://github.com/hashicorp/packer/issues/8866
2020-03-11 19:27:48 -04:00
66ad6f3483
builders: Fix gosimple S1007 linting issue ( #8871 )
...
Results before change
```
⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007
builder/alicloud/ecs/image_config.go:208:9: S1007: should use raw string
post-processor/vsphere-template/step_mark_as_template.go:130:8: S1007: shape twice (gosimple)
builder/azure/arm/config.go:58:27: S1007: should use raw string (`...`)
builder/azure/arm/config.go:59:27: S1007: should use raw string (`...`)
builder/qemu/driver.go:192:15: S1007: should use raw string (`...`)
```
Results after change
```
⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007
```
2020-03-11 10:29:22 +01:00
4133acbdf3
update spot price docs
2020-03-09 08:46:30 -07:00
764b4cb50a
updated link to GuestOsIdentifier ( #8849 )
...
Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>
2020-03-06 15:30:11 +01:00
698924f246
vSphere ISO supports more common options ( #8845 )
...
The `convert_to_template` and `create_snapshot` are supported across
both builders, but currently only shown in the vSphere Clone docs, this adds
them to it.
2020-03-05 15:04:15 -05:00
7e382d0df7
Merge pull request #8828 from mvitaly/fix_8816
...
Remove all floppy controllers before adding a new one
2020-03-05 09:35:20 -08:00
8832b3e2ca
Merge pull request #8787 from jhawk28/vsphere_iso_multiple_disks
...
(vsphere-iso) add ability to define multiple disks
2020-03-04 15:17:54 -08:00
e1a46ec293
Fix gosimple S1025 linting errors ( #8838 )
...
Remove unneeded use of fmt.Sprintf for variables that are already strings.
2020-03-04 15:31:30 -05:00
1dbe5abc14
update documentation based on feedback
2020-03-04 09:48:01 -05:00
d7230827cd
(vsphere-iso) add ability to define multiple disks
...
Closes #8749
2020-03-04 09:48:01 -05:00
25f59a1592
Add a simple test for the call to remove all floppy controllers
2020-03-03 20:58:09 -08:00
ce674ff272
Add exclude mapstructure tag to exclude from hcl2spec struct ( #8785 )
2020-03-03 17:13:39 +01:00
6dbe86fcf4
only re-set path name if it needs to be unquoted; otherwise unquote r… ( #8826 )
2020-03-03 11:17:48 +01:00
67c9c2a59a
Remove all floppy controllers before adding a new one
2020-03-02 21:56:20 -08:00
9c9826ee4b
Merge pull request #8714 from williamb1024/hyperv-gen1-boot-order
...
WIP: Add Hyper-V builder `first_boot_device` setting to allow the selection of the initial device or device class used for booting the VM.
2020-03-02 12:27:25 -08:00
17fa6a3e95
proxmox: template_name cannot contain spaces
2020-02-26 08:44:27 +01:00
8e0ed66318
Fix raw string breaks escaping
2020-02-22 02:40:41 -06:00
efa9d94d8e
use raw string around regex to make go lint happy
2020-02-22 02:22:59 -06:00
d246d0c82a
More testing ( #4 )
...
Additional testing for SetFirstBootDevice and checking configuration in config.Prepare()
2020-02-22 02:03:42 -06:00
b5b190b1f0
Bootdevice testing ( #3 )
...
Start step_first_boot_device_test and rejigger ParseBootDeviceIdentifier to avoid regex where reasonable.
2020-02-22 00:29:05 -06:00
723a9eba9a
really, really, really fix driver_mock
2020-02-21 01:53:13 -06:00
11fae17308
again, really fix driver_mock
2020-02-21 01:44:49 -06:00
2de731453f
really fix driver_mock this time
2020-02-21 01:43:03 -06:00
0a0fbfc33b
fmt
2020-02-21 01:31:18 -06:00
dd8f4370c6
initial support for gen2 and fix driver_mock
2020-02-21 01:30:59 -06:00
5e1e4ec701
fmt && generate
2020-02-21 01:07:58 -06:00
d7300f4635
Remove legacy_boot and replace with first_boot_device (initial)
2020-02-21 01:01:09 -06:00
3d8bda31a4
modify docstring
2020-02-20 12:54:35 +01:00
dde74232f2
Clearly document all template-engine-enabled options ( #8770 )
2020-02-20 11:05:27 +01:00
eb35617985
Merge pull request #8756 from aeber/feature_eagerly_scrub_disks
...
vsphere-iso: add support for eagerly zeroed / scrubbed disks
2020-02-19 09:47:49 -08:00
5846c0cdd7
Merge pull request #8753 from jhawk28/bug_8743
...
fix #8743 by using interface instead of Network object
2020-02-18 10:12:34 -08:00
3f80414e6d
fix #8743 by using interface instead of Network object
2020-02-18 10:05:18 -05:00
f3231018ca
showing tencentcloud image id after copy to desination region ( #8763 )
2020-02-18 11:17:19 +01:00
9cbb49bacb
builder/vmware/iso: Expand `guest_os_type` docs ( #8760 )
2020-02-18 11:11:20 +01:00
94130b5def
add autogenerated help for disk_eagerly_scrub
2020-02-17 17:01:00 +01:00
6c749eecf7
add support for eagerly zeroed / scrubbed disks
2020-02-17 16:26:07 +01:00
807f39284d
Merge pull request #2 from hashicorp/master
...
merge from hashicorp/packer
2020-02-15 23:13:38 -06:00
7f0de5fc8d
add ability to define multiple NICs for vsphere-iso ( #8739 )
2020-02-14 17:51:57 +01:00
9ec8b67392
Add golangci-lint to project ( #8686 )
...
* Add golangci-lint as linting tool
* Disable failing staticchecks to start; GitHub issue to handle coming soon
* Run `goimports -w` to repair all source files that have improperly
formatted imports
* makefile: Add ci-lint target to run on travis
This change adds a new make target for running golangci-lint on newly
added Go files only. This target is expected to run during Packer ci builds.
* .github/contributing: Add code linting instructions
* travis: Update job configuration to run parallel builds
2020-02-14 11:42:29 -05:00
4f7670a1e6
Merge pull request #8690 from daxgames/vsphere_iso_remove_cdrom
...
vsphere iso remove cdroms
2020-02-13 11:00:47 -08:00
23fa3107a3
Render variables one time on prepare method ( #8727 )
2020-02-13 17:35:23 +01:00
78012dc56f
add autogenerated help for vsphere iso remove cdrom
2020-02-12 11:31:46 -05:00
c99dc56544
Update Azure ARM documentation
...
* Change generated documentation to indicate what image selection
options are required, and when.
* Refactor the structure of the documentation to highlight required
options for different types of builds
2020-02-10 21:14:11 -05:00
a90f75585b
Merge pull request #8709 from hashicorp/aws_max_retries
...
add max_retries option to aws builders
2020-02-10 14:58:44 -08:00
7e45a10e90
Merge pull request #8717 from luba239/master
...
Add service account ID to config #8716
2020-02-10 14:27:59 -05:00
dfefe7e8d9
Merge pull request #8704 from hashicorp/custom_vault_azure
...
Custom vault azure
2020-02-10 10:51:06 -08:00
a067b23e6d
Execute `make generate` #8716
2020-02-10 18:51:29 +03:00
38fe16e01f
Add service account ID to config #8716
2020-02-10 18:36:19 +03:00
61f5f867eb
make generate
2020-02-09 16:41:07 -06:00
9891e75f75
update hyper-v driver_mock.go
2020-02-09 15:39:35 -06:00
31622b50ac
applied fmt
2020-02-09 15:22:36 -06:00
7152732597
changing SetBootDvdDrive messaging to be truthful
2020-02-09 14:26:46 -06:00
55ae803852
Add Hyper-V support for Gen-1 boot order with ISO
2020-02-09 13:08:22 -06:00
7d5f0c11af
add max_retries option to aws builders
2020-02-07 16:36:14 +01:00
6d7c6ba18c
Add step_http_ip_discover to virtualbox to allow HTTPIP in vboxmanage ( #8700 )
2020-02-07 10:38:48 +01:00
2181f10e79
fix statebag setup; simplify conditional
2020-02-06 16:54:07 -08:00
7dd1fa44db
regenerate code
2020-02-06 16:41:28 -08:00
9643ad35f1
add tests
2020-02-06 16:41:28 -08:00
6d6b94d515
Add ability to use custom keyvault into azure builds
2020-02-06 16:41:28 -08:00
a1d9ba0e32
Merge pull request #8699 from fly1028/fix-instance-running-timeout
...
Instance Running waiter not aware of global waiter settings
2020-02-06 17:18:59 -05:00
c8062cc8b3
fix #8679 with source_image_project_id as list
2020-02-06 10:30:04 +01:00
e5e5fd1198
Instance Running waiter not aware of global waiter settings
2020-02-05 15:09:09 -08:00
1cb6f4e456
Merge branch 'vsphere_iso_remove_cdrom' of https://github.com/daxgames/packer into vsphere_iso_remove_cdrom
...
* 'vsphere_iso_remove_cdrom' of https://github.com/daxgames/packer :
format
Update builder.go
2020-02-05 11:11:43 -05:00
76680ac1c6
add docs
2020-02-05 11:10:50 -05:00
6b82bf5a93
format
2020-02-05 15:25:49 +00:00
9756a9858a
Update builder.go
2020-02-04 14:41:44 -05:00
4fa0f6baa3
recreate https://github.com/jetbrains-infra/packer-builder-vsphere/pull/238
2020-02-04 14:25:45 -05:00
561f02cc2f
builder/azure-arm: Update logic for setting subscriptionID ( #8685 )
...
* builder/azure-arm: Update logic for setting subscriptionID
Previously, when using managed identities, the Azure builder would set the SubscriptionID in the Prepare method. But would not update it after getting the updated SubscriptionID from the metadata server. This change updates the Run method to ensure a valid subscriptionID is saved to the statebag before continuing with an image build.
Co-authored-by: Paul Meyer <paul.meyer@outlook.com>
2020-02-04 10:54:58 -05:00
08b0bd1d2c
Fix HCL2 code generation for slices within another slice ( #8669 )
2020-02-03 17:03:28 +01:00
df18187032
builder/ncloud: Migrate ncloud-sdk-go-v1 to ncloud-sdk-go-v2 ( #8678 )
2020-02-03 14:55:01 +01:00
d252a24b82
allow user to set winrm_host override like we do ssh_host override
2020-01-30 15:22:22 -08:00
654cc4c4d5
builder/azure-arm: Set WinRMPassword on the communicator config
...
Build results before change
```
azure-arm: output will be in this color.
==> azure-arm: Running builder ...
azure-arm:
==> azure-arm: Provisioning with Powershell...
==> azure-arm: Provisioning with powershell script:
/tmp/powershell-provisioner922851060
==> azure-arm: Exception calling "RegisterTaskDefinition" with "7" argument(s): "(38,4):Task:"
==> azure-arm: At C:\Windows\Temp\packer-elevated-shell-5e320d29-bdbd-b619-9e64-0c8a301b9d1d.p
==> azure-arm: s1:60 char:1 ==> azure-arm: + $f.RegisterTaskDefinition($name, $t, 6,
"packer", $password, $logon_type,
==> azure-arm: $null) ...
==> azure-arm: +
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==> azure-arm: ~~~
==> azure-arm: + CategoryInfo : NotSpecified:
(:) [], MethodInvocationException
==> azure-arm: + FullyQualifiedErrorId :
ComMethodTargetInvocation
==> azure-arm:
==> azure-arm: Exception calling "GetTask" with "1"
argument(s): "The system cannot find the
==> azure-arm: file specified. (Exception from HRESULT:
0x80070002)"
==> azure-arm: At
C:\Windows\Temp\packer-elevated-shell-5e320d29-bdbd-b619-9e64-0c8a301b9d1d.p
==> azure-arm: s1:61 char:1
==> azure-arm: + $t = $f.GetTask("\$name")
==> azure-arm: + ~~~~~~~~~~~~~~~~~~~~~~~~~
==> azure-arm: + CategoryInfo : NotSpecified:
(:) [], MethodInvocationException
==> azure-arm: + FullyQualifiedErrorId :
ComMethodTargetInvocation
==> azure-arm:
==> azure-arm: Method invocation failed because
[System.__ComObject] does not contain a
==> azure-arm: method named 'Run'.
==> azure-arm: At
C:\Windows\Temp\packer-elevated-shell-5e320d29-bdbd-b619-9e64-0c8a301b9d1d.p
==> azure-arm: s1:62 char:1
==> azure-arm: + $t.Run($null) | Out-Null
==> azure-arm: + ~~~~~~~~~~~~~~~~~~~~~~~~
==> azure-arm: + CategoryInfo :
InvalidOperation: (Run:String) [], RuntimeExcept
==> azure-arm: ion
==> azure-arm: + FullyQualifiedErrorId : MethodNotFound
==> azure-arm:
Cancelling build after receiving interrupt
==> azure-arm: Removing the created Deployment object:
'pkrdp087bb80ibj'
==> azure-arm: Removing the created Deployment object:
'kvpkrdp087bb80ibj'
==> azure-arm:
==> azure-arm: Cleanup requested, deleting resource group
...
==> azure-arm: Resource group has been deleted.
Build 'azure-arm' errored: Build was cancelled.
Cleanly cancelled builds after being interrupted.
```
Build results after change
```
azure-arm: WinRM connected.
==> azure-arm: <Objs Version="1.1.0.1"
xmlns="http://schemas.microsoft.com/powershell/2004/04 "><Obj S="progress" RefId="0"><TN RefId="0"><T>System.Management.Automation.PSCustomObject</T><T>System.Object</T></TN><MS><I64
N="SourceId">1</I64><PR N="Record"><AV>Preparing modules for first use.</AV><AI>0</AI><Nil /><PI>-1</PI><PC>-1</PC><T>Completed</T><SR>-1</SR><SD> </SD></PR></MS></Obj><Obj S="progress" RefId="1"><TNRef RefId="0" /><MS><I64 N="SourceId">2</I64><PR N="Record"><AV>Preparing modules for first use.</AV><AI>0</AI><Nil /><PI>-1</PI><PC>-1</PC><T>Completed</T><SR>-1</SR><SD> </SD></PR></MS></Obj><Obj S="progress" RefId="2"><TNRef RefId="0" /><MS><I64 N="SourceId">3</I64><PR N="Record"><AV>Preparing modules for first use.</AV><AI>0</AI><Nil /><PI>-1</PI><PC>-1</PC><T>Completed</T><SR>-1</SR><SD> </SD></PR></MS></Obj></Objs>
==> azure-arm: Connected to WinRM!
==> azure-arm: Running local shell script:
/tmp/packer-shell091779215 azure-arm: 022xUtbwAH3DdqIoRCOh9caZi8tOYqcY
==> azure-arm: Provisioning with Powershell...
==> azure-arm: Provisioning with powershell script: /tmp/powershell-provisioner469853889
azure-arm: HELLO NEW USER; automatically generated aws password is: 022xUtbwAH3DdqIoRCOh9caZi8tOYqcY
==> azure-arm: Querying the machine's properties ...
```
2020-01-30 12:07:48 -05:00
dc31bad539
Sharing info with post-processors via artifact ( #8632 )
2020-01-30 11:27:58 +01:00
d2a9e6b32e
Format code with `gofmt -s -w`
2020-01-28 16:52:50 -05:00
e57004b2ec
Merge pull request #8662 from hashicorp/return_with_ssh_wait_timeout
...
WIP Add ssh_wait_timeout back for backward compatibility
2020-01-28 12:08:42 -08:00
6a07d76416
Merge pull request #8654 from hashicorp/fix_8583
...
Extract http ip discover to a new step
2020-01-28 08:50:48 -08:00
6ad7f593bf
Undo ssh_wait_timeout backward incompatibility
2020-01-28 17:26:01 +01:00
61bee60ecf
Add StepHttpIpDiscover tests
2020-01-28 10:31:17 +01:00
56206aa3ae
Merge pull request #8636 from hashicorp/clundquist/fix-lxd-dir-upload
...
fixes and closes #8547
2020-01-27 19:22:49 -08:00
df38d11270
Fix compilation error
2020-01-27 17:15:13 +01:00
0566f1f999
Extract http ip discover to a new step
2020-01-27 17:06:56 +01:00
8c8de27509
add note about error abort to vmware warning
2020-01-24 09:02:30 -08:00
b0b10f6939
Merge pull request #8496 from ryanhartje/delete_arm_deployment_on_cleanup
...
attempting to resolve deployment quota issue due to non-cleanup
2020-01-23 09:48:20 -08:00
c4a9715e50
updated the deleteTemplate invocation to a defer at the start of cleanup
2020-01-22 16:58:26 -06:00
111bab86d9
Merge pull request #8622 from datalot/pre-validate-with-filters
...
Allow aws builder pre validation to pass when subnet filters are present
2020-01-22 15:00:44 -05:00
15cbe4769c
fixes and closes #8547
2020-01-21 19:49:49 -08:00
0b7251a4bb
Share .Device and .MountPath between builders, provisioners and post-processors ( #8621 )
2020-01-20 16:29:38 +01:00
8e4c165173
Proxmox upload ISO
2020-01-17 22:17:28 +01:00
4fb0de5256
allow validation to pass when subnet filters are present
2020-01-17 11:57:42 -05:00
39c25b2c66
Add retry mechanism to amazon DeleteSnapshot ( #8614 )
2020-01-16 14:38:46 +01:00
0677b02e18
Share SourceImageName with provisioners and manifest post-processor ( #8603 )
2020-01-16 12:04:03 +01:00
83dc0a7c8b
fix config decode
2020-01-15 14:27:55 -08:00
fac320d290
Merge pull request #8480 from hashicorp/merge-vsphere-builder
...
Merge the vSphere builder
2020-01-15 14:11:20 -08:00
ecf0e5794a
Merge pull request #8607 from hashicorp/fix_vagrant_crash
...
Fix a crash in the vagrant driver
2020-01-15 13:33:23 -08:00
a847530a83
Update builder/vagrant/driver_2_2.go
...
Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>
2020-01-15 13:12:44 -08:00
d55f256cac
Merge pull request #8414 from footplus/fix_osc_ssh_host_detection
...
builder/osc: fix ssh host detection in Public Cloud and Nets
2020-01-15 12:13:28 -08:00
48811ed4e5
replace buffer copy loop with a scanner that handles carriage returns
2020-01-15 12:05:29 -08:00
6315f69019
break out of loop once channel is read from.
2020-01-15 11:00:41 -08:00
b8edaa9850
Merge pull request #8605 from hashicorp/fix_8599
...
remove unhelpful quotes to fix bug with reading key from a path with …
2020-01-15 10:56:23 -08:00
bbd64896a0
use strconv.unquote instead of DIY
2020-01-15 10:23:25 -08:00
0e177915f8
Add retry mechanism to DeregisterImage from awsec2 ( #8598 )
2020-01-15 10:28:14 +01:00
5980d32efb
remove unhelpful quotes to fix bug with reading key from a path with spaces in it.
2020-01-14 13:57:11 -08:00
82f03fca7c
fix to work with hcl2; update tests
2020-01-13 15:52:05 -08:00
dfb45e86cc
remove unused file, set up prepare() properly to work with HCL2 in vsphere-clone builder
2020-01-13 12:33:56 -08:00
9459e2233b
fix config loading to work with HCL2
2020-01-13 11:51:36 -08:00
f84634aff3
small log line improvements
2020-01-13 11:43:53 -08:00
d6a351b173
Rename communicator config variables and remove deprecated code ( #8584 )
2020-01-09 08:37:30 -08:00
baa203bb53
Adds acpi_shutdown to virtualbox builder ( #8587 )
2020-01-09 08:36:19 -08:00
6a2d73a0e9
Add missing doc variable description
2020-01-08 15:28:53 -08:00
e87aa237dd
Get plugin up to parity with v1.5.0. Remove custom jetbrains-internal testing logic; disable acceptance tests (for now) until we can set up a test rig inside of HashiCorp. Regenerate code based on vendoring changes.
2020-01-08 14:41:51 -08:00
c3c2622204
builder/tencentcloud: Correct the image name length validation, the max length of image name is 60 ( #8536 )
2020-01-08 12:05:37 +01:00
073eda76aa
remove extraneous files from when vsphere builder was a plugin, and move README into packer website as separated docs for vsphere-clone and vsphere-iso. Move option descriptions into struct code, and generate documentation directly from those structs as we do inside of the other builders
2020-01-07 16:59:31 -08:00
8cb1f7b1c1
Merge branch 'master' into merge-vsphere-builder
2020-01-07 14:23:38 -08:00
eeac289fa5
Merge pull request #8535 from alexyueer/master
...
fix issue #8534
2020-01-07 12:47:23 -08:00
21edd085c7
Merge pull request #8560 from alexyueer/feature/support_aliyun_profile_20200103
...
support aliyun profile
2020-01-07 12:45:54 -08:00
e9bb81a440
Merge pull request #8578 from hashicorp/unstick_vmware_shutdown_tests
...
bump the timeout to a very high level to protect against laggy CI mac…
2020-01-07 12:44:48 -08:00
7d789a1483
Merge pull request #8579 from hashicorp/do_8562
...
step_download: return without error if Urls is empty
2020-01-07 12:01:24 -08:00
c446bf07c5
Merge pull request #8574 from hashicorp/fix_8541
...
Fix 8541
2020-01-07 12:00:27 -08:00
90bdcf58bd
update step_download to return an ActionContinue if the URls field is empty. this allows us to simplify the hyperv builder, and is still safe because all other builders and uses of step_download already validate that the iso url is not empty if that's what they need, most of them inside of the IsoConfig prepare function.
2020-01-07 10:45:24 -08:00
be3c1ef106
bump the timeout to a very high level to protect against laggy CI machines
2020-01-07 09:59:25 -08:00
af2c4346f8
Merge pull request #8561 from ata18/ata18-end-of-life
...
Set expiry for image versions in SIG
2020-01-07 09:53:14 -08:00
Wilken Rivera
Ryan Hartje
Megan Marsh
Adrien Delorme
Rui Lopes
Vladislav Rassokhin
Gennady Lipenkov
jhawk28
Paul Meyer
Lars Lehtonen
Matthew Sanabria
Romain Lecat
vijayrajah
Svetlin Zamfirov
Adrien Delorme
Gerhard Lausser
Thor K. Høgås
Li Kexian
Jeff Escalante
Moss
Vaijanath Angadihiremath
Vaijanath Angadihiremath
Vaijanath Angadihiremath
desolatorxxl
Jorge Marey
Jeff Mixon
Vijay Rajah
Ilias Tzimourakas
r_takaishi
Mike Brancato
Paul Cichonski (pcichons)
jnsc
Vitaly Polonetsky
Calle Pettersson
William Brooks
Rens Sikma
Joshua Foster
Jason A. Beranek
Anselm Eberhardt
Dax T. Games
Luba Grinkevich
Patrick Ng
Dax T. Games
Yu SungDuk
Chris Lundquist
Rich Cavanaugh
Shengyu Liu