Megan Marsh
4472ecccb0
fix waiters that weren't applying env defaults
2018-08-31 13:30:41 -07:00
Megan Marsh
d00b815c06
Update public google cloud image projects
2018-08-31 13:13:19 -07:00
Manuel Riezebosch
fcfa54fb1d
[azure-arm] retry cleanup individual resources on error
2018-08-31 13:43:38 +02:00
Adrien Delorme
61480f41dc
fix some go vet issues in tests ( composite literal uses unkeyed fields )
2018-08-31 11:54:12 +02:00
Jeffrey Martin
1833b4edaf
validate compaction is skipped when not 'thin'
2018-08-30 16:44:00 -05:00
Jeffrey Martin
b51cd22b21
document ESXi disk compaction & use verbose option
2018-08-30 16:44:00 -05:00
Jeffrey Martin
09c71f3810
add support for disk compaction to esx5 builder
2018-08-30 16:43:53 -05:00
Megan Marsh
9926988ab7
Merge pull request #6621 from hashicorp/ssh_keys_centralised
...
Merge ssh fields usage
2018-08-30 14:13:21 -07:00
Megan Marsh
d606339edc
Merge pull request #6635 from hashicorp/fix_6493
...
fix chroot communicator to properly escape quotes
2018-08-30 09:40:03 -07:00
Megan Marsh
2b9f937c23
increase max retries from 3 to 20
2018-08-30 09:35:06 -07:00
Adrien Delorme
cbbfc6630d
scaleway: stop using config from statebag
2018-08-30 17:58:09 +02:00
Adrien Delorme
d159c0900b
openstack: use config only where needed
2018-08-30 17:52:11 +02:00
Adrien Delorme
df9e756865
pass the Comm instance to the amazon ebs builders steps
2018-08-30 12:50:29 +02:00
Adrien Delorme
157691c710
remove unecessary get/pug config in tests; those are being referenced
2018-08-30 12:07:37 +02:00
Adrien Delorme
94d5bb7a3b
revert test changes of builder/googlecompute/step_create_ssh_key_test.go
2018-08-30 12:04:21 +02:00
Harvey Lowndes
344e7e8b92
Validation for tag configuration
2018-08-29 15:31:05 -07:00
Harvey Lowndes
cc7d4e4a95
Add support for freeform tagging of images
2018-08-29 15:31:05 -07:00
Adrien Delorme
050a98e8bb
googlecompute builder: use config from statebag
2018-08-29 18:15:09 +02:00
Adrien Delorme
b0c09087a2
move SSHInterface/SSHIPVersion fields to communitator.Config struct
2018-08-29 14:51:28 +02:00
Adrien Delorme
cd851f8ac2
use public ssh key & key name from config instead of the statebag
2018-08-29 14:40:33 +02:00
Adrien Delorme
0938b640cc
use key pair name from config
2018-08-29 14:40:33 +02:00
Adrien Delorme
1e71712cc9
builder.alicloud: stop using config from statebag
2018-08-29 14:40:33 +02:00
Adrien Delorme
4fdf5714a6
builder.scaleway: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
0f9eddda3a
builder.oracle: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
92570a2725
builder.openstack: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
4982627dd2
builder.gcp: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
e0e6b0b8f7
builder.cloudstack: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
ef4ca9c48e
builder.amazon: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
dffcbb7a35
builder.alicloud: use c.Comm for ssh
2018-08-29 14:40:33 +02:00
Adrien Delorme
9a9b82715b
config.Comm.SSHKeyPair => SSHKeyPairName
2018-08-29 14:40:33 +02:00
Adrien Delorme
3a4bb26150
builder.aws: use key pair from comm struct
2018-08-29 14:40:33 +02:00
Adrien Delorme
293c485372
builder.aws: use SSHAgentAuth from Comm
2018-08-29 14:40:33 +02:00
Adrien Delorme
ef08c441c9
builder.aws: use Comm field for StepKeyPair & StepGetPassword
2018-08-29 14:40:33 +02:00
Adrien Delorme
7c358eed2f
removed unused builder/azure/common/lin.StepGeneralizeOS struct
2018-08-29 14:40:33 +02:00
Adrien Delorme
3d46fbd4f2
removed unused builder/azure/common/lin.StepCreateCert struct
2018-08-29 14:40:33 +02:00
Adrien Delorme
25de7ad1f2
PrivateKey => PrivateKeyFile
2018-08-29 14:40:33 +02:00
Adrien Delorme
324c46279b
up test
2018-08-29 14:40:33 +02:00
Adrien Delorme
5369c15459
helper: communicator.SSHFileSigner => ssh.FileSigner
...
* had to to avoid circular dependency
* this commit fixes #6631 ( esxi cannot be reached by ssh )
2018-08-29 14:40:33 +02:00
Adrien Delorme
b83c72fd54
more private keys in config
2018-08-29 14:40:32 +02:00
Adrien Delorme
336cac29d4
also use config.SSHPrivateKey for azure-arm builds
2018-08-29 14:40:32 +02:00
Adrien Delorme
d49ad12895
update gcp ssh tests
2018-08-29 14:40:32 +02:00
Adrien Delorme
663c8134ef
GCP: put ssh public/private key in config
2018-08-29 14:40:32 +02:00
Adrien Delorme
51d2aac9f6
SSHPrivateKey => SSHPrivateKeyFile
2018-08-29 14:40:32 +02:00
Megan Marsh
e4f6b6f720
fix chroot communicator to properly escape quotes
2018-08-28 09:16:43 -07:00
Matthew Hooker
7519037562
Merge pull request #6629 from hashicorp/travisbuild
...
travis builds go 1.11. remove 1.9
2018-08-24 20:51:31 -07:00
Matthew Hooker
3f1a9766f4
formatting verb fixes for go 1.11
2018-08-24 16:18:21 -07:00
Matthew Hooker
e41e99954d
go 1.11 format rules
2018-08-24 15:56:44 -07:00
Megan Marsh
c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
...
Various improvements to Hyper-V ISO and VMCX builders
2018-08-24 15:52:49 -07:00
Megan Marsh
bf191d1ef6
Merge pull request #6204 from arizvisa/GH-6197
...
Specify "bios.hddOrder" during the CreateVMX step for the vmware-iso builder.
2018-08-24 15:46:31 -07:00
Megan Marsh
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
Megan Marsh
fa99f931b7
Merge pull request #6601 from hashicorp/fix_6536
...
Increase waiter timeout for AWS WaitUntilImageAvailable command
2018-08-24 09:35:58 -07:00
Adrien Delorme
6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls ( #6622 )
...
* Remove duplicate unused SSHConfig funcs
* call to SSHConfigFunc() for azure/arm builder
* ncloud too
* remove empty ncloud file
2018-08-24 16:00:40 +02:00
Megan Marsh
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
...
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
Megan Marsh
1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
...
Filter logs
2018-08-23 13:30:21 -07:00
Megan Marsh
7f518cc2d0
Merge pull request #6616 from hashicorp/fix_6496
...
added new template variables to replace PACKER_KEY_INTERVAL with tuna…
2018-08-23 13:21:31 -07:00
Megan Marsh
31d4f8af45
use a time.Duration instead of a hardcoded ms
2018-08-23 13:16:01 -07:00
Rickard von Essen
70cfafb75c
Merge pull request #6490 from tcarrio/most-recent-image-openstack
...
OpenStack source image search filter
2018-08-23 12:41:06 +02:00
Tom Carrio
e2fe5cd775
Updated test cases to cover bad filters and empty()
2018-08-22 18:23:12 -04:00
Megan Marsh
bb319fb1e8
Merge pull request #6607 from hashicorp/gcp_min_cpu_platform
...
GCP: min cpu platform
2018-08-22 12:58:34 -07:00
Megan Marsh
918db58604
added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used
2018-08-22 11:37:56 -07:00
Adrien Delorme
e5ffa9e5b3
use SSHConfigFunc on right member in builder/parallels/pvm/builder.go
2018-08-22 18:23:23 +02:00
Adrien Delorme
fa44a4546f
use ssh.ParsePrivateKey where we can
2018-08-22 18:23:09 +02:00
Adrien Delorme
41f6e0334d
refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
...
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
Rickard von Essen
057a635cab
Merge pull request #6532 from sermilrod/Allowing-fixed-port-in-forwarding-rules
...
Cloudstack builder: adding public_ssh_port flag to use a fixed port in the forwarding rules
2018-08-22 14:27:38 +02:00
Rickard von Essen
3b49caaf40
OpenStack: refactored how source_image_filter is handled to remove reflection
2018-08-22 13:37:43 +02:00
Sergio Millan Rodriguez
befdb59da6
renaming public_ssh_port to public_port
2018-08-22 10:17:46 +01:00
Rickard von Essen
bd1961b927
Correctly fail if no Image matches filter
2018-08-21 12:46:42 +02:00
Adrien Delorme
b038cd10f5
GCP: Allow to set MinCpuPlatform
2018-08-21 10:09:30 +02:00
Adrien Delorme
e37f126cf1
update gcp google.golang.org/api/compute/v1/
2018-08-21 10:09:01 +02:00
Megan Marsh
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Matthew Hooker
31fcfe4bc2
PoC for filtering logs
2018-08-20 15:20:21 -07:00
Adrien Delorme
6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them"
2018-08-20 10:48:06 +02:00
Tom Carrio
c5fe1e9e34
Updated to @rickard-von-essen's code review suggestions, including:
...
- filter build and error checking in Prepare stage (multiErr created in the original function will be returned to Prepare and appended, so all errors show).
- source_image overrides source_image_filter.
- Doc edit
2018-08-19 18:47:07 -04:00
Tom Carrio
5ca5c037eb
Updated filter parser to log all invalid values/fields provided by user
2018-08-19 18:45:22 -04:00
Tom Carrio
fc19cd8d28
Updated limit logic, removed limiter, updated test cases and sort field used
2018-08-19 18:45:22 -04:00
Tom Carrio
4147062802
Internally handling most_recent logic.
2018-08-19 18:45:22 -04:00
Tom Carrio
2d5d1890d4
Switching sort method
2018-08-19 18:45:22 -04:00
Tom Carrio
8d98237a15
I should have a git-status alias to make fmt
2018-08-19 18:45:22 -04:00
Tom Carrio
036918b81b
Updated to comments in PR#6490 - Thanks @haxorof
2018-08-19 18:45:22 -04:00
Tom Carrio
db3d2682b5
Updated allowed filters to tags, visibility, owner, and name. Test cases updated and passed
2018-08-19 18:45:22 -04:00
tcarrio
e9e58e6b2b
Tags field parsed from "tags" and updated test case
2018-08-19 18:45:22 -04:00
Tom Carrio
c8fd53d60b
make fmt
2018-08-19 18:45:22 -04:00
Tom Carrio
de9999ecb9
Updated tag to slice, docs, comments, only active images, source_image_name supercedes filter name
2018-08-19 18:45:22 -04:00
tcarrio
e776ad51a9
Removing statement from old image erroring logic
2018-08-19 18:45:22 -04:00
tcarrio
3a6ab0fc0e
Updated test logic and Error->Errof for formatted output.
2018-08-19 18:45:22 -04:00
tcarrio
6dc71590eb
Updated OpenStack Builder docs and tests
2018-08-19 18:45:22 -04:00
tcarrio
94018c691c
Fixed step interface, added step to builder, passing all tests for new image_query.go
2018-08-19 18:45:22 -04:00
Tom Carrio
a87c8fec38
Fixing up reflection issues on ListOpts builder
2018-08-19 18:39:42 -04:00
Tom Carrio
810a602a1b
Added testing on query helper functions
2018-08-19 18:39:42 -04:00
Tom Carrio
33caed3531
Completed filters and most_recent processing using OpenStack imageservice API
2018-08-19 18:39:42 -04:00
Megan Marsh
00c6ec979f
do 30 minutes not 25
2018-08-17 13:30:02 -07:00
Megan Marsh
00de0f4996
increase the timeout for waiting for an ami to become available
2018-08-17 13:27:19 -07:00
Megan Marsh
5dbd71b857
Merge pull request #6593 from hashicorp/iso_inplace
...
allow to use ISO images in-place v.s. copying them
2018-08-17 10:27:50 -07:00
Andrei Ozerov
6bf442f039
OpenStack builder: fix floating IP docs
...
Update website documentation about "floating_ip_network" parameter.
Add new inline comment about alghoritm that is used for checking
floatingIP-related configuration parameters.
2018-08-17 07:55:31 +03:00
Andrei Ozerov
103403db48
OpenStack builder: do not always use floating IPs
...
Only associate floating IPs if user provided "floating_ip_network" or
"floating_ip".
Remove FindExternalNetwork helper method because it won't be used.
2018-08-17 00:49:06 +03:00
Andrei Ozerov
5d6ba4301d
OpenStack builder: fix floating_ip_pool validation
...
Only use "floating_ip_pool" if "floating_ip_network" wasn't set.
Update unit test for the OpenStack builder parameters.
2018-08-17 00:15:18 +03:00
Andrei Ozerov
1af899248b
OpenStack builder: allow floating IP network name
...
Add support for the external network reference by it's name apart from
ID.
Include external network id in a log message of
the openstack/step_allocate_ip.
2018-08-16 23:38:41 +03:00
Andrei Ozerov
c9047cbfbe
OpenStack builder: update floating IP params
...
Rename "floating_network" to the "floating_ip_network".
Return old "floating_ip_pool" parameter for backward compatibility with
old configuration files. It's value will be passed to the
"floating_ip_network" parameter.
2018-08-16 22:18:48 +03:00
Andrei Ozerov
0eef9b4292
OpenStack builder: floating IP refactoring
...
Remove usage of the deprecated OpenStack Compute service floating IP
management and add methods to work with the OpenStack Networking
service floating IPs API.
Remove usage of the deprecated OpenStack Compute service floating IP
pools and add methods to work with the OpenStack Networking service
external networks API.
Move reusable logic of working with the OpenStack Networking service API
to a separate methods in the networking.go file.
Pass error messages from the API services to the ui messages in the
allocate IP step.
2018-08-16 22:15:26 +03:00
zhuzhih2017
2eafdb33a2
Merge pull request #6588 from xiaozhu36/master
...
Support describing and checking source image coming from marketplace
2018-08-16 20:58:52 +08:00