da9c94b345
Added some testcases for the various file uri transforms to download_test.go
...
Moved some of the code for normalizing a Windows file uri to a regular path into it's own function NormalizeWindowsURL
2018-01-16 13:36:18 -06:00
281dd1258a
Added proper support for downloading via a Windows UNC path or a relative uri.
...
Added proper support for validating a downloadableURL containing a UNC or relative uri.
Removed the workaround for an earlier Go issue that had remained dormant in common/download.go (issue #5927 ).
When building a .vmx file via the vmware-iso builder, transform the path to the correct os-formatted one (using filepath.FromSlash).
2018-01-16 13:36:17 -06:00
e222d60b5a
update changelog
2018-01-12 15:11:50 -08:00
cea2ab8c6d
move kms/encrypted validation to block devices
2018-01-12 15:10:51 -08:00
0023aa11cf
add kms_key_id to block device docs
2018-01-12 14:48:18 -08:00
e968f9d6cc
spelling/style fixes
2018-01-12 14:26:56 -08:00
cfd24eddbf
Merge pull request #5774 from jwieringa/f-kms-key-id
...
Added KmsKeyID to Amazon Builder DeviceBlock
2018-01-12 14:23:19 -08:00
f6772f06be
builder/amazon: Raise error when ebsvolume kms_key_id is without encrypted = true
2018-01-11 20:27:38 -08:00
2ac59b3c27
builder/amazon: Added KmsKeyID to BlockDevice
...
+ Adds kms_key_id to list of options
+ Tests that configuraiton is set along with encrypted
+ Updates documentation on ebsvolume builder
2018-01-11 20:27:38 -08:00
78ff4d1eed
Updated github.com/aws/aws-sdk-go/service/ec2
...
Upgrades to v1.12.57 for the field KmsKeyID on EbsBlockDevice
introduced in v1.12.35 on November 2017.
2018-01-11 20:27:38 -08:00
6f2669c044
Revert "add note about vix api libraries"
...
This reverts commit c5ec92c88b
2018-01-11 16:48:39 -08:00
c5ec92c88b
add note about vix api libraries
2018-01-11 15:44:49 -08:00
6d6216419c
update changelog
2018-01-11 12:14:34 -08:00
2ce3ca1538
Merge pull request #5773 from hashicorp/fix5705
...
Use SDK's InstanceReady waiter
2018-01-11 12:12:03 -08:00
fb730cf521
Merge pull request #5761 from hashicorp/fix_5713
...
fix nasty edge case where we can't find guest additions on windows if they are on a different drive
2018-01-11 11:48:26 -08:00
bdd186fa2b
add tests for fileexistslocally helper function
2018-01-10 16:44:27 -08:00
3ace5bb91b
simplify FileExistsLocally
2018-01-10 16:11:17 -08:00
f5ea1e8312
Use WaitUntilInstanceReady waiter
2018-01-10 15:57:31 -08:00
55ddbf4765
sloppy copypasta
2018-01-10 10:08:23 -08:00
898dadd53c
re-add this block. I still don't think we need it but I don't want to risk breaking things with this bugfix.
2018-01-10 10:03:36 -08:00
4b8476b3f4
Merge pull request #5781 from diegogoding/fix5779
...
fixes issue 5779
2018-01-10 09:59:37 -08:00
38b1cdd8c4
fixed issue 5779
2018-01-10 08:56:59 -06:00
a04a921c2d
add UNC path to test cases, so I can try to enable it in future
2018-01-09 17:14:32 -08:00
154973241f
add a bunch of windows filepath tests
2018-01-09 16:57:52 -08:00
40f0cc6dfe
I don't think this is needed anymore
2018-01-09 15:53:54 -08:00
2838a2371d
disambiguate url variable from url library
2018-01-09 15:47:18 -08:00
216c44b153
fix FileExistsLocally
2018-01-09 15:47:07 -08:00
60a136b20a
Merge pull request #5776 from hashicorp/hashicorp-middleman-0.3.29
...
Update hashicorp-middleman to 0.3.29
2018-01-09 13:16:01 -08:00
2e8561a28d
update middleman-hashicorp
2018-01-09 11:39:55 -08:00
e4c1805f81
Update hashicorp-middleman to 0.3.29
...
Also includes Nokogiri 1.8.1, to fix https://github.com/hashicorp/packer/network/dependencies#30455077
2018-01-09 13:11:22 -05:00
0d711bf2eb
Merge pull request #5768 from hashicorp/better_download_tests
...
reformat TestDownloadableURL into a table test to allow adding more URLS
2018-01-09 09:59:43 -08:00
dfd5f07145
fix ebs acc test
2018-01-08 12:27:10 -08:00
df790a889d
Merge pull request #5765 from lmayorga1980/master
...
improve documentation when vmware-iso is used on amazon-import post-p…
2018-01-08 09:12:01 -08:00
ccf404ea75
fix typo
2018-01-06 13:13:19 -05:00
37ab70c4ae
Updated CHANGELOG.md
2018-01-06 11:23:41 +01:00
15eccb1aa5
Merge pull request #5758 from GSA/better-user
...
make user retrieval for Ansible provisioner more robust
2018-01-06 11:22:03 +01:00
a3d5d40f78
reformat TestDownloadableURL into a table test to allow adding more URLS
2018-01-05 11:06:26 -08:00
e164621bfe
log line to help prevent confusion when guest_additions_url is set from env variable that is empty
2018-01-05 09:19:38 -08:00
7a4709400b
improve documentation when vmware-iso is used on amazon-import post-processr
2018-01-04 21:49:36 -05:00
ff3cbbf28c
Merge pull request #5757 from arizvisa/virtualbox-guest_additions_url-interpolation
...
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-04 15:39:29 -08:00
89ba76b4aa
update changelog
2018-01-04 14:39:26 -08:00
da93b7cf1f
Merge pull request #5762 from hashicorp/static_cred_error
...
builder/aws: catch static credential errors early.
2018-01-04 14:38:43 -08:00
ea9c6e4f65
Merge pull request #5763 from hashicorp/update_winrmcp
...
update winrmcp to fix #5752
2018-01-04 12:29:36 -08:00
98c2a2d1f7
builder/aws: catch static credential errors early.
...
If we're using static credentials, either both the access key and secret key must be set, or neither of them should be.
2018-01-04 11:50:27 -08:00
7fe1ec03ca
update winrmcp to fix #5752
2018-01-04 11:34:05 -08:00
4f3b470804
add helper function to manage validation of filepaths created using DownloadableURL
2018-01-03 16:53:47 -08:00
54bd057bb9
fix nasty edge case where we can't find guest additions on windows if they are on a different drive
2018-01-03 14:34:11 -08:00
0ae1df2071
clarify that ssh_interface works for winrm
2018-01-03 13:42:53 -08:00
b894c925d1
make user retrieval for Ansible provisioner more robust
...
Previously, the Ansible provisioner would look for the username from the
`USER` environment variable. Unfortunately, this is not always set -
particularly in Docker containers. It's very confusing to understand why
the error is happening.
Switched to using Go's built-in `os/user` package for retrieving the
current username. @rickard-von-essen had done this in 7369841d59844f795e712b72
2018-01-03 02:52:41 -05:00
4fcd542d0c
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-02 21:09:41 -06:00
Ali Rizvi-Santiago
Matthew Hooker
Jason Wieringa
SwampDragons
Diego Goding
Justin Campbell
lmayorga
Rickard von Essen
Aidan Feldman