Megan Marsh
dde7302265
Merge pull request #8689 from hashicorp/fix_8530
...
Add iso file name when targetPath is a directory
2020-02-04 13:43:09 -08:00
Moss
f2c8e8491c
Fix format
2020-02-04 18:22:43 +01:00
Moss
e020da49f3
Add iso file name when targetPath is absolute
2020-02-04 18:06:47 +01:00
Wilken Rivera
561f02cc2f
builder/azure-arm: Update logic for setting subscriptionID ( #8685 )
...
* builder/azure-arm: Update logic for setting subscriptionID
Previously, when using managed identities, the Azure builder would set the SubscriptionID in the Prepare method. But would not update it after getting the updated SubscriptionID from the metadata server. This change updates the Run method to ensure a valid subscriptionID is saved to the statebag before continuing with an image build.
Co-authored-by: Paul Meyer <paul.meyer@outlook.com>
2020-02-04 10:54:58 -05:00
Sylvia Moss
bc11853ecf
Rename method writeSpecField to goFieldToCtyType ( #8687 )
2020-02-04 16:37:25 +01:00
Sylvia Moss
08b0bd1d2c
Fix HCL2 code generation for slices within another slice ( #8669 )
2020-02-03 17:03:28 +01:00
Yu SungDuk
df18187032
builder/ncloud: Migrate ncloud-sdk-go-v1 to ncloud-sdk-go-v2 ( #8678 )
2020-02-03 14:55:01 +01:00
Wilken Rivera
4f78876754
Merge pull request #8675 from hashicorp/fix_5957
...
Fix 5957
2020-01-31 15:24:46 -05:00
Megan Marsh
c6dddb75cf
clarify artifice postprocessor wording to make it clear that it will not clean up old artifacts ( #8676 )
...
fix #5451
2020-01-31 16:45:18 +01:00
Megan Marsh
3b5780f98c
add jq example for basic manifest parsing ( #8677 )
...
fix #5413
2020-01-31 16:43:52 +01:00
Megan Marsh
69fe131571
switch trilean to boolean in docs to prevent confusion ( #8673 )
2020-01-31 16:42:16 +01:00
Megan Marsh
d252a24b82
allow user to set winrm_host override like we do ssh_host override
2020-01-30 15:22:22 -08:00
Megan Marsh
de17afbefc
switch trilean to boolean in docs to prevent confusion
2020-01-30 14:58:04 -08:00
Wilken Rivera
18f14fc368
Merge pull request #8670 from hashicorp/fix_8619
...
builder/azure-arm: Set WinRMPassword on the communicator config
2020-01-30 15:37:11 -05:00
Megan Marsh
431b27be1a
Merge pull request #8671 from hashicorp/pp_sharing_info_doc
...
Add custom-builders sharing info with post-processors doc
2020-01-30 10:42:35 -08:00
Moss
f44eee11b3
Add custom-builders sharing info with post-processors doc
2020-01-30 18:16:55 +01:00
nywilken
654cc4c4d5
builder/azure-arm: Set WinRMPassword on the communicator config
...
Build results before change
```
azure-arm: output will be in this color.
==> azure-arm: Running builder ...
azure-arm:
==> azure-arm: Provisioning with Powershell...
==> azure-arm: Provisioning with powershell script:
/tmp/powershell-provisioner922851060
==> azure-arm: Exception calling "RegisterTaskDefinition" with "7" argument(s): "(38,4):Task:"
==> azure-arm: At C:\Windows\Temp\packer-elevated-shell-5e320d29-bdbd-b619-9e64-0c8a301b9d1d.p
==> azure-arm: s1:60 char:1 ==> azure-arm: + $f.RegisterTaskDefinition($name, $t, 6,
"packer", $password, $logon_type,
==> azure-arm: $null) ...
==> azure-arm: +
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==> azure-arm: ~~~
==> azure-arm: + CategoryInfo : NotSpecified:
(:) [], MethodInvocationException
==> azure-arm: + FullyQualifiedErrorId :
ComMethodTargetInvocation
==> azure-arm:
==> azure-arm: Exception calling "GetTask" with "1"
argument(s): "The system cannot find the
==> azure-arm: file specified. (Exception from HRESULT:
0x80070002)"
==> azure-arm: At
C:\Windows\Temp\packer-elevated-shell-5e320d29-bdbd-b619-9e64-0c8a301b9d1d.p
==> azure-arm: s1:61 char:1
==> azure-arm: + $t = $f.GetTask("\$name")
==> azure-arm: + ~~~~~~~~~~~~~~~~~~~~~~~~~
==> azure-arm: + CategoryInfo : NotSpecified:
(:) [], MethodInvocationException
==> azure-arm: + FullyQualifiedErrorId :
ComMethodTargetInvocation
==> azure-arm:
==> azure-arm: Method invocation failed because
[System.__ComObject] does not contain a
==> azure-arm: method named 'Run'.
==> azure-arm: At
C:\Windows\Temp\packer-elevated-shell-5e320d29-bdbd-b619-9e64-0c8a301b9d1d.p
==> azure-arm: s1:62 char:1
==> azure-arm: + $t.Run($null) | Out-Null
==> azure-arm: + ~~~~~~~~~~~~~~~~~~~~~~~~
==> azure-arm: + CategoryInfo :
InvalidOperation: (Run:String) [], RuntimeExcept
==> azure-arm: ion
==> azure-arm: + FullyQualifiedErrorId : MethodNotFound
==> azure-arm:
Cancelling build after receiving interrupt
==> azure-arm: Removing the created Deployment object:
'pkrdp087bb80ibj'
==> azure-arm: Removing the created Deployment object:
'kvpkrdp087bb80ibj'
==> azure-arm:
==> azure-arm: Cleanup requested, deleting resource group
...
==> azure-arm: Resource group has been deleted.
Build 'azure-arm' errored: Build was cancelled.
Cleanly cancelled builds after being interrupted.
```
Build results after change
```
azure-arm: WinRM connected.
==> azure-arm: <Objs Version="1.1.0.1"
xmlns="http://schemas.microsoft.com/powershell/2004/04 "><Obj S="progress" RefId="0"><TN RefId="0"><T>System.Management.Automation.PSCustomObject</T><T>System.Object</T></TN><MS><I64
N="SourceId">1</I64><PR N="Record"><AV>Preparing modules for first use.</AV><AI>0</AI><Nil /><PI>-1</PI><PC>-1</PC><T>Completed</T><SR>-1</SR><SD> </SD></PR></MS></Obj><Obj S="progress" RefId="1"><TNRef RefId="0" /><MS><I64 N="SourceId">2</I64><PR N="Record"><AV>Preparing modules for first use.</AV><AI>0</AI><Nil /><PI>-1</PI><PC>-1</PC><T>Completed</T><SR>-1</SR><SD> </SD></PR></MS></Obj><Obj S="progress" RefId="2"><TNRef RefId="0" /><MS><I64 N="SourceId">3</I64><PR N="Record"><AV>Preparing modules for first use.</AV><AI>0</AI><Nil /><PI>-1</PI><PC>-1</PC><T>Completed</T><SR>-1</SR><SD> </SD></PR></MS></Obj></Objs>
==> azure-arm: Connected to WinRM!
==> azure-arm: Running local shell script:
/tmp/packer-shell091779215 azure-arm: 022xUtbwAH3DdqIoRCOh9caZi8tOYqcY
==> azure-arm: Provisioning with Powershell...
==> azure-arm: Provisioning with powershell script: /tmp/powershell-provisioner469853889
azure-arm: HELLO NEW USER; automatically generated aws password is: 022xUtbwAH3DdqIoRCOh9caZi8tOYqcY
==> azure-arm: Querying the machine's properties ...
```
2020-01-30 12:07:48 -05:00
Sylvia Moss
dc31bad539
Sharing info with post-processors via artifact ( #8632 )
2020-01-30 11:27:58 +01:00
Megan Marsh
f5c58c8e83
fix rcp --> rpc typo ( #8665 )
2020-01-29 10:49:50 +01:00
Megan Marsh
4b29131d9c
update docs with warning about timestamp drift ( #8666 )
2020-01-29 10:29:35 +01:00
Megan Marsh
51ec376eab
Merge pull request #8663 from hashicorp/td_gofmt_source
...
Format code with `gofmt -s -w`
2020-01-28 16:34:24 -08:00
nywilken
d2a9e6b32e
Format code with `gofmt -s -w`
2020-01-28 16:52:50 -05:00
Megan Marsh
817957fe4f
Merge pull request #8616 from hashicorp/packer-plugin-path
...
add PACKER_PLUGIN_PATH for plugin discovery
2020-01-28 12:09:55 -08:00
Megan Marsh
e57004b2ec
Merge pull request #8662 from hashicorp/return_with_ssh_wait_timeout
...
WIP Add ssh_wait_timeout back for backward compatibility
2020-01-28 12:08:42 -08:00
Megan Marsh
6a07d76416
Merge pull request #8654 from hashicorp/fix_8583
...
Extract http ip discover to a new step
2020-01-28 08:50:48 -08:00
Moss
6ad7f593bf
Undo ssh_wait_timeout backward incompatibility
2020-01-28 17:26:01 +01:00
Megan Marsh
2cf5c8f0ef
Merge pull request #8659 from hashicorp/update_amznchroot_docs
...
Add template engine variables doc for amazon-chroot
2020-01-28 08:25:43 -08:00
Moss
7194e92930
Add template engine variables doc for amazon-chroot
2020-01-28 14:58:05 +01:00
Paschalis Tsilias
beca6de71b
Add packer.ExpandUser() function to support tilde in usage of config.ValidationKeyPath ( #8657 )
2020-01-28 14:33:42 +01:00
Moss
61bee60ecf
Add StepHttpIpDiscover tests
2020-01-28 10:31:17 +01:00
Chris Lundquist
56206aa3ae
Merge pull request #8636 from hashicorp/clundquist/fix-lxd-dir-upload
...
fixes and closes #8547
2020-01-27 19:22:49 -08:00
Megan Marsh
6eda9504c9
remove second dir
2020-01-27 16:20:59 -08:00
Megan Marsh
69e7d39fd3
add some tests for packer_plugin_path
2020-01-27 16:19:03 -08:00
Megan Marsh
25a61d977d
update changelog
2020-01-27 12:00:36 -08:00
Sylvia Moss
328eb8ee96
Interpolate boot_command when defined by user variable ( #8640 )
2020-01-27 19:10:16 +01:00
Moss
df38d11270
Fix compilation error
2020-01-27 17:15:13 +01:00
Moss
0566f1f999
Extract http ip discover to a new step
2020-01-27 17:06:56 +01:00
chrisL
63cba2dc00
google compute builder documentation example code cleanup ( #8551 )
2020-01-27 15:53:17 +01:00
Wilken Rivera
eab8f43151
Merge pull request #8649 from hashicorp/fix_8647
...
add note about error abort to vmware warning
2020-01-24 17:17:06 -05:00
Megan Marsh
8c8de27509
add note about error abort to vmware warning
2020-01-24 09:02:30 -08:00
Wilken Rivera
ecf11816c5
Merge pull request #8639 from hashicorp/fix_8627
...
provisioner/shell: Fix envVarFile clean up issue
2020-01-23 16:23:12 -05:00
nywilken
b80882f3b8
provisioner/shell: Fix envVarFile clean up issue
...
This change ensures the deletion of the external envVarFile (use_env_var_file = true) occurs after all script files have been executed and deleted.
Build results before change
```
> packer build build.pkr.hcl [~0]
docker: output will be in this color.
==> docker: Creating a temporary directory for sharing data...
==> docker: Pulling Docker image: ubuntu:bionic
docker: bionic: Pulling from library/ubuntu
docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110
docker: Status: Image is up to date for ubuntu:bionic
docker: docker.io/library/ubuntu:bionic
==> docker: Starting docker container...
docker: Run command: docker run -v /home/wilken/.packer.d/tmp476880774:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic
docker: Container ID: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b
==> docker: Using docker communicator to connect: 172.17.0.2
==> docker: Provisioning with shell script: sample.sh
docker: Sample Script
docker: wilken is NotForSale!
==> docker: Provisioning with shell script: foobar.sh
==> docker: /bin/sh: 1: .: Can't open /tmp/varfile_2555.sh
==> docker: Provisioning step had errors: Running the cleanup provisioner, if present...
==> docker: Killing the container: 812069b4d70746a6d4592a8f75c06867c6774b8b0bd81ade76eae7926a30f64b
Build 'docker' errored: Script exited with non-zero exit status: 2.Allowed exit codes are: [0]
==> Some builds didn't complete successfully and had errors:
--> docker: Script exited with non-zero exit status: 2.Allowed exit codes are: [0]
==> Builds finished but no artifacts were created.
```
Build results after change
```
> packer build build.pkr.hcl
docker: output will be in this color.
==> docker: Creating a temporary directory for sharing data...
==> docker: Pulling Docker image: ubuntu:bionic
docker: bionic: Pulling from library/ubuntu
docker: Digest: sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110
docker: Status: Image is up to date for ubuntu:bionic
docker: docker.io/library/ubuntu:bionic
==> docker: Starting docker container...
docker: Run command: docker run -v /home/wilken/.packer.d/tmp819845000:/packer-files -d -i -t --entrypoint=/bin/sh -- ubuntu:bionic
docker: Container ID: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5
==> docker: Using docker communicator to connect: 172.17.0.2
==> docker: Provisioning with shell script: sample.sh
docker: Sample Script
docker: wilken is NotForSale!
==> docker: Provisioning with shell script: foobar.sh
docker: FooBar Script
docker: wilken is NotForSale!
==> docker: Committing the container
docker: Image ID: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3
==> docker: Killing the container: d8ed9100ff5017379bfc0d80703b2b2d10c4104941663aa5ddbbf18f6dcf74a5
Build 'docker' finished.
==> Builds finished. The artifacts of successful builds are:
--> docker: Imported Docker image: sha256:a412e43f134431f2049a7d06d5d691aad3717d91dd2ee5e2575e05b89384a4b3
```
2020-01-23 14:59:36 -05:00
Megan Marsh
b0b10f6939
Merge pull request #8496 from ryanhartje/delete_arm_deployment_on_cleanup
...
attempting to resolve deployment quota issue due to non-cleanup
2020-01-23 09:48:20 -08:00
Zian Ke
dd5893ec23
Fix grammatical error ( #8643 )
2020-01-23 10:03:39 +01:00
Ryan Hartje
c4a9715e50
updated the deleteTemplate invocation to a defer at the start of cleanup
2020-01-22 16:58:26 -06:00
Wilken Rivera
111bab86d9
Merge pull request #8622 from datalot/pre-validate-with-filters
...
Allow aws builder pre validation to pass when subnet filters are present
2020-01-22 15:00:44 -05:00
Megan Marsh
6046818897
Merge pull request #8638 from hashicorp/hashibot.hcl
...
Create .hashibot.hcl
2020-01-22 10:43:52 -08:00
Adrien Delorme
93f421ce89
Update .hashibot.hcl
2020-01-22 17:15:34 +01:00
Adrien Delorme
266a8ccffc
Create .hashibot.hcl
2020-01-22 17:13:15 +01:00
Chris Lundquist
15cbe4769c
fixes and closes #8547
2020-01-21 19:49:49 -08:00