8f3a115c5a
Merge pull request #10173 from hashicorp/azr-fix-hcl2-gcp-image_encryption_key
...
Fix GCP HCL image_encryption_key fields and use the same casing in JSON and HCL2
2020-10-27 10:56:26 -07:00
dc38fadeeb
Merge pull request #10155 from hashicorp/logging_for_10042
...
builder/vsphere: Don't try to delete a cd file from the remote datastore if the upload of the cd failed
2020-10-27 10:54:07 -07:00
8adbba6904
switch to guard clause format
2020-10-27 10:37:03 -07:00
ef32147a4a
Fix GCP HCL image_encryption_key fields and use the same casing in JSON and HCL2
...
this closes #9997
2020-10-27 15:46:45 +01:00
c4866504e1
respect the destroy flag in content library config ( #10165 )
...
* respect the destroy flag in content library config
* Make vsphere-clone respect delete_vm state tag; use a common delete func to prevent future drift
2020-10-27 09:07:08 -04:00
bab29060fe
regen hcl after master merge
2020-10-26 15:48:10 +01:00
f5e037e8b4
Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp
2020-10-26 15:47:29 +01:00
73370570f4
Fix Proxmox builder unhandled buildvar type ( #10154 )
...
* Fix Proxmox builder unhandled buildvar type #10139
Co-authored-by: Calle Pettersson <carlpett@users.noreply.github.com>
Co-authored-by: Adrien Delorme <adrien.delorme@icloud.com>
2020-10-26 15:11:09 +01:00
25f4e24772
Merge pull request #10150 from nshalman/nshalman/tag-snapshots
...
amazon/ebssurrogate: apply snapshot tags right when taking snapshot
2020-10-23 15:57:18 -07:00
7646ecf8c6
fix tests
2020-10-23 15:35:37 -07:00
4862b2c0f0
Merge pull request #10163 from hashicorp/fix-azure_arm-manageddisk-deletion-regression
...
builder/azure_arm: Fix build failures due to the deletion of attached managed disks
2020-10-23 15:19:30 -07:00
fc619dc977
Merge pull request #9626 from featheredtoast/add-proxmox-vm-clone
...
builder/proxmox FEATURE: split Proxmox into proxmox-iso and proxmox-clone
2020-10-23 13:36:45 -07:00
56c7a9cda5
rebase
2020-10-23 11:47:20 -07:00
15467aa868
Update builder/vsphere/common/step_shutdown.go
...
Co-authored-by: Sylvia Moss <sylviamoss.m@gmail.com>
2020-10-23 11:41:03 -07:00
185f3d9d48
vsphere clone config not yet using warnings, leaving code commented out
2020-10-23 11:41:03 -07:00
c8ad66f419
update to docs as suggested
2020-10-23 11:41:03 -07:00
c86a48fbc9
syntax change
2020-10-23 11:41:03 -07:00
f86f7c4464
Another instance using `Prepare()` needed an update
2020-10-23 11:41:03 -07:00
09edada93d
moved the warning into Prepare() and updated the invocation
2020-10-23 11:41:03 -07:00
572de129d7
update documentation
2020-10-23 11:41:03 -07:00
1048cdbcc4
check for no communicator and provide messaging to user
2020-10-23 11:41:03 -07:00
2ecf5cc9aa
Communicator is not needed unless shutdown_command is populated
2020-10-23 11:41:03 -07:00
6b39b1eed6
StepShutdown should still occur if Comm.Type is none
2020-10-23 11:41:03 -07:00
65ff092fd4
hashicorp/packer#9924
2020-10-23 11:41:03 -07:00
19bd997f11
add directory existence check
2020-10-23 11:06:25 -07:00
a1d69bfe91
Fix liniting issues
2020-10-23 13:52:05 -04:00
afd33679f5
builder/azure_arm: Fix build failures due to the deletion of attached managed disks
...
Previously (prior to v1.6.2) the Azure ARM builder had two delete functions
one that would run before any of the StepDelete* types, and one on deployment template
cleanup. The refactored coded re-introduces the logic from the previously removed
step in v1.6.1 as the main delete logic for the whole deployment
template. Ensuring that all deployed items are deleted before trying to
remove any managed disks.
This change moves all the deletion logic into the
step_deployment_template#Cleanup function to ensure that dependent steps
are only called once the created deployment items (i.e
StepDelateAdditionalDisks) have been deleted.
Test results before change
```
compute.DisksClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="OperationNotAllowed" Message="Disk pkrdd02e9rzzu5k-1 is attached to VM /subscriptions/1f90521a-24f6-4758-ac3d-88d869fb0bf5/resourceGroups/packer-acceptance-test/providers/Microsoft.Compute/virtualMachines/pkrvm02e9rzzu5k."
--- FAIL: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk (454.00s)
FAIL
FAIL github.com/hashicorp/packer/builder/azure/arm 454.008s
```
Test results after change
```
--- PASS: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk (563.56s)
```
Closes #10070
2020-10-23 13:44:27 -04:00
8f67f939f9
Merge pull request #10158 from Direnol/yandex-add-support-iam-auth
...
Added support for IAM credential in the token field and YC_TOKEN env
2020-10-23 09:39:46 -07:00
75befba67e
add more doc
2020-10-23 18:01:52 +03:00
60595ad522
remove extra log
2020-10-23 14:09:05 +03:00
72fe3bbc26
Update builder/yandex/access_config.go
...
Co-authored-by: GennadySpb <lipenkov@gmail.com>
2020-10-23 14:05:39 +03:00
ae7fc84557
Added support for IAM credential in the token field and YC_TOKEN env
2020-10-23 11:47:28 +03:00
7fac596b37
don't try to delete a cd file if the upload of the cd itself failed
2020-10-22 16:53:40 -07:00
3be53e10af
Merge pull request #10128 from nayyara-samuel/add-state-timeout-linode
...
Add documented `state_timeout` parameters to Linode builder
2020-10-22 15:13:59 -07:00
c4001734d0
Merge pull request #10143 from hashicorp/do_9951
...
builder/vsphere: skip iso download if hashed file is already present on remote datastore
2020-10-22 15:06:04 -07:00
00037d8e69
Merge pull request #10145 from hashicorp/fix_10135
...
commhostport isn't present if communicator is null; protect casting i…
2020-10-22 14:24:23 -07:00
70cb4097e1
review comments, add plugin type for a few missing builders
2020-10-21 16:17:32 -07:00
c0ce8a9414
rework fixer deprecation code so we know what plugins they relate to
2020-10-21 15:28:59 -07:00
f1f834b8fe
commhostport isn't present if communicator is null; protect casting in a check
2020-10-21 14:30:23 -07:00
83a672f2c9
amazon/ebssurrogate: apply snapshot tags right when taking snapshot
2020-10-21 16:17:37 -04:00
796c40f89b
builder/vsphere: skip iso download if hashed file is already present in remote packer_cache
2020-10-21 11:33:43 -07:00
a2ba700ac0
Remove deprecated object ids from configs
2020-10-21 13:56:22 -04:00
522d122858
regen all code
2020-10-21 12:04:10 +02:00
4aea2efd0f
HCL2: fully name SSHTemporaryKeyPair fields so that they don't conflict and can be generated
2020-10-21 11:53:07 +02:00
1621ab59d8
tests/azure/arm: Update test image name ( #10133 )
...
I've run into a few cases where running the full test suite for the ARM
builder would fail because of conflicting image names. This is a
workaround for now the bigger fix is to have the acceptance clean up any
created images.
Results before change
```
the managed image named testBuilderAccManagedDiskWindows-1603151855 already exists in the resource group packer-acceptance-test, use the -force option to automatically delete it.
--- FAIL: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group (0.66s)
```
Results after change
```
PASS
ok github.com/hashicorp/packer/builder/azure/arm 2431.115s
```
2020-10-21 11:12:50 +02:00
799c548c40
Merge pull request #10116 from OblateSpheroid/GH8915
...
Feat (builder/oracle-oci): Allow filtering on base image
2020-10-20 14:41:09 -07:00
9b89439ec2
Rearrange cert add after err check for idiomatic
2020-10-20 22:20:57 +02:00
1082bffddd
Add Azure PFX certificate support
...
Azure typically uses pfx files for service principal authentication.
These are PKCS#12 files so just try and read a cert file as such if we
can't already read it as PEM.
2020-10-20 22:15:38 +02:00
d1e0214bec
avoid panic debugging ssh key
2020-10-20 16:59:46 +02:00
f51b231c17
Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp
2020-10-20 16:39:01 +02:00
536421efaf
debug mode: don't dump the ssh key if its from a file
2020-10-20 12:00:49 +02:00
2f26e6d823
tests (builder/oracle-oci): test base image filter in config
2020-10-19 23:30:46 -04:00
32ebabfcf5
Add documented `state_timeout` parameters to Linode builder
2020-10-19 22:07:22 -04:00
2124d3d6b8
builder/digitalocean: tests added for new features vpc_uuid and connect_with_private_ip
2020-10-19 23:19:11 +03:00
b8e6e2c081
Merge pull request #10085 from 10000coins/f-aws-tenancy
...
builder/amazon: Support for source instance tenancy
2020-10-19 12:49:07 -07:00
ef1b401a22
Merge pull request #10102 from mattr-/update-amazon-builder-for-io2
...
builder/amazon: Add io2 as a supported volume type
2020-10-16 16:32:57 -07:00
ecc8c6a44a
Replace `create_image` with `skip_create_image`, as requested
...
Closes #9965
2020-10-16 15:42:30 -07:00
476eefa26b
Add 'create_image' option to googlecompute
...
When building a CI/CD deployment, during the PR process it's nice to be
able to run the builder, but not create the image the build produces.
Closes #9965
2020-10-16 15:42:17 -07:00
456214eb51
Merge pull request #10056 from marinsalinas/new_client
...
New official Outscale SDK migration.
2020-10-16 15:28:54 -07:00
608307cd1e
Re-allow spot + tenancy. Validate tenancy is set to a usable value
2020-10-16 21:43:22 +00:00
d5d1a8708e
Add tests for Tenancy vs Spot Price
2020-10-16 21:43:22 +00:00
6967e02103
Add support for source instance tenancy to amazon builders
2020-10-16 21:43:22 +00:00
0c34d6ca12
feat (builder/oracle-oci): add regex search on base image name
2020-10-15 15:28:38 -04:00
27128dc62f
feat (builder/oracle-oci): allow filtering on base image
2020-10-15 11:02:16 -04:00
54032d6c11
gen code and docs
2020-10-15 16:51:23 +02:00
f4f731b83c
Refactor google compute's temporary ssh keygen genertion to use the sshkey package
2020-10-15 16:51:11 +02:00
15f97421e2
builder/amazon: Add io2 as a supported volume type
...
io2 volumes are new as of 2020-08-24. This adds support for specifying
them in a packer template and having the iops value specified take
effect.
2020-10-14 09:01:17 -05:00
c7ba5c9a14
Fix line ending issues for test files ( #10096 )
2020-10-14 11:03:43 +02:00
22a49a2f2e
chore: fix test
2020-10-13 16:19:15 -05:00
472b008a94
chore: fix test
2020-10-13 15:16:01 -05:00
4810a3d86f
Merge pull request #10077 from hashicorp/document_3348
...
builder/qemu: docs: users must re-apply packer defaults for drive and device arguments
2020-10-13 11:41:28 -07:00
2578bbbb50
chore: fix test
2020-10-13 12:54:25 -05:00
09f57537bf
chore: fix lint issues on osc builder
2020-10-13 11:02:13 -05:00
a100fe496b
go fmt
2020-10-13 18:57:57 +03:00
56807553fc
chore: fix lint issues on osc builder
2020-10-13 10:45:32 -05:00
49cd4baa0c
VPCUUID and ConnectWithPrivateIP have been added to builder/digitalocean
2020-10-13 18:26:00 +03:00
0f12414126
Merge branch 'master' into add-proxmox-vm-clone
2020-10-12 10:48:15 -07:00
01ed398756
fix up alicloud docs to make it clearer that disk_size and other disk device options are not top level fields. ( #10080 )
2020-10-12 10:28:25 +02:00
2861ad9074
clean up imports
2020-10-11 11:47:02 -07:00
709a173060
fix docs linking issue
2020-10-09 14:01:21 -07:00
b05fd9303e
document that users must re-apply packer defualts for drive and device arguments
2020-10-09 10:39:27 -07:00
774a168957
Merge pull request #10064 from hashicorp/refactor_step_run
...
builder/qemu: (tech-debt) Major refactor of step_run.
2020-10-08 11:54:34 -07:00
3e35630d8d
remove slashes to prevent windows test fails
2020-10-08 11:36:36 -07:00
62a401ef28
Fix 10060 ( #10065 )
...
* fix overeager validation
* fix validation of openstack source images
2020-10-08 10:54:41 +02:00
93531b3ec5
[proxmox] Adds proxmox fixer and fixer test
...
Add fixer for proxmox to proxmox-iso. Updated gofmt.
2020-10-08 00:04:43 -07:00
a140c13943
[proxmox] add proxmox builder alias
...
Adds an alias for `proxmox` that points to proxmox-iso builder for
backwards compatibility
2020-10-07 23:43:12 -07:00
d6aa172edc
remove typo'd option from docs
2020-10-07 16:14:13 -07:00
8e632866b1
typo
2020-10-07 15:22:08 -07:00
b54b778572
major refactor of the step_run. Splits step into two major parts:
...
- generating defaults
- overriding defaults with user args
The default generation has been shuffled around some, in order to
make sure that any changes to a specific arg happen in one place
to make it easier to reason about those args. Related args have
been moved close to one another.
The deviceArgs and driveArgs were overly complex after several
layers of copy/paste modifications. Careful pruning reduced the
layers of logic and repeated code, to help make it easier to reason
about.
2020-10-07 15:09:45 -07:00
d4d78feed2
feat(scaleway): get image by label if not an UUID ( #10061 )
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
2020-10-07 16:04:00 +02:00
a478bf6f37
fix: update scaleway website documentation ( #10058 )
2020-10-07 12:02:08 +02:00
809f38be3a
[azure-chroot] Updating parameter `exlude_from_latest` to `exclude_from_latest` ( #10034 )
2020-10-07 11:08:33 +02:00
cd3bdc9e38
REFACTOR: do not pass comm ref through statebag
2020-10-06 22:45:19 -07:00
fdda18e392
Use Trilean for boolean value, and allow for missing values for defaults
2020-10-06 17:24:45 -07:00
977022fb35
Go format
2020-10-06 16:53:29 -07:00
a26e3e6887
[Proxmox] FIX: tests, add required iso_file to basic iso config tests
2020-10-06 16:04:18 -07:00
61c6085651
final fix to make service account impersonation work with iap tunnels ( #10054 )
2020-10-06 15:34:06 -04:00
7ee9a4b638
Merge pull request #9968 from upodroid/google-impersonation
...
GCP: add service account impersonation
2020-10-06 11:32:03 -07:00
f6d362d392
skip Ctx
2020-10-06 11:54:04 +02:00
25d7e7ce17
fix tests
2020-10-06 11:48:24 +02:00
5b3ff89cb0
proxmox: move iso.storageConfig to common.storageConfig
2020-10-06 11:42:49 +02:00
1260e123aa
proxmox.Config: remove mapstructure:",squash" tag
2020-10-06 11:14:09 +02:00
b2be255057
Merge remote-tracking branch 'origin/master' into pr/featheredtoast/9626-1
2020-10-06 11:11:04 +02:00
deb08409f1
Merge pull request #10040 from OblateSpheroid/GH6844
...
Feat (oracle/oci): allow specifying image compartment
2020-10-05 15:02:23 -07:00
721cbac645
Merge pull request #9996 from hashicorp/fix_9995
...
Make shell-local post-processor return copy of previous artifact
2020-10-05 13:00:51 -07:00
c892f0582b
GH#6844: allow image compartment to be specified
2020-10-02 22:30:52 -04:00
157b5cdc28
Merge pull request #10017 from kostasns/oci_boot_volume
...
Allow to specify boot volume size in OCI builder
2020-10-02 11:04:05 -07:00
b1c74f9df0
Merge branch 'master' of github.com:hashicorp/packer into google-impersonation
2020-10-01 23:19:15 +01:00
f13099edfb
rebase the branch
2020-10-01 20:39:06 +01:00
8c07e21be8
update hcl2spec
2020-10-01 09:06:22 +03:00
18c4f271ac
rename variable; add docs
2020-10-01 09:01:51 +03:00
49e4d83cd7
refactor: remove oapi references in bsusurrogate builder
2020-09-30 10:39:24 -05:00
aa3ec3fd0f
refactor: change chroot builder to new SDK
2020-09-30 10:38:31 -05:00
c0c0f003f9
refactor: fix bsu builder to accept proxy
2020-09-30 10:37:41 -05:00
d813c3647d
refactor: change bsuvolume builder to new SDK
2020-09-30 10:37:09 -05:00
b2047bd938
Put the correct AzureTags type in StateBag ( #10014 )
...
Azure expects the tags format to use a pointer to the string for the map value.
The configuration from the builder is not a pointer so when storing in the state bag for
reference in later execution we convert it when creating the StateBag.
Fixes #10012 and #10013 .
* Use the MapToAzureTags helper and error check in resource group creation
* Added test case for tag values not using a pointer
* test/azure/arm: Add test to verify tags stored in state
* test/azure/arm: Add azure_tags to existing acceptance test for Linux
Test Before Fix
```
--- FAIL: TestBuilderAcc_ManagedDisk_Linux (1.81s)
panic: interface conversion: interface {} is map[string]string, not map[string]*string [recovered]
panic: interface conversion: interface {} is map[string]string, not map[string]*string
FAIL github.com/hashicorp/packer/builder/azure/arm 1.822s
```
Test After Fix
```
2020/09/29 17:23:03 ui: ==> test: Resource group has been deleted.
--- PASS: TestBuilderAcc_ManagedDisk_Linux (517.41s)
PASS
ok github.com/hashicorp/packer/builder/azure/arm 517.426s
```
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-09-30 09:55:46 -04:00
72166febee
allow to specify boot volume size
2020-09-30 13:31:37 +03:00
4c0ac6917e
switch to using aws base config, which means we're using code tested and maitnained by the terraform crowd.
2020-09-29 14:26:38 -07:00
c8874c9382
improve docker_tag cast to avoid failures
2020-09-29 14:41:43 +02:00
bdb1c47532
Pass QemuImgArgs to stepConvertDisk ( #10001 )
2020-09-28 11:43:20 +02:00
aa9c162c60
improve docker_tags artifact state read
2020-09-28 10:52:28 +02:00
e758891878
make shell-local post-processor return copy of previous artifact
2020-09-25 16:53:59 +02:00
b6ff793496
builder/proxmox: add support for io threads ( #9969 )
2020-09-25 14:59:54 +02:00
a2ceb54b1a
Add support for external source image url ( #9992 )
...
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
2020-09-25 14:59:00 +02:00
29d23c13d0
Add additional debugging for OpenStack ( #9972 )
...
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
2020-09-25 13:16:53 +02:00
96e3def294
Add pause_before_ssm config to pause before establishing the Session Manager session ( #9988 )
2020-09-25 10:19:19 +02:00
108455a7dc
Merge pull request #9983 from hashicorp/tools_upload_path
...
allow user to set tools upload path
2020-09-24 10:41:08 -07:00
d66b358100
Merge pull request #9991 from hashicorp/b-amazon-ssm-infinite-loop
...
amazon/ssm_driver: Update log polling logic
2020-09-24 09:55:39 -07:00
8d0058dad6
allow user to set tools source path
2020-09-24 09:51:01 -07:00
2f2b5683a2
amazon/ssm_driver: Update log polling logic
...
This change checks for closed iochans related to the log polling
function and will break out of the loop when both channels are closed.
Which is an indicator that the SSM session has been terminated by some
external process. This fixes an issue where Packer hangs, due to the
infinite loop, when an SSM session is killed outside of Packer.
Related to #9442
2020-09-24 10:19:37 -04:00
654fade0a9
azure arm: make map[string]*string => map[string]string to simplify things ( #9985 )
...
* azure arm: make map[string]*string => map[string]string to simplify things
* go generate ./builder/azure/...
* tests !
fix #9984
2020-09-24 12:19:26 +02:00
e41100290e
Merge pull request #9981 from hashicorp/assume_role
...
Implement assume_role for Packer.
2020-09-23 13:44:45 -07:00
429d431365
Implement assume_role for Packer. This functionality is copied shamelessly
...
from the Terraform AWS provider
2020-09-23 13:18:26 -07:00
9170204a93
Merge pull request #9963 from hashicorp/implement_9868
...
Add floppy_files, cd_files, and iso_paths to vsphere-clone
2020-09-23 11:37:17 -07:00
75d649e051
add step_remove_cdrom tests
2020-09-23 12:09:33 +02:00
2de3f2755a
add step_remove_floppy tests
2020-09-23 12:00:28 +02:00
7cd6ee2b3b
add FindDatastore driver test
2020-09-22 17:42:35 +02:00
b881a59bc8
refactor vcenter simulator setup
2020-09-22 16:48:53 +02:00
7b1af2c4e8
add step_add_floppy unit tests
2020-09-22 16:23:11 +02:00
b46f587450
vsphere-clone use common step_add_cdrom
2020-09-22 11:34:49 +02:00
be56632f7e
fix vendoring
2020-09-20 16:50:03 +01:00
9b121e85f9
fix dodgy pointers
2020-09-20 15:31:45 +01:00
3f6230470b
Merge branch 'master' into google-impersonation
2020-09-20 15:23:04 +01:00
2faacfd5d7
add service account impersonation
2020-09-20 15:18:37 +01:00
4d7e42220b
scaleway: add pre validate step (check image and snapshot names) ( #9840 )
...
* Implement Stringer inteface for multistep.StepAction
* scaleway: add pre validate step (check image and snapshot names)
Before, it was possible to create multiple images with the same name,
leading to a confusing and wasteful situation (same for snapshots).
Now, we perform the same kind of checks done by the AWS EC2 builder,
and refuse to proceed if there is an existing image with the same name
(same for snapshots).
As usual, invoking `packer build -force` will bypass the checks.
Closes #9839 .
2020-09-18 15:37:48 -04:00
77817f80a2
Merge pull request #9956 from hashicorp/do_6734
...
builder/qemu: Add qemu_img_args option to set special cli flags for our calls to qemu-img
2020-09-18 11:24:34 -07:00
b7b43a41f3
review cleanup
2020-09-18 10:56:28 -07:00
778d77e4a2
add floppy and cd to vsphere-clone
2020-09-18 17:09:01 +02:00
d347bbec4c
Retry fleet creating only on invalid IAM instance profile ( #9946 )
2020-09-18 17:05:36 +02:00
eca9b2f30d
aws ebs_surrogate: fix unhonored kms_key_id ( #9959 )
2020-09-18 12:39:07 +02:00
ce2047f30b
vSphere StepAddCDRom tests ( #9955 )
2020-09-18 09:57:01 +02:00
1d218d9e65
add QemuImgArgs option to set specialized flags in qemu-img
...
convert, resize, and create commands. Add tests. Refactor steps to
not require config pulled from statebag.
2020-09-17 15:15:04 -07:00
1052733fca
Skip qemu-img convert if format of output file matches format of input file.
...
This works around an osx bug in qemu-img convert in osx.
2020-09-17 11:21:04 -07:00
83ee4e7d13
miscellaneous qemu cleanup. Fix generator strings; generate code
...
fix diskimage logic
linting
fix tests
2020-09-17 09:57:45 -07:00
3577c4a283
refactor multistep array construction in qemu builder to push majority of conditionals into their steps rather than the multistep constructor code.
2020-09-17 09:57:45 -07:00
9ac76be190
clean up step_run
2020-09-17 09:57:45 -07:00
5b714497e6
qemu: split config and config tests into their own files to match best practices from other builders
2020-09-17 09:57:45 -07:00
6c0c603fbf
stub out test
2020-09-17 09:57:45 -07:00
9737b85bbc
Remove usb_keyboard option ( #9945 )
2020-09-17 10:38:33 +02:00
b4be598148
Fix static check issues SA1019 for googlecompute plugins ( #9950 )
...
This change replaces the deprecated constructors `New` with
`NewService`.
Static check before the change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google
- post-processor/googlecompute-import/post-processor.go:183:18: SA1019:
storage.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- post-processor/googlecompute-import/post-processor.go:219:18: SA1019:
compute.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- post-processor/googlecompute-import/post-processor.go:273:18: SA1019:
storage.New is deprecated: please use NewService instead. To provide a
custom HTTP client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- builder/googlecompute/driver_gce.go:127:18: SA1019: compute.New is
deprecated: please use NewService instead. To provide a custom HTTP
client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
- builder/googlecompute/driver_gce.go:132:25: SA1019: oslogin.New is
deprecated: please use NewService instead. To provide a custom HTTP
client, use option.WithHTTPClient. If you are using
google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey
with NewService instead. (staticcheck)
```
Static check after change
```
[go-1.15.2] [1] wilken@automaton in ~/Development/packer/
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | grep SA1019 | grep google
```
2020-09-17 10:14:41 +02:00
7736ae6c67
Add VMware vnc_over_websocket option ( #9938 )
2020-09-16 11:02:46 +02:00
bdd736b800
Interpolate vagrantfile_template on Vagrant post-processor ( #9923 )
2020-09-16 10:08:44 +02:00
bc69db2433
Merge pull request #9941 from hashicorp/cd_files_vsphere
...
add cd_files to vsphere builder
2020-09-15 11:25:01 -07:00
ef01bb5ba6
generated code
2020-09-14 15:35:38 -07:00
e70e8c8651
add cd_files
2020-09-14 14:59:51 -07:00
5d15f5e2f4
No longer need a 15 second sleep
2020-09-14 13:36:26 -07:00
f28cabb162
Merge pull request #9940 from hashicorp/fix_9936
...
skip slot 7 in disk creation so we don't use reserved slot
2020-09-14 13:36:16 -07:00
b08dd28b85
skip slot 7 in disk creation so we don't use reserved slot
2020-09-14 13:13:59 -07:00
e00f6afff8
Merge pull request #9918 from hashicorp/fix_7408
...
skip compaction when backing file is used, to prevent conversion that…
2020-09-14 13:09:13 -07:00
6d2df7fb55
Merge pull request #9932 from hashicorp/cd_files_on_virtualbox
...
Implement cd_files for virtualbox builders.
2020-09-14 13:08:23 -07:00
3c9969d841
cleanup goimports for linter
2020-09-14 12:49:38 -07:00
eab7672519
regenerate code
2020-09-14 12:16:56 -07:00
e723609ef1
regenerate hcl config
2020-09-14 12:16:56 -07:00
6935f47809
add tests for disk defaulting
2020-09-14 12:16:56 -07:00
eae3fda901
refactor out disk defaulting so it can be used to default the vmx cdrom too
2020-09-14 12:16:56 -07:00
9140985ab0
implement cd_files for qemu builder
2020-09-14 12:16:56 -07:00
f774983d36
implement on hyperv
2020-09-14 12:16:56 -07:00
018a1a5da0
Correct full clone logic
2020-09-14 12:15:07 -07:00
681d0f8467
Correct builder ID
2020-09-14 11:59:47 -07:00
99c3872a48
run go fmt
2020-09-14 11:58:50 -07:00
698bef434f
track whether we've detached disks so we don't duplicate work
2020-09-14 11:00:35 -07:00
a92491d17b
capitalization
2020-09-14 10:40:07 -07:00
c032d463d3
Bootcommand Fix For Proxmox Builder ( #9885 )
2020-09-14 17:17:38 +02:00
caf65781d7
Add vsphere-clone mac_address option ( #9930 )
...
* add vsphere-clone mac_address option
* check on prepare if network is set together with mac_address
2020-09-14 13:18:39 +02:00
3739970b84
Adds ability to specify interfaces for http_directroy and VM for the Proxmox builder ( #9874 )
...
Adds two config options to the Proxmox builder:
```
http_interface
vm_interface
```
Both give the user the ability to specify an interface whos IP will be set as the `.HTTPIP` and VMIP respectively.
This is useful when the VM and or the machine executing Packer has multiple interfaces.
Until now Packer would accept the first non-loopback IP as the `.HTTPIP` and VMIP.
I'm open to suggestions and any kind of feedback.
* Added ability to define the NIC where the HTTPIP is taken from.
* Added VM interface config option
* fmt and documentation
* Moved HTTPInterface into HTTPCommon
* Build Fix
* Documentation Fix
2020-09-14 12:24:01 +02:00
aa5eb770d0
DEV: use proper interfaces for vmCreator
2020-09-11 16:45:16 -07:00
b73825bb72
Implement cd_files for virtualbox builders.
...
Since the work to mount isos was duplicated already across the
step_mount_iso and step_mount_guest_additions, this required a
refactor to prevent further code duplication and make the
ports and devices easier to follow
2020-09-11 16:23:29 -07:00
abdb4bcfbf
refactor: change ssh host to osc ssh host
2020-09-11 12:11:52 -05:00
645e5afa36
refactor: change bsuvolume builder to new SDK
2020-09-11 12:11:24 -05:00
b844b7f1c7
refactor: change bsusurrogate builder to new SDK
2020-09-11 10:38:13 -05:00
007f6cce4c
feat: add wait funtions for snapshot and omi in osc builders
2020-09-11 09:47:08 -05:00
31f08909b4
Add usb_scan_codes option to use USB scancodes instead of VNC for remote builds ( #9895 )
2020-09-11 16:46:33 +02:00
eed047b83b
feat: add proxy support to osc builder
2020-09-11 09:46:04 -05:00
cfece501d0
Implement proxmox-clone
2020-09-09 23:55:35 -07:00
8b9009c571
Merge pull request #9856 from OblateSpheroid/add_vnic_details
...
Feat (builder/oracle-oci): Add VNIC details to launch details
2020-09-09 16:15:48 -07:00
8ffa0d2060
Merge pull request #9842 from jason-azze/patch-1
...
Builders vsphere-iso and vsphere-clone - CPUs is actually for cores, not sockets.
2020-09-09 16:03:45 -07:00
ca650c9602
fix struct comment for generation
2020-09-09 16:01:30 -07:00
0a02bd5b2a
skip compaction when backing file is used, to prevent conversion that would make backing file pointless
2020-09-09 15:26:10 -07:00
9d5dedc3db
tests: add some fields to config_test
2020-09-09 09:25:58 -04:00
f8e31bff12
feat(builder): bump scaleway to new sdk ( #9902 )
2020-09-09 10:27:48 +02:00
0719f906d4
Replace if/else with simple if ( #9913 )
2020-09-09 10:24:17 +02:00
8aaa1bd7a6
Merge pull request #9796 from hashicorp/do_8778
...
create secondary iso containing user's desired files
2020-09-08 15:05:48 -07:00
dd54651125
fix (builder/oracle-oci): add freeform and defined tags to create_vnic_details
2020-09-08 14:40:21 -04:00
b4ff0ea4bc
[builder/qemu] Skip resize step when skip_resize_disk is enable #9860 ( #9896 )
...
* [builder/qemu] Skip resize step when skip_resize_disk is enable #9860
* Update builder/qemu/builder_test.go
Improve the code quality
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
* Update files for unit tests
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-09-08 14:32:08 -04:00
f5dc260cf5
refactor (builder/oracle-oci): pass CreateVnicDetails as struct instead of map
2020-09-08 12:03:18 -04:00
7335695c84
qemu vnc: hardcoded lowerbound leaves negative ports
...
```hcl2
vnc_port_min = 5000
vnc_port_max = 5500
```
Build returns faulty:
```
qemu.one: view the screen of the VM, connect via VNC to vnc://127.0.0.1:5138
(...)
2020/09/06 19:09:52 packer-builder-qemu plugin: Qemu stderr: qemu-system-x86_64: -vnc 127.0.0.1:-762,password: can't convert to a number: -762
```
2020-09-06 21:18:12 +02:00
905869308d
Split proxmox builder into a common part and iso/clone builders
...
Clone builder is still just a stub. Proof-of-concept for #9626
Signed-off-by: Calle Pettersson <calle@cape.nu>
2020-09-04 23:53:09 +02:00
d2dd158fe2
Implement cd_files option. The Addfile code is modified from the floppy_files
...
tooling. Tested on OSX, `Windows, and Linux. Documented command line dependencies.
Added acceptance tests (behind testacc flag, since there are dependencies).
This option is only implemented for the vmware and hyperv iso builders. It will be
implemented for others in later PRs in order to make review easier.
2020-09-04 12:20:19 -07:00
dfe8aa51b0
Merge pull request #9845 from hashicorp/run_and_stream_helper_func
...
move runAndStream into a generalized helper function to enable easy l…
2020-09-04 12:19:37 -07:00
5120ad9d9a
add test file
2020-09-04 11:56:32 -07:00
20d62654ae
move runAndStream into a generalized helper function to enable easy local exectution in other places than just the docker builder
2020-09-04 11:56:32 -07:00
03a0beb683
builder/vmware/common: simplify type assertion switch ( #9893 )
2020-09-04 16:25:19 +02:00
ba74602d63
Allows publishing to a Shared Image Gallery with a different subscription id ( #9875 )
2020-09-03 17:13:32 +02:00
7a7d3ff350
Remove comments about sharing with catsby
2020-09-03 09:14:40 -05:00
d1a61cac33
Add NVMe controller support to vsphere-iso builder ( #9880 )
2020-09-03 11:14:58 +02:00
602729ac23
Fix vsphere-iso acceptance tests ( #9878 ) ( #9881 )
2020-09-03 10:17:49 +02:00
ab23e839c8
update sharing test to req aws account id
2020-09-02 11:44:38 -04:00
903deb9e6a
vSphere StepHardware tests ( #9866 )
2020-09-02 10:19:57 +02:00
e96cc07a1a
Merge pull request #9853 from remyleone/boottype_local
...
change default scaleway boottype to local
2020-09-01 10:44:42 -07:00
24dbd0a28b
Fix iso_path validation regex ( #9855 )
2020-09-01 10:11:48 +02:00
f4556fd3f1
Merge pull request #9831 from hashicorp/remedial_remote_export_config_tests
...
add tests to make sure prepare for export defaults properly
2020-08-31 15:47:05 -04:00
f74a425661
feat (builder/oracle-oci): pass CreateVnicDetails to instance
2020-08-31 13:13:33 -04:00
58a0bdd780
Look for a default resource pool when root resource pool is not found ( #9809 )
2020-08-31 16:26:48 +02:00
03a374f4b6
Fix linting issues for SA6005 check ( #9854 )
...
Before change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
builder/profitbricks/step_create_server.go:254:22: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/oneandone/config.go:97:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
builder/vmware/common/driver_parser.go:1199:7: SA6005: should use strings.EqualFold(a, b) instead of strings.ToLower(a) == strings.ToLower(b) (staticcheck)
```
After change
```
⇶ golangci-lint run --disable-all --no-config --enable=staticcheck | ack SA6005
```
2020-08-31 15:44:42 +02:00
804fefef17
yandex-import: allow set custom API endpoint ( #9850 )
...
* Separate Access Config from yandex builder Config
* make use of Access Config explicit
* Move `MaxRetries` into AccessConfig
* NewDriverYC use AccessConfig instead Config
* yandex-import PP use common Access Config
Now support set custom API Endpoint
* yandex-export PP use common Access Config
Now support set custom API Endpoint too (as yandex-import)
* fix test
* Tiny doc updates.
2020-08-31 15:29:20 +02:00
0ad26cce01
Feat (oracle-oci): allow freeform and defined tags to be added instance ( #9802 )
...
* feat (oracle-oci): allow freeform and defined tags to be added to instance (#6313 )
* docs (oracle-oci): add descriptions for instance_tags and instance_defined_tags (#6313 )
* fix: fmt
* fix: generate hcl2spec
2020-08-31 14:36:09 +02:00
ecd1a49a35
change default scaleway boottype to local
2020-08-31 13:15:37 +02:00
e4f975fae1
Allows for the mounting of ISOs when a Proxmox VM s created. Same as … ( #9653 )
...
Allows the mounting of additional ISOs when the VM is created. The config option was taken from PR #9055 and slightly changed. Users can specify an array of bus names, bus numbers and filenames.
"cd_drive":[
{
"bus": "ide",
"bus_number": 3,
"filename": "isos:iso/virtio-win-0.1.187.iso"
},
{
"bus": "sata",
"bus_number": 3,
"filename": "isos:iso/someother.iso"
}
]
Closes : #7950
Co-authored-by: Calle Pettersson <carlpett@users.noreply.github.com>
2020-08-31 10:48:24 +02:00
942bfbf221
Add driver mocks and write tests to steps Remote Upload and Create VM ( #9833 )
2020-08-31 10:34:41 +02:00
1c5bc41beb
refactor ovftool validation into vmware driver
2020-08-27 10:55:57 -07:00
bbc3a5b0d1
add tests to make sure prepare for export defaults properly
2020-08-27 10:55:57 -07:00
e0badb3fb7
refactor: update step_update_omi_attributes and create_tags to new OSC SDK
2020-08-26 12:25:46 -05:00
a6d5106cd7
Allow "export" to ovf/ova for local vmware builds in addition to esx ones.
...
Refactor step_export and the driver interface to move the ovftool call
into the vmware driver. This refactor allows us to add meaningful tests
to step_export, which I have also added here.
2020-08-26 09:45:12 -07:00
e9b526ee2d
Move step_create_disk into common folder, and add to vmx builder ( #9815 )
...
Pull additional disk related config options into their own file.
2020-08-26 10:13:11 +02:00
8885a5ef31
refactor: update step_create_omi to new OSC SDK
2020-08-25 18:02:11 -05:00
f0dc26613a
Merge pull request #7 from marinsalinas/step_deregister_omi
...
Step Deregister OMI
2020-08-25 17:22:58 -05:00
0d0bd9ce75
name fields of PolicyDocument correctly in HCL ( #9812 )
...
withouth this fix we would have had to do
```hcl
temporary_iam_instance_profile_policy_document {
statement {
action = ["*"]
effect = "Allow"
resource = ["*"]
}
version = "2012-10-17"
}
```
instead of the same document but with capitalised fields
2020-08-25 10:53:56 +02:00
a0c09e85df
retry spot instance creation when an "Invalid IAM Instance Profile name" error pops up ( #9810 )
...
PutRolePolicy & AddRoleToInstanceProfile are eventually consistent but it is not possible to wait for them to be done here: 0785c2f6fc/builder/amazon/common/step_iam_instance_profile.go (L117-L134)
2020-08-25 10:10:32 +02:00
2152fa3313
Accept content library path in iso_paths ( #9801 )
2020-08-24 16:54:30 +02:00
8166dad533
Merge pull request #5 from marinsalinas/step_cleanup_volumes
...
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-21 15:03:47 -05:00
8274d4848c
chore: added forece_deregister in the test case to verify the step_deregister_omi
2020-08-21 13:30:21 -05:00
071854ea4a
chore: implemented OSC API in step_deregister_omi
2020-08-21 13:29:41 -05:00
a13dfe1f42
chore: added GetRegion() and NewOSCClientByRegion functions
2020-08-21 13:29:27 -05:00
60bd61dc18
chore: removed security group filter function, it was moved to step_security_group file
2020-08-21 11:31:00 -05:00
c3a4b60ea5
chore: implemented OSC API in step_security_group
2020-08-21 11:30:10 -05:00
7a45e4c8b0
refactor: change step tag bsu volumes to new OSC SDK
2020-08-21 10:40:14 -05:00
c58d6f9b33
refactor: migrate run vm step to new SDK
2020-08-21 10:10:25 -05:00
6f0bb33c9a
refactor: change tags ssh file to new OSC SDK
2020-08-20 20:35:51 -05:00
e5c14044fb
refactor: change tags file to new OSC SDK
2020-08-20 19:12:38 -05:00
addc3dd6e7
refactor: change step_cleanup_volumes to new OSC SDK
2020-08-20 18:33:02 -05:00
d9a7626249
Merge pull request #4 from marinsalinas/step_public_ip
...
Step public ip
2020-08-20 18:04:03 -05:00
7745369dce
chore: set true associate_public_ip_address attribute to test the step_public_ip
2020-08-20 14:00:13 -05:00
86966ecfee
:chore: implemented OSC API in pre_public_ip step
2020-08-20 13:59:25 -05:00
ada2a431ef
Modularise vCenter rest client ( #9793 )
2020-08-20 17:55:25 +02:00
99800619b7
Add HCL2 examples to the virtualbox builders ( #9788 )
2020-08-20 15:43:38 +02:00
a1524bf96a
Add option to also import OVF templates to the Content Library ( #9755 )
2020-08-19 13:20:25 +02:00
232d5a3ce6
chore: changed oapi to osc
2020-08-18 15:06:00 -05:00
a2cfaace59
extract output dir configuration and defaulting into the step_output_dir, using pointers to make sure they get set properly back on the main config
2020-08-18 12:50:06 -07:00
3b2bedf794
implement a remote_output_directory option, and heavily comment output code
2020-08-18 12:50:00 -07:00
43e9d43ebd
chore: removed API attribute
2020-08-18 13:52:49 -05:00
8b2cdc5821
refactor: change step_network_info to new OSC SDK
2020-08-18 13:33:45 -05:00
8649496c6c
refactor: change new sdk on step_source_omi_info
2020-08-18 13:33:45 -05:00
4431bb87b2
:chore: added api key to specify the API connection
2020-08-18 13:33:45 -05:00
823b957a1f
:chore: implemented OSC connection in pre_validate file
2020-08-18 13:33:45 -05:00
22481d1ac2
:chore: added OSC Connection in builder file
2020-08-18 13:32:38 -05:00
1fbe715c13
:chore: added OSC Connection in builder file
2020-08-18 12:23:39 -05:00
b0d2201d55
Merge pull request #9782 from hashicorp/fix_9151
...
fully destroy vm if it was cancelled or errored
2020-08-18 07:22:18 -07:00
0a5cd953fc
fully destroy vm if it was cancelled or errored
2020-08-17 14:07:58 -07:00
aa2418cf01
add progress tracker to vmware-esx iso upload. Add colored prefix to … ( #9779 )
...
* add progress tracker to vmware-esx iso upload. Add colored prefix to tracker to make it clear which build a tracker belongs to.
* fix mock; fix tests
2020-08-17 14:35:42 -04:00
d74b47b734
Merge pull request #9777 from hashicorp/fix_9756
...
Add aws_polling config option to override env variables
2020-08-17 10:49:38 -07:00
1a0d5a93ee
fix max_attempts typo
2020-08-17 17:58:22 +02:00
788dc32598
add aws_polling config option to override env variables
2020-08-17 17:15:32 +02:00
1bfb2d9170
:chore: implemented transport file to make the OSC API Connection
2020-08-17 10:04:28 -05:00
1055007cba
:chore: added OSC API Client Connection
2020-08-17 10:02:00 -05:00
46a26a3d9e
Fix Hyper-V boot command refs #5291 ( #9765 )
2020-08-17 16:00:43 +02:00
8b4993e44c
fix docs for kms key ids ( #9766 )
2020-08-14 11:35:35 +02:00
74f868da37
:chore: changed the AMI with an existing AMI to work fine with the test case
2020-08-13 17:03:32 -05:00
acba3ea3e7
Document network path ( #9762 )
2020-08-13 11:26:40 -04:00
e97c56dc72
Merge pull request #9559 from hashicorp/fix_9482
...
builder/azure-arm: Remove duplicate resource deletion steps
2020-08-12 12:43:09 -07:00
55812fe8a5
Handle error of deferred deletion
2020-08-12 11:30:15 -04:00
5700f74c8c
Handle lease not present error
2020-08-12 11:27:07 -04:00
d91839b93e
Update deletion logic for OS disks
...
* Add an ResourceNotFound error check
* Add logic to break temporary disk lease before deleting it
2020-08-12 11:03:51 -04:00
ba6d11d518
Remove StepDeleteOSDisk in favor of StepDeployTemplate#Cleanup
2020-08-12 11:03:03 -04:00
54469c4728
Add all of the custom AWS template engines to GeneratedData for use b… ( #9751 )
2020-08-12 10:43:15 +02:00
e475db6a66
check for ip after timeout ( #9748 )
2020-08-12 10:39:12 +02:00
aed97e1a8b
Ensure any active leases are brokend before deleting
2020-08-11 16:41:28 -04:00
920da9d0a4
Fix up code to remove some additional steps
2020-08-11 16:40:51 -04:00
f8bb9008c0
Merge pull request #9697 from backerman/personal/backerman/9695
...
Add FreeBSD support to azure/chroot
2020-08-10 12:47:48 -07:00
7c28d5590c
Remove StepDeleteResourceGroup in favor of StepDeploymentTemplate#Cleanup
2020-08-10 12:57:11 -04:00
80960d7a64
Fix vsphere boot command and check for context cancelation when waiting for ip ( #9739 )
2020-08-10 18:16:19 +02:00
23d5432333
Revert inadvertently-changed import.
2020-08-09 14:31:54 -07:00
109b2a0ca9
Build constraints don't seem to work on test.
2020-08-09 14:12:58 -07:00
94c9b87431
Only run on platforms supported by chroot.
2020-08-09 13:53:21 -07:00
33eb8483ba
Get some tests in here.
2020-08-09 13:39:29 -07:00
8f362656ee
Update builder/amazon/ebs/step_create_ami.go
...
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
2020-08-07 08:02:57 -07:00
484dbfe6ad
improve error handling when waiting for image so that the resourcenotready error is bubbled up more clearly without verbose logging turned on
2020-08-06 14:58:05 -07:00
04d7a10aa0
Merge pull request #9714 from hashicorp/fix_9688
...
provide more helpful error message than the one returned by the clien…
2020-08-06 10:54:21 -07:00
4964c54f60
update docs to state resource id must be fully qualified
2020-08-06 10:41:18 -07:00
25f2ec48d3
add network_name option to vmware builder to make it match the network option on the vsphere builder, so vmware users needn't update vmx data just for the network name ( #9718 )
2020-08-06 13:19:55 +02:00
3f61498704
Merge pull request #9704 from ntoofu/f-vsphere-export-permission
...
Add `directory_permission` config option to `vsphere` builder
2020-08-05 10:57:30 -07:00
Megan Marsh
Adrien Delorme
blz-ea
netapp-jgriffit
James Griffith
Wilken Rivera
Roman Mingazeev
Nahum Shalman
Boran Car
js-g
Nayyara Samuel
Ufuk
Bryan Hundven
Evan Pipho
Matt Rogers
Marin Salinas
Jeff Wong
Patrik
abarbare
Ricardo Rosales
upodroid
Kostas
Braunson
sylviamoss
Lik
Roman Tomjak
Niels Pardon
Niels Pardon
Adrien Delorme
Marco Molteni
Anthony Dong
Andreas Botzner
Richard Turc
Ronald van Zantvoort
Calle Pettersson
Lars Lehtonen
catsby
Troy Lindsay
Rae Krantz
GennadySpb
Rémy Léone
PacoDw
Isaac Buckman
Brad Ackerman