Commit Graph

17155 Commits

Author SHA1 Message Date
Nick Dimiduk 89cf76c2cd HBASE-24658 Update PolicyBasedChaosMonkey to handle uncaught exceptions
Running `ServerKillingChaosMonkey` via `RESTApiClusterManager` for any
duration of time slowly leaks region servers. I see failures on the
RESTApi side go unreported on the ChaosMonkey side. It seems like
`RuntimeException`s are being thrown and lost.

`PolicyBasedChaosMonkey` uses a primitive means of thread management
anyway. Update to use a thread pool, thread groups, and an
uncaughtExceptionHandler.

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-20 17:00:03 -07:00
stack 620470607e Revert "HBASE-24718 : Generic NamedQueue framework for multiple use-cases (Refactor SlowLog responses)"
Causes TestAdminShell and TestThriftHBaseServiceHandler to fail 100% of the time in branch-2.

This reverts commit 8ae3480e70.
2020-07-20 14:50:03 -07:00
Zheng Wang 61e3945990
HBASE-24748 Add hbase.master.balancer.stochastic.moveCost.offpeak to doc as support dynamically change
Closes #2101

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-20 15:23:14 +05:30
Wellington Ramos Chevreuil 8c89582633 HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails with an uncaught exception (#2079)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit bd42c75cac)
2020-07-20 10:29:04 +01:00
Zheng Wang 0a8a7fa2ed
HBASE-24709 Support MoveCostFunction use a lower multiplier in offpeak hours
Closes #2099

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Mingliang Liu <liuml07@apache.org>
2020-07-19 20:11:20 +05:30
Michael Stack 552008c577 HBASE-24698 Turn OFF Canary WebUI as default (#2037)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2020-07-17 15:52:21 -07:00
Elliot be946b0f48 HBASE-24722 Update commands with unintentional return values (#2058)
- Prior to this commit, there were 13 commands that unintentionally return the
  number of lines they print (usually one). This commit ensures that they
  return the value documented by the help text, or nil if there is not a simple
  logical value to return.
- Fixes 6 hbase-shell commands that return String rather than TrueClass or
  FalseClass
- Use double-bang to cast truthy values to TrueClass and FalseClass so that
  ruby's to_s can reliably print true or false without using ternary operators
- Updates tests for is_disabled, is_enabled, disable_rpc_throttle,
  enable_rpc_throttle, disable_exceed_throttle_quota,
  enable_exceed_throttle_quota, clear_deadservers, snapshot_cleanup_switch,
  snapshot_cleanup_enabled, and balancer to check return values
- Adds new tests for balance_switch, balancer_enabled, normalizer_switch,
  normalizer_enabled, catalog_janitor_switch, catalogjanitor_enabled,
  cleaner_chore_switch, cleaner_chore_enabled, splitormerge_switch, and
  splitormerge_enabled

signed-off-by: stack <stack@apache.org>
2020-07-17 11:47:29 -07:00
Mohammad Arshad e08da3bf26
HBASE-24675: On Master restart all servers are assigned to default rsgroup
Closes #2053

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-17 22:46:43 +05:30
Zheng Wang 4001d3f2d2
HBASE-24746 The sort icons overlap the col name in master UI
Closes #2078

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-17 21:51:49 +05:30
Viraj Jasani 8ae3480e70
HBASE-24718 : Generic NamedQueue framework for multiple use-cases (Refactor SlowLog responses)
Closes #2052

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2020-07-17 19:57:05 +05:30
bsglz ec3beaf5a2
HBASE-24664 Some changing of split region by overall region size rather than only one store size (#2054)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2020-07-17 10:47:01 +01:00
bsglz bf368a01bc
HBASE-24382 Flush partial stores of region filtered by seqId when archive wal due to too many wals (#2049)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
2020-07-17 10:40:50 +01:00
Lars 86f00e4749 HBASE-24742 Improve performance of SKIP vs SEEK logic. 2020-07-16 13:10:06 -07:00
Mohammad Arshad ad826a43a2
HBASE-24721: rename_rsgroup overwriting the existing rsgroup
Closes #2066

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-15 18:30:16 +05:30
WenFeiYi 87a60c0889
HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket
Closes #1962

Signed-off-by: David Manning
Signed-off-by: Rushabh
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-15 15:39:02 +05:30
huaxiangsun 0e45e377b8
HBASE-24705 MetaFixer#fixHoles() does not include the case for read replicas (i.e, replica regions are not created) (#2062) (#2068)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-14 22:38:01 -07:00
Viraj Jasani d3ec4886a1
Revert "HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket"
This reverts commit 9ab5282c3e.
2020-07-15 00:20:13 +05:30
WenFeiYi 9ab5282c3e
HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket
Closes #1962

Signed-off-by: David Manning
Signed-off-by: Rushabh
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-15 00:10:43 +05:30
BukrosSzabolcs 7900afdb4f HBASE-24720: Meta replicas not cleaned when disabled (#2057)
- make sure to always clean up excess meta replicas not just when their
number get decreased
- make sure NotServingRegionException is handled properly even when
wrapped
- add test

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
2020-07-14 19:06:01 +02:00
Bo Cui 44d351915a
HBASE-24693 regioninfo#isLast() should point to EMPTY_END_ROW (readability improvement)
Closes #2051

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-14 15:43:17 +05:30
WenFeiYi e1d1304cb1
HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count
Signed-off-by: Reid Chan <reidchan@apache.org>
2020-07-14 10:39:19 +08:00
Geoffrey Jacoby a3567037c6
HBASE-23744 - FastPathBalancedQueueRpcExecutor should enforce queue length of 0
Closes #1094

Signed-off-by: Xu Cang <xucang@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-13 12:19:02 +05:30
Zheng Wang fce1df9a3c
HBASE-24586 Add table level locality in table.jsp
Closes #2048

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-11 17:20:22 +05:30
chenglei deff4c88d3
HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.(#2034)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2020-07-11 16:35:10 +08:00
Joseph295 ff2951e672 HBASE-24663 Add procedure process time statistics UI (#2035)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-07-10 15:05:57 +08:00
niuyulin eee467d119 HBASE-24653 Show snapshot owner on Master WebUI (#2016)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-07-10 15:05:48 +08:00
XinSun 3a33f642bf
HBASE-22738 Fallback to default group to choose RS when there are no RS in current group (#2039)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-07-10 09:59:58 +08:00
XinSun 5fcffae5db
HBASE-24431 RSGroupInfo add configuration map to store something extra (#2031)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-07-08 14:39:41 +08:00
Toshihiro Suzuki f771fd26b4
HBASE-24650 Change the return types of the new checkAndMutate methods introduced in HBASE-8458 (#2033)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-07-08 08:00:48 +09:00
Duo Zhang 28602d6fdb Revert "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)"
This reverts commit f834919929.
2020-07-07 18:16:58 +08:00
WenFeiYi 5416cef27f HBASE-24546 CloneSnapshotProcedure unlimited retry (#1900)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-07-06 13:59:07 +08:00
Baiqiang Zhao 0e74a8c86b
HBASE-24671 Add excludefile and designatedfile options to graceful_stop.sh
Closes #2013

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-05 19:35:27 +05:30
chenglei f834919929 HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-07-04 21:12:07 +08:00
David Manning 25e929bdf0
HBASE-24657 add unit test for JSONBean.java
Closes #2004

Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-02 18:51:13 +05:30
Baiqiang Zhao cb154d50aa
HBASE-24560 Add a new option of designatedfile in RegionMover
Closes #1901

Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-07-01 20:28:35 +05:30
pengmq1 2a12fd283e HBASE-24289 Heterogeneous Storage for Date Tiered Compaction (#1730)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-06-30 15:19:30 +08:00
stack 0dd42f7916 HBASE-24648 Remove the legacy 'forceSplit' related code at region server side (#1990)
Addendum to fix TestHeapSize
2020-06-29 14:19:44 -07:00
Michael Stack 91da188d78
HBASE-24656 [Flakey Tests] branch-2 TestMasterNoCluster.testStopDuringStart (#1998) 2020-06-29 11:10:14 -07:00
Nick Dimiduk 5b8afaeacd HBASE-24144 Update docs from master (addendum)
Bring back documentation from master branch (37b863bd0b), using

```
$ git checkout master -- src/main/asciidoc/
$ git checkout master -- src/site/asciidoc/
```

And then:
 * remove changes from HBASE-23890
   This reverts commit 420e38083f.
 * delete docs re: sync_replication
 * delete docs re: backup
2020-06-29 08:33:30 -07:00
Duo Zhang 3effd28a75 HBASE-24648 Remove the legacy 'forceSplit' related code at region server side (#1990)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-29 23:16:21 +08:00
Duo Zhang ed6104418c HBASE-24646 Set the log level for ScheduledChore to INFO in HBTU (#1987)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
2020-06-28 23:27:42 +08:00
Viraj Jasani 0fe85947ec
HBASE-24588 : Submit task for NormalizationPlan (#1933) (#1983)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
2020-06-28 01:10:42 +05:30
Duo Zhang 7c78356218 HBASE-24635 Split TestMetaWithReplicas (#1980)
Signed-off-by: Guanghao Zhang <zghao@apache.org>
2020-06-27 11:11:36 +08:00
huaxiangsun 2c201cc034
HBASE-24552 Replica region needs to check if primary region directory exists at file system in TransitRegionStateProcedure (#1924) (#1971)
Signed-off-by:  stack <stack@apache.org>
2020-06-26 11:27:30 -07:00
Nick Dimiduk a499eae1aa HBASE-24221 addendum to restore public interface on LoadIncrementalHFiles
Signed-off-by: niuyulin <nyl353@163.com>
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
2020-06-26 09:06:32 -07:00
BukrosSzabolcs 50d1a79255 HBASE-24562: Stabilize master startup with meta replicas enabled (#1903)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Huaxiang Sun <huaxiangsun@apache.com>
(cherry picked from commit 8cdb2cca44)
2020-06-26 16:50:55 +01:00
Bharath Vissapragada a6c887012e
HBASE-24603: Make Zookeeper sync() call synchronous (#1945) (#1975)
Writing a test for this is tricky. There is enough coverage for
functional tests. Only concern is performance, but there is enough
logging for it to detect timed out/badly performing sync calls.

Additionally, this patch decouples the ZK event processing into it's
own thread rather than doing it in the EventThread's context. That
avoids deadlocks and stalls of the event thread.

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 84e246f9b1)
2020-06-25 16:41:11 -07:00
Michael Stack e6639f9d4e
HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a TableDescriptor (#1955)
Purge query Master for table descriptors; make do w/ generic options.

Logging cleanup.

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java
 Undo fetching Table Descriptor. Not reliably available at recovery time.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-06-25 11:45:06 -07:00
Nick Dimiduk 3db4f00f24 HBASE-22504 Addendum: restore findCommonPrefix
Address incompatibility issue raised in 2.3.0RC0 vote thread.
2020-06-25 11:17:22 -07:00
Nick Dimiduk eb16b4a782 HBASE-24631 Loosen Dockerfile pinned package versions of the "debian-revision" (#1965)
After a bit of research into [0] and [1], and a bit of
experimentation, it seems we can use a partial wild-card expression
for these version strings. Let's try this for now. If it works out, we
should expand this usage to all the version package numbers, pinning
them to their epic:upstream-version components.

[0]: http://manpages.ubuntu.com/manpages/xenial/en/man5/deb-version.5.html
[1]: http://manpages.ubuntu.com/manpages/xenial/man8/apt-get.8.html

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
2020-06-25 22:26:06 +08:00