2013-05-23 14:47:00 -04:00
|
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
2013-05-13 19:53:14 -04:00
|
|
|
<!--
|
|
|
|
|
2013-05-16 15:59:40 -04:00
|
|
|
Licensed to the Apache Software Foundation (ASF) under one or more
|
|
|
|
contributor license agreements. See the NOTICE file distributed with
|
|
|
|
this work for additional information regarding copyright ownership.
|
|
|
|
The ASF licenses this file to You under the Apache License, Version 2.0
|
|
|
|
(the "License"); you may not use this file except in compliance with
|
|
|
|
the License. You may obtain a copy of the License at
|
2013-05-13 19:53:14 -04:00
|
|
|
|
2013-05-16 15:59:40 -04:00
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
2013-05-13 19:53:14 -04:00
|
|
|
|
2013-05-16 15:59:40 -04:00
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
limitations under the License.
|
2013-05-13 19:53:14 -04:00
|
|
|
|
|
|
|
-->
|
2012-10-26 12:34:48 -04:00
|
|
|
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
|
|
|
|
|
|
|
|
<module name="Checker">
|
|
|
|
<property name="severity" value="warning"/>
|
2014-09-15 18:11:40 -04:00
|
|
|
<module name="NewlineAtEndOfFile">
|
|
|
|
<property name="lineSeparator" value="lf"/>
|
|
|
|
</module>
|
|
|
|
<module name="TreeWalker">
|
2012-11-13 23:24:55 -05:00
|
|
|
<module name="AvoidStarImport"/>
|
2012-11-01 21:57:37 -04:00
|
|
|
<module name="EmptyStatement"/>
|
2014-08-26 20:51:29 -04:00
|
|
|
<module name="IllegalInstantiation">
|
|
|
|
<property name="classes" value="java.lang.Boolean,java.lang.Short,java.lang.Integer,java.lang.Long"/>
|
|
|
|
</module>
|
2014-09-06 14:20:56 -04:00
|
|
|
<module name="InterfaceIsType"/>
|
2012-11-10 16:05:45 -05:00
|
|
|
<!--
|
|
|
|
jclouds prefers 120 character line lengths but has many files with
|
|
|
|
longer lines
|
2012-10-26 12:34:48 -04:00
|
|
|
<module name="LineLength">
|
|
|
|
<property name="ignorePattern" value="^import\s.*;$"/>
|
|
|
|
<property name="max" value="120"/>
|
|
|
|
</module>
|
2012-11-10 16:05:45 -05:00
|
|
|
-->
|
2014-08-31 16:34:46 -04:00
|
|
|
<module name="MissingOverride"/>
|
2012-11-01 22:49:46 -04:00
|
|
|
<module name="ModifierOrder"/>
|
2012-11-01 23:11:23 -04:00
|
|
|
<module name="MultipleVariableDeclarations"/>
|
2014-08-26 14:16:24 -04:00
|
|
|
<module name="NoWhitespaceAfter">
|
|
|
|
<!-- ARRAY_INIT disabled -->
|
|
|
|
<property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"/>
|
|
|
|
</module>
|
|
|
|
<module name="NoWhitespaceBefore"/>
|
2013-12-12 21:22:46 -05:00
|
|
|
<module name="RedundantImport"/>
|
2019-05-07 05:49:54 -04:00
|
|
|
<!-- <module name="RedundantModifier"/> -->
|
2012-11-04 21:11:12 -05:00
|
|
|
<module name="SimplifyBooleanExpression"/>
|
2014-08-26 14:29:25 -04:00
|
|
|
<module name="TypeName"/>
|
2012-11-04 19:36:01 -05:00
|
|
|
<module name="UnnecessaryParentheses"/>
|
2014-07-18 19:53:16 -04:00
|
|
|
<module name="UnusedImports">
|
|
|
|
<property name="processJavadoc" value="true"/>
|
|
|
|
</module>
|
2015-06-10 07:11:35 -04:00
|
|
|
<module name="IllegalImport">
|
|
|
|
<!-- Avoid importing AutoValue shaded packages such as Guava -->
|
Replace embedded and repackaged GSON library
Replace substituted GSON package names with those provided from the vendor.
Reduce OSGi-metadata declaration of core-module because the artificial package org.jclouds.json.gson.internal was removed.
Remove the Gson module its children Gson bundle, and Gson shaded.
Remove duplication conflict and check-style rules due to the removal of the internal Gson module.
Add maven repository where a custom version of the Gson library gets hosted, which exports all packages.
Remove particular repository
Remove the declaration of the repository that serves a custom build GSON version. The build uses GSON in its original form of the vendor, which gets distributed through the standard distribution channel. The identifiers for group, artifact, and version correspond to the latest stable release of GSON.
Integrate GSON library in Clouds Core Bundle
The change contained in the commit puts the GSON library into the classpath of the JClouds core module.
After several tests with Karaf and Karaf JClouds, especially if the Maven identifier matches the original GSON library, there are only a limited number of ways to keep the deployment effort low.
Specifically, Karaf has a set of predefined Maven repositories that can be easily customized. The order in which a particular repository is resolved into the customized GSON library is more difficult. In normal OSGi applications, which do not have such a management function, I imagine this configuration to be more complicated. Sure, a unique identifier would help, but then we are back to step 1.
Although I honestly don't like to see this kind of approach in a codebase I'm working with, there are not many alternatives to the main aspect of deployment mentioned above.
Maybe the approach can still ease the problem in the short term. In a further mid-term step, however, this problem must be addressed in general.
2020-06-25 09:27:15 -04:00
|
|
|
<property name="illegalPkgs" value="sun,autovalue,org.testng.internal"/>
|
2015-06-10 07:11:35 -04:00
|
|
|
</module>
|
2014-05-07 13:32:32 -04:00
|
|
|
<module name="WhitespaceAfter">
|
2014-08-26 13:55:19 -04:00
|
|
|
<!-- TYPECAST disabled -->
|
|
|
|
<property name="tokens" value="COMMA, SEMI"/>
|
2014-05-07 13:32:32 -04:00
|
|
|
</module>
|
2014-05-08 16:30:23 -04:00
|
|
|
<module name="WhitespaceAround">
|
2014-10-03 03:20:39 -04:00
|
|
|
<property name="ignoreEnhancedForColon" value="false" />
|
|
|
|
<!-- TODO: enable LCURLY, RCURLY, SLIST -->
|
|
|
|
<property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, SL, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_EXTENSION_AND" />
|
2014-05-08 16:30:23 -04:00
|
|
|
</module>
|
2012-10-26 12:34:48 -04:00
|
|
|
</module>
|
2014-05-12 16:30:56 -04:00
|
|
|
<module name="Header">
|
2014-08-18 17:24:11 -04:00
|
|
|
<property name="header" value="/*\n
|
|
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more\n
|
|
|
|
* contributor license agreements. See the NOTICE file distributed with\n
|
|
|
|
* this work for additional information regarding copyright ownership.\n
|
|
|
|
* The ASF licenses this file to You under the Apache License, Version 2.0\n
|
|
|
|
* (the "License"); you may not use this file except in compliance with\n
|
|
|
|
* the License. You may obtain a copy of the License at\n
|
|
|
|
*\n
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0\n
|
|
|
|
*\n
|
|
|
|
* Unless required by applicable law or agreed to in writing, software\n
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,\n
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n
|
|
|
|
* See the License for the specific language governing permissions and\n
|
|
|
|
* limitations under the License.\n
|
|
|
|
*/\n"/>
|
2014-05-12 16:30:56 -04:00
|
|
|
<property name="fileExtensions" value="java"/>
|
|
|
|
</module>
|
2014-06-06 22:50:15 -04:00
|
|
|
<module name="RegexpMultiline">
|
|
|
|
<property name="format" value="@author"/>
|
|
|
|
<property name="message" value="Do not use Javadoc @author annotation"/>
|
|
|
|
</module>
|
2015-03-31 16:44:51 -04:00
|
|
|
<module name="RegexpMultiline">
|
|
|
|
<property name="format" value="\r\n"/>
|
|
|
|
<property name="message" value="Do not use Windows line endings"/>
|
2015-04-07 18:56:03 -04:00
|
|
|
<property name="fileExtensions" value="java,xml,json"/>
|
2015-03-31 16:44:51 -04:00
|
|
|
</module>
|
2012-10-26 12:34:48 -04:00
|
|
|
</module>
|