Andrew Gaul
1f9c4cc2a7
Move modernizer from validate to verify phase
...
Validate runs before the compile phase and modernizer requires the
compiled class files so running after the compile phase makes more
sense.
2014-09-22 22:02:59 -07:00
Andrew Gaul
2d70087bfa
Add modernizer-maven-plugin to build
...
This plugin finds uses of legacy APIs:
https://github.com/andrewgaul/modernizer-maven-plugin
2014-09-22 21:57:55 -07:00
Andrew Gaul
b9f54a3301
Enforce that interfaces are types via Checkstyle
2014-09-20 18:48:40 -07:00
Andrew Gaul
200481300d
Convert fake interfaces to utility classes
2014-09-20 18:48:40 -07:00
Andrew Gaul
dc3011469b
Prefer Charsets.UTF_8 over string literal
...
Found with modernizer-maven-plugin.
2014-09-20 18:31:24 -07:00
Jeremy Daggett
2db654fbe3
Removed deprecated methods from the VolumeApi and updated related tests
2014-09-19 16:38:59 -07:00
Andrew Gaul
1223772852
Prefer Charsets.UTF_8 over string literal
...
Found with modernizer-maven-plugin.
2014-09-18 18:11:19 -07:00
jasdeep-hundal
3f2b9376a1
JCLOUDS-514: Support attaching volumes at boot in Nova
2014-09-18 16:32:24 -07:00
Jeremy Daggett
0ac7dfd377
Add assertj-core and assertj-guava dependencies to project pom
2014-09-17 15:06:00 -07:00
Jeremy Daggett
9f0b86ec1a
JCLOUDS-719: Updgrade to Gson 2.3
2014-09-17 08:52:24 -07:00
Jeremy Daggett
d2f181bc55
Remove unnecessary blobstore references
2014-09-16 12:50:25 -07:00
Zack Shoylev
18046cd3c7
Whitespace fix.
2014-09-15 17:11:40 -05:00
Zack Shoylev
816e70ea7b
jclouds has to use git core.autocrlf false (or LF line endings) to pass tests. Without this checkstyle setting, checkstyle fails on windows (looking for CRLF).
2014-09-15 13:41:35 -05:00
Jeremy Daggett
d309e45725
JCLOUDS-686: Remove changesSince() query from base PaginationOptions
2014-09-11 09:27:55 -07:00
Jeremy Daggett
9384575d1e
Fail build on checkstyle warnings
2014-09-10 11:41:30 -07:00
Jeremy Daggett
d6eb54e2b4
JCLOUDS-296: Deprecate Rackspace First-Gen CloudServers
2014-09-09 17:05:42 -07:00
Andrew Gaul
0e3d1475ab
Prefer ByteSource payload
...
Also use randomByteSource for test input.
2014-09-09 15:32:39 -07:00
Jeremy Daggett
a73340abb9
JCLOUDS-296: Deprecate Rackspace First-Gen CloudServers
2014-09-09 14:41:54 -07:00
Andrew Gaul
000a505360
Prefer Files.delete(Path) over File.delete
...
The former throws an exception including the cause if the operation
fails while the latter merely returns a boolean.
2014-09-08 18:41:27 -07:00
Andrew Gaul
fc4b072a26
Ignore non-existent container in deleteContainer
...
All other blobstore providers allow this operation. Further this
matches the behavior of TransientStorageStrategy.deleteContainer.
This commit prevents a spurious error message from
deleteContainerOrWarnIfUnable after test suite completion.
2014-09-08 18:37:19 -07:00
Andrew Gaul
ac22383648
Remove ByteArrayPayload
...
Callers should use ByteSourcePayload instead.
2014-09-07 07:43:14 -07:00
Andrew Gaul
bd5b6853ee
Replace uses of ByteArrayPayload
...
Prefer ByteSourcePayload which offers a superset of its functionality.
Note that ByteArrayPayload implicitly set the contentLength while
users of ByteSourcePayload must do so explicitly.
2014-09-07 07:43:14 -07:00
Andrew Gaul
a4bc36dafa
Add PayloadEnclosing.setPayload(ByteSource)
2014-09-06 22:27:22 -07:00
Andrew Gaul
7869d92b29
Skip test when filesystem does not have xattr
...
Addresses regression from a104944
seen on CloudBees.
2014-09-05 17:53:59 -07:00
Andrew Gaul
e1a5c521c5
Improve XML compatibility with trace-level logging
...
Some providers, notably Azure, include a byte-order mark in their XML
responses. ParseSax.apply buffers these responses in a String when
users enable trace-level logging to include the response in any thrown
exceptions. InputSource(InputStream) skips these byte-order marks
while InputSource(Reader) does not, yielding a SAXParseException.
2014-09-05 17:53:50 -07:00
Andrew Gaul
3c050e0e97
Address Checkstyle violations
2014-09-05 16:38:20 -07:00
Andrew Gaul
975c1325bc
JCLOUDS-706: Upgrade Azure API to 2012-02-12
...
This will allow use of Azure after August 2015:
http://blogs.msdn.com/b/windowsazurestorage/archive/2014/08/05/microsoft-azure-storage-service-version-removal.aspx
2014-09-05 16:35:31 -07:00
Jeremy Daggett
15d8166701
JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package
2014-09-05 08:04:44 -07:00
Andrew Gaul
58438d7d1e
Address Checkstyle violations
2014-09-04 17:24:27 -07:00
Andrew Gaul
a1049449f4
Reset xattr on overwrite in filesystem provider
2014-09-04 17:22:26 -07:00
Andrew Gaul
0b89b1fd10
Ensure that Content-MD5 has 128 bits
...
Update many tests Content-MD5 headers and ETag responses.
2014-09-04 16:57:48 -07:00
Andrew Gaul
8613967820
Remove ByteStreams2.asByteSource
...
This method is dangerous since all ByteSource should provide a new
InputStream on every call to openStream while the method returns the
same InputStream for non-repeatable Payloads.
2014-09-04 16:55:55 -07:00
Andrew Gaul
1b39589092
Ensure that deprecated methods are fully annotated
...
Found with Google error-prone.
2014-09-04 16:54:52 -07:00
Jeremy Daggett
398e8e30a4
Updated api-version and removed upper bounds wildcards for extension APIs
2014-09-04 09:33:58 -07:00
Andrew Gaul
808bef3339
Add missing ec2 mock expectations
...
Regression from 8f8b6dd
.
2014-09-02 17:56:53 -07:00
Andrew Gaul
46daeae1d9
Address masked fields FindBugs warning
2014-09-02 15:24:34 -07:00
Andrew Gaul
8f8b6dd7ce
Further FindBugs fixes
2014-09-02 15:24:33 -07:00
Andrew Gaul
8d9850d8da
Correct Checkstyle violations
2014-08-31 20:04:03 -07:00
Andrew Gaul
34cfdbe266
Enforce Override annotation via Checkstyle
...
Also remove bogus inheritDoc on base and static methods.
2014-08-31 19:37:50 -07:00
Andrew Gaul
fdef97d527
Add suppressions to FindBugs
2014-08-30 14:34:59 -07:00
Andrew Gaul
195998b3b6
Miscellaneous FindBugs fixes
2014-08-30 14:33:10 -07:00
Andrew Gaul
5399cb6877
Avoid unnecessary boxing
...
Found with FindBugs.
2014-08-30 14:30:47 -07:00
Andrew Gaul
63d43f236e
Correct unusual equals implementations
...
Found with FindBugs.
2014-08-30 14:30:44 -07:00
Andrew Gaul
df996f3231
Set Content-MD5 only if ETag has correct format
...
Previously this check was more lenient than it should have been.
2014-08-28 21:50:57 -07:00
Everett Toews
268fb242d5
jclouds Development Tools
2014-08-28 10:19:57 -05:00
Andrew Gaul
550018a68d
Use randomByteSource to generate test data
...
This avoids buffering the entire bolus of data in-memory.
2014-08-27 15:59:36 -07:00
Andrew Gaul
ba9c4b972a
Upgrade to maven-findbugs-plugin 3.0.0
...
Notably this release include support for Java 8. Changelog:
http://findbugs.sourceforge.net/Changes.html
2014-08-26 18:16:18 -07:00
Andrew Gaul
df94527056
Ensure no calls to primitive wrapper constructors
2014-08-26 17:51:29 -07:00
Andrew Gaul
37d65d3d81
Avoid primitive wrapper constructors
2014-08-26 17:51:11 -07:00
Andrew Gaul
92d5091845
Enforce no redundant modifiers via Checkstyle
...
This check also helps find utility classes which should not allow
instantiation.
2014-08-26 17:38:21 -07:00