Andrew Gaul
000a505360
Prefer Files.delete(Path) over File.delete
...
The former throws an exception including the cause if the operation
fails while the latter merely returns a boolean.
2014-09-08 18:41:27 -07:00
Andrew Gaul
fc4b072a26
Ignore non-existent container in deleteContainer
...
All other blobstore providers allow this operation. Further this
matches the behavior of TransientStorageStrategy.deleteContainer.
This commit prevents a spurious error message from
deleteContainerOrWarnIfUnable after test suite completion.
2014-09-08 18:37:19 -07:00
Andrew Gaul
ac22383648
Remove ByteArrayPayload
...
Callers should use ByteSourcePayload instead.
2014-09-07 07:43:14 -07:00
Andrew Gaul
bd5b6853ee
Replace uses of ByteArrayPayload
...
Prefer ByteSourcePayload which offers a superset of its functionality.
Note that ByteArrayPayload implicitly set the contentLength while
users of ByteSourcePayload must do so explicitly.
2014-09-07 07:43:14 -07:00
Andrew Gaul
a4bc36dafa
Add PayloadEnclosing.setPayload(ByteSource)
2014-09-06 22:27:22 -07:00
Andrew Gaul
7869d92b29
Skip test when filesystem does not have xattr
...
Addresses regression from a104944
seen on CloudBees.
2014-09-05 17:53:59 -07:00
Andrew Gaul
e1a5c521c5
Improve XML compatibility with trace-level logging
...
Some providers, notably Azure, include a byte-order mark in their XML
responses. ParseSax.apply buffers these responses in a String when
users enable trace-level logging to include the response in any thrown
exceptions. InputSource(InputStream) skips these byte-order marks
while InputSource(Reader) does not, yielding a SAXParseException.
2014-09-05 17:53:50 -07:00
Andrew Gaul
3c050e0e97
Address Checkstyle violations
2014-09-05 16:38:20 -07:00
Andrew Gaul
975c1325bc
JCLOUDS-706: Upgrade Azure API to 2012-02-12
...
This will allow use of Azure after August 2015:
http://blogs.msdn.com/b/windowsazurestorage/archive/2014/08/05/microsoft-azure-storage-service-version-removal.aspx
2014-09-05 16:35:31 -07:00
Jeremy Daggett
15d8166701
JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package
2014-09-05 08:04:44 -07:00
Andrew Gaul
58438d7d1e
Address Checkstyle violations
2014-09-04 17:24:27 -07:00
Andrew Gaul
a1049449f4
Reset xattr on overwrite in filesystem provider
2014-09-04 17:22:26 -07:00
Andrew Gaul
0b89b1fd10
Ensure that Content-MD5 has 128 bits
...
Update many tests Content-MD5 headers and ETag responses.
2014-09-04 16:57:48 -07:00
Andrew Gaul
8613967820
Remove ByteStreams2.asByteSource
...
This method is dangerous since all ByteSource should provide a new
InputStream on every call to openStream while the method returns the
same InputStream for non-repeatable Payloads.
2014-09-04 16:55:55 -07:00
Andrew Gaul
1b39589092
Ensure that deprecated methods are fully annotated
...
Found with Google error-prone.
2014-09-04 16:54:52 -07:00
Jeremy Daggett
398e8e30a4
Updated api-version and removed upper bounds wildcards for extension APIs
2014-09-04 09:33:58 -07:00
Andrew Gaul
808bef3339
Add missing ec2 mock expectations
...
Regression from 8f8b6dd
.
2014-09-02 17:56:53 -07:00
Andrew Gaul
46daeae1d9
Address masked fields FindBugs warning
2014-09-02 15:24:34 -07:00
Andrew Gaul
8f8b6dd7ce
Further FindBugs fixes
2014-09-02 15:24:33 -07:00
Andrew Gaul
8d9850d8da
Correct Checkstyle violations
2014-08-31 20:04:03 -07:00
Andrew Gaul
34cfdbe266
Enforce Override annotation via Checkstyle
...
Also remove bogus inheritDoc on base and static methods.
2014-08-31 19:37:50 -07:00
Andrew Gaul
fdef97d527
Add suppressions to FindBugs
2014-08-30 14:34:59 -07:00
Andrew Gaul
195998b3b6
Miscellaneous FindBugs fixes
2014-08-30 14:33:10 -07:00
Andrew Gaul
5399cb6877
Avoid unnecessary boxing
...
Found with FindBugs.
2014-08-30 14:30:47 -07:00
Andrew Gaul
63d43f236e
Correct unusual equals implementations
...
Found with FindBugs.
2014-08-30 14:30:44 -07:00
Andrew Gaul
df996f3231
Set Content-MD5 only if ETag has correct format
...
Previously this check was more lenient than it should have been.
2014-08-28 21:50:57 -07:00
Everett Toews
268fb242d5
jclouds Development Tools
2014-08-28 10:19:57 -05:00
Andrew Gaul
550018a68d
Use randomByteSource to generate test data
...
This avoids buffering the entire bolus of data in-memory.
2014-08-27 15:59:36 -07:00
Andrew Gaul
ba9c4b972a
Upgrade to maven-findbugs-plugin 3.0.0
...
Notably this release include support for Java 8. Changelog:
http://findbugs.sourceforge.net/Changes.html
2014-08-26 18:16:18 -07:00
Andrew Gaul
df94527056
Ensure no calls to primitive wrapper constructors
2014-08-26 17:51:29 -07:00
Andrew Gaul
37d65d3d81
Avoid primitive wrapper constructors
2014-08-26 17:51:11 -07:00
Andrew Gaul
92d5091845
Enforce no redundant modifiers via Checkstyle
...
This check also helps find utility classes which should not allow
instantiation.
2014-08-26 17:38:21 -07:00
Andrew Gaul
1b824afbfc
Remove redundant modifiers from interfaces
2014-08-26 17:34:13 -07:00
Ignasi Barrera
b2cb898123
Ignore jEnv files
2014-08-26 23:54:44 +02:00
Andrew Gaul
480f0e883d
Prevent instantiation of utility classes
...
Also prevent extension.
2014-08-26 12:23:36 -07:00
Andrew Gaul
967f55c2e4
Enforce type naming via Checkstyle
2014-08-26 11:29:25 -07:00
Andrew Gaul
bf678edb97
Enforce no leading or trailing spurious whitespace
2014-08-26 11:16:24 -07:00
Andrew Gaul
9c2c2e0c44
Remove spurious whitespace
...
Also remove spurious unary operator plus.
2014-08-26 11:15:55 -07:00
Andrew Gaul
8b16bf0e47
Enforce whitespace after semicolon
2014-08-26 11:06:16 -07:00
Andrew Gaul
74fb8f0183
Add whitespace after semicolons
...
Also correct some bad line-wrapping.
2014-08-26 11:06:00 -07:00
Ignasi Barrera
cd4ce6b192
JCLOUDS-428: Use Maps with a consistent iteration order
2014-08-26 10:32:48 +02:00
Andrew Gaul
614f5194ef
JCLOUDS-653: Upgrade to Guava 18.0
...
Release notes:
https://code.google.com/p/guava-libraries/wiki/Release18
2014-08-25 17:47:23 -07:00
Jeremy Daggett
ddd00a20de
Added assertion for versioned OpenStack extension APIs. Required for the Neutron v2 API.
2014-08-22 20:30:46 -07:00
Andrew Gaul
60e3763999
Throw ContainerNotFoundException from removeBlob
...
This makes removeBlob consistent with all other user-facing methods.
2014-08-21 16:18:12 -07:00
Andrew Gaul
80a4430035
JCLOUDS-679: Use HEAD for S3 bucketExists
...
This method costs 0.4 cents per 10,000 requests instead of 0.5 cents
per 1,000 requests:
http://aws.amazon.com/s3/pricing/
API reference:
http://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketHEAD.html
2014-08-20 12:44:20 -07:00
Jeremy Daggett
e711275fb1
Prefer isEmpty() for collections rather than size()
2014-08-20 11:07:48 -07:00
Chris Custine
192785dbae
Move checkstyle copyright header into checkstyle.xml
2014-08-18 18:55:52 -06:00
John Walker
e5283df995
JCLOUDS-676: Fix reflection warnings / Clojure
...
JCLOUDS-676: Fix reflection warnings / Clojure
Also fixed a typo in a doc string
2014-08-17 12:03:30 -07:00
Jeremy Daggett
82fbdf9695
Updated OSGi fragment bundle-version upper constraint from version 2 to 3
2014-08-17 07:59:44 -07:00
Stuart Hendren
f3778b6cbd
JCLOUDS-661: Adding a test for single-port firewall rules
2014-08-14 12:49:06 -04:00