2103 Commits

Author SHA1 Message Date
Jeremy Daggett
398e8e30a4 Updated api-version and removed upper bounds wildcards for extension APIs 2014-09-04 09:33:58 -07:00
Andrew Gaul
46daeae1d9 Address masked fields FindBugs warning 2014-09-02 15:24:34 -07:00
Andrew Gaul
8f8b6dd7ce Further FindBugs fixes 2014-09-02 15:24:33 -07:00
Andrew Gaul
8d9850d8da Correct Checkstyle violations 2014-08-31 20:04:03 -07:00
Andrew Gaul
34cfdbe266 Enforce Override annotation via Checkstyle
Also remove bogus inheritDoc on base and static methods.
2014-08-31 19:37:50 -07:00
Andrew Gaul
195998b3b6 Miscellaneous FindBugs fixes 2014-08-30 14:33:10 -07:00
Andrew Gaul
5399cb6877 Avoid unnecessary boxing
Found with FindBugs.
2014-08-30 14:30:47 -07:00
Andrew Gaul
63d43f236e Correct unusual equals implementations
Found with FindBugs.
2014-08-30 14:30:44 -07:00
Andrew Gaul
df996f3231 Set Content-MD5 only if ETag has correct format
Previously this check was more lenient than it should have been.
2014-08-28 21:50:57 -07:00
Andrew Gaul
550018a68d Use randomByteSource to generate test data
This avoids buffering the entire bolus of data in-memory.
2014-08-27 15:59:36 -07:00
Andrew Gaul
37d65d3d81 Avoid primitive wrapper constructors 2014-08-26 17:51:11 -07:00
Andrew Gaul
1b824afbfc Remove redundant modifiers from interfaces 2014-08-26 17:34:13 -07:00
Andrew Gaul
480f0e883d Prevent instantiation of utility classes
Also prevent extension.
2014-08-26 12:23:36 -07:00
Andrew Gaul
74fb8f0183 Add whitespace after semicolons
Also correct some bad line-wrapping.
2014-08-26 11:06:00 -07:00
Ignasi Barrera
cd4ce6b192 JCLOUDS-428: Use Maps with a consistent iteration order 2014-08-26 10:32:48 +02:00
Jeremy Daggett
ddd00a20de Added assertion for versioned OpenStack extension APIs. Required for the Neutron v2 API. 2014-08-22 20:30:46 -07:00
Andrew Gaul
80a4430035 JCLOUDS-679: Use HEAD for S3 bucketExists
This method costs 0.4 cents per 10,000 requests instead of 0.5 cents
per 1,000 requests:

http://aws.amazon.com/s3/pricing/

API reference:

http://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketHEAD.html
2014-08-20 12:44:20 -07:00
Jeremy Daggett
e711275fb1 Prefer isEmpty() for collections rather than size() 2014-08-20 11:07:48 -07:00
Jeremy Daggett
7d70362590 Removed @Nullable annotations on region parameters 2014-08-13 15:37:54 -07:00
Jeremy Daggett
744cd5d7eb Prefer Regions to Zones in OpenStack APIs 2014-08-13 09:58:53 -07:00
Andrew Gaul
9009bb5268 JCLOUDS-658: use xattr only on supported systems
Mac OS X HFS+ does not support UserDefinedFileAttributeView:

https://bugs.openjdk.java.net/browse/JDK-8030048
2014-08-12 12:30:06 -07:00
Ignasi Barrera
95b6064c3d JCLOUDS-496: Use the security groups options in the portable TemplateOptions 2014-08-12 13:34:29 -04:00
Andrew Gaul
204a6c7f3b JCLOUDS-658: xattr for filesystem blob metadata
This allows the filesystem blobstore to mimic real blobstores more
accurately.  This also doubles the speed of getBlob by storing the
Content-MD5 header instead of recalculating it.
2014-08-11 12:56:14 -07:00
Andrew Phillips
4ef699a35c Fixing compilation errors caused by Payload no longer being an InputSupplier
See 80a0256c in jclouds
2014-08-11 15:41:34 -04:00
Andrew Gaul
95cfc0d950 JCLOUDS-653: Address Guava 18 deprecations
Mostly renaming Objects.toStringHelper to MoreObjects.toStringHelper.
2014-08-08 11:12:21 -07:00
Jeremy Daggett
23d5290526 OpenStack Cinder general cleanup. Prefer ByteSourcePayload. 2014-08-06 15:20:03 -07:00
Andrew Gaul
59462747e7 Reset StringBuilder instead of creating new ones
This avoids unneeded garbage, especially during XML parsing.  Replaced
with:

find -name \*.java | xargs sed -i 's/^\( *[^ ]*\) = new StringBuilder();$/\1.setLength(0);/'
2014-08-06 11:22:49 -07:00
Andrew Gaul
9e9acf1f3e Address Checkstyle violations 2014-08-05 17:13:29 -07:00
Jeremy Daggett
95a3c7ec2c JCLOUDS-646: Copied Cloud Identity v1.1 classes from openstack-common and fixed incorrect Keystone package names 2014-08-05 09:01:21 -07:00
Andrew Phillips
55e403d222 Updating project version to 2.0.0-SNAPSHOT
Follow-up to 82b23fc
2014-08-05 11:50:02 +02:00
Andrew Phillips
e3d9851216 Up to 2.0.0-SNAPSHOT after the 1.8.0 release 2014-08-05 09:10:24 +02:00
Ignasi Barrera
8cb2cb449b Revert "Move jclouds-chef to the main jclouds repo"
This change will be added again after the 1.8.0 release.

This reverts commit 867c7a407c1db8f56ff3211d70481755cf71440f.
2014-07-29 00:38:46 +02:00
Ignasi Barrera
867c7a407c Move jclouds-chef to the main jclouds repo 2014-07-28 21:08:54 +02:00
Andrew Phillips
eba727fef7 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService
Follow-up to d57bbebe
2014-07-28 12:20:49 -04:00
Luciano P. Sabenca(luciano.sabenca@movile.com)
2e81343297 JCLOUDS-624 - Fixed bug in ListNodes
To fix this bug, I used the approach debated in the above issue: create
new methods to do the operation using an ExecutorService provided by the
user.The the old methods are still working, but now the operations in
those methods are not concurrent anymore.
2014-07-28 15:31:11 +02:00
Shri Javadekar
d57bbebe7e Try iso8601SecondsDateParse if iso8601DateParse fails.
S3 compatible blobStores sometimes return date in the format:
"2014-07-23T20:53:17+0000" instead of the more common
"2014-07-23T18:09:39.944Z". This caused jclouds to barf with an
IllegalArgumentException.

This commit tries to parse both the formats for S3. The exception
is thrown if both fail.

Added unit tests for the same.
2014-07-26 22:19:54 -07:00
Andrew Gaul
9677ed18eb Remove loop to gather metrics
This loop dramatically increases integration test run-time for no
discernible benefit.
2014-07-26 11:08:16 -07:00
Andrew Gaul
1e1eb5a092 Add deleteContainerIfEmpty to BlobStore
This matches how most blobstores operate: delete container is a single
operation, not a compound operation which recursively deletes blobs.
Azure is the only provider which allows deleting a non-empty
container.
2014-07-25 23:02:39 -07:00
Andrew Gaul
5c850947da Correct typo 2014-07-24 23:41:13 -07:00
Andrew Gaul
10262df81c Add symbolic error codes for Atmos 2014-07-24 16:30:42 -07:00
Andrew Gaul
5c8bdcdfbb Remove ByteSources.asByteSource
This method breaks the contract of ByteSource which specifies that
openStream can produce multiple independent streams.
2014-07-24 13:02:13 -07:00
Andrew Gaul
011aed71ed Prefer ByteStreams2 over ByteSources.asByteSource
The latter breaks the contract of ByteSource which specifies that
openStream can produce multiple independent streams.
2014-07-22 16:56:00 -07:00
Andrew Phillips
365ac21f1e Addressing a Checkstyle violation 2014-07-22 13:35:43 -04:00
Andrew Gaul
d1bd551edf Add support for filesystem last modified 2014-07-21 12:25:04 -07:00
Jeremy Daggett
0d77d8c2b1 JCLOUDS-554: Update Nova default API to v2 2014-07-21 10:50:46 -07:00
Andrew Gaul
f17c876d8d Replace const.txt file input with synthetic inputs
This commit replaces file resource-based test inputs with in-memory
equivalents.  This is more consistent and efficient than the previous
approach.  Also resized some test inputs to be partSize + 1 instead of
2 * partSize.  Tested against aws-s3, blobstore, core, cloudfiles-us,
and filesystem.
2014-07-19 18:35:25 -07:00
Andrew Gaul
370194b2be Enable more filesystem integration tests
Other tests will require Java 7 xattr support.
2014-07-19 12:17:23 -07:00
Andrew Gaul
dd3dc9790e Close streams in integration tests
Also remove bogus delete workaround.  Previously unclosed
FileInputStream caused test failures on Windows which cannot delete
open files.  Found with Kohsuke's file-leak-detector.
2014-07-19 05:25:20 -07:00
Aled Sage
1fb286809e JCLOUDS-549: Fix NPE in LoginCredentials.toString
- also deprecates LoginCredentails.get(Password|PrivateKey)
- use getOptionalPassword and getOptionalPrivateKey instead
2014-07-18 14:09:18 +01:00
Andrew Gaul
fb60d76704 JCLOUDS-622: Remove most vestiges of InputSupplier
Guava 16 deprecated InputSupplier and a future release will remove it.
2014-07-16 16:07:59 -07:00