Commit Graph

8482 Commits

Author SHA1 Message Date
Erick Erickson f3de646560 SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort (thread leaks) 2020-07-15 09:23:27 -04:00
Andrzej Bialecki a0488c1cf1 SOLR-14244: Remove ReplicaInfo. 2020-07-14 15:01:23 +02:00
Chris Hostetter e3c2a93edb SOLR-14635: re-enable test with better gatekeeping of expected 'ownership threads' and (nightly only) polling of 'locked/waiting threads' before making asserts 2020-07-13 12:29:04 -07:00
Atri Sharma a73dbdd877
Harden TestBuildingUpMemoryPressure (#1662)
Add better error message checking and finer mocks along with temporary logging which will be removed.
2020-07-13 15:02:59 +05:30
Erick Erickson c346881ad6 SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 2020-07-12 22:41:08 -04:00
S N Munendra 8c9c0640cf
SOLR-11262: XML writer implements writeMap and writeIterator (#1665) 2020-07-13 11:21:14 +10:00
Chris Hostetter c20501a504 SOLR-13132: fix some small package visibility and javadoc glitches that were caught on backport by the java8/branch_8x precommit but slipped past the java11/master precommit 2020-07-09 21:05:13 -07:00
Michael Gibney 40e2122b5a SOLR-13132: JSON Facet perf improvements to support "sweeping" collection of "relatedness()"
This adds a lot of "under the covers" improvements to how JSON Faceting FacetField processors work, to enable
"sweeping" support when the SlotAcc used for sorting support it (currently just "relatedness()")

This is a squash commit of all changes on https://github.com/magibney/lucene-solr/tree/SOLR-13132
Up to and including ca7a8e0b39840d00af9022c048346a7d84bf280d.

Co-authored-by: Chris Hostetter <hossman@apache.org>
Co-authored-by: Michael Gibney <michael@michaelgibney.net>
2020-07-09 18:42:37 -07:00
Chris Hostetter 5a422db60e SOLR-14635: disable test that has silly concurrency assumptions 2020-07-09 18:23:22 -07:00
Chris Hostetter 5c6314a970 SOLR-14635: ThreadDumpHandler has been enhanced to show lock ownership 2020-07-09 12:13:02 -07:00
Mike Drob 2341c220ce
SOLR-11390 Trie* field javadocs to @see *Point (#1612)
Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
2020-07-09 12:20:56 -05:00
Andrzej Bialecki cf742f4596 SOLR-12847: Remove support for maxShardsPerNode. 2020-07-08 17:57:24 +02:00
Jason Gerlowski 80f8ab717c
SOLR-14566: Add request-ID to all distrib-search requests (#1574) 2020-07-08 08:38:23 -04:00
Mike Drob d3f4b21deb
SOLR-10814 Add short-name feature to RuleBasedAuthz plugin
Additional-Author: Hrishikesh Gadre <hgadre@cloudera.com>
2020-07-07 11:37:50 -05:00
Andrzej Bialecki f19057f5e5 SOLR-14537: Fix inner class visibility, reduce diffs with branch_8x. 2020-07-07 16:46:39 +02:00
Cao Manh Dat a80eb84d56
SOLR-14354: HttpShardHandler send requests in async (#1470) 2020-07-07 09:17:26 +07:00
Ishan Chattopadhyaya 5fc12745ca SOLR-14599: Ref guide updates and some error handling fixes
* Ref guide section for types of plugins (that now includes a cluster level plugins section)
* Ref guide updates for deploying, undeploying, updating cluster level plugins
* Better error handling for cluster level plugin deployments
2020-07-07 07:39:45 +05:30
David Smiley 31e7ad9ee2
SOLR-14628: hl.fragsizeIsMinimum now defaults to true (#1651)
Fragments size like <= Solr 8.4 and addresses a significant performance regression
2020-07-06 09:31:37 -04:00
Chris Hostetter fea6c1b9da SOLR-14595: add AwaitsFix test to TestJsonFacetRefinement demonstrating problem, and work around to randomized testing in TestCloudJSONFacetSKGEquiv 2020-07-05 13:28:08 -07:00
noble 3642aa3d4e SOLR-14404: update was not working 2020-07-05 16:28:35 +10:00
Ishan Chattopadhyaya c3d6a8bf7a SOLR-14021: Deprecate HDFS support 2020-07-04 18:29:45 +05:30
Ishan Chattopadhyaya 35b5eea147 SOLR-14537: Fix gradle precommit failures 2020-07-04 14:31:23 +05:30
Erick Erickson e9568c3473 SOLR-10742: SolrCores.getNamesForCore is quite inefficient and blocks other core operations 2020-07-02 23:56:17 -04:00
Eric Pugh b50dd0c9c7
SOLR-14358 respond to feedback on URLClassifyProcessorFactory (#1632)
* Add an example explaining how to use

* fix up JavaDoc formatting

* Respond to feedback from @janhoy

Co-authored-by: ohtwadi <harinder.hanjan@gmail.com>
2020-07-02 15:16:24 -04:00
Andrzej Bialecki 1b8fb70216 SOLR-14537: Improve performance of ExportWriter. 2020-07-02 17:34:50 +02:00
Ishan Chattopadhyaya 7c593b1940 SOLR-14022: Deprecate CDCR 2020-07-02 16:29:29 +05:30
Atri Sharma 3f9cc227f1
SOLR-14588: Implement Circuit Breakers (#1626)
* SOLR-14588: Implement Circuit Breakers

This commit consists of two parts: add circuit breakers infrastructure and a "real" JVM heap memory based
circuit breaker which monitors incoming search requests and rejects them with SERVICE_TOO_BUSY error
if the defined threshold is breached, thus giving headroom to existing indexing and search requests
to complete.
2020-07-02 12:43:48 +05:30
Atri Sharma ccdfee2cf0 Remove Redundant Import in TestContainerPlugin 2020-07-02 12:24:05 +05:30
noblepaul 2e60e1fbbd SOLR-14404: Unregister was not working for plugins with $path-prefix 2020-07-02 15:44:16 +10:00
Erick Erickson d0864a19c7 SOLR-14523: Enhance gradle logging calls validation: eliminate getMessage() 2020-07-01 22:07:59 -04:00
Erick Erickson 76e1d901cb SOLR-14592: Upgrade Zookeeper to 3.6.1 2020-07-01 19:47:16 -04:00
Tomas Fernandez Lobbe 6eb7bc3b7b
SOLR-14590 : Add support for Lucene's FeatureField in Solr (#1620)
Add a new RankField type that internally creates a FeatureField
Add a new RankQParser that can create queries on the FeatureField
2020-06-30 11:15:36 -07:00
Atri Sharma d1c29ae8a9 SOLR-14609: Fix Unused Imports in TestJsonFacetsWithNestedObjects 2020-06-30 23:09:52 +05:30
Atri Sharma ccbdb77344 Remove Unused Import in BoolQParserPlugin 2020-06-30 22:17:48 +05:30
Mikhail Khludnev f647400e31 SOLR-14539: Introducing {!bool excludeTags=foo,bar} 2020-06-30 18:55:07 +03:00
Noble Paul 20c1fdbf7e
SOLR-14404: use MethodHandles in AnnotatedAPI (#1624) 2020-06-30 22:40:26 +10:00
Jan Høydahl f0764dbb54 SOLR-14561: Fix failing @Nightly test 2020-06-30 14:37:10 +02:00
Ishan Chattopadhyaya adf3361428 SOLR-14599: Package manager support for cluster level plugins
Usage:
        bin/solr package deploy <packagename> -y -cluster
        bin/solr package deploy <packagename>:<new-version> -y -cluster --update
        bin/solr package undeploy <packagename> -y -cluster
2020-06-30 15:50:40 +05:30
Jan Høydahl 49a3f0a11d
SOLR-14561 Followup - validate params for more core operations (#1629)
Add template to solr.in scripts
Also testes Windows paths
Added RefGuide documentation to some params
2020-06-29 13:18:24 +02:00
Jan Høydahl 574e399ce5 SOLR-14588: Fix failing DebugComponentTest by reverting test to pre-patch state 2020-06-29 12:53:42 +02:00
noble d883cd69fc SOLR-14481: use classloader to open resource 2020-06-29 14:03:17 +10:00
noble 584e4d5f3c syncing with branch_8x 2020-06-28 15:22:42 +10:00
Noble Paul 1590ed56bb
SOLR-14404: support for openResource() in PackageResourceLoader & path-prefix for container plugins 2020-06-28 14:49:06 +10:00
Atri Sharma 529faf1241 Revert "SOLR-14588: Implement Circuit Breakers (#1606)"
This reverts commit 7b54902f68.
2020-06-27 23:44:32 +05:30
Atri Sharma 45763b6531 Revert "SOLR-14588: Follow Up Fixes and Documentation (#1615)"
This reverts commit 74ac97e402.
2020-06-27 23:43:58 +05:30
David Smiley 80bc86dd6a
SOLR Revert change in path separator exposed by cat()
Previous change *should* have been purely a refactor but accidentally  changed the path separator this streaming expression exposed to always be '/'.  Apparently this is controversial so the previous behavior is re-instated here (and fixes a failing test on Windows).
2020-06-27 12:13:25 -04:00
Gus Heck 455f2e6c73 SOLR-13286 Quiet down metrics logging, add a marker to allow any handler to be silenced via log4j2.xml 2020-06-26 18:00:52 -04:00
Atri Sharma 74ac97e402
SOLR-14588: Follow Up Fixes and Documentation (#1615)
This commit is a follow up to the original commit and adds more documentation and adds timing information for circuit breaker in query response only if circuit breakers are enabled. This commit also adds a test for ensuring that the query response is correct when timing is enabled and circuit breakers are being used.
2020-06-26 22:20:21 +05:30
Erick Erickson cb6b0318a7 SOLR-14588: fix failing test 2020-06-25 19:29:20 -04:00
Marcus 31de01f0ae
SOLR-14578: Update solrcloud-autoscaling-triggers.adoc and test (#1591)
* Update solrcloud-autoscaling-triggers.adoc
* fix the name of the execute_plan action in docs and test.
2020-06-25 16:50:50 -05:00
Erick Erickson 11538e52a2 SOLR-14541: Ensure classes that implement equals implement hashCode or suppress warnings 2020-06-25 16:35:56 -04:00
Atri Sharma 7b54902f68
SOLR-14588: Implement Circuit Breakers (#1606)
* SOLR-14588: Implement Circuit Breakers

This commit consists of two parts: initial circuit breakers infrastructure and real JVM memory based
circuit breaker which monitors incoming search requests and rejects them with SERVICE_TOO_BUSY error
if the defined threshold is breached, thus giving headroom to existing indexing and search requests
to complete.
2020-06-25 21:06:22 +05:30
Dan Fox 54e6528304 SOLR-13749: XCJF -> Cross-Collection Join
change solrUrlWhitelist -> allowSolrUrls
ref guide: update join parser section to be inline with the unit tests.
2020-06-25 09:26:00 -04:00
noble 73a5016ea7 Use simplified API signatures. @EndPoint annotation can be attached to a method and it's posisble to have just a single parameter for an end point 2020-06-25 16:16:04 +10:00
David Smiley 3000bbd05a
SOLR Move "userfiles" stuff from SolrPaths to CoreContainer. (#1600)
And convert String and File paths to Path API
2020-06-25 00:18:58 -04:00
Noble Paul 57a892f896
SOLR-14404 CoreContainer level custom requesthandlers (#1432)
SOLR-14404 CoreContainer level custom requesthandlers
2020-06-25 13:08:51 +10:00
Mike Drob fa44f822e3
LUCENE-6669 Fix repeated "the the"
Co-Authored-By: Rich Bowen <rbowen@apache.org>
2020-06-24 16:15:51 -05:00
Atri Sharma 6a455866b0
Change JoinQuery class's visibility to package again (#1611) 2020-06-24 22:41:34 +05:30
Atri Sharma 7030bb5e27
SOLR-14591: Move JoinQuery To Its Own File (#1609) 2020-06-24 21:36:46 +05:30
Erick Erickson db986086f5 SOLR-14541: Remove IntelliJ //noinspection comments 2020-06-23 19:36:51 -04:00
Erick Erickson ea1bb9f2e9 SOLR-13268: Clean up any test failures resulting from defaulting to async logging 2020-06-23 15:35:08 -04:00
Ilan Ginzburg 3e42286e9e
SOLR-14546: OverseerTaskProcessor can process messages out of order (#1561)
SOLR-14546: OverseerTaskProcessor can process messages out of order
2020-06-23 16:16:46 +02:00
Tomas Fernandez Lobbe a1be1de67e
SOLR-14554: Let Solr use WAND algorithm when scores are requested (#1566)
Make MaxScoreCollector set minCompetitiveScore
2020-06-22 16:50:54 -07:00
David Smiley aa5b26f6c4
Remove some needless toAbsolutePath calls (#1582) 2020-06-21 16:28:25 -04:00
Erick Erickson 84729edbba SOLR-14574: Fix or suppress warnings in solr/core/src/test (part 2) 2020-06-18 11:12:50 -04:00
Jan Høydahl 936b9d770e
SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated (#1572) 2020-06-18 16:13:52 +02:00
Tomas Fernandez Lobbe cfae052973
SOLR-14577: Return BAD REQUEST when field is missing in terms QP (#1588) 2020-06-17 16:02:48 -07:00
Erick Erickson b01e249c9e SOLR-14574: Fix or suppress warnings in solr/core/src/test (part 1) 2020-06-17 17:51:41 -04:00
Eric Pugh 207efbceeb
SOLR-14572 document missing SearchComponents (#1581)
* Add an example explaining how to use

* fix up JavaDoc formatting

* add missing SearchComponents that ship with Solr, and point to external site with components.

* fix path

* simplify page layout by consolidating to lists

* add missing components that are documented elsewhere in refguide

* try to get pathing to pass precommit

* remove mention of solr.cool, in favour of a seperate PR that handles it differently
2020-06-17 11:01:49 -04:00
Erick Erickson 6357b3bdaa SOLR-14573: Fix or suppress warnings in solrj/src/test 2020-06-16 13:27:53 -04:00
Jason Gerlowski a7792b129b
SOLR-14558: Record all log lines in SolrLogPostTool (#1570) 2020-06-16 08:21:24 -04:00
Nazerke Seidan 2da71c2a40
SOLR-14384: SolrRequestInfo now stacks internally.
* "set" now MUST pair with a "clear"
* fixes SolrIndexSearcher.warm which should have re-instated previous SRI
* cleans up some SRI set/clear users

Closes #1527
2020-06-16 01:46:50 -04:00
Gus Heck b8ff4c7636 Refactor for code clarity, add some comments. 2020-06-13 12:17:48 -04:00
Erick Erickson a41aa20b0a SOLR-14564: Fix or suppress remaining warnings in solr/core 2020-06-13 11:00:58 -04:00
Michael Sokolov 26075fc1dc
LUCENE-9394: fix and suppress warnings (#1563)
* LUCENE-9394: fix and suppress warnings in lucene/*
* Change type of ValuesSource context from raw Map to Map<Object, Object>
2020-06-12 07:25:31 -04:00
Erick Erickson ff391448d1 SOLR-14559: Fix or suppress warnings in solr/core/src/java/org/apache/solr/util, response, cloud, security, schema, api 2020-06-11 18:01:29 -04:00
Mike Drob fb98f30a61
SOLR-8392 type safety on SolrParam (#1556) 2020-06-11 14:21:54 -05:00
Tomas Fernandez Lobbe 9728f4ef20
SOLR-14552: Add BMW support to ReRank queries (#1559) 2020-06-10 14:59:50 -07:00
Munendra S N 53040984f6 SOLR-14345: return correct err msg when non-binary resp parser is used
* This adds support to parse error properly in case of non-binary
  resp parser but the problem still exists for noopResponseParser
2020-06-10 19:11:52 +05:30
Munendra S N 001c4e2ddd SOLR-14550: fix duplicate issue in Atomic updates with add-distinct
* When add-distinct value is list, it can end up adding duplicate
  entries
2020-06-10 18:59:44 +05:30
Mike Drob 8ee6e6797b
SOLR-14548 Address warning: static member should be qualified by type… (#1555) 2020-06-09 15:33:37 -05:00
murblanc 1ab9b811c6
SOLR-12823: remove /clusterstate.json (#1528)
* SOLR-12823: remove /clusterstate.json

Remove all code dealing with Zookeeper's /clusterstate.json, remove Collection API's MIGRATESTATEVERSION, remove legacyCloud option.

Also fixes SOLR-11877 DocCollection.getStateFormat is buggy

Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-06-09 13:59:17 -05:00
Erick Erickson 4dcdd750f2 SOLR-14545: Fix or suppress warnings in apache/solr/update 2020-06-08 19:03:34 -04:00
Andrzej Bialecki 30924f23d6 SOLR-14470: Add streaming expressions to /export handler. 2020-06-08 16:03:07 +02:00
Jan Høydahl 3e538005ec SOLR-9679: Harden BasicAuthOnSingleNodeTest#testDeleteSecurityJsonZnode 2020-06-08 10:46:53 +02:00
Erick Erickson 04ba04c29d SOLR-14543: Fix or suppress warnings in apache/solr/search 2020-06-07 21:20:25 -04:00
Jan Høydahl f404a38fa6
SOLR-9679: Exception when removing zk node /security.json (#1403) 2020-06-08 01:11:56 +02:00
Gus Heck ae6fe8d826 Revert "Refactor for code clarity, add some comments."
This reverts commit ebd40918 for which I apparently ran the tests one less time than I needed to
2020-06-07 13:02:45 -04:00
Gus Heck ebd409187a Refactor for code clarity, add some comments. 2020-06-07 12:24:17 -04:00
Gus Heck 14a988cc2a Legibility: Only get the value of node from messages once. 2020-06-07 12:20:27 -04:00
mrsoong 291e358a3d
SOLR-13203: return 400 on invalid dynamic field for edismax uf (#1502) 2020-06-07 17:42:25 +05:30
Erick Erickson 3cbb1e0b4f SOLR-14480: Fix or suppress warnings in solr/cloud/api 2020-06-06 18:11:37 -04:00
Erick Erickson ae3de57b33 SOLR-14538: Fix or suppress remaining warnings in apache/solr/handler 2020-06-05 15:22:44 -04:00
Chris Hostetter 924e7d5cd6 Assume the 'javascript' engine is supported before trying test, to prevent spurious failures on systems w/o javascript engine 2020-06-05 11:39:47 -07:00
Chris Hostetter b055c7489f SOLR-14467: Fix relatedness() stat in json.facets to no longer cause server errors (or nonsense results) when combined with allBuckets:true 2020-06-05 08:58:59 -07:00
Erick Erickson 0c4d8fb116 SOLR-14535: Fix or suppress warnings in apache/solr/handler/component, sql and loader 2020-06-04 17:49:46 -04:00
murblanc dec6922528
SOLR-14524: Harden MultiThreadedOCPTest testFillWorkQueue() (#1548)
Make MultiThreadedOCPTest.testFillWorkQueue() less vulnerable to timing issues

Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-06-04 16:37:24 -05:00
Erick Erickson bab4fccba2 SOLR-14533: Fix or suppress warnings in solr/handler/admin 2020-06-04 07:02:55 -04:00
Chris Hostetter fb58f433fb SOLR-14520: Fixed server errors from the json.facet allBuckets:true option when combined with refine:true 2020-06-03 09:09:46 -07:00
David Smiley 2af82c83d9 SOLR-11334: Split some field lists better
Used by HighlightComponent and TermVectorComponent
Used to produce an empty string on comma-space, leading to an exception.
2020-06-02 22:57:37 -04:00