c88bb59d81
FIX: Fully re-render ads when navigating between pages ( #188 )
...
In the past, the ad plugin relied on two side-effects to achieve this behaviour:
1. Components being fully destroyed/rendered when navigating between pages. This stopped working when Discourse core moved to the more efficient 'loading slider' UI
2. The `listLoading` argument. This was an implementation detail of the old discovery routing infrastructure. Core recently overhauled this and removed the `listLoading` argument, because loading is now handled properly by the Ember router.
Instead of these two properties, we can use the `currentRoute` property of Ember's router service to trigger changes when navigating between pages. A common `{{#each` trick is used to fully destroy/re-render components even if the ad network is unchanged.
2023-11-07 21:12:30 +00:00
5ad841de0b
Update translations ( #184 )
2023-11-07 21:31:35 +01:00
0948d6b19e
DEV: Refactor initializer to use RenderGlimmer and registerWidgetShim
2023-11-07 18:37:39 +00:00
3828578d5d
DEV: Restructure file locations
...
- Colocate components / connectors
- Move admin UI files to `admin/assets` so they are only served to admins
2023-11-07 18:37:39 +00:00
dbafb3b277
DEV: Update tests to use qunit-dom
2023-11-07 18:14:12 +00:00
86ef7da2eb
DEV: Apply eslint --fix
2023-11-07 18:14:12 +00:00
32a43a850f
DEV: Update linting config
2023-11-07 18:14:12 +00:00
8931e2a07e
Bump @babel/traverse from 7.20.10 to 7.23.2 ( #182 )
...
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse ) from 7.20.10 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse )
---
updated-dependencies:
- dependency-name: "@babel/traverse"
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-18 18:26:49 +02:00
44f49725f8
Update translations ( #181 )
2023-08-29 15:50:11 +02:00
3a89fbdd9a
Update translations ( #180 )
2023-08-23 09:28:54 +02:00
8f51e0e4c0
DEV: Pin plugin for Discourse 3.1 stable ( #179 )
2023-08-22 13:45:25 -05:00
30c49eb50d
Update translations ( #178 )
2023-08-08 15:42:08 +02:00
8cb9628f0d
Bump word-wrap from 1.2.3 to 1.2.4 ( #177 )
...
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap ) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases )
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4 )
---
updated-dependencies:
- dependency-name: word-wrap
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-19 01:00:58 +02:00
b4aa9a05be
Bump semver from 6.3.0 to 6.3.1 ( #176 )
...
Bumps [semver](https://github.com/npm/node-semver ) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-11 10:37:40 +02:00
db0097b8f8
Update translations ( #175 )
2023-07-04 18:13:14 +02:00
bade14daa0
Update translations ( #174 )
2023-06-27 16:39:17 +02:00
743478d593
DEV: Use angle bracket syntax ( #172 )
2023-05-26 09:20:47 -05:00
58205cc9ac
UX: introduce min-height for responsive ads ( #170 )
2023-04-25 16:19:48 -04:00
d3005f26af
Update translations ( #169 )
2023-04-11 15:44:40 +02:00
c2057a5056
FEATURE: Add per-ad visibility settings for anons and logged-in users ( #168 )
...
This commit adds 2 new settings to house ads to control whether an ad is shown to anonymous users and logged in users. Existing ads that were created before this feature will default to true for both settings; i.e., they will remain to be visible to both anonymous and logged-in users, but it will be possible to change the settings. Turning off both settings will effectively disable the ad completely.
2023-04-07 17:56:22 +03:00
bfd4438b97
Update translations ( #167 )
2023-02-21 17:11:00 +01:00
4d2ec950d0
Ensure README images are pointing to discourse/gh-owned repositories ( #166 )
2023-01-25 17:30:08 +05:30
165ecdefc5
DEV: Update CI workflows ( #165 )
...
Co-authored-by: discoursebuild <build@discourse.org>
2023-01-10 18:02:36 +00:00
c519b4bc92
DEV: Update eslint-config-discourse, use prettier for hbs ( #163 )
2023-01-04 13:34:08 +01:00
dc48bea931
Update translations ( #164 )
2022-12-30 17:49:25 +01:00
c73ac98748
DEV: Introduce syntax_tree for ruby formatting ( #161 )
2022-12-29 13:29:26 +01:00
ff6b767796
Update translations ( #160 )
2022-12-28 13:31:54 +01:00
116795aff3
Update translations ( #159 )
2022-11-29 15:35:21 +01:00
fd6ac11ee9
Bump minimatch from 3.0.4 to 3.1.2 ( #157 )
...
Bumps [minimatch](https://github.com/isaacs/minimatch ) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases )
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2 )
---
updated-dependencies:
- dependency-name: minimatch
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-27 17:33:42 +01:00
203eedb915
Update translations ( #156 )
2022-11-16 11:36:55 +01:00
8ac32a06c3
DEV: Update CI workflows ( #155 )
...
Co-authored-by: discoursebuild <build@discourse.org>
2022-11-07 12:45:46 -06:00
f52ac0775f
Update translations ( #154 )
2022-11-02 15:12:51 +01:00
fa2ec23ebc
DEV: Use `popupAjaxError` instead of bootbox ( #153 )
2022-10-18 13:58:55 -04:00
f7d9d13de8
Update translations ( #152 )
2022-10-05 15:31:18 +02:00
a647813ce7
DEV: Bump rubocop-discourse ( #151 )
...
* DEV: Bump rubocop-discourse
* Fix rubocop violations
2022-10-03 21:36:57 +02:00
a570a46ad2
Update translations ( #150 )
2022-09-27 19:07:32 +02:00
3b50a509f2
Update translations ( #149 )
2022-07-26 15:20:46 +02:00
4940d0ea19
FIX: Ensure we won't render the connector if there are no ads ( #148 )
2022-07-14 15:58:29 -03:00
d9b739f803
FIX: Don't render the connector when we shouldn't display an ad in the topic list item. ( #146 )
...
We expose the ad-slot logic to determine which ads are potentially available for each slot and don't render the connector when there are none. Leaking the component logic is not ideal, but I don't see a better solution given the
current design.
2022-07-12 16:13:18 -03:00
a4aa6332bb
Update translations ( #147 )
2022-07-12 17:25:54 +02:00
469771db1d
DEV: Skip assertion temporarily. ( #145 )
...
The code-review plugin overrides the core's topic-list template, which makes all the connectors for the outlets there stop working. I'm temporarily skipping this assertion until we remove the override.
2022-07-07 15:07:16 -03:00
5901a52dbc
FEATURE: support placing ads between topic list for house ads ( #143 )
...
* init
* more
* Pass td and colspan to component
* various fixes for house ads between n topics and add a test
* Make adComponents condition easier to read
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
Co-authored-by: romanrizzi <rizziromanalejandro@gmail.com>
2022-07-07 08:53:29 -03:00
c27f5717e4
Update translations ( #144 )
2022-07-06 09:14:50 +02:00
a514c7aee2
Update translations ( #142 )
2022-06-21 15:25:57 +02:00
3f951116fa
DEV: Update CI workflows ( #141 )
...
Co-authored-by: discoursebuild <build@discourse.org>
2022-06-17 21:32:32 +02:00
fb73dda584
DEV: Remove 'htmlSafe' string prototype extensions ( #140 )
...
Context: https://deprecations.emberjs.com/v3.x/#toc_ember-string-prototype_extensions
2022-06-01 11:37:01 -05:00
b9ac5516bf
DEV: Update CI workflows ( #139 )
...
Co-authored-by: discoursebuild <build@discourse.org>
2022-05-23 16:58:32 +02:00
e56197505f
Bump async from 2.6.3 to 2.6.4 ( #136 )
...
Bumps [async](https://github.com/caolan/async ) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases )
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md )
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4 )
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 18:02:21 +02:00
208b56b130
Bump ansi-regex from 4.1.0 to 4.1.1 ( #135 )
...
Bumps [ansi-regex](https://github.com/chalk/ansi-regex ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases )
- [Commits](https://github.com/chalk/ansi-regex/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: ansi-regex
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 13:53:32 +02:00
898de0c9c8
Bump minimist from 1.2.5 to 1.2.6 ( #134 )
...
Bumps [minimist](https://github.com/substack/minimist ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases )
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6 )
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 13:51:42 +02:00
David Taylor
Discourse Translator Bot
dependabot[bot]
Penar Musaraj
Isaac Janzen
Kris
Osama Sayegh
Rishabh
discoursebot
Roman Rizzi
Arpit Jalan