Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Update deprecation banner to include id and remove Ember 5 link (#25786) 

We're starting to use this system for non-ember-5 deprecations, so linking to the Ember 5 topic doesn't make sense. Instead, we can include the deprecation ID to help with identifying the issue.
This commit is contained in:
David Taylor 2024-02-21 10:59:09 +00:00 committed by GitHub
parent 1d4ef460ac
commit a30b54be87
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/services/deprecation-warning-handler.js
View File

@ -82,7 +82,9 @@ export default class DeprecationWarningHandler extends Service {
notifyAdmin(id, source) { notifyAdmin(id, source) {
this.#adminWarned = true; this.#adminWarned = true;
let notice = I18n.t("critical_deprecation.notice"); let notice = I18n.t("critical_deprecation.notice", {
id: escapeExpression(id),
});
if (this.siteSettings.warn_critical_js_deprecations_message) { if (this.siteSettings.warn_critical_js_deprecations_message) {
notice += " " + this.siteSettings.warn_critical_js_deprecations_message; notice += " " + this.siteSettings.warn_critical_js_deprecations_message;

2
config/locales/client.en.yml
View File

@ -226,7 +226,7 @@ en:
broken_plugin_alert: "Caused by plugin '%{name}'" broken_plugin_alert: "Caused by plugin '%{name}'"
critical_deprecation: critical_deprecation:
notice: "<b>[Admin Notice]</b> One of your themes or plugins needs updating for compatibility with upcoming Discourse core changes (<a target='_blank' href='https://meta.discourse.org/t/287211'>more info</a>)." notice: "<b>[Admin Notice]</b> One of your themes or plugins needs updating for compatibility with upcoming Discourse core changes (id:<em>%{id}</em>)."
theme_source: "Identified theme: <a target='_blank' href='%{path}'>'%{name}'</a>." theme_source: "Identified theme: <a target='_blank' href='%{path}'>'%{name}'</a>."
plugin_source: "Identified plugin: '%{name}'" plugin_source: "Identified plugin: '%{name}'"