55fd3acea0
Revert "FIX: Undefined method when serializing a user"
...
This reverts commit 1fbe078ae04f5c9bb8d3
2019-06-04 09:30:30 +08:00
1fbe078ae0
FIX: Undefined method when serializing a user
...
Apparently is is possible to have a user without a user_profile. This
fix will return nil for any user_profile fields during serialization
(like the after delete web hook) instead of blowing up.
2019-05-23 19:44:55 -06:00
bf7594b327
More prefabrication
2019-05-10 08:34:04 -04:00
63a3caa516
FIX: Don't display option for users to flag and notify a bot.
2019-05-10 10:05:03 +08:00
e219588142
DEV: Prefabrication (test optimization) ( #7414 )
...
* Introduced fab!, a helper that creates database state for a group
It's almost identical to let_it_be, except:
1. It creates a new object for each test by default,
2. You can disable it using PREFABRICATION=0
2019-05-07 13:12:20 +10:00
18d742d334
FIX: Broken spec
2019-05-06 17:09:08 -04:00
31e100530f
FEATURE: Flag count in post menu
...
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.
We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
bcdf5823a0
DEV: correct frozen string and broken spec
...
This needs to be properly handled so the correct message is raised
1 item was removed from the serializer (avg_time)
2019-05-06 17:31:35 +10:00
24347ace10
FIX: Properly associate user_profiles background urls via upload id.
...
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
1be01f8dd4
DEV: Add support for Rails 6
...
Minor fixes to add Rails 6 support to Discourse, we now will boot
with RAILS_MASTER=1, all specs pass
Only one tiny deprecation left
Largest change was the way ActiveModel:Errors changed interface a
bit but there is a simple backwards compat way of working it
2019-05-02 16:23:25 +10:00
404b35bd04
FEATURE: Category Reviewable by Group
...
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
ad44243a57
Removed unused let blocks ( #7446 )
...
The bodies of these blocks were never evaluated.
2019-04-29 15:08:56 +08:00
bf313c1b68
DEV: User email test optimization ( #7405 )
2019-04-23 17:49:05 +08:00
57d1dea8a2
FEATURE: Let staff add custom post notices. ( #7377 )
2019-04-19 17:53:58 +03:00
a5d9afe397
FEATURE: Include a user's pending posts in the topic view
...
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
2019-04-12 14:25:12 -04:00
331a809738
FEATURE: Display the reason for many reviewable items
...
Queued Posts and Users will now display a reason why they are in the
review queue.
2019-04-11 12:04:45 -04:00
47c50d9a95
DEV: Add test for post notices. ( #7352 )
2019-04-10 22:06:27 +03:00
82e051077d
Show link to the original topic when it was deleted ( #7319 )
...
* Moved i18n keys to core. We show a links that points to the original topic when it was deleted
* Use link-to since it's more idiomatic
2019-04-10 11:25:45 +02:00
131eba0366
FIX: Hide post replies content for ignored users ( #7320 )
2019-04-05 16:13:36 +02:00
111a502231
FIX: Deleting Users should work nicely with Reviewable Users
...
"Rejecting" a user in the queue is equivalent to deleting them, which
would then making it impossible to review rejected users. Now we store
information about the user in the payload so if they are deleted things
still display in the Rejected view.
Secondly, if a user is destroyed outside of the review queue, it will
now automatically "Reject" that queue item.
2019-04-03 16:42:39 -04:00
af04318aff
FIX: Allow us to serialize reviewables with deleted topics
2019-04-02 09:36:49 -04:00
a2e6a8a51e
DEV: Refactor test to assert for actual content.
...
The other assertion is already asserting for `Post#url` and I think it
makes the test clearer here.
2019-04-02 07:43:13 +08:00
6470c85fda
UX: Link directly to the post, not to the topic
2019-04-01 14:29:14 -04:00
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
ef2362a30f
FEATURE: Introducing new UI for changing User's notification levels ( #7248 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-27 09:41:50 +00:00
b8bd031648
FIX: Always include custom fields in CategorySerializer
...
even if it is empty
2019-03-25 07:59:56 +05:30
4477938ea7
DEV: Option to preload category custom fields for site serializer
2019-03-16 17:18:57 +05:30
c5808a8a25
PERF: N+1 queries admin users pages.
2019-03-15 15:09:44 +08:00
c34a6ba674
REFACTOR: Rename site settings to make them less confusing
2019-03-14 13:40:14 +01:00
7310ee3ef1
FEATURE: Add more control over post notices. ( #7148 )
2019-03-13 08:06:28 +11:00
ceec11a153
FIX: Make post notices invisible to poster.
2019-03-11 12:07:19 +02:00
b28b418363
FIX: Various improvements to post notices.
...
- Notices are visible only by poster and trust level 2+ users.
- Notices are not generated for non-human or staged users.
- Notices are deleted when post is deleted.
2019-03-11 11:19:58 +02:00
eb3f15c3e2
FIX: WebhookPostSerializer spec failure
2019-03-06 09:47:31 +00:00
55b4b84b63
FIX: WebhookUserSerializer spec failure
2019-03-05 17:57:46 +00:00
986cc8a0fb
FEATURE: Introduce Ignore user ( #7072 )
2019-02-27 14:49:07 +01:00
457e6c7b37
FIX: Mods weren't able to see emails in admin user list
2019-01-18 15:37:30 +01:00
83af32c472
DEV: more accurate spec for UserSummarySerializer
2019-01-14 07:26:10 +05:30
5e9a7e41e9
DEV: improve UserSummarySerializer spec
2019-01-14 07:19:37 +05:30
e453539e1e
DEV: Refactor test to assert for the actual output.
...
Also, generatnig the same json multiple times.
2019-01-12 08:00:22 +08:00
5e0f9eadb8
FIX: show user avatar on User summary page ( #6872 )
2019-01-11 23:39:06 +05:30
dbe42068a2
REFACTOR: Move option to return emails into the serializer
...
This makes more sense than having the guardian take an accessor.
The logic belongs in the Serializer, where the JSON is calculated.
Also removed some of the DRYness in the spec. It's fewer lines
and made it easier to test the option on the serializer.
2019-01-11 11:17:23 -05:00
0ce5f05b2a
FIX: hide emails on admin user list for moderators ( #6781 )
2018-12-19 10:24:57 +01:00
98d09c90ac
Current user serializer groups ( ef7f84b follow-up)
2018-12-18 09:05:45 +01:00
9f3e2a9e34
FIX: Only serialize group membership domains for administrators ( #6771 )
2018-12-14 15:47:00 +00:00
5e09398c5b
FIX: Do not serialize user fields unless they are specified for display ( #6736 )
2018-12-07 10:57:28 +00:00
1da265db11
UX: category images have no sizes ( #6662 )
2018-11-27 08:40:06 +08:00
cf21c7f5aa
DEV: Fix typo in specs.
2018-11-19 15:13:54 +08:00
fe131c5ea2
Fix missing avatars on topic list page.
...
Introduced in b50fab2d72
2018-11-19 14:55:41 +08:00
b50fab2d72
PERF: Fix N+1 for non-staff users when tagging is enabled.
2018-11-19 12:53:58 +08:00
fa0e421af3
FIX: Do not leak information about post revisions. ( #6536 )
2018-10-31 14:47:00 +00:00
d17c8df926
Only check for suspicious login for staff members
2018-10-26 00:29:28 +02:00
effbef7d0b
UX: Use user locale for locations. ( #6527 )
...
* UX: Use user locale for locations.
* DEV: Added MaxMindDB test data and fixed test.
2018-10-25 10:54:01 +00:00
65faff5832
DEV: Improve specs to provide a better error message.
2018-10-19 14:31:17 +08:00
501ac4dfa6
DEV: Cleanup properly after user_serializer test
2018-10-17 10:54:22 +01:00
c6f364224e
FEATURE: Allow plugins to whitelist user custom fields for public display ( #6499 )
...
This works exactly the same as `whitelist_staff_user_custom_fields`, but is not limited to staff
2018-10-17 10:33:27 +01:00
b8a1196b6b
Add missing fields to Upload Fabricator ( #6448 )
2018-10-04 22:00:07 +08:00
a651d39b8a
FIX: Display errors in single theme pages ( #6449 )
...
Currently the errors are not well handled. So it breaks the whole UI of admin themes list page.
2018-10-04 02:33:06 +05:30
5a214a687c
FIX: Exclude `UserAuthToken` and `UserAuthTokenLog` in user webhook.
2018-08-31 17:25:56 +08:00
931cffcebe
FEATURE: Let users see their user auth tokens. ( #6313 )
2018-08-31 10:18:06 +02:00
ff441bc4ca
Add spec for UserSerializer and UserApiKey.
2018-08-23 19:01:02 +02:00
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
3e436e2daf
FIX: doesn't translate group permission keys
2018-08-21 12:56:56 +02:00
50df2d7241
FIX: Should not include regular categories in top_category_ids array
2018-07-30 16:06:36 +05:30
dac29b5ebc
UX: Display only top categories in hamburger menu ( #6146 )
2018-07-27 12:11:07 +05:30
21ebb1cd54
FEATURE: Secondary emails support.
2018-07-16 11:09:49 +08:00
96aca6d7e6
Remove legacy vote post action code. ( #6009 )
2018-07-09 16:54:18 +08:00
969e79d7c6
PERF: Do not calculate gaps for `TopicViewPostsSerializer`.
...
The client doesn't use the gaps results when loading new posts.
2018-07-02 14:01:50 +08:00
bad6a5142c
PERF: Don't include entire post stream when we're loading more posts.
2018-06-22 10:49:03 +08:00
ced3c8e5cf
remove unused variable
2018-06-12 15:00:50 +05:30
59a8471308
FIX: do not show SSO external_email to moderators
2018-06-12 14:20:44 +05:30
89ad2b5900
DEV: Rails 5.2 upgrade and global gem upgrade
...
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated
Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
45f65859c9
improve erraticly failing spec
2018-05-23 08:39:15 +10:00
37ad2dd936
Fix the build.
2018-05-21 17:59:47 +08:00
00c6b078e3
Trim `WebHookUserSerializer`.
2018-05-21 17:29:58 +08:00
60e7b13f59
Trim `WebHookPostSerializer` further.
2018-05-21 17:29:58 +08:00
3ff0074e9d
Trim `WebHookTopicSerializer` further.
2018-05-21 17:29:58 +08:00
b74c108c09
UX: Display group tabs in user's messages tab for non-staff as well.
...
https://meta.discourse.org/t/group-inboxes-in-user-messages/86787
2018-05-17 18:10:17 +08:00
565fa1f60e
Fix regression introduced in 8cf0f51eb2.
2018-05-16 14:26:03 +08:00
64a45b0980
FIX: Missing `Group#bio_raw` attribute for group owners.
...
https://meta.discourse.org/t/group-description-does-not-load-in-editor-for-owners-who-are-not-staff/85345
2018-04-17 15:57:52 +08:00
f2c060bdf2
FEATURE: option for tags in a tag group to be visible only to staff
2018-03-26 17:05:09 -04:00
88fdc926d1
Move external_id from UserSerializer to CurrentUserSerializer ( #5658 )
2018-03-07 22:54:31 -05:00
51544047dc
Add external_id to User Serializer
2018-02-28 10:13:27 +08:00
519026a31f
Trim attributes that are not useful from `WebHookTopicViewSerializer`.
2018-02-27 11:28:31 +08:00
7cbda949f1
REFACTOR: New spec tests and code improvement
2018-02-22 20:27:02 +05:30
84867c1c07
Rename site setting to allow_staff_to_tag_pms from allow_staff_to_tag_in_pm
2018-02-22 06:48:34 +05:30
2b509eaa91
Merge branch 'master' into pm-tags
2018-02-21 23:55:59 +05:30
4d842ef2d5
Additional spec test function added and fixed the existing
2018-02-21 21:47:02 +05:30
84ce1acfef
FEATURE: Allow staffs to tag PMs
2018-02-21 20:11:46 +05:30
1446753fd2
FIX: Include deleted topics in the post serializer
2018-02-21 14:31:52 +05:30
179ecee11e
FIX: featured links are 'undefined' in suggested topics
2018-01-25 14:40:07 -05:00
80c41a0e59
Merge pull request #5510 from discourse/add-posts-count-to-web-hook-post-serializer
...
Feature: add topic posts count to webhook post serializer
2018-01-23 07:46:59 +08:00
47058b29d3
FEATURE: emit external_id field with user webhook
2018-01-22 10:09:26 +11:00
22ca5a772d
Expect 41 keys in the serializer
2018-01-17 11:48:00 -08:00
9fbe1436b6
UX: Replace heuristic solution root domain extraction for topic featured link.
2017-11-29 21:52:41 +08:00
8491c5fba5
UX: Replace heuristic solution for extracting root domain.
2017-11-29 16:26:46 +08:00
87ec11e298
FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats.
2017-11-17 16:08:46 -05:00
838568cbc3
Refactor flag types for more customization
2017-10-19 13:55:23 -04:00
5d37f8673b
PERF: Only send down suggested payload when loading last chunk.
2017-09-26 14:42:27 +08:00
Guo Xiang Tan
Blake Erickson
Daniel Waterworth
Robin Ward
Sam Saffron
Dan Ungureanu
Roman Rizzi
Tarek Khalil
Vinoth Kannan
Gerhard Schlager
Tarek Khalil
Arpit Jalan
Maja Komel
David Taylor
Bianca Nenciu
Régis Hanol
Paul Trippett
Bianca Nenciu
Leo McArdle
Guo Xiang Tan
Neil Lalonde
Simon Cossar