d2e320d4f7
FIX: Bookmarks shortcut goes to new bookmarks with reminders ( #10181 )
2020-07-07 11:12:41 -05:00
4a90464619
FIX: Do not highlight large code blocks ( #10125 )
2020-07-07 18:51:19 +03:00
6705c45156
FEATURE: Add reply_as_new_group_message composer action ( #10168 )
2020-07-07 18:30:48 +03:00
f92116d695
Revert "DEV: flexify post actions ( #9926 )"
...
This reverts commit 6ef0e98f4e
2020-07-07 12:42:49 +02:00
56475f57c5
UX: simplifies editing email templates by always having a default ( #10179 )
2020-07-07 11:44:13 +02:00
9b7000dbf1
FIX: ensures category order keeps consistent ( #10165 )
...
Before this change:
- first full page load would get category defaults defined un cateory settings
- a navigation to a topic and then back to categories list would reset defaut to the ones defined in discovery/topics
2020-07-07 09:56:38 +02:00
72861f4e1c
FIX: add table CSS rules to normalize ( #10176 )
...
* FIX: add table CSS rules to normalize
In the new version of normalize - 8.0.1 ` `table` and `td` CSS rules are missing
https://github.com/necolas/normalize.css/blob/master/normalize.css
They existed in version `3.0.1` https://github.com/necolas/normalize.css/blob/3.0.1/normalize.css#L417
Also, extracted custom rules to new file
2020-07-07 16:47:03 +10:00
280cd99c62
DEV: Add extra appEvents to composer workflow
...
* add composer:saved, composer:created-post, and composer:edited-post
appEvents inside the composer controller, to make it easier to detect
these events in plugins
2020-07-07 14:13:45 +10:00
556f7dc9c0
FIX: Fix race condition when resolving tag and category hashtags ( #10153 )
...
* FIX: Fix race condition when resolving tag and category hashtags
If the category hashtags were resolved first and then tag hashtags, then
the tags would overwrite the categories. Similarly, if the category
hashtags were resolved last it would overwrite even hashtags which ended
with '::tag'.
* DEV: Add test
* DEV: Fix test
2020-07-07 10:20:51 +10:00
b9e3db6387
UX: Add link to user email preferences in admin view ( #10169 )
2020-07-07 10:20:14 +10:00
6ef0e98f4e
DEV: flexify post actions ( #9926 )
...
* DEV: flexify post actions
* more tweaks
2020-07-07 10:18:01 +10:00
1f5cecaf28
Minor follow up fix to 4f12768 for mobile
2020-07-06 19:17:30 -04:00
4f12768d10
UX: Remove extra space added by img resize controls in composer preview
2020-07-06 19:11:58 -04:00
194c962124
FIX: Do not rerender widget-dropdown on all clicks ( #10100 )
...
Because of how the dropdown was structured, as long it was in the DOM, all clicks outside the widget would rerender it.
This commit introduces `widget-dropdown-body` that handles the `clickOutside` callback and is rendered conditionally, so it won't get called when the dropdown is closed.
2020-07-06 17:04:16 +02:00
3b51e05de2
FIX: CookText may be gone before promise resolves ( #10097 )
...
* FIX: CookText may be gone before promise resolves
Bug introduced in 293467a37a232311aa8c
2020-07-06 17:03:27 +02:00
3792ffa556
DEV: Update method documentation in lib/computed.js ( #10172 )
2020-07-06 09:26:21 -05:00
6e341f1839
UX: restore table borders
...
Newer versions of Normalize remove the `border-collapse: collapse;` property and fallback to browser defaults. This commit restores that property because we're using it in quite a few places.
2020-07-06 21:25:41 +08:00
98786cb037
DEV: Refactor basic-topic-list to use topic-list-item on mobile ( #10105 )
...
Previously, basic-topic-list had its own implementation of topic-list-item on mobile, which made it more difficult to maintain and extend. The visible difference was that the basic-topic-list implementation had no large avatar on the left. This commit adds a new hideMobileAvatar parameter to topic-list-item and topic-list, and sets it to `true` for the basic-topic-list component.
2020-07-06 13:58:57 +01:00
525a2174b3
Restore 'pointer' cursor on buttons
...
Normalize removed their opinionated cursor styling of buttons in [4.0.1](170455d6f61fd3a30a59
2020-07-06 13:15:31 +02:00
5284d41a8e
FEATURE: Optionally skip the create account popup for external auth
2020-07-06 10:18:57 +01:00
041d28295f
UX: Hide login button during externally authenticated account creation
...
Also switch to use the new d-button loading property for the create account button
2020-07-06 10:18:49 +01:00
977766e7a8
FEATURE: sso_overrides_(email|username|name) for all auth methods
...
These settings previously applied only to discourse-sso. Now they work for all external authentication methods.
2020-07-06 10:18:45 +01:00
789a15a897
DEV: allows autocomplete to be debounced ( #10166 )
...
Usage:
```
$(".foo").autocomplete({debounced: true});
```
2020-07-06 09:28:57 +02:00
1fd3a30a59
FIX: update normalize css from 3.0.1 to 8.0.1 ( #10141 )
...
It is a second attempt to this update. First one was reverted here https://github.com/discourse/discourse/pull/8618
We noticed a problem that `like` counter had incorrect colour on mobile.
I added a missing rule to the bottom of the file (that rule existed in normalize-3 and was removed in normalize-8)
```
button,
input,
optgroup,
select,
textarea {
color: inherit;
}
```
2020-07-06 09:09:30 +10:00
a9c703c230
FIX: emoji autocomplete not triggering correctly
...
08044b4f👍 t` would not trigger an autocomplete to pick skin tone.
2020-07-03 16:56:11 +10:00
04d7693355
FIX: Filter read/unread notifications on the server side ( #10152 )
...
https://meta.discourse.org/t/notifications-unread-only-filter/37621/32
2020-07-02 11:06:00 +01:00
95153356ea
PERF: Refactor lightbox decorator to use querySelectorAll ( #10158 )
...
Previously we were using `$elem.find(...).not($elem.find(...))`. This took approximately 2ms on my machine with a test post.
This commit switches to using a native querySelectorAll method, which takes less than 0.5ms on the same test post.
2020-07-02 11:04:19 +01:00
490939a1c9
UX: Truncate long badge names in the mobile usercard
2020-07-01 21:39:40 -04:00
8bc61e84a7
FIX: Support root paths that omit the trailing slash and have QPs
2020-07-01 14:55:20 -04:00
76d5e54aab
PERF: Check for modal visibility in a more efficient way
...
This code runs on every keyup event in the application, so it needs to be efficient. Previously we were iterating over the whole document using the JQuery :visible selector. Per the JQuery docs at https://api.jquery.com/visible-selector/
> Using this selector heavily can have performance implications, as it may force the browser to re-render the page before it can determine visibility. Tracking the visibility of elements via other methods, using a class for example, can provide better performance.
We already had a `hidden` class on the modal element which we can check, so we can check that instead.
2020-07-01 17:49:23 +01:00
57a8b3b964
DEV: Add group name as class to group-box ( #10150 )
2020-06-30 10:49:31 -05:00
4db9f7bb73
FIX: Hide publish_read_state option from non-admin users ( #10148 )
2020-06-30 16:49:04 +01:00
67a310db02
FIX: emoji_autocomplete_min_chars failing when not 0
...
autocomplete resolving to [] was causing it to stop working.
Instead we have a special const (SKIP) which ensures it will
continue to be evaluated and only this instance is skipped.
2020-06-30 17:39:52 +10:00
7ddd83dfcf
FIX: Uploads cannot be mapped due to the cook-text's element attr being null ( #10136 )
2020-06-29 15:37:40 -03:00
df1f804400
FIX: ensures moderation history is accessible from topic/post admin menu ( #10118 )
2020-06-24 10:49:47 +02:00
42226e12ee
FEATURE: Add after-user-name plugin outlet ( #10113 )
2020-06-24 15:45:11 +10:00
13087cab54
FIX: Prevent typing "#" when showing "Jump to…"
...
Closes https://meta.discourse.org/t/the-shortcut-behaves-wrong-in-some-browsers/155531
2020-06-24 00:25:54 +02:00
aff9bfd5bc
FIX: Fix select kit size ( #10094 )
2020-06-22 16:48:00 +03:00
516a03be09
FIX: Improve admin permalink UX ( #10101 )
...
The admin permalink list was a little tricky to use because the URLs are easily reduced with a ... if they are too long. This adds a copy to clipboard button for the URL and a title on hover so the full text of the URL can be seen.
2020-06-22 13:14:16 +10:00
02d3bf304a
remove inaccurate comment, follow up to c028936
2020-06-19 16:49:56 -04:00
c0289362f7
Safari icon fix, follow up to 5cc0369
2020-06-19 16:44:34 -04:00
0b58414de2
DEV: Add classes to admin customize nav items ( #10092 )
2020-06-19 10:51:53 -05:00
4a2871f7f6
FEATURE: Don't display muted/ignored users under "who liked" ( #10084 )
...
* FEATURE: Don't display muted/ignored users under "who liked"
Previously, if you clicked on the heart icon below a post
it would show you the avatar for a user even if you ignored or muted
them.
This commit will instead display a (?) icon. The count of likes will
remain correct, but you needn't be reminded of the person you
preferred not to see.
* Use a circle instead of (?) for unknown user
2020-06-19 10:44:21 -04:00
b5495b8e9c
FIX: Do not incorrectly add topic bookmark on Escape ( #10088 )
...
* The first post was showing as bookmarked incorrectly after pressing f to open the topic modal then pressing escape to cancel without saving, because the closeWithoutSaving option was not being respected.
* Also re-introduce the enter shortcut when the name input is focused to saveAndClose the bookmark modal by pressing enter.
2020-06-19 11:17:18 +10:00
5faf074e61
minor fix to post admin menu button class
2020-06-18 19:18:00 -04:00
6cb6faff29
UX: Ignore modal margin was too tight
2020-06-18 13:26:25 -04:00
b8c676e727
FEATURE: allows to ignore a user forever ( #10074 )
2020-06-18 11:24:07 -04:00
ec794c7f29
DEV: Plugin outlet after user-info ( #10072 )
2020-06-18 10:18:34 -05:00
62faa0f5fe
FIX: Do not show Add or Change buttons if email is not editable ( #10068 )
2020-06-18 11:15:44 +03:00
d72ed8c5a8
UX: Include category name in hyperlink modal results on mobile
2020-06-17 14:46:01 -04:00
a60a67c431
FIX: Show unconfirmed emails too when checking emails ( #10062 )
...
When checking emails through user preferences, it did not display the
unconfirmed emails.
2020-06-17 21:41:01 +03:00
81a3129ffb
ARIA - add aria-label on topic input and post textarea ( #10057 )
...
Add reply form role with label as create/reply, and aria-labels on text inputs
2020-06-17 08:55:19 -07:00
9da3a7f436
FEATURE: allows published pages to be public ( #10053 )
2020-06-17 12:42:20 +02:00
7d289a4f3e
UX: Style video elements, show descriptions ( #10040 )
...
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do.
2020-06-17 12:38:00 +02:00
a859d507e7
FIX: Prevent producing "undefined" strings ( #10042 )
...
Fixes a bug in search-menu-results (type: "group"), where:
```javascript
const fullName = escapeExpression(group.fullName);
const name = escapeExpression(group.name);
const groupNames = [h("span.name", fullName || name)];
```
`groupNames` could end up having value "undefined" if a group doesn't have a `fullName`.
2020-06-17 12:37:06 +02:00
d66ccabdb1
DEV: Added topic-list-after-title outlet in the mobile template ( #10059 )
2020-06-17 10:05:37 +01:00
52580605d8
FIX: select-kit components not being hidden.
2020-06-17 09:39:51 +08:00
a3e812453e
FEATURE: new category-list-above-each-category plugin outlet ( #10037 )
2020-06-16 11:53:36 -07:00
df0e3b4ed4
FIX: Allow opening FAQ in a new tab ( #10039 )
2020-06-16 17:35:04 +02:00
ce37561e10
UX: Improve revert label in post history modal ( #10038 )
2020-06-16 11:31:25 -04:00
4b4f568ec0
add showPreview to composer fields plugin outlet ( #10019 )
...
showPreview is necessary because we need to add 50% width class similar to: class="title-and-category with-preview" on the category and title div if the preview is shown.
2020-06-16 10:50:55 -04:00
6258406419
FIX: secondary_emails, unconfirmed_emails, group_users are private fields
...
Those fields should be only visible to the user.
2020-06-16 12:46:27 +03:00
298393a5bc
FIX: Keep onebox styling in edit history
2020-06-15 15:23:14 -04:00
6780d4d70c
FIX: process /invites/ route from server side only
2020-06-15 12:31:27 +05:30
35a157619a
FEATURE: Add "Now" as an option (default hidden) to the future date input selector ( #10047 )
...
Sometimes you need to schedule things from now onward. "Now" in this case is now + 1 minute. this option is hidden by default.
2020-06-15 14:06:03 +10:00
7429512ced
FIX: Get correct right/left offset for topic progress bar on compose
2020-06-12 18:44:42 -04:00
16b41aa485
Save button alignment fixes for admin badge page
2020-06-12 17:15:59 -04:00
2adad96d05
Center align items in select kit headers
2020-06-12 17:07:50 -04:00
d0a7f15764
Usercard buttons on mobile should utilize full width
2020-06-12 16:24:25 -04:00
ff6811ceb8
Allow multiple groups which can vote when creating a poll ( #10015 )
...
* FEATURE: Allow multiple groups which can vote when creating a poll
* DEV: Fix select-kit deprecations
* DEV: Fix lint
2020-06-12 14:52:32 +03:00
60196cc192
FIX: Hide bootbox after a negative answer ( #10028 )
...
Starting to reply and then editing a post was not possible because of a
bootbox which kept showing up.
2020-06-12 13:48:45 +02:00
f57ecf22e0
UX: Send background color to iPad app too
...
Previously, we were only updating mobile devices.
2020-06-11 23:20:25 -04:00
62ad473716
FIX: Preload readonly mode attribute seperately.
...
There are two problems I'm trying to tackle here.
1. The site json is cached for anonymous users so readonly mode can be
cached for up to 30 minutes which makes it confusing.
2. We've already checked for readonly mode in the controller so having
to check for readonly mode again in `SiteSerializer` is adding an extra
Redis query on every request.
2020-06-12 09:54:05 +08:00
dd85d44dda
FIX: Show tag count for existing tags ( #9892 )
...
* FIX: Show tag count for existing tags
* Add test
2020-06-11 14:13:48 +03:00
6fa990f05d
FIX: prevents emoji in links to appear as large emojis ( #10027 )
2020-06-11 12:27:48 +02:00
a26b490047
FIX: present correct new/unread counts when filtered by tag
...
Previously we would incorrectly ignore tags.
This ensures tracking state is properly shipped to client if
show_filter_by_tag is enabled.
2020-06-11 16:47:57 +10:00
b8acb36532
DEV: Plugin outlet at top of user preference interface ( #10020 )
2020-06-10 13:36:50 -05:00
5bfe1ee4f1
FEATURE: Improve UX support for multiple email addresses ( #9691 )
2020-06-10 19:11:49 +03:00
3a7ca97c36
FIX: Use include-subcategories filter in report export ( #10007 )
...
Some filters were renamed and the conversion of the filter names and arguments
was removed.
2020-06-10 18:57:39 +03:00
8fe074430b
REVERT: partly revert change to ensure context is the same ( #10012 )
2020-06-10 11:10:39 +02:00
9e98c02dd7
FIX: Don't call cooked decorators in composer if cooked is unchanged
...
If cooked is unchanged, ember will not re-render the preview area, so we should not re-run the post-processing decorators. This can cause issues when decorateCooked functions are not idempotent.
2020-06-09 23:01:07 +01:00
f67e7d2fad
FIX: add attributes of `params` to topic `findOpts`.
...
If `params` is ignored then `findTopicList` won't get the `no_subcategories` attribute.
d27b877a40
2020-06-10 01:33:58 +05:30
43e17f92e0
DEV: allows to call a widget function without re-rendering the widget ( #10004 )
2020-06-09 19:58:17 +02:00
84d767716f
linting ( #10008 )
2020-06-09 19:54:06 +02:00
a3cf1cf6ff
DEV: allows to prepend widgets to post nav controls ( #10005 )
...
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-06-09 19:37:06 +02:00
23ed16339f
DEV: adds mouse{Over,Out} and touch{Start,End} to widgets ( #10003 )
2020-06-09 19:36:28 +02:00
415c1bb9e1
FIX: don't show create topic suggestion to users who can't
...
Users with TL below the "min trust to create topic" setting used to see a prompt to create new topics in the footer message below the topic list. Those topics would never be submitted because those users don't meet the TL requirements to create a new topic (based on that site setting). This PR removes that prompt for those users.
2020-06-10 00:02:11 +08:00
3094459cd9
FEATURE: multiple use invite links ( #9813 )
2020-06-09 20:49:32 +05:30
f1fc6cd40d
DEV: Add user-card-additional-buttons plugin outlet
...
The user-card-additional-controls outlet is outside the `<li>` element, which makes styling difficult. Placing an outlet inside the button list means that themes/plugins can easily reuse core styling.
2020-06-09 14:33:24 +01:00
08044b4f94
FIX: emoji autocomplete triggering incorrectly
...
Previous to this fix the we were checking for non letters.
This was mismatching what pretty-text/addon/emoji.js was doing.
`ù:su`
and
`1:su`
Would lead to an emoji autocomplete popup in the composer.
2020-06-09 17:22:51 +10:00
3e210b76d9
FIX: Change bookmark name "name" attr to disable autocomplete
2020-06-09 14:47:30 +10:00
d09bf892c7
UX: Improve layout of topic pin admin modal
2020-06-08 23:58:53 -04:00
c5b1f028ed
FIX: update minimum required tag when switching categories in composer
2020-06-08 17:10:26 -04:00
fbeaba4acf
FIX: don't override category text color in dropdown
2020-06-08 16:45:30 -04:00
bdba17cdf7
FIX: Restore stream position in safari ( #9993 )
...
Safari uses an aggressive back/forward cache, which means the app loads
very quickly when hitting Back. But, in topics with > 30 posts, hitting
Back runs post stream calculations too early, which means that users
get taken back to an earlier point in the stream, consistently.
Using `onpageshow`, we can restore the correct location before the post
stream calculations take place.
2020-06-08 10:13:46 -04:00
cb13152a43
FIX: ensures edit-category-setting is correctly casting boolean ( #9999 )
2020-06-08 15:16:42 +02:00
833b5d89e0
PERF: Cache PrettyText instance for rendering composer preview ( #9987 )
...
Previously we were building pretty-text from scratch on every keypress
2020-06-08 10:42:59 +01:00
293467a37a
REFACTOR: Remove jquery usage from resolveAllShortUrls, and fix debounce
...
- This function now requires an explicit scope. It will never run on the entire document.
- Previously debounce was being used with an anonymous function, which means it was having no effect.
2020-06-05 17:15:14 +01:00
0f09fd22f3
DEV: Remove attachment css handling from resolveAllShortUrls
...
This was moved inside the markdown processor in 65481858
2020-06-05 15:12:30 +01:00
a9def011d0
FIX: `(getURL "")` was not working with the `i18n` helper
2020-06-05 09:53:43 -04:00
be5974734d
PERF: Pass element to resolveAllShortUrl function, not text selector ( #9988 )
...
We already have a reference to the preview element, so there is no need to look it up again. This saves about 1ms per keypress in my testing.
2020-06-05 13:37:07 +01:00
731263b81c
PERF: Correctly memoize baseUri value in javascript app ( #9986 )
...
An empty string is a falsey value in javascript, so we were looking for the meta tag every time getURL was called, which took approximately 1.5ms every time.
2020-06-05 13:36:48 +01:00
2de2537595
UX: add bottom padding to user lists on mobile
...
In some cases, when lists had a handful of items, the last item would be covered by the footer-nav eoverlay on PWAs and DiscourseHub.
2020-06-04 21:42:01 -04:00
f6c3962e3c
UX: Change collapsed draft z-index on mobile
2020-06-04 21:24:14 -04:00
5cea4a6cc2
icon color fix, follow-up to 5cc0369
2020-06-04 17:29:28 -04:00
5cc0369898
Minor dropdown icon width fix
2020-06-04 17:26:57 -04:00
f00e5515e4
FIX: Service Worker URL was broken
...
Behavior was changed in #9966 , which made the URL be relative.
If the user landed in a topic, for example, the browser was given a
service worker URL under that specific topic URL, which was a 404.
Fixes broken PWA install and broken push notifications
2020-06-04 14:49:39 -03:00
a23d31e4d6
DEV: removes unecessary casting ( #9982 )
2020-06-04 19:07:34 +02:00
2d880b42a3
UX: Add simple-list setting type ( #9970 )
2020-06-04 10:44:54 -04:00
40dfac176f
FIX: client side /my/ redirects were appending extra slash
2020-06-04 17:32:34 +05:30
c200238bdc
DEV: Reorder appending extra header icons ( #9973 )
2020-06-03 14:28:02 -05:00
3e7f7fdde8
FEATURE: category setting for default list filter. ( #9975 )
2020-06-04 00:56:56 +05:30
ba00cc8ec4
DEV: Move `Discourse.getURL` and related functions to a module ( #9966 )
...
* DEV: Move `Discourse.getURL` and related functions to a module
* DEV: Remove `Discourse.getURL` and `Discourse.getURLWithCDN`
* FIX: `get-url` is required for server side code
* DEV: Deprecate `BaseUri` too.
2020-06-03 12:45:26 -04:00
d27b877a40
FIX: prevents false boolean param to be filtered as non existant ( #9968 )
...
* FIX: prevents false boolean param to be filtered as non existant
This was preventing to filter top category route to be filtered by replies.
* if order is different ascending should be true on first click
* test
* fix
* just pass params
* more fixxes
2020-06-03 10:19:53 -06:00
141fba8866
UX: Ensure that `select-kit` is hidden consistently.
2020-06-03 11:51:01 +08:00
1b5a505930
Small fixes to image uploaders
2020-06-02 20:36:01 -04:00
10e321a96f
Revert "DEV: makes autocomplete debounced ( #9941 )"
...
This reverts commit f9e715672b
2020-06-03 08:40:21 +10:00
688d9428fe
Use an em-based width for better scaling with font-size changes
2020-06-02 17:14:04 -04:00
9e9ff01e86
Add missing text back in
2020-06-02 16:39:18 -04:00
0cf297725f
DEV: Use consistent interpolation key format in translations
...
From now on client strings can easily be reused on the server and you don’t have to think about choosing the right format anymore.
2020-06-02 19:05:10 +02:00
b3c8d36412
DEV: Plugin api for adding extra header icons ( #9964 )
2020-06-02 11:39:12 -05:00
3e8d548d35
FIX: Prevent clipping user mentions ( #9962 )
2020-06-02 16:30:34 +02:00
d76ea9fa6b
FIX: Do not destroy $.fileupload element ( #9888 )
...
conditional-loading-section component rerendered the <input> element
and lost the necessary event handlers for jQuery-File-Upload.
2020-06-02 16:14:41 +10:00
ef3e3077d0
FIX: Staff users can bypass tag validation rule ( #9924 )
2020-06-02 16:11:25 +10:00
f9e715672b
DEV: makes autocomplete debounced ( #9941 )
...
* DEV: makes autocomplete debounced
* better wording
2020-06-02 15:20:14 +10:00
2a0a689442
UX: prevent devices from miscalculating fullscreen composer height
...
Fixes issue seen in some Chromebooks that flip between tablet and regular notebook window size
2020-06-01 22:24:16 -04:00
7e52106812
DEV: when synchornizing state pull tags
...
In some cases we may want topic tracking state to keep track of tags
this small change ensures we do not remove them if they are already in place
2020-06-02 11:42:00 +10:00
a95826f60c
Remove discourse constants ( #9958 )
...
* DEV: `Discourse.baseUri` does not exist
This never could have worked - should have been `Discourse.BaseUri` if
anything.
* DEV: Remove Discourse.Environment
* DEV: Remove `Discourse.disableMissingIconWarning`
* DEV: A bunch more missing environment checks
2020-06-01 16:33:43 -04:00
9162cd8f3d
FIX: Only render group card if user title is from group ( #9946 )
...
This was failing when a user with a primary_group chose to display a title coming from a badge.
2020-06-01 11:44:41 -07:00
b6709f0dda
DEV: Add option to only show icons to header widget ( #9935 )
2020-06-01 12:26:59 -05:00
0d6b638dac
FEATURE: New plugin outlet under badges page title ( #9936 )
2020-06-01 08:55:51 -07:00
e19d907f0f
FIX: Correct the misalignment of popover arrows ( #9947 )
...
* Fixes position of the top arrow, and border width of both
* Merged top and transform properties
* .5px values are required to make arrow border appear the same with as overall popover border width
I did have a chance to try it out on a Windows machine with a non-high DPI display and there were no issues. And I just re-tested it with Firefox on macOS using the "Open in Low Resolution" option and it looked more or less ok (bearing in mind that it the whole app is then a blurry mess, and that using custom zoom levels causes the arrow to break slightly, but that was also the case on Firefox before this change)
2020-06-01 16:31:53 +02:00
c2abf88a61
UX: Adjustments to topic admin menu on mobile ( #9945 )
2020-06-01 09:39:38 -04:00
921751f128
UX: Remove box-shadow from kbd, unify styling ( #9948 )
...
Having many elements with multiple box-shadows (e.g. in keyboard shortcuts modal) was tanking scrolling performance in some browsers.
2020-06-01 15:00:56 +02:00
ef8e44af73
FIX: Don't change the button height when spinner appears
...
on the exception page.
2020-06-01 14:15:41 +02:00
57e587f39f
DEV: removes dead code of dropdown-menu ( #9942 )
2020-06-01 11:22:35 +02:00
6ed3dbef03
UX: Fix border radius artifacts on dashboard pills ( #9949 )
2020-06-01 11:21:07 +02:00
40c4a8e3fc
DEV: skips/tweaks brittle tests ( #9952 )
2020-06-01 11:09:34 +02:00
82de9c5308
DEV: add countTags to topic tracking state
...
This introduces a new core API to get counts per tag from topic
tracking state
This API will only be useful if a plugin enable tags in topic
tracking state using
`TopicTrackingState.include_tags_in_report = true`
2020-06-01 17:05:24 +10:00
9ee77eae98
FIX: `z` helper doesn't resolve inside `calc`
...
It resulted in invalid `z-index: calc(z("tooltip") - 100)` in the output CSS. `calc` wasn't necessary here anyway since both operands are constant.
2020-06-01 05:50:50 +02:00
7bcee784c8
DEV: Remove an obsolete comment
...
Its first part was removed with other changes and this one got displaced after a `prettier` pass.
2020-06-01 05:50:49 +02:00
754a255ef7
UX: Remove the period after "Enable Notifications" button
2020-06-01 05:50:49 +02:00
7ac9a79ecb
UX: Fix inputs alignment in admin/customize/colors
2020-06-01 05:50:49 +02:00
f2647f1f36
UX: Position topic admin menu next to wrench ( #9932 )
2020-05-30 15:32:57 -04:00
e1af91f5ae
Revert "FEATURE: category setting for default list filter."
...
This reverts commit 6f03d14c23
2020-05-30 20:53:53 +05:30
93bd1ff228
FIX: topic-admin-popup-menu was overflowing on small screens ( #9944 )
2020-05-30 10:53:08 +02:00
530c6594cb
follow-up fix due to adding overflow hidden in 32e40ea
2020-05-29 22:23:23 -04:00
3c11c5dcdc
show-replies styles were lost with some menu changes
2020-05-29 22:05:58 -04:00
32e40ea133
UX: Make the menu links header within the user panel more flexible
2020-05-29 21:02:26 -04:00
8f59f155fb
UI: makes topic count less visible in category drop ( #9938 )
2020-05-30 00:32:20 +02:00
c5ccf5f93c
UI: removes font-weight: bold from category-drop names ( #9937 )
2020-05-30 00:06:35 +02:00
03c3448b15
UX: better alignment of icons in notifications menu ( #9934 )
2020-05-29 22:48:47 +02:00
7a76f3c295
UX: Relocate before-topic-list outlet so it shows up on Top as well
2020-05-30 03:31:28 +08:00
8e6d95a309
DEV: adds a few plugin outlets required for themes ( #9929 )
2020-05-30 03:04:12 +08:00
931bfca454
DEV: allows categories-admin-dropdown to have custom items ( #9931 )
...
Usage:
```
modifySelectKit("categories-admin-dropdown").appendContent(function() {
return {
id: "foo",
name: I18n.t("foo"),
description: I18n.t("foo_description"),
icon: "gear",
onChange: () => alert("Foo.")
};
});
```
2020-05-29 21:01:19 +02:00
2b2434b82d
Start Discourse in an initializer ( #9930 )
...
* DEV: To be pedantic, there is more than EMBER in there now
* DEV: Use less globals. Have `Discourse` start in an initializer
* DEV: Remove another global
2020-05-29 14:37:02 -04:00
3fe5eacd1b
DEV: Abstract `Ember.testing` so our application code doesn't use it
2020-05-29 12:16:58 -04:00
e5cd331fb3
DEV: Why use a whole object when a functionw will do?
2020-05-29 11:56:45 -04:00
5d792483f0
UI: various select-kit dropdown tweaks/cleaning ( #9922 )
2020-05-29 11:11:28 +02:00
d7d5bb4454
UX: homogenises sk row padding and topic-admin-menu ( #9920 )
2020-05-29 09:35:43 +02:00
4be45bec7e
UI: homogenise topic-footer-mobile-dropdown styles ( #9919 )
2020-05-29 08:34:19 +02:00
31d1468922
UX: reworks various menus to homogenize them ( #9905 )
...
- bookmark modal menu
- topic-footer-mobile-dropdown
- post-admin-menu
- topic-admin-menu
- quick-access menus
- toolbar-popup-menu
2020-05-29 08:05:21 +02:00
ef5320dd47
FIX: don't rerender whole users page while typing on input.
2020-05-29 09:06:26 +05:30
c7d75bc3a0
Minor adjustment to menu-links-header spacing to avoid some wrapping
2020-05-28 18:40:22 -04:00
ce1491e830
UX: remove `in:unpinned` filter from advanced search page. ( #9911 )
2020-05-29 00:47:28 +05:30
a98182debf
UX: Fix activity column display in wizard homepage step
...
Followup to f8f281cdad
2020-05-28 11:24:24 -04:00
2033c3ec9c
Revert "Revert "DEV: Import `MessageBus` from `message-bus-client` instead of globals""
...
This reverts commit b10e995d9d
2020-05-28 08:42:36 -04:00
0854785175
FIX: allows to define label/title properties for display instead of name
...
Usage:
```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];
{{combo-box
content=content
value=value
labelProperty="foo"
titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
ecc8e559ec
UX: remove edit PM button
...
Edit PM button leads to confusion and is uneeded
2020-05-28 15:15:27 +10:00
b9d9bbb95f
UX: More consistent alignment of topic timer's selected datetimes
2020-05-27 22:19:00 -04:00
9841569bba
Revert "DEV: Fix a deprecated `ember` import ( #9903 )"
...
This reverts commit 75f46ca632
2020-05-28 10:06:05 +10:00
b10e995d9d
Revert "DEV: Import `MessageBus` from `message-bus-client` instead of globals"
...
This reverts commit 9dddbcc00d
2020-05-27 16:14:09 -06:00
75f46ca632
DEV: Fix a deprecated `ember` import ( #9903 )
...
See the following for `Ember.testing` and `@ember/debug isTesting`:
* 8cf29959f7/packages/ember/index.js (L372-L376)8cf29959f7/packages/%40ember/debug/lib/testing.ts
2020-05-27 22:47:46 +02:00
9dddbcc00d
DEV: Import `MessageBus` from `message-bus-client` instead of globals
2020-05-27 16:42:42 -04:00
0f71d38d3a
Revert "DEV: Import `MessageBus` from `message-bus-client` instead of globals ( #9902 )"
...
This reverts commit d3bd482142
2020-05-27 16:34:30 -04:00
d3bd482142
DEV: Import `MessageBus` from `message-bus-client` instead of globals ( #9902 )
2020-05-27 15:56:46 -04:00
77801aa9be
FIX: allows to have custom emoji translation without static file ( #9893 )
2020-05-27 20:11:52 +02:00
207b72ade1
UX: Don't show the suspension date if the user is permantently suspended. ( #9895 )
...
Use the same pattern used in user.hbs
2020-05-27 14:50:17 -03:00
7bc496070f
UX: Keep focus on input after selecting an autocomplete option
...
This is particularly helpful on mobile, now tapping on an item from
the autocomplete dropdown keeps the keyboard visible.
2020-05-27 12:45:03 -04:00
68fdfd76f5
fix the build
2020-05-27 22:06:45 +05:30
8d2908dd9e
UX: do not show redundant user count
...
UX: add spacing between +member_count and "more"
2020-05-27 21:53:59 +05:30
461df7d050
UX: Rename Priority to score for sorting. ( #9846 )
2020-05-27 12:50:28 -03:00
f51093dde7
FIX: correctly set values and defaults for group-form-interaction-fields ( #9891 )
2020-05-27 12:10:27 +02:00
1cf2d1f9f2
FIX: when destroying a draft always ensure saving is done
...
There was a race condition where drafts could be either saving
or queued to be saved and a user canceled draft leading to destroying
it.
This cancels debounce save and waits for save in the pipeline to
be over prior to firing off a DELETE on the draft
2020-05-27 18:46:19 +10:00
f41fcad6c3
FIX: opening cancel draft dialog broke autosave
...
cancelComposer would leak a promise that never got resolved if
you aborted cancelling a composer.
This change ensured the promise will always be resolved
2020-05-27 18:16:48 +10:00
66ec634cb3
Composer whisper icon missing margin when editing replies
2020-05-26 19:17:09 -04:00
5f61deff80
FIX: updates variables for HTML to use `em` instead of `px` in font-size ( #9883 )
2020-05-26 17:48:35 -05:00
b1c726be0d
Remove support for FontAwesome 4.7 icon names ( #9871 )
2020-05-26 14:53:32 -04:00
7820686f73
FIX: Wizard previews if color step is excluded ( #9881 )
2020-05-26 12:56:36 -05:00
675e9b81c6
FIX: document.activeElement can be null on IE11 ( #9880 )
2020-05-26 16:51:55 +02:00
253a185769
FIX: makes focust text area after complete more resilient ( #9879 )
2020-05-26 16:27:02 +02:00
d9f915b195
FIX: documentation was using incorrect function ( #9876 )
2020-05-25 21:55:30 +02:00
be16205118
DEV: plugin api should have been bumped for #8825395 ( #9874 )
2020-05-25 21:44:15 +02:00
8825395bdc
DEV: allows to decorate username selector ( #9869 )
...
Usage:
```
api.addUsernameSelectorDecorator(username => {
return iconHTML("calendar-alt");
});
```
2020-05-25 19:09:55 +02:00
631024ae5d
FEATURE: Permalinks for tags
2020-05-25 14:51:01 +02:00
48fb354bce
PERF: avoid traversing DOM in loadScript
...
Once a script is loaded operation should be very fast.
This optimisation avoids a DOM traverse and call to getURL on
every invocation.
2020-05-25 18:19:59 +10:00
47c6fe9bfa
Merge branch 'master' of github.com:discourse/discourse
2020-05-25 11:36:18 +05:30
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
8e56197728
UX: use "icon-picker" & "image-uploader" fields to set group flair. ( #9779 )
2020-05-25 11:08:47 +05:30
6f03d14c23
FEATURE: category setting for default list filter.
2020-05-25 00:04:06 +05:30
058bf56b4c
FIX: group card not showing if user can't see its members.
2020-05-24 23:08:51 +05:30
60a3110113
FIX: call `getURL` method explicitly to prevent `this` context override.
2020-05-24 21:58:03 +05:30
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eeee62a85cf2660c2e203d26cd6
2020-05-23 00:56:13 -04:00
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f2660c2e21d
2020-05-22 20:25:56 -07:00
bf8085e436
FIX: Double Button Alignment Mobile ( #9862 )
2020-05-22 13:33:29 -05:00
06e1d430c1
FIX: better cross browser topic footer buttons alignment ( #9860 )
2020-05-22 17:03:22 +02:00
f9649c92b5
FIX: Live reloading of css in development ( #9859 )
2020-05-22 16:37:35 +02:00
793085c703
REFACTOR: slightly cleaner topic admin button css ( #9858 )
2020-05-22 15:23:17 +02:00
e71f5e8951
UI: apply margin only if the menu has content ( #9857 )
2020-05-22 15:19:55 +02:00
5a71c51ddd
FIX: tag input says tags are optional when they're required
2020-05-21 12:40:33 -04:00
1a5bcf2a64
UX: Remove live theme previewing in favor of refresh ( #9798 )
2020-05-21 08:32:50 -05:00
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
18959ff9da
UX: user name instead username for profile link title
2020-05-21 14:02:12 +05:30
3c9212fd88
UX: add title for user profile link
2020-05-21 13:00:05 +05:30
62ecb2885f
glob @import desktop and mobile scss
2020-05-20 18:05:27 -04:00
234933c781
FIX: Show staff counters if the rejected posts count is the only value to show ( #9845 )
2020-05-20 19:00:35 -03:00
eef47a26d9
UX: More consistent mobile banner/alert styles, css cleanup
2020-05-20 17:17:47 -04:00
ba04bb7552
FIX: Path should be `addon` not `app`
2020-05-20 12:13:15 -04:00
3062036f2f
FIX: Allow deprecation to work with Ember CLI
2020-05-20 12:05:56 -04:00
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
6c9c8dfefd
FIX: `guidFor` is not part of `Ember.Object`
2020-05-20 11:31:11 -04:00
bd57ae83f1
DEV: Guardian for hiding about stats ( #9841 )
2020-05-20 10:26:20 -05:00
30631a963f
UX: moves editFirstPost in taggable Pms in dropdown on mobile ( #9840 )
2020-05-20 14:07:00 +02:00
fb15da43da
Remove old web hooks in favor of 'reviewable' web hook ( #9776 )
...
* FIX: Emit web hooks for flags
* FEATURE: Remove 'flag' web hook in favor of 'reviewable' web hook
* FEATURE: Remove 'queued post' web hook in favor of 'reviewable' web hook
* FIX: Do not set a default value for web hooks with no events
2020-05-20 12:07:48 +03:00
e97cb20c2a
UX: strip text from PM bookmark and share buttons
...
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
2020-05-20 16:46:49 +10:00
a93d0a8fcc
UX: Remove bold from category badge text
2020-05-19 21:11:49 -04:00
52228b1fa6
DEV: These routes don't exist anymore ( #9823 )
2020-05-19 16:09:03 -03:00
a239900522
UI: reduces category row description margin ( #9834 )
2020-05-19 20:44:54 +02:00
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
1647ba4624
FIX: applies flex on topic-footer-main-buttons ( #9829 )
2020-05-19 11:29:38 +02:00
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
864fb45ff0
Improve mobile friendliness of crawler view
2020-05-19 00:24:17 -04:00
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
1876b3cc4c
FIX: more resilient/consistent date-picker loading ( #9817 )
2020-05-18 15:29:24 +02:00
48ed1b40cf
REFACTOR: ensures later is correctly canceled ( #9796 )
2020-05-18 14:20:23 +02:00
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
320b21ab5b
UX: allows dropdown-select-box to display a caret ( #9803 )
...
```
selectKitOptions: {
showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
e5dc843185
FIX: ensures hide is called when card is destroyed ( #9814 )
2020-05-18 10:10:40 +02:00
e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange ( #9801 )
2020-05-16 11:20:37 +02:00
db8e872bda
DEV: Move select kit to an addon ( #9797 )
2020-05-15 16:07:35 -04:00
7f07c513a7
FIX: Switching composer action does not refresh composer actions content ( #9791 )
2020-05-15 13:54:44 -04:00
6b04760572
FIX: Component was still used by data explorer
2020-05-15 13:52:03 -04:00
7edd312f85
UX: focus category name when editing category ( #9795 )
2020-05-15 18:27:06 +02:00
b07f1bfd93
FIX: displays a title on sk header if no selected name ( #9794 )
...
none has to be defined.
2020-05-15 17:36:00 +02:00
9810ca1dbd
UX: Add copied text upon copy button click ( #9793 )
2020-05-15 17:08:46 +02:00
d1146ccb7b
Revert "FIX: Correct plugin api version bump."
...
This reverts commit 6a96c424b7
2020-05-15 21:22:44 +08:00
6a96c424b7
FIX: Correct plugin api version bump.
...
It doesn't seem to be following semver.
2020-05-15 21:17:50 +08:00
162d125b83
Fix lint.
2020-05-15 20:23:17 +08:00
dada1fc417
UX: Better composer-action icon when creating new topic.
2020-05-15 16:40:49 +08:00
f9a9bd136b
FEATURE: Expose `Composer.serializeToTopic` in client side plugin api.
2020-05-15 16:16:58 +08:00
1a2b9435b0
DEV: Standardize table sorting verbiage ( #9757 )
...
* DEV: Standardize table sorting verbiage
This commit creates a common component that tables can use to make their
headers sortable. This commit also standardizes on using `desc` as the
default and passing in the `asc=true` flag to adjust the sorting
direction.
* Add deprecation warnings
Adds deprecation warnings if using previous params and maintains
backwards compatibility. Set the default sort value for group members to
be asc.
* switch group requests to use common table-header-toggle
* update fixture
2020-05-14 20:10:59 -06:00
869f9b20a2
PERF: Dematerialize topic_reply_count ( #9769 )
...
* PERF: Dematerialize topic_reply_count
It's only ever used for trust level promotions that run daily, or compared to 0. We don't need to track it on every post creation.
* UX: Add symbol in TL3 report if topic reply count is capped
* DEV: Drop user_stats.topic_reply_count column
2020-05-14 15:42:00 -07:00
e0e967ac46
FIX: Apply code quoting with no syntax highlighting ( #9784 )
2020-05-14 13:03:42 -07:00
bec6bace53
DEV: Allow plugins to hide user stats by new guardian method ( #9772 )
2020-05-14 11:57:35 -05:00
87b9488137
UX: Limit iOS modal keyboard changes to composer
...
Followup to 423802fbc
2020-05-14 12:48:28 -04:00
aa2d040526
DEV: Update ESLint to remove I18n global
...
Also fixes missed imports in core.
2020-05-14 10:18:12 -04:00
42e5a5bb39
DEV: do not append/prepend if callback returns nothing ( #9778 )
2020-05-14 14:38:03 +02:00
9a18bacbe3
DEV: Fix lint.
2020-05-14 16:10:51 +08:00
a1a798ac7d
DEV: Expose `Composer.serializeOnUpdate` in client side plugin api.
...
Also expose `Composer.serializeOnCreate` as well.
2020-05-14 16:06:29 +08:00
fdea969f14
DEV: Minor follow up to d7e230c1b9
2020-05-14 16:02:54 +08:00
95a80525ae
DEV: Remove erroneous code introduced in d7e230c1b9
2020-05-14 15:58:44 +08:00
d7e230c1b9
UX: Introduce composer-actions when editing a post.
2020-05-14 15:56:08 +08:00
c014b93854
UX: don't disable "create account" button & display error message for required fields. ( #9643 )
2020-05-14 12:15:33 +05:30
3d050bdaa3
DEV: correct test suite
...
We have no choice but to bypass recursive debouncers in test
Otherwise we overrun the stack with frames
2020-05-14 16:41:34 +10:00
ce4b5b56e5
FIX: never save draft while it is saving
...
Previously if saving a draft took longer than 2 seconds there
could be conditions where drafts could be saved concurrently.
This meant the composer could race with itself and raise conflicts.
This is likely to happen on bad internet connections or where
latency is really high.
Additionally a throttle was added so drafts save unconditionally
every 15 seconds.
Save draft in the model now properly and consistently returns a
promise.
2020-05-14 15:36:18 +10:00
ad7c964cd1
FIX: Prevent Safari from scrolling when closing composer
...
Unlike other browsers, Safari maintains focus on elements even when
they are hidden. And since the composer is fixed-positioned when hidden,
closing the composer on a topic with several replies causes Safari to
scroll the window up.
Deliberately blurring the focused element fixes the issue.
2020-05-13 21:24:40 -04:00
eab560fe2a
DEV: import I18n instead of global usage ( #9768 )
...
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
2020-05-13 16:23:41 -04:00
3d54f497db
DEV: add classes to li's inside user navigation ( #9766 )
2020-05-13 12:22:14 -05:00
c405b15914
DEV: Add plugin outlet `revision-user-details-after`.
2020-05-13 15:40:37 +08:00
a64cf265fd
FIX: Change /bookmarks URL back to topic list and add bookmark poster avatars ( #9759 )
...
* Changes the /bookmarks URL to show the original "topics filtered by bookmark" list instead of redirecting to user activity bookmarks (see https://meta.discourse.org/t/domain-com-bookmarks-is-showing-domain-com-u-user-activity-bookmarks-with-reminders/149252/12 )
* Add the user avatar for the user who made the post that is bookmarked
2020-05-13 14:03:24 +10:00
811bc3544f
prettier
2020-05-12 23:12:46 -04:00
822e594fc8
UX: Improve display of site setting validation message.
...
Previously, the validation message is shown inline with the label which
leads to the available width for both element being reduced.
2020-05-13 11:10:08 +08:00
765e842101
UX: remove underline from del & ins elements
2020-05-12 22:51:28 -04:00
d9f5499f3a
Revert "Revert "DEV: Remove `Discourse.Route`""
...
This reverts commit b4d27d327d
2020-05-12 14:15:07 -04:00
9bce91f59f
DEV: Allow plugins to add extra icons to category-link ( #9743 )
2020-05-12 09:41:16 -05:00
16137308b0
FIX: Show Settings button if plugin has settings ( #9728 )
...
It used to check if the plugin has an enabled_setting.
2020-05-12 11:18:19 +03:00
39a2d90e0f
DEV: Pass currentUser to post-menu button builders ( #9752 )
...
Adding this from a review; I was using Discourse.currentUser which is frowned upon now.
Passing currentUser both for regular post menu buttons and extra buttons attached via the plugin API.
Lots of formatting/whitespace changes, best off reviewing with ?w=1
2020-05-12 14:09:38 +10:00
a009ec597d
remove ember container div
2020-05-11 21:12:33 -04:00
6f228b0312
FIX: Remove unnecessary forward slashes in regex
2020-05-11 17:55:44 -07:00
7cdf41d311
DEV: Remove reference to Discourse.Category
2020-05-11 18:28:45 -04:00
e744b9efec
FIX: add tabindex=-1 on tabLoc post links
...
This prevents tabbing from confusing screenreaders, as having default tabindex
with aria-hidden confuses screenreaders
2020-05-11 14:43:12 -07:00
90b900704b
FIX: Improve mobile footer nav accessibility
2020-05-11 16:55:34 -04:00
b4d27d327d
Revert "DEV: Remove `Discourse.Route`"
...
This reverts commit eed7983404
2020-05-11 16:50:53 -04:00
22af44ac49
DEV: Remove `Discourse.Mobile`
2020-05-11 16:13:29 -04:00
eed7983404
DEV: Remove `Discourse.Route`
2020-05-11 16:11:33 -04:00
74db317974
DEV: Remove deprecation for `Discourse.Category`
2020-05-11 16:10:21 -04:00
286b4e535e
DEV: allows buttons to define aria-label ( #9747 )
2020-05-11 22:09:44 +02:00
b4bd238dd6
DEV: Add safe deprecation to `Discourse.User`
2020-05-11 16:08:12 -04:00
46730a2f0d
DEV: Allow us to keep the deprecation with Ember CLI
2020-05-11 16:06:06 -04:00
4c17ff98fa
DEV: Remove deprecation for `Discourse.Session`
2020-05-11 15:51:10 -04:00
8311374a5a
DEV: Replace `version.js.erb` with pre generated file
2020-05-11 15:43:09 -04:00
d2b16a7618
DEV: Generate `emoji/data` on demand ( #9744 )
...
These emoji rarely change and can be re-generated when we make changes
to them.
2020-05-11 15:29:46 -04:00
af6e61defd
FIX: sets a title for notifications button ( #9745 )
2020-05-11 20:46:08 +02:00
5a073c6a0a
Revert "FIX: title should attempt to fallback to label before name ( #9739 )"
...
This reverts commit c6bf552ca3
2020-05-11 20:09:11 +02:00
141f16eb6b
FIX: Multiple schema.org improvements
...
* Do not show "Uncategorized" category in topics list.
* Use "BreadcrumbList" only if topic is in a category.
* Add tags list as keywords to the first post.
* Add "dateModified" even if it is the same with "datePublished".
* Show "crawler-linkback-list" only if there are links to be shown.
2020-05-11 20:38:49 +03:00
0deb05740f
Revert "DEV: allows to define an ariaLabel on d-button ( #9716 )"
...
This reverts commit 7a95dd4841
2020-05-11 19:19:13 +02:00
7a95dd4841
DEV: allows to define an ariaLabel on d-button ( #9716 )
...
* DEV: allows to define an ariaLabel on d-button
This topic also adds this function to topic-footer-buttons, simplifies the whole logic of titile/label/arialabel in d-button and adds tests for these properties.
* typo
2020-05-11 18:42:51 +02:00
c6bf552ca3
FIX: title should attempt to fallback to label before name ( #9739 )
2020-05-11 18:42:18 +02:00
7d3c4a5f13
FIX: Show category name in badge preview on edit ( #9726 )
2020-05-11 17:05:40 +02:00
a2bb33b6d7
REFACTOR: Remove an unused Topic model observer ( #9723 )
...
As far I can tell nothing sets categoryName on the Topic model. Didn't find anything in all-the-plugins/all-the-themes either.
2020-05-11 17:05:05 +02:00
89c6f697b8
DEV: Plugin outlet after save or cancel composer buttons ( #9725 )
2020-05-11 09:23:36 -05:00
77f5bb1419
FIX: stop clearing title by mistake
...
b180e6e737
2020-05-11 19:07:32 +10:00
a3a464b838
DEV: Improve description of addPosterIcon plugin api.
2020-05-11 16:44:47 +08:00
b180e6e737
FIX: default to blank title on open
...
In production `title` was set to undefined causing a
discrepancy between originalTitle and title
This attempts to work around the issue in the production bundle
2020-05-11 18:36:09 +10:00
29842e682b
FIX: Resolve issues with Next Monday for bookmarks not working in certain locales ( #9737 )
...
In moment.js the .day() function can accept a day string but this is locale based, so e.g. in Finnish locale the string "Monday" means nothing and will parse incorrectly to Sunday. To resolve this we always use the moment.js number for the day of the week we want.
2020-05-11 13:59:14 +10:00
12d4d51d81
FIX: CurrentUser now must be passed to resolveTimezone and user card local time issues ( #9734 )
...
* This is to prevent user's timezones being changed accidentally
e.g. by admin looking at a user
* This problem only occurred via the user card, however the user card
was still calling userTimezone even if the setting to display user
time in card was disabled
2020-05-11 11:01:47 +10:00
44712c5f98
FIX: ESC to dismiss empty draft topic composer
...
Previously originalTitle was set to undefined leading to
titleDirty being unconditionally undefined for new topics
That mean you could not dismiss the composer via ESC
2020-05-11 10:04:38 +10:00
8149bfbaf1
FEATURE: Filter settings by plugin ( #9692 )
2020-05-10 14:07:45 +03:00
3b2b635e9b
DEV: removes setInterval as it might cause issues ( #9722 )
2020-05-10 08:57:48 +02:00
862d153f54
REFACTOR: removes dead code ( #9721 )
2020-05-09 11:50:47 +02:00
9bf11a8c68
DEV: allows select-kit to prevent autofocus of header after onChange ( #9718 )
2020-05-09 10:26:23 +02:00
d653d2f5d9
UX: Prevent timeline overlapping topic footer buttons
2020-05-08 16:20:27 -04:00
34e5f807ec
DEV: User UPPER_CASE for constants
2020-05-08 15:50:55 -04:00
da561a430d
DEV: Add data-name to popular-theme-item rows ( #9714 )
2020-05-08 14:38:41 -05:00
5bac2828ee
DEV: 25ms was too short and causing test failures ( #9712 )
2020-05-08 21:10:52 +02:00
7f373e8b93
DEV: Don't use `js.erb` for constants
...
Adds a new rake task to auto generate a constants.js file with the
constants present. This makes migrating to Ember CLI easier, but also
slightly speeds up asset compilation by having to do less work.
If the constants change you need to run:
`rake javascripts:update_constants`
2020-05-08 14:14:01 -04:00
47788da706
FIX: Bookmark Modal Input ( #9707 )
2020-05-08 17:47:01 +02:00
350fe932ca
DEV: removes setTimeout and reduces timer in tests ( #9701 )
2020-05-08 16:46:24 +02:00
646bee2efe
DEV: removes a setTimeout and ensure shorcut is not propagated ( #9702 )
2020-05-08 16:46:13 +02:00
e46bf15407
FIX: some adjustment for the UI of the table
2020-05-08 16:39:31 +02:00
8d3900c6da
DEV: gear icon is deprecated in favor of cog ( #9704 )
2020-05-08 10:35:29 +02:00
00a038d646
REFACTOR: removes various assignments and superfluous params ( #9699 )
2020-05-08 09:19:48 +02:00
9d172eeaa5
REFACTOR: removes implicit operand conversion ( #9700 )
2020-05-08 09:19:36 +02:00
1840023c28
UX: Improve banner & alert close button alignment and consistency
2020-05-07 22:57:52 -04:00
ef94b0f1a7
FIX: Incorrect CSS class
2020-05-07 16:29:09 -04:00
94d10b46ca
Admin popup menu needs a higher z-index than the bg cloak on mobile
2020-05-07 16:24:47 -04:00
f9608c0af5
DEV: Remove INLINE_ONEBOX_* constants
...
There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and
`INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they
were DRYing up: `inline-onebox-loading` and `inline-onebox`
I normally appreciate constants, but in this case it meant that we had
a lot of JS imports resulting in many more lines of code (and CPU cycles
spent figuring them out.)
It also meant we had an `.erb` file and had to invoke Ruby to create the
JS file, which meant the app was harder to port to Ember CLI.
I removed the constants. It's less DRY but faster and simpler, and
arguably the loss of DRYness is not significant as you can still search
for the `inline-onebox-loading` and `inline-onebox` strings easily if
you are refactoring.
2020-05-07 16:14:38 -04:00
3567a90661
DEV: Ember Addon needs a vendor dir
2020-05-07 15:45:35 -04:00
4891276742
Reduce the width of the input field on desktop
2020-05-07 20:36:36 +02:00
788e305469
FIX: parenthesis were wrong, resulting in an always true expression ( #9690 )
2020-05-07 19:56:35 +02:00
79c64eaeff
DEV: Move pretty-text into an ember-addon format ( #9689 )
2020-05-07 12:37:47 -04:00
3cd412ae02
REFACTOR: removes useless variable assignment ( #9666 )
2020-05-07 16:41:26 +02:00
1dd9df9cd0
REFACTOR: removes overwritten properties and duplicates fn ( #9686 )
2020-05-07 16:39:53 +02:00
265baa40c6
REFACTOR: useless conditional as 'data' always evaluates to true ( #9685 )
2020-05-07 16:38:38 +02:00
99c3ce03cb
REFACTOR: removes superfluous argument ( #9684 )
...
hideTooltip doesnt accept any argument
2020-05-07 16:38:23 +02:00
206d45fd96
REFACTOR: removes superfluous argument ( #9683 )
2020-05-07 16:38:09 +02:00
9846c43d93
REFACTOR: removes use of undeclared variable ( #9682 )
2020-05-07 16:37:56 +02:00
af78d188b8
REFACTOR: removes useless self assignment ( #9681 )
2020-05-07 16:37:20 +02:00
8be0ba3aa4
REFACTOR: function was incorrectly called as a constructor ( #9679 )
2020-05-07 16:36:29 +02:00
e74170cd9e
REFACTOR: Superfluous arguments passed to function resolveSize ( #9678 )
...
resolveSize accepts only one param
2020-05-07 16:36:15 +02:00
affc79bb68
REFACTOR: removes useless assignment to local variable ( #9676 )
2020-05-07 16:35:54 +02:00
08e8ae82cc
REFACTOR: removes useless conditional ( #9677 )
2020-05-07 16:34:49 +02:00
a078b086ba
REFACToR: removes useless assignment to local variable ( #9675 )
2020-05-07 16:34:36 +02:00
a04b226c2b
REFACTOR: removes useless conditional ( #9674 )
...
We already check if there's a post in the line before.
2020-05-07 16:34:25 +02:00
d5fe1279bd
REFACTOR: value assigned to precision here is unused ( #9673 )
2020-05-07 16:34:14 +02:00
a2109bd9b2
REFACTOR: value assigned to cp here is unused. ( #9672 )
2020-05-07 16:30:51 +02:00
930989d462
REFACTOR: variable '_postSnapshot' always evaluates to true ( #9671 )
2020-05-07 16:28:28 +02:00
Mark VanLandingham
Bianca Nenciu
jjaffeux
Krzysztof Kotlarek
Martin Brennan
Dan Ungureanu
Kris
Jarek Radosz
Joe
David Taylor
Régis Hanol
Sam Saffron
Ahmed Gagan
Robin Ward
Roman Rizzi
Martin Brennan
Penar Musaraj
Jeff Wong
Faizaan Gagan
Guo Xiang Tan
tshenry
Samuel Carvalho Santos
spirobel
Arpit Jalan
Vinoth Kannan
Rafael dos Santos Silva
Gerhard Schlager
Kane York
Blake Erickson
Jordan Vidrine
Michael Brown
Jeff Atwood
Neil Lalonde
Justin DiRose
Dax74