bd35a8f334
FIX: ensures spinner is showing on tags/show when loading more ( #7876 )
...
Context: https://meta.discourse.org/t/issue-while-scrolling-down-after-selecting-a-tag-on-the-home-page/122542
2019-07-10 21:37:31 +02:00
142344e45d
FIX: ensures routing with hash doesn't stuck history ( #7872 )
...
* FIX: ensures routin with hash doesnt stuck history
Original issue: https://meta.discourse.org/t/hash-anchor-in-url-prevents-further-url-updates/122068/4
Basically when the path has a hash, state would be null, and nothing would happen.
* Update app/assets/javascripts/discourse/lib/discourse-location.js.es6
Co-Authored-By: Régis Hanol <regis@hanol.fr>
2019-07-10 20:43:03 +02:00
f89bd55576
Revert "FEATURE: admin/user exports are compressed using the zip format ( #7784 )"
...
This reverts commit 8b2580e20f
2019-07-10 11:38:51 -03:00
90fcdad3cd
UX: Discard selected post if it is not in viewport. ( #7869 )
...
This way, users can combine keyboard shortcuts with mouse scrolling.
2019-07-10 10:22:09 -04:00
8b2580e20f
FEATURE: admin/user exports are compressed using the zip format ( #7784 )
...
* FEATURE: admin/user exports are compressed using the zip format
* Update translations. Theme exporter now exports .zip file. Theme importer supports .zip and .gz files
* Fix controller test, updated locale and skip saving the csv export to disk
2019-07-10 11:13:03 -03:00
629bb8adf2
SECURITY: XSS with title selector on preferences page
...
Note this is very low severity as the group needs to be created with a
default title that contains HTML, and group creation is restricted to
staff members right now.
2019-07-09 15:49:24 -04:00
6e22499e5f
Remove unused file resubscribe.html.erb
2019-07-09 15:17:33 -04:00
a65a9a85d5
FEATURE: Remap uploads during restore when S3 or CDN changes
...
In order for this to work the Backuper stores a couple of site settings
in the new backup_metadata table, because the old setting values might
not be available on restore anymore.
2019-07-09 14:04:16 +02:00
9f5cfa192e
FEATURE: Allow Markdown in post notices. ( #7864 )
2019-07-09 14:42:02 +03:00
f4dc6de9f1
FIX: Clear theme editor content on switching tabs
...
Issue happens when sending a null value to ACE Editor.
Fixed by sending an empty string to ACE instead of null.
2019-07-08 20:06:56 -04:00
324e182842
FEATURE: show login and signup button on no-ember layout ( #7867 )
2019-07-09 04:51:19 +05:30
7b0517895e
FEATURE: Add "Group owners" to posting options for groups
...
Context: https://meta.discourse.org/t/121589
This new setting option lets group owners message/mention large groups
without granting that privilege to all members.
2019-07-08 17:14:11 -04:00
b690fc3d98
FEATURE: Add new group visibility option for "logged on users" ( #7814 )
...
Groups can now be marked as visible to "logged on users". All automatic groups (except `everyone`) are now visible to "logged on users", previously they were marked as public but suppressed in the group page for non-staff.
2019-07-08 15:09:50 -04:00
bb8cf81089
Bump onebox version.
...
- better placeholders for audio/video/trello/typeform oneboxes
- added CSS for audio/video/trello/typeform onebox placeholders
2019-07-08 21:40:33 +05:30
e49b5fa30c
UX: expand-post button alignment fix ( #7865 )
2019-07-08 14:36:15 +08:00
2cd4e95d82
FIX: show category name in title for crawler view
...
Show category name in title for crawler view despite presence of `short_site_description`.
Bug reported here: https://meta.discourse.org/t/short-site-description-break-category-title-for-crawler-or-its-the-expected-behavior/122109/
2019-07-08 11:42:39 +05:30
3132a9007b
FIX: Use correct timezone for manual SQL
2019-07-06 15:14:07 -04:00
a075fd46fd
FIX: Don't use exceptions to catch conflicts
...
If a database exception is raised ActiveRecord will always rollback
even if caught.
Instead we build the query in manual SQL and DO NOTHING when there's a
conflict. If we detect nothing was done, perform an update.
2019-07-06 14:43:56 -04:00
a9982b5aa2
UX: Make default site logo height an even 40px
2019-07-05 23:46:43 -04:00
de6edf9e4e
FIX: Back button would go to previous topic instead of list
...
See related topic:
https://meta.discourse.org/t/back-button-history-not-properly-working/122183
The issue here is the transition was not completing properly which meant
if you backed out of a topic quickly and entered a new one, hitting back
in the second topic would sometimes take you to the previous one instead
of back to the topic list.
2019-07-05 15:53:14 -04:00
66214eee85
SECURITY: Strip HTML from invite emails
...
We also strip new lines from the emails because it ruins the markdown
formatting which expects a one line message.
2019-07-05 14:57:11 -04:00
155cad8b85
FIX: only add image size when with & height are in pixels
2019-07-05 20:34:11 +02:00
589351d996
UX: Give badge icons width to accommodate for dimensionless SVGs
2019-07-05 12:37:18 -04:00
7c130990e9
FIX: IE grid layout issue on user's own activity page
2019-07-05 12:05:58 -04:00
5494e17c71
UX: improve twitter status onebox with line breaks
2019-07-05 20:37:08 +05:30
5bc1fd23b0
Bump onebox version.
...
- update HTML for twitter quoted onebox
- updated CSS for twitter quoted onebox
2019-07-05 19:35:36 +05:30
bd084b2147
FIX: do not show invite button if local logins are disabled
2019-07-05 15:16:20 +05:30
f140c4d499
FIX: ensures routing to / with query string works ( #7859 )
2019-07-05 09:40:19 +02:00
1bb258ab49
DEV: use upload short-url in html to markdown conversion if 'base62-sha1' data attr available.
2019-07-05 10:06:41 +05:30
1318e0b288
FEATURE: Rake themes installer ( #7848 )
...
* Delete remote_theme when deleting the theme
* Install themes and theme components through rake
* Removed unnecessary test
2019-07-04 14:33:05 -04:00
72bac61c90
FIX: Upsert a custom field if a unique constraint fails
2019-07-04 13:26:25 -04:00
c78634284c
UI: when in a different topic context, allow dismissing draft without destroying it
...
This changes the label and behaviour of the "No, keep" button in the confirmation modal when user cancels a draft while on a different topic. The new button label is "No, save draft", and when clicked, the composer will be dismissed without destroying the draft.
2019-07-04 11:45:57 -04:00
03805e5a76
FIX: Ensure lightbox image download has correct content disposition in S3 ( #7845 )
2019-07-04 11:32:51 -04:00
c5625b70f1
FIX: Prevent emoji-picker from not showing ( #7856 )
...
If an external plugin inserts an element with class "emoji-picker", something probable if they extend EmojiPicker, it could cause troubles as css is added depending on the emoji-picker height. Just by adding a class of a parent <div> as could be d-editor, we prevent this from happening.
2019-07-04 11:46:21 +02:00
a5e80079d6
FEATURE: Add Belarusian language
2019-07-04 11:37:37 +02:00
2063d20e9a
Revert "DEV: Let OmniAuth strategies return auth result. ( #7833 )"
...
This reverts commit dc5eb76551
2019-07-04 10:06:18 +01:00
71bf9ec1b2
FEATURE: opt-in guidance on topics for users without access ( #7852 )
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
Co-Authored-By: Robin Ward <robin.ward@gmail.com>
2019-07-04 10:12:39 +02:00
5fdf228db6
FIX: Respect the full_screen_login parameter from plugin auth providers ( #7855 )
...
This behavior was regressed in 427979e7e5
2019-07-04 09:06:29 +01:00
1708be4f27
FEATURE: support query params when redirecting to internal link on login ( #7829 )
2019-07-04 11:11:43 +05:30
0f813fc7c7
DEV: Remove reference to non-existent `letter_proxy` route
...
This was introduced in f04471e422
2019-07-03 23:48:32 +01:00
459932f4e2
FIX: Use title attribute for notification items. ( #7840 )
2019-07-03 10:48:13 -04:00
f3c9dbcf20
UX: Add styling for quoted tweets ( #7832 )
2019-07-03 10:34:46 -04:00
9ca1bbe900
Revert "FIX: remove misplaced save button"
...
This reverts commit 4f468ef210
2019-07-03 10:56:08 -03:00
f9f1df7611
DEV: prevents reports key to be time dependant when testing ( #7850 )
2019-07-03 15:43:01 +02:00
4f468ef210
FIX: remove misplaced save button
2019-07-03 10:39:01 -03:00
bfdf740a05
FIX: Show 'Export' button for all tabular reports. ( #7838 )
2019-07-03 14:47:36 +02:00
426c8045de
FIX: logs for enabling/disabling components should show up in the staff actions logs
2019-07-03 12:33:25 +00:00
3d64532273
FEATURE: allow disabling theme components ( #7812 )
...
This allows you to temporarily disable components without having to remove them from a theme.
This feature is very handy when doing quick fix engineering.
2019-07-03 18:18:11 +10:00
ecf0215ee7
DEV: resets page tracking state between tests ( #7847 )
2019-07-03 10:08:05 +02:00
9ee2c121c1
FIX: ensures emoji helper is working with custom emojis ( #7843 )
2019-07-03 09:23:40 +02:00
0733ed3a2b
FIX: ensures /t/TOPIC_ID/POST_NUMBER is correctly routing ( #7841 )
2019-07-03 09:23:23 +02:00
6e3e0685fb
DEV: add useBlockMode option for toolbar button text selection
...
Allows buttons to switch selection to block mode if needed.
2019-07-02 18:02:40 -04:00
c422520b4a
FEATURE: Add CSS classes to associated accounts rows
2019-07-02 16:56:15 -03:00
72441e2c7c
FIX: page starts at 1 ( #7844 )
2019-07-02 17:26:23 +02:00
8404921b91
FIX: Remove misplaced outlet
2019-07-02 11:26:40 -03:00
ccb3ba509d
FIX: creating new badge is failing on empty SQL query ( #7837 )
2019-07-02 15:12:53 +05:30
1b45096aa5
UX: improves styling of similar topics results in composer ( #7839 )
2019-07-02 11:26:43 +02:00
fca2f0f212
FIX: Only show remove timer button to users with permission to do so
2019-07-01 22:17:02 -04:00
f1c67729de
Different fix ( #7815 )
2019-07-02 11:53:16 +10:00
4dcc5f16f1
FEATURE: when under extreme load disable search
...
The global setting disable_search_queue_threshold
(DISCOURSE_DISABLE_SEARCH_QUEUE_THRESHOLD) which default to 1 second was
added.
This protection ensures that when the application is unable to keep up with
requests it will simply turn off search till it is not backed up.
To disable this protection set this to 0.
2019-07-02 11:22:01 +10:00
dc5eb76551
DEV: Let OmniAuth strategies return auth result. ( #7833 )
2019-07-01 13:13:11 -03:00
f56d86a852
FIX: use normal title instead of fancy title for prefilled composer
2019-07-01 17:55:24 +05:30
7b52a110b8
DEV: removes DOMTokenList polyfill ( #7831 )
...
Creates more issues than it solves especially on IOS, I dont trust it anymore. Will reconsider if this is an issue in the future.
2019-07-01 14:08:38 +02:00
d513c28e3b
FIX: Don't send notification email when user isn't allowed to see topic
2019-07-01 14:03:03 +02:00
997250586c
FEATURE: prefill title for direct messages from topic
...
https://meta.discourse.org/t/default-re-title-title-for-direct-messages-from-topic/121413
2019-07-01 17:14:08 +05:30
af58049eeb
UX: puts tags and categories on same line in search-menu-results ( #7830 )
2019-07-01 13:11:43 +02:00
384f5cea05
FIX: ensures static pages are using absolute path ( #7828 )
2019-07-01 11:25:45 +02:00
11ae5c78db
FEATURE: adds infite scroll on admin users list page ( #7821 )
2019-07-01 11:00:06 +02:00
4f97f85178
DEV: Fix lint. ( #7824 )
2019-06-28 20:24:09 +02:00
aa9b9e1930
UX: improved mobile positioning of topic timer remove button
2019-06-28 14:09:42 -04:00
5bab4f8007
UX: gives each info its own line in search-menu-results ( #7825 )
2019-06-28 11:14:38 +02:00
61438c825a
fix prettier ( #7823 )
2019-06-28 09:36:38 +02:00
b2eb0f4ad6
FEATURE: Export any type of report supporting table mode. ( #7662 )
2019-06-28 08:50:31 +02:00
82f2af8a0d
UX: Move link to show tracked topics, simplify translation
2019-06-27 21:36:24 -04:00
27387b0859
Do not collapse quote notifications
...
This prevents an issue where edits to a post with a quote would trigger push notifications indefinitely.
2019-06-27 18:20:43 -04:00
4ba35472e6
Don't check for second factor when switching to anonymous account ( #7803 )
2019-06-27 15:01:26 -07:00
a61147d838
FEATURE: displays tags in search menu results when enabled ( #7819 )
2019-06-27 19:26:14 +02:00
ed936bcb01
FIX: Fix a navigation bug
...
To reproduce:
1. Visit a url in a new tab such as `/latest?order=views`
2. Click a topic link
3. Click the back button
Before this patch, you would not be sent back to the latest list.
Now, I am somewhat hesitant to delete code like this, but the [original
commit](b2b7f4d905
2019-06-27 09:06:10 -04:00
fe870a1e54
DEV: Respond with error 400 to uploads requested via XHR
...
follow-up to 13f38055
2019-06-27 11:15:35 +02:00
8f7a387aa7
FEATURE: add support for tag group search
...
The behaviour of #TERM in search has been amended
1. We try category or subcategory slugs
2. We try tags
3. We try tag-groups
The term `hello #my-group` will search for all posts tagged with any of
the tags in the tag group `My Group`
Future work may be introducing a slug cache here or caching it in the table
but the assumption is that the number of tag groups will not be huge
2019-06-27 17:53:26 +10:00
9a2eb5c8cb
UX: change icon for video placeholder
2019-06-27 12:27:14 +05:30
5bc5c02af6
FIX: mark topics in sub categories as unread when dismissing parent
...
Previously we would only dismiss the parent category and leave the
child categories unread
2019-06-27 13:26:48 +10:00
88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
50e4ecc77e
UX: hide post is unread tooltip after the post is read ( #7813 )
...
Note we can't use `display: none` here because it doesn't work with
animations.
2019-06-26 22:39:57 +03:00
a3bcb8e887
UX: make onebox video placeholder icon grey
2019-06-26 23:40:36 +05:30
168a38dc29
Bump onebox version.
...
- better Twitch placeholder
- CSS for said placeholder
2019-06-26 23:22:29 +05:30
817661aed9
UX: Require a confirmation if approving a post in a closed topic
2019-06-26 12:21:49 -04:00
14a64e7c4c
Move "Hide Post" option up to the top on the review interface
...
If you agree with the post you are likely to want to hide it.
2019-06-26 11:35:59 -04:00
eedec7d79b
FIX: Only include pending/agreed scores in the total score
...
This should prevent posts from being hidden if a previous flag was
rejected and a new one was added.
2019-06-26 11:21:35 -04:00
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
56b76f31dc
fix prettier linting ( #7809 )
2019-06-26 15:26:02 +02:00
dfde59f631
FIX: provides an emoji helper to replace codes by images ( #7802 )
2019-06-26 15:11:04 +02:00
65a6e2c860
Change Widget#attach signature
...
Take a fallback option instead of a list of names
2019-06-26 09:01:25 -04:00
37b8f5d989
Use dasherize instead of replace
2019-06-26 09:01:25 -04:00
d025e188e8
Make the linter happy
2019-06-26 09:01:25 -04:00
70e27641eb
Pass data to description to prevent duplication
2019-06-26 09:01:25 -04:00
8c349101c5
Pass data to text method to prevent duplication
2019-06-26 09:01:25 -04:00
86d5208b31
Pass data to url method to avoid duplication
2019-06-26 09:01:25 -04:00
ac6f7b3625
Remove notificationType argument from text
2019-06-26 09:01:25 -04:00
a3254b8446
Pull invitee accepted notification behaviour into its own class
2019-06-26 09:01:25 -04:00
7c52ba1431
Pull liked consolidated notification behaviour into its own class
2019-06-26 09:01:25 -04:00
42143a874e
Pull custom notification behaviour into its own class
2019-06-26 09:01:25 -04:00
305562bf66
Pull title logic into its own method
2019-06-26 09:01:25 -04:00
d83147d137
Rename "title" variable to more apt "description"
2019-06-26 09:01:25 -04:00
02deaa4bc6
Pull icon choosing into its own method
2019-06-26 09:01:25 -04:00
36d7abed0b
Pull group message summary behaviour into its own class
2019-06-26 09:01:25 -04:00
396e13aaa7
Pull liked notification behaviour in its own class
2019-06-26 09:01:25 -04:00
bd062fcbef
Export DefaultNotificationItem
2019-06-26 09:01:25 -04:00
04a75b1cb3
Change the way notification items are created
...
Look for the specialised version first, before falling back to the
default. This allows the behaviour to be customised based on the type of
notification.
2019-06-26 09:01:25 -04:00
cdf0cd3ecd
`createWidgetFrom` creates a new widget with an arbitrary base class
2019-06-26 09:01:25 -04:00
01a7fd4225
Make `attach` optionally take a list of widget names to try
2019-06-26 09:01:25 -04:00
41129f933d
Rename notification-item to default-notification-item
2019-06-26 09:01:25 -04:00
7e70db3fb7
s/notName/notificationName/g
2019-06-26 09:01:25 -04:00
7c9d62c280
FIX: prevents failure when TL was mutated on internal object ( #7808 )
2019-06-26 14:51:45 +02:00
01de7e1444
FIX: calling action with a string is deprecated ( #7807 )
2019-06-26 12:42:46 +02:00
e64544ae44
icon s/trash/trash-alt ( #7806 )
2019-06-26 12:31:49 +02:00
ea2a9bc4fc
FIX: closes search-menu on escape ( #7804 )
2019-06-26 11:53:39 +02:00
2af4002817
Bump onebox version.
...
- Add a placeholder icon for Twitch onebox preview
- Add CSS for showing fontawesome play icon for placeholder class
2019-06-26 13:40:14 +05:30
333b5a19b2
FIX: do not include uncategorized_category_id in `topic_create_allowed` if posting in uncategorized is disabled
...
Previously users were still allowed to create topic via API even if
uncategorized was disabled.
Not 100% happy with all this special casing, but I guess we have to do
something.
This also splits up a mega spec now that we have fab! into a more easy to
understand structure (I hope)
2019-06-26 17:41:07 +10:00
2eece2c41b
UX: add shortcut for deferring topics ( #7798 )
2019-06-25 07:20:55 +03:00
afb5ec811d
FIX: Don't use DistributedCache to store redis readonly state
...
This can cause unbound CPU usage in some cases, and excessive logging in other cases. This commit moves redis readonly information into the local process, but maintains the DistributedCache for postgres readonly state.
2019-06-25 11:20:34 +08:00
f3e4e6941c
DEV: Correct batch setting of categories
...
followup to #bc03c509
There were 2 problems
1. VALUES was not properly getting multiple results ... we need (1),(2),(3)
not (1,2,3)
2. changes was mistakenly lazy evaluated eg `changed ||=` which meant some
queries were not running
2019-06-25 13:05:43 +10:00
bc03c509ab
FIX: CategoryUser#batch_set ( #7787 )
...
* Remove unused method
* Prefabricate user in category_user_spec.rb
* FIX: Remove notification_level from category_users unique indexes
* FIX: CategoryUser#batch_set wasn't updating pre-existing records
* Improve tests for CategoryUser#batch_set
* FIX: changed was being reported incorrectly
* DEV: Rewrote query to do a bulk insert
* DEV: remove unnecessary parentheses
2019-06-25 12:13:27 +10:00
6de254f642
FIX: iterate when clearing watched words cache
2019-06-24 17:17:56 -07:00
b1ca64487a
FIX: multisite upload urls must have either db name or the word 'short-url'.
2019-06-25 01:19:58 +05:30
9e54e0141e
FIX: mobile overflow for tall fixed modals
2019-06-24 12:24:13 -04:00
c1ca942a77
REFACTOR: removes self pattern from safari-hacks lib ( #7795 )
2019-06-24 11:12:06 +02:00
e064db35d9
REFACTOR: removes self pattern from eyeline lib ( #7796 )
2019-06-24 10:58:59 +02:00
cea3a027f3
FIX: category-chooser search should be scoped to category ( #7794 )
2019-06-24 10:45:30 +02:00
7cabc47945
UX: improves change-timestamp modal datepicker ( #7771 )
2019-06-24 10:24:54 +02:00
ee8669d778
FIX: Ensure :after_auth event is triggered. ( #7791 )
2019-06-21 21:57:49 +03:00
02f6db4e59
FIX: Back button shenanigans when redirecting from `index` routes
...
This is a problem that has long plagued Discourse. The root issue here
is that we have to implement our own link click handler, because
Discourse allows users to create HTML blobs of content with links, and
when those links are clicked they must be handled by the Ember router.
This always involved a certain amount of use of private Ember APIs which
of course evolved over time.
The API has more or less stabilized in the last two years, however we
have hacks in our URLs to handle a dynamic root path, depending on how
forums have set up their filters and in what order.
This patch adds a special case for the root path so we needn't update
the URL ourselves otherwise, which preserves the back button on index
routes. The update call would otherwise insert an extra history event if
a route redirected on transition, breaking the back button.
2019-06-21 14:42:01 -04:00
e51de4cc25
FEATURE: Add endpoint to individually update a theme setting ( #7789 )
...
- also adds a new staff action type called "change theme setting" for easier logging of staff changes to theme settings
2019-06-21 13:49:14 -04:00
2738d11f60
UX: show like icon on archived posts ( #7775 )
2019-06-21 20:47:32 +05:30
1cbe2dd2ce
DEV: adds polyfill to fully support DOMTokenList in IE ( #7765 )
2019-06-21 09:59:28 +02:00
7c86f16aa3
FIX: Support carriage return in `InlineUploads`.
...
Follow up to 8deaef3872
2019-06-21 14:07:06 +08:00
8deaef3872
FIX: Don't replace img tags within anchor tags with markdown format.
...
Follow up to 9a25b0d614
2019-06-21 12:32:02 +08:00
9a25b0d614
FIX: Edge case with anchor tag in `InlineUploads`.
2019-06-21 09:55:56 +08:00
fc026e12a5
FIX: Some toolbar operations weren't triggering the `change` event
...
This would mean that some simple edits to queued posts did not get
saved.
2019-06-20 13:35:12 -04:00
0e26c57afa
FIX: Do not refresh all settings on save for all settings, limit to only a few
...
- Followup to 0e303c7f5d
2019-06-20 10:57:31 -04:00
56b7777705
FIX: 'status' param change not filtering the topics in tag route.
...
Use existing 'filterQueryParams' helper method to set 'queryParams' value for tag route.
2019-06-20 17:27:32 +05:30
53efb7bd24
FIX: BBcode edge case for `InlineUploads`.
2019-06-20 11:47:51 +08:00
f096c994de
FIX: use correct name for selectable_avatars_enabled site setting
2019-06-19 13:18:16 -04:00
34f382b758
FIX: `InlineUploads` should replace attachment links with markdown text.
2019-06-19 11:15:02 +08:00
73a45048a0
FIX: `Upload#short_url` generates incorrect URL when extension is `nil`.
2019-06-19 09:10:50 +08:00
6fec4982d9
FIX: Couldn't modify a widget that wasn't in the registry
2019-06-18 12:28:18 -04:00
03ba1d49fb
DEV: lint file
...
We no longer need that isAppleDevice require
2019-06-18 17:12:55 +10:00
506de13896
FIX: remove temporary hack for fixed iOS bug ( #7773 )
...
A bug where input focus is displaced on modals was fixed in iOS 11.3 update. This hack was causing problems on topic page since hiding main-outlet results in lost read position after opening and closing a modal.
2019-06-18 16:25:29 +10:00
893b50031d
replace subfolder on cdn url conversion between general cdn and s3 ( #7764 )
...
When both a cdn URL and an s3 cdn URL defined, subfolder paths were leaking
through to the s3 cdn URL. If we are replacing the cdn url with the s3_cdn url,
we also need to make sure that the subpath is removed as well, as it appears in
the original cdn url.
The test should give a fairly good gist of the situations - in subfolder
situations where s3_cdn and a cdn is defined:
`asset_path` returns the asset with a subfolder, in the form `{cdn_url}/{subfolder}/{asset_path}`
Currently this is being replaced to `{s3_cdn_url}/{subfolder}/{asset_path}`
I am proposing we change this to: `{s3_cdn_url}/{asset_path}` as it seems like
for s3_cdn urls we should not be carrying around app subfolder pathing anywhere
we are looking up s3 paths.
2019-06-17 11:51:17 -07:00
e6e47f2fb2
SECURITY: Add confirmation screen when logging in via user-api OTP
2019-06-17 16:18:44 +01:00
52387be4a4
SECURITY: Add confirmation screen when logging in via email link
2019-06-17 16:18:37 +01:00
5f6f707080
Revert "Merge pull request from GHSA-hv9p-jfm4-gpr9"
...
This reverts commit b8340c6c8e
2019-06-17 16:17:10 +01:00
b8340c6c8e
Merge pull request from GHSA-hv9p-jfm4-gpr9
...
* SECURITY: Add confirmation screen when logging in via email link
* SECURITY: Add confirmation screen when logging in via user-api OTP
* FIX: Correct translation key in session controller specs
* FIX: Use .email-login class for page
2019-06-17 15:59:41 +01:00
863d8014d0
FIX: respond with 400 error on invalid redirect param
2019-06-17 16:44:30 +05:30
102be5a9e3
DEV: optimize fix for sub-categories not getting pre-filled.
2019-06-17 13:28:08 +05:30
c909033f2b
Add plugin outlets to login/create-account modals ( #7770 )
2019-06-17 16:22:00 +10:00
704c579550
FIX: do not allow unbound membership lookups
...
Previously we would allow looking up membership limits in an unbound way
via the API, this introduces an upper limit of 1000 per page.
2019-06-17 15:32:06 +10:00
fe4f0a4369
FIX: staged users should not be included in TL groups
...
staged users should not be included in any automatic groups cause for all
purposes they do not exist.
2019-06-17 15:10:47 +10:00
48b9e0d749
FIX: sub-categories was not getting selected for pre-filled topics
2019-06-15 13:46:15 +05:30
9cb656250d
FIX: Allow tall tables to scroll vertically on iOS
2019-06-14 14:26:59 -04:00
77c06384c0
Fix the build.
2019-06-14 13:56:35 +08:00
5d16d10a9e
DEV: Fix edge case for `InlineUploads`.
2019-06-14 13:48:03 +08:00
befb074c98
DEV: `InlineUploads` should process CDN upload URLs as well.
2019-06-14 13:14:37 +08:00
41abebcbce
DEV: Support both `http` and `https` for `InlineUploads`.
2019-06-14 12:48:31 +08:00
c9db897777
FIX: Remove onebox src from `Jobs::PullHotlinkedImages`.
...
The test that was added is incorrect because the post was not cooked.
2019-06-14 09:21:25 +08:00
457be89445
DEV: only skip migration if a non seeded upload exists
...
Followup to 667b9801
2019-06-14 09:52:02 +10:00
667b98017a
FIX: do not attempt to migrate pre-existing uploads
...
This makes this job re-runnable just in case cause it will skip creation
of new uploads if an upload already exists
2019-06-14 09:39:22 +10:00
efc05e7224
FIX: remove topic timer info on completion
2019-06-13 17:01:43 +05:30
fbbce235ce
UX: improves change-timestamp modal ( #7766 )
2019-06-13 13:30:33 +02:00
9daed05ad0
Fix the build.
2019-06-13 13:53:43 +08:00
7a0d031bc4
FIX: `InlineUploads` matching on external bbcode img url.
2019-06-13 13:47:36 +08:00
782e583844
FIX: Edge cases with markdown references for `InlineUploads`.
2019-06-13 12:08:01 +08:00
93c552afda
FIX: `InlineUploads` does not correct urls with uppercase extension.
2019-06-13 11:19:33 +08:00
fa2a5f6f56
FEATURE: SKIP_DB_AND_REDIS env var ( #7756 )
...
Sometimes we would like to create a base image without any DB access, this
assists in creating custom base images with custom plugins that already
includes `public/assets`
Following this change set you can run:
```
SPROCKETS_CONCURRENT=1 DONT_PRECOMPILE_CSS=1 SKIP_DB_AND_REDIS=1 RAILS_ENV=production bin/rake assets:precompile
```
Then it is straight forward to create a base image without needing a DB or
Redis.
2019-06-13 12:58:27 +10:00
19ca2d4772
DEV: reset widget clean callback between tests ( #7761 )
2019-06-12 17:49:02 +02:00
13b979cb71
FIX: Performing actions on a particular reviewable was displaying an error
...
It was expecting a method to remove the reviewable from the current
list, only we were not displaying a list.
Instead, we refresh the reviewable model with the latest result.
2019-06-12 10:56:30 -04:00
36e53db300
Fix the build.
2019-06-12 16:44:17 +05:30
7b66f8fb46
DEV: optimize bulk invite process
2019-06-12 16:33:19 +05:30
f0846ea7cf
DEV: Remove unused line.
2019-06-12 17:38:30 +08:00
641521896c
FIX: Cover more edge cases in `InlineUploads`.
2019-06-12 17:06:58 +08:00
0a1b16bb16
FIX: clean up cooked group bio when bio is removed ( #7745 )
2019-06-12 16:18:38 +10:00
73bf880f74
FIX: Correct more edge cases with `InlineUploads`.
2019-06-12 10:44:25 +08:00
ff48fbdfda
FIX: `InlineUploads` raises an error when img tag is invalid.
2019-06-12 10:31:00 +08:00
0ebe5ec1f8
FIX: Check `postStream.gaps` exists before trying `postSteam.gaps.after`
2019-06-11 23:48:21 +01:00
f6e0c79742
FIX: Trigger change event when inserting text
...
This would normally not fire and result in odd behavior in the review
queue when inserting links.
2019-06-11 17:27:34 -04:00
3d7c26c15e
FIX: Memory Leaks w/ Container ( #7750 )
...
Gives instance initializers the ability to add a `teardown` method that
will be called between tests to clean up after themselves.
2019-06-11 18:41:27 +02:00
47095a7fa1
FIX: Memory leak when adding ajax prefilter repeatedly.
2019-06-11 11:50:35 -04:00
c322cccd53
FIX: Memory Leaks when decorating posts ( #7749 )
...
* Remove long-deprecated method
* FIX: Memory Leaks when decorating posts
Previously we'd keep creating mixins dynamically when decorating the
same class.
This code changes the API to recommend an `id` parameter for each
decorator which will avoid leaks. All plugins should be updated to
include this parameter, although if they don't in the meantime it'll
just mean a warning in the console (and a continued leak.)
2019-06-11 17:21:23 +02:00
934adb14d2
FIX: On tag change notify only users watching the tag. ( #7707 )
2019-06-11 18:06:54 +03:00
788f995f30
FIX: skip external urls which has upload url in query string.
...
Add spec tests for post.each_upload_url method. e8fafbc123
2019-06-11 19:55:02 +05:30
e2636f0ec7
FIX: handle array in redirect param
2019-06-11 17:49:09 +05:30
f4fd75aea4
DEV: Rename variable to avoid conflict
2019-06-11 13:02:40 +01:00
f1d5b992bf
DEV: Correct linting error
2019-06-11 12:51:18 +01:00
dc15486f0a
Revert "DEV: resets csrf ajax prefilter only if present ( #7747 )"
...
This reverts commit 6612218a4e
2019-06-11 13:34:25 +02:00
61b587f66e
FIX: Mark ignored posts as 'read', if last visible post is read ( #7739 )
2019-06-11 12:16:28 +01:00
000a35b219
FIX: Do not live-load posts from ignored users
2019-06-11 12:07:14 +01:00
6612218a4e
DEV: resets csrf ajax prefilter only if present ( #7747 )
2019-06-11 12:50:20 +02:00
ebf77f74b7
Revert "DEV: prevents csrf token to leak state between tests ( #7746 )"
...
This reverts commit b29d63a52d
2019-06-11 12:19:49 +02:00
b29d63a52d
DEV: prevents csrf token to leak state between tests ( #7746 )
2019-06-11 11:54:23 +02:00
e6714d3531
Revert "DEV: attempts to prevent session object to be retain in csrf init ( #7743 )"
...
This reverts commit 62c56b6e59
2019-06-11 10:58:32 +02:00
4deb0f6d59
DEV: prevents post-cooked decorators to leak between tests ( #7744 )
2019-06-11 10:02:10 +02:00
62c56b6e59
DEV: attempts to prevent session object to be retain in csrf init ( #7743 )
2019-06-11 09:59:14 +02:00
c407e32368
DEV: should check on object and not length ( #7742 )
2019-06-11 09:45:45 +02:00
e5cace9185
FIX: File size text should not be part of link.
2019-06-11 15:21:06 +08:00
fb0a655e8a
FEATURE: Update pull hotlinked images to use `Upload#short_url`.
2019-06-11 15:17:29 +08:00
9d0fba64c0
FIX: Use attachment format in user export system post take 2.
2019-06-11 12:15:11 +08:00
a046f6ced5
FEATURE: Trigger Discourse events from authenticators. ( #7724 )
2019-06-11 11:28:42 +10:00
d073a7d5a8
DEV: Added commit approved notification type for discourse-code-review
...
We need to reserve ids in core so plugins do not clash.
2019-06-11 11:17:23 +10:00
06d974d55c
FEATURE: Add base62 sha1 to cooked data attribute
...
* FEATURE: Add base62 sha1 to data attribute in `Post#cooked`.
* FIX: Use `Upload#short_url` when quoting an image.
2019-06-11 11:15:45 +10:00
bd538f7437
FIX: Composer preview not caching inline onebox.
2019-06-11 09:14:53 +08:00
9168ffc201
PERF: Use already loaded post when quoting or opening draft.
2019-06-11 08:21:38 +08:00
7b17eb06da
FEATURE: ban any SSO attempts with invalid external id
...
We now treat any external_id of blank string (" " or " " or "", etc) or a
invalid word (none, nil, blank, null) - case insensitive - as invalid.
In this case the client will see "please contact admin" the logs will explain
the reason clearly.
2019-06-11 10:04:26 +10:00
ecebff5060
Only show deprecation warning if the webhook is active
2019-06-10 16:23:12 -04:00
ace6ce0462
FIX: Add 'deleted' to the list of status filters ( #7738 )
2019-06-10 15:43:49 -03:00
bdfa55ee5d
UX: Copyedits on reviewable filters
2019-06-10 13:45:38 -04:00
86f3e74799
DEV: Allow `{{d-button}}` to include a href
2019-06-10 13:24:40 -04:00
8b31b812f8
UX: Use a glyph to indicate a new topic instead of "New Topic:"
...
In the review queue it was easy to miss "New Topic:" so let's try a font
awesome glyph instead.
2019-06-10 12:43:20 -04:00
8c4e16eafd
FIX: In reply to would sometimes have a broken link
2019-06-10 11:33:10 -04:00
af08ab5b7b
Revert "DEV: prevents csrf-token initializer to leak session object ( #7730 )"
...
This reverts commit da5255e560
2019-06-07 18:31:16 +02:00
ebecd0b7d1
Revert "fix tests, crsf token meta is not present on tests ( #7733 )"
...
This reverts commit 240b61e844
2019-06-07 18:31:13 +02:00
bae7b75e23
FIX: Updating a user profile as admin shouldn't change the user's locale
2019-06-07 17:53:46 +02:00
2dce650b72
FIX: prevents screen-track from leaking object ( #7734 )
2019-06-07 17:18:27 +02:00
240b61e844
fix tests, crsf token meta is not present on tests ( #7733 )
2019-06-07 17:11:16 +02:00
dfb66334c1
DEV: prevents global-notice events to leak ( #7732 )
2019-06-07 16:49:59 +02:00
55325679ac
DEV: prevents share-popup to leak events ( #7731 )
2019-06-07 16:48:45 +02:00
da5255e560
DEV: prevents csrf-token initializer to leak session object ( #7730 )
2019-06-07 16:46:55 +02:00
df01249db4
FIX: removes leaking handler in select-kit ( #7729 )
2019-06-07 16:12:22 +02:00
fca90106b9
FIX: select-kit events were sometimes not cleaned up ( #7728 )
2019-06-07 15:20:01 +02:00
54afa314fb
FIX: Do not download emojis in pull_hotlinked_images
2019-06-07 13:00:52 +01:00
d1228f47bb
FIX: Handle missing plural keys on client
2019-06-07 10:24:17 +02:00
cbd4d06da0
PERF: only check for totp record on current user at when needed
...
Previously the check was done a bit too early causing one extra query
per page unconditionally for logged on users
2019-06-07 16:25:04 +10:00
a652d620f6
FIX: safari desktop doesnt support input[time] ( #7719 )
...
This commit attempts to improve the experience by:
- showing time input as disabled on any platform if date hasn't been set
- showing a placeholder --:-- to emphasize the expected format
2019-06-07 15:50:43 +10:00
a0474a0774
FIX: always take the first post in the RSS fee
...
`.posts.first` may be the first post and may not, depending on luck
Also add protection for corrupt topics
2019-06-07 14:57:56 +10:00
ff3a1eae3a
FIX: ensure consistency should handle cases where a topic trashed
...
Followup to c05b6170
2019-06-07 14:57:56 +10:00
ee142c2173
DEV: More improvements to `InlineUploads`.
...
* Convert inline links to short path
```
<link> <link>
<link>
```
to
```
<short_path> <short_path>
<short_path>
```
2019-06-07 11:49:30 +08:00
c05b617067
FIX: ensure_consistency was able to create corrupt category topics
...
- Correct create_category_definition to skip validations and use a
transaction, no longer able to create corrupt topics
- ensure_consistency now clears topic_id if pointing at deleted or missing
topic_id
- Stop creating category definition topics for uncategorized
2019-06-07 11:20:13 +10:00
9db1fef4e3
FIX: add support for custom/plugin notification title attribute
2019-06-07 09:09:16 +08:00
1f73a3ba6d
FIX: round the calculated heat values
...
Views heats like 12135 will become 12000, like ratios like
1.666666666667 will become 1.67.
2019-06-06 15:44:55 -04:00
35da531f1d
FIX: Do not resize images in Onebox while lazy loading.
...
Follow-up to 35d0fd0
2019-06-06 18:36:18 +03:00
9acd851b9a
FIX: correct link to list of watched words
2019-06-06 20:21:54 +05:30
48b6391777
FIX: s/thumb-tack/thumbtack ( #7718 )
2019-06-06 14:43:16 +02:00
c462c2f271
FIX: prevents appEvents to leak ( #7714 )
2019-06-06 12:33:52 +02:00
5377d1672f
DEV: Fix linting issue.
2019-06-06 13:20:16 +03:00
f63b8bb79d
FIX: Periodically ensure consistency of categories. ( #7663 )
2019-06-06 11:30:52 +02:00
782da448a2
FIX: Missing `title` attribute when quoting an image.
2019-06-06 16:45:12 +08:00
2265c5102f
DEV: Remove unnecessary condition.
...
Follow up to 21876d46d6
2019-06-06 15:55:49 +08:00
95db609586
DEV: Support more formats of inline images.
2019-06-06 15:50:56 +08:00
21876d46d6
DEV: Missing loading spinner for staff action logs.
...
Follow up to e0c821ebb0
2019-06-06 15:41:55 +08:00
f00275ded3
FEATURE: Support private attachments when using S3 storage ( #7677 )
...
* Support private uploads in S3
* Use localStore for local avatars
* Add job to update private upload ACL on S3
* Test multisite paths
* update ACL for private uploads in migrate_to_s3 task
2019-06-06 13:27:24 +10:00
e0c821ebb0
FEATURE: Make staff action logs page support infinite loading
2019-06-06 13:02:53 +10:00
b510006ca8
FEATURE: show tags in crawler view of tags page for static site
...
Previously tags page would have an empty page in crawler view
2019-06-06 12:55:37 +10:00
c3a38d2304
DEV: Make groups/new extensible by plugins ( #7642 )
...
* Expose a new plugin outlet. Pass group model to the group-member-dropdown so it can be accessed by plugins
* Added controller tests for group custom fields. update custom fields when updating a group
2019-06-06 12:05:33 +10:00
7bd8f715bc
DEV: Prefer `this.site.notification_types`.
2019-06-06 09:39:59 +08:00
d9d36f241d
DEV: Use `this.site.get("notification_types")` instead.
...
Follow up to fcb7422213
2019-06-06 08:18:25 +08:00
54db23e4ff
UX: Make input caret color match text color
2019-06-05 14:27:27 -04:00
58ff7216ca
UX: Display "Queued Topic" if a Queued Post will create a topic
2019-06-05 14:11:28 -04:00
d902c4eb9f
FEATURE: Can sort reviewable queue
...
Choices are Priority / Created At (and desc versions.)
2019-06-05 13:21:05 -04:00
35d0fd038e
FIX: Add unit to width and height CSS properties.
2019-06-05 19:51:31 +03:00
c0e8950fdb
UX: Shrink oneboxes and other wide content in custom post messages
2019-06-05 12:48:06 -04:00
ea5767e935
FIX: Broken serializer spec with no payload
2019-06-05 12:44:56 -04:00
f1d547c301
FEATURE: Show "in reply to" on the review queue
...
We now show if a queued or flagged post is a reply to another when in
the review queue. It's especially helpful for queued posts where
normally they are linked to the topic where they are created, and you
have no context about the reply.
Note that this will only apply to new queued posts going forward.
Previously queued posts will not show the "in reply to"
2019-06-05 12:34:41 -04:00
be464f753c
UX: Lighten OS icons in recently used devices
2019-06-05 10:56:25 -04:00
ad876880e1
FIX: Ember was raising an error without a `.set` here
2019-06-05 10:23:39 -04:00
0082a57718
REFACTOR: computed lib ( #7702 )
2019-06-05 15:50:22 +02:00
f506843074
REFACTOR: user route ( #7704 )
2019-06-05 13:05:27 +02:00
1178f4865b
REFACTOR: login-method model ( #7703 )
2019-06-05 12:35:41 +02:00
80459d83a4
REFACTOR: discourse-location lib ( #7700 )
2019-06-05 11:46:36 +02:00
faef660631
REFACTOR: invite model ( #7699 )
2019-06-05 11:24:06 +02:00
df6d46b235
FIX: regression and attempts to have clearer naming ( #7701 )
2019-06-05 11:23:30 +02:00
0fd7f74664
REFACTOR: post model ( #7659 )
2019-06-05 11:04:35 +02:00
69f75b2a81
REFACTOR: preferences/account controller ( #7698 )
2019-06-05 10:37:51 +02:00
19e3b3b1bc
PERF: speed up topic poster lookups
...
During profiling looking up topic users popped up as a hot path, this
change more than halved the amount of work it does
It reduces object allocations and method calls and avoids repeate translation
of common terms
2019-06-05 18:28:36 +10:00
ce79a71c5d
typo s/faivcon/favicon ( #7697 )
2019-06-05 09:46:07 +02:00
b9df7a2257
FIX: if favicon is missing due to bad url we would return a 500 on favicons
...
This ensures that the error logging does not corrupt the cache
2019-06-05 16:43:40 +10:00
b2b66d645b
UX: Move archive button in topic controls dropdown (mobile view). ( #7681 )
2019-06-05 11:30:06 +10:00
1cf0b549ab
FIX: don't send post edit notification when hidden tags are changed
...
Create a hidden revision so staff can see the changed, but don't send
notifications to non-staff.
2019-06-04 15:48:15 -04:00
f03a547a89
REFACTOR: topic-entrance component ( #7694 )
2019-06-04 17:50:02 +02:00
6de3824b46
REFACTOR: group model ( #7692 )
2019-06-04 17:41:46 +02:00
68147cedd1
REFACTOR: username-validation mixin ( #7693 )
2019-06-04 17:41:33 +02:00
7b19e63ce7
REFACTOR: badge model ( #7690 )
2019-06-04 17:12:02 +02:00
1bca6fdf51
UX: Z-index fix for preview on iOS
2019-06-04 11:08:49 -04:00
e7fe7010b8
FIX: use hijack for processing bulk invites ( #7679 )
...
FIX: do not store bulk invite CSV file on server
2019-06-04 20:19:46 +05:30
ecc9c76692
FEATURE: dynamically update the topic heat settings monthly ( #7670 )
...
The site settings beginning with "topic views heat" and "topic post like
heat" are set to defaults when installing Discourse, but there has not
been a process or guidance for updating these values based on
community activity.
This feature will update them once a month. The low, medium, and
high settings will be based on the minimums of the 45th, 25th, and
10th percentile topics respectively, so that 45% of topics will have
some "heat".
Disable automatic changes with the automatic_topic_heat_values setting.
2019-06-04 10:34:07 -04:00
e66024bd3b
Update theme component URL
2019-06-04 10:04:27 -04:00
4201329f1e
REFACTOR: topic-from-params route ( #7689 )
2019-06-04 15:51:22 +02:00
87bf0ec7ae
FIX: fix locale key
2019-06-04 13:35:17 +02:00
fcb7422213
DEV: Avoid hard-coding notification types integer in client side code.
...
Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
2019-06-04 17:30:46 +08:00
9585a16264
FIX: ensures correct i18n key is used ( #7686 )
2019-06-04 11:22:44 +02:00
4283281397
FIX: ensures we have data to compute average ( #7685 )
2019-06-04 11:21:55 +02:00
b79d02ff48
FEATURE: displays average for 2 columns tables which support average
2019-06-04 11:08:26 +02:00
c9a34aa10c
FIX: add title attribute for notifications
2019-06-04 17:02:12 +08:00
33bc8c276d
FIX: default top timeframe was overriding best_periods_for
2019-06-04 10:57:50 +02:00
7da875f52a
FIX: trigger user_updated webhook when avatar changes
2019-06-04 16:46:46 +08:00
497a1d2d9f
FEATURE: uses native date picker on mobile ( #7541 )
2019-06-04 10:44:55 +02:00
c4419b7369
REFACTOR: badge-selector component ( #7683 )
2019-06-04 10:30:56 +02:00
2863e7c181
FIX: fix select badge as user title on badge page ( #7682 )
2019-06-04 18:19:30 +10:00
1991af2abb
DEV: Switch `InlineUploads` to a regexp based implementation.
2019-06-04 15:54:25 +08:00
d93e5fb00d
DEV: Class that converts MD with old attachment links to new MD.
2019-06-04 15:54:25 +08:00
22abad4151
PERF: stop reindexing and skipping deleted posts
2019-06-04 17:53:35 +10:00
74c4f926fc
FIX: drop deleted posts from search index
...
This does two things
1. Our "index grace period" has been wound down to 1 day, there is no point
keeping a bloated index for a week, usually when people delete stuff they
mean for it to be removed
2. We were never dropping deleted posts from the index, only posts from
deleted topics
These changes speed up search a tiny bit and reduce background work.
2019-06-04 17:19:59 +10:00
6428aa5b1f
FIX: search indexer had various cases where it could fail
...
Previous to this fix is a post had the test www.test.com/abc it would fail
to index.
This also simplifies the rules to avoid full url parsing which can be
expensive
2019-06-04 16:21:03 +10:00
bb98785569
DEV: Fix broken `Upload#base62_sha1`.
2019-06-04 14:10:46 +08:00
871fcf1117
PERF: omit user profile and private message stats in web hook serializer.
2019-06-04 08:44:10 +05:30
77300c1d8d
DEV: reindex old data in a more consistent way
...
Previously we were grabbing arbitrary rows in many cases which makes
diagnosing issues in the indexer more complex
2019-06-04 11:47:24 +10:00
55fd3acea0
Revert "FIX: Undefined method when serializing a user"
...
This reverts commit 1fbe078ae04f5c9bb8d3
2019-06-04 09:30:30 +08:00
0c5498c9a4
REFACTOR: exception controller ( #7675 )
2019-06-03 23:34:23 +02:00
d7ff640778
fix the build
2019-06-03 20:42:46 +02:00
b792db9d92
FIX: redirect to top was always redirecting to 'All'
2019-06-03 20:18:14 +02:00
9a3dd6b59a
UX: Add missing classes to user preferences
2019-06-03 13:35:40 -04:00
f9f12ed221
PERF: fix N+1 queries for non-JS topic view.
2019-06-03 21:47:33 +05:30
d4f6b9e827
FIX: Crawler footer style needed to be more specific
2019-06-03 11:52:20 -04:00
81dcadf788
DEV: Stop compiling themes during DB migration. Recompile on cdn change. ( #7676 )
...
This is an improved implementation for bc8b7b13
2019-06-03 16:38:02 +01:00
6834b0a4ba
Fix Prettier
2019-06-03 10:54:24 -04:00
16982d2a69
Update UI for wizard themes further reading step ( #7669 )
2019-06-03 10:47:17 -04:00
f6ced0a78a
Remove unused & empty author meta tag
2019-06-03 12:00:14 +02:00
7500eed4c0
FEATURE: Multi-file javascript support for themes ( #7526 )
...
You can now add javascript files under `/javascripts/*` in a theme, and they will be loaded as if they were included in core, or a plugin. If you give something the same name as a core/plugin file, it will be overridden. Support file extensions are `.js.es6`, `.hbs` and `.raw.hbs`.
2019-06-03 10:41:00 +01:00
c1e7a1b292
UX: Merge settings related to muted tags. ( #7656 )
2019-06-03 12:23:23 +10:00
42809f4d69
FIX: use crawler layout when saving url in Wayback Machine ( #7667 )
2019-06-03 12:13:32 +10:00
28dcf445b7
DEV: Pass editor to plugin hook handling composer uploads. ( #7673 )
2019-06-03 12:07:25 +10:00
98336de266
UX: Cleanup crawler styles, improve schema.org markup ( #7668 )
...
* Cleaning up crawler styles, improving some schema.org markup
* Cleaning up crawler styles, improving some schema.org markup
* additional styling
* add space for pagination
2019-06-03 12:03:16 +10:00
e302c0af8b
DEV: by default disable anon impersonation in dev environments
...
The impersonate any user by anonymous feature in dev should require a
deliberate opt-in. This way developers are better aware of the security
implications of this development only feature.
2019-06-03 10:02:27 +10:00
a2598632aa
FIX: Histories should be reverse chronological
2019-05-31 14:59:26 -04:00
74eaa5e7ec
FIX: For API consumption it's easier if the lings are the full URL
2019-05-31 14:04:54 -04:00
75fc126224
DEV: Change path for extra scss files in themes ( #7664 )
...
The preferred path is `/stylesheets/...`, to match core and plugins. The old `/scss/...` path will continue to function
2019-05-31 15:40:41 +01:00
03363d03e8
FEATURE: Load theme setting descriptions from theme locale files
...
Previously theme setting descriptions were defined in the `settings.yml` file like this:
```
setting_name:
default: "My Default Value"
description:
en: "English description"
fr: "French description"
```
This commit allows developers to store the localised descriptions in the theme locale files instead:
```
en:
theme_metadata:
description: Theme Description
settings:
setting_name: "The localised description for setting_name"
```
2019-05-31 14:49:59 +01:00
a0a2823536
DEV: Fix indentation
2019-05-31 10:19:19 -03:00
1db7fd6f9b
REFACTOR: topic-list model ( #7658 )
2019-05-31 13:15:45 +02:00
63264158cf
REFACTOR: user-posts-stream model ( #7657 )
2019-05-31 13:02:15 +02:00
3b8819f0ab
FEATURE: add support for defer topic functionality
...
This feature allows end users to "defer" topics by marking them unread
The functionality is default disabled. This also introduces the new site
setting default_other_enable_defer: to enable this by default on new user
accounts.
2019-05-31 15:44:35 +10:00
077dcc0642
FEATURE: add autocomplete discourse on full page search
...
This teaches chrome not to try autocompleting it.
2019-05-31 10:27:44 +10:00
2e0a40007b
FIX: Category topics should not be deletable via review queue
2019-05-30 16:43:23 -04:00
c169456ee5
DEV: Create new component to reify the user fields ( #7655 )
2019-05-30 16:17:16 -03:00
c4fa20d644
FIX: Broken test, also typoed property
2019-05-30 14:27:28 -04:00
5e89714f77
FIX: Linting via prettier
2019-05-30 13:58:06 -04:00
7a9e85b1d7
FIX: Don't show the "Flag to delete" message to staff
...
If they can't delete, flagging should not either.
2019-05-30 13:31:40 -04:00
7a21f78f8c
prettier ( #7653 )
2019-05-30 17:28:07 +02:00
0fbbff86ab
REFACTOR: rest model ( #7652 )
2019-05-30 17:11:17 +02:00
8196af165d
FIX: Add Chromebook detection.
2019-05-30 16:29:51 +03:00
f54a865846
DEV: refactor cleaning up of user export topics
2019-05-30 10:24:45 +05:30
bfb26b720b
FIX: the en_US locale depends on en
2019-05-30 08:46:43 +08:00
2fa8df7cd2
New: can_see_groups? method for better perf
2019-05-30 08:45:20 +08:00
e7ee556e87
Support multi-group user search
2019-05-30 08:45:20 +08:00
b24938b5ff
UX: Minor composer button alignment adjustments, simplification
2019-05-29 14:37:32 -04:00
227c45107d
FEATURE: Implement Onebox for posts including polls. ( #7539 )
2019-05-29 17:05:52 +02:00
c77bc525cb
REFACTOR: new-topic route ( #7639 )
2019-05-29 16:46:58 +02:00
ba66d6fd82
FIX: icon deprecation s/group/users ( #7638 )
2019-05-29 16:29:01 +02:00
034502af21
FIX: incorrectly removed moveTypes array ( #7637 )
2019-05-29 16:23:32 +02:00
bb6337d6c6
REFACTOR: choose-topic component ( #7636 )
2019-05-29 16:21:13 +02:00
b2fc80e4b7
REFACTOR: build-topic-selection mixin ( #7635 )
2019-05-29 16:09:19 +02:00
468cfa39f7
REFACTOR: rename-tag controller ( #7634 )
2019-05-29 15:58:12 +02:00
f2858e03c8
REFACTOR: preferences/email controller ( #7633 )
2019-05-29 15:53:42 +02:00
5e7e32510a
FIX: lookup should be done against locale of reference ( #7632 )
2019-05-29 15:45:44 +02:00
05206a61ab
FIX: displays text of asset-version changed modal ( #7631 )
2019-05-29 15:38:14 +02:00
a3938f98f8
Revert changes to `FileStore::S3Store#path_for` in f0620e7118.
...
There are some places in the code base that assumes the method should
return nil.
2019-05-29 18:39:07 +08:00
04fdada96a
annotate models
2019-05-29 14:26:24 +10:00
5c524ea8a4
FEATURE: introduce dedicated storage and DB constraints for anon users
...
Previously we used custom fields to denote a user was anonymous, this was
risky in that custom fields are prone to race conditions and are not
properly dedicated, missing constraints and so on.
The new table `anonymous_users` is properly protected. There is only one
possible shadow account per user, which is enforced using a constraint.
Every anonymous user will have a unique row in the new table.
2019-05-29 14:26:24 +10:00
f0620e7118
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD take 2.
...
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
63292cecd9
PERF: Prefer joins over `IN ()` queries.
2019-05-29 09:00:15 +08:00
76569b2018
FIX: ensures post-small-action is using timezone to display dates
2019-05-29 08:45:28 +08:00
a93aa5bbce
Add "further reading for themes" step to wizard
2019-05-29 08:28:03 +08:00
43e33302e1
FIX: Position emoji-picker around d-editor.
2019-05-29 08:27:14 +08:00
7a08e23b4b
FIX: Bump search index version.
2019-05-29 08:20:59 +08:00
7c9fb95c15
Temporarily revert "FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )"
...
This reverts commit b1d3c678ca
2019-05-28 16:37:01 -04:00
f3c07e27d9
FIX: correct translations for logs error rate notice ( #7622 )
...
The problem here is that hour and minute were passed to the %{duration} variable which made them impossible to translate in other languages.
I wonder if it's worth having 2 almost identical translations just for "reached" and "exceeded"? Perhaps we could combine them in one copy?
2019-05-28 22:10:51 +03:00
91ff8684fd
FIX: Use the right property for post ID.
2019-05-28 22:00:58 +03:00
67d8ceedf1
Remove unused variable
2019-05-28 14:31:52 -04:00
c57ab12238
UX: Move preview button to bottom right of mobile composer
2019-05-28 14:19:33 -04:00
bc14452585
FIX: ensures events have access to correct context ( #7621 )
2019-05-28 19:40:28 +02:00
b1d3c678ca
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
9bdfaa195e
FIX: We shouldn't memoize the last time something is read
2019-05-28 10:51:18 -04:00
028121b95b
FIX: delete system generated message when user_export record is deleted ( #7595 )
...
FIX: system generated message for user export should be closed by default
2019-05-28 16:38:41 +05:30
6decdfce5c
DEV: reduces memory footprint of tests - step 1 ( #7591 )
2019-05-28 12:15:12 +02:00
07b80d491b
FIX: Refresh automatic groups after inviting moderators.
2019-05-28 17:19:34 +08:00
0d9fdbf8fe
FEATURE: Allow import of hidden site settings ( #7601 )
...
* Allow optional import of hidden site settings
* Always import hidden settings
2019-05-28 16:20:18 +10:00
315a38e0e3
FEATURE: Allow running message_bus in a different redis instance ( #7616 )
...
Adds `DISCOURSE_MESSAGE_BUS_REDIS_ENABLED` env var, that when set
to true, will allow Discourse to connect to a different redis
instance for MessageBus needs.
When enabled you can configure the same env vars user for redis,
but prefixed by `MESSAGE_BUS`, eg:
`DISCOURSE_MESSAGE_BUS_REDIS_HOST`
2019-05-28 15:52:43 +10:00
7429700389
FIX: ensure we can download maxmind without redis or db config
...
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
b85fa62882
FIX: Don't send replies to flags that are ignored by expiry
...
The `AutoQueueHandler` will ignore really old flags. In that case, don't
notify the user that the moderator is looking into it. They probably
never saw it because it didn't meet the reviewable minimum priority.
2019-05-27 17:24:36 -04:00
03b4131933
FIX: When deleting a user via queued posts, block urls, ip and email
2019-05-27 15:54:01 -04:00
d26c4509ea
FIX: Adding a user to a group twice under concurrency
...
This prevents an error from being raised / logged.
2019-05-27 15:42:40 -04:00
dfcc2e7ad8
Revert "FEATURE: Send notification when member was accepted to group. ( #7503 )"
...
This reverts commit 42c82d544e
2019-05-27 15:19:59 -04:00
c108131ad4
Revert "Fix JS error in group summary notification message"
...
This reverts commit b1268e00b8
2019-05-27 15:19:38 -04:00
b1268e00b8
Fix JS error in group summary notification message
2019-05-27 14:54:51 -04:00
d95a68b837
FEATURE: When suspending a user, allow the Delete + Replies action
...
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
192562745f
DEV: uses focus helper for d-editor tests ( #7610 )
2019-05-27 17:31:11 +02:00
42c82d544e
FEATURE: Send notification when member was accepted to group. ( #7503 )
2019-05-27 17:28:41 +03:00
395f0ca126
FIX: attempts to prevent stacked-chart from being cut off ( #7608 )
2019-05-27 15:43:27 +02:00
e284b6e075
FIX: Update tags on change. ( #7581 )
2019-05-27 16:04:26 +03:00
d93f753b17
apply prettier on gigantic find and replace ( #7604 )
2019-05-27 10:42:53 +02:00
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
da39d66e83
DEV: Improve support for plugins. ( #7332 )
...
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
2019-05-25 16:53:03 +03:00
6398ded798
Revert "FIX: ensures selection is lookedup into async content ( #7586 )"
...
This reverts commit c238f0d223
2019-05-25 15:50:41 +02:00
d6aacadc4e
make 🤖 happy
2019-05-25 00:32:29 +02:00
4b796eebe0
UX: Try tweaking how soon images are lazily loaded
2019-05-24 15:52:48 -04:00
89b84651c3
Migrate score settings to use sensitivities
...
We hide scores so these settings no longer made sense.
2019-05-24 15:44:24 -04:00
fad5d9c49b
Use an Enum class for the Reviewable Priority Site Setting
2019-05-24 15:44:24 -04:00
dbd14a805c
UX: Wrap long names on user admin page
2019-05-24 13:39:16 -04:00
963f6fbd40
Add icon for "Move to Inbox" footer button
2019-05-24 11:53:14 -04:00
e20c30987c
FEATURE: detect theme errors and catch them ( #7589 )
...
* FEATURE: detect theme errors and catch them
* Bump COMPILER_VERSION
* Feedback
* Override eslint no console for one line
* Can't use our ajax method
* remove emoji from translation file
2019-05-24 17:25:55 +03:00
049561ac49
FIX: introduces onSelectAny (regroup onSelect and onSelectNone) ( #7594 )
2019-05-24 13:11:33 +02:00
f4a471f0eb
FIX: Correctly cache hash of extra translations
2019-05-24 11:38:26 +02:00
c1e9a70d59
FIX: Fallback locale was not available for extra translations
...
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
2019-05-24 11:38:26 +02:00
fd0eff6ce3
Revert "FIX: Add missing unique index on user_id for user_profiles."
...
Oops `user_id` is the primary key.
This reverts commit 5478aa63ab
2019-05-24 12:58:36 +08:00
5aed463649
Update annotation.
2019-05-24 12:58:26 +08:00
5478aa63ab
FIX: Add missing unique index on user_id for user_profiles.
2019-05-24 12:11:49 +08:00
4f5c9bb8d3
DEV: Prefer `create!` over `create`.
...
We want to know when stuff fails.
2019-05-24 12:07:22 +08:00
1fbe078ae0
FIX: Undefined method when serializing a user
...
Apparently is is possible to have a user without a user_profile. This
fix will return nil for any user_profile fields during serialization
(like the after delete web hook) instead of blowing up.
2019-05-23 19:44:55 -06:00
1babc3bec6
Follow up to 3388872991.
2019-05-24 09:02:39 +08:00
3388872991
UX: Separate section for 2FA settings, more consistent layout
2019-05-24 08:58:12 +08:00
648af78298
FIX: Linting
2019-05-23 12:16:45 -04:00
f73988acd2
Remove unused computed property.
2019-05-23 12:06:18 -04:00
e74cd54fc6
REFACTOR: Replace score bonuses with low/med/high priorities
...
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
2019-05-23 11:54:45 -04:00
30961dd875
Revert "UX: Prevent long names from overflowing on user admin"
...
This reverts commit 6207b71c36
2019-05-23 16:56:30 +02:00
943fdc1762
make eslint happy
2019-05-23 12:51:40 +02:00
0cc81f95a5
FIX: popover should use target when no data attributes
2019-05-23 12:41:36 +02:00
ca6c919299
DEV: Remove unused variable.
...
Follow up to df1e6eed5a07f49eeda4c0bbd8c63d539aefdb3b..
2019-05-23 16:42:42 +08:00
f0a776f05d
FIX: allows scrolling when a lot of categories are used ( #7590 )
2019-05-23 10:04:53 +02:00
df1e6eed5a
FIX: Pull hotlinked images for lightbox links as well.
2019-05-23 15:44:37 +08:00
553ffbfcb5
FEATURE: add OpenGraph data to /login page
2019-05-23 07:03:01 +05:30
954293655f
FEATURE: rake posts:destroy_old_user_data_exports
...
Historically we would keep the user data export posts around but delete
the uploads.
This leaves a lot of broken uploads in the system.
This rake task allows us to clean up old mess.
2019-05-23 11:11:37 +10:00
6207b71c36
UX: Prevent long names from overflowing on user admin
2019-05-22 15:10:09 -04:00
9f6af5f8a7
UX: Prevent long names from overflowing on user profiles
2019-05-22 15:03:50 -04:00
881c832a2f
UX: Remove padding from empty row
2019-05-22 14:27:17 -04:00
ca03baf2b2
UX: Hide pending score statuses
2019-05-22 11:26:17 -04:00
cf63a9bb53
FIX: exception when pressing backspace on empty selection ( #7587 )
2019-05-22 17:18:46 +02:00
c238f0d223
FIX: ensures selection is lookedup into async content ( #7586 )
2019-05-22 17:11:19 +02:00
58f72cd439
Remove duplicate translations
2019-05-22 16:15:22 +02:00
40c903ec23
FIX: ie11 exception on new category popup ( #7585 )
2019-05-22 15:17:28 +02:00
e224100023
FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled
2019-05-22 11:44:39 +02:00
d9413a61d2
PERF: move crawl_topic_links to the low queue
...
Crawling topic links can be somewhat delayed no need to run it in the default
queue.
2019-05-22 10:18:49 +10:00
0ed1cfd8d9
FIX: ensures we have an elementFromPoint before using it ( #7583 )
2019-05-21 21:26:54 +02:00
793915fe6a
DEV: should ignore missing post uploads when a user export destroyed
2019-05-21 13:32:36 +05:30
236adc9ccb
FIX: shows parent category name in title anchor ( #7576 )
2019-05-21 08:33:22 +02:00
0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales ( #7545 )
...
* Refactor keyboard shortcuts modal to fix RTL locales
* Feedback
* Remove lowercase modifier keys
2019-05-21 06:39:32 +03:00
bc8c77723e
FIX: puts focus-event at application level ( #7568 )
...
Also attempts to use simpler and newer APIs
2019-05-20 13:48:03 +02:00
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
9bbf421125
FIX: better node check for clickoutside in widgets ( #7573 )
2019-05-20 12:45:33 +02:00
0ddfeb9c64
FIX: ensures mousetrap is reset with the application ( #7569 )
2019-05-20 10:45:31 +02:00
14bae6d52d
Make `email_excerpt` method take an optional `post` param ( #7570 )
...
The spoiler alert plugin replaces spoiler text found in email excerpts with posts URL, which means it needs to have a reference to the post it's processing.
This change makes `email_excerpt` accepts an optional post param, which calls `PrettyText.format_for_email` which then triggers the `reduce_cooked` event that the plugin subscribes to.
2019-05-20 10:04:23 +02:00
7eea2e35e4
Upload image preview needs width on desktop
2019-05-17 11:25:35 -04:00
b05d7042ae
FIX: prevents events on toolbar when in form ( #7567 )
...
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.
This commit also prevents d-editor-modal to be filled when it's hidden.
2019-05-17 11:14:09 +02:00
148bfc9be5
DEV: Simplify client and server side code to support removing tags.
...
Follow up to 834c86678f
2019-05-17 16:39:20 +08:00
5666316285
FEATURE: Display 'last updated' on dashboard, improve release notes link ( #7560 )
2019-05-17 15:42:45 +10:00
834c86678f
FIX: Missing post revision when editing the first post.
2019-05-17 12:54:27 +08:00
e2444e0d31
DEV: Fix another frozen string error.
2019-05-17 10:07:37 +08:00
25137554ed
FIX: _.include is no longer imported from lodash
...
Instead use toArray and indexOf which is also clearer
2019-05-17 08:58:39 +10:00
80b3560050
IE11: Login form needs full flex shorthand
2019-05-16 14:07:49 -04:00
225593d445
FIX: Small tweak to percentiles based on feedback
2019-05-16 13:45:36 -04:00
ad4d01233b
DEV: attempts to make d-editor tests more resilient ( #7556 )
2019-05-16 14:42:01 +02:00
244c03573a
FIX: btn class was duplicated on admin-menu-buttons ( #7555 )
2019-05-16 14:37:53 +02:00
0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes ( #7557 )
2019-05-16 14:37:37 +02:00
1afe6d0aee
FIX: share-and-invite modal was too narrow ( #7559 )
2019-05-16 14:37:19 +02:00
0e677daaee
FIX: include posts with data-orig-src attribute in have_uploads scope query.
2019-05-16 16:39:38 +05:30
56ada8374f
DEV: wrap find_missing_uploads method in distributed mutex
...
And skip posts with deleted topics.\ne8fafbc123170dd1f7d2a8adea4e7810585d3e76
2019-05-16 15:17:53 +05:30
a5a4f9dc1a
DEV: make prettier happy
...
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 ( #7546 )
2019-05-16 10:34:19 +02:00
a36fe019bb
DEV: Fix race condition when enqueuing edit wiki-ed notification.
2019-05-16 13:48:46 +08:00
636b75fa16
REFACTOR: remove duplicate reject loop and implicit return
...
e8fafbc123
2019-05-16 10:04:04 +05:30
227bedebf7
DEV: Fix modifying a frozen string.
2019-05-16 11:30:31 +08:00
7cd1067f3d
FIX: Select-kit too narrow in topic timer
2019-05-15 17:58:40 -04:00
501bee56b7
Make prettier happy
2019-05-15 23:46:50 +02:00
7eea55d564
PERF: remove "new posts" stat from summary email
...
It performs horribly and isn't a personalized stat like the others.
2019-05-15 16:28:21 -04:00
db89722a98
UX: ignore leading/trailing whitespaces in site settings search
2019-05-15 22:22:20 +02:00
b9fcb2bcdf
DEV: Add before button hook in post-menu. ( #7550 )
2019-05-15 22:48:23 +03:00
0ef25f7a66
prettier
2019-05-15 13:35:58 -04:00
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles ( #7549 )
2019-05-15 13:26:25 -04:00
9a17b19636
FIX: don't hide back button at the bottom of timeline ( #7544 )
2019-05-15 19:02:48 +02:00
fc5bb39096
FIX: Do not send duplicate alerts for the same post ( #7476 )
2019-05-15 18:47:36 +02:00
1299c94a52
FIX: Make serverside and clientside omniauth origin redirects consistent
...
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
2019-05-15 12:40:51 +01:00
1d3375b176
FEATURE: Preserve notifications levels when splitting topics. ( #7494 )
2019-05-15 17:29:29 +10:00
42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
e0fe01925e
FIX: make frozen string mutable in incoming_domain
2019-05-14 17:44:53 +02:00
d127119549
REFACTOR: user-selector take 2 ( #7540 )
2019-05-14 09:43:29 +02:00
624184560e
PERF: improve performance of publish_notifications_state
...
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.
On some heavy notification related sites this can be a major CPU user on PG
This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
2019-05-14 16:02:55 +10:00
6f747c6b71
FIX: don't allow username to be changed to same as password
...
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
2019-05-13 16:43:40 -04:00
bbab60fa9b
FIX: Don’t try to delete inactive moderators
...
follow-up to 6d77156a
2019-05-13 21:44:03 +02:00
7707d5db2d
Revert "REFACTOR: user-selector ( #7529 )"
...
This reverts commit 9a56df89f0
2019-05-13 19:39:30 +02:00
a2b1789c3e
FIX: do not log username change if the save process was unsuccessful
2019-05-13 22:20:27 +05:30
fb1da53dff
FIX: Issue with incorrect heights when cloaking plugin content in posts
...
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.
Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
7326ddea6d
REFACTOR: tags mixin ( #7533 )
2019-05-13 17:05:21 +02:00
b8db702a02
REFACTOR: admin-user-index route ( #7534 )
2019-05-13 17:04:41 +02:00
717aa764b6
FIX: more efficient topic-footer-button-api ( #7535 )
2019-05-13 17:04:24 +02:00
750c125707
DEV: Include foreign keys in model annotations
2019-05-13 15:53:42 +01:00
607c671003
Fix string literal when switching theme in dev env
2019-05-13 10:25:51 -04:00
f1b0782624
UI: Adjust footer nav bar size in iOS app
2019-05-13 10:25:51 -04:00
1bff81419e
DEV: Update annotations
2019-05-13 15:24:24 +01:00
53d2232731
FIX: Remove trailing slash from topic URL
...
this lead to duplicate slashes in concatenated URLs
2019-05-13 14:51:45 +02:00
df18243827
FIX: prevents exception if report doest define filters ( #7532 )
2019-05-13 13:34:28 +02:00
9a56df89f0
REFACTOR: user-selector ( #7529 )
2019-05-13 13:03:12 +02:00
25b39b86ae
FIX: reload the user record instead of fetching via email
2019-05-13 15:16:53 +05:30
e64ed9dbc1
REFACTOR: edit-category controller ( #7527 )
2019-05-13 11:30:32 +02:00
64c117519e
Fix modifying frozen strings errors take 3.
2019-05-13 16:45:23 +08:00
74989783da
Fix modifying frozen strings error in `OneboxController`.
2019-05-13 16:25:52 +08:00
b584e30902
Fix modifying frozen strings error take 2.
2019-05-13 16:23:45 +08:00
9b75320d63
FIX: track mutations on topic edit category-chooser only on select ( #7528 )
2019-05-13 10:22:28 +02:00
d643294c9d
FIX: delete duplicate invites earlier in the process
...
There was a race condition when 2 invites existed for 1 user where in some
cases data from both invites would be used for the redeem. Depending on DB
ordering.
Fix is to delete duplicate invites earlier in the process prior to
`redeem_from_email` being called.
2019-05-13 17:42:39 +10:00
81c329fbb8
FIX: Customizing missing pluralized translations didn't work
2019-05-13 09:36:05 +02:00
d369b84ced
Fix modifying frozen strings error.
2019-05-13 14:31:20 +08:00
8165ceb320
Make rubocop happy.
2019-05-13 09:55:44 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
a859ddc77e
Improve theme/component delete modal warning
2019-05-10 14:14:12 -04:00
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
643c75c419
FIX: Don't increment version if the reviewable operation fails
...
In fact, roll back the entire operation in the database.
2019-05-10 09:53:25 -04:00
abbe812a0d
FIX: Correct CSS for instagram video play icon
2019-05-10 10:46:07 +01:00
4096d559b5
REFACTOR: user-stream model ( #7515 )
2019-05-10 10:05:43 +02:00
a85b7feef4
REFACTOR: composer controller ( #7516 )
2019-05-10 10:05:29 +02:00
7aedc92a35
REFACTOR: login-controller ( #7514 )
2019-05-10 10:05:11 +02:00
63a3caa516
FIX: Don't display option for users to flag and notify a bot.
2019-05-10 10:05:03 +08:00
0ab6c6e24e
PERF: speed up spec suite, avoid featuring topics
...
Before: 6:05
After: 5:42
Featuring topics for `list/categories` is a very expensive operation that
happened each time we created a topic. This introduces a test only bypass
2019-05-10 11:37:53 +10:00
34684af195
FIX: Show error message if message exists
2019-05-09 22:12:51 +02:00
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
8dfb15a2e5
FIX: Do not show self edits in Post Edits report. ( #7510 )
2019-05-09 20:39:17 +03:00
ea3004ef11
UX: Save scroll position in tags topic list. ( #7511 )
2019-05-09 20:39:03 +03:00
2a45933ff2
FIX: reduce iPad app nav padding
2019-05-09 10:25:22 -04:00
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. ( #7509 )
2019-05-09 14:08:10 +03:00
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
977ffa20f4
FIX: variable is different from key ( #7512 )
2019-05-09 10:03:33 +02:00
427979e7e5
FEATURE: use full screen login by default for social login methods ( #7481 )
2019-05-09 10:03:01 +05:30
8ec1f8cf07
DEV: Correct naming convention for JS file.
2019-05-09 10:18:29 +08:00
8c07c272f2
make rubocop happy.
2019-05-09 05:25:44 +05:30
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
e6cfc584d0
Revert "FIX: frozen string exception ( #7506 )"
...
This reverts commit c4b7fb2754
2019-05-08 17:27:09 +02:00
497c0ba418
Revert "FIX: frozen string exception ( #7505 )"
...
This reverts commit 2938e3f033
2019-05-08 17:27:03 +02:00
24ca074f3f
FIX: short description title on client side when empty description
...
follow-up 77af097c
2019-05-08 17:07:12 +02:00
e84531a6a6
FIX: Correctly clear theme stylesheet cache when changing color scheme
2019-05-08 16:02:55 +01:00
54c2f24ee9
REFACTOR: composer model ( #7499 )
2019-05-08 16:53:12 +02:00
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
4aaee7ee35
REFACTOR: change-timestamp controller ( #7498 )
2019-05-08 16:26:51 +02:00
c4b7fb2754
FIX: frozen string exception ( #7506 )
...
Initial backtrace:
```
/var/www/discourse/app/models/incoming_domain.rb:29:in `to_url'
/var/www/discourse/app/models/incoming_link.rb:83:in `referer'
/var/www/discourse/app/models/incoming_link.rb:106:in `referer_valid'
```
2019-05-08 16:25:54 +02:00
b409dab77f
Rename `flags_default_topics` to `reviewable_default_topics`
...
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
77af097ce0
FIX: add short description to title on client side
2019-05-08 15:03:33 +02:00
b717e23ceb
FIX: Dynamically adjust scale when rendering wizard canvases
...
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
861023f0d6
FIX: Skip attachments in click track.
2019-05-08 11:55:31 +03:00
f04518fdf9
DEV: Reduce number of jobs enqueued.
...
Apply code review suggestion from
405ba00c08
2019-05-08 15:58:08 +08:00
405ba00c08
FEATURE: Create notifications on wiki edits for watching users.
...
* Moves creation of notification into background job.
2019-05-08 15:31:10 +08:00
46ea69a73c
UX: Initialize client side category model with right search_priority.
...
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
626534ad94
FIX: lighten instead of adding transparency to consolidated pageviews ( #7495 )
2019-05-07 18:14:13 +02:00
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign ( #7497 )
2019-05-07 12:25:10 -03:00
e20f13ebb7
fix css of prev and next page links, move them to bottom of page ( #7465 )
...
Thanks 👍
2019-05-07 17:04:27 +02:00
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
Joffrey JAFFEUX
romanrizzi
Dan Ungureanu
Robin Ward
Neil Lalonde
Gerhard Schlager
Penar Musaraj
Arpit Jalan
Joe
Kris
Régis Hanol
Vinoth Kannan
Ralph Rooding
Mario Santos
David Taylor
Bianca Nenciu
Julian Calvento
OsamaSayegh
Rafael dos Santos Silva
Sam Saffron
Jeff Wong
Daniel Waterworth
Guo Xiang Tan
Maja Komel
tshenry
Bianca Nenciu
Saurabh Patel
Blake Erickson