1fdeec564b
PERF: Move `where` clause up to speed up CalculateAvgTime daily job ( #7462 )
...
Cuts down affected posts earlier in the query, so the generated plan
deals with less rows, and runs faster.
https://meta.discourse.org/t/post-calculate-avg-time-taking-up-a-long-time/49750/13?u=falco
2019-04-30 13:34:46 +10:00
dca7f8ecf2
FIX: Loading more broken on groups page.
...
Regressed in 1f17d52f55
2019-04-30 10:35:17 +08:00
75a6c440f7
DEV: Spec clarification example ( #7458 )
2019-04-30 09:41:24 +08:00
7b1783bae8
FIX: cache_critical_dns was never caching pg replica ( #7461 )
...
* it's DISCOURSE_DB_REPLICA_HOST not DISCOURSE_DB_BACKUP_HOST
2019-04-30 08:42:51 +08:00
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
0a5a6dfded
DEV: stop mutating inputs as a side effect
...
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.
This handles all the cases where specs caught this.
Mutating inputs makes code harder to reason about. Eg:
```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```
This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
2019-04-30 10:25:53 +10:00
442111af91
DEV: remove a couple of warnings from spec
2019-04-30 08:41:28 +10:00
a00354f11f
Prettier site-settings/group-list.js.es6
2019-04-29 16:26:13 -04:00
1ba72ccab8
DEV: add site setting type group_list for a list of groups
...
Add a js test
2019-04-29 16:15:22 -04:00
526e76ced2
FIX: Use PostgreSQL 'ON CONFLICT' to deal with race condition
...
On busy sites, concurrent requests to insert into post_timings can
occur, which was dealt with using Ruby exceptions.
This moves the handling to PostgreSQL which makes it a bit faster,
and prevents a spam of ERROR in the database logs.
2019-04-29 16:34:42 -03:00
bfadb1fabc
FIX: use more specific target for ".tag-box"
...
This avoids tags named "box" from receiving styling aimed at this specific element on the tag list page.
2019-04-29 13:55:40 -04:00
f8f7091e57
FIX: staff-only tags visible on /tags page when restricted to a category
...
If a tag group is set to only be visible to staff, and is restricted
to a category that is visible by everyone, the tags in the group were
being shown on the /tags page. They weren't visible anywhere else.
This commit fixes it so they don't show on the /tags page.
2019-04-29 12:38:28 -04:00
56f6065393
FIX: Generate ASCII slug with default locale
2019-04-29 18:29:58 +02:00
b75720d911
FIX: skip click-tracking for mentions
2019-04-29 12:05:47 -04:00
876c4f20b3
FIX: Remove duplicate Emoji names from blurb
...
The blurb contained the value of the alt and title attribute of Emojis. Both values are always the same.
2019-04-29 17:26:39 +02:00
71d19f6e1f
FIX: Reduce mentions in blurbs to @username or @groupname
...
The link to the user profile or group is useless and the URL encoded username or group name looks awful for Unicode names
2019-04-29 17:26:39 +02:00
5d4aa256be
FIX: category logo upload error in Discuz importer.( #7453 )
2019-04-29 17:01:15 +02:00
5768011cad
FIX: prevents exception in the composer with regexp flags
2019-04-29 16:58:17 +02:00
629ae7a5b7
FIX: Revert tracking links in quotes
2019-04-29 10:30:04 -04:00
aef35faefc
FIX: Open links in external tabs. ( #7444 )
2019-04-29 10:27:29 -04:00
ca9fd95a08
FIX: Respect "open external links in new window" in quotes and edit history
2019-04-29 10:13:53 -04:00
7a27c93c03
FIX: URL encode username and first letter in avatar URL
...
And it adds specs as a follow-up to aadb7da7
2019-04-29 15:08:14 +02:00
286f2abc65
FIX: prevents exception when clicking directly on site text
2019-04-29 12:07:30 +02:00
7afc36420c
Revert "PERF: Call web hook events in a new thread ( #7451 )" ( #7456 )
...
This reverts commit 09ae12bd5d
2019-04-29 18:50:34 +10:00
09ae12bd5d
PERF: Call web hook events in a new thread ( #7451 )
2019-04-29 18:50:12 +10:00
82a6cf8afd
Take 2 of 0f5161af19.
2019-04-29 16:41:35 +08:00
0f5161af19
DEV: Fix invalid constant after upgrading lograge to 0.11.0.
2019-04-29 16:19:29 +08:00
1d784c7a18
FEATURE: adds support for dates in polls ( #7450 )
2019-04-29 10:01:19 +02:00
ac3dab93f5
DEV: lint the files
2019-04-29 17:40:53 +10:00
45285f1477
DEV: remove update_attributes which is deprecated in Rails 6
...
See: https://github.com/rails/rails/pull/31998
update_attributes is a relic of the past, it should no longer be used.
2019-04-29 17:32:25 +10:00
3b95f34e7b
DEV: Rails 6 compatability
...
Without forcing a reload on start internal state in the accelerator can be
off. In Rails 5 not translation is being called so this is not an issue but
in 6 it is called earlier on.
2019-04-29 17:13:30 +10:00
1b1cfd4507
add no_subcategories query param in url only if its true ( #7439 )
2019-04-29 15:10:59 +08:00
fe86941cb6
FIX: prevents exception when search q params is a hash ( #7437 )
...
* FIX: prevents exception when searh q params is a hash
* raise when invalid format
2019-04-29 15:09:25 +08:00
ad44243a57
Removed unused let blocks ( #7446 )
...
The bodies of these blocks were never evaluated.
2019-04-29 15:08:56 +08:00
17b34f5744
DEV: correct heisentest
...
This test failed IF this category id number 3 was fabricated to start with
at the top of the test.
This is very likely if the test is run on a blank DB
2019-04-29 16:57:09 +10:00
09b3d0c2a0
DEV: Only install danger on Travis. ( #7452 )
2019-04-29 14:45:24 +08:00
fa313564d7
DEV: update rails multisite
...
This gives us Rails 6 support, should not impact existing behavior
2019-04-29 16:24:47 +10:00
c448e014fe
Recover missing old scheme uploads from tombstone directory too.
2019-04-29 11:33:57 +05:30
a7b840c203
DEV: Run with Ruby 2.6.3 on Travis.
2019-04-29 13:59:34 +08:00
c0a5a07eda
DEV: missing change from prev commit
2019-04-29 15:52:47 +10:00
09638fcd27
DEV: add note explaining why omniauth-google-oauth2 is pinned
2019-04-29 15:47:05 +10:00
7ea5c8a5f5
DEV: update AWS dependency
...
AWS is a big moving target, this fills gaps in the API. Technically we
use such a tiny surface area that it probably does not matter, but it is
good to be up to date here.
2019-04-29 15:39:19 +10:00
2d9c8581ce
DEV: low risk gem updates
...
This updates another batch of gems that are lowish risk
Most of the gem changes are here for Rails 6 / Ruby 2.6.3 support
Excon did some stuff around better cipher ordering
2019-04-29 15:33:01 +10:00
8ca73235dd
DEV: add diagnostics to erratic test
2019-04-29 15:19:05 +10:00
9797073de0
DEV: update mini_sql and some other gems
...
Big one is mini_sql, only noticeable change is that the internals now
support jruby!
2019-04-29 15:04:19 +10:00
75c1506cb0
DEV: update minor dependencies
...
These gems have very minor changes, and are low risk updates
2019-04-29 15:00:58 +10:00
b3d91ea541
DEV: update rubocop
...
No changes required in core Discourse.
2019-04-29 14:57:30 +10:00
5d96c5cb84
FIX: set upper limit on clean up invalid users (10 years)
...
Note... this setting is quite new so I am not adding a migration here to
clean up history. Instead next time users save the setting it will complain.
Also explicitly call out that the value 0 is special and used to disable
the job.
2019-04-29 14:51:15 +10:00
574f39f9d0
FIX: Fixed uploadPlaceholder regex failing on not escaped characters ( #7442 )
2019-04-29 12:32:48 +10:00
6449170e15
DEV: update mini racer version
...
Mini Racer 0.2.5 provides support for libv8 7.3 (so we just upgraded from
Chrome 67 -> 73 JS engine wise)
2019-04-29 10:22:27 +10:00
Rafael dos Santos Silva
Guo Xiang Tan
Daniel Waterworth
Michael Brown
Sam Saffron
Neil Lalonde
Penar Musaraj
Gerhard Schlager
MMX
Joffrey JAFFEUX
Bianca Nenciu
Vinoth Kannan
Saurabh Patel
Tim Lange