039b4758ac
fix 1.9.3 regression, [] does not work on OpenStruct there.
2013-06-26 21:49:29 +10:00
48d7a33157
Flag UI now displays deleted status for post/topic correctly on old flags
...
Commented out a spec that was failing in order random, with a TODO
2013-06-26 16:18:50 +10:00
65dc04c00e
simplify flag reporting and correct it so it properly displays old flags
2013-06-26 15:57:55 +10:00
3af12ba7d3
Merge pull request #1088 from ComputerDruid/fix-ipv6
...
Fix ipv6 addresses in the database
2013-06-25 17:25:48 -07:00
9f6b7889a8
views: convert 'ip' (bigint) -> 'ip_address' (inet)
...
This fixes all known issues when connecting to discourse over IPv6.
This table has no primary key, so the migration is done with update_all,
for each ip address in the views table. Since this table can potentially
grow quite large, this process might take a long time. I don't know any
way around this, though.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the View model class, which should keep the
migration from failing if that class is modified in the future.
2013-06-25 19:47:25 -04:00
2e478d8537
TopicLinkClick: convert 'ip' (bigint) -> 'ip_address' (inet)
...
When accessed over IPv6, the ip address of the user is a 128-bit number,
too big for PostgreSQL's bigint data type. Since PostgresSQL has the
built-in inet type, which handles both IPv4 and IPv6 addresses, we
should use that instead. Where this is done elsewhere in the codebase,
the column is called ip_address, so we should follow that convention as
well.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the TopicLinkClick model class, which should
keep the migration from failing if that class is modified in the future.
2013-06-25 19:41:19 -04:00
a86b35c873
Remove the access_password site setting
2013-06-25 15:05:25 -04:00
06be760257
adds TopMenuItem model which encapsulates top_menu parsing logic
2013-06-24 10:04:18 -07:00
d12288de49
adding a missing User association
2013-06-24 17:08:49 +03:00
25bb8cf382
remove dead uncalled code
2013-06-23 15:28:38 +10:00
ea932b74e7
values is a much more consistent name than all_values ... we use {}.values not {}.all_values
...
also fixes random ordering of tests failure in site settings
2013-06-23 15:07:49 +10:00
22d6f6784c
Merge pull request #1075 from ZogStriP/fix-lightboxing-when-using-s3
...
FIX: lightbox wasn't working when using s3 upload
2013-06-23 22:11:45 -07:00
287d0dbd75
bad locale files could lead to broken automatic groups
2013-06-23 14:44:16 +10:00
298949a343
missing dependency
2013-06-23 14:32:46 +10:00
fc6983d238
basic requires that 20 topics are entered thanks @novemberkilo
2013-06-23 14:32:37 +10:00
08aa23f0ca
FIX: lightbox wasn't working when using s3 upload
2013-06-22 13:38:42 +02:00
bb908d5913
Email parsing uses Traditional Markdown Linebreaks by default. Added JS tests for line breaks.
2013-06-21 11:37:26 -04:00
bfdbf373f3
Don't show invisible topics in uncategorized on categories page
2013-06-21 11:36:00 -04:00
455742d3ee
Merge pull request #1062 from ComputerDruid/fix-which-s
...
Use "command -v" to test for convert instead of "which -s"
2013-06-21 07:12:42 -07:00
8dceb655db
Merge pull request #1058 from ZogStriP/delete-optimized-images-when-cleaning-up-orphans
...
make sure we also delete optimized images
2013-06-21 07:10:28 -07:00
8a751e6e44
make sure we also delete optimized images
2013-06-21 09:34:02 +02:00
777e8c2012
Correct spelling of suppress
...
supress => suppress
Amos King @adkron <amos.l.king@gmail.com>
2013-06-20 23:44:27 -05:00
8009b3f036
Use "command -v" to test for convert instead of "which -s"
2013-06-20 21:42:18 -04:00
f39f44ddbf
Categories page should not show invisible topics
2013-06-20 16:07:53 -04:00
4aa20cf23c
Merge pull request #1053 from vipulnsward/remove_var
...
Remove unused var.
2013-06-20 09:54:34 -07:00
5e5ef9cafd
Remove unused var.
2013-06-20 20:58:05 +05:30
9f3d5b9f1e
Merge pull request #1044 from ZogStriP/clean-orphan-uploaded-files
...
added a rake task to clean orphan uploaded files
2013-06-20 07:53:50 -07:00
2e7c5a674c
Merge pull request #1049 from ZogStriP/admin-alerts
...
Admin alerts
2013-06-20 07:51:40 -07:00
70683c1f09
Merge pull request #1034 from chrishunt/rebake-oneboxes
...
Optionally rebake oneboxes with posts:rebake task
2013-06-20 01:18:57 -07:00
08df4c41cc
Merge branch 'master' of github.com:discourse/discourse
2013-06-20 17:42:29 +10:00
4a8a663a67
flagging workflow changes per http://meta.discourse.org/t/we-need-an-archive-flag-notification-button/7450
2013-06-20 17:42:15 +10:00
8a26b86739
added image magick alert
2013-06-19 22:36:56 +02:00
9036738ba2
added s3 file uploads alert
2013-06-19 22:11:11 +02:00
4a17d6dca6
added a rake task to clean orphan uploaded files
2013-06-19 21:51:41 +02:00
5ef6714d48
New site setting: `minimum_topics_similar`, allows you to specify a minimum amount
...
of topics that need to be in the database before it will suggest similar topics as
a user creates a post.
2013-06-19 13:14:24 -04:00
ef76e18215
Optionally invalidate onebox in PostAnalyzer#cook
2013-06-19 00:19:42 -07:00
799b402778
fix horribly broken invite code, could lead to inviting the wrong person to a conversation
2013-06-19 10:31:19 +10:00
6989851cd4
Merge pull request #1038 from ZogStriP/keep-uploads-reverse-index-up-to-date
...
Keep uploads reverse index up to date
2013-06-18 00:43:31 -07:00
80c42753e1
fix up find as you type for the invite into PM function
...
allow mods to remove users from a PM
2013-06-18 17:17:01 +10:00
7abb20928b
Merge pull request #1033 from chrishunt/move-dynamic-favicon-to-user
...
Move 'dynamic favicon' setting to User preference
2013-06-17 17:31:02 -07:00
8acdc18bc8
First stab at polling support for POP3S / reply by email
2013-06-17 16:49:02 -04:00
ae3543872c
renamed the `sha` column to the proper `sha1`
2013-06-17 22:16:14 +02:00
281a08a99f
Allow people to capitalize a word when ninja-editing a post
2013-06-17 15:57:13 -04:00
3c7eb3a4e8
FIX: null dates crashed the client app. `last_posted_at` was not updating properly on split topic.
2013-06-17 13:02:50 -04:00
af45b5a11e
proper column naming
...
silly schemaless database habits are hard to kill
2013-06-17 04:02:17 +02:00
454636abf1
annotate models
2013-06-17 02:49:34 +02:00
510bac4b27
refactored a bit & tested thumbnails creation
2013-06-17 02:49:34 +02:00
cc9e0ec80a
create thumbnails when needed
2013-06-17 02:49:34 +02:00
d4c3fe4e6a
added `create_thumbnails?` site setting
...
defaults to `false`
2013-06-17 02:49:34 +02:00
5de03814fb
created `optimized_image` model
2013-06-17 02:49:34 +02:00
2c3f757951
moved `has_been_uploaded` and `uploaded_regex` to the `Upload` model
2013-06-17 02:49:34 +02:00
8a98310cf9
make sure we only do the work once
2013-06-17 02:49:34 +02:00
6c4554b941
identifies all uploads with the SHA1 hash of the file content
2013-06-17 02:49:33 +02:00
6ea91b4416
remove useless upload topic direct association
2013-06-17 02:49:33 +02:00
b545a49d32
Merge pull request #1025 from ZogStriP/reverse-index-take-2
...
Reverse index take 2
2013-06-16 16:49:57 -07:00
09d3800701
Move 'dynamic favicon' from Server to User pref
2013-06-14 23:58:24 -07:00
f62c421c91
Render category descriptions differently on the categories page
2013-06-14 11:18:44 -04:00
037f62928b
add proper post_uploads reverse index
2013-06-13 23:44:24 +02:00
4db8204a15
Remove topic links when a post is deleted
2013-06-13 13:41:54 -04:00
49c09898e2
The EmailBuilder now creates the Reply by Email Key if necessary.
2013-06-13 12:40:06 -04:00
e29f4a3496
Work in Progress: Reply By Email:
...
- Add support classes and settings to enable reply by email
- Split out Email builder to be more OO, add many specs
2013-06-13 12:39:56 -04:00
ef18a3ad5c
Locales should be sorted in dropdown
2013-06-13 12:18:11 -04:00
cb40ceb9e8
Merge pull request #1019 from ZogStriP/reverse-index-of-user-uploads
...
added a reverse index of user uploads + rake task
2013-06-13 07:20:55 -07:00
f7de9f17d5
refactor validators
...
add a new setting for min pm body length
use that setting for flags
scale entropy check down for pms
2013-06-13 18:18:43 +10:00
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
770c1faeb1
added a reverse index of user uploads + rake task
2013-06-13 01:43:50 +02:00
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
28ac110a3c
Add eu-west-1 to s3 regions
2013-06-12 12:02:47 -04:00
c1f6169b48
hidden and deleted state in user stream
2013-06-12 11:14:08 +10:00
8a2d635e62
removed imgur support
2013-06-11 21:51:41 +02:00
811a0df68b
Make s3 region site setting a drop down
2013-06-11 14:24:04 -04:00
5ff7e570ac
Add support for enum site settings that render as a dropdown; use a dropdown for default_locale
2013-06-11 11:40:14 -04:00
b4a4774165
extend consumer email warning to yahoo & outlook
2013-06-10 00:08:06 -07:00
4f606ffd8e
Some minor cleanups
...
1. Change map to keys
2. Remove overshadow
3. Remove var
2013-06-10 10:38:10 +05:30
6a6496eedf
Merge pull request #995 from novemberkilo/master
...
Refactoring Post model
2013-06-09 16:19:06 -07:00
2d14b54096
Merge pull request #988 from chrishunt/add-dynamic-favicon
...
Add 'dynamic favicon' setting
2013-06-09 16:13:54 -07:00
3fdba0019b
Extract callbacks and validations for Post
...
Move Post create callbacks to PostCreate
Extract Post validations
Move stripped_length_validator to lib/validators
2013-06-09 20:47:04 +02:00
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
af1c14939e
Add 'dynamic favicon' setting
2013-06-07 17:15:49 -07:00
463be6fadf
Merge pull request #982 from jd-erreape/add_scopes_to_roleable
...
Added role scopes to roleable
2013-06-07 12:08:26 -07:00
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
36fe8fbc6d
Added role scopes to roleable
2013-06-07 18:26:06 +02:00
1b92d9d7f8
Added roleable module for User model
2013-06-07 12:33:48 +02:00
f6ce985121
Send activation email after user approved
2013-06-06 18:37:25 -07:00
1eed1e240b
Merge pull request #977 from chrishunt/add-apple-touch-icon
...
Add 'apple touch icon url' site setting
2013-06-06 17:40:12 -07:00
268a5debbf
Add 'apple touch icon url' site setting
2013-06-06 14:43:05 -07:00
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
f268b882fd
The posts rebake task should regenerate links too.
2013-06-06 13:52:30 -04:00
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
f030d9b420
Make default_logo_check more smarter
2013-06-05 16:59:19 -04:00
4e8ff74b99
Show dashboard warning when favicon and/or logo urls contain the same filename as the shipped defaults
2013-06-05 16:43:39 -04:00
b55182b983
Use PostDestroyer when deleting all of a user's posts; deleting a post removes its flags and resets its flag counts
2013-06-05 16:05:13 -04:00
dfba2b6e0a
FIX: Strip links from google indexed bios when the users are new.
2013-06-05 15:28:10 -04:00
24da1ab07e
Add 'invite only' site setting
2013-06-05 11:06:05 -07:00
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
2509d0f4fa
Merge pull request #959 from chrishunt/chrishunt/login-required-fixes
...
'login required' site setting improvements
2013-06-04 19:09:40 -07:00
3074300f76
Allow customization of 'login required' message
2013-06-04 18:53:36 -07:00
9a57aaaaa9
fix encoding for category excerpt
...
fix missing secure category topics in categories page
2013-06-05 11:22:47 +10:00
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
85ceb5efa7
Add 'login required' site setting
2013-06-04 16:10:10 -07:00
e3e55d4dad
fix image uploads on s3/imgur
2013-06-05 00:35:42 +02:00
2465c9c724
Add min_private_message_title_length site setting so private messages can have short titles
2013-06-04 17:59:23 -04:00
4392a17b54
Strip out links when displaying a new user's bio
2013-06-04 12:06:25 -04:00
2259e97d42
Add a count of blocked users on the dashboard
2013-06-04 11:53:19 -04:00
c4904aacc0
Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.
2013-06-03 16:37:40 -04:00
33d0a6a876
FIX: Safety checks for categories index
2013-06-02 11:20:08 -04:00
cab3502c15
Replace PostAnalyser module with a class
...
Encapsulate Post#cooked_document as well
Include specs for PostAnalyzer class
2013-06-01 14:59:27 +02:00
545dbfc07e
New Feature: Staff can choose to "Take Action" when flagging to immediately reach hiding
...
thresholds.
2013-05-31 17:39:32 -04:00
d23ef1d090
FIX: You could update a topic to have a title that's too short if the TextCleaner
...
removed extra characters. Additionally, updating the title will not return an error
message to the client app if the operation fails (rather than failing silently.)
2013-05-31 15:24:13 -04:00
0af0a214b2
Refactor: Back all modals by controllers
2013-05-31 12:29:38 -04:00
830b7805e9
Merge pull request #927 from bplexico/extract_invite_redeemer
...
Extract InviteRedeemer from Invite
2013-05-31 08:30:42 -07:00
d2c1eb090e
Merge pull request #921 from nirnanaaa/postgres-truefalse
...
removed t's and f's from models
2013-05-30 21:38:26 -07:00
41187a5de1
Merge pull request #931 from ZogStriP/more-file-upload-test-coverage
...
added more file uploads test for better coverage
2013-05-30 21:36:33 -07:00
6cc0f8f2d4
added more file uploads test for better coverage
2013-05-31 03:13:37 +02:00
807f763fb0
Merge remote-tracking branch 'upstream/master'
2013-05-30 21:42:26 +02:00
24e32092e7
Refactored two class methods into scopes (to achieve a better 'rails way')
...
Also added some tests to the methods
2013-05-30 21:21:31 +02:00
b82a5dfd56
Move logic to reject slugs that are just numbers into the slug module
2013-05-30 11:54:02 -04:00
0591d5be11
Extract InviteRedeemer from Invite
2013-05-30 11:49:11 -04:00
7d5c313456
Don't allow category slugs that are numbers
2013-05-30 11:09:09 -04:00
6ad86aa305
read state is now published
2013-05-30 16:49:58 +10:00
e93b7a3b20
more progress towards live unread and new counts, unread message implemented, still to implement delete messages
2013-05-30 16:49:57 +10:00
73834370a5
work in progress, live unread and new counts
2013-05-30 16:49:57 +10:00
33ff87bf44
work in progress, live unread / new counters
2013-05-30 16:49:57 +10:00
830b93a16b
Reduced complexity of admin flags controller, split up into methods, moved reports into model.
2013-05-29 16:49:34 -04:00
364113a4d5
removed t and f 's from group model
...
removed t and f 's from user model as mentioned in #919
removed t's and f's from category model
2013-05-29 22:10:43 +02:00
6abd9ddd2d
Add warning on admin dashboard if production env is configured to send email through gmail
2013-05-29 14:00:35 -04:00
92dc59fba9
Properly assign draft keys to Categories List view.
2013-05-28 21:16:24 -04:00
46389754d6
Merge pull request #892 from eriko/cas_support
...
Cas support
2013-05-28 16:13:29 -07:00
ee319ea7f7
FIX: Issues that didn't show up originally
2013-05-28 15:57:11 -04:00
560fb15d8a
Include pinned topics in category list.
...
- removes an (n+1) query for user data
- supports the preload store for the data to avoid a second request
- fix a bug where uncategorizes was reporting (0, 0, 0) for topics by week, month, year
2013-05-28 15:36:16 -04:00
320b35bf90
Merge pull request #910 from novemberkilo/master
...
WIP - Reduce complexity of Post#raw_links
2013-05-28 10:07:41 -07:00
21a54567ff
Extract TopicStatusUpdate from Topic
2013-05-28 09:01:04 -07:00
9a409d9440
fix comment and remove url setting as it is not used.
2013-05-28 08:06:18 -07:00
1d5952a92f
Extract analysis type methods to a module and refactor Post#raw_links
2013-05-28 16:41:18 +02:00
54a798eb12
Add Topic#age_in_days for determining age of topic
2013-05-27 18:02:15 -07:00
d2f2a8e218
refactoring
2013-05-28 09:13:53 +10:00
62a20f5655
FIX: Couldn't access "Uncategorized" category from category list.
2013-05-27 14:15:52 -04:00
b1ef2ea1e1
Fix TopicPostersSummary when a suggested topic includes a user who has been deleted
2013-05-27 14:12:15 -04:00
197909246c
Weigh staff likes higher when calculating scores. New site setting: `staff_like_weight`
...
can set the factor (default is 3)
2013-05-27 12:46:08 -04:00
e1781240a6
Merge branch 'refactoring' of git://github.com/mattvanhorn/discourse
...
Conflicts:
lib/text_sentinel.rb
2013-05-27 10:42:20 -04:00
a15910ad1e
Merge pull request #899 from chrishunt/chrishunt/extract-topic-posters-summary
...
Extract topic posters summary
2013-05-27 06:30:58 -07:00
bf16b4f381
Merge pull request #903 from chrishunt/chrishunt/extract-post-move
...
Extract post move
2013-05-26 19:10:50 -07:00
6024529f81
Extract PostMover from Topic into its own class
2013-05-26 18:42:04 -07:00
d84ae80074
Simplify user action make it more idiomatic
2013-05-27 10:22:37 +10:00
f58bcf7fe3
Refactored duplication in user action
2013-05-26 16:07:20 +03:00
b8fbac582e
Add Topic#url for determining url for a Topic
2013-05-25 17:44:32 -07:00
f2b5e20840
Add Topic#max_post_number to find max post number
2013-05-25 17:44:32 -07:00
c4cce68613
Add Post#is_first_post?
...
We should be able to ask a post if it's the first in a topic
2013-05-25 17:44:32 -07:00
63c63c2939
Remove unused parameters from posters_summary
2013-05-24 15:33:50 -07:00
c1841a6c89
Extract Topic#posters_summary
2013-05-24 15:33:45 -07:00
e2774cc2df
Merge pull request #896 from xtream/master
...
Removed unnecesary method
2013-05-24 14:09:44 -07:00
d26b87bd3c
Add Site Setting allow_uncategorized_topics. Uncheck it to force people to choose a category for all new topics.
2013-05-24 16:56:43 -04:00
e5e904aa4e
minor refactorings
2013-05-24 13:36:33 -07:00
d7817cf314
extract TopicNotifier class from topic
2013-05-24 13:36:33 -07:00
d1fdc66ca4
FIX: For spam detection, don't count total occurances of links of the same host, but
...
post count including that host.
2013-05-24 15:20:58 -04:00
bca006feca
removed unnecesary method
2013-05-24 18:03:02 +02:00
c0c97487d8
Merge pull request #888 from novemberkilo/master
...
Refactor to reduce complexity of Post#save_reply_relationships
2013-05-24 07:04:28 -07:00
ca2dee52db
moved comments to the bottom, they are way less intrusive there
2013-05-24 12:48:32 +10:00
2cd95bc649
lets try out annotations
2013-05-24 12:35:14 +10:00
fc3c93d237
almost fixed the regression of not allowing top level filters
2013-05-24 09:54:39 +10:00
0bdee973a0
allow disabling of local logins. In the instance where an .edu is using cas they may not want a user to be able to log in once the users credentials have been revoked in the system that feeds the CAS authentication server. This is very optional
2013-05-23 13:44:14 -07:00
1575ce7b10
add cas support with a few tests
2013-05-23 13:40:50 -07:00
9aacde2f2d
Refactor Post#save_reply_relationships
2013-05-23 18:09:06 +02:00
ba4eaa0297
Helper to create reply relationship with post
2013-05-23 18:08:24 +02:00
d7219a6fbc
Helper to add a number to quoted_post_numbers
2013-05-23 18:07:45 +02:00
4492d06a9f
Don't send notifications for moderator action posts
2013-05-23 11:42:52 -04:00
0bd61df34c
Merge pull request #884 from mattvanhorn/refactor_topic
...
Refactor topic
2013-05-23 07:26:22 -07:00
c4b5821ef8
Revert annotation and non-English I18n changes
2013-05-23 06:44:47 -07:00
3dfc034e8d
Merge pull request #881 from novemberkilo/master
...
Improve flog metric for Post#extract_quoted_post_numbers
2013-05-23 00:21:27 -07:00
7271b90655
annotate topic model
2013-05-22 22:36:01 -07:00
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
4754216369
Simplify branching
2013-05-22 21:45:31 +02:00
ef93512de8
Extract quote parsing into a method
2013-05-22 21:38:45 +02:00
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
5f7f87437c
Fix for topic excerpt being from the wrong post
2013-05-18 13:35:21 -04:00
b16705be0d
Clean up update_visit_record!
...
update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
2013-05-18 16:02:06 +10:00
32f4dfd2fb
DRY up the user model slightly
...
regular? is just the inverse of staff?
2013-05-18 16:00:35 +10:00
25105082d5
Merge pull request #850 from bplexico/refactor_post_rb
...
Refactored post model to reduce duplication in validator methods
2013-05-17 15:56:53 -07:00
2acc80d192
Various idiomatic User refactorings.
2013-05-17 15:44:35 -04:00
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
191d454589
Show Inbox before Sent Items
2013-05-17 14:11:33 -04:00
d30330441a
Refactored conditional to an || to be more idiomatic.
2013-05-17 14:06:58 -04:00
a86646312b
Refactored post model to reduce duplication in validator methods
2013-05-17 12:15:21 -04:00
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
8f46653345
refactor
2013-05-17 09:03:52 +10:00
d554a59102
Support for a new site setting: `newuser_spam_host_threshold`. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
eb71e9de24
opening move, don't get rid of green notification till the pm is read
...
TODO a way to list all unread PMs
2013-05-16 16:37:47 +10:00
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
dadb7eaa23
fix crash caused by incorrect query in scope
...
setting all categories to be secured led to a blank screen on all pages
use stabby lambda for consistency in class
make the test a little more concise
- move the local assignments into let blocks for
reusability
- remove calls to `to_a`, which aren't needed
- use 'be_empty' instead of '[]' to be consistent
with the other matchers in the test
add a test for the `secured` scope with multiple
secured categories
2013-05-15 22:26:52 +01:00
18634ad00d
Don't cache the problems list with the rest of the dashboard data
2013-05-15 11:09:12 -04:00
21b4b8d5d5
Expire dashboard data when you upgrade to a new discourse version. Version check data was being cached and causing confusion to people who upgraded.
2013-05-14 16:17:25 -04:00
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
670b66ade3
better add some tests here tomorrow
2013-05-13 18:47:32 +10:00
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
4f328e3e45
+x on files makes no sense unless they really are executable
...
rails in the script dir makes no sense, use binstubs or bundler instead
2013-05-09 17:35:15 +10:00
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
f35a44aeae
Add ability for admins and mods to send another activation email to a user, to activate an account, and deactivate an account
2013-05-08 10:10:47 -04:00
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
7571152d1d
fix issue adding users to groups
2013-05-08 10:32:29 +10:00
52ee1928cc
Oops, I made a spec fail by refactoring after I made the test pass and didn't check the tests
2013-05-07 15:40:18 -04:00
8e24a608b0
Show empty categories on categories page to people people who can edit and delete categories
2013-05-07 15:31:56 -04:00
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
69be7d0ad1
Change the title Visits to Clicks in referral tables on admin dashboard
2013-05-06 11:56:35 -04:00
b944157d88
Fix edit uncategorized when on the /category/uncategorized page
2013-05-06 11:22:58 -04:00
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
392b9696f4
prevent duplicate actions on a post
2013-05-04 02:52:45 +02:00
52942d2de6
Merge pull request #813 from slainer68/ga_domain_name
...
Google Analytics Domain name site setting
2013-05-03 14:57:01 -07:00
c6370a3479
Add ability to edit the uncategorized category name, color, and text_color in a modal
2013-05-03 17:55:04 -04:00
ac66f25043
Google Analytics Domain name site setting
2013-05-03 21:58:10 +02:00
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
e59ab32210
Merge pull request #800 from goodbrews/imgur-api-v3
...
Update to Imgur API v3
2013-05-01 21:52:00 -07:00
6be26f5316
Update to Imgur API v3
...
Version 2 of Imgur's API is deprecated. Their documentation for v2 is no
longer online, and applications can only be registered under version 3.
Version 3 of their API has a slightly different endpoint but, more
importantly, uses a Client ID/Secret pair instead of an API Key.
This PR updates Discourse to use the new version of Imgur's API.
Signed-off-by: David Celis <me@davidcel.is>
2013-05-01 21:39:10 -07:00
3c7afeb233
Fix incoming links dashboard data when topic record can't be found
2013-05-01 19:10:31 -04:00
38ed86d0c5
Add reports for IncomingLinks on admin dashboard
2013-05-01 18:12:02 -04:00
e4a76812a6
this is a slightly round about way of making our self oneboxes sane
...
shrunk avatar to 60px, added global whitelisting
2013-05-01 16:38:13 +10:00
08ce46e7ed
:s/POST/REPLY/g
2013-05-01 10:52:31 +10:00
51f16333be
increase default max_likes to 50
...
WE LIKE LIKES MAN
2013-04-30 12:45:27 -07:00
20d73a4151
Fix bookmarks admin dashboard counts to include bookmarks that were deleted
2013-04-30 12:52:12 -04:00
b25a5a20bb
option to strip links from excerpts
2013-04-30 13:25:55 +10:00
dc07563c0d
Add unstarred_at column to topic_users so we can permanently track when topics are starred
2013-04-29 11:39:05 -04:00
5cfcdc7ef0
backend for secure categories mostly done (todo pm groups)
2013-04-29 16:33:43 +10:00
dca2fbcefc
add meaningful error message on upload [ fixes #773 ]
2013-04-27 20:26:17 +02:00
bbf982984d
Add TOS and Privacy Policy site settings that can link to external sites.
2013-04-26 18:46:36 -04:00
f9e33ec6b8
store ip address and current user with incoming links
...
make links long an readable in share dialog
2013-04-26 16:18:55 +10:00
f0d3500ada
Merge pull request #735 from kubabrecka/i18n_user_actions4
...
move i18n of UserActions to JS-side and make sentences translatable (take 3)
2013-04-25 15:53:17 -07:00
159c9b10d5
Add a nag to admin dashboard if you haven't changed the title site setting from the default 'Discourse'
2013-04-25 17:53:31 -04:00
db2de1eff0
Add contact_email to site settings
2013-04-24 11:15:47 -04:00
37867af1bb
track incoming links, amend share link to include user
...
fix pm styling
2013-04-24 18:05:35 +10:00
4d9dc82be0
bug fix
2013-04-24 14:39:31 +10:00
81673dcde8
slug memoization in the table
2013-04-24 12:46:43 +10:00
72508d459b
Use heat map on views column in topic lists
2013-04-23 15:06:13 -04:00
7257d65082
Add warning to dashboard if using default logo or favicon
2013-04-22 15:38:48 -04:00
439877bdb9
Show a warning if there are email jobs in the retry queue
2013-04-22 13:37:16 -04:00
ae487e740c
Add a dashboard warning when sidekiq queue has more than 100 jobs
2013-04-22 13:02:24 -04:00
cfc62dadff
speed up tests
...
add the ability to find the first notify private message
2013-04-22 17:45:03 +10:00
8827dd3e42
speed up tests
2013-04-22 13:48:41 +10:00
42fdbe2fb6
Fixing Amazon uploads to not be hardcoded to https
...
Amazon S3 uploads are currently hardcoded to use https, where they should probably use whatever protocol the rest of the site is using. Removing the protocol and just using "//" links should accomplish that.
2013-04-19 22:05:51 -03:00
b644509c28
reduce auto track default from 5m to 4m
2013-04-19 15:11:38 -07:00
6948d2cbf3
increase email notify delay to 10 mins
2013-04-19 14:59:11 -07:00
4cea92c4e9
work in progress add support for groups
2013-04-19 10:34:39 +10:00
5cd6c85e8b
Add bookmarks and favorites to dashboard stats
2013-04-18 14:27:22 -04:00
75cfcbfa4f
Need to require email in user.rb because specs can start failing when running guard
2013-04-18 14:27:04 -04:00
d355e42d73
move i18n of UserActions to JS-side and make sentences translatable (take 3)
2013-04-18 12:08:13 +02:00
b64a4100fa
change "visitor" trust level to "new user"
...
I blame me for this mistake.. visitor means other stuff in practice. New
User is correct meaning.
2013-04-17 16:11:24 -07:00
437142424c
speed up tests, fix notification of mentioned users in pms
2013-04-17 17:39:18 +10:00
3b6aeb14c7
Add subtype to topics to classify private messages
2013-04-16 16:56:18 -04:00
b24c1a1ad9
better consistency around email case sensitivity
2013-04-15 02:20:33 +02:00
2bdb53261b
don't treat notify user as a flag
2013-04-15 13:09:52 +10:00
5b4fa68e8c
Merge pull request #705 from wpp/refactor_users_controller
...
Refactor user controller, create action, mostly.
2013-04-14 18:40:19 -07:00
3dcb1905e3
Refactor user controller, create action, mostly.
...
The gist of the commit are a few improvements in the
create action, where:
* long boolean statemenst have been wrapped in smaller more readable
methods.
* the 3rd party user info creation has been extracted (still in controller)
* a small helper method for creating a new user from params (to reduce
visual clutter)
* specs have been added where I came across untested methods/branches
Other changes are more trivial like formatting and whitespace fixes.
Hope this helps. Regards.
2013-04-13 00:53:59 +02:00
48d5cb02c2
Add email as a sharing option
2013-04-12 18:06:36 -04:00
651cfba93f
Add ability to destroy a user with 0 posts
2013-04-12 16:53:00 -04:00
86b317ea73
oops
2013-04-12 18:14:36 +10:00
e969eb14e8
added 2 new flag types: notify user and notify moderators
...
fixed up messed up user navigation
refactored
2013-04-12 17:55:45 +10:00
36dc5874e5
Post image_count doesn't count favicons and thumbnails in oneboxes, so visitors can post links that get oneboxed
2013-04-11 12:36:45 -04:00
5f30ea7463
Merge pull request #684 from ZogStriP/auto-replace-rules-in-titles
...
auto replace rules in titles
2013-04-10 21:12:20 -07:00
c0f3c47196
Use message bus to broadcast addition and removal of categories
2013-04-10 15:53:36 -04:00
d120a5d139
FIX: setting min_topic_title_length is ignored
2013-04-10 14:54:10 +02:00
c5cf8be864
auto replace rules in titles
2013-04-10 11:00:50 +02:00
33e3ad1603
clean up onebox application so it uses a single code path
...
use fragments for oneboxes
strip parent <p> if <div> is in it
clean some tests
2013-04-10 17:52:38 +10:00
9b487953c4
collapse some db tests
...
ensure deleted topics do not show up in user stream
2013-04-10 12:50:00 +10:00
1ce7a40084
Revert "Merge pull request #677 from kubabrecka/localization_user_actions2"
...
This reverts commit c3a426930b9f9072bd9d
2013-04-09 12:33:32 -04:00
8d927418e8
move i18n of UserActions to JS-side and make sentences translatable
2013-04-08 22:54:08 +02:00
467d59ec5a
Merge some work: topic counts in category select; fix All count on dashboard
2013-04-08 10:23:29 -04:00
73c508115a
better consistency check
2013-04-08 13:02:20 +10:00
11ff0ccd03
correct logic for tracking the highest seen post number so its always consistent
2013-04-08 11:12:52 +10:00
1692350336
added some tests for uploads
2013-04-07 17:52:46 +02:00
a14f62766e
Replace MultisiteI18n hack with SiteContent and admin editing.
2013-04-05 16:48:15 -04:00
c6bd6371f2
Exclude recently made invisible topics from the categories list. Also remove a couple n+1 queries.
2013-04-05 16:09:27 -04:00
fe8d2377e8
admins/moderators should not receive "body is too similar" when editing
...
a regular user's post.
2013-04-05 15:38:03 -04:00
72b4f41254
Can change TOS content via site content editor
2013-04-05 15:21:55 -04:00
eb212aec9b
Fix dashboard totals for topics, posts, and private messages
2013-04-05 14:09:16 -04:00
af9b27358c
If an admin or moderator edits a visitor's post, the restrictions should be based
...
on the *editors* access rights, not the original poster.
2013-04-05 13:59:00 -04:00
0481fbae8c
Fix for reply to user avatar and picture uploading not working when editing post with discourse running in a prefix
2013-04-05 12:46:14 +02:00
5273657537
a method called "adding_user_record" is annoying me. 5 lines of code replaced with 2
2013-04-05 17:53:39 +11:00
ea8d69fbd6
fix my broken test
2013-04-05 17:47:54 +11:00
a2cca2540e
some minimal site settings diags
...
fix issue where days_visited was totally out of sync
2013-04-05 17:47:54 +11:00
a7f92ec0c1
topic reply count resync for each new post
2013-04-05 17:47:54 +11:00
4fbf017272
get regular trust level going, self heal inconsistent topic timings
2013-04-05 15:30:28 +11:00
fa1ba6791b
Work in Progress: Content Editing in Admin Section
2013-04-04 17:26:22 -04:00
e61a28f3e1
utc vs non utc is a subtle issue, tests were failing for a few hours every day cause of this
2013-04-04 13:29:54 +11:00
86cf7b1524
trust level 0 is highlighted in light gray as opposed to having special semantics around account age.
2013-04-04 12:24:23 +11:00
33f349a1e6
Show all Hot rankings at once with a toggle button
2013-04-03 15:25:18 -04:00
bb18b6cb9b
Dashboard: split out private messages from topic and post counts; re-enable report_spec because I think I fixed it...
2013-04-03 13:26:09 -04:00
459c7e3d59
Include pinned on Categories page
2013-04-03 11:45:53 -04:00
ac0bc1bb30
Including your avatar if you've posted is confusing. Let's remove it for now.
2013-04-03 11:29:50 -04:00
ee76f1926d
Debugging Tool for Hot Topics
2013-04-02 18:00:53 -04:00
202addb693
User Visits count for 30 days ago was always 0
2013-04-02 15:03:23 -04:00
e8d66beea5
Fix @notification text for non visitors
2013-04-02 11:58:12 -04:00
422dbbd25a
Exclude older topics from the first x rows in "Hot"
2013-04-02 11:15:04 -04:00
533936f3a2
increase max_mentions to 10
2013-04-01 14:31:07 -07:00
1e6f8dc93a
Include uncategorized pinned topics on 'Hot'
2013-04-01 13:49:35 -04:00
79c986dd92
Fix issue with duplicate slugs
2013-04-01 12:26:51 -04:00
68710be564
Merge pull request #610 from PragTob/ReportsRemoveDuplication
...
Battling code duplication in the Report class
2013-04-01 07:39:44 -07:00
f9ea1a448d
Merge pull request #600 from kubabrecka/consistent_topic_count
...
make sure Category.topic_count is consistent with week/year stats
2013-04-01 07:37:07 -07:00
8f518a2496
Merge pull request #604 from wpp/refactor_suggest_username
...
Improve suggest_username method in user class
2013-04-01 07:25:27 -07:00
3324f0f2d2
Battling code duplication in the Report class
...
* the reports mainly followed the same structure but with
different classes, so I took the code and a class as its
parameter
* the method on which reports.data is generated may change
but mostly is count_per_day so made that optional
* grouped the refactored methods to the top, some unrefactored
methods remain but those are a bit harder to refactor, and not
as reusable so I'd like to get this through first
* Overall I believe this patch enhances maintainability :-)
2013-04-01 15:26:58 +02:00
dce2847b4f
Merge pull request #597 from ZogStriP/fix-s3-image-upload
...
FIX: S3 image upload
2013-04-01 03:12:58 -07:00
c34f476b31
Improve suggest_username method in user.rb
...
The suggest_username method showed up on codeclimate
so I thought I'd give it some love and make it more readable.
In the process removed trailing whitespaces and had to fix a
terrible spelling error :)
2013-03-31 19:01:11 +02:00
d50b5e1fd8
make sure Category.topic_count is consistent with week/year stats
2013-03-31 13:22:05 +02:00
92aa0f45d2
Show trends on some dashboard numbers
2013-03-30 14:07:35 -04:00
0aff5042e5
FIX: S3 image upload
2013-03-30 17:56:25 +01:00
25073e873f
Fetch the list of problems more frequently on the admin dashboard
2013-03-29 15:48:26 -04:00
df85201298
Adjust hot to include more recent topics
2013-03-29 13:33:31 -04:00
436515ec6c
Dashboard checks for facebook, twitter, and github configs
2013-03-29 13:32:40 -04:00
bdfa9b0508
create the User.admins and User.moderators scopes
2013-03-29 09:52:09 +03:00
a819a26f34
BUGFIX: New status posts weren't using PostCreator
2013-03-28 16:40:54 -04:00
473a64d39d
Add score, percent_rank to topics. Adds `HotTopic` model and consolidated job to calculate
...
hotness. Note: People on Heroku will have to update their jobs to the new structure
in Heroku.md
2013-03-28 15:39:54 -04:00
1668b5eab2
FIX: allows the selection of the default landing tab
2013-03-28 14:01:13 +01:00
36269cfbaa
Rename 'popular' to 'latest'. First stab at 'Hot' tab.
2013-03-27 16:21:23 -04:00
5961ffc0e4
Add site setting to choose which share links to show and in what order
2013-03-26 17:17:37 -04:00
c57ec611e1
basic api support
2013-03-25 18:04:46 -07:00
c372e36cb6
Don't count @mentions as links in a post
2013-03-25 13:12:15 -04:00
6568b4aaa9
Better error messages when hitting max mentions/images/links
2013-03-25 12:27:09 -04:00
deb603f41c
Merge pull request #547 from kid0m4n/convert-ruby-1-9-syntax
...
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-24 16:43:17 -07:00
5dfb04e4b3
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-25 05:07:36 +05:30
36a069488e
Merge pull request #492 from sbauch/email-whitelist
...
added email whitelist SiteSetting feature to replicate email blacklist S...
2013-03-24 16:35:24 -07:00
f14cf4c97e
reduce read time required for basic user to 15m
2013-03-23 23:52:34 -07:00
842760e50e
Bump up best of to top 20%
2013-03-23 11:14:07 -04:00
3f27ffca9f
topic_poster.rb: Fix formatting of the attributes return value
2013-03-23 19:09:01 +05:30
4424328bff
remove unnecessary .gitkeep files
2013-03-23 10:45:40 +01:00
f0b57d5e4a
reduce basic user time required from 25m to 20m
2013-03-22 15:33:40 -07:00
158cda7628
Add moderator and admin count to dashboard
2013-03-22 17:50:34 -04:00
aa6e87c5c1
Dashboard memory warning
2013-03-22 15:47:35 -04:00
9c38c13ac5
The "Best Of" mode uses a percentage ranking of posts.
2013-03-22 15:44:39 -04:00
77e3434d81
added email whitelist SiteSetting feature to replicate email blacklist. email_validator method now also uses the regex method for both the whitelist and blacklist.
2013-03-22 14:49:42 -04:00
6f8d13d47e
Dashboard warning when sidekiq is not running
2013-03-22 11:35:51 -04:00
Sam
Dan Johnson
Neil Lalonde
Jesse House
Dmitriy Budnik
Régis Hanol
Robin Ward
Amos L King
Vipul A M
Chris Hunt
Chris Hunt
Jeff Atwood
Navin
Juan de Dios Herrero
Ian Christian Myers
DI2uNk
Brian Plexico
nirnanaaa
Erik Ordway
Janis Miezitis
Matt Van Horn
Victor Cruz Dueñas
Leonard Garvey
Josh Susser and Avdi Grimm
Lee Machin
slainer68
David Celis
Jeff Atwood
Shane Liesegang
Kuba Brecka
Philipp Weissensteiner
Wojciech Kocjan
Tobias Pfeiffer
Gosha Arinich
Karan Misra
Sam Bauch