Commit Graph

16652 Commits

Author SHA1 Message Date
Guo Xiang Tan 862e83287e
Merge pull request #5575 from featheredtoast/tab-index-composer-actions
tab index composer actions
2018-02-22 15:16:41 +08:00
Maja Komel 76a2fc3d07 UX: Add og metadata for groups.
https://meta.discourse.org/t/onebox-for-groups/79155
2018-02-22 15:03:41 +08:00
Guo Xiang Tan 7bcc0c1da9 FIX: Login buttons not working on sign up modal. 2018-02-22 14:01:07 +08:00
Guo Xiang Tan ae2d7ba857 Partially revert d170c8fccc to bring back 3df0626aa5. 2018-02-22 13:42:04 +08:00
Arpit Jalan d170c8fccc Revert 'Accessibility: focus management in topics'
reverts:

- 3df0626aa5
- 3212cdda78
- 59b7760e2e
- bfc1301823
2018-02-22 10:32:37 +05:30
Kane York bfc1301823 UX: Remove default focus styling from posts & topic list items
The styling is superseded by the .selected management
2018-02-22 12:21:23 +08:00
Kane York 59b7760e2e UX: Make the .selected class follow focus 2018-02-22 12:20:47 +08:00
Kane York 3212cdda78 UX: Use focus as the first selector for J/K navigation 2018-02-22 11:55:36 +08:00
Kane York 3df0626aa5 UX: Apply hover styling to post actions on focus 2018-02-22 11:55:36 +08:00
Guo Xiang Tan bbb30bedf3 Improve output of SSO verbose logging. 2018-02-22 11:26:13 +08:00
Sam f4418ae884 PERF: fast docking of timeline so it does not overlap
In the past we debounced all dock check this causes situations where
sometimes timeline would not dock in time especially on slow computers

This works around it by performing the dock by hand.

Also there was missing integer casting causing over aggressive re-rendering
2018-02-22 12:52:43 +11:00
Guo Xiang Tan 964624f3ab FIX: No error displayed when 2FA token is invalid on admin login page. 2018-02-22 09:45:57 +08:00
Guo Xiang Tan 412b298f55 UX: Smaller input field for preferences 2FA form. 2018-02-22 09:07:43 +08:00
Guo Xiang Tan 1b04d881c5 UX: Display lock icon in admin user lists when user has 2FA enabled. 2018-02-22 09:00:09 +08:00
Guo Xiang Tan edf326a9a5 Fix incorrect translation. 2018-02-22 08:06:37 +08:00
Joffrey JAFFEUX 6f5acfe783 Login with email/forget password UI refactoring
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
2018-02-22 08:06:15 +08:00
Sam 720e1965e3 FEATURE: add category suppress from latest
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.

New setting explicitly only removes from latest list but leaves the
category list alond
2018-02-22 09:56:35 +11:00
Jeff Wong d2b518c61c QR code display fix on dark backgrounds (#5613)
https://meta.discourse.org/t/2fa-qr-code-not-visible-on-dark-theme/81152?u=awole20
2018-02-21 23:23:47 +01:00
Robin Ward 83d8fa2892 FIX: Allow customized usernames to work in this route
Co-authored-by: jjaffeux <j.jaffeux@gmail.com>
2018-02-21 13:37:14 -05:00
Vinoth Kannan 2b509eaa91
Merge branch 'master' into pm-tags 2018-02-21 23:55:59 +05:30
Neil Lalonde 81e873138f FIX: error when deleting a tag associated with a deleted topic 2018-02-21 12:35:53 -05:00
Régis Hanol 4e7244d8d9 FIX: never open internal links in a new tab when user prefers opening external links in a new tab 2018-02-21 17:51:53 +01:00
Vinoth Kannan d4b2e840cb remove unwanted code 2018-02-21 20:19:19 +05:30
Vinoth Kannan 84ce1acfef FEATURE: Allow staffs to tag PMs 2018-02-21 20:11:46 +05:30
Vinoth Kannan 1446753fd2 FIX: Include deleted topics in the post serializer 2018-02-21 14:31:52 +05:30
Guo Xiang Tan b16471edfb FIX: Invalid token error incorrectly displayed on email login page. 2018-02-21 15:46:53 +08:00
Guo Xiang Tan 8964e75ad6
Merge pull request #5612 from discourse/featheredtoast-two-factor-login
Featheredtoast two factor login
2018-02-21 15:00:10 +08:00
Guo Xiang Tan 14f3594f9f Review Changes for f4f8a293e7. 2018-02-21 14:55:49 +08:00
Robin Ward 5c40ae9e63 FIX: Links in quotes should be counted for rate limits 2018-02-20 20:42:01 -05:00
Jeff Wong f4f8a293e7 FEATURE: Implement 2factor login TOTP
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
Kris ce97bdb472 Flag badge too wide in header panels 2018-02-20 17:31:02 -05:00
Kris 677e126fbf UX: Implementing a box-shadow system, cleaning up existing shadows 2018-02-20 12:18:20 -05:00
Guo Xiang Tan 226ace1643 Update annotations. 2018-02-20 14:28:58 +08:00
Sam 86d12bd44b FEATURE: search within title using in:title
Also

- Significantly improved search ranking, title is treated most strongly
- Adds tag names to the index
- Run search re-indexer more aggressively
- Re-index topic and all posts on category change
2018-02-20 14:41:21 +11:00
Régis Hanol 60ec483caa FIX: include title in local onebox when linking to a different topic 2018-02-19 22:40:14 +01:00
Arpit Jalan 614b1c8e68 FIX: admin was not able to unblock screened IP address 2018-02-20 00:36:13 +05:30
Arpit Jalan c419c26f56 FEATURE: new site setting 'max_emojis_in_title' 2018-02-19 18:15:26 +05:30
OsamaSayegh f3815cd785 FEATURE: New site setting for additional allowed filetypes for staff (#5364)
* FEATURE: New site setting for additional allowed filetypes for staff

* Problematic variable name

* feedback

* small issues

* fix indentation

* failing tests

* Remove message bus and fix minor issues

* Missed this message bus
2018-02-19 10:44:24 +01:00
Zach Whitehead afa2b36842 Add class to category link for easy styling (#5606) 2018-02-19 10:22:27 +01:00
Leo McArdle 5d9d0fcb4f FEATURE: add setting which adds group name to PM email subject (#5475) 2018-02-19 10:20:17 +01:00
Joffrey JAFFEUX b3b6373f77
FIX: do not show mail-forward icon if not needed 2018-02-19 09:52:35 +01:00
Arpit Jalan 33df2d6a02 FIX: data export should fill missing dates with zero value 2018-02-18 23:52:09 +05:30
Robin Ward 02093ecbdd Extensibility: Allow plugins to munge user params 2018-02-16 19:12:02 -05:00
Kris a2327b4897 login button alignment fix 2018-02-16 17:13:10 -05:00
Kris 35a49a240a UX: Improving header scalability for large font themes 2018-02-16 15:58:10 -05:00
Kris 67526907cd Tags should wrap on mobile topic-list 2018-02-15 15:15:42 -05:00
Kris 5de78a719b Fixing emoji admin page column 2018-02-15 15:07:26 -05:00
Robin Ward 32e8cef0ad
Merge pull request #5596 from discourse/mobile-landscape-timeline
UX: Make mobile timeline extra short in landscape
2018-02-15 11:34:03 -08:00
Robin Ward 3faeb4f093 Calculate the heights when we need them 2018-02-15 14:33:20 -05:00
Neil Lalonde 991dfadad7 FIX: CategoryTagStat queries need to exclude PMs with tags 2018-02-15 12:13:42 -05:00
Neil Lalonde fdd8ce9722 empty category_tag_stats table before running init job 2018-02-15 11:28:25 -05:00
Joffrey JAFFEUX 2cf40096d1
FIX: makes mini-tag-chooser search more efficient 2018-02-15 15:01:19 +01:00
Arpit Jalan 585fc26f8e FIX: allow discourse app to link directly to upgrade page 2018-02-15 18:20:25 +05:30
Joffrey JAFFEUX e1883ba828
minor select-kit css improvements 2018-02-15 12:56:20 +01:00
Arpit Jalan b43ac801d1 FIX: show create new topic link in advanced search mode 2018-02-15 17:23:34 +05:30
hnb-ku afdc559f4f FEATURE: Whitelist div[data-theme-*] (#5598)
* Whitelist div[data-theme-*]

Whitelisting data attributes on <div> elements that match [data-theme-*] allows theme authors to target elements in posts and not have those attributes sanitized. 

https://meta.discourse.org/t/79520/16

* Update white-lister.js.es6
2018-02-15 04:32:41 -05:00
Guo Xiang Tan 7902296c11 Oops we should register a service worker as long as it is supported. 2018-02-15 15:02:14 +08:00
Kris 5ab44833ab UX: Make mobile timeline extra short in landscape 2018-02-14 23:27:06 -05:00
Guo Xiang Tan 9c7d609575 UX: Restore width of composer user selector.
* This fixes the build as well as a short width
  resulted in the user selector collapsing into
  the compressed display.
2018-02-15 11:49:10 +08:00
Guo Xiang Tan 28365f8ae5 PERF: Have nginx cache and serve the service worker file. 2018-02-15 10:50:39 +08:00
Sam d8b4627fc8 we have to define this for tests to pass 2018-02-15 13:30:34 +11:00
Sam b5b866aab3 oops 2018-02-15 13:13:31 +11:00
Sam c89b42c488 PERF: only require the rss library if used
Before:

Total allocated: 257909321 bytes (2514134 objects)
Total retained:  39681579 bytes (343387 objects)

allocated memory by gem
-----------------------------------
  42875979  rss

retained memory by gem
-----------------------------------
   2080188  rss

retained objects by gem
-----------------------------------
     13052  rss

After:

Total allocated: 210562047 bytes (2252030 objects)
Total retained:  37433816 bytes (328635 objects)

----

So, 2 less megabytes on boot and 13000 objects stuck in ruby heaps forever.
2018-02-15 13:11:33 +11:00
Robin Ward a03e7cee63 FIX: Group posts had the wrong paths in subfolders 2018-02-14 20:33:31 -05:00
Guo Xiang Tan 96e5a7da46 Prefer `success_Json` over custom success JSON payload. 2018-02-15 07:47:35 +08:00
Rafael dos Santos Silva 218c8e8623
Merge pull request #5595 from discourse/new-gfycat-onebox
New gfycat onebox
2018-02-14 19:03:28 -02:00
Robin Ward a3e5a31674 FIX: Allow 404 pages to use the current theme 2018-02-14 15:29:01 -05:00
Kris dffdff91a6 Fix avatar flair alignment on mobile user profiles 2018-02-14 13:39:30 -05:00
Kris e85458e1b9 Removing old bootstrap columns 2018-02-14 12:27:34 -05:00
Joffrey JAFFEUX 3ad0266dd8
FIX: better handling of category badge when displaying sub and parent cat 2018-02-14 16:42:20 +01:00
Arpit Jalan f07b1a5c05 FIX: activate user even if email token is already confirmed 2018-02-14 20:44:48 +05:30
Joffrey JAFFEUX 8ae2c4555a
FIX: do not translate the same string two times when rendering icon label 2018-02-14 12:41:24 +01:00
Joffrey JAFFEUX 23ef5f10e9
FIX: check can_create_tag on create and not on select 2018-02-14 12:20:07 +01:00
Joffrey JAFFEUX e3774c7bed
FEATURE: displays category badge in {{category-chooser}} header 2018-02-14 11:49:23 +01:00
Joffrey JAFFEUX e7761db60f
FIX: improves contrast on period-chooser when using dark-theme 2018-02-14 11:16:57 +01:00
Joffrey JAFFEUX 5d00a97ae9
FIX: regression preventing uncategorized badge to be shown 2018-02-14 11:03:33 +01:00
Joffrey JAFFEUX b0eed424f7
FIX: continue discussion when creating new topic from composer-actions 2018-02-14 10:32:46 +01:00
Joffrey JAFFEUX 480c94d298
minor visual improvements to mini-tag-chooser 2018-02-14 10:26:43 +01:00
Sam 38f4acd55a FIX: rate limiter text is confusing, should not say daily
Also, adds easily parseable JSON so users can figure out
how long to wait when the API is limited. ("extras" "wait_seconds")
2018-02-14 15:29:50 +11:00
Sam f028ffaf29 SECURITY: correct local onebox category checks
Also removes ugly "source_topic_id" from cooked posts

Patch was authored by @zogstrip

Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
Joffrey JAFFEUX 548db91c76
FIX: displays an error when reaching tags limit 2018-02-14 00:30:09 +01:00
Gerhard Schlager 5a56746610 FIX: Embedded topic was not found when URL contained query string 2018-02-14 00:28:30 +01:00
Neil Lalonde 22f0b0096d FEATURE: show avatar flair on user profile page 2018-02-13 17:13:38 -05:00
Robin Ward 556ab8480e FIX: ESlint 2018-02-13 16:06:40 -05:00
Robin Ward 713993d150 UX: Link post ids in staff action logs to the post 2018-02-13 15:59:10 -05:00
Robin Ward 7348513848 FIX: Include post in staff action logs when silencing a user 2018-02-13 15:59:10 -05:00
Joffrey JAFFEUX ed114177e7
Mini tag chooser tweaks 2018-02-13 19:41:03 +01:00
Joffrey JAFFEUX d525a644d2
fix linting 2018-02-13 18:12:30 +01:00
Joffrey JAFFEUX 20123271d2
FIX: override backspaceFromFilter only if defined 2018-02-13 17:48:00 +01:00
Neil Lalonde 20e44b3c14 Revert "FIX: 404 page when clicking a badge notification from before changing username" 2018-02-13 11:39:33 -05:00
Régis Hanol 7d501058d7 FIX: don't grant new user of the month badge to suspended users or based on deleted topics/posts 2018-02-13 17:32:38 +01:00
Joffrey JAFFEUX 6bfc25d895
FEATURE: new {{mini-tag-chooser}} replaces {{tag-chooser}} in composer 2018-02-13 17:23:12 +01:00
Vinoth Kannan 0a95d2a21f FIX: Upload fails silently if it is bigger than max allowed size 2018-02-13 14:39:25 +05:30
Erick Guan 03b3e57a44 FEATURE: login by a link from email
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
Guo Xiang Tan f9280617d0 Remove redundant comment. 2018-02-13 15:58:13 +08:00
Maja Komel 1c27d93dcf anonymous shadow users are approved on creation if must_approve_users is enabled (#5569) 2018-02-13 01:58:38 -05:00
Muhlis Cahyono cc3cf6588b FEATURE: Notification API Endpoints for Admins
* create/update/delete notification api with external url
* remove external url feature
* Fix Travis CI build error (add new line)
* Fix Travis CI build error
2018-02-13 01:38:26 -05:00
Sam 14d0450bef FEATURE: Only load service worker for Android
TBD an interface for plugin to enable service workers on desktop if they need them
2018-02-13 16:23:36 +11:00
Sam 074d590abd FIX: stop counting offline page as a page view 2018-02-13 16:19:43 +11:00
Sam b34b1b6fe3 FIX: invite to message was not allowing groups
Previously we were incorrectly checking mentionable instead of messageable

Also fix edge case where multiple groups sharing a name mean that exact match override is not working

Also cleans up params sent to user selector
2018-02-13 13:28:46 +11:00
Kris 5f8f691e2b FIX: Border issue with group inputs on high resolution displays 2018-02-12 21:09:40 -05:00
Robin Ward ae15faeb34 FIX: Allow links from one relative uri to another 2018-02-12 18:27:08 -05:00
Robin Ward 4c9959f795 FIX: Don't allow silenced users to reach TL3 2018-02-12 17:20:11 -05:00
Neil Lalonde 1bafbc8c5c
Merge pull request #5576 from discourse/top-tags
PERF: a faster way to count tags used per category
2018-02-12 16:25:18 -05:00
Kris 32116654ec removing duplicate topic-map desktop/mobile styles 2018-02-12 15:20:14 -05:00
Neil Lalonde 76c309fe6b PERF: a faster way to count tags used per category 2018-02-12 15:16:47 -05:00
Vinoth Kannan e700e3e882 FIX: post_destroyed webhook event not fired 2018-02-13 01:36:56 +05:30
Robin Ward d962d6072e FIX: Don't auto select ALL topics, only keyboard chosen ones 2018-02-12 13:54:37 -05:00
Robin Ward 7b7f94d7df FIX: Using cmd-f to search in a topic wasn't restricting to that topic 2018-02-12 13:09:56 -05:00
Kris 44f39ddc86 prevent post-link clicks from being squished by long strings 2018-02-12 11:52:42 -05:00
Rafael dos Santos Silva 4644757785 FEATURE: Style new gfycat onebox 2018-02-12 13:39:52 -02:00
Joffrey JAFFEUX 3d5c4580bd
FIX: makes sure we add ellipsis to action-title 2018-02-12 16:27:24 +01:00
Kris d30c43e8cc usercard overflow fix 2018-02-10 21:27:25 -05:00
Kris 3d22ba35bc usercard website fix 2018-02-09 21:45:38 -05:00
Robin Ward cee3337357 Don't allow users to auto-hide staff posts 2018-02-09 19:53:58 -05:00
Robin Ward b31e6e64fb FIX: After deleting a post, staff can recover it 2018-02-09 19:42:16 -05:00
Robin Ward 569e57f0a9 FIX: Delete the invalid auth cookie even if you hit the rate limit 2018-02-09 19:09:54 -05:00
Robin Ward 2faa4c2f5f FIX: Don't show personal messages if disabled as a composer action 2018-02-09 16:58:35 -05:00
Kris 56352137ca UX: Preventing usercard and profile URLs from overflowing 2018-02-09 16:55:43 -05:00
Kris 88a992014b Default modals were too wide 2018-02-09 15:45:34 -05:00
Kris 597f17bf70 button padding nitpick 2018-02-09 15:41:59 -05:00
Vinoth Kannan 91beedd0ca FEATURE: Composer HTML pasting ul tag support for MS Word 2018-02-10 01:18:56 +05:30
Kris 1e51be923c UX: Improving post-link alignment 2018-02-09 12:43:15 -05:00
Kris 6f094ee27e extra-info-wrapper titles were too short 2018-02-08 20:43:34 -05:00
Robin Ward 5466389f4e FIX: Consider oneboxes links wrt to `min_trust_level_to_post_links` 2018-02-08 18:27:40 -05:00
Kris 69bccb9e32 UX: Better alignment of small topic statuses 2018-02-08 17:04:29 -05:00
Jeff Wong 8e49033ed1 tab index composer actions
add styling for :focus
2018-02-08 12:16:13 -08:00
Kris e17e6d2880 Removing unneeded width 2018-02-08 14:10:04 -05:00
Robin Ward dedeb2deb8 FIX: Don't show the link button in the composer if linking is disabled 2018-02-08 12:56:10 -05:00
Joffrey JAFFEUX 8c89f5704d
FIX: makes sure we display whisper if we don’t have a post 2018-02-08 14:18:53 +01:00
Gerhard Schlager 0ecdf90023 FIX: Validations could prevent moving posts 2018-02-08 13:36:13 +01:00
Gerhard Schlager 8ab6689f43 FIX: Preserve original date when moving first post 2018-02-08 12:55:32 +01:00
Joffrey JAFFEUX 190d208631
FEATURE: improves composer-actions toggle menu
* only toggles
* fix a bug with presence
* more tests
* do not duplicate `continuing discussion...` text
* persist state to allow switching between toggles
2018-02-08 11:46:55 +01:00
Robin Ward 209a6cae2c FIX: Don't show messages setting if messages are disabled 2018-02-07 11:43:22 -05:00
Robin Ward c0ef6ca01c UX: Show the footer on the user summary and preferences pages 2018-02-07 11:35:36 -05:00
Gerhard Schlager 8765279c90 FIX: Customizing site texts ignored current locale for _MF keys 2018-02-07 16:57:08 +01:00
Gerhard Schlager 890ffb1eb5 FIX: overriding _MF translations worked only for English 2018-02-07 12:47:15 +01:00
Neil Lalonde ce26f48f97 FIX: only send up to 100 selected tags in the tag search request to avoid sending a query string that's too long 2018-02-06 17:54:57 -05:00
Joffrey JAFFEUX cdded801c5
FIX: correctly shows link to post number when editing 2018-02-06 22:17:27 +01:00
Kris 900f37e5a9 UX: Allow history modal to scale down on smaller screens 2018-02-06 15:02:51 -05:00
Sam Saffron 884b9d4b78 PERF: optimize performance of new topics query (home page)
This ensures the bypass is always applied to query plan
also, add frozen strings
2018-02-06 12:37:23 -05:00
Joffrey JAFFEUX b1593c0184
FIX: prevents exception when opening new topic on mobile
Repro:

- Visit https://meta.discourse.org/categories, refresh the page
- Navigate to Latest
- Click New Topic
- Error occurs
2018-02-06 14:48:04 +01:00
Kris e7b732ad95 FIX: Desktop/mobile heatmap colors should be the same 2018-02-05 21:36:35 -05:00
Neil Lalonde d7e90edeb5 PERF: Tl3Promotions job can limit the number of TL3 candidates by using some simple requirements in the query 2018-02-05 17:54:36 -05:00
Neil Lalonde 648a11a6a1 FIX: size of tags input field of tag group 2018-02-05 15:05:43 -05:00
Simon Cossar e3de396091 Set text to empty string when null is passed as argument (#5560) 2018-02-06 07:05:32 +11:00
Joffrey JAFFEUX c48761c628
s/select-box-kit/select-kit
Definitely remove legacy naming.
2018-02-05 18:25:39 +01:00
Neil Lalonde 8fe61c68a1 FIX: process_post job should update baked_at and baked_version if it rebakes the post 2018-02-05 11:47:04 -05:00
Régis Hanol 130974d58d FIX: automatically unsilence users 2018-02-05 17:45:47 +01:00
Kris ad8c2c08a4 fixing link alignment in titles 2018-02-05 10:42:37 -05:00
Joffrey JAFFEUX bd0a8ae792
FIX: makes scrollbar always on for small dropdowns 2018-02-05 10:51:06 +01:00
Joffrey JAFFEUX 5cd5d5aca5
FIX: prevents a regression where enter wasn't working in inputs 2018-02-05 09:55:58 +01:00
Robin Ward 0776340b29 SECURITY: Prevent robots from indexing more routes
These routes could contain sensitive material and should never be
indexed for content.
2018-02-04 13:24:36 -05:00
Kris 86bf6babf8 FIX: Prevent long composer overlapping controls 2018-02-02 22:31:55 -05:00
Kris cf623e65e0 tag alignment fix 2018-02-02 21:29:51 -05:00
Kris cd798e49d8 header text wrap fix 2018-02-02 19:33:00 -05:00
Kris 8bac9c7a09 header-extra wrap fix 2018-02-02 19:28:45 -05:00
Kris 9e690bf238
UX: Cleaning up category badge alignment (#5561) 2018-02-02 19:03:25 -05:00
Robin Ward 2f19588311 FIX: If personal messages are disabled, don't show messages for groups 2018-02-02 16:35:54 -05:00
Robin Ward 68d0d39ab7 FIX: Order the homepage box in the same order as the top menu
This is required because "no interface" is the same as showing
the first entry. But when the top menu has changed the first
entry is no longer the same, so it shows the wrong default.
2018-02-02 16:11:28 -05:00
Vinoth Kannan e8559f222c FIX: After moving the posts topic timestamp should be updated with newest post 2018-02-02 19:30:52 +05:30
Joffrey JAFFEUX b4aad15267
FIX: simplify styling of category-name when using category-drop/link 2018-02-02 10:31:20 +01:00
Joffrey JAFFEUX cf592fa35d
remove debugging code 2018-02-02 09:31:47 +01:00
Joshua Rosenfeld e5655f0b6b
UX: Add specific classes to ip address rows on user admin 2018-02-02 00:40:10 -05:00
Joffrey JAFFEUX 85db6cd2d7
FIX: makes sure we have a content to filter 2018-02-02 02:13:06 +01:00
Joffrey JAFFEUX a4445b0c1e
FIX: improve dropdown-select-box on mobile 2018-02-02 00:47:12 +01:00
Robin Ward d31417d3af FIX: Remove unused import 2018-02-01 18:03:22 -05:00
Joffrey JAFFEUX ce507b7957
FEATURE: display search on large category-drop and tag-drop 2018-02-01 23:51:29 +01:00
Robin Ward 8ff4104555 Many enhancements to the flagging / suspending interface. 2018-02-01 17:13:02 -05:00
Joffrey JAFFEUX f7df68c9a3
FIX: makes composer-actions toggling whisper instead of replying 2018-02-01 23:07:37 +01:00
Robin Ward 0156ae486d Apply extra classes to header avatar 2018-02-01 16:59:10 -05:00
Robin Ward 9f96d59a17 FIX: Unused import 2018-02-01 16:31:21 -05:00
Neil Lalonde 9fa71e198e FIX: admin reports charts should use same time of day as dashboard numbers 2018-02-01 15:59:39 -05:00
Neil Lalonde ef2a7ac0f7 FIX: admin reports would sometimes return fewer than 30 days of data, causing current 30 day period counts to be too small and prev30day counts to count the wrong days 2018-02-01 15:50:51 -05:00
Robin Ward 08db10491e Adds a new plugin API for adding classes to be shown on user avatars 2018-02-01 15:24:26 -05:00
Joffrey JAFFEUX 42399261ba
adds margin to avatar in composer-action-title 2018-02-01 18:41:11 +01:00
Joffrey JAFFEUX e3301c4869
FIX: max-height auto is not valid 2018-02-01 18:08:55 +01:00
Robin Ward 64ba876ff4 FIX: Don't show "Grant Badge" if badges are disabled 2018-02-01 11:33:48 -05:00
Joffrey JAFFEUX 97ddaeeae8
FIX: use css instead of js to fix select-kit-collection max-height 2018-02-01 16:56:07 +01:00
Joffrey JAFFEUX 9923829402
FEATURE: Menu toggle for different reply modes
Allow users to access different reply modes from the composer.

Actions introduced:

- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
2018-02-01 16:42:56 +01:00
Robin Ward 96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support
FEATURE: Mixed text direction support
2018-02-01 07:29:15 -08:00
Joshua Rosenfeld f85055d653 FIX: Remove activation link from account approved email (#5548) 2018-02-01 14:59:37 +01:00
Arpit Jalan f88b8a8945 rename 'default_email_private_messages' to 'default_email_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan 49424fd798 rename private to personal 2018-02-01 13:25:29 +05:30
Arpit Jalan 6be536ca50 rename 'max_private_messages_per_day' to 'max_personal_messages_per_day' 2018-02-01 13:25:29 +05:30
Arpit Jalan 7cda3a37af rename 'private_email_time_window_seconds' to 'personal_email_time_window_seconds' 2018-02-01 13:25:29 +05:30
Arpit Jalan ff0376a80b rename 'enable_private_messages' to 'enable_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan 25ec077eca rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length' 2018-02-01 13:25:29 +05:30
Sam 60ee9a4ccf make tests a bit happier 2018-02-01 15:56:22 +11:00
Sam 41986cdb2f Refactor requires login logic, reduce duplicate code
This also corrects the positioning in the chain of the check
and removes misuse of prepend_before_action
2018-02-01 15:17:59 +11:00
Sam ee0d3f15c1 FEATURE: allow better fidelity for auto linkify, disable most tlds based linkify
New site settings:

enable_markdown_linkify: which is default on, auto links https:// and http:// and mail://

markdown_linkify_tlds: which allows control of what tlds get autolinked for cases such as www.site.com, default is com|net|gov
2018-02-01 13:22:38 +11:00
Sam f2e7b74d88 FIX: don't return 200s when login is required to paths
When running `ensure_login_required` it should always happen prior to
`check_xhr` cause check xhr will trigger a 200 response
2018-02-01 12:26:45 +11:00
Régis Hanol 4bcf9c5bf3 FIX: only count 'human' users in group.user_count 2018-01-31 21:55:01 +01:00
Régis Hanol 826584b9c1 UX: prevent anons from clearing pins in topic view 2018-01-31 20:34:53 +01:00
Régis Hanol 8c91d418dd UX: improve semantic of login button for better password managers compatibility 2018-01-31 20:09:59 +01:00
Kris add641cbbc
UX: Input and search cleanup (#5546)
* Cleaning up input sizes

* alignment

* more alignment adjustments
2018-01-31 11:44:51 -05:00
Régis Hanol 48f8d9f8a4 UX: prevent anons from clearing pins 📌 2018-01-31 17:13:52 +01:00
Régis Hanol d233ecbe34 push updates to backups list to client 2018-01-31 12:05:06 +01:00
Régis Hanol c6fac68ccd FIX: don't blow up on badly encoding incoming email body 2018-01-30 23:47:58 +01:00
Neil Lalonde aab2d102ff FIX: 404 page when clicking a badge notification from before changing username 2018-01-30 15:56:44 -05:00
Vinoth Kannan 10ed4c0078 FEATURE: Composer HTML pasting support for complex table formats 2018-01-31 01:39:11 +05:30
Kris 56987e2290 Profile textarea too short in iOS10 2018-01-30 09:31:18 -05:00
Vinoth Kannan 88c05d7050 Limit the maxLength of the name and description text inputs for custom user fields 2018-01-30 17:04:18 +05:30
Maja Komel 018cb7f36b add a custom user onebox (#5542)
* add custom user onebox

* add specs
2018-01-30 11:03:08 +01:00
scossar 41f1e7430c Refactor code; add tests 2018-01-29 17:42:19 -08:00
Robin Ward 95e0aa059c UX: The delete button is also a dropdown 2018-01-29 19:15:19 -05:00
Maja Komel 330912e1e5 FIX: allowed href scheme link can start with a + (#5537)
* allowed href scheme link can start with a +

* allow tel:// links only to start with +

* add missing semicolon

* add test
2018-01-30 11:02:23 +11:00
Sam f946db4afe FIX: inline oneboxer min title length of 2
also: cache mini onebox misses as well to cut down traffic
2018-01-30 08:40:04 +11:00
Neil Lalonde d37477b1ef FIX: show label beside confirm user fields, and fix spacing around them 2018-01-29 16:39:41 -05:00
Kris 2eef9b3295 UX: Adding a sticky footer to the post history modal, removing bootstrap columns 2018-01-29 15:15:50 -05:00
Neil Lalonde fcc86d5be3 FIX: time read on users directory was not rendering correctly on mobile 2018-01-29 13:31:18 -05:00
Robin Ward 51e327f640 FIX: Remove old text 2018-01-29 13:18:44 -05:00
Robin Ward 73fae6513f FIX: Missing translation 2018-01-29 13:16:58 -05:00
Régis Hanol 77ac14d475 prevent users with a tiny number of posts to dominate the 'new user of the month' leaderboard 2018-01-29 12:09:17 +01:00
Joffrey JAFFEUX 52fbf9d3ae
FIX: emoji-picker improvements
* fix a performance issue on mobile when modifying filtering query, thanks to David Taylor and Jorge Manrubia for the initial finding and solution
* minor refactoring
* better positioning of the picker on mobile
2018-01-29 11:05:35 +01:00
Simon Cossar 4662cc428f Fix RTL topic-admin-menu-position (#5497) 2018-01-29 18:14:36 +11:00
scossar 42970e758e Use consistent style for string concatenation 2018-01-28 18:45:11 -08:00
Arpit Jalan 1f6adbea5c FEATURE: log private message views 2018-01-29 08:08:08 +05:30
scossar caa38aaaad Add support for mixed text directions 2018-01-28 18:33:55 -08:00
Joffrey JAFFEUX 4c19088084
FIX: hides upload link on mobile 2018-01-28 09:48:41 +01:00
Robin Ward 2d340d1122 FIX: Don't allow username update via update route
It's not using the UsernameChanger
2018-01-26 16:53:43 -05:00
Kris 452a6bfa9c Minor alignment fix for bullet categories 2018-01-26 16:35:49 -05:00
Kris f587fb7cc7 FIX: Select-kit category dropdown issues in IE11 2018-01-26 15:51:44 -05:00
Robin Ward 36d836ba40 Link suspensions to the staff logs page 2018-01-26 15:40:03 -05:00
Kris ee155bd4f2 Removing duplicate modal styling 2018-01-26 14:54:15 -05:00
Robin Ward 6b04967e2f FEATURE: Staff members can lock posts
Locking a post prevents it from being edited. This is useful if the user
has posted something which has been edited out, and the staff members don't
want them to be able to edit it back in again.
2018-01-26 14:01:30 -05:00
Kris 76317957ed UX: Removing some old references to the star feature 2018-01-26 13:05:29 -05:00
Régis Hanol e2d82b882e FIX: redirect to original URL after social login 2018-01-26 18:52:27 +01:00
Joffrey JAFFEUX 3d595a52ca
FIX: improves UI state when no extensions are allowed for upload 2018-01-26 18:12:23 +01:00
Joffrey JAFFEUX 56834dbd98
FEATURE: select-kit api to modify collection header 2018-01-26 14:42:24 +01:00
Joffrey JAFFEUX 0eb71cef98
FIX: makes sur allowUncategorized is passed to category-selector 2018-01-26 14:41:30 +01:00
Gerhard Schlager 3fde4c9db7 FIX: Enabling verbose localization for session didn't work 2018-01-25 23:29:53 +01:00
Neil Lalonde 179ecee11e FIX: featured links are 'undefined' in suggested topics 2018-01-25 14:40:07 -05:00
Arpit Jalan 8b59ce9183 FIX: CTRL+mouse-left-click / CMD+mouse-left-click or mouse-middle-click should open link in new tab 2018-01-25 20:35:39 +05:30
Bruno Perel 6750ff6873 (S)CSS cleanup: 0px => O and removal of duplicated properties (#5526) 2018-01-25 09:53:36 -05:00
Gerhard Schlager b784c1eda4 FIX: Remove all notifications of staged user during sign-up 2018-01-25 14:58:43 +01:00
Gerhard Schlager d9515c37b3 FIX: Show message from discobot when staged user signs up 2018-01-25 14:58:43 +01:00
Gerhard Schlager eb52c5469e FEATURE: Allow plugins to register a new locale 2018-01-25 14:57:41 +01:00
Gerhard Schlager 683be5e555 FIX: Application should not crash when selected locale is missing 2018-01-25 14:57:41 +01:00
Joffrey JAFFEUX 01f9995956
FEATURE: do not restrict categories filtering to only FULL permission type 2018-01-25 12:03:13 +01:00
Joffrey JAFFEUX b821da80f8
FIX: makes sure allowUncategorized is passed to underlying component 2018-01-25 10:41:10 +01:00
Joffrey JAFFEUX 47bef377f6
FIX: force full width on mobile for cat and tag drops 2018-01-25 09:38:02 +01:00
Kyle Zhao afaf9fd54c FIX: mods should be able to grant badges in post wrench (#5522) 2018-01-25 13:52:05 +11:00
Neil Lalonde dc97239040 FIX: censored regex words were replacing other text that shouldn't be censored 2018-01-24 12:33:47 -05:00
Joffrey JAFFEUX 3ad48e0d30
FIX: larger tag-drop 2018-01-24 18:25:26 +01:00
Joffrey JAFFEUX 1d0f3a9816
FIX: tweaks to tag and category drops 2018-01-24 18:16:29 +01:00
Joffrey JAFFEUX 1fd3b5cc4f
FIX: improvements to category-drop when used with a subcategory 2018-01-24 17:41:26 +01:00
Joffrey JAFFEUX 262f795a4b
FIX: better handling of collection height 2018-01-24 16:42:13 +01:00
Kris a2f78fd778 FIX: alignment for box/bullet tag styles 2018-01-24 10:37:24 -05:00
Vinoth Kannan 4a70248311 UX: Trim selected text while copying to the link building modal 2018-01-24 18:58:54 +05:30
Joffrey JAFFEUX 3a290ee625
FEATURE: replaces category/tag dropdowns by select-kit 2018-01-24 11:48:20 +01:00
Arpit Jalan 5cfcfa7a76
Merge pull request #5523 from angusmcleod/badge_group_edit_bugfix
FIX: badge group edit modal controller is missing modal functionality
2018-01-24 12:06:00 +05:30
Arpit Jalan 65e80aba03 FIX: creating new message via link was failing for anon user 2018-01-24 11:45:15 +05:30
Sam 95ac1655bc revert settings 2018-01-24 13:21:23 +11:00
Angus McLeod 63b29301d8 FIX: badge group edit modal controller is missing modal functionality 2018-01-24 09:33:43 +08:00
Sam 3492a91056 FEATURE: allow site operators to disable emoji shortcuts 2018-01-24 12:21:44 +11:00
Sam 7ba06de0d6 FEATURE: disable service worker for all browsers except for android
Service worker is still quite experimental, only enable on android
where it provides many benefits
2018-01-24 12:03:08 +11:00
Sam c42bb94362 PERF: slow down optimizing images per host 2018-01-24 08:53:17 +11:00
Sam bfd052a317 PERF: guard so we only create one optimized image per process
This protectd sidekiq and other cases where optimized images are created on
demand so they do not dominate the machine.
2018-01-24 08:22:28 +11:00
Robin Ward a469c65631 FIX: Missing footer on groups pages 2018-01-23 16:20:53 -05:00
Robin Ward 0351565731 Add span to make extensibility easier 2018-01-23 15:45:09 -05:00
Vinoth Kannan 86e142b39f UX: Copy selected text to the link building modal 2018-01-24 02:02:12 +05:30
Robin Ward 782d75069e FIX: UX improvements for system messages when PMs are disabled 2018-01-23 13:12:11 -05:00
Kris cb9524c365 UX: Additional protections to prevent tag nesting exploits in posts 2018-01-23 10:34:37 -05:00
Kris c3103cb23e FIX: Users column too wide on tablet 2018-01-23 09:45:46 -05:00
Kris c8f9e7a9c5 FIX: tag alignment 2018-01-22 21:36:07 -05:00
Kris 3875b204d4 FIX: space below post-actions 2018-01-22 21:26:07 -05:00
Kris fb2ab3c4d4 UX: White text for social login buttons, regardless of theme 2018-01-22 21:19:38 -05:00
Guo Xiang Tan 80c41a0e59
Merge pull request #5510 from discourse/add-posts-count-to-web-hook-post-serializer
Feature: add topic posts count to webhook post serializer
2018-01-23 07:46:59 +08:00
Kris 99cabd071a UX: Very long tag names should truncate 2018-01-22 17:14:40 -05:00
Sam 2437b0d531 FIX: regression, missing 404 page 2018-01-23 09:00:28 +11:00
Robin Ward 1e77850dff FIX: Don't link icon to the private messages page if they are disabled 2018-01-22 16:56:25 -05:00
Robin Ward e52e0f4635 FIX: Disable the keyboard shortcut if private messages are disabled 2018-01-22 16:45:27 -05:00
Kris a9e0c6a685 FIX: Flags notification badge becomes too narrow when menu is open 2018-01-22 14:02:07 -05:00
scossar 841a988454 Return 0 if there is no topic associated with the post 2018-01-22 09:54:11 -08:00
Joffrey JAFFEUX f06f7161ea
FIX: category badge when using box style on long category names 2018-01-22 18:26:54 +01:00
Régis Hanol 5c1eaeca9e FIX: prevent users from moving whispers to new topic 2018-01-22 17:23:19 +01:00
Gerhard Schlager dde0fcc658 FEATURE: Allow sending invites to staged users 2018-01-22 15:37:18 +01:00
Régis Hanol f74ac826c5 slightly more meaningful error message 2018-01-22 12:20:53 +01:00
Sam 060e78e884 PERF: reduce memory usage for post alerter 2018-01-22 17:11:52 +11:00
Sam ce815276d0 Small and big should be limited via rem so it works large font mode 2018-01-22 14:22:30 +11:00
Kyle Zhao 83c549bd31 FEATURE: grant badges in post admin wrench (#5498)
* FEATURE: grant badges in post admin wrench

* only grant manually grantable badges

* extract GrantBadgeController mixin
2018-01-22 14:10:53 +11:00
Sam 47058b29d3 FEATURE: emit external_id field with user webhook 2018-01-22 10:09:26 +11:00
Kris 2de1264213 UX: Adjustments for embedded reply collapse button 2018-01-19 16:16:22 -05:00
Robin Ward 5b820ebb62 Allow plugins to extend the post title 2018-01-19 15:30:50 -05:00
Régis Hanol f674b9e86e FIX: encode image filename so '[', ']' and '|' doesn't break the markdown 2018-01-19 19:52:03 +01:00
Robin Ward 645c32758a Extensibility points for poster name 2018-01-19 12:52:46 -05:00
Robin Ward a8b46df4bd More extensibility for custom silence/suspend messages 2018-01-19 11:35:19 -05:00
Kris 3cec2394b2 FIX: Margin below topic-map 2018-01-19 11:06:21 -05:00
Robin Ward a34010e49a Add some extensibility to posts rendering 2018-01-19 10:22:40 -05:00
Joffrey JAFFEUX bd5a82cfe7
FIX: makes sure mousedown is stopped only on select-kit element 2018-01-19 15:19:07 +01:00
Arpit Jalan d24c35012d FIX: jump to original post when expanded posts are collasped 2018-01-19 18:01:54 +05:30
Arpit Jalan 73dea4e7eb Merge branch 'embedded-posts' 2018-01-19 12:54:34 +05:30
Arpit Jalan 104859af47 FIX: prevent <big> nesting abuse 2018-01-19 12:42:30 +05:30
Jeff Atwood 7ed41fae2b
Merge pull request #5493 from notriddle/home_logo_h1
Change the text-only home logo to an H1
2018-01-18 16:14:36 -08:00
Michael Howell aa65003087 Mark up the headers in the Categories page (#5494)
This should cause them to show up in the screenreader's heading map,
allowing non-sighted users to find both sections.
2018-01-18 16:47:50 -05:00
Sam 873624c487 FIX: never flush timings while in progress
Also reset last flush counter when we finally get a response from server.
2018-01-19 08:27:29 +11:00
Sam 12872d03be PERF: run post timings in background
This means that if a very large amount of registered users hit
a single topic we will handle it gracefully, even if db gets slow.
2018-01-19 08:27:29 +11:00
Robin Ward 90a8ea617b
Merge pull request #5513 from ckeboss/patch-2
Update post-menu.js.es6
2018-01-18 14:11:04 -05:00
ckeboss beee69e566
Update tense and change actions around. 2018-01-18 11:05:25 -08:00
Kris f5f163d1ce FIX: Wrap similar topic titles at narrow widths 2018-01-18 13:57:18 -05:00
ckeboss 1738a85bdc
Update post-menu.js.es6
The bookmark ID's were not very clear and not using the same names as the classes. This addresses that.
2018-01-18 10:53:05 -08:00
Kris 23515a68ca UX: Small adjustments to similar topics popup 2018-01-18 13:52:40 -05:00
Kris fe5374dd3b FIX: increasing z-index on topic-avatar 2018-01-18 13:38:27 -05:00
Michael Howell dff5951fa6
Fix font-up-3 nit 2018-01-17 14:26:35 -07:00
Michael Howell 3fbf731e2d
Fix font-up-3 nit 2018-01-17 14:26:14 -07:00
Robin Ward 34ed6088b9 FEATURE: New modal to show flags received for a user 2018-01-17 15:08:08 -05:00
Neil Lalonde ec65ae76b9 FIX: don't create new like notifications for deleted topics 2018-01-17 14:36:32 -05:00
Kris f108bc3715 FIX: Box badges on 404 page not displaying correctly 2018-01-17 13:42:39 -05:00
scossar 2646eb5e1d Add topic.posts_count to web_hook_posts_serializer 2018-01-17 10:40:21 -08:00
Rafael dos Santos Silva 70c5f6ae17
Merge pull request #5489 from discourse/fix-shared-s3-cdn
FIX: Allow shared CDN for s3 and assets
2018-01-17 16:32:11 -02:00
Joffrey JAFFEUX 7eb9f4d9f7
FIX: badge with box mode having incorrect background size
This bug was hitting FX and IE
2018-01-17 17:54:51 +01:00
Robin Ward 8d454156b3 Rename css class to something that makes more sense 2018-01-17 11:38:43 -05:00
Neil Lalonde 718e932b44 FEATURE: plugins can send more data to Google Tag Manager 2018-01-17 11:18:17 -05:00
Kris 91ff79a289 UX: User column heading needs a width 2018-01-17 09:54:09 -05:00
Arpit Jalan e04fb9a877 fix the build 2018-01-17 12:57:33 +05:30
Arpit Jalan 19b36a2d60 missing semicolon 2018-01-17 12:49:52 +05:30
Arpit Jalan 79eb9d7086 FEATURE: show header search results on search log term details page 2018-01-17 12:47:16 +05:30
Kane York ff91c43087 FEATURE: Keyboard shortcut to refocus composer (#5506)
It was very annoying to get back to the composer after losing it!

Added to the keyboard shortcuts help dialog, and reshuffled it a bit.
Translation keys were intentionally kept so our translators don't have
to copy paste to update.

This commit also fixes an incidental listener leak.
2018-01-17 17:15:03 +11:00
Sam b2009d6e32 PERF: bypass theme handling on static routes 2018-01-17 16:33:17 +11:00
Sam 72b592c395 PERF: add frozen string literals to app controller 2018-01-17 16:32:52 +11:00
Sam b7023da894 PERF: reduce queries required for post timings
- also freezes a bunch of strings
- bypass active record for an exists query
2018-01-17 15:50:41 +11:00
Kris 0c01e0b2fe
UX: Implementing a z-index system (#5507) 2018-01-16 19:05:12 -05:00
Sam 2d2602edf0 no need to log anything if term is blank 2018-01-17 11:02:53 +11:00
Kris 2f8a8dbb21 UX: Modal; Moving cancel further away from confirm 2018-01-16 17:49:04 -05:00
Kris 92c5bc6ac9 UX: Removing width: auto; in mobile autocomplete so long strings truncate 2018-01-16 17:09:07 -05:00
Kris 2e12c2c352 UX: button styling 2018-01-16 16:06:04 -05:00
Kris dc5b0e05e2 UX: Styling embedded post collapse button 2018-01-16 15:48:47 -05:00
Robin Ward d74f609921 Rename key for defer flag -> ignore flag 2018-01-16 14:33:39 -05:00
Sam d7657d8e47 correct specs, ensure crawler layout only applies to html 2018-01-16 16:28:11 +11:00
Sam eaca2cb049 bypass loud logging 2018-01-16 15:41:45 +11:00
Kris 4128f36f52 UX: Tag alignment and size in topic titles 2018-01-15 22:56:37 -05:00
Arpit Jalan 6177fb80eb UX: switch to quartlerly period view for search log term graphs 2018-01-16 07:53:22 +05:30
Neil Lalonde ce79ec0127 FIX: subfolder: top referred topics report was missing subfolder in links 2018-01-15 17:28:35 -05:00
Arpit Jalan 6fff16a999 FEATURE: add collapse button 2018-01-16 01:07:48 +05:30
Kris fe907aaf74 UX: increasing contrast on composer elements 2018-01-15 13:37:29 -05:00
Robin Ward 1080748444 Extensibility point for claiming flagged posts 2018-01-15 13:11:11 -05:00
Kris 22849fce96 UX: Line-height should be larger with single-line titles 2018-01-15 11:00:04 -05:00
Kris 53fb02f7fc UX: increase post meta font size 2018-01-15 10:30:52 -05:00
Joffrey JAFFEUX b3465b4779
FIX: adds support for selection-indicator 2018-01-15 14:37:18 +01:00
Joffrey JAFFEUX 9122d828e8
remove uneeded line-height 2018-01-15 13:34:07 +01:00
Joffrey JAFFEUX 2ab095612f
FIX: category topic count alignment 2018-01-15 12:43:59 +01:00
Joffrey JAFFEUX ec2ce8f763
FEATURE: replace period-chooser by a select-kit component 2018-01-15 11:55:16 +01:00
Arpit Jalan 785d063a6b
Merge pull request #5496 from techAPJ/admin-graphs
FIX: graphs should go to zero for missing dates
2018-01-15 11:10:29 +05:30
Sam 38c018a84b FIX: invalid cache for parent category with limit_suggested_to_category 2018-01-15 16:13:29 +11:00
Arpit Jalan b7ba490df7 FIX: graphs should go to zero for missing dates 2018-01-15 10:16:34 +05:30
Sam bf68d394f4 PERF: handle debounce in redis cause SQL can be slow 2018-01-15 14:48:28 +11:00
Sam e3a616764e PERF: add frozen strings 2018-01-15 12:44:54 +11:00
Michael Howell 333ab59f97 Fix the site header to size 1.5em 2018-01-12 23:35:24 +00:00
Michael Howell 4c31e4c44e Change mobile site text logo to target `<h1>` 2018-01-12 23:34:31 +00:00
Michael Howell 66d5b9f74c Change the text-only home logo to an H1
Fixes https://meta.discourse.org/t/77892
2018-01-12 23:34:31 +00:00
Kris 674013129a
UX: Type system rebuild (#5492) 2018-01-12 17:27:38 -05:00
Neil Lalonde 298ee26908 FIX: when deleting a tag, the warning modal has the wrong topic count 2018-01-12 16:35:27 -05:00
Neil Lalonde ad58a1743b rename topic_list.tags to topic_list.top_tags 2018-01-12 16:35:27 -05:00
Robin Ward 9d84b4ffe4 Minor extensibility for flagged posts 2018-01-12 16:08:59 -05:00
Robin Ward 3ddc33b07c Don't swallow errors once they've been popped up 2018-01-12 16:08:59 -05:00
Neil Lalonde 6d68275ef9 don't show tag groups if they're restricted to categories you can't access 2018-01-12 14:25:42 -05:00
Robin Ward ff2e8c1a51 UX: Don't use a chevron when a dropdown is just an icon 2018-01-12 12:39:42 -05:00
Neil Lalonde 2493648f9c PERF: calculate topic_counts for tags in an async job so tag queries that include counts are much faster 2018-01-12 11:03:03 -05:00
Neil Lalonde 4d50feb6bd FEATURE: add setting to display tags by tag groups 2018-01-12 11:03:02 -05:00
Arpit Jalan a2c561bbde UX: switch back to line chart 2018-01-12 10:27:23 +05:30
Sam 5bf116e719 warn if missing user option record 2018-01-12 15:43:56 +11:00
Sam 49ed382c2a FIX: return 429 when admin api key is limited on admin route
This also handles a general case where exceptions leak out prior to being handled by the application controller
2018-01-12 14:15:26 +11:00
Rafael dos Santos Silva b9a343afe7 FIX: Allow shared CDN for s3 and assets 2018-01-12 01:08:15 -02:00
Robin Ward dd33050e10 Add discourse events for when a user is suspended/silenced 2018-01-11 12:56:45 -05:00
Robin Ward e904d92b98 FIX: Suspension / Silence reasons were incorrect on save 2018-01-11 10:54:47 -05:00
Neil Lalonde ec4295fb1c
Merge pull request #5482 from vinothkannans/force_https_check
FEATURE: Display force_https warning in admin problems dashboard
2018-01-11 10:39:43 -05:00
Joffrey JAFFEUX 3a7d2da633
FIX: category badges css refactoring/fixes
This commit fixes multiple css issues with category badges in select-kit and outside of select-kit. It also contains refactoring of components impacted by those changes.
2018-01-11 13:05:29 +01:00
Joffrey JAFFEUX 3ee7b18886
FIX: disable by default limitMatches 2018-01-11 09:54:39 +01:00
Joffrey JAFFEUX 3ec2024466
select-kit refactoring
* improve events naming/handling
* do not explicitly check for true/Fasle
* make sure header is re-computed on toggle
2018-01-11 09:39:51 +01:00
Vinoth Kannan b96ae14261 FEATURE: Display force_https warning in admin problems dashboard 2018-01-11 12:16:10 +05:30
Arpit Jalan 2509bef2c0 FEATURE: show create new topic link on mobile 2018-01-11 10:38:52 +05:30
Robin Ward 6dad7dfcec Add extensible classes for components 2018-01-10 14:57:04 -05:00
Robin Ward e7696ef483 Remove beforeControlModal, it is not as useful as a component 2018-01-10 14:48:34 -05:00
Neil Lalonde edb3a7f646 FIX: support for watched_words_regular_expressions when censoring words 2018-01-10 14:11:23 -05:00
Robin Ward 213cc2fe51 Add extensibility point for suspension modal 2018-01-10 13:56:39 -05:00
Robin Ward 8bb6856fde Allow silence details to be overwritten via plugin 2018-01-10 13:19:53 -05:00
Robin Ward 17213887a1 FIX: Allow plugins to override admin component templates 2018-01-10 13:14:43 -05:00
Robin Ward 01726e68ab Add extensibility for suspension reasons 2018-01-10 12:52:31 -05:00
Arpit Jalan 8ad6d8385b FIX: show create new topic link when there are no search results 2018-01-10 14:57:32 +05:30
Sam 114294d899 PERF: cache messages so re-opening composer on same topic does not issue a req 2018-01-10 14:39:39 +11:00
Robin Ward 3ed9cbc040 UX: Put the HR in the correct place 2018-01-09 17:48:52 -05:00
Neil Lalonde 8f21c96ea5 FIX: don't downcase watched words on input since it can break the watched_words_regular_expressions setting 2018-01-09 16:51:59 -05:00
Sam daad2291ba simplify production switch and serve extra locales from actual site 2018-01-10 08:19:51 +11:00
Neil Lalonde ad62f1099c FIX: censored words should support * as wildcard 2018-01-09 15:53:40 -05:00
Vinoth Kannan 61384c8026 Skip CDN for admin locales since it is login required 2018-01-10 01:24:03 +05:30
Arpit Jalan 672888f526 FIX: handle invalid password reset token 2018-01-09 23:48:17 +05:30
Kris c1cb6053b7 UX: Adding a little space after oneboxes 2018-01-09 13:00:32 -05:00
Jan Suchal bc56d86a63 Support ruby 2.5.0 2018-01-09 16:03:17 +01:00
Joffrey JAFFEUX c9921869f1
FIX: adds select-kit api to modify header computed content (#5476)
This api would allow to simply modify header text or icons, eg:

```
      api.modifySelectKit("select-kit")
        .modifyHeaderComputedContent((context, computedContent) => {
          computedContent.title = "Not so evil";
          return computedContent;
        });
```
2018-01-09 10:52:32 +01:00
Sam c9f42506b7 If login is required skip CDN 2018-01-09 17:51:53 +11:00
Sam 6b8320fea6 PERF: use cdn for extra locales 2018-01-09 17:00:42 +11:00
Arpit Jalan 16ce305e53 UX: show bar chart for admin graphs 2018-01-09 11:18:40 +05:30
Guo Xiang Tan e90187cbf7
Merge pull request #5469 from tgxworld/add_guard_to_prevent_primary_email_from_being_reassigned
FIX: Add guard to prevent a primary `UserEmail` from being reassigned.
2018-01-09 13:35:08 +08:00
Sam ea63abf0f7 bypass mini profiler for locales
bypass cdn for now
2018-01-09 11:30:59 +11:00
Sam b0a7ee1aec FIX: source admin locale from cdn 2018-01-09 10:27:33 +11:00
Sam 8ff5f5f2ef FIX: cache admin locale file for 24 hours 2018-01-09 10:23:49 +11:00
Robin Ward 685fc637d5 Improve some user menu code and make the logout button optional 2018-01-08 16:56:56 -05:00
Robin Ward e244a1a319 Extract category name fields into a component 2018-01-08 15:08:56 -05:00
Vinoth Kannan e5affdf230 FIX: URI must be ascii only for URI.parse command 2018-01-07 02:31:35 +05:30
Robin Ward c1ae562389 Add support for app events in plugin api, plus an event for custom html 2018-01-05 16:45:57 -05:00
Joffrey JAFFEUX 642645ba9a
FIX: broken select badge as user title (#5474)
* FIX: broken select badge as user title

* selected id wasn’t pass to underlying component
* <none> was rendered as an html tag <none></none>
* overriding a badge name wouldn’t work as it was using badge.name and not badge.display_name
* adds a spec to ensure this behavior is correct
2018-01-05 16:58:15 +01:00
Arpit Jalan ed4b845930 FIX: render error message when backup download fails 2018-01-05 19:46:43 +05:30
Sam 0081de30a5 PERF: conserve memory while rebaking posts 2018-01-05 09:54:42 +11:00
Arpit Jalan 2d0b88410d
Merge pull request #5470 from techAPJ/embed-url-protocol
FIX: do not create duplicate topics
2018-01-05 01:38:03 +05:30
Robin Ward fbd0d47fce FIX: Don't raise error if I18n key is not found 2018-01-04 14:08:21 -05:00
Arpit Jalan 9030d3ef63 FIX: do not create duplicate topics
https://meta.discourse.org/t/duplicate-http-https-topics-are-randomly-created/77190
2018-01-04 23:53:52 +05:30
Guo Xiang Tan 8a3bbcb19a FIX: Add guard to prevent a primary `UserEmail` from being reassigned. 2018-01-04 19:40:50 +08:00
Robin Ward a109397035 Add extensibility point for d-editor 2018-01-03 17:02:57 -05:00
Robin Ward df163cbf61 Add a `deleted-post` class to the deleted post action 2018-01-03 13:56:47 -05:00
Robin Ward dbd2d29abe Allow the deleted post indicator on a post to be extended. 2018-01-03 13:34:26 -05:00
Arpit Jalan 7ca2e6a80c fix the build 2018-01-03 17:35:36 +05:30
Arpit Jalan 06e509057e FIX: handle missing user records 2018-01-03 17:18:13 +05:30
Guo Xiang Tan ad02437358 FIX: Missing post/topic created web hooks due to race condition. 2018-01-03 17:24:01 +08:00
Guo Xiang Tan 9644569a28 FIX: Wildcard webhooks could send duplicated events. 2018-01-03 17:00:44 +08:00
Kris 73912ebc12 UX: Adjusting color on composer box-shadow 2018-01-02 21:29:16 -05:00
Kris efc5bc2c55 UX: removing double underline from abbr 2018-01-02 21:06:06 -05:00
Robin Ward 0eba867c8c Allow menu classes to be targetable by name 2018-01-02 17:01:44 -05:00
Robin Ward bf7e0188e5 Extensibility points for user/preferences 2018-01-02 15:46:32 -05:00
Robin Ward 4cfea21aa2 UX: Add missing `btn-icon` class to edit icons 2018-01-02 15:24:36 -05:00
Robin Ward 32b5b04d18 Pass `save` action to outlet in case we need to save 2018-01-02 15:17:52 -05:00
Robin Ward 891f0cfe52 FIX: Don't display the `@mention` message if disabled 2018-01-02 14:12:18 -05:00
Gerhard Schlager a0b2b3c8a7 FIX: Canceling upload on mobile did not work 2018-01-02 11:26:23 +01:00
Arpit Jalan 04b8831cde UX: for numbers greater than 100k allow 0 precision 2018-01-02 13:27:46 +05:30
Gerhard Schlager 38269c416d FIX: return regular notification level for categories when not set by user 2017-12-30 20:36:58 +01:00
Arpit Jalan 6ce422feab FIX: respect 'topic page title includes category' client side 2017-12-30 09:06:02 +05:30
Arpit Jalan 6a38e4336b FIX: use different variable name for referer record 2017-12-29 23:31:53 +05:30
Vinoth Kannan f08995c390 Remove unused code lines 2017-12-29 12:32:18 +05:30
Joffrey JAFFEUX 8fd683ab19
select-kit DOM mixin refactoring
This commits improves code readability, performance and rendering precision.
2017-12-28 16:12:45 +01:00
Sam 5ad1709dba PERF: cache service worker for 1 hour 2017-12-28 08:31:01 +11:00
Régis Hanol f5e170c6b5 FIX: catch all server-side error when uploading a file
UX: always show a message to the user whenever an error happens on the server when uploading a file
2017-12-27 16:33:25 +01:00
Maja Komel 2a32536645 grey out disabled badges in admin overview (#5416)
* gray out disabled badges in admin overview

* fix style
2017-12-27 16:57:21 +11:00
Vinoth Kannan d18c42abd5 FIX: Ignore if the default localization node is not an object (#5439) 2017-12-27 16:53:53 +11:00
David Taylor f1f2ae594c Remove wrapper `<span>` from user nav plugin outlet (#5455) 2017-12-27 16:51:39 +11:00
Sam a9e2fc59c4 FIX: [constructor] bbcode would cause markdown crash 2017-12-27 16:11:30 +11:00
Sam 3937ff0425 FIX: don't preload json on static routes 2017-12-27 14:33:36 +11:00
Sam c30ccceade correct params 2017-12-27 13:51:16 +11:00
Sam 0c834515a9 FIX: only attempt old rebakes a maximum of 3 times 2017-12-27 12:44:41 +11:00
Robin Ward 6cffbb4ea4 FIX: Don't show moderation history option to TL4 2017-12-26 17:13:29 -05:00
Arpit Jalan 89d1107f81 UX: show '{count}+' when not sure about exact search count 2017-12-26 19:50:03 +05:30
Régis Hanol 27a368bb70 FIX: SCSS variable regex wasn't working in JS 2017-12-26 11:28:36 +01:00
Vinoth Kannan 688f39447c Skip tab delimited lists in plain text to table conversion 2017-12-26 15:52:22 +05:30
Joffrey JAFFEUX f6dc992b0f
FIX: do not apply i18n if already done 2017-12-26 09:51:45 +01:00
Vinoth Kannan e9cd7af10e FIX: IE not supporting regex negative lookbehind 2017-12-23 23:44:57 +05:30
Vinoth Kannan 035f96d25f Allow linked images inside table cells in HTML to Markdown conversion 2017-12-23 22:48:39 +05:30
Kris a7a0cba45b UX: Fixing font-size issue on /categories 2017-12-22 22:02:33 -05:00
Kris e84fb9ba4d UX: Fixing an issue where category names were too large on /categories 2017-12-22 21:22:12 -05:00
Régis Hanol 779efd9235 FIX: don't set properties on destroyed components 2017-12-22 20:33:33 +01:00
Robin Ward ea9c1e5cf8 Add extensibility endpoints for clicking on topic list item rows 2017-12-22 14:01:17 -05:00
Vinoth Kannan 3ae9d91d86 UX: Use tight list by default in HTML to Markdown conversion 2017-12-22 21:34:55 +05:30
Vinoth Kannan ac1e93e82a Minor fix to correctly trim spaces in HTML to Markdown conversion 2017-12-22 19:05:40 +05:30
Joffrey JAFFEUX 315b9d796d
select-kit refactoring
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
Vinoth Kannan 4935ae4338 Remove unwanted spaces between HTML tags and support Word documents 2017-12-22 09:28:24 +05:30
Kris e667434bb3 UX: Cleaning up a few admin styles 2017-12-21 17:13:06 -05:00
Kris fc2f948a39 UX: user menu-panel icons too large 2017-12-21 16:31:45 -05:00
Robin Ward 69a90f31fb FEATURE: Allow Forums to disable the Backups feature 2017-12-21 15:22:04 -05:00
Kris 9a514e6a26 UX: Fixing mobile post action size 2017-12-21 14:47:58 -05:00
Robin Ward 2908aab0da Allow extensibility on username route format (non-english usernames) 2017-12-21 14:32:51 -05:00
Kris dea3e84f18 UX: Reducing number of font-sizes used in common 2017-12-21 12:59:19 -05:00
Gerhard Schlager 7b58afe677 FIX: ProcessPost job failed for posts that have no user 2017-12-21 14:45:59 +01:00
Gerhard Schlager 727a45185d FIX: regex should behave the same in Ruby and Postgres 2017-12-21 11:26:56 +01:00
Vinoth Kannan 129d924c0d Dont support single row or column tables in HTML to Markdown conversion 2017-12-21 12:58:57 +05:30
Guo Xiang Tan 6ecf37c482 Improve URL validation to check for a valid host.
Parsing a URL with `URI` is not sufficient as the following cases
are considered valid:

URI.parse("http://https://google.com")
=> #<URI::HTTP http://https//google.com>
2017-12-21 13:50:15 +08:00
Sam 62a27f9d57 FEATURE: warn if attempting to mention a group with too many members 2017-12-21 16:13:57 +11:00
Sam 081959227d FIX: unicode titles missing when visiting topic from topic list 2017-12-21 15:20:47 +11:00
Kris 7b0f3f4e34 FIX: only staff highlight main post, not embedded replies 2017-12-20 21:26:24 -05:00
Sam 252cbd8635 FIX: keyboard shortcut allowed you to open composer on closed topics 2017-12-21 13:09:18 +11:00
Sam 2423b18839 FIX: links inside quotes not opening in new tab 2017-12-21 13:00:20 +11:00
Sam 6bf3bee473 FIX: when leaving PM tab revert to user scoped search 2017-12-21 12:30:41 +11:00
Sam e756d02088 FIX: create topic keyboard shortcut not checking permissions 2017-12-21 11:23:57 +11:00
Sam 88a4ec5f1b FIX: stop forking regular backup jobs 2017-12-21 09:00:48 +11:00
Kris 4bf558f941 UX: Reducing number of overall font sizes 2017-12-20 15:57:49 -05:00
Gerhard Schlager ac7e6dab06 FIX: Refreshing Gravatar didn't work 2017-12-20 20:49:58 +01:00
Régis Hanol 7f69362d9d FIX: external links in whisper ended up in a white page
FIX: clicking a link in a onebox wasn't properly extracting the post_id
2017-12-20 17:55:15 +01:00
Joffrey JAFFEUX 6e1dd12390
FIX: load tracked/watched/muted categories on screen loading 2017-12-20 16:13:33 +01:00
Vinoth Kannan ac1d3a761e Support for table & ol tags for HTML pasting in composer 2017-12-20 19:24:55 +05:30
Gerhard Schlager 86c86a1ddb FIX: prevent loading of invalid locales from plugins 2017-12-20 12:14:39 +01:00
Philipp Daniels 6a2bce1931 FIX: Data loss on update of single user_field.
https://meta.discourse.org/t/api-data-loss-caused-by-changed-behaviour-of-custom-user-field-update/74990
2017-12-20 16:33:23 +08:00
Guo Xiang Tan 87c334c063 Fix randomly failing JS acceptance tests. 2017-12-20 11:04:47 +08:00
Sam 7aa56fc9d9 refinement and test for batch mode on feature_topics 2017-12-20 13:58:05 +11:00
Neil Lalonde f5a3be750c PERF: add option to limit how many categories are processed in one call to CategoryFeaturedTopic.feature_topics (#5446) 2017-12-20 13:42:29 +11:00
Arpit Jalan eab66065d1 FEATURE: search log term details page (#5445) 2017-12-20 13:41:31 +11:00
Robin Ward 2735914cf6 FIX: ESlint 2017-12-19 17:55:41 -05:00
Kris d90fc415a1 UX: Reducing number of font sizes used in mobile view 2017-12-19 17:40:08 -05:00
Robin Ward b3fda0ea86 FIX: details tags broke excerpts 2017-12-19 17:28:55 -05:00
Robin Ward c1716d41c7 Add some plugin outlets to the user card 2017-12-19 15:04:54 -05:00
Kris bb2c8b605e UX: Reducing number of different fonts used in Admin 2017-12-19 13:10:38 -05:00
Vinoth Kannan 6272f35eec blockquote tag support for HTML pasting in composer 2017-12-19 20:59:55 +05:30
Régis Hanol 24e89b6b38 FIX: validates 'ThemeField' name when used in a SCSS variable 2017-12-19 16:10:44 +01:00
Gerhard Schlager 84c975e3a5 CRLF caused problems with launch script 2017-12-19 13:55:17 +01:00
blokovi 0df1c85fd3 FEATURE: Serbian translation (#5443) 2017-12-19 12:26:06 +01:00
Sam 9472821331 Allow plugins to specify custom nav items on mobile 2017-12-19 16:50:25 +11:00
Sam 57a1190b07 FIX: correct issue with search omitting words with multiple dots
Previously we used to break up words with dots incorrectly leading to
missing search terms
2017-12-19 16:04:24 +11:00
Sam e63a2487e3 UX: allow for iPhone X in iOS Hacks 2017-12-19 15:20:06 +11:00
Guo Xiang Tan 30ddc1f222 Don't swallow errors when failing to create message for post action. 2017-12-19 10:58:26 +08:00
Guo Xiang Tan b39d3a863d FIX: `moderators` group wasn't being updated to be messagable by everyone.
https://meta.discourse.org/t/custom-flag-not-showing-text/76244
2017-12-19 10:14:56 +08:00
Sam 1abc276451 FIX: properly omit inactive and silenced users from directory 2017-12-19 12:53:59 +11:00
Kris 2d9d43ed1a UX: Removing px font defintions and replacing with em 2017-12-18 15:49:11 -05:00
Vinoth Kannan 70b6030c74 FIX: IE syntax error in regular expression 2017-12-18 23:03:35 +05:30
Vinoth Kannan ad41523895 FEATURE: Converting code tags to Markdown while pasting 2017-12-18 22:12:05 +05:30
Joffrey JAFFEUX 133d97402a
FIX: prevents global input width to impact input inside emoji picker filter 2017-12-18 10:48:33 +01:00
Vinoth Kannan b9f553d45d REFACTOR: Small improvement in code for Tag.slice method 2017-12-18 13:38:47 +05:30
Vinoth Kannan 0588edbc96 FEATURE: Keep supported HTML tags in HTML to Markdown conversion 2017-12-18 12:48:17 +05:30
Guo Xiang Tan 97ceebb570 SECURITY: Don't pass email backup token to sidekiq as a parameter.
* This exposes the token in the Sidekiq dashboard which can be
  viewed by an admin and defeats the purpose of using a token
  in the download backup email ink.
2017-12-18 11:25:22 +08:00
Sam 433ef4513b FEATURE: upload images and fonts in themes via hijack 2017-12-18 10:40:10 +11:00
Sam 5e90abfaea FIX: use hijack for emoji uploads 2017-12-18 10:31:19 +11:00
Vinoth Kannan b963307f30 FIX: IE compatability issue in clipboard files array 2017-12-17 12:04:16 +05:30
Joffrey JAFFEUX 7f89f8aa3f
FIX: reset scroll position when switching tab in edit category modal 2017-12-16 20:46:22 +01:00
Vinoth Kannan 4f2f42d710 PERF: Better handling of headings in HTML inline pasting 2017-12-17 00:45:21 +05:30
Régis Hanol 8175740e87 UX: don't shown the 'staff-counters' div when there's no counter 2017-12-16 13:16:23 +01:00
Régis Hanol 50487d6122 FIX: wasn't able to recover a post 2017-12-16 13:04:20 +01:00
Neil Lalonde e73556f48f FIX: disable New Topic button if filtered to a tag and a category that you don't have permission to post in 2017-12-15 13:42:29 -05:00
Kris 065c155f81 UX: Increasing line-height for headlines in all post content 2017-12-15 11:29:15 -05:00
Guo Xiang Tan 5489cd14c7 Skip validations when fixing `Topic#featured_link` in onceoff job. 2017-12-15 23:45:07 +08:00
Vinoth Kannan dc159d7fa6 Grab dimention of the clipboard images 2017-12-15 17:28:38 +05:30
Vinoth Kannan 9cd48207f2 make eslint happy 2017-12-15 17:08:17 +05:30
Vinoth Kannan 236ecec0b0 Skip HTML pasting if image upload available 2017-12-15 16:40:40 +05:30
Guo Xiang Tan 91e84433ff Take two at fixing JS tests. 2017-12-15 15:46:09 +08:00
Vinoth Kannan 5c3ef7875f FIX: Inline head tag html pasting 2017-12-15 12:00:17 +05:30
Vinoth Kannan bfafca42b7 fix eslint and refactor code 2017-12-15 11:07:50 +05:30
Vinoth Kannan f0497ee9c4
FEATURE: HTML to Markdown conversion using native JavaScript ES6 classes (#5425) 2017-12-15 10:28:20 +05:30
Régis Hanol b91f83eb7d Ignore auto-quote/reply when counting replies 2017-12-15 00:38:14 +01:00
Sam f18dda2adc FEATURE: full rebake of all old posts
This limits to 100 post per 15 minutes, so it will take a while.

This will pick up CommonMark and a large amount of onebox fixes.
2017-12-15 10:28:25 +11:00
Régis Hanol 092c976d7c FIX: prevent 💥 when selecting replies to posts quoting themselves 2017-12-15 00:23:51 +01:00
Régis Hanol 2f792bc59f FIX: a topic should be visited when you've read everything and there's deleted posts at the end 2017-12-15 00:00:48 +01:00
Robin Ward 4fcf9ece3a Allow plugins to customize the columns returned by user_actions
This is useful if they have a different mechanism for rendering an
avatar and want to include custom columns via the `custom_avatar_column`
plugin function.
2017-12-14 16:52:54 -05:00
Neil Lalonde 3cbaea81bd
Merge pull request #5428 from discourse/fix-pending-users-count
FIX: incorrect pending_users_reminder user count
2017-12-14 14:05:37 -05:00
Joffrey JAFFEUX 3090c016d0
FIX: do not display used categories as selectable in categories notifications preferences 2017-12-14 14:40:08 +01:00
Joffrey JAFFEUX 5e1545fb7f
FIX: make sure scrollbar don’t appear 2017-12-14 14:23:40 +01:00
Joffrey JAFFEUX 001abfc4cb Revert "FIX: not permitted theme params when importing theme"
This reverts commit 813df1a3fb.
2017-12-14 11:40:14 +01:00
Joffrey JAFFEUX 041deac67a Revert "FIX: constant lookup error when exporting theme"
This reverts commit 1eda8c50f0.
2017-12-14 11:40:08 +01:00
Joffrey JAFFEUX 813df1a3fb
FIX: not permitted theme params when importing theme 2017-12-14 11:25:58 +01:00
Joffrey JAFFEUX 1eda8c50f0
FIX: constant lookup error when exporting theme 2017-12-14 11:25:11 +01:00
Joffrey JAFFEUX 28a63135b8
FIX: set a default color scheme when creating a new one 2017-12-14 08:21:56 +01:00
Guo Xiang Tan f2565f6c7e SECURITY: Any group can be invited into a PM. 2017-12-14 14:57:48 +08:00
Sam 14cfce2827 Merge branch 'master' of github.com:discourse/discourse 2017-12-14 17:17:02 +11:00
Sam 96584403cd SECURITY: prevent staged accounts from changing email 2017-12-14 17:16:49 +11:00
Guo Xiang Tan 34342ad0d8 FIX: `User#user_avatar` may be nil. 2017-12-14 13:23:03 +08:00
scossar 11050e5d10 Don't override count value that has been set by query.count 2017-12-13 18:48:46 -08:00
Maja Komel 52e38e5527 FIX: save whisper drafts (#5417) 2017-12-14 11:35:08 +11:00
Régis Hanol 5db3d39b05 FIX: Post.reply_ids should also handle quotes 2017-12-14 00:43:48 +01:00
Régis Hanol 53bbf08ea1 FIX: wasn't redirected to group inbox 2017-12-13 23:31:20 +01:00
Régis Hanol c63ecd87f2 FIX: ensure we're always changing 1 post ownership 2017-12-13 22:45:14 +01:00
Maja Komel 0f4ed2e070 display language name in user locale selector - make it consistent with admin (#5424) 2017-12-14 08:17:36 +11:00
Régis Hanol 1b4483c942 FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts 2017-12-13 22:12:06 +01:00
Neil Lalonde 712c9fca1b sorry rubocop 2017-12-13 15:47:42 -05:00
Neil Lalonde 3f1d6a302e FIX: links with query params to external sites fail to load if ga universal auto link domains is used 2017-12-13 13:58:44 -05:00
Joffrey JAFFEUX 8001f68c32
FIX: make sure we don’t show scrollbars on toolbar-popup-menu 2017-12-13 19:01:30 +01:00
Joffrey JAFFEUX e42812fcf7
FIX: make sure new badges have a default type 2017-12-13 10:55:16 +01:00
Joffrey JAFFEUX c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Guo Xiang Tan d5293aeae2 Clean `Topic#slug` when `SiteSetting.slug_generation_method` changes.
https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld
2017-12-13 16:11:07 +08:00
Sam 9d925f6b26 FIX: correctly count participants when more than 24
Also cuts out one query for the normal case
2017-12-13 17:19:42 +11:00
Sam b998efdc94 FIX: do not send mailing list emails to unapproved users 2017-12-13 15:13:17 +11:00
Sam a393d3bcbb FIX: ensure staged accounts are always inactive
If for any reason active is stored in the user model, clear it out
prior to creating an account
2017-12-13 14:22:16 +11:00
Gerhard Schlager a7c1b0c81f FIX: path whitelist for embedded comments didn't work with non-ASCII chars 2017-12-12 20:17:46 +01:00
Gerhard Schlager e30851e45a Move escape_uri method to a more suitable place 2017-12-12 20:17:46 +01:00
Robin Ward 5fbfe34356 FIX: Moderation History wasn't working from timeline admin button 2017-12-12 12:21:10 -05:00
Kris 1be32bf4cf FIX: text indent on twitter oneboxes 2017-12-12 11:17:09 -05:00
Kris d6a18f72b6 UX: Mobile user profile button adjustment 2017-12-12 10:58:03 -05:00
Kris 55c019f776 UX: Cleaning up staff counters on user profiles 2017-12-12 10:40:16 -05:00
Arpit Jalan 492af81e67 FIX: save registration_ip_address for staged users logging in via social auth 2017-12-12 17:41:16 +05:30
Guo Xiang Tan e2b64257b3 Fix undefined method for `NilClass` error. 2017-12-12 18:54:29 +08:00
Régis Hanol af3c153687 make robocop 🤖 happy 2017-12-12 11:33:35 +01:00
Régis Hanol 62a5b174e1 FIX: wasn't able to use the same username when taking over a staged account 2017-12-12 11:26:00 +01:00
Arpit Jalan b014540fde FIX: view was getting rendered twice for rate limiting error 2017-12-12 14:48:58 +05:30
Kris 920571ae07 UX: Making button on advanced search page match input height 2017-12-11 17:15:08 -05:00
Kris 60cd28d5b9
UX: Cleaning up user profiles on mobile 2017-12-11 15:40:04 -05:00
Vinoth Kannan c17a28f875 Using const instead of var while declaring 2017-12-11 14:26:21 +05:30
Guo Xiang Tan 4bd5acec47 FIX: `Topic#featured_link` may contain more than a URL. 2017-12-11 16:36:19 +08:00
Arpit Jalan 3c56c9b637 FIX: strip webhook payload_url 2017-12-11 13:48:11 +05:30
Arpit Jalan 3c230d8f97 FIX: 'redirect_to :back' is deprecated 2017-12-11 12:18:19 +05:30
Kris edd7cb4f0d UX: Replacing some PX font definitions with EM based units 2017-12-08 17:10:49 -05:00
Robin Ward b3bdc68639 UX: Add link to "Moderation History" to flagging interface 2017-12-08 15:48:32 -05:00
Vinoth Kannan fdef4e58f0 Skip markdown table conversion from rich text feature flag setting 2017-12-08 18:30:38 +05:30
Vinoth Kannan b9c0488687 New site setting to enable or disable rich text pasting 2017-12-08 14:09:39 +05:30
Vinoth Kannan 0a47642003 FIX: Pasted text removing if server unable to parse HTML to Markdown 2017-12-08 13:38:54 +05:30
Sam cff9b8846d FIX: rendering %lt;/div noscript in header 2017-12-08 10:30:00 +11:00
Robin Ward 74b9828731 FIX: Remove mentions filters from user and groups
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX fd99e1ef56 FEATURE: site setting enable_mentions to turn on/off mentions 2017-12-07 16:27:58 -05:00
Kris 3e4f02a180 UX: Removing staff highlight from .name so it only applies to .user-title 2017-12-07 16:10:54 -05:00
Kris 6d5e5629f6 FIX: Choices input layout bug in IE11 2017-12-07 15:49:54 -05:00
Robin Ward 3cf4886d3e UX: Add a class name to target the embedded post controls 2017-12-07 15:01:34 -05:00
Kris f7c77171b9 UX: Eliminating a "sweet spot" at 870px viewport where the topic-body exceeds 690px wide 2017-12-07 14:32:31 -05:00
Robin Ward aeebcef7e2 FIX: Don't show the email from the suspension on the user profile 2017-12-07 13:27:02 -05:00
Robin Ward 4ae1bbaeba FIX: Only show the full suspension reason on the admin side 2017-12-07 13:27:02 -05:00
Kris ef0d9d631c
UX: New style for staff highlight
Moved highlight to cooked content, also highlighting primary name (with shield) and title (if applicable). 

**Before**:
![image](https://user-images.githubusercontent.com/1681963/33724323-2269e79e-db3d-11e7-8c93-75b9dc9a1ab7.png)


**After**:
<img width="809" alt="screen shot 2017-12-06 at 3 55 31 pm" src="https://user-images.githubusercontent.com/1681963/33724287-09eb66de-db3d-11e7-8e02-0062ed2b8716.png">
2017-12-07 12:40:39 -05:00
Kris 282633bc97 FIX: New topic composer layout in iOS10 2017-12-07 12:04:39 -05:00
Vinoth Kannan be848b8a5c FIX: Image pasted twice when it copied from browser 2017-12-07 21:23:31 +05:30
Vinoth Kannan 5cceb95f92 Improvement in composer HTML pasting 2017-12-07 21:13:09 +05:30
Vinoth Kannan 858cd3a589 Improvement in composer HTML pasting 2017-12-07 21:08:08 +05:30
Arpit Jalan c168c5895f
Merge pull request #5407 from techAPJ/show-inactive-accounts
FEATURE: new site setting show_inactive_accounts
2017-12-07 20:52:37 +05:30
Maja Komel cce077de56 move /tags/ topics list out of footer (#5405) 2017-12-07 15:25:04 +01:00
Arpit Jalan 5003f07b2c FEATURE: new site setting show_inactive_accounts 2017-12-07 19:22:41 +05:30
Joffrey JAFFEUX f0ef307d2d
FIX: topic timer offset applied two times
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.

This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1  hour to your timezone offset.
2017-12-07 14:42:58 +01:00
Kyle Zhao c52f747031 FEATURE: Catalan Translations (#5404) 2017-12-07 10:36:25 +01:00
Guo Xiang Tan c64774f4f8 Remove debugging code. 2017-12-07 06:48:12 +08:00
Régis Hanol c08d53f2dd keyValueStore isn't available in test 2017-12-06 23:28:28 +01:00
Kris 4d9f26879b FIX: Composer preview-area plugin layout 2017-12-06 16:12:52 -05:00
Régis Hanol ae0acfb1df FEATURE: live reply indicators at the bottom of topic 2017-12-06 21:58:59 +01:00
Régis Hanol ea50f823cb FIX: logging in after an anon ❤️ does not count the ❤️ 2017-12-06 21:58:05 +01:00
Robin Ward cf3ea4f9bd UX: Use the same 404 page for the `unknown` route and exception handler 2017-12-06 15:20:24 -05:00
Robin Ward e8d5d34755 FIX: Don't show trust level if the API didn't return it 2017-12-06 13:13:51 -05:00
ckeboss 7a093ea5d6 Format username for desktop notifications (#5403)
FIX: Desktop notifications weren't formatting the username
2017-12-06 12:52:11 -05:00
Kris f559275b14 FIX: Adjusted the composer preview to avoid odd scroll issue 2017-12-06 11:31:36 -05:00
Vinoth Kannan 7d88cfde0e Skip paste handling if composer textarea lost focus 2017-12-06 19:36:13 +05:30
Guo Xiang Tan 4531563717 Hide new advanced editor and preview sync behind a hidden site settings. 2017-12-06 12:34:58 +08:00
Kris da78e75f6f UX: Mobile post control button color was too specific, overriding solved plugin 2017-12-05 21:07:20 -05:00
Joffrey JAFFEUX 75463e5a91
FIX: correctly print html entity when used in a locale for none 2017-12-05 19:09:12 -05:00
Kyle Zhao 5f318a5241 FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)
* SPEC: PollFeedJob parsing atom feed

* add FeedItemAccessor

It is to provide a consistent interface to access a feed item's tag
content.

* add FeedElementInstaller

to install non-standard and non-namespaced feed elements

* FEATURE: replace SimpleRSS with Ruby RSS module

* get FinalDestination and download with Excon

* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
Robin Ward 410994b7f5 FEATURE: Show a button to Staff for "Moderation History" on posts/topics
When clicked, it pops up a modal showing a history of moderation actions
taken on the post or topic.
2017-12-05 15:20:20 -05:00
Vinoth Kannan 94e9be3b88 Make eslint happy 2017-12-06 01:28:22 +05:30
Vinoth Kannan 8cf7152151 FIX: IE compatability issue in clipboard data types array 2017-12-06 01:02:06 +05:30
Vinoth Kannan 6e054b2572 FEATURE: Convert HTML to Markdown while pasting in composer 2017-12-05 12:23:39 -05:00
Arpit Jalan daeb7694bc update annotations 2017-12-05 21:03:20 +05:30
Vinoth Kannan 37948838be FIX: Global event variable is not compatible with all browsers 2017-12-05 11:27:08 +05:30
Vinoth Kannan 4654f076f5 FIX: Drive spreadsheet table not converting to Markdown table 2017-12-05 11:03:33 +05:30
Kris a1d880a215 FIX: Broken variable 2017-12-04 20:22:04 -05:00
Kris 4af4081c39
UX: Updating the edit post title layout 2017-12-04 15:29:02 -05:00
Neil Lalonde b5a967ab43 lint failure 2017-12-04 14:32:01 -05:00
Neil Lalonde 23ea4b6739 FIX: don't create featured link if title includes more than a url 2017-12-04 14:21:08 -05:00
Neil Lalonde fb08441802 Revert "FIX: don't create featured link if title includes more than a url" 2017-12-04 12:53:12 -05:00
Vinoth Kannan e14281bdf6
Merge pull request #5393 from vinothkannans/clip-master
FEATURE: Paste plain text table as Markdown table
2017-12-04 22:45:07 +05:30
Neil Lalonde cde42c3f69 FIX: don't create featured link if title includes more than a url 2017-12-04 12:03:41 -05:00
Kris b55b7c5356 FIX: Removing horizontal scrollbar in category modal 2017-12-04 12:00:34 -05:00
Kris 8eb7518d2a FIX: Disappearing tag input border on hi-res devices/when scaling 2017-12-04 11:35:02 -05:00
Kris f1b5227aa6 FIX: Mobile composer layout for PMs 2017-12-04 11:15:10 -05:00
Kris 13840942b9 UX: Fixing code highlighting color issue in dark themes 2017-12-04 10:28:32 -05:00
Vinoth Kannan ab4c953d82 FEATURE: Paste plain text table as Markdown table 2017-12-04 20:53:42 +05:30
Arpit Jalan f466791a15 FIX: resolve from URL when using /new-topic route 2017-12-04 17:34:17 +05:30
Arpit Jalan 0e0794dff9 FIX: correct use of invitee vs inviter in email templates 2017-12-04 14:09:48 +05:30
Guo Xiang Tan e73fbfe265 FIX: `Topic#featured_link_root_domain` extracts URL before parsing. 2017-12-04 10:00:07 +08:00
Robin Ward 3e83c34785 FIX: Don't include `null` class when rendering the pinned dropdown 2017-12-03 16:20:35 -05:00
Robin Ward e80caab247 FIX: Reply to tab was not using the username formatter 2017-12-03 15:49:21 -05:00
Robin Ward a0da098e6b UX: Add new classes to make user creation more targetable 2017-12-03 15:03:06 -05:00
Kris c8ad89afd4 UX: Adjustments to composer uploading message 2017-12-01 22:31:40 -05:00
Kris d615a37eba UX: Hiding composer preview reduces width of composer overlay 2017-12-01 22:23:12 -05:00
Jeff Atwood bcd57d72a9
Merge pull request #5389 from vinothkannans/clip-master
FIX: Skip pasting files if plain text available in clipboard
2017-12-01 16:41:39 -08:00
Kris a43c044b1e UX: Removing an old font declaration 2017-12-01 16:17:01 -05:00
Neil Lalonde b35960fc35 FIX: export admin reports to csv would have 0 rows in the csv file 2017-12-01 15:50:36 -05:00
Vinoth Kannan e2c60ea4b2 FIX: Skip pasting files if plain text available in clipboard 2017-12-02 02:05:11 +05:30
Joffrey JAFFEUX dbadebacd1
FIX: allows select-kit to search by null value 2017-12-01 20:02:00 +01:00
Kris 29bdf35977 FIX: Composer not properly centered in IE11 2017-12-01 13:58:04 -05:00
Kris e7725e23ad FIX: Flexbox composer issue in IE11, bad flex-shrink default 2017-12-01 13:12:25 -05:00
Arpit Jalan 54f5b4d4e0 FEATURE: log clicks on full page search 2017-12-01 23:21:16 +05:30
Kris af11913314 FIX: Positining of search spinner in tablet-sized viewports 2017-12-01 11:01:03 -05:00
Joffrey JAFFEUX 966dbb9705
FIX: do not give any element focus when creating topic 2017-12-01 13:16:36 +01:00
Guo Xiang Tan 2e860eddc1 Don't sync scroll when input is not scrollable.
https://meta.discourse.org/t/composer-preview-scroll-not-syncing-with-editor/74975/14?u=tgxworld
2017-12-01 17:08:03 +08:00
Jeff Atwood 3e42dceaae "reply to which topic" needs wider buttons 2017-11-30 23:25:32 -08:00
Arpit Jalan 496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan e3925278e2 FEATURE: support search click through tracking for user, category and tags
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj

This commit adds following features:

- support for tracking click through to user, tag and category
- new filter for search type (header, full page)

This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Vinoth Kannan 7f2eeaf767 FIX: Password required flag should be cleared whenever clearing the raw password (#5384) 2017-12-01 15:19:24 +11:00
Kris 9876f3d0ee FIX: extraneous mobile CSS, flagged badge color in dropdown 2017-11-30 17:29:29 -05:00
Neil Lalonde 3dd67e9c04 replace 'email' with envelope icon on user card for staged users 2017-11-30 16:55:27 -05:00
Neil Lalonde bca90381cf FIX: save drafts of new topics with titles but no body 2017-11-30 15:16:12 -05:00
Robin Ward dfd309c64f FIX: The user summary wasn't using the username formatter 2017-11-30 12:17:03 -05:00
Kris 3f8d0c5c94 FIX: Increasing overridden label contrast in settings 2017-11-30 10:13:09 -05:00
Vinoth Kannan 704dbd7cfc FIX: Unable to remove existing user title (#5386) 2017-11-30 15:54:38 +01:00
Vinoth Kannan 1ee48966ca REVERT: FIX: Password required flag should be cleared whenever clearing the raw password 2017-11-30 16:17:14 +05:30
Vinoth Kannan 1776649b4d FIX: Password required flag should be cleared whenever clearing the raw password 2017-11-30 13:40:18 +05:30
Guo Xiang Tan c128e421c4 FIX: Don't run job if topic timer has already been deleted. 2017-11-30 15:26:26 +08:00
Guo Xiang Tan 853b51b519 Add uniqueness validation for `SingleSignOnRecord#external_id`. 2017-11-30 15:15:52 +08:00
Guo Xiang Tan f7f743970b Just use space to prettify SSO verbose error logging. 2017-11-30 15:10:00 +08:00
Guo Xiang Tan 1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
Sam 05f5df69b1 UX: Add tooltips for messages and notifications in header 2017-11-30 12:56:54 +11:00
Sam 772301bc65 woops 2017-11-30 12:32:50 +11:00
Sam bf1f6c7fe4 UX: better help text for composer collapse / discard
also: warn on collapsed close if you are to discard content
2017-11-30 12:28:00 +11:00
Régis Hanol 0d34caff85 UX: show error message when no gravatar is associated 2017-11-29 18:09:44 +01:00
Régis Hanol 1218ead355 UX: preloaded gravatar was appearing on the right instead of the left 2017-11-29 18:07:09 +01:00
Guo Xiang Tan 9fbe1436b6 UX: Replace heuristic solution root domain extraction for topic featured link. 2017-11-29 21:52:41 +08:00
Guo Xiang Tan 8491c5fba5 UX: Replace heuristic solution for extracting root domain. 2017-11-29 16:26:46 +08:00
Guo Xiang Tan 3e9c3f6f13 Fix JS test.
* `new Array` doesn't seem to be available in phantomJS yet.
2017-11-29 16:03:00 +08:00
Guo Xiang Tan 5b965ab5d0 Sync editor and preview when preview is updated. 2017-11-29 11:19:04 +08:00
Kris 03eb278034
FIX: Increased composer width to match preview, border width fix (#5379) 2017-11-28 21:57:27 -05:00
Guo Xiang Tan ebc31975e8 `Ember.run.schedule` -> `Ember.run.scheduleOnce`. 2017-11-29 10:43:59 +08:00
Guo Xiang Tan de17a8e856 UX: Sync input and preview when user is typing. 2017-11-29 09:56:15 +08:00
Guo Xiang Tan 4816619ba3 FIX: Editor and preview does not sync when scrolled to the bottom. 2017-11-29 08:38:57 +08:00
Guo Xiang Tan bb0b7b61d7 FIX: Don't fail silently when updating a record. 2017-11-29 08:01:13 +08:00
Gerhard Schlager 44ee388070 FEATURE: omit images from og and twitter description tags 2017-11-28 21:34:02 +01:00
Robin Ward 04e8b7dffb UX: Remove another plugin outlet container we don't need 2017-11-28 14:46:17 -05:00
Robin Ward 86df5846c8 Don't use a tag for a couple of topic outlets 2017-11-28 14:42:24 -05:00
Robin Ward 823896d698 FIX: Use parseable date format 2017-11-28 14:16:33 -05:00
Kris fbc4191195 moving inputs outside of label tag 2017-11-28 14:12:01 -05:00
Robin Ward 23ee3047bf FIX: Future date input selector was not respecting timezone 2017-11-28 13:44:24 -05:00
Robin Ward f4b3306bf4 FIX: Link from flagged topics to user was broken 2017-11-28 13:10:30 -05:00
Gerhard Schlager 41e70c410c
FEATURE: replace GUID in image name uploaded from iOS (#5370) 2017-11-28 11:05:34 +01:00
Arpit Jalan f37a1d5976 UX: add tooltip to unique on search logs page 2017-11-28 15:29:35 +05:30
Guo Xiang Tan 1d8b834301
Merge pull request #5369 from vinothkannans/queued
FIX: Error if queued post not found while updating
2017-11-28 17:51:05 +08:00
Angus McLeod 8a0d7bb922 Update wizard import to new select-kit style path (#5375) 2017-11-28 10:06:05 +01:00
Guo Xiang Tan 110dfbf42f Uglify doesn't support ES6 yet. 2017-11-28 16:07:27 +08:00
Guo Xiang Tan 7b8699f3be FIX: Can't load `service-worker.js` in production. 2017-11-28 15:40:57 +08:00
Jeff Wong b094894c94 Feature: Add service worker registration method to plugin API 2017-11-28 14:01:41 +08:00
Sam b3b55e18d1 UX: stop warping tiny onebox images 2017-11-28 12:32:35 +11:00
Sam ceaadf6246 UX: adjustments for topic title editing 2017-11-28 12:00:18 +11:00
Kris 87c83f102d small color fix 2017-11-27 18:30:12 -05:00
Kris d31c8ffa87
small color adjustment (#5374) 2017-11-27 18:20:07 -05:00
Sam 5a715b7d55 lint it up 2017-11-28 07:39:24 +11:00
Kris ada1d6b987
Composer restyle
* composer restyle, some input normalization

* style adjustments: spacing, preview background, colors

* small spacing adjustments, removing default iOS input appearance, fixing merge

* small width adjustment

* fixing mobile link modal for small devices

* FIX: more resilient allowInitiatlValueMutation implementation

* Build scrollMap only on scroll.

* FIX: pick date and time was not reseting state

* FIX: removes auto sizing and touchstart support for now

* Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"

This reverts commit b5ed980235.

* tweak icon-library generation

* FIX: regression preventing to set number of hours before closing

This commit also adds a full test suite for editing topic timer.

* FIX: makes allowInitialValueMutation more restrictive

* FIX: invite-list expects initial value mutation

* fixing tag input spacing

* minor input cleanup

* bump onebox version

* FIX: avoids test failing at some times of the day

* FIX: various issues when editing category permissions

This commit also adds multiple tests
2017-11-27 15:23:18 -05:00
Joffrey JAFFEUX 49b1df40fc
FIX: various issues when editing category permissions
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Neil Lalonde c22f202e10 FIX: missing likes count on top topics in user summary 2017-11-27 13:42:16 -05:00
Robin Ward 36d46df8dc New setting to show the reply title on the post menu on mobile 2017-11-27 13:21:53 -05:00
Arpit Jalan 2c16240b60 fix the build 2017-11-27 23:18:08 +05:30
Arpit Jalan bf415f2d40 FIX: youtube playlist videos were not functioning properly in fullscreen 2017-11-27 22:56:44 +05:30
Robin Ward 77f90876d3 REFACTOR: Track manual locked user levels separately from groups 2017-11-27 11:23:44 -05:00
Vinoth Kannan 31aa21b5a4 FIX: Error if queued post not found while updating 2017-11-27 19:25:51 +05:30
Sam 608207b2e5 FEATURE: avatar proxy happens in background
This ensures that even if it is slow to download avatars site will
continue to work

Also simplifies hijack pattern
2017-11-27 17:43:24 +11:00
Sam d5e7691ae9 favicon proxy now uses hijack 2017-11-27 14:51:14 +11:00
Guo Xiang Tan 5805979e88 FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
Sam eb428ef54d FEATURE: uploads are processed a faster
Also cleans up API to always return 422 on upload error. (previously returned 200)

Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
Sam a74ac90bf5 FIX: quote dropped when replying as new topic 2017-11-27 10:08:55 +11:00
Angus McLeod 4b919cd735 Move queuedForTyping assignment (#5366) 2017-11-27 09:43:41 +11:00
Joffrey JAFFEUX 329343be06
FIX: various sizing issues on select-kit 2017-11-26 17:21:39 +01:00
Arpit Jalan abbb2b28eb bump onebox version 2017-11-25 15:53:18 +05:30
Neil Lalonde 39d7745dc5 UX: show staged users' email addresses to staff without requiring a button press 2017-11-24 16:11:34 -05:00
Neil Lalonde 510a2a1e0f remove ancient unused css 2017-11-24 15:42:50 -05:00
Neil Lalonde 6f8f2c494d FIX: admin strings in plugins should fallback to english when untranslated 2017-11-24 14:11:01 -05:00
Kris c2da25dd5c
Cleaning up the 404 page (#5363) 2017-11-24 12:41:31 -05:00
Guo Xiang Tan f3f051a344 UX: Composer textarea should always start at the top. 2017-11-24 23:24:37 +08:00
Joffrey JAFFEUX f2c7f39066
FIX: invite-list expects initial value mutation 2017-11-24 13:32:24 +01:00
Joffrey JAFFEUX 96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Gerhard Schlager b3094e9954 FIX: incoming and outgoing emails got lost when post was moved 2017-11-24 11:45:36 +01:00
Guo Xiang Tan 44333c5de3 REFACTORY: Dry up some composer syncing code. 2017-11-24 14:57:36 +08:00
Sam e0e99d4bbd PERF: hijack onebox requests so they do not use up a unicorn worker 2017-11-24 15:31:40 +11:00
Joffrey JAFFEUX 63307c303a
FIX: regression preventing to set number of hours before closing
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Neil Lalonde 3f58b18dab FEATURE: user card shows staff if a user is staged and lets them check the email address 2017-11-23 16:38:11 -05:00
Arpit Jalan 406ad1a1f2
Merge pull request #5357 from techAPJ/invite-trust-level
FIX: invited users were not granted trust level based on their group
2017-11-23 23:42:20 +05:30
Robin Ward ad07e6e172 FEATURE: `group_removes_trust_level` setting
By default in Discourse, if a group grants a user a particular trust
level that is locked even if they are removed from the group.

With this new setting, when a user is removed from a group their
trust level is set to either the next highest trust level based on group
membership, or they are unlocked and promoted based on the default
mechanisms.
2017-11-23 13:03:24 -05:00
Joffrey JAFFEUX 9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX dd5562322b Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"
This reverts commit b5ed980235.
2017-11-23 18:24:26 +01:00
Arpit Jalan 3508046e33 FIX: invited users were not granted trust level based on their group
https://meta.discourse.org/t/bulk-invites-and-trust-level/73535

If the user enters password when accepting invite they were not granted
trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.
2017-11-23 22:19:28 +05:30
Gerhard Schlager 39810e4425 FIX: do not move small post actions 2017-11-23 17:25:53 +01:00
Joffrey JAFFEUX 616a0dae4e
FIX: removes auto sizing and touchstart support for now 2017-11-23 15:34:52 +01:00
Gerhard Schlager eaa54a5a64 FIX: don't store state of composer's preview in mobile view 2017-11-23 15:22:00 +01:00
Joffrey JAFFEUX 5b3ecffbb2
FIX: pick date and time was not reseting state 2017-11-23 15:18:27 +01:00
Guo Xiang Tan c5745feac6 Build scrollMap only on scroll. 2017-11-23 21:44:09 +08:00
Joffrey JAFFEUX fe94e7c453
FIX: more resilient allowInitiatlValueMutation implementation 2017-11-23 14:39:26 +01:00
Guo Xiang Tan ab839d134b Fix scrollmap included NaN values. 2017-11-23 18:08:43 +08:00
Joffrey JAFFEUX 9f0798682e
FIX: tweak alignment of select-kit in navigation bar 2017-11-23 10:42:39 +01:00
Guo Xiang Tan 486016acea UX: Improve editor and preview scroll syncing. 2017-11-23 17:02:02 +08:00
Sam 49f97d75b7 FIX: make uploads safe for block that can run later 2017-11-23 17:28:18 +11:00
Sam d43a54e83a FIX: use current_user.id in onebox instead of param 2017-11-23 15:32:19 +11:00
Sam 2fe131db9f UX: handle super tall images in onebox respectfully.
Tall images got distorted previously
2017-11-23 14:45:46 +11:00
Neil Lalonde 6c86e0c94a FEATURE: remove the featured link by editing the topic 2017-11-22 14:53:35 -05:00
Joffrey JAFFEUX d32c95b6e8
FIX: avoid touch on select-kit causing instant closing of it 2017-11-22 16:36:50 +01:00
Régis Hanol 8a7cbeef00 UX: hide 'dismiss' in notifications dropdown when there are no unread notifications 2017-11-22 15:56:01 +01:00
Régis Hanol 4addc5e329 Add missing contexts when destroying users 2017-11-22 15:43:54 +01:00
Joffrey JAFFEUX acdfb3ed03
FIX: don’t convert an object using EachProxy to an array 2017-11-22 14:33:04 +01:00
Joffrey JAFFEUX b14d9529b8
FIX: adds support for name changes tracking 2017-11-22 13:49:45 +01:00
Joffrey JAFFEUX 86b8f6b238
FIX: cast integer on truthy value and not only true
allows castInteger="true" to work
2017-11-22 13:40:22 +01:00
Joffrey JAFFEUX 5a992fe5e7
FIX: makes sure keyboard is disabled on mobile 2017-11-22 12:33:07 +01:00
Joffrey JAFFEUX a3b511f4f5
FIX: simplify keyboard handling 2017-11-22 11:29:30 +01:00
Joffrey JAFFEUX b2b565c2fb
select-kit initial plugin api implementation (0.8.13)
```
api.modifySelectKit("identifier-of-the-select-targeted")
  .modifyContent((context, existingContent) => {})
  .appendContent(() => {})
  .prependContent(() => {})
  .onSelect((context, val) => {});
```
2017-11-22 10:34:12 +01:00
Joffrey JAFFEUX f3db3c7e0b
FIX: future-date-input-row lost datetimes 2017-11-22 08:52:00 +01:00
Sam a92f61e926 FIX: allow login required sites access to attachements 2017-11-22 10:50:55 +11:00
Joffrey JAFFEUX 761f4afd85
FIX: tab should select and focus next tabindex 2017-11-21 23:28:48 +01:00
Robin Ward 8d98752b57 Allow sites to bootstrap the error page.
This will display working dropdowns and such even if the page is a 404.
2017-11-21 16:13:09 -05:00
Robin Ward be34b796ea UX: Add targetable class 2017-11-21 14:55:55 -05:00
Neil Lalonde 33feb62673 FIX: times showing as < 1m instead of blank 2017-11-21 14:33:49 -05:00
Neil Lalonde 66e53f449a UX: Auth complete page/modal has a link to continue to the site to accomodate auth methods that can't automatically redirect to Discourse 2017-11-21 13:56:19 -05:00
Joffrey JAFFEUX 12beb77afa
FIX: make sure the element exists before calling `off`
This commit fixes an issue happening only when running tests under `/qunit` and not with `rake qunit:test`
2017-11-21 19:08:59 +01:00
Robin Ward 7533e5b541 UX: Use date picker on full page search 2017-11-21 12:52:23 -05:00
Joffrey JAFFEUX 7669146897
FIX: force focus input only on expand 2017-11-21 18:23:49 +01:00
Robin Ward 628275fc31 FIX: Some badge routes were still working even with badges disabled 2017-11-21 12:22:44 -05:00
Joffrey JAFFEUX 9444c31918
FIX: makes typing indicator visible when possible 2017-11-21 18:07:10 +01:00
Joffrey JAFFEUX 3dfc0777df
FIX: close on click outside 2017-11-21 17:37:13 +01:00
Joffrey JAFFEUX 00e9805e23
FIX: category descriptions should display html 2017-11-21 17:31:26 +01:00
Joffrey JAFFEUX 2087d011df
FIX: fix bugs with keyboard events 2017-11-21 16:59:03 +01:00
Joffrey JAFFEUX b5ed980235
FIX: reflects discourse icons naming scheme s/d-icon-*/d-* 2017-11-21 16:01:15 +01:00
Joffrey JAFFEUX f210e1660d
uses correct path for component connector 2017-11-21 16:00:49 +01:00
Joffrey JAFFEUX b76154ec36
minor refactoring of component-connector 2017-11-21 15:48:56 +01:00
Joffrey JAFFEUX 5dd890eb3d
FIX: displayCategoryDescription was not working correctly 2017-11-21 15:38:30 +01:00
Joffrey JAFFEUX b8c95373be
uses right naming for search-advanced-category-chooser component 2017-11-21 14:47:53 +01:00
Arpit Jalan 753a4fc369 UX: make onebox timestamp consistent with header 2017-11-21 16:39:15 +05:30
Joffrey JAFFEUX 39f3dbd945
Introduces select-kit
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:

```
computeValue()
computeContent()
mutateValue()
```
2017-11-21 11:53:09 +01:00
Régis Hanol c4d0eb802e FIX: delete upload records when sha is null 2017-11-21 10:20:42 +01:00
Guo Xiang Tan f7642e076d REFACTOR: Avoid duplicated logic on server and client. 2017-11-21 17:10:04 +08:00
Régis Hanol 2d48caffdf FIX: be more lenient when deleting a custom emoji 2017-11-20 23:50:23 +01:00
Neil Lalonde dcd60dcc8f FIX: cap posts_read_count in user_stats to 50 posts per topic_entered 2017-11-20 17:15:05 -05:00
Robin Ward f8164956dd Add quote and mention support for username formatters 2017-11-20 16:28:03 -05:00
Robin Ward c53ed61bd3 UX: There were many places where username formatters were not applied 2017-11-20 15:03:13 -05:00
Robin Ward b9595966d4 FIX: Error applying quotes with blank lines in front 2017-11-20 13:46:19 -05:00
Robin Ward 0a9daba627 FIX: Support for long suspension emails 2017-11-20 12:45:46 -05:00
Neil Lalonde 8496191f0b UX: better tooltip for read time on user cards 2017-11-20 11:55:22 -05:00
Sam 7e841a0495 FIX: stop counting PMs, deleted topics and whispers in directory and user stats 2017-11-20 16:44:09 +11:00
Guo Xiang Tan a27dd760b9 FIX: Incorrect group path. 2017-11-20 09:55:15 +08:00
Sam ff1ce175fc FIX: sometimes quote button did nothing on Firefox 2017-11-20 11:14:44 +11:00
Gerhard Schlager 92a831bae6 FEATURE: user directory returns staged users during search 2017-11-19 01:17:31 +01:00
Neil Lalonde 6dda87c49b FEATURE: show topics viewed on user summary 2017-11-17 17:53:30 -05:00
Neil Lalonde 7c6f991313 REFACTOR: remove AgeWord calls from serializers and do it in javascript 2017-11-17 17:53:30 -05:00
Kris 4daaa3544b mobile topic adjustments 2017-11-17 16:57:25 -05:00
Neil Lalonde 87ec11e298 FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats. 2017-11-17 16:08:46 -05:00
Robin Ward 3785429948 FIX: Missing word boundaries when non-regexp 2017-11-17 14:37:31 -05:00
Robin Ward d755c9c90f FIX: Allow regular expressions to specify boundaries 2017-11-17 14:13:44 -05:00
Joffrey JAFFEUX faa597ff90
FIX: avoids view jumping on mobile 2017-11-17 07:31:57 -08:00
Gerhard Schlager d47fa6653b do not notify staged users about posts withing mailinglist mirror category 2017-11-17 15:29:14 +01:00
Gerhard Schlager 8f6d35aa59 FEATURE: category setting for mailinglist mirror 2017-11-17 15:29:14 +01:00
Régis Hanol ddd4ddc020 missing 1px in .posters column when there are 5 posters and OP is most recent poster 2017-11-17 12:42:19 +01:00
Michael Howell c7d024446e Cast the numeric keys of `USER_HOMES` to numbers (#5322)
When converting from hard-coded functions to a map,
the key `1` got converted to `"1"`.
This broke the drop-down menu.
2017-11-17 11:01:18 +11:00
Neil Lalonde b37e40eea9 FEATURE: show read time in last 60 days 2017-11-16 15:46:51 -05:00
Kris 3d145a588f fixing an inconsistency that was cuasing some theme issues (#5320) 2017-11-16 12:44:00 -05:00
Robin Ward 54db283e31 Small code tidy up for user/activity menu 2017-11-16 11:49:14 -05:00