Robin Ward
d09f109b2c
FIX: Re-enable filtering on user expansions on topics
2014-09-02 12:08:02 -04:00
Robin Ward
ce745b737e
Renamed `poster-expansion` to `user-expansion` because it's not specific
...
to a poster anymore.
2014-09-02 12:08:02 -04:00
Robin Ward
2b0e11dad8
Merge pull request #2711 from hydrarulz/localize_romanian
...
Add translation for Romanian.
2014-09-02 10:48:38 -04:00
Robin Ward
065101afac
Merge pull request #2734 from cpradio/readd-dismiss-bindings
...
FIX: Readd the dismiss keybindings
2014-09-02 10:42:53 -04:00
Arpit Jalan
8955bf02d8
hide poster avatars when only two posts
2014-09-02 20:10:36 +05:30
Sam
22fbae8556
Merge pull request #2674 from akshaymohite/optimization-fixes
...
renamed unused variables properly
2014-09-02 08:22:43 +10:00
Sam
e0c8abc911
Merge pull request #2717 from riking/badge-solid
...
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
Sam
202656a679
Merge pull request #2725 from cpradio/german-keyboard-support
...
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
cpradio
02a7a579f4
FIX: Duplicate badge titles can still occur
...
Send false instead of true to .uniq as the badges are not sorted.
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge-2/19495
2014-09-01 13:56:19 -04:00
Jeff Atwood
03a7b01e4b
Merge pull request #2735 from techAPJ/patch-3
...
suppress post count on avatar for single post
2014-09-01 08:11:32 -07:00
Arpit Jalan
eba3f6b408
suppress post count on avatar for single post
2014-09-01 14:23:34 +05:30
Sam
68cc4fb285
we need more height
2014-09-01 17:42:27 +10:00
Sam
60559b42be
got to move inidicator a bit
2014-09-01 17:17:50 +10:00
Sam
69e418facf
FEATURE: wider search with more context
2014-09-01 17:04:57 +10:00
riking
808460a28f
Fix magic numbers, extra param references
2014-08-31 19:36:31 -07:00
cpradio
42c052d21b
FIX: Readd the dismiss keybindings
...
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
2014-08-31 21:56:38 -04:00
cpradio
6234284243
FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings
2014-08-31 21:42:03 -04:00
Kamil Bielawski
bf679f1626
FIX: destroy CategoryGroup when Category or Group is destroyed
2014-08-31 22:10:38 +02:00
riking
1833b43ae2
FEATURE: Badge query validation, preview results, and EXPLAIN
...
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.
Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.
On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).
The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.
The Badge.save() method is amended to propogate errors.
Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.
Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.
An uninitialized variable path is removed in the backfill() method.
TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Sam
5c244c6f8f
FIX: autocomplete username failing to pop up
...
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises
This also fixes a promise leak
2014-09-01 01:48:17 +10:00
Jeff Atwood
6d1be665a1
Merge pull request #2729 from cpradio/firefox-kbd-post-navigation
...
FIX: j/k navigation for posts using Firefox
2014-08-30 13:32:15 -07:00
cpradio
37639308c0
FIX: Firefox j/k post navigation is inconsistent
...
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
cpradio
3f5d530553
Change SHIFT+J and SHIFT+K to move up/down sections instead of posts.
2014-08-30 07:31:38 -04:00
Arpit Jalan
82d4c29c88
TRIVIAL: add line break before time for post navigator
2014-08-30 16:14:00 +05:30
Jeff Atwood
7a50ba600a
Merge pull request #2726 from techAPJ/patch-4
...
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
Arpit Jalan
3c005557e6
FIX: use short date format for post navigator
2014-08-30 11:34:33 +05:30
Jeff Atwood
4281b16616
UX: dim the new and unread education
2014-08-29 22:54:11 -07:00
cpradio
89eb03aff0
FIX: Support J/K bindings on German Keyboards
...
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
2014-08-29 22:18:03 -04:00
cpradio
8b349b43a5
UX: Add keyboard binding for reply as new topic
...
Removed extra translation in the keyboard shortcut modal window
2014-08-29 20:10:34 -04:00
cpradio
2e200ffbf0
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
...
Conflicts:
config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
cpradio
875b39fb5f
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
2014-08-29 19:56:39 -04:00
Jeff Atwood
cb45d5fa25
Merge pull request #2724 from cpradio/key-binding-reply-new-topic
...
UX: Add keyboard binding for reply as new topic
2014-08-29 16:46:34 -07:00
Jeff Atwood
d74f94afa1
Merge pull request #2722 from cpradio/dismiss-keyboard-bindings
...
UX: Add key-bindings for Dismiss New, Dismiss Posts, and Dismiss Topics
2014-08-29 16:28:25 -07:00
cpradio
68e807f791
UX: Add keyboard binding for reply as new topic
2014-08-29 19:14:42 -04:00
cpradio
bc07bc4819
Remove incoming/updated topics logic (not sure how that got in here, but it is causing a conflict)
2014-08-29 18:19:06 -04:00
Neil Lalonde
1291e94c78
Merge pull request #2715 from cpradio/master
...
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
Robin Ward
6dcde9ccc3
FIX: Navigating to None was not working
2014-08-29 15:51:28 -04:00
Robin Ward
9062719480
Merge pull request #2720 from techAPJ/patch-3
...
FIX: do not redirect topic for JSON request
2014-08-29 13:59:45 -04:00
Robin Ward
926e45d030
SECURITY: User action route was returning too much data
2014-08-29 13:46:50 -04:00
Arpit Jalan
84d0b599a4
FIX: do not redirect topic for JSON request
2014-08-29 23:09:02 +05:30
Robin Ward
16c9f073b5
FIX: Back button breaks translation of incoming stuff
2014-08-29 12:53:06 -04:00
Neil Lalonde
ec42b61a4d
FIX: suspended users cannot be trust level 3
2014-08-29 12:33:34 -04:00
cpradio
8033972536
UX: Add keyboard bidning for incoming/updated topics
...
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
cpradio
5ca96e741d
UX: Add keyboard bidning for incoming/updated topics
2014-08-29 09:44:26 -04:00
cpradio
096bc0c0ae
Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
...
Conflicts:
app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cpradio
cde64580b1
Change the Dismiss keybindings to use 'x' instead of 'd' - moved it to a function binding
2014-08-29 09:35:38 -04:00
cpradio
3f085c3fd3
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 09:22:47 -04:00
cpradio
ede9d1e057
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 08:46:35 -04:00
cpradio
9e72b97a75
Corrected an issue with using the same ID for the header/footer of the buttons
2014-08-29 08:33:45 -04:00
cpradio
e4ce995369
FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu
2014-08-29 08:11:23 -04:00
cpradio
ed8d828ff1
FIX: Added keyboard bindings for dismiss buttons
2014-08-29 08:04:57 -04:00
Régis Hanol
fd6dd88afb
FIX: dual modal when deleting spammer in the flag modal
2014-08-29 13:05:51 +02:00
Régis Hanol
521cb6bd0d
FIX: dual modal when selecting 'delete spammer' in flags section
2014-08-29 12:54:24 +02:00
Jeff Atwood
8bda8a2235
Revert "UX: stop displaying "user deleted, OK" dialog"
...
This reverts commit 36405287b4
.
2014-08-29 03:49:00 -07:00
Jeff Atwood
36405287b4
UX: stop displaying "user deleted, OK" dialog
2014-08-29 03:34:23 -07:00
riking
3396e6fea3
Centralize MessageBus post updates
...
After this change, only two files directly publish to MessageBus with a
topic interpolated in the channel: Post and TopicUser.
2014-08-28 20:40:36 -07:00
riking
0a7a4eae99
Publish lightboxing on the message bus
...
With this change, images appear to lightbox instantly on my development
machine.
2014-08-28 20:16:33 -07:00
cpradio
0784c52a24
FIX: Remove up/down key bindings for search results
...
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 21:39:19 -04:00
Sam
c07d76677d
Merge pull request #2701 from riking/email-pr-ssl
...
Rename POP3 settings, fix multisite SSL state leak
2014-08-29 10:02:05 +10:00
cpradio
3e7084743c
FIX: Remove up/down key bindings for search results
...
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 19:58:07 -04:00
Sam
8ab9c57ca5
Merge pull request #2707 from eyalev/rtl-email
...
Enable RTL direction in emails.
2014-08-29 09:54:57 +10:00
Sam
5b696ca25a
Merge pull request #2708 from Wilhansen/sso_override_avatar
...
Fix SSO avatar downloading issues.
2014-08-29 09:53:48 +10:00
Robin Ward
85c6eb9b08
SECURITY: Only redirect to our host by path on the login action
2014-08-28 17:45:13 -04:00
Robin Ward
9e2c72e277
Allow restoring from backups in development mode even if the setting is
...
off.
2014-08-28 17:02:48 -04:00
cpradio
1acb2a13f1
Added a:first
2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f
Set focus on site-map and user menu
...
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
Neil Lalonde
14890a6002
FEATURE: add a way to map arbitrary urls to a topic, post, or category. Useful for sites that have migrated to Discourse and want to redirect from their old site to Discourse with 301 redirects.
2014-08-28 15:58:24 -04:00
Robin Ward
8a6c4234fc
FIX: Re-enable searching for topic by id when using the split topic
...
interface.
2014-08-28 15:42:29 -04:00
Robin Ward
b5b13b8c5f
Revert "Merge pull request #2713 from cpradio/master"
...
This reverts commit a9de189682
, reversing
changes made to b7ab43e454
.
2014-08-28 15:08:06 -04:00
Robin Ward
a9de189682
Merge pull request #2713 from cpradio/master
...
Set focus on first item in drop down (textbox, link, whatever it may be)
2014-08-28 14:47:38 -04:00
Robin Ward
8bf27642ad
FIX: Refresh was losing top controls after bulk operation. Removed
...
console.log
2014-08-28 14:44:38 -04:00
Robin Ward
69cb5bc425
FIX: Centralize Top rendering, remove old code paths. Fix some bugs.
2014-08-28 14:34:31 -04:00
Robin Ward
30b102aa98
FIX: Show uncategorized with badge/description in the category chooser
2014-08-28 12:42:31 -04:00
Robin Ward
c9262a8390
FIX: Resend activation email was busted
2014-08-28 12:07:13 -04:00
cpradio
a40b08f210
Set focus on first item in drop down (textbox, link, whatever it may be)
...
Set focus on first item in the drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 11:33:45 -04:00
Régis Hanol
38f52f0f8e
FIX: banner topic's max-width & max-height on both mobile & desktop
2014-08-28 16:15:48 +02:00
Luca Daniel
2cf92dbe7b
Add translation for Romanian.
2014-08-28 14:01:14 +03:00
Sam
a1244043d3
FIX: when search finds a deep link in a topic it takes you to it
2014-08-28 17:16:39 +10:00
Sam
3a9f0445bb
HACK: remove jarring scroll when hitting back from topic
2014-08-28 11:57:24 +10:00
Robin Ward
fc71662a13
FIX: Don't show topics as unread when hitting back
2014-08-27 18:01:02 -04:00
Robin Ward
0ae3c327de
Add a message to the staff logs indicating why a user was purged
2014-08-27 16:05:07 -04:00
Neil Lalonde
940c0d5dbb
FIX: topicCountStats was depending on the wrong properties
2014-08-27 15:58:32 -04:00
Neil Lalonde
99d26cef1a
FIX: uncategorized counts were always 0. topics_year, topics_month, topics_week, topics_day
2014-08-27 15:58:32 -04:00
Robin Ward
f05d2ed7cf
PERF: Do far fewer checks and use a lot less memory when loading more
2014-08-27 15:31:06 -04:00
Robin Ward
aab8eaac03
FIX: Double clicking quote expansion shouldn't break stuff.
2014-08-27 14:04:00 -04:00
Robin Ward
09ea159afc
UX: Add link to change username on admin page
2014-08-27 13:52:01 -04:00
Robin Ward
b1c0a3d01c
FIX: Retain back button scroll position even if we don't load more.
2014-08-27 13:33:52 -04:00
Robin Ward
f10d6ed88a
FIX: RSS feeds should use `created_at` not `bumped_at`
2014-08-27 12:42:54 -04:00
Robin Ward
bf8528b6ec
FIX: Use the `bumped_at` date for the RSS feed for a topic
2014-08-27 12:34:47 -04:00
Arpit Jalan
3a76f9e79f
FIX: allow localization in timestamp
2014-08-27 20:57:06 +05:30
Wilhansen Li
bba3f7c0ac
Fix SSO avatar downloading issues.
...
* Follow redirects when downloading SSO avatars.
* Add proper image ext. to downloaded SSO avatars.
2014-08-27 21:35:54 +08:00
Eyal Levin
e0c2f3df3a
Enable RTL direction in emails.
2014-08-27 14:38:03 +03:00
Jeff Atwood
009dc7ded3
missed a spot in CSS
2014-08-27 02:58:32 -07:00
Jeff Atwood
f557f7eeb9
change fix for [quote] padding
2014-08-27 02:45:57 -07:00
Jeff Atwood
dc6dd26b10
FIX: [quote][/quote] missing top padding
2014-08-27 02:22:58 -07:00
Sam
87d2be3ecf
FIX: ensure triggered badges are never triggered if filter is missing
2014-08-27 18:02:13 +10:00
Sam
f48b78c0bb
FEATURE: Allow localization sessions
...
use: I18n.verbose_localization_session()
2014-08-27 17:50:29 +10:00
Jeff Atwood
587f7f56c8
FIX: share link pushing viewport on mobile
2014-08-27 00:46:26 -07:00
Jeff Atwood
b3d896723b
Merge pull request #2706 from techAPJ/patch-2
...
FIX: use short date format for timestamp
2014-08-27 00:42:56 -07:00
Arpit Jalan
0453da6fa5
FIX: use short date format for timestamp
2014-08-27 12:56:52 +05:30
Jeff Atwood
180430de93
LAYOUT: add more space around topic map links
2014-08-27 00:24:58 -07:00
Sam
898d86fd9b
correct annotations
2014-08-27 15:30:17 +10:00
Sam
414c6d191f
FIX: remove nullable dates post upgrade to Rails 4
2014-08-27 15:19:25 +10:00
Sam
16c34c206d
FEATURE: verbose localization option
2014-08-27 14:12:11 +10:00
cpradio
1678a91a60
Add shortcuts for Profile Menu and Hamburger Menu
...
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
riking
e28ef099a4
Fix pop3 SSL state leaking over multisite
2014-08-26 17:03:58 -07:00
riking
6d357c9c23
Rename pop3s settings to pop3, remove 'insecure'
2014-08-26 17:03:58 -07:00
Robin Ward
105959c402
Merge pull request #2696 from riking/errors
...
Fix "Server Error: [missing {{code}} value]" page
2014-08-26 11:14:57 -04:00
Jens Maier
c58565d09f
Fix: dialect block parser should not eat next block's whitespace
2014-08-26 14:11:23 +02:00
Jeff Atwood
d63c6292b3
change "Visit Profile" to just "Profile"
2014-08-26 00:37:10 -07:00
Jeff Atwood
553e0290a6
mods can use shield glyph as well, don't need two
2014-08-25 23:49:39 -07:00
Sam
1ccfb4fa20
FIX: crashing job
2014-08-26 16:22:13 +10:00
Jeff Atwood
95f9943d28
remove <br/> from top non-mobile layout
2014-08-25 22:42:41 -07:00
Jeff Atwood
b6b0cd5c15
add glyph to move posts to new topic button
2014-08-25 22:38:28 -07:00
Sam
3ea76815e4
Merge pull request #2686 from meglio/ru-plurals
...
Update RU pluralization to use 3 keys: one, few, other (as by Transifex)
2014-08-26 12:42:59 +10:00
Sam
c412d74369
HACK: suppress "1 reply" when directly below for quotes posts
2014-08-26 12:00:16 +10:00
Sam
f331855482
FIX: username autocomplete more reliable, cancel old reqs
2014-08-26 11:32:50 +10:00
riking
5261f2e751
Fix "Server Error: [missing {{code}} value]" page
...
The translation was expecting a non-existent parameter.
2014-08-25 17:20:48 -07:00
Sam
96af48d903
Merge pull request #2694 from riking/logster-link
...
Fix Logster link by bypassing Ember router
2014-08-26 09:30:16 +10:00
riking
4db5c8d617
Add data-auto-route=true to Logster link
2014-08-25 15:59:48 -07:00
Robin Ward
a568696098
FIX: Add the <br/> without removing stuff
2014-08-25 18:56:27 -04:00
Robin Ward
939b7ce7e2
Revert "FIX: Added <br/> for @coding-horror"
...
This reverts commit d62218fb5b
.
2014-08-25 18:56:27 -04:00
Sam
64331e2ac1
row style is common, its the way we clear divs
2014-08-26 07:41:29 +10:00
Robin Ward
d62218fb5b
FIX: Added <br/> for @coding-horror
2014-08-25 17:21:01 -04:00
Robin Ward
c820c65172
Merge pull request #2692 from riking/sorted_badges
...
Sort the badges on the user profile page
2014-08-25 15:56:27 -04:00
Jeff Atwood
de1e0345df
proper fix for top page bottom buttons on mobile
2014-08-25 12:55:45 -07:00
riking
234956234b
Fix badge type ordering
2014-08-25 12:48:31 -07:00
Jeff Atwood
a11cc46c73
remove global margin right on mobile btn
2014-08-25 12:47:02 -07:00
riking
99c11e2184
Sort the badges on the user profile page
...
Also clean up UserBadgesController so it isn't doing two things in one
method
2014-08-25 12:40:51 -07:00
Jeff Atwood
024c503870
mobile login tweaks
2014-08-25 12:38:27 -07:00
Robin Ward
ed125975a1
SECURITY: Prefix session key and validate token format.
2014-08-25 15:31:49 -04:00
Jeff Atwood
3a010c34cc
smallenate anon drop-down topic counts
2014-08-25 12:14:47 -07:00
Robin Ward
0fba445bc1
FIX: Broken build
2014-08-25 13:35:40 -04:00
Robin Ward
f10f9585ae
Better Support for whitelisting caja tags
2014-08-25 13:11:20 -04:00
Régis Hanol
7aaf718cf3
update bbcode dialect and fix vBulletin importer
2014-08-25 10:48:29 +02:00
Jeff Atwood
bd66c67398
whoops, used font awesome 3.2 styles :(
2014-08-24 22:20:59 -07:00
Jeff Atwood
01853fb9d3
replace trophy with shield to indicate admin
2014-08-24 22:05:11 -07:00
Sam
56a0a40175
Merge pull request #2677 from keskuskentta/fi_locale
...
Add Finnish
2014-08-25 08:44:00 +10:00
Sam
643d0dfc13
FIX: use CDN when expanding avatar templates
2014-08-25 08:18:41 +10:00
Anton Andriyevskyy
c42a5551a1
Update RU pluralization to use 3 keys: one, few, other (as by Transifex)
2014-08-23 15:28:14 +03:00
Sam
af71307363
Add 10px margin for buttons in mobile
2014-08-23 10:41:48 +10:00
Sam
e0a74e336a
Add SSO diagnostics
2014-08-23 10:34:48 +10:00
Sam
f493eb5d12
FEATURE: allow version emails to be disabled globally
2014-08-23 10:02:32 +10:00
Jeff Atwood
ae9fcf17ef
make period chooser (/top h2) unselectable on touch
2014-08-22 17:01:12 -07:00
Robin Ward
db376d16d3
FIX: Topic entrance widget wasn't disappearing
2014-08-22 18:45:48 -04:00
Neil Lalonde
bbb358b356
Add likes given and likes received requirement for being TL3. Configure with site settings leader_requires_likes_given and leader_requires_likes_received.
2014-08-22 17:33:39 -04:00
Neil Lalonde
00c28f2391
Show total likes given. Put likes given/received and flags given/received together.
2014-08-22 15:23:19 -04:00
Jeff Atwood
79f7a922ef
add <hr> between sections of digest email
2014-08-22 12:15:02 -07:00
Robin Ward
2ae46b4742
REMOVE: Auto quoting confused more people than it helped.
2014-08-22 14:51:31 -04:00
Neil Lalonde
dafc63e3a0
Show how many likes users received in the last 100 days on their admin profile page
2014-08-22 14:37:07 -04:00