Joffrey JAFFEUX
93a370863f
FIX: more efficient and resilient widget-dropdown body ( #10458 )
2020-08-18 13:39:08 +02:00
Guo Xiang Tan
7e414da0d9
DEV: Fix lint.
2020-08-18 16:59:57 +08:00
Guo Xiang Tan
2161abfabd
DEV: Move data migration of `PostSearchData#private_message` into post_migration.
...
Follow-up to 92b7fe4c62
2020-08-18 16:46:14 +08:00
Vinoth Kannan
562180dd9a
FEATURE: add option to skip new user tips in first notification. ( #10462 )
2020-08-18 13:43:40 +05:30
Sam Saffron
2a7490149c
DEV: don't fail if in uploads:fix_missing_s3 when fix fails
...
Previously a single error on a file like invalid extension could fail the
entire rake task
2020-08-18 17:55:49 +10:00
Guo Xiang Tan
92b7fe4c62
PERF: Add partial index for non-pm search.
2020-08-18 15:55:08 +08:00
David Taylor
33c21c5921
DEV: Skip readonly tables when remapping content ( #10461 )
2020-08-18 08:53:12 +01:00
Sam Saffron
24fe08230f
FEATURE: ensure posts are rebaked when missing is fixed
...
This ensures any corrupt optimized images are removed and re-created
2020-08-18 15:37:24 +10:00
Martin Brennan
bb74ccf288
FIX: Add bookmark-list component ( #10451 )
...
Moving the bookmark list into its own component to solve click binding issues for external links, because controllers are not the place for DOM manipulation!
2020-08-18 12:15:00 +10:00
Blake Erickson
ba9fbb3443
FIX: Composer upload icon regression because of HEIC
...
Now that HEIC conversion is enabled by default we need to update a few
file extension checks to include `heic` and heif` formats.
https://meta.discourse.org/t/-/144326/23?u=blake
bug reported here:
https://meta.discourse.org/t/-/161197?u=blake
2020-08-17 19:39:26 -06:00
Sam Saffron
38e7b1a049
FIX: when destroying uploads clear card and profile background
...
There is an fk to user_profile that can make destroying uploads fail
if they happen to be set as user profile.
This ensures we clear this information when destroying uploads.
There are more relationships, but this makes some more progress.
2020-08-18 10:55:16 +10:00
David Taylor
1671cd924d
DEV: Bump onebox to 2.0.2
2020-08-18 01:19:52 +01:00
David Taylor
645b65adfa
FIX: Add playsinline to twitter GIFs
2020-08-18 00:26:51 +01:00
David Taylor
eb981b8fbb
FEATURE: Autoplay oneboxed twitter GIF media
2020-08-17 23:56:41 +01:00
David Taylor
5f7839f0a4
FIX: Allow safari to load and autoplay videos in posts
...
This improves the reloading workaround in a few ways:
- Multiple videos in posts are now reloaded. Previously only the first was reloaded.
- An empty `poster` string is treated the same as a missing attribute
- If the video is set to autoplay, it will be reloaded (and therefore autoplayed correctly)
2020-08-17 23:48:36 +01:00
Robin Ward
e2e51ee348
FIX: Refactor broke wizard
2020-08-17 16:34:12 -04:00
Penar Musaraj
2567bb4a67
DEV: Facilitate replacing category lock icon in components
2020-08-17 16:09:17 -04:00
Robin Ward
1a2156a0c2
REFACTOR: Remove `Discourse.BaseUrl` global
2020-08-17 16:08:40 -04:00
Robin Ward
19d057d261
REFACTOR: We can hardcode `#ember-testing` here to avoid a global
2020-08-17 15:56:17 -04:00
David Taylor
a895e4a15b
FIX: Skip rendering twitter video if matching format not found
...
Followup to d5a4318a
2020-08-17 20:53:14 +01:00
Robin Ward
441ac21053
FIX: Broken when iconList missing
2020-08-17 15:49:32 -04:00
Neil Lalonde
530058918e
DEV: Support env var for prometheus port in cache_critical_dns
2020-08-17 15:48:14 -04:00
Robin Ward
5b2c306bb8
REFACTOR: Remove `Discourse.HighlightJSPath` from globals
...
Instead we use the session, and pass that along where necessary.
2020-08-17 15:45:44 -04:00
Penar Musaraj
3745f2bb86
FEATURE: Dark mode alternative logos ( #10441 )
2020-08-17 15:43:20 -04:00
David Taylor
d5a4318ac1
FIX: Replace iframe with <video> for twitter videos
...
This avoids the samesite cookie related error on chrome. It also adds support for twitter 'GIF' content, and allows videos to resize smoothly for narrow devices.
2020-08-17 20:37:36 +01:00
Robin Ward
386a9d26ec
REFACTOR: Remove `Discourse.SvgIconList` and `Discourse.SvgSpritePath`
...
We use the session instead. This patch also removes some jQuery usage in
favor of regular HTML apis
2020-08-17 15:28:22 -04:00
jahan-ggn
65649eaef0
User card settings ( #10302 )
...
* settings implemented
* prettier
* settings updated
* rubocop
* prettier
* Revert "rubocop"
This reverts commit 7805145a7d
.
* Revert "prettier"
This reverts commit 2c53f4fa12
.
* settings updated and changed
* rubocop
* changes applied
* final changes done
* Server side feature added
* spec changed
* changed user_updater and profile file
* Fix user card specs
* web hook serializer solved
* site-setting changed
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
2020-08-17 12:37:45 -04:00
Mark VanLandingham
f2588e1c85
FIX: Clicking on category autocomplete row ( #10457 )
2020-08-17 11:02:00 -05:00
Joffrey JAFFEUX
6d0eb7178d
FIX: prevents errors on /tags when a tag `constructor` exists ( #10449 )
...
This is due to js objects having a constructor property:
```
const obj = {};
obj['constructor'] // return [native code] and not undefined
```
2020-08-17 17:40:34 +02:00
dependabot-preview[bot]
ef9af004f7
Merge pull request #10454 from discourse/dependabot/bundler/rubocop-rspec-1.43.1
...
Build(deps): Bump rubocop-rspec from 1.42.0 to 1.43.1
2020-08-17 11:34:15 -04:00
Robin Ward
2aae0f0d8b
FIX: This leaves an empty example group in TRAVIS mode
...
Instead we should remove the entire context.
2020-08-17 11:33:40 -04:00
dependabot-preview[bot]
a7d9334a93
Build(deps-dev): Bump simplecov from 0.18.5 to 0.19.0
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.18.5 to 0.19.0.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.18.5...v0.19.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-17 11:29:27 -04:00
David Taylor
0a5376084d
FIX: Ensure auto close notice is posted with system locale
...
Previously it was created with the locale of the user who created the final post in the topic
2020-08-17 15:40:47 +01:00
Robert
c164e9bbe0
DEV: Add computed property to Create Account modal ( #10455 )
...
Carry over the regime used in the Login modal to Create Account to
facilitate overriding of the classes set for the d-modal Component
using a new Computed Property having the same naming convention.
2020-08-17 12:31:41 +01:00
Guo Xiang Tan
872ef82f4d
Revert "PERF: Prefer joins over subquery for `User#private_posts_for_user`."
...
This reverts commit 05b43e5ae4
.
2020-08-17 14:58:47 +08:00
Guo Xiang Tan
05b43e5ae4
PERF: Prefer joins over subquery for `User#private_posts_for_user`.
...
The subquery here prevents the planner from optimizing the query. As
such, we prefer joining against the requried tables instead.
2020-08-17 14:47:48 +08:00
Guo Xiang Tan
248bebb8cd
PERF: Remove extra subquery in search.
...
I also noticed that removing the subquery helps the planner to plan
better.
2020-08-17 13:52:12 +08:00
Kris
630ec7b49c
Enable hamburger menu scrolling on mobile, follow-up to 1972364
2020-08-15 20:31:22 -04:00
Robin Ward
58ee947b35
FIX: Mobile group add dropdown was broken
...
It looks like we removed the bulk add modal but didn't update the mobile
template.
2020-08-14 21:03:41 -04:00
Robin Ward
51a6e96b7f
FIX: defer topic was broken
2020-08-14 17:25:37 -04:00
Robin Ward
afa9a61080
REFACTOR: These `Discourse` constants do not seem required in vendor
2020-08-14 13:42:15 -04:00
Robin Ward
41fd7a8b72
REFACTOR: Add `themeSettings` to the `helperContext` to avoid a global
2020-08-14 13:34:21 -04:00
David Taylor
8ac85f54fb
DEV: Remove blob: workers from CSP ( #10440 )
...
Ace editor is reconfigured to load workers directly from their JS URL. Workers must be on the same origin as the site, so they will not use the CDN.
2020-08-14 18:15:30 +01:00
Robin Ward
f52927cd33
REFACTOR: Migrate `screenTrack` to a service
2020-08-14 13:14:17 -04:00
Robin Ward
86aa5d5e48
FIX: `application` controller is not used by the card
2020-08-14 12:49:53 -04:00
Robin Ward
99764d8108
REFACTOR: Don't use container in Scrolling mixin
2020-08-14 12:49:53 -04:00
Robin Ward
37c6fef535
REFACTOR: Remove dead code (property was typo'd, no longer used)
2020-08-14 12:49:53 -04:00
Robin Ward
01e213c930
REFACTOR: Clean up router usage and private APIs
2020-08-14 12:49:53 -04:00
Robin Ward
6a9bde3bf4
REFACTOR: Remove `router:main` and `getOwner`
2020-08-14 12:49:53 -04:00
Robin Ward
cf466f7b84
REFACTOR: Simplify `willTransition`
2020-08-14 12:49:53 -04:00