Dan Johnson
9f6b7889a8
views: convert 'ip' (bigint) -> 'ip_address' (inet)
...
This fixes all known issues when connecting to discourse over IPv6.
This table has no primary key, so the migration is done with update_all,
for each ip address in the views table. Since this table can potentially
grow quite large, this process might take a long time. I don't know any
way around this, though.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the View model class, which should keep the
migration from failing if that class is modified in the future.
2013-06-25 19:47:25 -04:00
Dan Johnson
2e478d8537
TopicLinkClick: convert 'ip' (bigint) -> 'ip_address' (inet)
...
When accessed over IPv6, the ip address of the user is a 128-bit number,
too big for PostgreSQL's bigint data type. Since PostgresSQL has the
built-in inet type, which handles both IPv4 and IPv6 addresses, we
should use that instead. Where this is done elsewhere in the codebase,
the column is called ip_address, so we should follow that convention as
well.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the TopicLinkClick model class, which should
keep the migration from failing if that class is modified in the future.
2013-06-25 19:41:19 -04:00
Neil Lalonde
b2d300fe0b
Add ability to give users a title. Show them under usernames beside posts. Needs love from a designer.
2013-06-25 18:39:20 -04:00
Neil Lalonde
a86b35c873
Remove the access_password site setting
2013-06-25 15:05:25 -04:00
Robin Ward
9a19c0d9c4
Fix for multiple paragraph emails with text em-dashes in them (--).
2013-06-25 14:06:05 -04:00
Jesse House
2e12eb2b62
refactor list_controller
...
- minor refactoring of actions 'category' and 'category_feed'
- fix defect in 'category' where check was for literal
string 'uncategorized' instead of SiteSetting.uncategorized_name
- major refactoring on defined topic actions
2013-06-25 08:29:00 -07:00
Martin Feckie
674e26e6c3
Updated tests to decrease string repetition
...
Removed an unused variable
Some minor style changes
2013-06-25 22:15:41 +08:00
Sam
7d1e8239e0
Merge pull request #1070 from house9/top-menu
...
adds TopMenuItem model which encapsulates top_menu parsing logic
2013-06-25 02:51:57 -07:00
Régis Hanol
52b8e6014b
forgot to commit the test
2013-06-24 22:56:03 +02:00
Jesse House
06be760257
adds TopMenuItem model which encapsulates top_menu parsing logic
2013-06-24 10:04:18 -07:00
Sam
ea932b74e7
values is a much more consistent name than all_values ... we use {}.values not {}.all_values
...
also fixes random ordering of tests failure in site settings
2013-06-23 15:07:49 +10:00
Sam
22d6f6784c
Merge pull request #1075 from ZogStriP/fix-lightboxing-when-using-s3
...
FIX: lightbox wasn't working when using s3 upload
2013-06-23 22:11:45 -07:00
Sam
7c726bd235
Merge pull request #1079 from ZogStriP/do-not-lightbox-oneboxed-images
...
do not lightbox oneboxed images
2013-06-23 22:07:25 -07:00
Régis Hanol
361062d53e
do not lightbox oneboxed images
2013-06-24 02:10:21 +02:00
Sam
0b94c3c456
fix all sorts of issues with random spec order
...
SiteSetting no longer persisted across tests
2013-06-23 13:35:25 +10:00
Sam
251aca3b00
lets not fail in order random
2013-06-23 13:35:25 +10:00
Régis Hanol
08aa23f0ca
FIX: lightbox wasn't working when using s3 upload
2013-06-22 13:38:42 +02:00
Robin Ward
bb908d5913
Email parsing uses Traditional Markdown Linebreaks by default. Added JS tests for line breaks.
2013-06-21 11:37:26 -04:00
Neil Lalonde
bfdbf373f3
Don't show invisible topics in uncategorized on categories page
2013-06-21 11:36:00 -04:00
Sam
e53aa45f54
I think this is more correct, admins/mods should always be able to invite
2013-06-21 16:35:27 +10:00
Neil Lalonde
f39f44ddbf
Categories page should not show invisible topics
2013-06-20 16:07:53 -04:00
Robin Ward
0e984762d5
Oops, forgot to check in the email fixtures :P
2013-06-20 13:07:42 -04:00
Robin Ward
0d10b5c9c4
More email receiving logic
2013-06-20 12:38:37 -04:00
Robin Ward
9f3d5b9f1e
Merge pull request #1044 from ZogStriP/clean-orphan-uploaded-files
...
added a rake task to clean orphan uploaded files
2013-06-20 07:53:50 -07:00
Robin Ward
8e6a903f9b
Merge pull request #1046 from house9/admin-user-index-2
...
extract Admin::UsersController#index to its own query class
2013-06-20 07:52:22 -07:00
Sam
70683c1f09
Merge pull request #1034 from chrishunt/rebake-oneboxes
...
Optionally rebake oneboxes with posts:rebake task
2013-06-20 01:18:57 -07:00
Sam
08df4c41cc
Merge branch 'master' of github.com:discourse/discourse
2013-06-20 17:42:29 +10:00
Sam
4a8a663a67
flagging workflow changes per http://meta.discourse.org/t/we-need-an-archive-flag-notification-button/7450
2013-06-20 17:42:15 +10:00
Robin Ward
8c4aac7f94
Migrate all jasmine specs to Qunit. Removed Jasmine.
2013-06-19 18:18:35 -04:00
Jesse House
e0ff74ead0
extract Admin::UsersController#index to its own query class
...
- move query to its own class
- use postgres ILIKE case insensitive
- removed duplicated list of trust levels
2013-06-19 13:48:45 -07:00
Neil Lalonde
e263bb3c0a
Anons should be able to see post history
2013-06-19 16:43:16 -04:00
Régis Hanol
4a17d6dca6
added a rake task to clean orphan uploaded files
2013-06-19 21:51:41 +02:00
Robin Ward
5ef6714d48
New site setting: `minimum_topics_similar`, allows you to specify a minimum amount
...
of topics that need to be in the database before it will suggest similar topics as
a user creates a post.
2013-06-19 13:14:24 -04:00
Robin Ward
82d1465d18
Ugly Hack: Remove improperly parsed headers from Mail::Message
2013-06-19 12:14:01 -04:00
Sam
6491bda4ab
fix the positioning for replies
...
fix stubs
2013-06-19 18:23:01 +10:00
Chris Hunt
ef76e18215
Optionally invalidate onebox in PostAnalyzer#cook
2013-06-19 00:19:42 -07:00
Sam
799b402778
fix horribly broken invite code, could lead to inviting the wrong person to a conversation
2013-06-19 10:31:19 +10:00
Robin Ward
d5191adfc9
Remove useless jasmine spec
2013-06-18 18:08:37 -04:00
Robin Ward
62e21b8175
Markdown moved to Qunit
2013-06-18 18:05:08 -04:00
Robin Ward
f0ebca51cc
Moved Formatter, KeyValueStore and Onebox jasmine tests to QUnit.
2013-06-18 17:23:00 -04:00
Robin Ward
8af9952b25
Change all headers to X-Discourse-* instead of Discourse-*
2013-06-18 15:54:02 -04:00
Robin Ward
60fce196c7
More Qunit tests including a CLI runner
2013-06-18 13:44:20 -04:00
Neil Lalonde
eea00afb80
tos and privacy urls redirect based on site settings
2013-06-18 10:52:04 -04:00
Sam
6989851cd4
Merge pull request #1038 from ZogStriP/keep-uploads-reverse-index-up-to-date
...
Keep uploads reverse index up to date
2013-06-18 00:43:31 -07:00
Sam
80c42753e1
fix up find as you type for the invite into PM function
...
allow mods to remove users from a PM
2013-06-18 17:17:01 +10:00
Robin Ward
8acdc18bc8
First stab at polling support for POP3S / reply by email
2013-06-17 16:49:02 -04:00
Régis Hanol
7bdc616040
keep uploads reverse index up to date
2013-06-17 22:46:48 +02:00
Régis Hanol
ae3543872c
renamed the `sha` column to the proper `sha1`
2013-06-17 22:16:14 +02:00
Neil Lalonde
281a08a99f
Allow people to capitalize a word when ninja-editing a post
2013-06-17 15:57:13 -04:00
Robin Ward
3c7eb3a4e8
FIX: null dates crashed the client app. `last_posted_at` was not updating properly on split topic.
2013-06-17 13:02:50 -04:00
Neil Lalonde
876a570e3a
Fix to prevent check for all upper case for non-ascii messages
2013-06-17 12:22:50 -04:00
Robin Ward
797b99db7c
Moved a bunch of tests to QUnit. Added basic `Discourse.Site` support to test suite.
2013-06-17 11:38:30 -04:00
Sam
dd5cd1df4f
Merge pull request #1037 from ZogStriP/imagineering
...
Imagineering
2013-06-16 22:01:10 -07:00
Sam
0052e78bfe
render error when people attempt to save an invalid group name
...
hide controls when we showing an automatic group
2013-06-17 13:43:06 +10:00
Régis Hanol
af45b5a11e
proper column naming
...
silly schemaless database habits are hard to kill
2013-06-17 04:02:17 +02:00
Régis Hanol
510bac4b27
refactored a bit & tested thumbnails creation
2013-06-17 02:49:34 +02:00
Régis Hanol
5de03814fb
created `optimized_image` model
2013-06-17 02:49:34 +02:00
Régis Hanol
2c3f757951
moved `has_been_uploaded` and `uploaded_regex` to the `Upload` model
2013-06-17 02:49:34 +02:00
Régis Hanol
c11f4456ae
cleaned up CookedPostProcessor and improved specs
2013-06-17 02:49:34 +02:00
Régis Hanol
8a98310cf9
make sure we only do the work once
2013-06-17 02:49:34 +02:00
Régis Hanol
6ea91b4416
remove useless upload topic direct association
2013-06-17 02:49:33 +02:00
Sam
e603c85fa0
Merge pull request #1032 from Krugloff/patch-1
...
It maybe worth load pluralizations rules before compile?
2013-06-16 16:58:16 -07:00
Sam
4650ce3556
Merge pull request #1026 from chrishunt/link-twitter-handles
...
Link Twitter handles and hashtags in Twitter onebox
2013-06-16 16:50:57 -07:00
Sam
b545a49d32
Merge pull request #1025 from ZogStriP/reverse-index-take-2
...
Reverse index take 2
2013-06-16 16:49:57 -07:00
Krugloff
c964c5c0d5
Add test for load plurals before precompile
2013-06-16 02:38:28 +04:00
Neil Lalonde
f62c421c91
Render category descriptions differently on the categories page
2013-06-14 11:18:44 -04:00
Chris Hunt
4491b1f06f
Link hashtags in Twitter onebox
2013-06-13 21:09:37 -07:00
Chris Hunt
b84ee29c43
Link Twitter handles in Twitter onebox
2013-06-13 21:00:47 -07:00
Régis Hanol
037f62928b
add proper post_uploads reverse index
2013-06-13 23:44:24 +02:00
Robin Ward
bd1b4d3130
Include a custom reply address when reply by email is enabled.
2013-06-13 17:00:00 -04:00
Neil Lalonde
4db8204a15
Remove topic links when a post is deleted
2013-06-13 13:41:54 -04:00
Robin Ward
49c09898e2
The EmailBuilder now creates the Reply by Email Key if necessary.
2013-06-13 12:40:06 -04:00
Robin Ward
cf9b6beb13
Add specs for all user notifications, including whether they support
...
reply by email.
2013-06-13 12:40:01 -04:00
Robin Ward
e29f4a3496
Work in Progress: Reply By Email:
...
- Add support classes and settings to enable reply by email
- Split out Email builder to be more OO, add many specs
2013-06-13 12:39:56 -04:00
Robin Ward
66f5a3f6f6
FIX: Emoji sizes in emails should be done by the EmailStyler
2013-06-13 12:15:05 -04:00
Robin Ward
cb40ceb9e8
Merge pull request #1019 from ZogStriP/reverse-index-of-user-uploads
...
added a reverse index of user uploads + rake task
2013-06-13 07:20:55 -07:00
Sam
80f1e9a0d9
Merge pull request #1021 from ZogStriP/less-brittle-specs
...
less brittle specs to os-specific line endings
2013-06-13 02:27:07 -07:00
Régis Hanol
2e2553c18c
less brittle specs to os-specific line endings
2013-06-13 11:09:11 +02:00
Sam
f7de9f17d5
refactor validators
...
add a new setting for min pm body length
use that setting for flags
scale entropy check down for pms
2013-06-13 18:18:43 +10:00
Sam
384d743e7b
refactoring of site settings
2013-06-13 12:41:27 +10:00
Sam
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
Régis Hanol
770c1faeb1
added a reverse index of user uploads + rake task
2013-06-13 01:43:50 +02:00
Neil Lalonde
246148d4ff
Make topics invisible when first post is automatically hidden because of spam flags
2013-06-12 16:02:11 -04:00
Robin Ward
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
Neil Lalonde
28ac110a3c
Add eu-west-1 to s3 regions
2013-06-12 12:02:47 -04:00
Sam
54d8c963d0
fix tests and allow SE onebox to onebox Meta cause I need that for an post I am writing
2013-06-12 12:23:24 +10:00
Sam
c1f6169b48
hidden and deleted state in user stream
2013-06-12 11:14:08 +10:00
Sam
eb91a0c9df
Merge pull request #1012 from ZogStriP/extract-imgur-support-to-a-gem
...
Extract imgur support to a gem
2013-06-11 16:59:53 -07:00
Chris Hunt
a362d62b42
Do not return mail password in EmailController
2013-06-11 16:00:13 -07:00
Régis Hanol
8a2d635e62
removed imgur support
2013-06-11 21:51:41 +02:00
Neil Lalonde
82b5f57e40
Make it possible to set a site setting to empty string
2013-06-11 14:31:38 -04:00
Neil Lalonde
811a0df68b
Make s3 region site setting a drop down
2013-06-11 14:24:04 -04:00
Neil Lalonde
5ff7e570ac
Add support for enum site settings that render as a dropdown; use a dropdown for default_locale
2013-06-11 11:40:14 -04:00
Sam
c2cfbce9ce
automatically updating times for posts on topic
...
moved moment.js into localization file (we need to localize it)
added helpers for date formatting use, moment().shortDate() moment().longDate() moment().shortDateNoYear()
2013-06-11 17:25:50 +10:00
Sam
fa8a84f20c
removed sugar.js, port functionality to moment and underscore.js
...
bring in latest ace from local so we don't mess up with https
2013-06-11 15:27:26 +10:00
Robin Ward
ab5507ac06
Merge pull request #1002 from chrishunt/add-stack-exchange-onebox
...
Add Stack Exchange onebox
2013-06-10 12:38:03 -07:00
Robin Ward
93bbe190c0
Moved Email components into a module
2013-06-10 15:34:10 -04:00
Neil Lalonde
9b1d0baf45
Send a message to moderators when a newuser_spam_host_threshold is exceeded. Send it no more than once per day per user.
2013-06-10 13:17:32 -04:00
Chris Hunt
1fb0b424ed
Add Stack Exchange onebox
2013-06-10 09:27:13 -07:00
Robin Ward
68d849419b
FIX: Don't email '(user deleted)' posts. Seriously.
2013-06-10 12:02:04 -04:00
Robin Ward
ad6705cca7
Update Ember to latest master (RC5)
2013-06-10 10:14:42 -04:00
Jeff Atwood
b4a4774165
extend consumer email warning to yahoo & outlook
2013-06-10 00:08:06 -07:00
Chris Hunt
15efecd536
Remove html rendering test for commit onebox
...
This is a very brittle test. We want to be able to change our markup
without breaking tests.
2013-06-09 21:32:13 -07:00
Sam
cbec9efc16
Merge branch 'master' of github.com:discourse/discourse
2013-06-10 09:48:51 +10:00
Chris Hunt
d741798d9c
Add onebox for GitHub pull requests
2013-06-08 11:01:06 -07:00
Sam
9aa2cc2262
extra spec
2013-06-08 23:56:40 +10:00
Sam
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
Robin Ward
b2a6755a48
Merge pull request #984 from Supermathie/moreentropy
...
More entropy for foreign titles
2013-06-07 14:23:26 -07:00
Michael Brown
bb77d2c38b
More entropy for foreign titles
...
* Treat strings with non-ASCII characters as having more entropy
2013-06-07 14:47:07 -04:00
Neil Lalonde
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
Robin Ward
1b5ec42173
FIX: Regression where a topic rollback would not properly report errors to the client.
2013-06-07 12:36:37 -04:00
Robin Ward
3ae72259a6
Merge pull request #979 from iancmyers/strong-parameters
...
All parameters for #create in PostsController pass through strong_parameters
2013-06-07 09:17:29 -07:00
Ian Christian Myers
b61e10f9ad
All parameters for #create in PostsController pass through strong_parameters.
...
We are now explicitly whitelisting all parameters for Post creation. A nice side-effect is that it cleans up the #create action in PostsController. We can now trust that all parameters entering PostCreator are of a safe scalar type.
2013-06-07 01:29:25 -07:00
Sam
5fa20ce357
more progress towards full migration to moment.js
2013-06-07 18:27:42 +10:00
Chris Hunt
f6ce985121
Send activation email after user approved
2013-06-06 18:37:25 -07:00
Chris Hunt
93fc0e74bc
Test correct login behavior when pending approval
2013-06-06 18:36:16 -07:00
Chris Hunt
41b0692543
Show 'waiting approval' and don't send email
...
When 'must approve users' in enabled, we don't want to send an
activation email to users after they sign up. Instead, we will show them
'waiting approval' and not take an action until their account is
approved by an admin.
2013-06-06 18:36:16 -07:00
Chris Hunt
e7b38fb188
Move duplicated request to helper method
2013-06-06 18:36:16 -07:00
Chris Hunt
4a182f8bba
Fix spec doc; sends welcome email for active users
2013-06-06 18:36:16 -07:00
Sam
a5a229598d
missed a spot
2013-06-07 09:17:34 +10:00
Neil Lalonde
564d242832
Notify moderators when someone is automatically blocked because of spam flags
2013-06-06 18:49:19 -04:00
Sam
11afa0c11b
work in progress migrate to moment
2013-06-07 08:49:22 +10:00
Neil Lalonde
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
Neil Lalonde
62041da7e0
Handle /t/only-the-slug urls by trying to find the topic by slug (second try)
2013-06-06 14:41:37 -04:00
Robin Ward
b062b4a98e
Unapproved users should not receive digest emails. Fixes #974
2013-06-06 11:45:18 -04:00
Robin Ward
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
Juan de Dios Herrero
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
Ian Christian Myers
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
Robin Ward
a3d62fdf69
Temporarily roll back ember rc5. We identified some things we need to fix.
2013-06-06 01:25:43 -04:00
Sam
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
Robin Ward
6384518599
Allow images in the daily digest for top scoring posts
2013-06-05 18:55:27 -04:00
Robin Ward
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
Neil Lalonde
f030d9b420
Make default_logo_check more smarter
2013-06-05 16:59:19 -04:00
Neil Lalonde
4e8ff74b99
Show dashboard warning when favicon and/or logo urls contain the same filename as the shipped defaults
2013-06-05 16:43:39 -04:00
Neil Lalonde
b55182b983
Use PostDestroyer when deleting all of a user's posts; deleting a post removes its flags and resets its flag counts
2013-06-05 16:05:13 -04:00
Robin Ward
dfba2b6e0a
FIX: Strip links from google indexed bios when the users are new.
2013-06-05 15:28:10 -04:00
Robin Ward
729e4080a6
Merge pull request #958 from ZogStriP/fix-have-onebox-ignore-internal-links
...
FIX: Have onebox ignore internal links
2013-06-05 12:09:53 -07:00
Robin Ward
112d57e899
Merge pull request #960 from iancmyers/strong-parameters
...
Began implementing strong_parameters
2013-06-05 12:03:17 -07:00
Régis Hanol
01855b70b4
FIX: Have onebox ignore internal links
2013-06-05 20:53:07 +02:00
Chris Hunt
acf147ef88
Disable OmniAuth account creation if 'invite only'
2013-06-05 11:11:02 -07:00
Chris Hunt
d432798ff8
Silently fail if user tries to sneak in
...
When 'invite only' is enabled, there's no way for a user to create an
account unless they try and sneak in by POSTing to /users/. We will
silently fail if this happens.
2013-06-05 11:08:21 -07:00
Robin Ward
a0bd51862e
Upgrade Ember to RC5. Disabled a deprecation warning that I believe is in error.
2013-06-05 12:07:18 -04:00
Ian Christian Myers
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
Ian Christian Myers
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
Ian Christian Myers
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
Ian Christian Myers
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
Sam
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
Sam
74502172f3
speed up test
2013-06-05 12:48:34 +10:00
Sam
9a57aaaaa9
fix encoding for category excerpt
...
fix missing secure category topics in categories page
2013-06-05 11:22:47 +10:00
Sam
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
Sam
56ee7cdc1f
Merge pull request #956 from ZogStriP/fix-image-upload-to-s3
...
fix image uploads on s3/imgur
2013-06-04 16:34:42 -07:00
Sam
5f85aaee1d
correct message bus regression
...
implement automatically updating dates in list
2013-06-05 09:32:44 +10:00
Chris Hunt
978785720a
Redirect to root after login if no path provided
...
If we do not do this, then people that login from /login will just be
redirected back to the login page. We'd rather have them see the root
path.
2013-06-04 16:10:10 -07:00
Chris Hunt
92a4828f72
Redirect all controllers to login if required
...
We want to skip the filter for sessions controller so that we can login
and we want to skip the filter for static pages because those should be
visible to visitors.
2013-06-04 16:10:10 -07:00
Régis Hanol
e3e55d4dad
fix image uploads on s3/imgur
2013-06-05 00:35:42 +02:00
Neil Lalonde
2465c9c724
Add min_private_message_title_length site setting so private messages can have short titles
2013-06-04 17:59:23 -04:00
Robin Ward
4392a17b54
Strip out links when displaying a new user's bio
2013-06-04 12:06:25 -04:00
Neil Lalonde
c4904aacc0
Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.
2013-06-03 16:37:40 -04:00
Sam
ef976ba891
fix pending tests
2013-06-03 17:07:44 +10:00
Sam
8b69ee26ff
forking in passenger was bust, message bus subscriptions would stop working after fork
2013-06-03 16:50:30 +10:00
Sam
da22c0f359
omit single quotes from slug
2013-06-03 09:08:34 +10:00
Navin
cab3502c15
Replace PostAnalyser module with a class
...
Encapsulate Post#cooked_document as well
Include specs for PostAnalyzer class
2013-06-01 14:59:27 +02:00
Robin Ward
545dbfc07e
New Feature: Staff can choose to "Take Action" when flagging to immediately reach hiding
...
thresholds.
2013-05-31 17:39:32 -04:00
Robin Ward
d23ef1d090
FIX: You could update a topic to have a title that's too short if the TextCleaner
...
removed extra characters. Additionally, updating the title will not return an error
message to the client app if the operation fails (rather than failing silently.)
2013-05-31 15:24:13 -04:00
Robin Ward
9ba25b2b61
Merge pull request #934 from ZogStriP/fix-upload-specs
...
Fix upload specs
2013-05-31 09:56:45 -07:00
Neil Lalonde
e0dae88885
remove specs for redirect_to_show, i'll figure out how to do this properly later
2013-05-31 12:10:07 -04:00
Régis Hanol
bf6b846c0b
Fix upload specs
2013-05-31 17:51:22 +02:00
Sam
d00ba60ad3
file is uploaded but hash is not matching ... why?
2013-05-31 15:04:01 +10:00
Sam
41187a5de1
Merge pull request #931 from ZogStriP/more-file-upload-test-coverage
...
added more file uploads test for better coverage
2013-05-30 21:36:33 -07:00
Sam
037cbfd648
Merge pull request #926 from netzpirat/fix-s3-images
...
Don't append the base url to absolute image urls without protocol.
2013-05-30 21:33:37 -07:00
Sam
e5f8297670
Merge pull request #928 from jd-erreape/master
...
Refactored some class methods to scopes in order to achieve a better 'Rails way'
2013-05-30 21:31:53 -07:00
Sam
d6d3f74405
Merge pull request #901 from xtream/master
...
Refactored AvatarLookup
2013-05-30 21:30:39 -07:00
Régis Hanol
6cc0f8f2d4
added more file uploads test for better coverage
2013-05-31 03:13:37 +02:00
Juan de Dios Herrero
807f763fb0
Merge remote-tracking branch 'upstream/master'
2013-05-30 21:42:26 +02:00
DI2uNk
24e32092e7
Refactored two class methods into scopes (to achieve a better 'rails way')
...
Also added some tests to the methods
2013-05-30 21:21:31 +02:00
Neil Lalonde
b82a5dfd56
Move logic to reject slugs that are just numbers into the slug module
2013-05-30 11:54:02 -04:00
Michael Kessler
d2e45cb8fd
Don't append the base url to absolute image urls without protocol.
2013-05-30 17:17:07 +02:00
Neil Lalonde
7d5c313456
Don't allow category slugs that are numbers
2013-05-30 11:09:09 -04:00
Neil Lalonde
5d444be72b
Support incomplete topic urls like /t/just-a-slug; fix error when using route /t/:topic_id/:post_number
2013-05-30 10:39:15 -04:00
Victor Cruz Dueñas
5d2a6e3994
refactored and tested AvatarLookup
...
less array copying
Avoid N queries
2013-05-30 11:04:05 +02:00
Sam
8874c9ea75
Add message format support that can be used on complex localization strings
...
Add message about new and unread topics at the bottom of topics
move localization helper into lib
2013-05-30 16:49:57 +10:00
Sam
e93b7a3b20
more progress towards live unread and new counts, unread message implemented, still to implement delete messages
2013-05-30 16:49:57 +10:00
Sam
73834370a5
work in progress, live unread and new counts
2013-05-30 16:49:57 +10:00
Robin Ward
8182a9d10c
Merge pull request #918 from chrishunt/chrishunt/quiet-tests-please
...
Clean up test output
2013-05-29 12:17:04 -07:00
Robin Ward
3d0587d8ce
Refactor: move category slug helper to Category model
2013-05-29 14:18:02 -04:00
Neil Lalonde
6abd9ddd2d
Add warning on admin dashboard if production env is configured to send email through gmail
2013-05-29 14:00:35 -04:00
Chris Hunt
e94e9b7621
Set UTF-8 charset for plain text email part
2013-05-29 09:54:36 -07:00
Chris Hunt
46a5066aed
Set SeedFu to quiet mode. No talking please.
2013-05-29 09:36:51 -07:00
Sam
46389754d6
Merge pull request #892 from eriko/cas_support
...
Cas support
2013-05-28 16:13:29 -07:00
Robin Ward
8d47f92c27
Merge pull request #908 from chrishunt/chrishunt/extract-topic-status-update
...
Extract topic status update
2013-05-28 10:00:49 -07:00
Robin Ward
feb966a1cf
Fixed jasmine specs that relied on old Discourse user api.
2013-05-28 12:09:03 -04:00
Chris Hunt
be234a2bc7
Add test to verify autoclose moderator post
2013-05-27 18:02:15 -07:00
Sam
c32399a80b
added test condition that fails with latest AM serializer
2013-05-28 10:42:04 +10:00
Robin Ward
197909246c
Weigh staff likes higher when calculating scores. New site setting: `staff_like_weight`
...
can set the factor (default is 3)
2013-05-27 12:46:08 -04:00
Robin Ward
e1781240a6
Merge branch 'refactoring' of git://github.com/mattvanhorn/discourse
...
Conflicts:
lib/text_sentinel.rb
2013-05-27 10:42:20 -04:00
Robin Ward
a15910ad1e
Merge pull request #899 from chrishunt/chrishunt/extract-topic-posters-summary
...
Extract topic posters summary
2013-05-27 06:30:58 -07:00
Sam
bf16b4f381
Merge pull request #903 from chrishunt/chrishunt/extract-post-move
...
Extract post move
2013-05-26 19:10:50 -07:00
Sam
661ddbb158
introduce strong_parameters
2013-05-27 11:06:09 +10:00
Sam
d84ae80074
Simplify user action make it more idiomatic
2013-05-27 10:22:37 +10:00
Chris Hunt
13c4266c74
Allow Chinese characters in Topic titles
2013-05-26 13:56:42 -07:00
Chris Hunt
1ba18318ac
Add test to verify posts are moved in transaction
2013-05-25 17:44:32 -07:00
Matt Van Horn
d5958f8779
Sliding window rate limiting
...
Switched the algorithm to use a circular buffer
based on a redis list
2013-05-25 12:37:28 -07:00
Chris Hunt
c1841a6c89
Extract Topic#posters_summary
2013-05-24 15:33:45 -07:00
Matt Van Horn
d7817cf314
extract TopicNotifier class from topic
2013-05-24 13:36:33 -07:00
Robin Ward
1313c0f094
FIX: When using a search context, *prefer* the context's results, don't restrict to only them.
2013-05-24 16:17:09 -04:00
Robin Ward
d1fdc66ca4
FIX: For spam detection, don't count total occurances of links of the same host, but
...
post count including that host.
2013-05-24 15:20:58 -04:00
Robin Ward
bd779834e5
Use search context for filtering search results by current category or user
2013-05-24 14:04:26 -04:00
Robin Ward
84bc798afa
Merge pull request #891 from GlitchMr/iPhone-casing
...
Thread title fixer should ignore special cases like iLetter
2013-05-24 07:02:34 -07:00
Sam
9926b0dbc8
staff styling
2013-05-24 13:32:41 +10:00
Sam
ca2dee52db
moved comments to the bottom, they are way less intrusive there
2013-05-24 12:48:32 +10:00
Erik Ordway
1575ce7b10
add cas support with a few tests
2013-05-23 13:40:50 -07:00
Konrad Borowski
8bc4264c98
Thread title fixer should ignore special cases like iLetter
2013-05-23 21:31:08 +02:00
Robin Ward
8e8d9af2bf
Use classes instead of a complicated nested hash for search results
2013-05-23 12:44:47 -04:00
Neil Lalonde
4492d06a9f
Don't send notifications for moderator action posts
2013-05-23 11:42:52 -04:00
Robin Ward
0bd61df34c
Merge pull request #884 from mattvanhorn/refactor_topic
...
Refactor topic
2013-05-23 07:26:22 -07:00
Matt Van Horn
24c25895f0
remove unnecessary title quality tests from topic
2013-05-22 22:56:27 -07:00
Matt Van Horn
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
Sam
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
Robin Ward
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
Robin Ward
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
Matt Van Horn
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
Sam
96f8d79e83
Merge pull request #876 from chrishunt/chrishunt/observe-changes-for-topic-users
...
Trigger UserActionObserver when updating TopicUser
2013-05-21 23:02:27 -07:00
Sam
da6a88634b
improve best filter so it properly excludes all admin messages from count as well
2013-05-22 15:14:47 +10:00
Sam
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
Chris Hunt
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
Chris Hunt
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
Jason Kriss
c22435562d
fix small typo in search_spec
2013-05-21 05:56:04 -03:00
Sam
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
Sam
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
Sam
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
Sam
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
Sam
24c997966e
Merge pull request #861 from sanderdatema/post_creator
...
Set created_at manually through PostCreator
2013-05-19 16:34:45 -07:00
Chris Hunt
fb4e5973db
Fix spelling mistake in spec doc
2013-05-18 13:11:34 -07:00
Chris Hunt
c2a4f16f24
Show posts for last page when page out of range
2013-05-18 13:11:01 -07:00
Sander Datema
286a06bd4e
Set created_at manually through PostCreator
2013-05-18 21:24:29 +02:00
Leonard Garvey
3de632f892
Added a spec for staff? and regular?
2013-05-18 18:07:07 +10:00
Neil Lalonde
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
Robin Ward
a80ec535a3
Support for "Select All / Deselect All" while selecting posts to merge / delete.
2013-05-16 16:50:38 -04:00
Robin Ward
d554a59102
Support for a new site setting: `newuser_spam_host_threshold`. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
Sam
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
Sam
eb71e9de24
opening move, don't get rid of green notification till the pm is read
...
TODO a way to list all unread PMs
2013-05-16 16:37:47 +10:00
Sam
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
Régis Hanol
27dfb7a948
FIX: @username mentions when there are multiple code blocks in a post.
...
Meta: [All of my internal users show as coming from 127.0.0.1!](http://meta.discourse.org/t/all-of-my-internal-users-show-as-coming-from-127-0-0-1/6607 )
This fixes the regular expression used to identify @ inside <code> or <pre> blocks in the `postConversion` hook.
2013-05-16 01:59:07 +02:00
Lee Machin
dadb7eaa23
fix crash caused by incorrect query in scope
...
setting all categories to be secured led to a blank screen on all pages
use stabby lambda for consistency in class
make the test a little more concise
- move the local assignments into let blocks for
reusability
- remove calls to `to_a`, which aren't needed
- use 'be_empty' instead of '[]' to be consistent
with the other matchers in the test
add a test for the `secured` scope with multiple
secured categories
2013-05-15 22:26:52 +01:00
Sam
ef98b60184
disable observers in tests, enable as needed, tests are 20% faster
2013-05-14 11:59:55 +10:00
Robin Ward
fff46cf5aa
Can search by URL or ID
2013-05-13 17:07:58 -04:00
Robin Ward
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
Neil Lalonde
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
Sam
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
Sam
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
Sam
98d9f174ae
fix spec
2013-05-13 11:07:22 +10:00
Sam
30501e943c
fix search
2013-05-13 11:07:21 +10:00
Robin Ward
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
Régis Hanol
297680c28d
FIX: pinned topic excerpt is not properly truncated
2013-05-10 12:28:17 +02:00
Sam
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
Sam
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
Sam
4f328e3e45
+x on files makes no sense unless they really are executable
...
rails in the script dir makes no sense, use binstubs or bundler instead
2013-05-09 17:35:15 +10:00
Sam
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
Sam
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
Sam
7571152d1d
fix issue adding users to groups
2013-05-08 10:32:29 +10:00
Robin Ward
6843ba7ed6
Fix regression: default to JSON type on GET requests.
2013-05-07 17:17:21 -04:00
Neil Lalonde
f9a82f3aa0
Add a spec for category list with empty category
2013-05-07 15:52:45 -04:00
Neil Lalonde
8e24a608b0
Show empty categories on categories page to people people who can edit and delete categories
2013-05-07 15:31:56 -04:00
Sam
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
Neil Lalonde
69be7d0ad1
Change the title Visits to Clicks in referral tables on admin dashboard
2013-05-06 11:56:35 -04:00
Sam
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
Régis Hanol
392b9696f4
prevent duplicate actions on a post
2013-05-04 02:52:45 +02:00
Sam
3eab0be4a8
deleting posts as an admin was bust
2013-05-03 17:56:23 +10:00
Sam
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
Sam
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
Sam
e59ab32210
Merge pull request #800 from goodbrews/imgur-api-v3
...
Update to Imgur API v3
2013-05-01 21:52:00 -07:00
David Celis
6be26f5316
Update to Imgur API v3
...
Version 2 of Imgur's API is deprecated. Their documentation for v2 is no
longer online, and applications can only be registered under version 3.
Version 3 of their API has a slightly different endpoint but, more
importantly, uses a Client ID/Secret pair instead of an API Key.
This PR updates Discourse to use the new version of Imgur's API.
Signed-off-by: David Celis <me@davidcel.is>
2013-05-01 21:39:10 -07:00
Neil Lalonde
3c7afeb233
Fix incoming links dashboard data when topic record can't be found
2013-05-01 19:10:31 -04:00
Neil Lalonde
38ed86d0c5
Add reports for IncomingLinks on admin dashboard
2013-05-01 18:12:02 -04:00
Sam
e4a76812a6
this is a slightly round about way of making our self oneboxes sane
...
shrunk avatar to 60px, added global whitelisting
2013-05-01 16:38:13 +10:00
Sam
08ce46e7ed
:s/POST/REPLY/g
2013-05-01 10:52:31 +10:00
Sam
58dbfa1b91
Merge pull request #796 from ZogStriP/fix-shift-clicks-on-links
...
FIX: shift+click on links
2013-04-30 16:02:24 -07:00
Régis Hanol
ff309cf024
FIX: shift+click on links
...
Default browser's behavior when shift+clicking was messed up.
This adds the shift key modifier to the list of click modifiers in both
`click_track` and `discourse`.
Also updated & refactored a bit the `click_track_spec`.
2013-04-30 15:48:58 +02:00
Sam
acc4f73ba0
very subtle, autospec was not using inotify if guard was already running
2013-04-30 22:54:52 +10:00
Sam
b25a5a20bb
option to strip links from excerpts
2013-04-30 13:25:55 +10:00
Sam Saffron
94a578e4b2
ignore assets
...
fix runner so it works on mac
get rid of some test warnings
2013-04-30 12:43:59 +10:00
Régis Hanol
017ee7c2da
FIX: [security bug] XHR check bypass
2013-04-30 02:34:19 +02:00
Neil Lalonde
eb151d440b
Don't call discourse hub during user destroy if hub integration is disabled
2013-04-29 11:39:05 -04:00
Neil Lalonde
dc07563c0d
Add unstarred_at column to topic_users so we can permanently track when topics are starred
2013-04-29 11:39:05 -04:00
Sam
5cfcdc7ef0
backend for secure categories mostly done (todo pm groups)
2013-04-29 16:33:43 +10:00
Ryan Boland
9bc8faeaf2
added rottentomatoes.com onebox
2013-04-28 16:24:03 -04:00
Jonathan Roes
057b4768e6
strip whitespace when changing e-mail addresses
...
Fixes #778 .
2013-04-27 23:03:06 -04:00
Neil Lalonde
1375954fbc
Add title tags to dashboard stats to show percent change from previous period
2013-04-26 17:14:03 -04:00
Neil Lalonde
c589b4b187
Add a js spec for admin/report model, and find a bug too
2013-04-26 17:14:02 -04:00
Sam
f9e33ec6b8
store ip address and current user with incoming links
...
make links long an readable in share dialog
2013-04-26 16:18:55 +10:00
Sam
a56a926582
seed fu should not run before the suite, just before fork
...
we have no seeds.rb so do nothing there
2013-04-26 16:18:55 +10:00
Sam
eb085beea8
attempt to fix the UTF-8 warn in the log, turns out this runs really deep, when you hit deliver in test it clones the mail not setting charset properly, leaving as is for today but fixing prod at least
2013-04-26 16:18:54 +10:00
Sam
14f33b80e4
lets not let without a block rspec gets very upset
2013-04-26 16:18:54 +10:00
Sam
37867af1bb
track incoming links, amend share link to include user
...
fix pm styling
2013-04-24 18:05:35 +10:00
Régis Hanol
451a818162
do not display clicks count in oneboxes
2013-04-22 20:21:29 +02:00
Sam
cfc62dadff
speed up tests
...
add the ability to find the first notify private message
2013-04-22 17:45:03 +10:00
Sam
8827dd3e42
speed up tests
2013-04-22 13:48:41 +10:00
Sam
2843f1cf4b
collapse some slow tests
2013-04-22 11:06:10 +10:00
Sam
aea988a447
before:
...
Finished in 6.38 seconds
after:
Finished in 1.52 seconds
2013-04-22 11:05:54 +10:00
Jeff Atwood
b64a4100fa
change "visitor" trust level to "new user"
...
I blame me for this mistake.. visitor means other stuff in practice. New
User is correct meaning.
2013-04-17 16:11:24 -07:00
Régis Hanol
e76f629df8
Text Cleaner now removes all periods from the end of the title
2013-04-18 00:19:42 +02:00
Sam
437142424c
speed up tests, fix notification of mentioned users in pms
2013-04-17 17:39:18 +10:00
Neil Lalonde
3b6aeb14c7
Add subtype to topics to classify private messages
2013-04-16 16:56:18 -04:00
Régis Hanol
c2e58b61c9
automatically resizes images
2013-04-15 23:32:26 +02:00
Régis Hanol
b24c1a1ad9
better consistency around email case sensitivity
2013-04-15 02:20:33 +02:00
Neil Lalonde
c6ab9fec9d
Unregister forum membership at Discourse Hub when deleting a user
2013-04-15 14:52:07 -04:00
Sam
f314e7a89c
make source git pull freindly, no need to copy files around when updating
2013-04-15 15:07:40 +10:00
Sam
ea3c6d2e6f
fix jshint
2013-04-15 13:18:26 +10:00
Philipp Weissensteiner
3dcb1905e3
Refactor user controller, create action, mostly.
...
The gist of the commit are a few improvements in the
create action, where:
* long boolean statemenst have been wrapped in smaller more readable
methods.
* the 3rd party user info creation has been extracted (still in controller)
* a small helper method for creating a new user from params (to reduce
visual clutter)
* specs have been added where I came across untested methods/branches
Other changes are more trivial like formatting and whitespace fixes.
Hope this helps. Regards.
2013-04-13 00:53:59 +02:00
Neil Lalonde
651cfba93f
Add ability to destroy a user with 0 posts
2013-04-12 16:53:00 -04:00
Sam
1725bf77a7
fix build
2013-04-12 21:09:41 +10:00
Sam
5551ef9418
ok I should not be coding to a deadline ... grrr
2013-04-12 18:15:19 +10:00
Sam
86b317ea73
oops
2013-04-12 18:14:36 +10:00
Sam
e969eb14e8
added 2 new flag types: notify user and notify moderators
...
fixed up messed up user navigation
refactored
2013-04-12 17:55:45 +10:00
Neil Lalonde
36dc5874e5
Post image_count doesn't count favicons and thumbnails in oneboxes, so visitors can post links that get oneboxed
2013-04-11 12:36:45 -04:00
Sam
5f30ea7463
Merge pull request #684 from ZogStriP/auto-replace-rules-in-titles
...
auto replace rules in titles
2013-04-10 21:12:20 -07:00
Régis Hanol
d120a5d139
FIX: setting min_topic_title_length is ignored
2013-04-10 14:54:10 +02:00
Régis Hanol
c5cf8be864
auto replace rules in titles
2013-04-10 11:00:50 +02:00
Sam
33e3ad1603
clean up onebox application so it uses a single code path
...
use fragments for oneboxes
strip parent <p> if <div> is in it
clean some tests
2013-04-10 17:52:38 +10:00
Michael Scott Shappe
2fb673dd72
Create and use new rspec matcher 'match_html'
...
This introduces match_html, which converts actual and expected HTML strings into "canonical" HTML using Nokogiri with NOBLANKS and COMPACT, and then does a simple equality comparison.
This eliminates whitespace differences introduced by library changes (e.g. the libxml2 2.9.0 change).
pretty_text_spec.rb has been changed to use match_html where appropriate. and all tests pass under libxml2 2.7.6, 2.8.0 or 2.9.0
2013-04-09 22:30:10 -05:00
Sam
9b487953c4
collapse some db tests
...
ensure deleted topics do not show up in user stream
2013-04-10 12:50:00 +10:00
Robin Ward
6198c1a35b
Missed a jshint thing in the spec
2013-04-09 18:04:25 -04:00
Robin Ward
00f9e628e0
Don't apply markdown to content of [quote] -- it messes up spacing.
2013-04-09 17:32:50 -04:00
Neil Lalonde
467d59ec5a
Merge some work: topic counts in category select; fix All count on dashboard
2013-04-08 10:23:29 -04:00
Sam
73c508115a
better consistency check
2013-04-08 13:02:20 +10:00
Sam
9ad320768e
Merge pull request #667 from ZogStriP/dont-track-links-in-oneboxes
...
don't track links in oneboxes
2013-04-07 18:30:24 -07:00
Sam
11ff0ccd03
correct logic for tracking the highest seen post number so its always consistent
2013-04-08 11:12:52 +10:00
Régis Hanol
d080ae4d2d
don't track links in oneboxes
2013-04-08 02:24:12 +02:00
Sam
3e9b782f3e
save it ...
2013-04-08 08:21:54 +10:00
Régis Hanol
1692350336
added some tests for uploads
2013-04-07 17:52:46 +02:00
Robin Ward
a14f62766e
Replace MultisiteI18n hack with SiteContent and admin editing.
2013-04-05 16:48:15 -04:00
Robin Ward
cecdafd4e8
Fixes broken spec
2013-04-05 16:27:25 -04:00
Robin Ward
72b4f41254
Can change TOS content via site content editor
2013-04-05 15:21:55 -04:00
Neil Lalonde
eb212aec9b
Fix dashboard totals for topics, posts, and private messages
2013-04-05 14:09:16 -04:00
Robin Ward
af9b27358c
If an admin or moderator edits a visitor's post, the restrictions should be based
...
on the *editors* access rights, not the original poster.
2013-04-05 13:59:00 -04:00
Sam
a2cca2540e
some minimal site settings diags
...
fix issue where days_visited was totally out of sync
2013-04-05 17:47:54 +11:00
Sam
27776287f4
Merge pull request #654 from ZogStriP/consistent-behavior-regarding-file-uploads
...
consistent behavior regarding file uploads
2013-04-04 21:36:17 -07:00
Sam
4fbf017272
get regular trust level going, self heal inconsistent topic timings
2013-04-05 15:30:28 +11:00
Régis Hanol
82bd92dd46
consistent behavior regarding file uploads
2013-04-05 01:07:31 +02:00
Robin Ward
fa1ba6791b
Work in Progress: Content Editing in Admin Section
2013-04-04 17:26:22 -04:00
Sam
e61a28f3e1
utc vs non utc is a subtle issue, tests were failing for a few hours every day cause of this
2013-04-04 13:29:54 +11:00
Régis Hanol
7105349f1f
FIX: accessing a topic with a 'page' parameter
2013-04-04 00:12:27 +02:00
Neil Lalonde
bb18b6cb9b
Dashboard: split out private messages from topic and post counts; re-enable report_spec because I think I fixed it...
2013-04-03 13:26:09 -04:00
Robin Ward
738789f336
Admins can't lock themselves out of a site by setting approval.
2013-04-03 12:23:28 -04:00
Robin Ward
368011d03b
Merge pull request #628 from ZogStriP/add-uploads-controller-specs
...
add UploadsController specs
2013-04-03 08:06:49 -07:00
Régis Hanol
cf3eb98321
add GitHub commit onebox
2013-04-03 03:36:38 +02:00
Régis Hanol
2b120ef886
add UploadsController specs
2013-04-03 01:17:17 +02:00
Robin Ward
61b5c0340e
Convert all Ajax calls to use Discourse.ajax()
2013-04-01 18:09:23 -04:00
Robin Ward
79c986dd92
Fix issue with duplicate slugs
2013-04-01 12:26:51 -04:00
Robin Ward
f9ea1a448d
Merge pull request #600 from kubabrecka/consistent_topic_count
...
make sure Category.topic_count is consistent with week/year stats
2013-04-01 07:37:07 -07:00
Philipp Weissensteiner
c34f476b31
Improve suggest_username method in user.rb
...
The suggest_username method showed up on codeclimate
so I thought I'd give it some love and make it more readable.
In the process removed trailing whitespaces and had to fix a
terrible spelling error :)
2013-03-31 19:01:11 +02:00
Kuba Brecka
d50b5e1fd8
make sure Category.topic_count is consistent with week/year stats
2013-03-31 13:22:05 +02:00
Neil Lalonde
25073e873f
Fetch the list of problems more frequently on the admin dashboard
2013-03-29 15:48:26 -04:00
Neil Lalonde
436515ec6c
Dashboard checks for facebook, twitter, and github configs
2013-03-29 13:32:40 -04:00
Robin Ward
3d615ada12
Merge pull request #583 from wpp/add_some_user_specs
...
Add a few specs to user model
2013-03-29 10:01:32 -07:00
Robin Ward
a0867bff24
Topic Statuses need to be updated by those who have access. I have self flaggelated
...
as punishment for checking in broken specs before running out earlier.
2013-03-29 02:38:54 -04:00
Philipp Weissensteiner
095cbaa093
Add a few specs to user model
...
I noticed a few assertions of the has_many type were missing.
Also added a couple of specs which were testing in one direction only.
Just tipping my toes in discourse hope this helps a little.
2013-03-29 00:24:35 +01:00
Robin Ward
473a64d39d
Add score, percent_rank to topics. Adds `HotTopic` model and consolidated job to calculate
...
hotness. Note: People on Heroku will have to update their jobs to the new structure
in Heroku.md
2013-03-28 15:39:54 -04:00
Régis Hanol
1668b5eab2
FIX: allows the selection of the default landing tab
2013-03-28 14:01:13 +01:00
Sam
2295290383
added best=N option to get N best comment on a post
2013-03-27 22:53:11 -07:00
Robin Ward
36269cfbaa
Rename 'popular' to 'latest'. First stab at 'Hot' tab.
2013-03-27 16:21:23 -04:00
Robin Ward
af7f6fea28
Can set the `hotness` of a category. For the soon to be implemented "hotness" tab.
2013-03-26 18:08:58 -04:00
Robin Ward
f1e2923a91
Display correct post counts, even with a filter active
2013-03-26 15:06:23 -04:00
Robin Ward
5dc47c2d82
Rename `posts_count` in topic view to `post_counts_by_user` which makes much more sense
2013-03-26 14:06:24 -04:00
Robin Ward
2efd3e61c7
TopicView respects `sort_order` and better specs
2013-03-26 13:27:11 -04:00
Sam
c57ec611e1
basic api support
2013-03-25 18:04:46 -07:00
Robin Ward
90443dac30
Don't email about posts if the user deleted it.
2013-03-25 13:40:48 -04:00
Robin Ward
c372e36cb6
Don't count @mentions as links in a post
2013-03-25 13:12:15 -04:00
Robin Ward
6568b4aaa9
Better error messages when hitting max mentions/images/links
2013-03-25 12:27:09 -04:00
Sam
deb603f41c
Merge pull request #547 from kid0m4n/convert-ruby-1-9-syntax
...
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-24 16:43:17 -07:00
Karan Misra
5dfb04e4b3
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-25 05:07:36 +05:30
Sam
36a069488e
Merge pull request #492 from sbauch/email-whitelist
...
added email whitelist SiteSetting feature to replicate email blacklist S...
2013-03-24 16:35:24 -07:00
Robin Ward
3cb729df21
Merge pull request #546 from ZogStriP/improve-i18n-spec-speed
...
prevent double work in the i18n integrity specs
2013-03-24 08:28:04 -07:00
Régis Hanol
7d43058d20
FIX: Email notification for different user being mentioned
2013-03-24 01:57:00 +01:00
Régis Hanol
c98d58378c
prevent double work in the i18n integrity specs
2013-03-23 15:49:31 +01:00
Kuba Brecka
624649ddc2
adding i18n integrity check for valid YAML and valid content
2013-03-23 08:57:31 +01:00
Neil Lalonde
aa6e87c5c1
Dashboard memory warning
2013-03-22 15:47:35 -04:00
Robin Ward
9c38c13ac5
The "Best Of" mode uses a percentage ranking of posts.
2013-03-22 15:44:39 -04:00
Sam Bauch
77e3434d81
added email whitelist SiteSetting feature to replicate email blacklist. email_validator method now also uses the regex method for both the whitelist and blacklist.
2013-03-22 14:49:42 -04:00
Robin Ward
3d4fb43c73
Re-enable integrity check
2013-03-22 12:49:46 -04:00
Neil Lalonde
6f8d13d47e
Dashboard warning when sidekiq is not running
2013-03-22 11:35:51 -04:00
Régis Hanol
2ab08ef21d
FIX: OpenGraph tags not fully sanitized
2013-03-22 12:32:56 +01:00
Robin Ward
ee5213be5f
Fixes regression with video embeds
2013-03-21 20:53:12 -04:00
Neil Lalonde
8cc7f3c20b
Dashboard warning when clockwork doesn't seem to be running
2013-03-21 16:51:50 -04:00
Robin Ward
babcfe6234
Cache oneboxes in Redis now instead of postgres.
2013-03-21 13:11:54 -04:00
Sam
cd9d99aab8
Merge pull request #505 from ZogStriP/updated-preloadstore-api
...
updated PreloadStore API
2013-03-20 16:30:15 -07:00
Robin Ward
8b6dbfc1c6
Make spec pending for now -- jenkins does not like it
2013-03-20 18:10:52 -04:00
Robin Ward
a2796641b6
Merge pull request #504 from ZogStriP/ensure-locales-are-not-overwritten-take-2
...
ensure locales are not overwritten
2013-03-20 14:42:18 -07:00
Neil Lalonde
d28d81a590
Dashboard warning when GC params are default
2013-03-20 16:16:23 -04:00
Neil Lalonde
c8508d3f26
Dashboard warning when host_names is localhost
2013-03-20 15:38:28 -04:00
Neil Lalonde
c3c25b894a
Cache dashboard data in the controller, not the report model
2013-03-20 13:54:32 -04:00
Neil Lalonde
1e4dd3ea0c
Start detecting install problems and report them on the admin dashboard. This commit adds check for Rails.env
2013-03-20 12:00:52 -04:00
Régis Hanol
f1015fd73a
updated PreloadStore API
...
so that it is more clear that we are deleting preloaded data once read
2013-03-20 16:26:46 +01:00
Régis Hanol
6dab9927c6
ensure locales are not overwritten
2013-03-20 10:51:28 +01:00
Sam
bfeb75a60f
Revert "ensure locales are not overwritten"
...
breaking now
2013-03-19 21:23:03 -07:00
Sam
3f64a54898
SO AWESOME!!!!!!!!!!!!!!!!!!!!!!!!
2013-03-19 21:06:11 -07:00
Sam
62c60540be
pull moderator into own column, rename trust levels
2013-03-19 21:06:11 -07:00
Régis Hanol
e61ca1f67f
ensure locales are not overwritten
2013-03-20 03:07:45 +01:00
Robin Ward
49c66037b1
Moved deleting tests to post_destroyer_spec
2013-03-19 14:15:08 -04:00
Robin Ward
59fc3bfac4
PostDestroyer to replace callbacks for destroying
2013-03-18 17:55:11 -04:00
Robin Ward
c1e40f5d19
Convert Post type constants to Enum
2013-03-18 17:55:05 -04:00
Robin Ward
897d48b145
Moved more `Post` callbacks into service classes
2013-03-18 17:54:55 -04:00
Robin Ward
d5e4243f02
Move draft sequence incrementing out of `after_save`
2013-03-18 17:54:50 -04:00
Robin Ward
5aec5261a7
Converted flag threshold constants to enums
2013-03-18 17:54:43 -04:00
Robin Ward
aea848f164
Move MessageBus observer into PostCreator
2013-03-18 17:54:39 -04:00
Robin Ward
b6224b014c
Move a bunch of callbacks into PostCreator
2013-03-18 13:56:26 -04:00
Neil Lalonde
50b04b2209
Add email counts to admin dashboard
2013-03-18 10:08:09 -04:00
Neil Lalonde
6a99d12784
Add likes to admin dashboard
2013-03-18 10:08:08 -04:00
Neil Lalonde
0e63de59b5
Comment out report_spec.rb for now because it fails sometimes
2013-03-16 19:42:23 -04:00
Sandy Vanderbleek
204dcc43a4
Use Diffy as DiffEngine implementation
2013-03-15 17:31:51 -07:00
Neil Lalonde
d9cdde9aa7
Add user counts for each trust level to admin dashboard
2013-03-15 18:09:02 -04:00
Neil Lalonde
8983df9856
Show current user count for now, not at different points in time
2013-03-15 18:09:01 -04:00
Robin Ward
1a60301a17
Merge branch 'fixes-topic-title-length-too-short' of git://github.com/ZogStriP/discourse
...
Conflicts:
app/assets/javascripts/discourse/controllers/composer_controller.js
app/assets/javascripts/discourse/views/composer_view.js
config/locales/client.en.yml
2013-03-15 16:49:17 -04:00
Robin Ward
76d8df6ac6
Merge pull request #462 from kubabrecka/colorpicker3
...
implement color picking from predefined set for category badges + option to change foreground color
2013-03-15 13:43:59 -07:00
Robin Ward
ad082cea70
Big commit:
...
- Support for a popup that shows similar topics
- Cleaned up a lot of Javascript
- Cleaned up use of Promises
2013-03-15 14:35:33 -04:00
Neil Lalonde
6c4d9ecfdc
Use one request to fetch dashboard report data and check version
2013-03-14 18:26:26 -04:00
Kuba Brecka
8784c55188
implement color picking from predefined set for category badges + option to change foreground color
2013-03-14 14:16:57 +01:00
Robin Ward
ea20993bed
FIX: Don't create a new version when a post is recovered. Also display username instead of full name for consistency.
2013-03-13 12:35:55 -04:00
Sam
fcc6aac008
hacked dates so jeff sees no more 1mons everywhere.
2013-03-13 00:05:21 -07:00
Régis Hanol
439ac95b73
the composer will now count only significant whitespaces
2013-03-12 23:54:29 +01:00
Neil Lalonde
40c27ff3cf
Add flag counts to admin dashboard
2013-03-12 14:40:59 -04:00
Neil Lalonde
4eda422cdf
Add total users report; restructure dashboard reports js
2013-03-12 14:40:59 -04:00
Robin Ward
1103dde5cd
Fix: When you split topics, featured users and like counts were incorrect.
2013-03-12 12:33:42 -04:00
Neil Lalonde
f1908fd8e8
Fix report_spec so it's not so fussy and breaks sometimes
2013-03-11 10:40:13 -04:00
Regis Hanol
2039c0f704
fix the specs errors due to a change to the min topic title's length
2013-03-11 14:51:24 +01:00
Sam
621f946193
fuff with test so it passes
2013-03-10 19:58:42 -07:00
Neil Lalonde
8927432a93
Add stats to the admin dashboard
2013-03-09 15:34:27 -05:00
Robin Ward
97ba6f32c7
Fixes broken jasmine test - PreloadStore now returns null
2013-03-08 15:10:57 -05:00
Robin Ward
d1d4530efd
User Profile enhancements:
...
- Added PreloadStore support to avoid duplicate requests
- preliminary SEO
- Support for opengraph/twitter cards
2013-03-08 15:04:37 -05:00
Robin Ward
b8fd734d0e
Merge branch 'refactor-category' of git://github.com/goshakkk/discourse
...
Conflicts:
app/models/category.rb
2013-03-08 10:49:25 -05:00
Robin Ward
fb573b917f
Merge pull request #390 from ZogStriP/min-search-term-length-site-setting
...
added the min-search-term-length site setting
2013-03-08 06:58:45 -08:00
Robin Ward
d848a9fedc
Add opengraph and twitter card support to topics
2013-03-07 17:46:43 -05:00
Neil Lalonde
2ebe0336ae
On signup, handle duplicate key errors on email and username better
2013-03-07 14:56:55 -05:00
Robin Ward
052887c296
Category Topics are no longer invisible, they are pinned.
2013-03-07 12:46:23 -05:00
Robin Ward
5349e1b163
Merge pull request #387 from ZogStriP/g10n-wikipedia-oneboxer
...
globalized wikipedia onebox
2013-03-07 09:23:19 -08:00
Robin Ward
f8d8272406
Cleaned up TopicUserSpec, introduces clearing of pinned topics
2013-03-07 12:19:25 -05:00
Regis Hanol
5703d6c730
added the min-search-term-length site setting
2013-03-07 16:52:01 +01:00
Régis Hanol
621995f35a
globalized wikipedia onebox
2013-03-07 03:30:40 +01:00
Robin Ward
c123e40638
Merge pull request #373 from alxndr/master
...
Raise 404 from Admin::UsersController#show if no user found
2013-03-06 09:17:47 -08:00
Robin Ward
30aae8e793
Topic was not sanitizing <b> and <img> tags from titles
2013-03-06 11:36:42 -05:00
Neil Lalonde
83f89b5c55
Fix check if you're up to date in javascript
2013-03-06 10:34:29 -05:00
Sam Saffron
8f56a09e82
PBKDF2 gem is trouble, removing and hand coding for now
2013-03-06 23:12:16 +11:00
Alexander
c4f1cb0d7b
Raise 404 from Admin::UsersController#show if no user found
...
[Fixes #353 ]
2013-03-05 14:02:23 -08:00
Robin Ward
86af49e663
More Markdown refactoring - fixed bug with Pagedown not showing on user profile - replaced jQuery occurrences with $.
2013-03-05 15:39:21 -05:00
Robin Ward
cf09e200a5
Moved Markdown out of Discourse.Utilities -> Discourse.Markdown
2013-03-05 14:56:43 -05:00
Robin Ward
e4277757c4
Fix onebox loading on every keystroke after a request fails.
2013-03-05 14:06:39 -05:00
Gosha Arinich
a1825fece9
refactor Category
...
* move callback bodies to separate methods (easier to test)
2013-03-05 21:09:13 +03:00
Régis Hanol
239cbd2d58
enforce coding convention
...
replaced every `and` by `&&` and every `or` by `||`
2013-03-05 01:42:44 +01:00
Robin Ward
e669b10966
Merge pull request #355 from dracula2000/site_setting_spec_fix
...
Fix order dependency in site_setting_spec.rb
2013-03-04 11:53:17 -08:00
Robin Ward
35d5c899dd
Merge pull request #321 from tijmenb/fix-hosts-in-oneboxer
...
Fix display hosts in oneboxer
2013-03-04 11:04:02 -08:00