40b1558f83
Merge pull request #2747 from cpradio/remove-additional-search-code
...
FIX: Remove additional search code related to the up/down navigation
2014-09-03 14:46:09 -04:00
e9600d7cb1
Convert some application helpers to ES6 format.
2014-09-03 13:30:22 -04:00
0b6c84e292
UX: Remove background color from new badge. DRY up lots of repeated code
...
for rendering badges on topics.
2014-09-03 12:22:18 -04:00
6489c1d7e3
FIX: admin page for users who have not been activated makes it more clear that the account is inactive, and won't offer actions that don't work yet
2014-09-03 10:41:13 -04:00
ff136ddeea
FEATURE: accounts that have not been activated are grey in admin user lists
2014-09-03 10:09:30 -04:00
c6aab831ed
Merge pull request #2741 from riking/badges_create_checks
...
FIX: Apply contract checks when first creating a badge
2014-09-03 22:19:09 +10:00
9c16dee843
Merge pull request #2742 from riking/patch-1
...
UX: Change Impersonate to btn-danger
2014-09-03 22:18:19 +10:00
44a25271f1
FIX: Remove additional search code related to the up/down navigation
...
Removed additional search code that was related to the up/down navigation and their related tests.
https://meta.discourse.org/t/magic-search-code-for-keyboard-shortcuts/19563
2014-09-03 06:51:52 -04:00
d4f08f442c
FIX: correct template for search in post (regression)
2014-09-03 17:09:01 +10:00
921dd75dd9
FIX: anonymous had <a> items for pin/unpin
...
FEATURE: display category in search results
FEATURE: display topic state (locked/pinned/etc) in search results
UI cleanup for search results, clearing floats and so on.
2014-09-03 12:13:26 +10:00
4f09d552ed
FEATURE: increase search expansion to 50 results
...
refactor search code to deal with proper objects
use proper serializers, test the controllers
2014-09-03 12:13:25 +10:00
71b7c80257
UX: CSS tweaks for badge query previews
2014-09-02 19:09:51 -07:00
8979020b9d
Clean up unused translations
2014-09-02 15:40:23 -07:00
3413228e89
UX: Change Impersonate to btn-danger
2014-09-02 15:33:54 -07:00
b04a52676e
FIX: Don't show wrong flag choices after undo
2014-09-02 17:37:54 -04:00
defe1dd86f
Merge pull request #2739 from techAPJ/patch-1
...
hide poster avatars when only two posts
2014-09-02 09:54:52 -07:00
abd84cd2a1
FIX: Redirect to Top was showing "latest" content because it was in the
...
preload store.
2014-09-02 12:29:22 -04:00
d09f109b2c
FIX: Re-enable filtering on user expansions on topics
2014-09-02 12:08:02 -04:00
ce745b737e
Renamed `poster-expansion` to `user-expansion` because it's not specific
...
to a poster anymore.
2014-09-02 12:08:02 -04:00
2b0e11dad8
Merge pull request #2711 from hydrarulz/localize_romanian
...
Add translation for Romanian.
2014-09-02 10:48:38 -04:00
065101afac
Merge pull request #2734 from cpradio/readd-dismiss-bindings
...
FIX: Readd the dismiss keybindings
2014-09-02 10:42:53 -04:00
8955bf02d8
hide poster avatars when only two posts
2014-09-02 20:10:36 +05:30
e0c8abc911
Merge pull request #2717 from riking/badge-solid
...
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
202656a679
Merge pull request #2725 from cpradio/german-keyboard-support
...
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
02a7a579f4
FIX: Duplicate badge titles can still occur
...
Send false instead of true to .uniq as the badges are not sorted.
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge-2/19495
2014-09-01 13:56:19 -04:00
03a7b01e4b
Merge pull request #2735 from techAPJ/patch-3
...
suppress post count on avatar for single post
2014-09-01 08:11:32 -07:00
eba3f6b408
suppress post count on avatar for single post
2014-09-01 14:23:34 +05:30
69e418facf
FEATURE: wider search with more context
2014-09-01 17:04:57 +10:00
42c052d21b
FIX: Readd the dismiss keybindings
...
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
2014-08-31 21:56:38 -04:00
6234284243
FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings
2014-08-31 21:42:03 -04:00
1833b43ae2
FEATURE: Badge query validation, preview results, and EXPLAIN
...
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.
Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.
On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).
The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.
The Badge.save() method is amended to propogate errors.
Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.
Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.
An uninitialized variable path is removed in the backfill() method.
TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
5c244c6f8f
FIX: autocomplete username failing to pop up
...
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises
This also fixes a promise leak
2014-09-01 01:48:17 +10:00
6d1be665a1
Merge pull request #2729 from cpradio/firefox-kbd-post-navigation
...
FIX: j/k navigation for posts using Firefox
2014-08-30 13:32:15 -07:00
37639308c0
FIX: Firefox j/k post navigation is inconsistent
...
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
3f5d530553
Change SHIFT+J and SHIFT+K to move up/down sections instead of posts.
2014-08-30 07:31:38 -04:00
82d4c29c88
TRIVIAL: add line break before time for post navigator
2014-08-30 16:14:00 +05:30
7a50ba600a
Merge pull request #2726 from techAPJ/patch-4
...
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
3c005557e6
FIX: use short date format for post navigator
2014-08-30 11:34:33 +05:30
4281b16616
UX: dim the new and unread education
2014-08-29 22:54:11 -07:00
89eb03aff0
FIX: Support J/K bindings on German Keyboards
...
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
2014-08-29 22:18:03 -04:00
8b349b43a5
UX: Add keyboard binding for reply as new topic
...
Removed extra translation in the keyboard shortcut modal window
2014-08-29 20:10:34 -04:00
2e200ffbf0
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
...
Conflicts:
config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
875b39fb5f
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
2014-08-29 19:56:39 -04:00
cb45d5fa25
Merge pull request #2724 from cpradio/key-binding-reply-new-topic
...
UX: Add keyboard binding for reply as new topic
2014-08-29 16:46:34 -07:00
d74f94afa1
Merge pull request #2722 from cpradio/dismiss-keyboard-bindings
...
UX: Add key-bindings for Dismiss New, Dismiss Posts, and Dismiss Topics
2014-08-29 16:28:25 -07:00
68e807f791
UX: Add keyboard binding for reply as new topic
2014-08-29 19:14:42 -04:00
bc07bc4819
Remove incoming/updated topics logic (not sure how that got in here, but it is causing a conflict)
2014-08-29 18:19:06 -04:00
1291e94c78
Merge pull request #2715 from cpradio/master
...
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
6dcde9ccc3
FIX: Navigating to None was not working
2014-08-29 15:51:28 -04:00
926e45d030
SECURITY: User action route was returning too much data
2014-08-29 13:46:50 -04:00
16c9f073b5
FIX: Back button breaks translation of incoming stuff
2014-08-29 12:53:06 -04:00
ec42b61a4d
FIX: suspended users cannot be trust level 3
2014-08-29 12:33:34 -04:00
8033972536
UX: Add keyboard bidning for incoming/updated topics
...
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
5ca96e741d
UX: Add keyboard bidning for incoming/updated topics
2014-08-29 09:44:26 -04:00
096bc0c0ae
Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
...
Conflicts:
app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cde64580b1
Change the Dismiss keybindings to use 'x' instead of 'd' - moved it to a function binding
2014-08-29 09:35:38 -04:00
3f085c3fd3
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 09:22:47 -04:00
ede9d1e057
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 08:46:35 -04:00
9e72b97a75
Corrected an issue with using the same ID for the header/footer of the buttons
2014-08-29 08:33:45 -04:00
e4ce995369
FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu
2014-08-29 08:11:23 -04:00
ed8d828ff1
FIX: Added keyboard bindings for dismiss buttons
2014-08-29 08:04:57 -04:00
fd6dd88afb
FIX: dual modal when deleting spammer in the flag modal
2014-08-29 13:05:51 +02:00
521cb6bd0d
FIX: dual modal when selecting 'delete spammer' in flags section
2014-08-29 12:54:24 +02:00
8bda8a2235
Revert "UX: stop displaying "user deleted, OK" dialog"
...
This reverts commit 36405287b4
2014-08-29 03:49:00 -07:00
36405287b4
UX: stop displaying "user deleted, OK" dialog
2014-08-29 03:34:23 -07:00
3396e6fea3
Centralize MessageBus post updates
...
After this change, only two files directly publish to MessageBus with a
topic interpolated in the channel: Post and TopicUser.
2014-08-28 20:40:36 -07:00
0784c52a24
FIX: Remove up/down key bindings for search results
...
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 21:39:19 -04:00
3e7084743c
FIX: Remove up/down key bindings for search results
...
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 19:58:07 -04:00
9e2c72e277
Allow restoring from backups in development mode even if the setting is
...
off.
2014-08-28 17:02:48 -04:00
1acb2a13f1
Added a:first
2014-08-28 16:06:48 -04:00
4fd73a2b2f
Set focus on site-map and user menu
...
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
8a6c4234fc
FIX: Re-enable searching for topic by id when using the split topic
...
interface.
2014-08-28 15:42:29 -04:00
b5b13b8c5f
Revert "Merge pull request #2713 from cpradio/master"
...
This reverts commit a9de189682b7ab43e454
2014-08-28 15:08:06 -04:00
a9de189682
Merge pull request #2713 from cpradio/master
...
Set focus on first item in drop down (textbox, link, whatever it may be)
2014-08-28 14:47:38 -04:00
8bf27642ad
FIX: Refresh was losing top controls after bulk operation. Removed
...
console.log
2014-08-28 14:44:38 -04:00
69cb5bc425
FIX: Centralize Top rendering, remove old code paths. Fix some bugs.
2014-08-28 14:34:31 -04:00
30b102aa98
FIX: Show uncategorized with badge/description in the category chooser
2014-08-28 12:42:31 -04:00
a40b08f210
Set focus on first item in drop down (textbox, link, whatever it may be)
...
Set focus on first item in the drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 11:33:45 -04:00
2cf92dbe7b
Add translation for Romanian.
2014-08-28 14:01:14 +03:00
3a9f0445bb
HACK: remove jarring scroll when hitting back from topic
2014-08-28 11:57:24 +10:00
fc71662a13
FIX: Don't show topics as unread when hitting back
2014-08-27 18:01:02 -04:00
940c0d5dbb
FIX: topicCountStats was depending on the wrong properties
2014-08-27 15:58:32 -04:00
f05d2ed7cf
PERF: Do far fewer checks and use a lot less memory when loading more
2014-08-27 15:31:06 -04:00
aab8eaac03
FIX: Double clicking quote expansion shouldn't break stuff.
2014-08-27 14:04:00 -04:00
09ea159afc
UX: Add link to change username on admin page
2014-08-27 13:52:01 -04:00
b1c0a3d01c
FIX: Retain back button scroll position even if we don't load more.
2014-08-27 13:33:52 -04:00
3a76f9e79f
FIX: allow localization in timestamp
2014-08-27 20:57:06 +05:30
f48b78c0bb
FEATURE: Allow localization sessions
...
use: I18n.verbose_localization_session()
2014-08-27 17:50:29 +10:00
0453da6fa5
FIX: use short date format for timestamp
2014-08-27 12:56:52 +05:30
16c34c206d
FEATURE: verbose localization option
2014-08-27 14:12:11 +10:00
1678a91a60
Add shortcuts for Profile Menu and Hamburger Menu
...
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
105959c402
Merge pull request #2696 from riking/errors
...
Fix "Server Error: [missing {{code}} value]" page
2014-08-26 11:14:57 -04:00
c58565d09f
Fix: dialect block parser should not eat next block's whitespace
2014-08-26 14:11:23 +02:00
d63c6292b3
change "Visit Profile" to just "Profile"
2014-08-26 00:37:10 -07:00
553e0290a6
mods can use shield glyph as well, don't need two
2014-08-25 23:49:39 -07:00
95f9943d28
remove <br/> from top non-mobile layout
2014-08-25 22:42:41 -07:00
b6b0cd5c15
add glyph to move posts to new topic button
2014-08-25 22:38:28 -07:00
3ea76815e4
Merge pull request #2686 from meglio/ru-plurals
...
Update RU pluralization to use 3 keys: one, few, other (as by Transifex)
2014-08-26 12:42:59 +10:00
c412d74369
HACK: suppress "1 reply" when directly below for quotes posts
2014-08-26 12:00:16 +10:00
f331855482
FIX: username autocomplete more reliable, cancel old reqs
2014-08-26 11:32:50 +10:00
Robin Ward
Neil Lalonde
Sam
cpradio
riking
Jeff Atwood
Arpit Jalan
Régis Hanol
Luca Daniel
Jens Maier