Commit Graph

14280 Commits

Author SHA1 Message Date
Robin Ward b78b010757 FIX: Fixes to grant new user of the month badge 2017-05-24 11:36:24 -04:00
Neil Lalonde 0756602dfa UX: h1, h2, etc css reset should give them a bottom margin 2017-05-24 10:38:25 -04:00
Neil Lalonde c9028f517a UX: headings in banners had no margins 2017-05-23 11:25:40 -04:00
Neil Lalonde 9edc490d3f FIX: remove memoized values in jobs 2017-05-22 16:26:30 -04:00
Robin Ward b23fc2bf84 Helper to find the final destination for a URL 2017-05-22 15:52:41 -04:00
Neil Lalonde f350dd4fd1 FIX: possible data leaking from one site to another in multisite in PendingFlagsReminder 2017-05-22 15:18:13 -04:00
Arpit Jalan decb432740 FIX: fill date input with default date range 2017-05-22 21:54:28 +05:30
Robin Ward 773445b8df FIX: Topic Crawling should only crawl HTTP/S urls 2017-05-22 11:57:20 -04:00
Guo Xiang Tan 08c36fa968 REFACTOR: Clean up some code associated with topic timers. 2017-05-22 18:10:29 +08:00
Guo Xiang Tan 604aaf8686 FIX: N+1 query in suggested topics list. 2017-05-22 18:05:38 +08:00
Guo Xiang Tan 238a156300 FIX: `TopicTimestampChanger` should not allow timestamps in the future. 2017-05-22 16:03:49 +08:00
Guo Xiang Tan 4382a0bb07 Rename `PostTimestampChanger` -> `TopicTimestampChanger`. 2017-05-22 15:01:33 +08:00
Jeff Atwood 393c060047 use moon glyph to denote "later today" 2017-05-19 17:02:00 -07:00
Robin Ward ea9f93dcc5 FIX: Don't crawl non-http/s links 2017-05-19 16:57:41 -04:00
Neil Lalonde 558a274187 UX: flag custom message description is too close to textarea on mobile 2017-05-19 16:08:28 -04:00
Robin Ward 908433a7a0 SECURITY: Validate the `entity` when downloading a CSV 2017-05-19 16:00:51 -04:00
Neil Lalonde 0a8e16d049 UX: show short flag descriptions in the flag modal on mobile 2017-05-19 15:35:10 -04:00
Neil Lalonde c0c6cb8124 mobile like count css rules being ignored 2017-05-19 11:10:18 -04:00
Neil Lalonde 3681b350cd FIX: new topics alert wasn't covering the entire topic list column headings 2017-05-19 11:05:38 -04:00
Jeff Atwood 387cad693e "next month" doesn't need time fidelity 2017-05-18 23:29:37 -07:00
Guo Xiang Tan e93535e239 Add "Next month" to topic timer selection options. 2017-05-19 14:09:53 +08:00
Guo Xiang Tan 8ab9f30bbd FIX: User can't remove bookmark from a deleted post. 2017-05-19 12:25:12 +08:00
Arpit Jalan 870c584e25 Merge pull request #4876 from techAPJ/upload-error
FIX: better uploads error page
2017-05-19 07:24:15 +05:30
Jeff Atwood ef2811f39a simplify time formats for set topic timer 2017-05-18 17:14:07 -07:00
Neil Lalonde 5e88794a65 remove box-shadows around radio buttons and checkboxes on mobile 2017-05-18 18:04:47 -04:00
Neil Lalonde fa77bbf04f FIX: mobile modal close button position, mobile layout of radio buttons and checkboxes 2017-05-18 17:08:52 -04:00
Robin Ward ed4b2b6d8d FIX: Don't incluide a trailing `<br>` in the bio excerpt 2017-05-18 16:40:07 -04:00
Neil Lalonde 3065b7db4c FIX: label positioning on mobile forms 2017-05-18 16:38:35 -04:00
Neil Lalonde c2579c5916 FIX: layout of buttons and modals on mobile 2017-05-18 16:11:52 -04:00
Robin Ward 1ef43c33d8 Don't pre-minifiy autoellipsis 2017-05-18 15:16:15 -04:00
Arpit Jalan 1fd8e426f2 FIX: better uploads error page 2017-05-18 23:29:37 +05:30
Neil Lalonde dbb814ec6a FIX: allow pasting links into title field that are longer than the max title length 2017-05-18 12:32:47 -04:00
Régis Hanol 13e489b4ca replace the upload type whitelist with a sanitizer 2017-05-18 12:13:13 +02:00
Arpit Jalan 8e5b0c79ae FIX: allow images to be uploaded in wizard 2017-05-18 13:53:23 +05:30
Sam 2a5a01af2e improve error on theme upload, add gif to allowed uploads 2017-05-17 16:29:09 -04:00
Neil Lalonde a0f03936ff FIX: saving invisible primary group field that you don't belong to 2017-05-17 12:46:50 -04:00
Robin Ward f8c503186e FIX: If there's an error downloading, don't raise it 2017-05-17 12:38:18 -04:00
Robin Ward 9090c7b05b FIX: Admin groups editor was showing extra page when exactly 50 records 2017-05-17 11:50:17 -04:00
Robin Ward 6d5fe73422 FIX: Sometimes the topic timeline wasn't docking 2017-05-17 11:05:58 -04:00
Guo Xiang Tan e4d557cdb9 Partially revert 92118dd1d1. 2017-05-17 21:42:31 +08:00
Jeff Atwood db06dd8032 remove labels from tag edit buttons in header 2017-05-17 01:18:31 -07:00
Guo Xiang Tan 92118dd1d1 FIX: Use observer to rerender widget instead. 2017-05-17 10:29:50 +08:00
Robin Ward 5d494cf158 FIX: Broken back button on account URLs 2017-05-16 17:21:52 -04:00
Sam 68df8f4427 FIX: only trigger notification level change if it actually changes
avoids double ajax call every time notification level changes
2017-05-16 16:52:39 -04:00
Robin Ward 733b0009cb FIX: Don't memoize the currentUser in case some plugins use it too early 2017-05-16 16:35:18 -04:00
Sam 763f156d91 FIX: require re-activation if SSO changes email and updates it 2017-05-16 16:18:18 -04:00
Sam 4424fd81b8 add a tiny bit of extra protection 2017-05-16 16:08:42 -04:00
Sam 4b449914b8 FIX: admins could never remove self from messages 2017-05-16 16:06:24 -04:00
Sam 6ddd8d9166 FIX: when entering topics "tracking" would not be set
There was a timing issue when subscribing to messages for topics.

Old flow:

- We generate JSON for topic
- We subscribe to messages for topic

New flow:

- We keep track of last id in the topic message bus channel
- We generate JSON
- We subscribe to messages for topic starting at saved message id

This ensures that there is complete overlap for message consumption
and that there are no cases where an update may go missing due to timing
2017-05-16 15:04:21 -04:00
Neil Lalonde 7821400141 FEATURE: staff can set a timer to remind them about a topic 2017-05-16 14:49:50 -04:00
Leo McArdle 59922ce0a4 FEATURE: remove table wrapping posts in notification emails 2017-05-16 10:37:53 -04:00
Robin Ward 941adca958 FIX: If you refresh New, clear the incoming topics text 2017-05-15 16:57:09 -04:00
Sam c40ac5abe6 FIX: resize events for ace were not triggered correctly 2017-05-15 16:10:07 -04:00
Sam 7a4e825671 we should use fancy title if available 2017-05-15 15:45:29 -04:00
Sam be8dd403df FEATURE: use fancy title in notifications 2017-05-15 15:38:30 -04:00
Robin Ward f7c46df804 FIX: Only mark all as rendered after *everything* is rendered 2017-05-15 15:12:10 -04:00
Sam f114d63de4 correctly pick the selected theme based on what is loaded 2017-05-15 14:34:24 -04:00
Robin Ward bd0bb879e5 FIX: Don't count likes from system users in the new user of the month 2017-05-15 13:14:32 -04:00
Sam e1dd543a93 FEATURE: allow users to select theme on single device 2017-05-15 12:48:16 -04:00
Robin Ward a0c936dadb UX: Take header height into account when positioning the timeline 2017-05-15 12:08:42 -04:00
Sam 44d7fe89ed FIX: unescape emoji in pretty title
This makes emoji in title consistent, it is later escaped back when needed
2017-05-15 10:28:05 -04:00
Guo Xiang Tan dfc9a27dc4 FIX: Quote button broken on windows. 2017-05-15 08:26:48 +08:00
Robin Ward 42de1cc977 FIX: Don't warn if the link is in the post you are editing 2017-05-12 20:05:30 -04:00
Neil Lalonde dd0c34c4b9 move background photo user prefs to be lower in the profile tab 2017-05-12 15:43:21 -04:00
Sam ff6b9aee47 no opacity rule for btn-primary 2017-05-12 15:11:44 -04:00
Sam baf011cbf6 annotate models 2017-05-12 14:47:08 -04:00
Robin Ward a9d5d2aee6 UX: Fix improper aspect ratio for xkcd oneboxes 2017-05-12 13:21:44 -04:00
Sam b92b654ea3 FIX: collapse mobile nav on outside click 2017-05-12 13:15:04 -04:00
Sam 3113a6a18a FIX: hide theme selector if only 1 theme 2017-05-12 12:50:56 -04:00
Sam 2d96a0785d FEATURE: theme selection is now global per-user 2017-05-12 12:41:34 -04:00
Robin Ward b301b69d00 FIX: Don't warn users about duplicate links for:
- The original post
- If the post is older than (x) (Two Weeks for now)
2017-05-12 12:37:02 -04:00
Sam ee71786057 PERF: we do not need to ship down the total number of unread
Total number of unread notification from the beginning of time
is not an interesting number
2017-05-12 11:11:38 -04:00
Sam e232f87cde PERF: avoid query as admin
As admin no need to query categories over and over
2017-05-12 11:09:41 -04:00
Chris Gavin fca166524b Fix the padding on the login and register buttons. 2017-05-12 09:51:48 +01:00
Guo Xiang Tan 8eecd42856 FIX: Delete topic timer after completion. 2017-05-12 10:28:51 +08:00
Guo Xiang Tan e63614024d FIX: Users can't request to join group due to alias level restriction.
https://meta.discourse.org/t/request-to-join-group-not-working/62371
2017-05-12 09:26:26 +08:00
Neil Lalonde 55b61e9bea rename topic_status_update to topic_timer 2017-05-11 18:27:53 -04:00
Robin Ward 92d63b59a7 FIX: Videos were missing from expanded quotes 2017-05-11 16:54:32 -04:00
Robin Ward f3c535b945 PERF: Dirty checking was broken and re-rendering too often 2017-05-11 16:22:15 -04:00
Robin Ward ea0ecb67f3 UX: Move delete button to end and mark it as dangerous 2017-05-11 16:22:15 -04:00
Sam 52ae63d5d7 FIX: when searching PMs also search group PMs
Users belonging to a group could not search for PMs unless explicitly added
to the PM unless admin
2017-05-11 15:59:03 -04:00
Pat David aa009dd2b5 Add @embeddable_css_class from embed_controller 2017-05-11 15:16:16 -04:00
Pat David 18de62b015 Add get_embeddable_css_class to assist multi-site embed styling
If present, pass embeddable_host.class_name to view for inclusion
on the <html> element as a class for targeted styling.
2017-05-11 15:16:16 -04:00
Pat David 4bf8548dc5 Add embed class name setup for embeddable hosts 2017-05-11 15:16:16 -04:00
Robin Ward 5bbc477baa UX: Better looking bulk actions modal 2017-05-11 14:48:06 -04:00
Neil Lalonde 1019bbda46 FEATURE: set a timer to delete a topic 2017-05-11 12:52:29 -04:00
Robin Ward 21238692d9 Remove unused file 2017-05-11 12:36:57 -04:00
Robin Ward 3ade46de0b FIX: Don't send system message for new user of the month if disabled 2017-05-11 11:33:16 -04:00
Robin Ward 006b35d2f3 FIX: Don't redirect for `users/account-created` path 2017-05-11 11:04:45 -04:00
Arpit Jalan f4b2677a19 FEATURE: ask for confirmation before resending all invites 2017-05-11 18:07:28 +05:30
Guo Xiang Tan ce9fe213fd FIX: Can't quote last paragraph. 2017-05-11 16:49:46 +08:00
Arpit Jalan 8c337ecf82 FIX: allow uploading of category logo and background 2017-05-11 12:48:54 +05:30
Régis Hanol 214939bb87 freeze array constants 2017-05-11 09:08:59 +02:00
Régis Hanol 4b7be137cb don't generate errors if 'upload_id' is invalid 2017-05-11 09:07:04 +02:00
Régis Hanol 9641d2413d REFACTOR: upload workflow creation into UploadCreator
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
Sam a5c4ddd334 oops my linter is not running automatically 2017-05-10 16:09:33 -04:00
Sam 2e13c2453b FIX: maximize css editor not working 2017-05-10 15:47:11 -04:00
Sam 04b5516bf2 improve upload functionality 2017-05-10 15:47:11 -04:00
Sam bc0b9af576 FEATURE: support uploads for themes
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
Sam f709899a1d Allow theme field object model to support uploads 2017-05-10 15:46:42 -04:00
OsamaSayegh 26209354e3 Don't hardcode code button index and remove the for loop and use .some() 2017-05-10 14:53:54 -04:00
osamasayegh 2f8b1e33f4 FEATURE: bulk relist 2017-05-10 14:53:54 -04:00
Robin Ward f7e8bc6216 UX: Tweak explanations for multiple_grant and allow_title 2017-05-10 14:39:23 -04:00
Robin Ward 4db76796b9 FEATURE: Setting to poll feeds more frequently 2017-05-10 14:30:12 -04:00
Neil Lalonde 5be7a2dad4 FIX: invalid html in notification emails when template has been customized 2017-05-10 14:01:26 -04:00
Guo Xiang Tan 41fb76cc66 Don't rescue all errors. 2017-05-10 09:12:44 +08:00
Robin Ward 907f6cd76b FIX: Select2 retina icons were broken 2017-05-09 15:51:39 -04:00
Robin Ward a1baf73956 FIX: Better error message for when your bookmark rate limit is exceeded 2017-05-09 15:42:55 -04:00
Robin Ward ae15b10cf8 FIX: The keyboard shortcut to bookmark the first post wasn't refreshing 2017-05-09 15:37:36 -04:00
Robin Ward 6e4ba8a33e Catch RSS Parsing errors 2017-05-09 15:07:06 -04:00
Robin Ward c2bf525a06 Make CloseTopic a no-op just in case 2017-05-09 15:02:05 -04:00
Robin Ward 24e1892d28 Silence logs for OptimizedImage failures 2017-05-09 14:59:46 -04:00
Robin Ward ba1868b051 FIX: There are still jobs enqueued for CloseTopic 2017-05-09 14:58:37 -04:00
Robin Ward da92f35e08 Don't log a gravatar failure that is a socket error 2017-05-09 14:44:53 -04:00
Robin Ward bcf1a9d43f We don't need to log when we can't download a Gravatar 2017-05-09 14:43:39 -04:00
Robin Ward 6fdbd29882 FIX: Dismiss all button was not updating the UI 2017-05-09 13:46:26 -04:00
Arpit Jalan e6e0025326 FIX: handle BOM in bulk import CSV file 2017-05-09 22:38:07 +05:30
Sam Saffron c2829dce22 FIX: base sql vanishes after badge creation 2017-05-09 09:25:57 -04:00
Arpit Jalan 94683b33b8 FIX: sanitize bulk invite error log 2017-05-09 17:41:59 +05:30
Robin Ward afe04b8bbb FIX: Possible 500 error if category saved incorrectly 2017-05-08 15:17:58 -04:00
Robin Ward 4f6e5fed2a We don't need to raise an error when no post is present. Just noop. 2017-05-08 15:08:29 -04:00
Robin Ward 7a0501c0c0 UX: Wrap really long titles on user stream pages 2017-05-08 14:45:34 -04:00
Robin Ward 96c59c5b82 FIX: Don't notify or return flags on system users 2017-05-08 13:13:35 -04:00
Sam a7471fe85f FIX: page scroll lock not clearing properly on chrome
For some reason Chrome renamed "mousewheel" to "wheel"
2017-05-08 09:50:07 -04:00
Sam 257c0dea70 Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list
Remove daily mailing mode option as it doesn't scale.
2017-05-08 09:10:46 -04:00
Arpit Jalan e89d0a6b20 FIX: importing a theme via file was broken 2017-05-08 12:03:24 +05:30
Jeff Atwood cfb30bca80 UX: simplify delete gap style 2017-05-05 17:06:13 -07:00
Jeff Atwood 27e52bc66d user page stats too "buttony" 2017-05-05 15:36:13 -07:00
Neil Lalonde b7322b05a0 FIX: some changes in composer affect all visible text editors 2017-05-05 12:59:45 -04:00
Neil Lalonde 3edea3d226 automatically unpin topics setting doesn't need its own section 2017-05-05 10:25:02 -04:00
Régis Hanol 8bc47d0bae fix build (cc @tgxworld) 2017-05-05 13:13:49 +02:00
Guo Xiang Tan e61959e6a8 FIX: `CustomEmoji` may contain an invalid upload_id.
https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608
2017-05-05 14:53:38 +08:00
Guo Xiang Tan 2b21e5ea7e UX: Display translated group name for automatic groups. 2017-05-05 14:34:47 +08:00
Guo Xiang Tan 71a266b673 Remove daily mailing mode option as it doesn't scale.
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
Guo Xiang Tan 50c8ae2c10 Load user records in batches. 2017-05-05 10:57:31 +08:00
Robin Ward 777f1f0f47 FIX: Return a 404 if the auth session is not present 2017-05-04 15:35:24 -04:00
Sam Saffron c182dcc64c FEATURE: add .admin-interface class to BODY when in admin
removes some dead code as well
2017-05-04 15:13:32 -04:00
Neil Lalonde 66cc4fff2c fix style of custom field labels on dropdowns and confirm 2017-05-04 14:08:15 -04:00
Sam 4ebbad991e FIX: properly clean up related color schemes on delete 2017-05-04 14:03:17 -04:00
Robin Ward 81326f85e5 FIX: Regression when clicking on post date 2017-05-04 13:51:02 -04:00
Neil Lalonde c576e49230 fix blank name field 2017-05-04 13:45:16 -04:00
Robin Ward 55ca5df96b FIX: If the host can't be extracted don't raise an error 2017-05-04 13:26:37 -04:00
Robin Ward 1768c45a33 FIX: If we can't proxy to a CDN due to HTTP error, render blank 2017-05-04 12:42:46 -04:00
Robin Ward 57a2042ef6 FIX: Quiet server side errors for requesting json for account-created 2017-05-04 12:30:13 -04:00
Robin Ward b3165f8435 FIX: If badges are disabled don't show "Top Badges" on summary view 2017-05-04 12:14:32 -04:00
Neil Lalonde c98601129b Move name, avatar, and title fields from profile tab to account tab 2017-05-04 12:04:07 -04:00
Robin Ward de0d13e4ef FIX: Badge filtering was always to the currentUser 2017-05-04 11:58:56 -04:00
Neil Lalonde f4c09e9e90 fix select input widths regression in user preferences 2017-05-04 11:25:22 -04:00
Arpit Jalan 0bdced165a UX: change timestamp button on mobile was hidden behind date selector 2017-05-04 18:47:25 +05:30
Guo Xiang Tan 58edd203a9 SECURITY: XSS issue in share popup if invalid link is passed in. 2017-05-04 10:33:59 +08:00
Guo Xiang Tan 94c8410521 FIX: Show share popup only for valid buttons. 2017-05-04 10:31:09 +08:00
Robin Ward b3908a1d7f FIX: The user might be anonymous 2017-05-03 18:39:02 -04:00
Robin Ward 60693240e1 FIX: Filter badges to user on their badges page too 2017-05-03 17:58:59 -04:00
Guo Xiang Tan 3eb920e2b0 Merge pull request #4841 from fantasticfears/webhook-ping
add event name for ping webhooks in the header
2017-05-04 04:54:40 +08:00
Neil Lalonde 7f09bc9a09 Merge pull request #4849 from discourse/prefs
User preferences in tabs
2017-05-03 16:53:26 -04:00
Neil Lalonde 389a0e1a1c FIX: emails should use default theme colors 2017-05-03 14:35:13 -04:00
Robin Ward b705634ee1 FIX: If you have a badge, filter to you when clicking on it 2017-05-03 13:35:20 -04:00
Robin Ward 09cb61b533 FIX: Jumping to a post that doesn't exist should jump to closest 2017-05-03 13:24:30 -04:00
Neil Lalonde 8bcfea3b0d new outlets for plugins 2017-05-03 11:41:01 -04:00
Sam 342ef5f81a FEATURE: out-of-the-box dark/light user selectable themes 2017-05-03 11:31:33 -04:00
Robin Ward 81190f5d66 FIX: Redirect away from `account-created` if you're logged in 2017-05-03 11:18:01 -04:00
Robin Ward 12fb20fe1b FEATURE: Allow users to resend/update email from confirmation page 2017-05-03 11:18:01 -04:00
Robin Ward b381372184 Use Ember.js for the `/u/account-created` path so we can add controls 2017-05-03 11:18:01 -04:00
Arpit Jalan 86f1cc8c92 FIX: don't apply max_emails_per_day_per_user on critical emails 2017-05-03 17:07:39 +05:30
Guo Xiang Tan 982e3d04f6 PERF: Allow memory to be freed instead of fetching all the objects into memory at once.
```
MemoryProfiler.report do
  Jobs::UserEmail.new.execute(type: :mailing_list, user_id: user.id)
end.pretty_print
```

Before:
```
Total allocated: 180096119 bytes (1962025 objects)
Total retained:  2194 bytes (16 objects)

allocated memory by gem
-----------------------------------
  66979096  activerecord-4.2.8
  43507184  nokogiri-1.7.1
  43365188  mail-2.6.4
   5960201  activesupport-4.2.8
   5056267  discourse/lib
   4835284  rack-mini-profiler-0.10.1
   3825817  arel-6.0.4
   2186088  i18n-0.8.1
   1719330  discourse/app
```

After:
```
Total allocated: 161935975 bytes (1473940 objects)
Total retained:  2234 bytes (17 objects)

allocated memory by gem
-----------------------------------
  45430264  activerecord-4.2.8
  43568627  nokogiri-1.7.1
  43430754  mail-2.6.4
  11233878  rack-mini-profiler-0.10.1
   5260825  activesupport-4.2.8
   5054491  discourse/lib
   2186088  i18n-0.8.1
   1822494  arel-6.0.4
```
2017-05-03 17:01:57 +08:00
Arpit Jalan cdce060a38 FIX: don't apply max emails per day per user to forgot password 2017-05-03 14:02:37 +05:30
Neil Lalonde 2503241ce5 FEATURE: rebuild user preferences page to use tabs 2017-05-02 16:52:18 -04:00
Sam 946f25098f Refactor theme fields so they support custom theme defined vars
This paves the way to allowing themes to specify uploads and so on.
2017-05-02 16:02:14 -04:00
Arpit Jalan 77a8cae094 FIX: rescue specific errors on invite failure 2017-05-02 15:13:33 +05:30
Erick Guan 9f8a917d65 add event name for ping webhooks in the header 2017-05-02 08:13:23 +02:00
Guo Xiang Tan f5b11cb429 PERF: Don't allocate extra array. 2017-05-02 11:54:23 +08:00
Robin Ward 3736b440cb FIX: Quoting an expanded first post would force it to reload the cooked 2017-05-01 15:01:35 -04:00
Neil Lalonde 0722ffadf1 Remove site settings enforce_global_nicknames and discourse_org_access_key 2017-05-01 14:53:16 -04:00
Neil Lalonde ca224ed8e9 FIX: pending flags message should go to moderators group, not staff 2017-05-01 14:53:16 -04:00
Sam 556ef4cfbd FIX: case sensitive unconditional add of exact match in user search 2017-05-01 14:37:16 -04:00
Robin Ward dfe1174137 FIX: The dates for retroactive anniversary badges were wrong 2017-05-01 12:06:18 -04:00
Arpit Jalan 9e9ead0954 FIX: incorrect label for top topics dropdown on mobile when filtering 2017-05-01 16:43:23 +05:30
Jeff Atwood a4815047c0 purge `scheduler_stats` every 1 month instead of 3 2017-04-28 15:05:15 -07:00
Robin Ward f05f1a24d3 Change Anniversary badge to be multiple grant, once per year 2017-04-28 14:22:54 -04:00
Neil Lalonde bb82e0a041 FIX: theme preview from preferences wasn't working 2017-04-28 14:01:57 -04:00
Neil Lalonde b193ae2d15 FIX: missing link in unsubscribe text of summary emails 2017-04-28 10:37:52 -04:00
Robin Ward cb8f91ca21 FIX: Scrolling offset was broken when entering some topics 2017-04-27 16:22:25 -04:00
Robin Ward 5774a9a2c8 Revert offset calculation, was working poorly. 2017-04-27 12:20:32 -04:00
Robin Ward a545117d2e FIX: Forgot to clear out a topic excerpt 2017-04-27 11:49:39 -04:00
Robin Ward 2efe0442bf FIX: Messed up i18n key 2017-04-27 11:45:59 -04:00
Guo Xiang Tan 304ace926e FIX: Raise right response when post_action does not exist. 2017-04-27 17:29:53 +08:00
Guo Xiang Tan e4b9f72f9e FIX: Force the right encoding when handling email. 2017-04-27 16:51:54 +08:00
Guo Xiang Tan 7873a2efb7 Merge pull request #4843 from tgxworld/disable_post_min_length_for_pm
FEATURE: Disable minimum post length check when in PM with non human …
2017-04-27 16:35:19 +08:00
Guo Xiang Tan 59b906ab0d FEATURE: Disable minimum post length check when in PM with non human users.
https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld
2017-04-27 16:00:22 +08:00
Guo Xiang Tan 85d9342ff0 Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job
FIX: Clean up unused staged users job not completing.
2017-04-27 15:41:46 +08:00
Arpit Jalan b755279cf0 remove unneeded code 2017-04-27 08:47:47 +05:30
Arpit Jalan e3f82140d8 more readable code for filtering username/email when bulk adding to group 2017-04-27 08:43:28 +05:30
Arpit Jalan b41d96fac1 FIX: properly initialize hashes 2017-04-27 02:56:14 +05:30
Arpit Jalan 9b0ecdaf7e Merge pull request #4839 from techAPJ/bulk-add-group
FEATURE: provide more details when performing a bulk add to group
2017-04-27 02:39:57 +05:30
Arpit Jalan 285c167fae FEATURE: provide more details when performing a bulk add to group 2017-04-27 01:37:51 +05:30
Robin Ward 30ebaf6b6a Update FontAwesome to 4.7.0 2017-04-26 15:16:30 -04:00
Robin Ward cd4f0393a8 Add a title tag to the search results page 2017-04-26 15:02:07 -04:00
Robin Ward bf9c4a7828 FEATURE: secure_email site setting to prevent data going out in email 2017-04-26 13:05:56 -04:00
Guo Xiang Tan fe0a7d97ca Fix incorrect class name. 2017-04-26 18:12:51 +08:00
Guo Xiang Tan b00886f5c1 Remove sidekiq-statistic gem.
* We don't really use it and there is an on-going issue
  with the gem not expiring keys in a Redis list which
  hasn't been fully resolved.

  https://github.com/davydovanton/sidekiq-statistic/issues/73
2017-04-26 14:54:47 +08:00
Guo Xiang Tan daa97c40ce FIX: Clean up unused staged users job not completing. 2017-04-26 10:51:36 +08:00
Guo Xiang Tan 1f6418f907 Track error message in `SchedulerStats`. 2017-04-26 01:34:25 +08:00
Arpit Jalan aeead60036 FIX: make TopicEmbed trashable 2017-04-25 18:40:39 +05:30
Régis Hanol 64787e7fa4 Merge pull request #4831 from gdpelican/image-gallery
FEATURE: Use image gallery functionality in magnific
2017-04-25 09:39:10 +02:00
James Kiesel 48c0f3faf3 Use image gallery feature of magnific
commit cc7061e9458d04dd02aad9c02ba3a89306e0fae7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 11:21:08 2017 +0900

    ;

commit 9233be7e432daff605812e6b49042f69d348b6e7
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 10:01:26 2017 +0900

    Don't break if $elem is undefined

commit 598a694c070c86df8d9f5ffa1ed84e2f8756e65f
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:51:14 2017 +0900

    .

commit 1711685a33ccd236011f54d3e652991728530b3a
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:34:11 2017 +0900

    ;

commit 81703f36c0593250aeac3418fde86660fd307092
Author: James Kiesel <james.kiesel@gmail.com>
Date:   Tue Apr 25 04:12:37 2017 +0900

    Use image gallery functionality in magnific
2017-04-25 11:23:15 +09:00
Guo Xiang Tan 6f7c6b0fd0 FIX: Incorrect error raised. 2017-04-25 09:59:01 +08:00
cpradio d69122c385 UX: Change banner close button to be floated to the right 2017-04-24 20:51:02 -04:00
Régis Hanol 0d66529d2b PostReply doesn't have a primary key, so no luck here 2017-04-24 23:14:01 +02:00
Régis Hanol 1787c45b38 PERF: don't load all replies in memory when moving posts 2017-04-24 23:00:32 +02:00
Régis Hanol 8fe0bbb238 REFACTOR: improve Notification.ensure_consistency SQL query readability 2017-04-24 23:00:27 +02:00
Régis Hanol 301dd139ae PERF: faster Group.refresh_automatic_group & Group.ensure_consistency 2017-04-24 23:00:21 +02:00
Régis Hanol 3d406b047c PERF: much faster Badge.ensure_consistency 2017-04-24 22:59:49 +02:00
Robin Ward f41ab98e86 FIX: Scrolling to the bottom was still a bit weird with no suggested 2017-04-24 16:36:43 -04:00
Robin Ward 62966b1023 FIX: Remove duplicate route warning, it's just a noop now 2017-04-24 13:36:05 -04:00
Robin Ward 4e1f8ec72b FIX: Without suggested topics jumping to a post had the wrong offset 2017-04-24 13:21:50 -04:00
Guo Xiang Tan 423f2ab228 FIX: Processing incoming email should be done in a background job. 2017-04-24 13:57:28 +08:00
Arpit Jalan 1f5089e474 FIX: handle invite error in wizard 2017-04-21 20:07:04 +05:30
cpradio 20c2c66dd4 FEATURE: Add normal as a preference for topic subscription state when replying to a topic 2017-04-20 22:33:10 -04:00
Rafael dos Santos Silva e922623da8 FIX: User Admin screen on mobile style was off 2017-04-20 23:18:01 -03:00
Guo Xiang Tan 8b2e3bf5f1 FIX: Topic title should be included in post webhook payload. 2017-04-21 10:04:21 +08:00
Sam aec73d4003 correct the spec again 2017-04-20 17:41:35 -04:00
Sam a9b953ac5a FIX: on create you could not add a theme component 2017-04-20 17:37:13 -04:00
Sam dcf9459b7c staff should track 2017-04-20 17:32:05 -04:00
Sam 5365973c0a FIX: detection of error changed, so you can clear errors 2017-04-20 16:55:18 -04:00
Neil Lalonde 703e6faf54 Revert "remove important from extra-info-wrapper color" 2017-04-20 16:27:10 -04:00
jomaxro b3eef0513f Remove console logging 2017-04-20 16:08:16 -04:00
Sam 7a9eee1b71 FEATURE: default notification level for group messages
also fixes it so staff can amend other user's group notification level
2017-04-20 15:47:35 -04:00
Neil Lalonde 05efa7ce68 simplify last_notified_id 2017-04-20 15:26:28 -04:00
Arpit Jalan 5d9d2cf287 FIX: do not explicitly show email of flagger / flagged user 2017-04-20 22:09:30 +05:30
Sam dfe3c162cc move stylesheet after js 2017-04-20 12:34:50 -04:00
Neil Lalonde 3d32158893 remove important from extra-info-wrapper color 2017-04-20 11:53:41 -04:00
Sam 81c08fe451 missing badge count in dark theme 2017-04-20 11:52:06 -04:00
Sam bbed29ba57 correct font preloading 2017-04-20 11:18:37 -04:00
Sam 8628a57f4e FIX: colors picker not working with CDN 2017-04-20 11:04:23 -04:00
Guo Xiang Tan 94c7be3ca6 Merge pull request #4824 from tgxworld/fix_optimize_image_timeout
Fix optimize image timeout
2017-04-20 15:53:43 +08:00
Arpit Jalan ea26c56631 FIX: redirect to login page for anonymous user when profiles are hidden 2017-04-20 13:00:45 +05:30
Guo Xiang Tan 2af1b9e93c Add time out when optimizing images. 2017-04-20 15:21:43 +08:00
Guo Xiang Tan 5c39c8f24b UX: Improve the way users set timers for `TopicStatusUpdate`. 2017-04-20 14:25:45 +08:00
Sam 7eabb90b71 FEATURE: added error messages for bad theme CSS / JS 2017-04-19 16:46:46 -04:00
Neil Lalonde 3835e16cf7 FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails. 2017-04-19 16:17:45 -04:00
Sam 0930db221f FIX: destroying color scheme could remove wrong item from UI 2017-04-19 15:31:21 -04:00
Sam c5ee448713 FEATURE: Only show overridden option for theme css
also fixes bad styling of mobile glyph
2017-04-19 15:24:00 -04:00
Sam c76d780675 FEATURE: show a paintbrush for color schemes 2017-04-19 11:06:21 -04:00
clapmyhands 5d28a1ac0d UX: Make abondon post confirmation button red. 2017-04-19 21:54:58 +08:00
Arpit Jalan 5fa5c18a48 use notification_levels methods for specifying normal notification level 2017-04-19 16:17:24 +05:30
cpradio 2dccaff25d FIX: Correct behavior of auto-notification state updating to exclude when the topic already has a state of normal/muted 2017-04-19 06:29:35 -04:00
Rafael dos Santos Silva d9ba168420 FIX: Show solved status on category with featured topics view too 2017-04-19 00:54:13 -03:00
Rafael dos Santos Silva 8d3ebfd2ac FIX: Show topic status on category view 2017-04-19 00:41:07 -03:00
Neil Lalonde e7b0ce1334 FIX: add white space in discourse-tags so tags can wrap 2017-04-18 17:09:46 -04:00
Sam 0a67d859d5 correct watcher so it handles color scheme changes correctly 2017-04-18 16:48:15 -04:00
Sam bbeb69ddc9 FIX: sort theme by lower case theme name 2017-04-18 15:43:38 -04:00
Sam 8ffb918824 FIX: add more consistent gutter to ace editor
old css hack had issues when line number was higher than 10
2017-04-18 15:43:22 -04:00
Sam 8ee2a500bc FEATURE: add hamburger extensibility 2017-04-18 15:18:03 -04:00
Robin Ward 8b8ee2ad61 Pass a context in when using a HTML builder 2017-04-18 12:35:35 -04:00
Sam Saffron a19c02f0d3 FEATURE: allow copying of color schemes to clipboard 2017-04-18 09:37:55 -04:00
Arpit Jalan 1c23aedccf FIX: always send password reset email when accepting invite if password is not set 2017-04-18 14:37:06 +05:30
Guo Xiang Tan 60f1169077 REFACTOR: Reduce repetition in code. 2017-04-18 17:03:49 +08:00
Guo Xiang Tan 03762e2828 Merge pull request #4818 from OsamaSayegh/ui/groups-heading-admin-page
The "Groups" section's heading on user admin page was visible to mods
2017-04-18 16:12:33 +08:00
Arpit Jalan 8dea70d354 Revert "FIX: User website allows new TLDs" 2017-04-18 13:18:51 +05:30
Rafael dos Santos Silva 4289dbe3e5 FIX: User website allows new TLDs 2017-04-18 00:30:37 -03:00
Robin Ward 1363988cd7 Support for an HTML builder that can create dynamic HTML 2017-04-17 17:32:55 -04:00
Sam 3ccd5eacb4 prefer multiline \A \z 2017-04-17 16:57:37 -04:00
Sam 86904e9cd6 FIX: better error handling for theme import 2017-04-17 16:55:53 -04:00
Sam 5e3a0846f7 FEATURE: allow themes to share color schemes 2017-04-17 15:56:24 -04:00
osamasayegh 3e048d686e The "Groups" section's heading on user admin page was visible to mods
Since moderators can't manage a user groups, they shouldn't see the Groups heading on the user admin page.

## Before:

![before](https://cloud.githubusercontent.com/assets/17474474/25099135/c0e1d5a4-23b3-11e7-95d1-8036bff057d4.png)


## After:

![after](https://cloud.githubusercontent.com/assets/17474474/25099130/c060a538-23b3-11e7-8428-602fc523e9e8.png)
2017-04-17 21:53:30 +03:00
jomaxro 7b708e5cf2 Disable browser auto-complete for messages 2017-04-17 14:24:09 -04:00
Sam b43d2e42f4 missing spots 2017-04-17 12:30:20 -04:00
Sam 81ebe853d1 missed a few spots 2017-04-17 12:05:23 -04:00
Sam 5dd752877e FEATURE: try adding some preload hints for chrome 2017-04-17 11:52:43 -04:00
jloh 5f47603b07
FIX: increase host_must_be_valid regex for .technology TLD
.technology is 11 chars long and wasn't being matched previously
2017-04-15 21:06:51 +10:00
Arpit Jalan 0954367bf4 FIX: send activation email when accepting invite if password is set 2017-04-15 14:59:50 +05:30
Guo Xiang Tan 04016f0dec Support Ruby 2.4. 2017-04-15 12:29:00 +08:00
cpradio 4dc4c5bebc FIX: Update auto_notification to also update the subscription state when replying if the current state is less than the state being requested 2017-04-14 15:44:42 -04:00
Sam ed2e62f845 correct environment handling for test mode 2017-04-14 14:00:46 -04:00
Sam 873a07a625 trigger a stylesheed update 2017-04-14 13:36:49 -04:00
Sam def7348777 FIX: display custom sections with default theme
also cleans up mechanism for previewing themes, cleans up naming,
gets rid of old janky "preview_style", secures local theme key
2017-04-14 13:35:12 -04:00
Arpit Jalan fe29fe71c5 FIX: embedding comments was broken 2017-04-14 08:14:22 +05:30
Sam 809fbb25ce FIX: blanking theme field was not properly removing it 2017-04-13 17:24:15 -04:00
Sam 9927489f4e FEATURE: auto focus text editor when editing themes 2017-04-13 16:21:46 -04:00
Sam 43e4fc03ef FIX: clicking on themes while editing left a blank screen 2017-04-13 15:49:46 -04:00
Sam 3f4f0b32a9 FIX: path wizard showing with no style 2017-04-13 15:22:39 -04:00
Sam 37d4dd4a4b use scss mode instead of css mode 2017-04-13 12:05:27 -04:00
Sam ee950b419f correct transitioning to theme CSS editing 2017-04-13 11:09:31 -04:00
Sam 679b6548e6 FIX: order child themes by name 2017-04-13 10:51:44 -04:00
Sam e61be7af13 FIX: improve dark theme styling in header for tags 2017-04-13 10:39:36 -04:00
Arpit Jalan ef093b1610 Merge pull request #4807 from techAPJ/email-token-social
FIX: confirm email token for user created via social login
2017-04-13 16:18:15 +05:30
Guo Xiang Tan 3d76fb9c2c FIX: Don't show category options for reports that can't be scoped to a category. 2017-04-13 17:10:55 +08:00
Arpit Jalan 7fb17b83c4 FIX: confirm email token for user created via social login 2017-04-13 14:15:32 +05:30
Guo Xiang Tan bda20cc44a FIX: Don't enqueue topic status update job if topic is deleted. 2017-04-13 12:02:35 +08:00
Guo Xiang Tan ee449b0dd5 Improve SSO verbose log when user record is invalid. 2017-04-13 11:39:26 +08:00
Guo Xiang Tan 72c16967e6 FIX: Check for reserved usernames before hitting DB. 2017-04-13 11:32:20 +08:00
Guo Xiang Tan 57788200ec REFACTOR: Add `User.reserved_username?`. 2017-04-13 10:44:26 +08:00
Neil Lalonde 07d596ea05 FIX: handle expanding quotes from deleted posts by rendering a trash icon 2017-04-12 16:48:47 -04:00
Neil Lalonde 2916b45666 multiplier should not have been changed 2017-04-12 14:48:30 -04:00
Neil Lalonde d34dd4ed4f FIX: pasting link into composer with a topic template will onebox the link after the template 2017-04-12 14:48:30 -04:00
Neil Lalonde 8395569b05 FIX: Topic.similar_to error when Search is not loaded 2017-04-12 14:48:30 -04:00
Sam d0fa8cda76 correct issue where no selected theme would force incorrect selection 2017-04-12 13:00:25 -04:00
Sam 7f2a80bbc8 correct theme selector expiry selection 2017-04-12 11:59:47 -04:00
Sam a7ed8a0310 correct theme importer to support embedded.scss 2017-04-12 11:30:16 -04:00
Sam a3e8c3cd7b FEATURE: Native theme support
This feature introduces the concept of themes. Themes are an evolution
of site customizations.

Themes introduce two very big conceptual changes:

- A theme may include other "child themes", children can include grand
children and so on.

- A theme may specify a color scheme

The change does away with the idea of "enabled" color schemes.

It also adds a bunch of big niceties like

- You can source a theme from a git repo

- History for themes is much improved

- You can only have a single enabled theme. Themes can be selected by
    users, if you opt for it.

On a technical level this change comes with a whole bunch of goodies

- All CSS is now compiled using a custom pipeline that uses libsass
    see /lib/stylesheet

- There is a single pipeline for css compilation (in the past we used
    one for customizations and another one for the rest of the app

- The stylesheet pipeline is now divorced of sprockets, there is no
   reliance on sprockets for CSS bundling

- CSS is generated with source maps everywhere (including themes) this
    makes debugging much easier

- Our "live reloader" is smarter and avoid a flash of unstyled content
   we run a file watcher in "puma" in dev so you no longer need to run
   rake autospec to watch for CSS changes
2017-04-12 10:53:49 -04:00
Dean Taylor 1a9afa976d FEATURE: Add AWS S3 EU (London) "eu-west-2" region 2017-04-12 10:38:17 -04:00
Arpit Jalan 30a8c5cca2 FIX: render emoji in topic title 2017-04-12 10:38:17 -04:00
Guo Xiang Tan 5cb64810cd FIX: Changing notification level in topic footer buttons was not updating timeline. 2017-04-12 14:54:03 +08:00
Guo Xiang Tan 7cb389a235 Add `DiscourseEvent` trigger when user's topic notification level changes. 2017-04-12 11:56:50 +08:00
Guo Xiang Tan 66a7b0c30b FIX: Add web hook `DiscourseEvent`s in initializer. 2017-04-12 11:55:49 +08:00
Neil Lalonde e5a50a3c98 FIX: rtl locale support for category box style 2017-04-11 15:04:27 -04:00
Arpit Jalan 82dfe4c5d5 FIX: disable browser autocomplete for change-owner modal 2017-04-11 20:43:30 +05:30
Arpit Jalan 8fb41bf5fb FIX: update timestamp when resending invite 2017-04-11 20:02:32 +05:30
Guo Xiang Tan 73180c8a19 FIX: Private message can be set to publish in the future. 2017-04-11 20:44:25 +08:00
Guo Xiang Tan aadf4805a5 FIX: Topic status update not being deleted once it has been executed. 2017-04-11 10:32:13 +08:00
Régis Hanol db77640634 FIX: grant first reply by email job was *brokenated* 2017-04-10 22:11:29 +02:00
Régis Hanol f0778c50bf UX: add href to badge title 2017-04-10 21:39:19 +02:00
Arpit Jalan b3761653b3 FIX: render emoji in title tag on topic page 2017-04-11 00:25:22 +05:30
Arpit Jalan 028eb8c05a FIX: render emoji in topic title 2017-04-10 23:36:30 +05:30
Neil Lalonde 3957540dd1 FIX: convert emoji to unicode in topic titles in emails 2017-04-10 13:15:25 -04:00
Sam Saffron 0013a23dc1 SECURITY: prefer render plain/html to render text where possible 2017-04-10 08:01:42 -04:00
Arpit Jalan e7c2f5fd96 UX: show check mark glyph on 'Dismiss New' button on mobile 2017-04-08 10:13:32 +05:30
Robin Ward 40cee37bcc FIX: Don't insert topic status messages unless the status changes 2017-04-07 17:10:43 -04:00
Robin Ward 28c59d754b FIX: Don't update `cooked` when a like is received. 2017-04-07 15:18:38 -04:00
Robin Ward 616e1dcd16 FIX: Topic Timeline was impossible to close if you used the back button 2017-04-07 14:37:05 -04:00
Robin Ward 397e850fba FIX: Allow `replaceState` to run on iOS.
Removes a test for unsupported versions.
2017-04-07 11:30:24 -04:00
Guo Xiang Tan 9663a74445 FIX: Ensure `username` param is valid in `NotificationsController`. 2017-04-07 17:32:52 +08:00
Guo Xiang Tan fad04aad6c Missing association. 2017-04-07 17:05:58 +08:00
Régis Hanol 93556bb950 Merge pull request #4793 from rcgordon/smtp-fast-rejection
Added an API to ask if an incoming email should be dropped at the SMTP level.
2017-04-07 09:59:52 +02:00
Guo Xiang Tan ae1d6e7421 Fix incorrect method usage. 2017-04-07 15:52:08 +08:00
Guo Xiang Tan 71501feaf3 Improve validation for `TopicStatusUpdate`. 2017-04-07 15:32:00 +08:00
Guo Xiang Tan cd59db5aa3 UX: Allow topic to be published to the same category when unlisted. 2017-04-07 15:32:00 +08:00
Guo Xiang Tan 690d2f4bd3 UX: Publish topic changes when topic is published. 2017-04-07 15:32:00 +08:00
Guo Xiang Tan 48a9860f07 FIX: Publish topic to a category should unlist it as well. 2017-04-07 13:58:52 +08:00
Neil Lalonde 708f65f740 FIX: web crawlers getting 404 on category pages 2017-04-06 14:52:06 -04:00
Ryan C. Gordon 888d1512ec Corrected indentation. 2017-04-06 01:49:34 -04:00
Guo Xiang Tan 8e794070d2 Fix incorrect method name. 2017-04-06 13:45:59 +08:00
Guo Xiang Tan 9bc6a60503 Merge pull request #4765 from ElTipejoLoco/show_tracked_topics_link
FEATURE: Add "Show tracked topics" to User Prefs
2017-04-06 12:34:10 +08:00
Guo Xiang Tan 0d67b507dc Merge pull request #4788 from davidtaylorhq/user_seen_event
Add a user_seen DiscourseEvent for plugins to hook into
2017-04-06 12:32:16 +08:00
Guo Xiang Tan e0e06c2992 Merge pull request #4794 from tgxworld/nuke_old_auto_close_jobs
FIX: Add onceoff job to remove old auto close topic sidekiq jobs.
2017-04-06 12:29:42 +08:00
Arpit Jalan f960505359 FIX: translate badge metadata title 2017-04-06 09:57:52 +05:30
David Rodríguez 934bff43d9 FIX: Copy post actions when moving a topic. 2017-04-06 12:16:22 +08:00
Aashaka Shah 402eaaa773 FEATURE: add og tags to metadata in individual badges page 2017-04-06 09:32:53 +05:30
Guo Xiang Tan 5943543ec3 FIX: Improve checks for non-human users. 2017-04-06 11:29:34 +08:00
cpradio aeb169bd0e FIX: Do not show User Cannot See Mention dialog when crafting a new topic or a new message
Use the model/composer topic.id to determine what users cannot be mentioned and what message to show as a warning.
2017-04-06 11:20:30 +08:00
Ryan C. Gordon c51af13338 smtp_should_reject API: use better approach to find user email. 2017-04-05 23:10:36 -04:00
Ryan C. Gordon a51c191a66 Make Email::Receiver.check_address() into a class method. 2017-04-05 23:10:36 -04:00
Ryan C. Gordon e15d11df18 Added an API to ask if an incoming email should be dropped at the SMTP level.
This lets an SMTP server optionally decide if it should reject a mail without
passing it on to Discourse at all, possibly before even reading the
email's payload, to prevent spam-induced backscatter and save resources.

This just does the bare minimum sanity checking that could prevent obvious
backscatter. For legit errors from legit users, Discourse will still send a
much more pleasant reply email.
2017-04-05 23:10:36 -04:00
Guo Xiang Tan e8eaffbd72 FIX: Add onceoff job to remove old auto close topic sidekiq jobs. 2017-04-06 10:52:13 +08:00
Robin Ward 40ab2e5667 FEATURE: Let users update their emails before confirming
This allows users who entered a typo or invalid email address when
signing up an opportunity to fix it and resending the confirmation
email to that address.
2017-04-05 16:44:49 -04:00
Régis Hanol d1c79372d7 fix permalinks serializer with subfolder setups 2017-04-05 18:45:01 +02:00
Sam Saffron cd39049262 SECURITY: do not send push notifications to suspended users 2017-04-05 08:28:24 -04:00
Bianca Nenciu 9065df76ad FEATURE: Change name from admin page.
https://github.com/discourse/discourse/pull/4770
2017-04-05 17:40:27 +08:00
Arpit Jalan c43c78cb8a FIX: do not add order param to user list unless required 2017-04-05 13:57:34 +05:30
Robin Ward 3839206317 FIX: Return JSON errors for `by-external` if JSON requested 2017-04-04 16:22:14 -04:00
Robin Ward 17f2974d0a SECURITY: Confirm new administrator accounts via email 2017-04-04 15:59:01 -04:00
Guo Xiang Tan a248ebde3c Allow custom empty label for `category-chooser`. 2017-04-04 17:19:55 +08:00
Guo Xiang Tan 69661be500 FIX: Don't raise an error if `TopicStatusUpdate` has been deleted. 2017-04-04 14:29:47 +08:00
Guo Xiang Tan 406d721f11 Fix `NilClass` error in `UsersController`. 2017-04-04 14:17:45 +08:00
Guo Xiang Tan aca972c08b FIX: Skip validations when updating group mentions. 2017-04-04 14:13:18 +08:00
Guo Xiang Tan 7f1c474e5b FIX: Selections getting deselected on FireFox. 2017-04-04 13:06:07 +08:00
Guo Xiang Tan ad44d2a400 Merge pull request #4790 from tgxworld/add_publish_to_topic_status_update
FEATURE: Allow admins to schedule a topic to be published in the future.
2017-04-04 11:18:53 +08:00
Guo Xiang Tan f4758a4c4d FEATURE: Allow admins to schedule a topic to be published in the future. 2017-04-04 11:16:05 +08:00
Robin Ward ebe232da47 Weigh staff votes more for New User of the Month badges 2017-04-03 16:52:31 -04:00
Robin Ward 0829671963 FIX: Nested quotes weren't rendered properly with BBCode 2017-04-03 14:38:30 -04:00
Robin Ward a13a8dc96c FIX: Safeguard to not award NewUserOfTheMonth if it hasn't been a month 2017-04-03 13:26:51 -04:00
Robin Ward 3d64f33d40 Require at least two likes to get the "New User of the Month" badge 2017-04-03 13:03:28 -04:00
Régis Hanol 15268657f4 Requiring it once is more than enough ;) 2017-04-03 12:12:36 +02:00
Régis Hanol 916ba945fe Merge pull request #4787 from jomaxro/patch-1
Mobile CSS for deleted topics is inconsistent with desktop CSS
2017-04-03 10:13:06 +02:00
Guo Xiang Tan 9ab5f17610 FIX: Broekn translation on `topic-status-info` component. 2017-04-03 10:31:40 +08:00
Guo Xiang Tan 5cf75c67df FIX: Callback `undefined` error when topic has been deleted. 2017-04-03 09:06:15 +08:00
Jeff Atwood 3b64aeaf21 loosen new user of the month criteria slightly 2017-03-31 16:33:50 -07:00
David Taylor 03373a0e84 Add a user_seen DiscourseEvent for plugins to hook into 2017-03-31 23:30:59 +01:00
Robin Ward e4b1376146 Change New User of the Month Badge to use trust level rather than age 2017-03-31 16:56:58 -04:00
Robin Ward a8d3779f0b Update New User of the Month badge to require 4 posts in 2 topics 2017-03-31 16:52:00 -04:00
Robin Ward fc7fa4c0ad Rename "Rookie of the Month" to "New User of the Month" 2017-03-31 16:30:30 -04:00
Robin Ward e6f6bd34d8 Send the user a notice when they've received rookie of the month 2017-03-31 15:06:31 -04:00
Robin Ward 893e93dfbe New badge, Rookie of the Month, for two new high quality users. 2017-03-31 15:06:31 -04:00
Robin Ward f42b6054e6 FIX: Class names should be dasherized, not underscored 2017-03-31 13:17:12 -04:00
Robin Ward 62be121328 FIX: On long browsers, you could get a double title 2017-03-31 13:00:52 -04:00
jomaxro d5d5cfc2f4 Mobile CSS for deleted topics is inconsistent
with desktop css - mobile targets a less specific class
2017-03-31 12:48:32 -04:00
Arpit Jalan 2418daeb63 FIX: check if post exists in topic 2017-03-31 18:02:14 +05:30
Guo Xiang Tan 7690cc6ca5 UX: Don't try to figure out root domain. 2017-03-31 17:24:24 +08:00
Guo Xiang Tan 04edbea693 UX: Remove width on `.auto-update-input`. 2017-03-31 17:13:50 +08:00
Guo Xiang Tan 78d87a79eb UX: Improve `.modal-header` style on mobile. 2017-03-31 16:47:49 +08:00
Guo Xiang Tan 0bbad5040a `topic-status-info` component wasn't updated when topic is closed/opened. 2017-03-31 15:58:26 +08:00
Guo Xiang Tan b6e9871b4b Update `Topic#closed` client side when closing/opening a topic temporarily. 2017-03-31 15:05:00 +08:00
Guo Xiang Tan ed577fbff8 FEATURE: Pause a topic instead of permanently closing when flag threshold is reached. 2017-03-31 14:35:05 +08:00
Guo Xiang Tan 2fa82ba4ff UX: Update copy for topic status update UI. 2017-03-31 12:06:55 +08:00
Guo Xiang Tan beba481bc8 UX: Update copy to remove a topic status update. 2017-03-31 11:54:20 +08:00
Guo Xiang Tan 7cf2528f18 UX: Copy changes for auto topic status update. 2017-03-31 11:45:10 +08:00
Guo Xiang Tan 34b7bee568 FEATURE: Allow admin to auto reopen at topic.
* This commit also introduces a `TopicStatusUpdate`
  model to support other forms of deferred topic
  status update in the future.
2017-03-31 11:14:18 +08:00
jomaxro 6fb255957c Move watching-first-post to notification-options
Also remove extra classes from scss, made targeting watching-first-post different from all other notification states
2017-03-30 18:37:51 -04:00
jomaxro 495c11e633 Remove watching-first-post from user SCSS
Move to notification-options.scss
2017-03-30 18:33:24 -04:00
Robin Ward 14410b71fb Convert server side paths to use `/u/` 2017-03-30 10:23:24 -04:00
Robin Ward 45a257815a Convert front end paths from `/users/` to `/u/` 2017-03-30 10:23:24 -04:00
Robin Ward 6b976433c9 Support for both `/users/` and `/u/` paths 2017-03-30 10:23:24 -04:00
Guo Xiang Tan 99abbc2e2d UX: Order custom emojis by name. 2017-03-30 13:24:18 +08:00
Guo Xiang Tan a818fa9831 FIX: Show stats of the last 30 days be default for admin reports.
* `1.month.ago + 1.month` uses the calendar month for calculations
  such that `1.month.ago` from the 30th of March 2017 will give
  us the 28th of February 2017. Adding one month ahead from
  28th February 2017 will be 28th of March 2017.
2017-03-30 09:48:10 +08:00
James Kiesel 47182d3441 Remove stray reference to additionalPanels 2017-03-30 08:16:00 +09:00
Robin Ward 16087009a9 Merge pull request #4783 from bekicot/allow-to-order-search-results-by-the-topic-creation-date
Allow to order search results by the topic creation date
2017-03-29 16:52:09 -04:00
Neil Lalonde 8742f5176f FIX: tags and topic links rendered outside of page header 2017-03-29 16:48:53 -04:00
Yana Agun Siswanto 47c1cc95dd Refactor `setSearchTerm`, to be reused on `noSortQ` 2017-03-30 03:22:49 +07:00
Yana Agun Siswanto cd2d2f16e5 Allow to order search results by the topic creation date
based on: https://meta.discourse.org/t/allow-to-order-search-results-by-the-topic-creation-date/38544
2017-03-30 01:18:38 +07:00
Robin Ward 3914f746b8 FIX: Missing semicolon 2017-03-29 13:03:35 -04:00
Robin Ward b240437b6f Merge pull request #4777 from gdpelican/add-header-panels
Allow plugins to add panels to header more easily
2017-03-29 12:53:08 -04:00
James Kiesel 3b55ceffb3 Use local var for additionalPanels 2017-03-29 08:52:50 +09:00
Robin Ward 86f11955cf FIX: Clicking on the title was doubling up the title 2017-03-28 17:05:07 -04:00
Robin Ward f3540332a8 FIX: Topic title wasn't showing properly when entering lower in topics 2017-03-28 16:28:26 -04:00
Arpit Jalan 322ed7124e UX: add a link to bulk invite howto 2017-03-28 23:44:13 +05:30
Arpit Jalan 4812417192 FIX: do not add user to group based on email domain unless email is confirmed 2017-03-28 15:02:40 +05:30
Guo Xiang Tan bace6af404 Nuke extra whitespace. 2017-03-28 16:50:35 +08:00
Guo Xiang Tan 874d151c05 REFACTOR: Allow `radio-button` component to be disabled. 2017-03-28 16:45:54 +08:00
Arpit Jalan 8bf12502bd Merge pull request #4780 from techAPJ/send-statistics
FEATURE: Send anonymized usage statistics to Discourse if "Discourse Hub" can't reach the site
2017-03-28 10:02:05 +05:30
Arpit Jalan f3cd5f61c5 FEATURE: Send anonymized usage statistics to Discourse if Discourse Hub can't reach the site 2017-03-28 09:07:23 +05:30
Robin Ward 1d478a97db FIX: Email Previewing was not showing in Firefox 2017-03-27 14:41:51 -04:00
Neil Lalonde 20400cb33f add category colour to left side of box style 2017-03-27 14:40:59 -04:00
Neil Lalonde 899a747e68 FIX: use consistent heading style in the category box styles 2017-03-27 14:11:01 -04:00
Neil Lalonde 249eedd45c categories page on mobile uses categories with featured topics 2017-03-27 13:55:39 -04:00
Neil Lalonde 6e847bb297 FEATURE: mobile support for row and box category styles 2017-03-27 13:55:39 -04:00
Robin Ward 27a73c73f9 FIX: Error when calculating geometric mean of 0 for read timings 2017-03-27 12:45:34 -04:00
Robin Ward 243b5756ee Adds a keyboard shortcut (shift+u) for jumping back to the last read post 2017-03-27 11:23:06 -04:00
Robin Ward 60975fcc18 Remove the "unread" timeline section 2017-03-27 11:07:27 -04:00
Robin Ward 2fedf1c668 FIX: jQuery include was incorrect for `finish-installation` 2017-03-27 10:29:25 -04:00
Arpit Jalan 3378e2d49f FIX: update topic fancy title when updating category name 2017-03-26 12:29:53 +05:30
James Kiesel c99883cf65 SEMICOLONS ;.; 2017-03-25 21:44:28 +13:00
James Kiesel a4127a8f71 Add addAdditionalHeader widget to pluginApi 2017-03-25 21:33:55 +13:00
Neil Lalonde 0083602ddd Revert "FEATURE: mobile support for row and box category styles" 2017-03-25 00:38:56 -04:00
Guo Xiang Tan 7c17966171 FEATURE: Include email in `User` webhook.
https://meta.discourse.org/t/should-the-email-address-of-a-new-user-be-included-in-the-webhook/59255
2017-03-25 08:23:01 +08:00
Robin Ward 80edb4cebc FIX: Clciking the home logo wasn't refreshing categories views 2017-03-24 16:30:00 -04:00
Robin Ward 276d139624 Experimental: Show a blue bar for unread ahead of you 2017-03-24 11:58:50 -07:00
Robin Ward 6875007366 Respect modifier keys when clicking on links 2017-03-24 11:35:16 -07:00
Neil Lalonde 708efad96d FIX: links in hamburger menu on subfolder installs 2017-03-24 10:31:17 -04:00
Régis Hanol 747f4812e4 fix custom emoji support when using subfolder 2017-03-24 02:09:39 +01:00
Régis Hanol 823e50b099 make eslint happy 2017-03-24 01:27:15 +01:00
Régis Hanol 5d9cba5581 quotes should keep new lines 2017-03-24 01:07:32 +01:00
James Kiesel 9f969b402e More stylistic fixes 2017-03-24 09:56:54 +13:00
James Kiesel 569785c555 Add semicolon 2017-03-24 09:48:51 +13:00
James Kiesel d073f582eb Allow plugins to add panels to header more easily 2017-03-24 09:19:25 +13:00
Robin Ward 65081a9193 FIX: Issue with double title showing up 2017-03-23 16:16:50 -04:00
Neil Lalonde 33ed064e59 FEATURE: mobile support for row and box category styles 2017-03-23 16:03:27 -04:00
Robin Ward cacf48fdb5 Experimental: Try adding a darker color in the timeline for unread 2017-03-23 15:49:47 -04:00
Robin Ward d161422002 UX: Be more optimistic about showing topic titles while entering topics 2017-03-23 13:53:49 -04:00
Robin Ward 6f230945c2 UX: Clear the header when navigating to a new topic 2017-03-23 13:19:59 -04:00
Neil Lalonde 8f436bf736 replace gets with arguments 2017-03-23 12:42:37 -04:00
Guo Xiang Tan 3ef82bb32c SECURITY: CSRF vulnerabilities in `Admin::BackupsController`. 2017-03-23 10:29:35 +08:00
Neil Lalonde 11ce73b8ed FEATURE: category setting for default top period 2017-03-22 16:54:18 -04:00
Robin Ward 0c46f51412 Use unminified resize to make debugging easier 2017-03-22 16:39:18 -04:00
Robin Ward f97a6598aa Use the same jQuery in prod and dev, avoid minimizing twice 2017-03-22 15:48:37 -04:00
Sam 8e5e3b5af8 FIX: sso provider require return_sso_url 2017-03-22 09:08:38 -04:00
Régis Hanol 67eb754c3c remove duplicate emoji translation 2017-03-22 12:07:17 +01:00
Régis Hanol ccd4832726 Add 'slight_smile' emoji translations 2017-03-22 10:17:10 +01:00
Arpit Jalan 786fd6bbd2 Merge pull request #4774 from techAPJ/email-prefix
FIX: use email prefix only in subject
2017-03-22 14:18:50 +05:30
Arpit Jalan 295cf8839e FIX: better error message when invited user already exists 2017-03-22 13:55:28 +05:30
Guo Xiang Tan e8fc8f0bb6 Update annotations. 2017-03-22 14:26:53 +08:00
Robin Ward 1cd14ef3aa FIX: Site Settings weirdness with back button 2017-03-21 16:13:19 -04:00
Robin Ward 874e8900af Display email address in SSO error message. 2017-03-21 15:37:46 -04:00
Robin Ward aeaf5075bf Custom errors for when Email is invalid via SSO 2017-03-21 15:23:38 -04:00
Robin Ward 52d78294cc Render a layout when there's an SSO error 2017-03-21 15:23:38 -04:00
Arpit Jalan 7f207fd411 Merge pull request #4771 from techAPJ/user-summary-tab
FEATURE: make summary as first tab on user page
2017-03-21 23:14:07 +05:30
Arpit Jalan ec2a66d1f0 FEATURE: make summary as first tab on user page
https://meta.discourse.org/t/custom-user-fields-show-on-activity-but-not-summary-page/59196/3?u=techapj
2017-03-21 23:12:28 +05:30
Neil Lalonde 2836d548fb Category boxes with feature topics will show pins and locks as bullet for pinned and closed/archived topics 2017-03-21 12:23:19 -04:00
Arpit Jalan 1853a4852c FIX: use email prefix only in subject 2017-03-21 20:29:57 +05:30
Arpit Jalan df246c79b6 FEATURE: add user profile fields in user list export 2017-03-21 15:51:52 +05:30
Arpit Jalan 82c0f5f587 Merge pull request #4767 from techAPJ/activate-account
FIX: send activation email if user have unconfirmed email address
2017-03-21 09:44:23 +05:30
Arpit Jalan 7c3ae50dcd FIX: send activation email if user have unconfirmed email 2017-03-21 09:41:50 +05:30
Guo Xiang Tan 0cfc4db868 Merge pull request #4769 from gsambrotta/admin-users-list-style
add style to show admin/users header as clickable
2017-03-21 10:07:05 +08:00
Sam Saffron b94c7b4902 missing disposition 2017-03-20 17:07:32 -04:00
Sam 652b2d7199 remove redundent header setting 2017-03-20 16:08:18 -04:00
Sam c106ca6778 FEATURE: fallback asset path for multi host setups 2017-03-20 15:59:17 -04:00
Neil Lalonde 9c03456e75 Category description in sub-category boxes is truncated after height 6em, customizable with CSS 2017-03-20 15:43:49 -04:00
Neil Lalonde e96d875bee FIX: show lock icons for secured categories in boxes views 2017-03-20 14:50:52 -04:00
Neil Lalonde 0238a076f3 Change category-boxes so it's easier to customize with CSS 2017-03-20 14:50:52 -04:00
Neil Lalonde 85280b0bc8 FIX: links in category description inside subcategory boxes have too much padding 2017-03-20 14:50:52 -04:00
giorgia b8ee2cabcf add style to make tabs clickable 2017-03-20 15:23:00 +01:00
giorgia c3e8497636 remove tooltip on hover on desktop 2017-03-20 13:26:36 +01:00
Arpit Jalan 521c88fe58 FIX: enqueue activation email for invited user that has password set 2017-03-20 17:13:21 +05:30
Guo Xiang Tan 1d4993a185 FIX: Sync user's notification channel before preloaded current user data.
This is to fix the problem where a newly created user would not
receive live updates for the first notification if the notification
is published before the client has subscribed to the channel.
2017-03-20 17:17:21 +08:00
Guo Xiang Tan 32d8447838 REFACTOR: Don't lookup container for certain objects if user is not signed in. 2017-03-20 15:49:36 +08:00
Guo Xiang Tan ddc8abf9d8 Fix broken optimize image command. 2017-03-20 15:07:38 +08:00
Guo Xiang Tan 6057e17ae7 Fix weird test failure. 2017-03-20 12:06:37 +08:00
Guo Xiang Tan a567e6bec9 FIX: Publish notification state in `after_commit` hook.
`after_save` is still wrapped in a transaction and
we were getting intermittent failures with notifications
state not being published.
2017-03-20 11:38:34 +08:00
Neil Lalonde 9ae8813a53 FIX: admin user page should show count of all posts, including private messages, so admins can delete them. This bug was making it impossible to delete users. 2017-03-17 17:01:45 -04:00
Robin Ward f5f54c1b77 Merge pull request #4764 from tgxworld/nuke_backticks
FIX: Don't use backticks that take in inputs.
2017-03-17 15:40:23 -04:00
Neil Lalonde 0991acf103 make it easier to customize category boxes with featured topics 2017-03-17 12:33:26 -04:00
ElTipejoLoco e234a7821d Add "Show tracked topics" to User Preferences
Does what it says on the tin. Minor clean-up.
2017-03-17 08:05:21 -05:00
Régis Hanol e600dca268 Merge pull request #4763 from vvanpo/fork-master
JSON API parsing error on CSRF exception: single quotes in ['BAD CSRF'] is invalid JSON
2017-03-17 09:19:10 +01:00
Guo Xiang Tan e7c972ac89 FIX: Don't use backticks that take in inputs. 2017-03-17 15:33:51 +08:00
Guo Xiang Tan 566f367fc3 FIX: Don't migrate custom emojis that are no longer valid.
* Warn about failed migration in logs.
2017-03-17 08:28:24 +08:00
Victor van Poppelen 9e60f9f093 JSON API parsing error on CSRF exception: single quotes in ['BAD CSRF'] is invalid JSON:
https://meta.discourse.org/t/json-api-parsing-error-single-quotes-used-for-errors-like-bad-csrf/58869
2017-03-16 16:47:18 -07:00
Neil Lalonde ad8a579c79 UX: banner enabled/disabled posts should be small posts, not full-size posts 2017-03-16 17:31:37 -04:00
Robin Ward 1957d12670 SECURITY: Don't use backticks for exporting your archive 2017-03-16 16:24:59 -04:00
Neil Lalonde 22f197c153 FEATURE: subcategory list style: boxes with featured topics 2017-03-16 11:54:45 -04:00
Sam 2c952e1981 Merge pull request #4760 from nbianca/fix_topic_title
Fixes duplicated title in header after edit
2017-03-16 11:49:45 -04:00
Bianca Nenciu f8a31d927f Fixes duplicated topic title in header after edit. 2017-03-16 17:34:39 +02:00
Robin Ward fd591257a8 Merge pull request #4759 from kennym/support-ports-for-ip-addresses-in-embedding
FIX: Allow ports for embed host IPs
2017-03-16 11:23:42 -04:00
Guo Xiang Tan 9f299b6842 Use `after_commit` since `after_save` runs within the transaction as well. 2017-03-16 16:02:34 +08:00
Guo Xiang Tan 299b92b4d7 Fix broken user created event trigger. 2017-03-16 15:36:27 +08:00
Guo Xiang Tan 5169ef8814 Fix broken specs. 2017-03-16 15:05:28 +08:00
Guo Xiang Tan bf78c228f4 FIX: User created web hook being enqueued before record has been saved.
* Improve web hook tests as well.
2017-03-16 14:44:09 +08:00
Guo Xiang Tan bb85795934 FIX: Leave group membership button not updating.
https://meta.discourse.org/t/leave-group-button-on-groups-page-doesnt-give-any-feedback/57359/4
2017-03-16 11:33:55 +08:00
Guo Xiang Tan 65c000ad74 FEATURE: Track views on user profile card as profile views. 2017-03-16 10:59:08 +08:00
Guo Xiang Tan 0a87547cbc Fix broken tests. 2017-03-16 10:22:15 +08:00
Erick Guan cfbfea0596 FEATURE: Allow easier customization to the web hook event serialization. 2017-03-16 10:09:05 +08:00
Guo Xiang Tan bbc85e1e29 Merge pull request #4750 from discourse/group_login_registration_flow
FEATURE: Redirect to groups page and apply group actions upon login/s…
2017-03-16 09:50:56 +08:00