73a4a05c5b
make eslint happy again
2017-06-23 16:06:32 +02:00
a9c0df0b58
FIX: always try to convert PNG to JPG when pasting an image
2017-06-23 12:13:48 +02:00
bfd892bbbc
better responsive layout for new topic btn
2017-06-23 01:52:09 -07:00
8c9e24e9b0
override desktop styles for mobile topic admin
2017-06-23 00:59:53 -07:00
6cc174ca82
PERF: Fetch users in batches in grant anniversary badge job.
2017-06-23 16:54:35 +09:00
c1c778f1e5
move mobile topic admin button to bottom
2017-06-23 00:36:50 -07:00
cbedc1a2ca
FIX: Notification backdrop does not display when user menu has been toggled.
...
https://meta.discourse.org/t/first-pm-spotlight-does-not-work-with-welcome-message-delay/64927/16?u=tgxworld
2017-06-23 11:35:06 +09:00
5fda2b84e1
FIX: If the progress bar is docked, set the progress to 100%
2017-06-22 14:43:15 -04:00
b22df9f166
FIX: Double header rendering issues, redux
2017-06-22 12:50:46 -04:00
6e5c59e5ec
FIX: image orientation wasn't properly working
2017-06-22 16:53:49 +02:00
a916f6b0c8
remove some warnings with already declared constants
2017-06-22 12:55:58 +02:00
2e7753c27f
User 'FileHelper.is_image?' to check wether a link is poiting to an image
2017-06-22 12:54:42 +02:00
80e348d226
PERF: Speed up slow tests in our test suite.
...
Before
```
Finished in 7 minutes 23 seconds (files took 4.15 seconds to load)
7145 examples, 0 failures, 10 pending
```
After
```
Finished in 6 minutes 12 seconds (files took 4.41 seconds to load)
7145 examples, 0 failures, 10 pending
```
2017-06-22 11:23:31 +09:00
1a02f5154f
FIX: Dirty keys should become to a widget, not global
2017-06-21 14:27:08 -04:00
287cb4bfc5
FEATURE: Allow truncated group posts to be expanded
2017-06-21 12:56:38 -04:00
32756060bb
REFACTOR: Remove unused component
2017-06-21 12:32:56 -04:00
d09bed0d76
FIX: Some stream items don't have post_id, so expand by topic id / post number
2017-06-21 12:27:39 -04:00
4c98bd9d5f
FIX: Can't update status_type of topic timers.
...
https://meta.discourse.org/t/topic-timers-internal-error-500/64805
2017-06-21 15:31:15 +09:00
dd85c1098b
Remove comment that is no longer valid.
2017-06-21 14:10:30 +09:00
0dd1d736c8
user stream UI should match time color
2017-06-20 17:19:53 -07:00
a289ae67e1
FEATURE: Expand truncated posts in the user stream
2017-06-20 15:45:41 -04:00
ae7734707e
REFACTOR: Merge different templates from rendering user stream items
2017-06-20 15:45:41 -04:00
fa35137d3a
PERF: Reduce allocations in `Emoji.unicode_replacements`.
...
```
MemoryProfiler.report { Emoji.unicode_replacements }.pretty_print
```
Before:
```
Total allocated: 2032131 bytes (30219 objects)
Total retained: 798059 bytes (10734 objects)
allocated memory by gem
-----------------------------------
1270762 discourse/app
690149 2.4.1/lib
48764 activesupport-4.2.8
11405 bootsnap-1.0.0
5266 logster-1.2.7
2473 hiredis-0.6.1
2056 redis-3.3.3
840 discourse/lib
240 activerecord-4.2.8
176 thread_safe-0.3.6
```
After:
```
Total allocated: 1715713 bytes (22449 objects)
Total retained: 797985 bytes (10737 objects)
allocated memory by gem
-----------------------------------
957250 discourse/app
690028 2.4.1/lib
48764 activesupport-4.2.8
11445 bootsnap-1.0.0
2745 hiredis-0.6.1
2624 redis-3.3.3
1473 logster-1.2.7
928 discourse/lib
280 activerecord-4.2.8
176 thread_safe-0.3.6
```
2017-06-20 13:50:37 +09:00
40ef5c4f14
PERF: Reduce memory allocation by `Emoji.unicode_replacements`.
...
Calling `Emoji.tonable_emojis` fetches from the cache but creates
a giant array each time it is called.
```
MemoryProfiler.report { Emoji.unicode_replacements }.pretty_print
```
Before:
```
Total allocated: 16560770 bytes (246364 objects)
Total retained: 784793 bytes (10624 objects)
allocated memory by gem
-----------------------------------
10224581 activesupport-4.2.8
3504241 hiredis-0.6.1
1449466 discourse/app
679314 2.4.1/lib
419592 discourse/lib
226720 redis-3.3.3
56680 activerecord-4.2.8
176 thread_safe-0.3.6
```
After:
```
Total allocated: 2127703 bytes (30556 objects)
Total retained: 798099 bytes (10735 objects)
allocated memory by gem
-----------------------------------
1270762 discourse/app
690149 2.4.1/lib
106977 bootsnap-1.0.0
48764 activesupport-4.2.8
5266 logster-1.2.7
2473 hiredis-0.6.1
2056 redis-3.3.3
840 discourse/lib
240 activerecord-4.2.8
176 thread_safe-0.3.6
```
2017-06-20 13:10:44 +09:00
394efb3290
FIX: Docking of progress component on iOS was a bit off
2017-06-19 15:53:51 -04:00
14256e11e7
FIX: topic list wrapping under category list on some screens
2017-06-19 15:23:32 -04:00
34126eb9e0
optimize 'hide help button' code
2017-06-19 22:20:09 +05:30
2bf2d506bf
UX: hide help button after click
2017-06-19 16:27:31 +05:30
ee1f3a4b25
UX: make font size consistent on password reset modal
2017-06-19 16:09:29 +05:30
74e6717b40
FEATURE: offer help on forgot password modal
2017-06-19 14:05:45 +05:30
4d62f41fbc
RTL digest emails
...
Allows RTL digest emails.
For this to work, I have done the following major additions:
1- adding appropriate direction to body and tables
2- making text-direction compatible with rtl
3- making float, padding, and margin tags compatible with rtl
2017-06-16 15:20:20 +04:30
77e886ec90
UX: move optional to the description text for the password field
2017-06-16 15:32:15 +05:30
d82dbd565b
FIX: Remove dependency on `rest-client`.
2017-06-16 09:42:41 +09:00
b5ec241716
FIX: Validate interpolation keys used in translation overrides.
...
https://meta.discourse.org/t/discobot-translation-missing-error/64429/6?u=tgxworld
2017-06-16 08:54:48 +09:00
6ab4692431
FEATURE: Add a user's primary group class name to the body tag
2017-06-15 14:25:39 -04:00
cc525b1a8d
Upgrade QUnit to latest version
2017-06-15 10:12:07 -04:00
8ae445766f
Upgrade Ember to 2.13
2017-06-15 10:12:07 -04:00
b5249fb4ca
FIX: Send request membership PM to last 5 active group owner.
2017-06-15 11:37:09 +08:00
b98a930364
Merge pull request #4896 from dmacjam/multiple-tags-logical-and-search
...
FEATURE: Advanced search supports logical AND of multiple tags
2017-06-14 14:39:23 -04:00
d6c63cc5b2
FIX: user's default group should only be set once
...
Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address.
Previously we were doing this everytime we'd save a user record 🤷
2017-06-14 19:20:18 +02:00
353d059133
Explains sort/reverse of emoji replacements
2017-06-14 17:54:52 +02:00
93778500c3
Merge pull request #4929 from jjaffeux/fixes-emojits-not-getting-converted
...
Improves native emoji conversion
2017-06-14 11:44:32 -04:00
95e1843d33
Improves native emoji conversion
2017-06-14 17:42:52 +02:00
31b8477d8b
use obj.prop syntax rather than obj[prop] syntax
2017-06-14 17:08:42 +02:00
f77e6c8fc6
Merge pull request #4928 from jjaffeux/transform-native-emojis-to-names
...
Transforms native emojis to valid names
2017-06-14 15:43:09 +02:00
ab6086bce9
Transforms native skin toned emojis to valid names
2017-06-14 15:35:37 +02:00
04e175bc06
Merge pull request #4925 from jjaffeux/adds-tones-to-clear-cache
...
Makes sure we clear tonable_emojis cache
2017-06-14 14:56:41 +02:00
1ceb64500f
Merge pull request #4926 from jjaffeux/fixes-mouse-three
...
Uses computer_mouse as base name
2017-06-14 14:55:48 +02:00
df75df7169
missing semicolon
2017-06-14 14:47:53 +02:00
fa508042ff
Makes sure we clear tonable_emojis cache
2017-06-14 11:11:02 +02:00
252c811dae
Uses computer_mouse as base name
2017-06-14 11:10:09 +02:00
f943efe1a9
remove use of soon-to-be-deprecated 'Discourse.SiteSettings' (cc @eviltrout)
2017-06-14 10:02:13 +02:00
493ab9d10e
Merge pull request #4923 from jjaffeux/fixes-automobile-emoji-not-displayed
...
Fixes automobile being an alias now
2017-06-14 09:25:10 +02:00
2fdf9068eb
FIX: Create notification for group users when group has been invited.
...
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509
2017-06-14 14:53:49 +09:00
03f3612884
Fixes automobile being an alias now
2017-06-14 07:50:36 +02:00
867cefc492
Ember.K was deprecated, so let's remove it.
2017-06-13 15:59:48 -04:00
74858fd450
FIX: Don't show emoji selector when ending a line with a colon
2017-06-13 14:25:31 -04:00
299339a373
Fixes emoji name to code missing tones
2017-06-13 14:10:26 -04:00
13f89a53a3
FIX: Autocomplete wasn't showing up for PM user selection
2017-06-13 13:23:27 -04:00
34996b4eff
FIX: show invite validation error message in response
2017-06-13 22:41:53 +05:30
826f332766
Merge pull request #4901 from jjaffeux/emoji-5.0
...
Emoji next
2017-06-13 11:12:41 -04:00
5d63a7f4a6
FIX: pull hotlinked images even when they have no extension
2017-06-13 13:27:05 +02:00
a5d3abc9b6
FIX: Create group membership request on behalf of user.
2017-06-13 17:49:21 +09:00
c5caa9cf71
Revert "FIX: Disable request membership button if user does not have sufficient trust level."
...
This reverts commit 5f441a2614
2017-06-13 17:49:21 +09:00
baf635c06e
UX: better accept invite page on mobile
2017-06-13 07:27:22 +05:30
5f6c859744
missing semicolon
2017-06-12 23:01:38 +02:00
54e8fb0d89
FEATURE: new 'allow_staff_to_upload_any_file_in_pm' site setting
2017-06-12 22:41:29 +02:00
16475bae89
padding below suggested topics on mobile
2017-06-12 15:46:10 -04:00
2ff850d446
FIX: If forcing a refresh, don't return a onebox preview
2017-06-12 14:05:59 -04:00
0b41046238
don't force SiteSetting.title into meta title tag
2017-06-12 13:50:50 -04:00
bd70656b90
FIX: Oneboxing root domains could stop previewing
2017-06-12 12:13:29 -04:00
b9c94aa234
FEATURE: add required user fields to invite accept form
...
UX: make "accept invitation" page consistent with sign up modal
2017-06-12 20:43:07 +05:30
9b8bf9c18c
reverting add readonly to site settings
...
see this commit for more details:
2ffddfb32c (commitcomment-22480952)
2017-06-12 06:53:57 -06:00
eab3562864
Merge pull request #4905 from tgxworld/strip-zero-width-chars-from-search-term
...
FIX: Strip zero-width characters from search terms.
2017-06-12 18:01:02 +09:00
5994c85ea9
FIX: Raise the right error when email params is missing.
2017-06-12 17:48:32 +09:00
e888369f51
UX: Don't send emails for discobot notifications.
2017-06-12 17:00:27 +09:00
6e37f09b19
UX: add email to '/email/unsubscribed' page
2017-06-10 09:51:12 +05:30
2ffddfb32c
add Enable read-only to Settings page
2017-06-09 16:07:02 -06:00
5ff986129a
copyedit to unsubscribe email
2017-06-09 00:27:24 -07:00
1c0bbcd580
UX: show user email when unsubscribing
2017-06-09 09:20:24 +05:30
8e2e962b1a
FIX: Replace `/my/` URLs before fixing the prefix
2017-06-08 16:21:54 -04:00
d92c938491
FIX: Don't raise an error cleaning up uploads if a path is nil
2017-06-08 14:31:58 -04:00
038454bde2
FIX: always confirm emails when SSO says so
2017-06-08 01:05:33 +02:00
e8f0771dc9
FIX: the 'clean_up_uploads' jobs would delete images used in site settings
...
when they were entered using absolute URLs, with the CDN or simple a different format than the one used in the database
2017-06-07 22:53:15 +02:00
54bb2a6bc2
FIX: Don't redirect to wizard when resetting password
2017-06-07 12:36:52 -04:00
5794ff53a1
FIX: Copy custom fields when moving first post of a topic.
...
https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678
2017-06-07 19:04:48 +09:00
684b05f510
FIX: Strip zero-width characters from search terms.
2017-06-07 18:19:47 +09:00
2cad739262
FIX: Better error message when username change fails.
...
https://meta.discourse.org/t/500-error-on-username-edit/64064
2017-06-07 10:45:53 +09:00
da736f70a4
Merge pull request #4845 from vinothkannans/download-onebox-images
...
FEATURE: pull onebox images
2017-06-07 09:55:04 +09:00
7dfbb5a395
UX: don't hide the subcategory filters when subcategories are listed below
2017-06-06 17:38:59 -04:00
6aa0823bf4
FIX: lounge category security settings won't be reset after an upgrade
2017-06-06 16:57:21 -04:00
00f06b8086
UX: Show column headers on user topic lists
2017-06-06 16:07:47 -04:00
209383faab
FEATURE: pull onebox images
2017-06-06 18:51:58 +05:30
63c32b6b21
FIX: Don't animate the progress bar unless scrolling
2017-06-05 15:38:40 -04:00
02ab2706df
FIX: Timeline was wrong sometimes on iPad
2017-06-05 15:23:37 -04:00
79763a6b97
FIX: If a topic is really long, show the timeline
2017-06-05 13:11:25 -04:00
2aae6cfdbe
look for aliases in Emoji.lookup_unicode
2017-06-05 18:53:11 +02:00
a922db6158
FIX: set max width and prevent wrapping on composer submit button on mobile
2017-06-05 12:25:20 -04:00
d78956c0c5
FIX: topic flagged message squeezed into a small column
2017-06-05 11:23:23 -04:00
ab8a1a377c
fixes eslint errors
2017-06-05 15:50:15 +02:00
05f8b5b72e
white_sun_small_cloud is an alias
2017-06-05 15:31:24 +02:00
ba07ae67fb
prefer const over let
2017-06-05 14:35:27 +02:00
f8e5cbd81a
prefer const when not reasigned
2017-06-05 14:33:52 +02:00
64336a8c75
Emoji 5.0 support
2017-06-05 14:06:23 +02:00
ac6c1acbed
FIX: Groups that do not have any owners should not allow membership requests.
2017-06-05 10:02:37 +09:00
a10c939775
FIX: do not show website name on TL0 profile
2017-06-04 18:30:28 +05:30
2518c6156d
UX: add more glyphs on /about page
2017-06-03 08:03:25 +05:30
44cf0bdf9e
UX: add admin/moderator icon on /about page
2017-06-03 01:05:26 +05:30
b4060778d9
FIX: you should always be allowed to see actions you created
2017-06-02 14:24:06 -04:00
007873af3c
FIX: Don't run in testing mode
2017-06-02 12:42:00 -04:00
62e6108756
FIX: Improper error message
2017-06-02 12:37:03 -04:00
eaec35d230
Fix tag related advanced search tests into one context. Fix dynamic locale and select clause in search by all tags. Fix separator for all tags to plus sign.
2017-06-02 12:39:07 +02:00
af3dc4e537
FIX: Publish group's categories to user when adding user to group.
...
https://meta.discourse.org/t/joining-a-group-doesnt-take-effect-unless-the-browser-is-hard-refreshed/57357/11?u=tgxworld
2017-06-02 17:38:14 +09:00
5f441a2614
FIX: Disable request membership button if user does not have sufficient trust level.
2017-06-02 16:06:25 +09:00
a7fc93acac
FIX: post mover not clearing reply_to_user_id
2017-06-01 18:00:14 -04:00
e050308f36
FIX: don't allow moderators to save category tracking settings
2017-06-01 15:26:05 -04:00
2ee144c27f
FEATURE: Add DiscourseEvent trigger when a user logs in.
...
* Also adds a event trigger when user logs in for the first time.
2017-06-01 17:44:49 +09:00
e66fa82f3a
FIX: Don't load JS via SCRIPT tag in QUnit mode
2017-05-31 15:31:24 -04:00
f8fa25a042
FIX: Be smart about refreshing the topic title when editing the OP
2017-05-31 11:13:16 -04:00
b0dd05fdc6
FIX: Inherit topic auto close when changing topic's category.
2017-05-31 17:40:21 +09:00
2302493c64
PERF: N+1 query in search when plugin loads custom fields in `TopicListItemSerializer`.
2017-05-31 09:54:10 +09:00
76aa651ad4
FIX: Posts weren't cloaking properly
2017-05-30 15:34:00 -04:00
872928bbc1
add loading arg for plugin outlet discovery-list-container-top
2017-05-30 14:30:47 -04:00
9be782acf6
FIX: Rerender posts when selecting replies
2017-05-30 12:50:31 -04:00
607998af33
FEATURE: dropdown to filter staff action logs
2017-05-30 11:25:42 -04:00
75c3e7b63c
css tweaks to admin user page on mobile
2017-05-29 14:13:33 -04:00
2927b45ff2
Add checkbox to contain all tags in advanced search and change separators according its state.
2017-05-29 19:12:07 +02:00
a0acce174c
Merge pull request #4888 from techAPJ/invite-full-name
...
FEATURE: require name when accepting invite if 'full name required' setting is enabled
2017-05-29 22:21:32 +05:30
d2c2139da8
FEATURE: require name when accepting invite if 'full name required' setting is enabled
2017-05-29 21:46:43 +05:30
847d831555
FIX: docking position of topic progress at bottom of topic on mobile
2017-05-29 12:14:45 -04:00
a7e65d98a9
FIX: mutex to avoid race condition with double notify
2017-05-26 17:04:40 -04:00
81c18fc0bd
UX: Add link to the user's preferences page next to the avatar
2017-05-26 15:00:49 -04:00
aa24bcbcc9
correct annotation
2017-05-26 09:04:54 -04:00
0aed2533ac
Revert unread optimisation, has too many edge cases
2017-05-26 09:04:13 -04:00
e57d2f5cb8
FIX: Don't do anything if avatar url returns an invalid status code.
2017-05-26 13:02:40 +08:00
7d59ff67b8
adjust qurey to include messages, once everything is read
...
then mark first_topic_unread_at to be current time
2017-05-25 18:40:32 -04:00
39e1948174
FIX: If the error is 401 unauthorized or such, just do nothing
2017-05-25 15:42:05 -04:00
b584264d82
FIX: Don't show "resend email" option when user approval is on
2017-05-25 15:29:05 -04:00
29fac1ac18
PERF: improve performance of unread queries
...
Figuring out what unread topics a user has is a very expensive
operation over time.
Users can easily accumulate 10s of thousands of tracking state rows
(1 for every topic they ever visit)
When figuring out what a user has that is unread we need to join
the tracking state records to the topic table. This can very quickly
lead to cases where you need to scan through the entire topic table.
This commit optimises it so we always keep track of the "first" date
a user has unread topics. Then we can easily filter out all earlier
topics from the join.
We use pg functions, instead of nested queries here to assist the
planner.
2017-05-25 15:07:30 -04:00
6eb6c25816
FIX: Keep the flash when redirecting for login_required
2017-05-25 14:10:15 -04:00
ca965f83c3
Revert "FIX: If login is required, redirect to the `/login` route instead of root"
...
This reverts commit 8a8dec550b
2017-05-25 14:04:28 -04:00
8a8dec550b
FIX: If login is required, redirect to the `/login` route instead of root
2017-05-25 13:35:15 -04:00
f8584e28d7
UX: improved layout of flag handling UI on mobile
2017-05-24 15:52:29 -04:00
f481708348
FIX: Sometimes the duplicate link text made no sense
2017-05-24 14:07:29 -04:00
0a08c18a14
FIX: Don't rate limit gravatar downloads
2017-05-24 13:54:26 -04:00
cdbe027c1c
Refactor `FileHelper` to use keyword arguments.
2017-05-24 13:54:26 -04:00
87ac758f05
FIX: Don't raise an error when the upload can't be retrieved
2017-05-24 13:54:26 -04:00
e8c89b4535
Merge pull request #4865 from chrisgavin/login-button-fix
...
Fix the padding on the login and register buttons.
2017-05-24 12:41:07 -04:00
4266828c62
FIX: incorrect margins on buttons in modals on mobile
2017-05-24 11:57:26 -04:00
d0f84aa14e
FIX: missing to_i which breaks selector component for anon
2017-05-24 11:39:10 -04:00
b78b010757
FIX: Fixes to grant new user of the month badge
2017-05-24 11:36:24 -04:00
0756602dfa
UX: h1, h2, etc css reset should give them a bottom margin
2017-05-24 10:38:25 -04:00
c9028f517a
UX: headings in banners had no margins
2017-05-23 11:25:40 -04:00
9edc490d3f
FIX: remove memoized values in jobs
2017-05-22 16:26:30 -04:00
b23fc2bf84
Helper to find the final destination for a URL
2017-05-22 15:52:41 -04:00
f350dd4fd1
FIX: possible data leaking from one site to another in multisite in PendingFlagsReminder
2017-05-22 15:18:13 -04:00
decb432740
FIX: fill date input with default date range
2017-05-22 21:54:28 +05:30
773445b8df
FIX: Topic Crawling should only crawl HTTP/S urls
2017-05-22 11:57:20 -04:00
08c36fa968
REFACTOR: Clean up some code associated with topic timers.
2017-05-22 18:10:29 +08:00
604aaf8686
FIX: N+1 query in suggested topics list.
2017-05-22 18:05:38 +08:00
238a156300
FIX: `TopicTimestampChanger` should not allow timestamps in the future.
2017-05-22 16:03:49 +08:00
4382a0bb07
Rename `PostTimestampChanger` -> `TopicTimestampChanger`.
2017-05-22 15:01:33 +08:00
393c060047
use moon glyph to denote "later today"
2017-05-19 17:02:00 -07:00
ea9f93dcc5
FIX: Don't crawl non-http/s links
2017-05-19 16:57:41 -04:00
558a274187
UX: flag custom message description is too close to textarea on mobile
2017-05-19 16:08:28 -04:00
908433a7a0
SECURITY: Validate the `entity` when downloading a CSV
2017-05-19 16:00:51 -04:00
0a8e16d049
UX: show short flag descriptions in the flag modal on mobile
2017-05-19 15:35:10 -04:00
c0c6cb8124
mobile like count css rules being ignored
2017-05-19 11:10:18 -04:00
3681b350cd
FIX: new topics alert wasn't covering the entire topic list column headings
2017-05-19 11:05:38 -04:00
387cad693e
"next month" doesn't need time fidelity
2017-05-18 23:29:37 -07:00
e93535e239
Add "Next month" to topic timer selection options.
2017-05-19 14:09:53 +08:00
8ab9f30bbd
FIX: User can't remove bookmark from a deleted post.
2017-05-19 12:25:12 +08:00
870c584e25
Merge pull request #4876 from techAPJ/upload-error
...
FIX: better uploads error page
2017-05-19 07:24:15 +05:30
ef2811f39a
simplify time formats for set topic timer
2017-05-18 17:14:07 -07:00
5e88794a65
remove box-shadows around radio buttons and checkboxes on mobile
2017-05-18 18:04:47 -04:00
fa77bbf04f
FIX: mobile modal close button position, mobile layout of radio buttons and checkboxes
2017-05-18 17:08:52 -04:00
ed4b2b6d8d
FIX: Don't incluide a trailing `<br>` in the bio excerpt
2017-05-18 16:40:07 -04:00
3065b7db4c
FIX: label positioning on mobile forms
2017-05-18 16:38:35 -04:00
c2579c5916
FIX: layout of buttons and modals on mobile
2017-05-18 16:11:52 -04:00
1ef43c33d8
Don't pre-minifiy autoellipsis
2017-05-18 15:16:15 -04:00
1fd8e426f2
FIX: better uploads error page
2017-05-18 23:29:37 +05:30
dbb814ec6a
FIX: allow pasting links into title field that are longer than the max title length
2017-05-18 12:32:47 -04:00
13e489b4ca
replace the upload type whitelist with a sanitizer
2017-05-18 12:13:13 +02:00
8e5b0c79ae
FIX: allow images to be uploaded in wizard
2017-05-18 13:53:23 +05:30
2a5a01af2e
improve error on theme upload, add gif to allowed uploads
2017-05-17 16:29:09 -04:00
a0f03936ff
FIX: saving invisible primary group field that you don't belong to
2017-05-17 12:46:50 -04:00
f8c503186e
FIX: If there's an error downloading, don't raise it
2017-05-17 12:38:18 -04:00
9090c7b05b
FIX: Admin groups editor was showing extra page when exactly 50 records
2017-05-17 11:50:17 -04:00
6d5fe73422
FIX: Sometimes the topic timeline wasn't docking
2017-05-17 11:05:58 -04:00
e4d557cdb9
Partially revert 92118dd1d1.
2017-05-17 21:42:31 +08:00
db06dd8032
remove labels from tag edit buttons in header
2017-05-17 01:18:31 -07:00
92118dd1d1
FIX: Use observer to rerender widget instead.
2017-05-17 10:29:50 +08:00
5d494cf158
FIX: Broken back button on account URLs
2017-05-16 17:21:52 -04:00
68df8f4427
FIX: only trigger notification level change if it actually changes
...
avoids double ajax call every time notification level changes
2017-05-16 16:52:39 -04:00
733b0009cb
FIX: Don't memoize the currentUser in case some plugins use it too early
2017-05-16 16:35:18 -04:00
763f156d91
FIX: require re-activation if SSO changes email and updates it
2017-05-16 16:18:18 -04:00
4424fd81b8
add a tiny bit of extra protection
2017-05-16 16:08:42 -04:00
4b449914b8
FIX: admins could never remove self from messages
2017-05-16 16:06:24 -04:00
6ddd8d9166
FIX: when entering topics "tracking" would not be set
...
There was a timing issue when subscribing to messages for topics.
Old flow:
- We generate JSON for topic
- We subscribe to messages for topic
New flow:
- We keep track of last id in the topic message bus channel
- We generate JSON
- We subscribe to messages for topic starting at saved message id
This ensures that there is complete overlap for message consumption
and that there are no cases where an update may go missing due to timing
2017-05-16 15:04:21 -04:00
7821400141
FEATURE: staff can set a timer to remind them about a topic
2017-05-16 14:49:50 -04:00
59922ce0a4
FEATURE: remove table wrapping posts in notification emails
2017-05-16 10:37:53 -04:00
941adca958
FIX: If you refresh New, clear the incoming topics text
2017-05-15 16:57:09 -04:00
c40ac5abe6
FIX: resize events for ace were not triggered correctly
2017-05-15 16:10:07 -04:00
7a4e825671
we should use fancy title if available
2017-05-15 15:45:29 -04:00
be8dd403df
FEATURE: use fancy title in notifications
2017-05-15 15:38:30 -04:00
f7c46df804
FIX: Only mark all as rendered after *everything* is rendered
2017-05-15 15:12:10 -04:00
f114d63de4
correctly pick the selected theme based on what is loaded
2017-05-15 14:34:24 -04:00
bd0bb879e5
FIX: Don't count likes from system users in the new user of the month
2017-05-15 13:14:32 -04:00
e1dd543a93
FEATURE: allow users to select theme on single device
2017-05-15 12:48:16 -04:00
a0c936dadb
UX: Take header height into account when positioning the timeline
2017-05-15 12:08:42 -04:00
44d7fe89ed
FIX: unescape emoji in pretty title
...
This makes emoji in title consistent, it is later escaped back when needed
2017-05-15 10:28:05 -04:00
dfc9a27dc4
FIX: Quote button broken on windows.
2017-05-15 08:26:48 +08:00
42de1cc977
FIX: Don't warn if the link is in the post you are editing
2017-05-12 20:05:30 -04:00
dd0c34c4b9
move background photo user prefs to be lower in the profile tab
2017-05-12 15:43:21 -04:00
ff6b9aee47
no opacity rule for btn-primary
2017-05-12 15:11:44 -04:00
baf011cbf6
annotate models
2017-05-12 14:47:08 -04:00
a9d5d2aee6
UX: Fix improper aspect ratio for xkcd oneboxes
2017-05-12 13:21:44 -04:00
b92b654ea3
FIX: collapse mobile nav on outside click
2017-05-12 13:15:04 -04:00
3113a6a18a
FIX: hide theme selector if only 1 theme
2017-05-12 12:50:56 -04:00
2d96a0785d
FEATURE: theme selection is now global per-user
2017-05-12 12:41:34 -04:00
b301b69d00
FIX: Don't warn users about duplicate links for:
...
- The original post
- If the post is older than (x) (Two Weeks for now)
2017-05-12 12:37:02 -04:00
ee71786057
PERF: we do not need to ship down the total number of unread
...
Total number of unread notification from the beginning of time
is not an interesting number
2017-05-12 11:11:38 -04:00
e232f87cde
PERF: avoid query as admin
...
As admin no need to query categories over and over
2017-05-12 11:09:41 -04:00
fca166524b
Fix the padding on the login and register buttons.
2017-05-12 09:51:48 +01:00
8eecd42856
FIX: Delete topic timer after completion.
2017-05-12 10:28:51 +08:00
e63614024d
FIX: Users can't request to join group due to alias level restriction.
...
https://meta.discourse.org/t/request-to-join-group-not-working/62371
2017-05-12 09:26:26 +08:00
55b61e9bea
rename topic_status_update to topic_timer
2017-05-11 18:27:53 -04:00
92d63b59a7
FIX: Videos were missing from expanded quotes
2017-05-11 16:54:32 -04:00
f3c535b945
PERF: Dirty checking was broken and re-rendering too often
2017-05-11 16:22:15 -04:00
ea0ecb67f3
UX: Move delete button to end and mark it as dangerous
2017-05-11 16:22:15 -04:00
52ae63d5d7
FIX: when searching PMs also search group PMs
...
Users belonging to a group could not search for PMs unless explicitly added
to the PM unless admin
2017-05-11 15:59:03 -04:00
aa009dd2b5
Add @embeddable_css_class from embed_controller
2017-05-11 15:16:16 -04:00
18de62b015
Add get_embeddable_css_class to assist multi-site embed styling
...
If present, pass embeddable_host.class_name to view for inclusion
on the <html> element as a class for targeted styling.
2017-05-11 15:16:16 -04:00
4bf8548dc5
Add embed class name setup for embeddable hosts
2017-05-11 15:16:16 -04:00
5bbc477baa
UX: Better looking bulk actions modal
2017-05-11 14:48:06 -04:00
1019bbda46
FEATURE: set a timer to delete a topic
2017-05-11 12:52:29 -04:00
21238692d9
Remove unused file
2017-05-11 12:36:57 -04:00
3ade46de0b
FIX: Don't send system message for new user of the month if disabled
2017-05-11 11:33:16 -04:00
006b35d2f3
FIX: Don't redirect for `users/account-created` path
2017-05-11 11:04:45 -04:00
f4b2677a19
FEATURE: ask for confirmation before resending all invites
2017-05-11 18:07:28 +05:30
ce9fe213fd
FIX: Can't quote last paragraph.
2017-05-11 16:49:46 +08:00
8c337ecf82
FIX: allow uploading of category logo and background
2017-05-11 12:48:54 +05:30
214939bb87
freeze array constants
2017-05-11 09:08:59 +02:00
4b7be137cb
don't generate errors if 'upload_id' is invalid
2017-05-11 09:07:04 +02:00
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
a5c4ddd334
oops my linter is not running automatically
2017-05-10 16:09:33 -04:00
2e13c2453b
FIX: maximize css editor not working
2017-05-10 15:47:11 -04:00
04b5516bf2
improve upload functionality
2017-05-10 15:47:11 -04:00
bc0b9af576
FEATURE: support uploads for themes
...
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
f709899a1d
Allow theme field object model to support uploads
2017-05-10 15:46:42 -04:00
26209354e3
Don't hardcode code button index and remove the for loop and use .some()
2017-05-10 14:53:54 -04:00
2f8b1e33f4
FEATURE: bulk relist
2017-05-10 14:53:54 -04:00
f7e8bc6216
UX: Tweak explanations for multiple_grant and allow_title
2017-05-10 14:39:23 -04:00
4db76796b9
FEATURE: Setting to poll feeds more frequently
2017-05-10 14:30:12 -04:00
5be7a2dad4
FIX: invalid html in notification emails when template has been customized
2017-05-10 14:01:26 -04:00
41fb76cc66
Don't rescue all errors.
2017-05-10 09:12:44 +08:00
907f6cd76b
FIX: Select2 retina icons were broken
2017-05-09 15:51:39 -04:00
a1baf73956
FIX: Better error message for when your bookmark rate limit is exceeded
2017-05-09 15:42:55 -04:00
ae15b10cf8
FIX: The keyboard shortcut to bookmark the first post wasn't refreshing
2017-05-09 15:37:36 -04:00
6e4ba8a33e
Catch RSS Parsing errors
2017-05-09 15:07:06 -04:00
c2bf525a06
Make CloseTopic a no-op just in case
2017-05-09 15:02:05 -04:00
24e1892d28
Silence logs for OptimizedImage failures
2017-05-09 14:59:46 -04:00
ba1868b051
FIX: There are still jobs enqueued for CloseTopic
2017-05-09 14:58:37 -04:00
da92f35e08
Don't log a gravatar failure that is a socket error
2017-05-09 14:44:53 -04:00
bcf1a9d43f
We don't need to log when we can't download a Gravatar
2017-05-09 14:43:39 -04:00
6fdbd29882
FIX: Dismiss all button was not updating the UI
2017-05-09 13:46:26 -04:00
e6e0025326
FIX: handle BOM in bulk import CSV file
2017-05-09 22:38:07 +05:30
c2829dce22
FIX: base sql vanishes after badge creation
2017-05-09 09:25:57 -04:00
94683b33b8
FIX: sanitize bulk invite error log
2017-05-09 17:41:59 +05:30
afe04b8bbb
FIX: Possible 500 error if category saved incorrectly
2017-05-08 15:17:58 -04:00
4f6e5fed2a
We don't need to raise an error when no post is present. Just noop.
2017-05-08 15:08:29 -04:00
7a0501c0c0
UX: Wrap really long titles on user stream pages
2017-05-08 14:45:34 -04:00
96c59c5b82
FIX: Don't notify or return flags on system users
2017-05-08 13:13:35 -04:00
a7471fe85f
FIX: page scroll lock not clearing properly on chrome
...
For some reason Chrome renamed "mousewheel" to "wheel"
2017-05-08 09:50:07 -04:00
257c0dea70
Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list
...
Remove daily mailing mode option as it doesn't scale.
2017-05-08 09:10:46 -04:00
e89d0a6b20
FIX: importing a theme via file was broken
2017-05-08 12:03:24 +05:30
cfb30bca80
UX: simplify delete gap style
2017-05-05 17:06:13 -07:00
27e52bc66d
user page stats too "buttony"
2017-05-05 15:36:13 -07:00
b7322b05a0
FIX: some changes in composer affect all visible text editors
2017-05-05 12:59:45 -04:00
3edea3d226
automatically unpin topics setting doesn't need its own section
2017-05-05 10:25:02 -04:00
8bc47d0bae
fix build (cc @tgxworld)
2017-05-05 13:13:49 +02:00
e61959e6a8
FIX: `CustomEmoji` may contain an invalid upload_id.
...
https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608
2017-05-05 14:53:38 +08:00
2b21e5ea7e
UX: Display translated group name for automatic groups.
2017-05-05 14:34:47 +08:00
71a266b673
Remove daily mailing mode option as it doesn't scale.
...
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
50c8ae2c10
Load user records in batches.
2017-05-05 10:57:31 +08:00
777f1f0f47
FIX: Return a 404 if the auth session is not present
2017-05-04 15:35:24 -04:00
c182dcc64c
FEATURE: add .admin-interface class to BODY when in admin
...
removes some dead code as well
2017-05-04 15:13:32 -04:00
66cc4fff2c
fix style of custom field labels on dropdowns and confirm
2017-05-04 14:08:15 -04:00
4ebbad991e
FIX: properly clean up related color schemes on delete
2017-05-04 14:03:17 -04:00
81326f85e5
FIX: Regression when clicking on post date
2017-05-04 13:51:02 -04:00
c576e49230
fix blank name field
2017-05-04 13:45:16 -04:00
55ca5df96b
FIX: If the host can't be extracted don't raise an error
2017-05-04 13:26:37 -04:00
1768c45a33
FIX: If we can't proxy to a CDN due to HTTP error, render blank
2017-05-04 12:42:46 -04:00
57a2042ef6
FIX: Quiet server side errors for requesting json for account-created
2017-05-04 12:30:13 -04:00
b3165f8435
FIX: If badges are disabled don't show "Top Badges" on summary view
2017-05-04 12:14:32 -04:00
c98601129b
Move name, avatar, and title fields from profile tab to account tab
2017-05-04 12:04:07 -04:00
de0d13e4ef
FIX: Badge filtering was always to the currentUser
2017-05-04 11:58:56 -04:00
f4c09e9e90
fix select input widths regression in user preferences
2017-05-04 11:25:22 -04:00
0bdced165a
UX: change timestamp button on mobile was hidden behind date selector
2017-05-04 18:47:25 +05:30
58edd203a9
SECURITY: XSS issue in share popup if invalid link is passed in.
2017-05-04 10:33:59 +08:00
94c8410521
FIX: Show share popup only for valid buttons.
2017-05-04 10:31:09 +08:00
b3908a1d7f
FIX: The user might be anonymous
2017-05-03 18:39:02 -04:00
60693240e1
FIX: Filter badges to user on their badges page too
2017-05-03 17:58:59 -04:00
3eb920e2b0
Merge pull request #4841 from fantasticfears/webhook-ping
...
add event name for ping webhooks in the header
2017-05-04 04:54:40 +08:00
7f09bc9a09
Merge pull request #4849 from discourse/prefs
...
User preferences in tabs
2017-05-03 16:53:26 -04:00
389a0e1a1c
FIX: emails should use default theme colors
2017-05-03 14:35:13 -04:00
b705634ee1
FIX: If you have a badge, filter to you when clicking on it
2017-05-03 13:35:20 -04:00
09cb61b533
FIX: Jumping to a post that doesn't exist should jump to closest
2017-05-03 13:24:30 -04:00
8bcfea3b0d
new outlets for plugins
2017-05-03 11:41:01 -04:00
342ef5f81a
FEATURE: out-of-the-box dark/light user selectable themes
2017-05-03 11:31:33 -04:00
81190f5d66
FIX: Redirect away from `account-created` if you're logged in
2017-05-03 11:18:01 -04:00
12fb20fe1b
FEATURE: Allow users to resend/update email from confirmation page
2017-05-03 11:18:01 -04:00
b381372184
Use Ember.js for the `/u/account-created` path so we can add controls
2017-05-03 11:18:01 -04:00
86f1cc8c92
FIX: don't apply max_emails_per_day_per_user on critical emails
2017-05-03 17:07:39 +05:30
982e3d04f6
PERF: Allow memory to be freed instead of fetching all the objects into memory at once.
...
```
MemoryProfiler.report do
Jobs::UserEmail.new.execute(type: :mailing_list, user_id: user.id)
end.pretty_print
```
Before:
```
Total allocated: 180096119 bytes (1962025 objects)
Total retained: 2194 bytes (16 objects)
allocated memory by gem
-----------------------------------
66979096 activerecord-4.2.8
43507184 nokogiri-1.7.1
43365188 mail-2.6.4
5960201 activesupport-4.2.8
5056267 discourse/lib
4835284 rack-mini-profiler-0.10.1
3825817 arel-6.0.4
2186088 i18n-0.8.1
1719330 discourse/app
```
After:
```
Total allocated: 161935975 bytes (1473940 objects)
Total retained: 2234 bytes (17 objects)
allocated memory by gem
-----------------------------------
45430264 activerecord-4.2.8
43568627 nokogiri-1.7.1
43430754 mail-2.6.4
11233878 rack-mini-profiler-0.10.1
5260825 activesupport-4.2.8
5054491 discourse/lib
2186088 i18n-0.8.1
1822494 arel-6.0.4
```
2017-05-03 17:01:57 +08:00
cdce060a38
FIX: don't apply max emails per day per user to forgot password
2017-05-03 14:02:37 +05:30
2503241ce5
FEATURE: rebuild user preferences page to use tabs
2017-05-02 16:52:18 -04:00
946f25098f
Refactor theme fields so they support custom theme defined vars
...
This paves the way to allowing themes to specify uploads and so on.
2017-05-02 16:02:14 -04:00
77a8cae094
FIX: rescue specific errors on invite failure
2017-05-02 15:13:33 +05:30
9f8a917d65
add event name for ping webhooks in the header
2017-05-02 08:13:23 +02:00
f5b11cb429
PERF: Don't allocate extra array.
2017-05-02 11:54:23 +08:00
3736b440cb
FIX: Quoting an expanded first post would force it to reload the cooked
2017-05-01 15:01:35 -04:00
0722ffadf1
Remove site settings enforce_global_nicknames and discourse_org_access_key
2017-05-01 14:53:16 -04:00
ca224ed8e9
FIX: pending flags message should go to moderators group, not staff
2017-05-01 14:53:16 -04:00
556ef4cfbd
FIX: case sensitive unconditional add of exact match in user search
2017-05-01 14:37:16 -04:00
dfe1174137
FIX: The dates for retroactive anniversary badges were wrong
2017-05-01 12:06:18 -04:00
9e9ead0954
FIX: incorrect label for top topics dropdown on mobile when filtering
2017-05-01 16:43:23 +05:30
a4815047c0
purge `scheduler_stats` every 1 month instead of 3
2017-04-28 15:05:15 -07:00
f05f1a24d3
Change Anniversary badge to be multiple grant, once per year
2017-04-28 14:22:54 -04:00
bb82e0a041
FIX: theme preview from preferences wasn't working
2017-04-28 14:01:57 -04:00
b193ae2d15
FIX: missing link in unsubscribe text of summary emails
2017-04-28 10:37:52 -04:00
cb8f91ca21
FIX: Scrolling offset was broken when entering some topics
2017-04-27 16:22:25 -04:00
5774a9a2c8
Revert offset calculation, was working poorly.
2017-04-27 12:20:32 -04:00
a545117d2e
FIX: Forgot to clear out a topic excerpt
2017-04-27 11:49:39 -04:00
2efe0442bf
FIX: Messed up i18n key
2017-04-27 11:45:59 -04:00
304ace926e
FIX: Raise right response when post_action does not exist.
2017-04-27 17:29:53 +08:00
e4b9f72f9e
FIX: Force the right encoding when handling email.
2017-04-27 16:51:54 +08:00
7873a2efb7
Merge pull request #4843 from tgxworld/disable_post_min_length_for_pm
...
FEATURE: Disable minimum post length check when in PM with non human …
2017-04-27 16:35:19 +08:00
59b906ab0d
FEATURE: Disable minimum post length check when in PM with non human users.
...
https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld
2017-04-27 16:00:22 +08:00
85d9342ff0
Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job
...
FIX: Clean up unused staged users job not completing.
2017-04-27 15:41:46 +08:00
b755279cf0
remove unneeded code
2017-04-27 08:47:47 +05:30
e3f82140d8
more readable code for filtering username/email when bulk adding to group
2017-04-27 08:43:28 +05:30
b41d96fac1
FIX: properly initialize hashes
2017-04-27 02:56:14 +05:30
9b0ecdaf7e
Merge pull request #4839 from techAPJ/bulk-add-group
...
FEATURE: provide more details when performing a bulk add to group
2017-04-27 02:39:57 +05:30
285c167fae
FEATURE: provide more details when performing a bulk add to group
2017-04-27 01:37:51 +05:30
30ebaf6b6a
Update FontAwesome to 4.7.0
2017-04-26 15:16:30 -04:00
cd4f0393a8
Add a title tag to the search results page
2017-04-26 15:02:07 -04:00
bf9c4a7828
FEATURE: secure_email site setting to prevent data going out in email
2017-04-26 13:05:56 -04:00
fe0a7d97ca
Fix incorrect class name.
2017-04-26 18:12:51 +08:00
b00886f5c1
Remove sidekiq-statistic gem.
...
* We don't really use it and there is an on-going issue
with the gem not expiring keys in a Redis list which
hasn't been fully resolved.
https://github.com/davydovanton/sidekiq-statistic/issues/73
2017-04-26 14:54:47 +08:00
Régis Hanol
Jeff Atwood
Guo Xiang Tan
Robin Ward
Neil Lalonde
Arpit Jalan
hosnas
Joffrey JAFFEUX
Sam
Blake Erickson
Guo Xiang Tan
Vinoth Kannan
Jakub Macina
Leo McArdle
Chris Gavin
Pat David
OsamaSayegh
osamasayegh
Erick Guan