Commit Graph

14186 Commits

Author SHA1 Message Date
Sam 8e5e3b5af8 FIX: sso provider require return_sso_url 2017-03-22 09:08:38 -04:00
Régis Hanol 67eb754c3c remove duplicate emoji translation 2017-03-22 12:07:17 +01:00
Régis Hanol ccd4832726 Add 'slight_smile' emoji translations 2017-03-22 10:17:10 +01:00
Arpit Jalan 786fd6bbd2 Merge pull request #4774 from techAPJ/email-prefix
FIX: use email prefix only in subject
2017-03-22 14:18:50 +05:30
Arpit Jalan 295cf8839e FIX: better error message when invited user already exists 2017-03-22 13:55:28 +05:30
Guo Xiang Tan e8fc8f0bb6 Update annotations. 2017-03-22 14:26:53 +08:00
Robin Ward 1cd14ef3aa FIX: Site Settings weirdness with back button 2017-03-21 16:13:19 -04:00
Robin Ward 874e8900af Display email address in SSO error message. 2017-03-21 15:37:46 -04:00
Robin Ward aeaf5075bf Custom errors for when Email is invalid via SSO 2017-03-21 15:23:38 -04:00
Robin Ward 52d78294cc Render a layout when there's an SSO error 2017-03-21 15:23:38 -04:00
Arpit Jalan 7f207fd411 Merge pull request #4771 from techAPJ/user-summary-tab
FEATURE: make summary as first tab on user page
2017-03-21 23:14:07 +05:30
Arpit Jalan ec2a66d1f0 FEATURE: make summary as first tab on user page
https://meta.discourse.org/t/custom-user-fields-show-on-activity-but-not-summary-page/59196/3?u=techapj
2017-03-21 23:12:28 +05:30
Neil Lalonde 2836d548fb Category boxes with feature topics will show pins and locks as bullet for pinned and closed/archived topics 2017-03-21 12:23:19 -04:00
Arpit Jalan 1853a4852c FIX: use email prefix only in subject 2017-03-21 20:29:57 +05:30
Arpit Jalan df246c79b6 FEATURE: add user profile fields in user list export 2017-03-21 15:51:52 +05:30
Arpit Jalan 82c0f5f587 Merge pull request #4767 from techAPJ/activate-account
FIX: send activation email if user have unconfirmed email address
2017-03-21 09:44:23 +05:30
Arpit Jalan 7c3ae50dcd FIX: send activation email if user have unconfirmed email 2017-03-21 09:41:50 +05:30
Guo Xiang Tan 0cfc4db868 Merge pull request #4769 from gsambrotta/admin-users-list-style
add style to show admin/users header as clickable
2017-03-21 10:07:05 +08:00
Sam Saffron b94c7b4902 missing disposition 2017-03-20 17:07:32 -04:00
Sam 652b2d7199 remove redundent header setting 2017-03-20 16:08:18 -04:00
Sam c106ca6778 FEATURE: fallback asset path for multi host setups 2017-03-20 15:59:17 -04:00
Neil Lalonde 9c03456e75 Category description in sub-category boxes is truncated after height 6em, customizable with CSS 2017-03-20 15:43:49 -04:00
Neil Lalonde e96d875bee FIX: show lock icons for secured categories in boxes views 2017-03-20 14:50:52 -04:00
Neil Lalonde 0238a076f3 Change category-boxes so it's easier to customize with CSS 2017-03-20 14:50:52 -04:00
Neil Lalonde 85280b0bc8 FIX: links in category description inside subcategory boxes have too much padding 2017-03-20 14:50:52 -04:00
giorgia b8ee2cabcf add style to make tabs clickable 2017-03-20 15:23:00 +01:00
giorgia c3e8497636 remove tooltip on hover on desktop 2017-03-20 13:26:36 +01:00
Arpit Jalan 521c88fe58 FIX: enqueue activation email for invited user that has password set 2017-03-20 17:13:21 +05:30
Guo Xiang Tan 1d4993a185 FIX: Sync user's notification channel before preloaded current user data.
This is to fix the problem where a newly created user would not
receive live updates for the first notification if the notification
is published before the client has subscribed to the channel.
2017-03-20 17:17:21 +08:00
Guo Xiang Tan 32d8447838 REFACTOR: Don't lookup container for certain objects if user is not signed in. 2017-03-20 15:49:36 +08:00
Guo Xiang Tan ddc8abf9d8 Fix broken optimize image command. 2017-03-20 15:07:38 +08:00
Guo Xiang Tan 6057e17ae7 Fix weird test failure. 2017-03-20 12:06:37 +08:00
Guo Xiang Tan a567e6bec9 FIX: Publish notification state in `after_commit` hook.
`after_save` is still wrapped in a transaction and
we were getting intermittent failures with notifications
state not being published.
2017-03-20 11:38:34 +08:00
Neil Lalonde 9ae8813a53 FIX: admin user page should show count of all posts, including private messages, so admins can delete them. This bug was making it impossible to delete users. 2017-03-17 17:01:45 -04:00
Robin Ward f5f54c1b77 Merge pull request #4764 from tgxworld/nuke_backticks
FIX: Don't use backticks that take in inputs.
2017-03-17 15:40:23 -04:00
Neil Lalonde 0991acf103 make it easier to customize category boxes with featured topics 2017-03-17 12:33:26 -04:00
ElTipejoLoco e234a7821d Add "Show tracked topics" to User Preferences
Does what it says on the tin. Minor clean-up.
2017-03-17 08:05:21 -05:00
Régis Hanol e600dca268 Merge pull request #4763 from vvanpo/fork-master
JSON API parsing error on CSRF exception: single quotes in ['BAD CSRF'] is invalid JSON
2017-03-17 09:19:10 +01:00
Guo Xiang Tan e7c972ac89 FIX: Don't use backticks that take in inputs. 2017-03-17 15:33:51 +08:00
Guo Xiang Tan 566f367fc3 FIX: Don't migrate custom emojis that are no longer valid.
* Warn about failed migration in logs.
2017-03-17 08:28:24 +08:00
Victor van Poppelen 9e60f9f093 JSON API parsing error on CSRF exception: single quotes in ['BAD CSRF'] is invalid JSON:
https://meta.discourse.org/t/json-api-parsing-error-single-quotes-used-for-errors-like-bad-csrf/58869
2017-03-16 16:47:18 -07:00
Neil Lalonde ad8a579c79 UX: banner enabled/disabled posts should be small posts, not full-size posts 2017-03-16 17:31:37 -04:00
Robin Ward 1957d12670 SECURITY: Don't use backticks for exporting your archive 2017-03-16 16:24:59 -04:00
Neil Lalonde 22f197c153 FEATURE: subcategory list style: boxes with featured topics 2017-03-16 11:54:45 -04:00
Sam 2c952e1981 Merge pull request #4760 from nbianca/fix_topic_title
Fixes duplicated title in header after edit
2017-03-16 11:49:45 -04:00
Bianca Nenciu f8a31d927f Fixes duplicated topic title in header after edit. 2017-03-16 17:34:39 +02:00
Robin Ward fd591257a8 Merge pull request #4759 from kennym/support-ports-for-ip-addresses-in-embedding
FIX: Allow ports for embed host IPs
2017-03-16 11:23:42 -04:00
Guo Xiang Tan 9f299b6842 Use `after_commit` since `after_save` runs within the transaction as well. 2017-03-16 16:02:34 +08:00
Guo Xiang Tan 299b92b4d7 Fix broken user created event trigger. 2017-03-16 15:36:27 +08:00
Guo Xiang Tan 5169ef8814 Fix broken specs. 2017-03-16 15:05:28 +08:00
Guo Xiang Tan bf78c228f4 FIX: User created web hook being enqueued before record has been saved.
* Improve web hook tests as well.
2017-03-16 14:44:09 +08:00
Guo Xiang Tan bb85795934 FIX: Leave group membership button not updating.
https://meta.discourse.org/t/leave-group-button-on-groups-page-doesnt-give-any-feedback/57359/4
2017-03-16 11:33:55 +08:00
Guo Xiang Tan 65c000ad74 FEATURE: Track views on user profile card as profile views. 2017-03-16 10:59:08 +08:00
Guo Xiang Tan 0a87547cbc Fix broken tests. 2017-03-16 10:22:15 +08:00
Erick Guan cfbfea0596 FEATURE: Allow easier customization to the web hook event serialization. 2017-03-16 10:09:05 +08:00
Guo Xiang Tan bbc85e1e29 Merge pull request #4750 from discourse/group_login_registration_flow
FEATURE: Redirect to groups page and apply group actions upon login/s…
2017-03-16 09:50:56 +08:00
Guo Xiang Tan ca965bb455 FEATURE: Redirect to groups page after login/registration flow. 2017-03-16 09:48:51 +08:00
giorgia 576982484d FEATURE: Make admin user list sortable.
https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649
2017-03-16 09:24:15 +08:00
Vinoth Kannan d3f07122c4 UX: 'Join Group' button position moved to group header 2017-03-16 08:40:27 +08:00
Kenny Meyer ae957bca25 Allow ports for embed host IPs 2017-03-15 18:16:34 -03:00
Sam 61a7162c01 Merge pull request #4747 from gsambrotta/show-disable-delete-btn-cat
Show disable delete btn cat
2017-03-15 15:45:05 -04:00
Neil Lalonde 5c4f37a24e cdn-img will render nothing if src is null 2017-03-15 13:30:29 -04:00
Anaketa d7dedc4649 add show/hide to tooltip 2017-03-15 17:23:52 +01:00
Anaketa 63febf391b create btn, tooltip and style it 2017-03-15 17:16:21 +01:00
Guo Xiang Tan 911d6abfad Merge pull request #4757 from nbianca/change_timestamp_bug
Change timestamp only for admin.
2017-03-15 10:44:19 +08:00
Neil Lalonde bc31d25132 some cleanup thanks to eviltrout 2017-03-14 17:23:19 -04:00
Neil Lalonde 5c923fef58 FIX: category logo preview in settings shouldn't render it like a background image 2017-03-14 17:12:09 -04:00
Sam 7378077036 Merge pull request #4749 from cpradio/add-subcategory-class-hamburger-menu
UX: Add subcategory class to hamburger menu items that are subcategories
2017-03-14 17:08:35 -04:00
Bianca Nenciu 8354768d7c Change timestamp only for admin. 2017-03-14 23:07:36 +02:00
Neil Lalonde 889902256b FIX: encoded characters shown in category boxes 2017-03-14 14:51:11 -04:00
Sam 8ac7e6a605 Merge pull request #4753 from cpradio/plugin-outlet-user-preferences
DEV: Add plugin-outlet to allow SSO sites to put a message on the User Preferences page
2017-03-14 10:32:09 -04:00
Guo Xiang Tan 58de40154d Bump `EMOJI_VERSION` to clear cache. 2017-03-14 15:31:01 +08:00
Guo Xiang Tan 6a6113fcea Merge pull request #4682 from tgxworld/store_custom_emoji_as_uploads
FIX: Store custom emojis as uploads.
2017-03-14 14:14:18 +08:00
Guo Xiang Tan 324b346bb1 FIX: Restore was not redirecting to logs route. 2017-03-14 14:00:18 +08:00
Guo Xiang Tan 1a7e954e09 FIX: Store custom emojis as uploads.
* Depending on a hardcoded directory was a flawed design
  which made it impossible to debug when custom emojis go
  missing.
2017-03-14 13:07:18 +08:00
Guo Xiang Tan 99943ec769 Make eslint happy. 2017-03-14 11:52:15 +08:00
Guo Xiang Tan 83d2e63771 Make eslint happy. 2017-03-14 11:47:35 +08:00
Guo Xiang Tan 8e45322b09 FIX: Only group admins can see group edit page. 2017-03-14 11:45:58 +08:00
cpradio a5af9a834f DEV: Add plugin-outlet to allow SSO sites to put a message on the User Preferences page 2017-03-13 18:26:00 -04:00
Neil Lalonde 318f7bab4b fix padding so entire box is clickable 2017-03-13 16:49:03 -04:00
Neil Lalonde 3dab932b96 fix trying to render cdn image of undefined 2017-03-13 16:22:37 -04:00
Neil Lalonde 6d7e968e30 FEATURE: box-style rendering of sub-categories 2017-03-13 15:25:52 -04:00
Régis Hanol 30d5d61158 use 'toLocaleDateString()' 2017-03-13 16:11:49 +01:00
cpradio 15f7fff561 UX: Add subcategory class to hamburger menu items that are subcategories
UX: Add data-category-url to make targetting a category li element in the hamburger menu easier
2017-03-13 10:51:41 -04:00
Sam 64680286f4 correct logic, so revalidation is reset
correct test so it can run at any point
2017-03-13 10:47:43 -04:00
Sam a690121805 SECURITY: always allow staff to resend activation mails 2017-03-13 10:32:24 -04:00
Sam 1a745ca16a else @user makes no sense :) 2017-03-13 10:22:23 -04:00
Sam ef24fd54ba FEATUE: automatically validate token is stored in redis
This ensures we have some handling for redis flushall

We attempt to recover our in-memory session token once every 30 seconds

Code is careful to only set the token if it is nil, to allow for manual
cycling to remain safe if needed
2017-03-13 10:19:02 -04:00
Guo Xiang Tan 9364d8ce71 FIX: Store user's id instead for sending activation email.
* Email and username are both allowed to be used for logging in.
  Therefore, it is easier to just store the user's id rather than
  to store the username and email in the session.
2017-03-13 20:24:55 +08:00
Guo Xiang Tan 7ebfa3c901 SECURITY: Only allow users to resend activation email with a valid session.
* Improve error when an active user tries to request for an activation email.
2017-03-13 19:35:29 +08:00
Régis Hanol dd60cb82c3 UX: add client-side rate limit on click counters 2017-03-13 11:31:37 +01:00
Arpit Jalan 848120c098 FEATURE: RSS feed for top page period filters 2017-03-13 15:23:46 +05:30
Guo Xiang Tan 4d4a1a1552 Add scope for human users. 2017-03-11 14:25:09 +08:00
Sam 16593ae8bf FEATURE: log reason staff auto blocks a user 2017-03-10 15:45:48 -05:00
Sam f13367cecd FIX: latest + category not respecting homepage category suppression 2017-03-10 15:17:51 -05:00
Sam 19ad1e2c2e less opacity for quote button 2017-03-10 14:57:58 -05:00
Neil Lalonde 402ddb810c FIX: email customizations now apply to both html and text parts 2017-03-10 14:08:03 -05:00
Neil Lalonde 15adbdcdd5 FEATURE: new template parameters for notification emails that can be used in links: topic_title_url_encoded and site_title_url_encoded 2017-03-10 14:08:03 -05:00
Sam bc1a6ccb90 Merge pull request #4741 from tgxworld/allow_bookmark_removal
FIX: Allow user to remove bookmark from posts as long as bookmark is …
2017-03-10 12:49:20 -05:00
Arpit Jalan f7e7ca3937 FEATURE: anonymized site statistics 2017-03-10 18:50:26 +05:30
Guo Xiang Tan 0e41b1181a UX: Display button to add a group when no group has been selected.
https://meta.discourse.org/t/new-button-on-groups/44546
2017-03-10 17:15:49 +08:00
Guo Xiang Tan eb6ef0311e Hide special users from about pages. 2017-03-10 15:33:31 +08:00
Guo Xiang Tan a43ec88f46 Merge pull request #4743 from tgxworld/fix_autocomplete_being_rerendered
FIX: Category autocomplete breaks when search menu widget rerenders.
2017-03-10 09:42:18 +08:00
Sam 3032aa7db9 PERF: avoid looking globals from providers after first call 2017-03-09 18:00:55 -05:00
Guo Xiang Tan b419a5765e FEATURE: Add seen/unseen filters to advanced search UI.
https://meta.discourse.org/t/advanced-search-posts-that-i-have-seen/57966
2017-03-09 10:46:06 +08:00
Régis Hanol 00380d84c5 UX: display text & html parts alongside raw email in incoming email modal 2017-03-08 23:15:42 +01:00
Arpit Jalan dfd5b06c82 FIX: custom CSS/HTML files were not getting downloaded on Chrome 2017-03-09 01:09:26 +05:30
Régis Hanol 23b06d2895 FIX: should not try to send digest to users who reached the bounce threshold 2017-03-08 19:19:11 +01:00
Guo Xiang Tan 6a7773b681 FIX: Category autocomplete breaks when search menu widget rerenders.
https://github.com/discourse/discourse/pull/4717#issuecomment-284914585
2017-03-08 20:13:48 +08:00
Guo Xiang Tan 3c41cb6b7d FIX: Reply to topic keyboard shortcut raises an error on non-topic routes. 2017-03-08 19:55:35 +08:00
Arpit Jalan 801b5838e1 FIX: do not show faq/guidelines page to anonymous users for private forums 2017-03-08 16:00:49 +05:30
Régis Hanol cf8bc4483f FIX: always send critical emails even when bounce score threshold has been reached 2017-03-08 10:06:16 +01:00
Arpit Jalan 090236b15b FIX: do not show about page to anonymous users for private forums 2017-03-08 13:15:44 +05:30
Guo Xiang Tan 689dd16be0 FIX: Allow user to remove bookmark from posts as long as bookmark is present.
https://meta.discourse.org/t/bookmark-issue-when-access-to-topic-is-lost-pms/51993
2017-03-08 13:53:49 +08:00
Sam 0c03ccb01e FEATURE: allow plugins to transform, the transformed post
This allows plugins to amend posts prior to rendering.
2017-03-07 17:12:31 -05:00
Sam 99f4d5082b FIX: Improve token rotation and increase logging
- avoid access denied on bad cookie, instead just nuke it
- avoid marking a token unseen for first minute post rotation
- log path in user auth token logs
2017-03-07 13:27:43 -05:00
Sam 9f8cfee450 remove dupe code, correct logging logic 2017-03-07 13:27:43 -05:00
Robin Ward 42fd4f987e When viewing yourself, default to activity, not summary. 2017-03-07 12:03:05 -05:00
Neil Lalonde d95e4102c1 FIX: tags created in secured categories should not be forbidden outside those categories 2017-03-07 11:46:46 -05:00
Robin Ward dad57fa033 FIX: More errors with non-ascii URLs 2017-03-07 11:21:41 -05:00
Guo Xiang Tan d1e587c10a Merge pull request #4737 from oblakeerickson/approve_invited_user
FIX: approve invited user
2017-03-07 21:14:34 +08:00
Guo Xiang Tan 60b7453f3f FIX: Do not trigger fullpage search when selecting autocomplete term with enter. 2017-03-07 11:56:40 +08:00
Guo Xiang Tan f3a7e398ca Merge pull request #4717 from cpradio/autocomplete-search
FEATURE: Autocomplete support on search
2017-03-07 06:40:45 +08:00
Sam 443bce6466 add a descriptive comment 2017-03-06 15:15:07 -05:00
Sam 3227d79430 FIX: extra-nav-item outlet no longer adds a DIV to UL
This amends the extensibility on navigation bar so extra nav items are not
added to a DIV nested into the UL, instead the LIs are rendered as usual
2017-03-06 15:00:13 -05:00
Robin Ward 3905778fc0 FIX: Put back the back button fix again. 2017-03-06 12:24:27 -05:00
Rafael dos Santos Silva c3477cd40d Merge pull request #4716 from discourse/bounced_emails_details
FEATURE: Allow checking the raw response of a bounced email
2017-03-06 13:30:19 -03:00
Régis Hanol 0abe433495 Merge pull request #4736 from techAPJ/group-bulk-add
FIX: grant trust level when bulk adding users to group
2017-03-06 12:43:26 +01:00
Guo Xiang Tan 1e8573ac75 Merge pull request #4738 from rimian/patch-4
less restrictive to allow plugin outlets
2017-03-06 17:25:18 +08:00
Guo Xiang Tan 7d82a53dfe FIX: `Group#name` is case insensitive. 2017-03-06 17:24:03 +08:00
Arpit Jalan d5bcc70e9c FIX: grant trust level when bulk adding users to group 2017-03-06 14:39:53 +05:30
Guo Xiang Tan 66b5f97743 Merge pull request #4739 from tgxworld/fix_cant_recover_a_topic_that_belongs_to_a_deleted_user
Fix cant recover a topic that belongs to a deleted user
2017-03-06 15:12:54 +08:00
Guo Xiang Tan 8aea3caf00 FIX: Ensure that we only move posts that belong to the original topic. 2017-03-06 15:04:10 +08:00
Guo Xiang Tan 477eb0591e FIX: Posts in a deleted topic couldn't be moved.
https://meta.discourse.org/t/moving-posts-to-new-topic/58436/4
2017-03-06 14:56:20 +08:00
Rimian Perkins 95f7b60212 less restrictive to allow plugin outlets
for extra-nav-items
2017-03-06 14:38:57 +11:00
Blake Erickson dbb3ddc7a6 FIX: approve invited user
This commit fixes the case where invited users who typed in a password
would not be approved by default. Because we moved the user create logic
for an invited user there was a clash with the `save` in the user model
and the `save` in the invite_redeemer class.

- added approve logic into invite_redeemer class.
- added tests to verify that the user is approved
- added a check to see if must_approve_users is on
- added a check to see if the inviter is staff
- go ahead and approve the user if must_approve_users is off
- keep existing User.approve workflow if user exists
- improve if/else logic to remove duplicate code
- use `Time.zone.now`
2017-03-05 06:58:23 -07:00
Guo Xiang Tan 08ffbf6c61 Use `Time.zone.now` instead. 2017-03-05 11:10:40 +08:00
Neil Lalonde 9c7a02192a FIX: flag action buttons are missing when visiting flags from the hamburger menu 2017-03-04 11:36:58 -05:00
cpradio 3eb51f0d77 FIX: Make it a tad bit harder to accidentally redirect to full page search while autocomplete is open 2017-03-03 22:48:28 -05:00
Sam 3e3fdfc717 FEATURE: plugin can now extend list of classes for topic-post 2017-03-03 16:57:25 -05:00
Sam 31a81d4eee FEATURE: allow for for empty description in list 2017-03-03 16:13:05 -05:00
Sam c99f4260c0 Merge pull request #4729 from tgxworld/dont_mark_user_as_valid
FIX: Don't mark user as `active` if verified email is different.
2017-03-03 15:57:30 -05:00
Neil Lalonde 6aab8cb331 FEATURE: new category setting for whether to show latest topics or top topics by default 2017-03-03 11:30:44 -05:00
Guo Xiang Tan bcf634ca85 Merge pull request #4728 from nbianca/username-regex
Add support for username regex.
2017-03-03 22:59:23 +08:00
Rafael dos Santos Silva aac4a4ed94 Handle invalid parameters and missing bounced emails 2017-03-02 20:37:28 -03:00
Sam abc4dff0fe FEATURE: add bumped_before query param for topic list 2017-03-02 15:11:50 -05:00
Neil Lalonde ca20cb9941 FEATURE: subcategories can be discovered by web crawlers on page 1 of the parent category topics list 2017-03-02 15:06:56 -05:00
Sam 4dac4c69a6 FEATURE: add `before` topic list filter 2017-03-02 14:54:33 -05:00
Neil Lalonde 7496f373cd add headline itemprop to DiscussionForumPosting for crawlers 2017-03-02 12:35:50 -05:00
Neil Lalonde 797313a28d FIX: subcategories need the num featured topics setting too 2017-03-02 11:31:28 -05:00
Sam 7431c30c1f Correct test and remove uneeded outlet 2017-03-02 09:17:14 -05:00
Bianca Nenciu 30909ec54e Add support for username regex. 2017-03-02 13:53:45 +02:00
Guo Xiang Tan 442bef2df9 Merge pull request #4706 from gsambrotta/add-name-search-dropbox
FEATURE: Add user name in search results
2017-03-02 15:22:15 +08:00
Guo Xiang Tan 3d347fb9c4 FIX: Don't mark user as `active` if verified email is different. 2017-03-02 14:24:30 +08:00
Sam dbfea9b5b0 correct refactor 2017-03-01 18:26:26 -05:00
Guo Xiang Tan f5bf6256a9 Merge pull request #4732 from nbianca/typo
Fixed typo.
2017-03-02 06:02:43 +08:00
Sam c79b146283 FEATURE: make list controller a bit more extensible 2017-03-01 16:41:09 -05:00
Sam f0b79cf54b FEATURE: Add outlet for messages nave extension 2017-03-01 16:41:09 -05:00
Bianca Nenciu 2c22a7f78b Fixed typo. 2017-03-01 23:02:29 +02:00
Neil Lalonde d848916357 FEATURE: Greek language support, thanks to Vasilis Vlachokyriakos 2017-03-01 15:52:55 -05:00
Sam 7895b71817 move to use let, missed a spot 2017-03-01 15:15:36 -05:00
Neil Lalonde 262016604d FEATURE: each category can control how many topics to show on categories page 2017-03-01 15:12:57 -05:00
Sam ca951f2cf2 FIX: render custom tag extensions even when tags disabled 2017-03-01 13:38:44 -05:00
Sam 89bd538742 add callback priority to tags html 2017-03-01 12:56:45 -05:00
Blake Erickson 0b81a93020 Merge pull request #4718 from oblakeerickson/email_discourse_backups
FEATURE: further restrict downloading of backups
2017-03-01 08:57:44 -07:00
Sam 8c8de1c2d4 FEATURE: addUserMenuGlyph extensibility point 2017-03-01 10:32:01 -05:00
Blake Erickson 80858bae2c FEATURE: further restrict downloading of backups
- send email to logged in admin when they press the "download" button
- show pop-up that email was sent
- create email template
- require a valid token to download backup
2017-03-01 08:28:34 -07:00
cpradio 4c7a21c76e FEATURE: Autocomplete support on advanced search
PERF: Extract autocomplete initialization to a function
PERF: Create a REGEXP_TAGS_REPLACE regex to remove a chained .replace call

FIX: autocomplete positioning

FIX: Collapsing/Expanding Advanced Search doesn't wipe out Advanced Search Terms from search query.

FIX: Populate Category when query/search term is updated

FIX: Using enter to complete autocomplete doesn't automatically send you to full page search
2017-03-01 10:25:49 -05:00
giorgia d308638a18 create searchResultUserSerializer, display name next to username in search results 2017-03-01 13:11:01 +01:00
Régis Hanol b20b568039 FIX: allow for empty translated strings 2017-03-01 11:30:44 +01:00
Arpit Jalan e27b1b98d1 FIX: handle new user when logging name change 2017-03-01 13:43:57 +05:30
Guo Xiang Tan 112ca20c96 Merge pull request #4675 from tgxworld/fix_polls_forever_broken_if_approval_required
FIX: Polls permanently broken if post requires approval.
2017-03-01 12:56:03 +08:00
Guo Xiang Tan 76dd6933d2 Revert "Revert "Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email."""
This reverts commit e6d75f6844.

This is why we should not be pushing directly to master.
2017-03-01 10:16:59 +08:00
Sam f918951d42 FEATURE: clean up tags extensibility
centralizes all logic for topic tag rendering and provides API for extension
2017-02-28 17:08:43 -05:00
Robin Ward e863d66e33 FIX: Back button was broken after clicking flags in hamburger 2017-02-28 13:53:48 -05:00
Sam 122fb8025d FIX: last seen date erroneously updated when browser in background
In some cases user may be "last seen" even though browser tab is in
the background or computer is locked
2017-02-28 12:35:10 -05:00
Neil Lalonde 292dd8623c Merge pull request #4622 from dmacjam/master
FEATURE: Append tags bulk action for topics
2017-02-28 11:36:58 -05:00
Sam 3ac4709903 FIX: on initial token issue stop unmarking token as unseen
prev and current are the same so we need special logic to bypass
2017-02-28 10:38:22 -05:00
Sam ffd8fa7481 FEATURE: move_to_inbox and archive_message events 2017-02-28 09:56:41 -05:00
Régis Hanol 5738253998 FIX: locale fallback with pluralized strings 2017-02-28 10:02:29 +01:00
Guo Xiang Tan 54577db8a4 Don't assign variable when not required to do so. 2017-02-28 14:14:57 +08:00
Guo Xiang Tan e6d75f6844 Revert "Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email.""
This reverts commit 0e3def7d2b.
2017-02-28 11:27:14 +08:00
Sam 1e980ad4e6 Merge pull request #4721 from oblakeerickson/sort_admin_users_api
FEATURE: Add order logic to admin users controller
2017-02-27 16:13:42 -05:00
Robin Ward b2b7f4d905 FIX: Query parameters were not being cleared when changing filtering. 2017-02-27 15:49:14 -05:00
Neil Lalonde cfedbad0e9 FIX: hamburger shouldn't show subcategories if show_subcategory_list is enabled on the parent 2017-02-27 15:34:07 -05:00
Arpit Jalan 6661cebff8 FIX: do not log duplicate username changes 2017-02-28 01:32:00 +05:30
Arpit Jalan b32d3d66e5 FEATURE: log all username and name changes 2017-02-28 00:23:27 +05:30
Robin Ward 0e3def7d2b Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email."
This reverts commit 1060239e2d.
2017-02-27 13:19:26 -05:00
Robin Ward bf9626d031 FIX: Embedding was broken with non-english URLs and ports 2017-02-27 12:17:52 -05:00
Arpit Jalan 877957ae88 Merge pull request #4715 from techAPJ/login-per-ip
FEATURE: new site setting for max logins per ip per hour/minute
2017-02-27 18:24:53 +05:30
Arpit Jalan cba51e1c38 FEATURE: new site setting for max logins per ip per hour/minute 2017-02-27 16:58:03 +05:30
Guo Xiang Tan 0e8c849572 UX: "See more" on not found page should redirect to /top. 2017-02-27 13:33:19 +08:00
Guo Xiang Tan ac37bd3dbc FIX: Search menu results does not refresh when search context is changed. 2017-02-27 12:23:41 +08:00
Guo Xiang Tan 758e3e52f7 FIX: Mobile topic timeline broken on Chrome 56.
* See https://developers.google.com/web/updates/2017/01/scrolling-intervention.
  From Chrome 56 onwards, `touchstart` event listeners are treated as passive
  by default which does not call `preventDefault` resulting in the page
  scrolling when topic timeline handle is being dragged.
2017-02-27 11:39:57 +08:00
Sam Saffron 7e8f0dc967 FIX: attempt to handle ios edge case where token is seen but unsaved
This relaxes our security in the following way

- prev auth token is always accepted as long as rotation
date is within our window of SiteSetting.maximum_session_age.hours
(previously old token expired within a minute of new one being seen)

- new auth token is marked unseen if we are presented with an old token
after we already saw new one

This attempts to fix an issue where ios webkit is not committing new cookies
2017-02-26 17:09:57 -05:00
Blake Erickson 0a41da6bad FEATURE: Add order logic to admin users controller
Added order and direction parameters for sorting admin user pages. This
commit only includes backend api changes.

https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649

Now you can pass in `order` and `asc` parameters to the
`/admin/users/list/<query>.json` endpoint.

Example:

`/admin/users/list/active.json?&order=post_count` which defaults to desc

and

`/admin/users/list/active.json?order=post_count&asc=true`
2017-02-24 17:11:17 -07:00
Régis Hanol fdf749770b remove unecessary '.limit(1)' 2017-02-24 12:56:13 +01:00
Régis Hanol a2c04be718 FIX: eradicate I18n fallback issues 💣
FIX: client's translation overrides were not working when the current locale was missing a key
FIX: ExtraLocalesController.show was not properly handling multiple translations
FIX: JsLocaleHelper#output_locale was not properly handling multiple translations

FIX: ExtraLocalesController.show's spec which was randomly failing
FIX: JsLocaleHelper#output_locale was muting cached translations hashes

REFACTOR: move 'enableVerboseLocalization' to the 'localization' initializer
REFACTOR: remove unused I18n.js methods (getFallbacks, localize, parseDate, toTime, strftime, toCurrency, toPercentage)
REFACTOR: remove all I18n.pluralizationRules and instead use MessageFormat's pluralization rules

TEST: add tests for localization initializer
TEST: add tests for I18n.js
2017-02-24 11:31:21 +01:00
Guo Xiang Tan 1060239e2d SECURITY: Ensure oAuth authenticated email is the same as created user's email. 2017-02-24 13:13:10 +08:00
Guo Xiang Tan 0847b4258a Revert "SECURITY: Ensure that user has been authenticated."
This reverts commit fbe51d68a7.

Changing the commit message to correctly reflect what we're actually
fixing.
2017-02-24 13:12:29 +08:00
Guo Xiang Tan fbe51d68a7 SECURITY: Ensure that user has been authenticated. 2017-02-24 10:47:48 +08:00
Sam Saffron 3754b038e8 fix brotli origin 2017-02-23 18:26:40 -05:00
Sam f15f61da0a FEATURE: add immutable caching to rails site of things 2017-02-23 13:05:00 -05:00
Jeff Atwood ad6cb3c638 force all iOS editors to minimum height for compat 2017-02-22 16:56:19 -08:00
Jeff Atwood 22fc761cc3 tweak iOS composer heights a bit 2017-02-22 15:48:39 -08:00
Neil Lalonde c00ffabac3 search scope checkbox is default checked for your messages too 2017-02-22 17:45:12 -05:00
Neil Lalonde 0551b3f5ee FEATURE: replace emoji with unicode in title and description meta tags 2017-02-22 16:24:13 -05:00
Sam Saffron 0fc2b64f65 attempt 2 at adjusting class definition so its more easily extensible 2017-02-22 14:18:43 -05:00
Sam Saffron 08d56952df revert change, it is required 2017-02-22 14:10:55 -05:00
Sam Saffron d0d60ffa89 make is slightly easier to extend 2017-02-22 14:06:18 -05:00
Neil Lalonde 57784ddf2b remove unused setting import 2017-02-22 13:05:57 -05:00
Rafael dos Santos Silva 5296f00c28 FEATURE: Allow checking the raw response of a bounced email 2017-02-22 14:51:33 -03:00
Neil Lalonde 00700da6b8 remove null class 2017-02-22 12:23:45 -05:00
Neil Lalonde 53ec4c44f4 FIX: N+1 in topic_list 2017-02-22 12:20:50 -05:00
Neil Lalonde a702330ccd FEATURE: make show_subcategory_list a per-category setting 2017-02-22 11:42:36 -05:00
Arpit Jalan 2f657b0e32 FIX: do not refresh staff action logs every time the page is loaded 2017-02-22 17:25:39 +05:30
Arpit Jalan 213a496203 FIX: show all staff events related to the target user 2017-02-22 13:31:40 +05:30
Jeff Atwood c191e2e84c more conservative editor heights on iOS 2017-02-21 16:25:46 -08:00
Neil Lalonde c94fdcea38 FIX: admin dashboard posts count should not include system posts and whispers 2017-02-21 14:45:41 -05:00
Arpit Jalan c216f59eaa fix the build 2017-02-22 00:43:37 +05:30
Sam Saffron ce7c3bfc14 FIX: refresh header if message bus updates topic 2017-02-21 11:43:44 -05:00
Arpit Jalan 046cbad10b FEATURE: add a button on admin user page that links to action log 2017-02-21 21:38:37 +05:30
Neil Lalonde b19dfba497 FIX: tag link in breadcrumbs on subfolder installs 2017-02-21 10:41:08 -05:00
Arpit Jalan 068ce19ae2 FEATURE: linked topics should be rendered under posts for crawlers 2017-02-21 12:43:24 +05:30
Neil Lalonde 1dda998a4e FEATURE: search should default scope to current category or user 2017-02-20 17:02:02 -05:00
Neil Lalonde 476ae57af3 FEATURE: primary group class on avatars in topic list 2017-02-20 15:55:10 -05:00
Jakub Macina 4a2f13348a ADD: Append tags bulk action for topics 2017-02-20 18:14:32 +01:00
Neil Lalonde aa2c527c60 Remove "From" from every post in Popular Posts section of summary emails 2017-02-20 11:04:12 -05:00
Régis Hanol 3ce3abef8f FIX: add Content-Disposition and Content-Type headers when downloading attachments 2017-02-20 15:59:01 +01:00
Régis Hanol fd62909819 UX: prevent post submission when uploading 2017-02-20 15:12:33 +01:00
Régis Hanol 97116c9276 Merge pull request #4714 from gdpelican/expose-safari-ua
Allow access to safari hack applicable function
2017-02-20 14:58:33 +01:00
James Kiesel 7dc0e11360 Rename exported function 2017-02-21 02:53:16 +13:00
Régis Hanol f51e3b2131 FIX: should not be able to rename a system badge 2017-02-20 14:35:05 +01:00
James Kiesel ffe41c9ae8 Allow access to safari hack applicable function 2017-02-21 02:32:01 +13:00
Régis Hanol cb99f59ec3 reset bounce score when email is successfully changed 2017-02-20 10:37:01 +01:00
Victor van Poppelen b501c3c6c6 desktop/topic.scss: fix responsive width
#topic-closing-info max-width fix for responsive issues below 757px
2017-02-19 18:30:19 -08:00
Neil Lalonde a6ebe495bf FEATURE: links that can't have no onebox can be used as featured topic links 2017-02-17 18:35:19 -05:00
Robin Ward bebc55eebd FIX: Users page wasn't loading more on mobile 2017-02-17 16:36:45 -05:00
Robin Ward 41db9e0d94 FIX: Silence CSS errors in Safari 2017-02-17 16:21:35 -05:00
Sam 1b6a801d35 forgot import 2017-02-17 16:17:44 -05:00
Sam 7d8a11f636 Add header-topic-info:after-tags extension point 2017-02-17 15:59:52 -05:00
Robin Ward e62c0a42fa FIX: Support multiple embeddable host records with the same host 2017-02-17 12:41:34 -05:00
Sam 1935f624b8 FEATURE: reset active record cache in sidekiq if needed
This can happen in multisite environments after restores
2017-02-17 12:09:53 -05:00
Neil Lalonde 3fb50d587d FIX: invited users and new TL1 users will see their first notification highlighted 2017-02-17 10:30:29 -05:00
Jeff Atwood a6dd1a2cd4 onebox last para needs less bottom margin 2017-02-16 15:39:46 -08:00
Neil Lalonde 868c489d5e FIX: plugin outlets in navigation bar need to be li elements instead of div and span 2017-02-16 15:08:13 -05:00
Neil Lalonde 6bb9c5ceee remove old code for global username registry 2017-02-16 13:06:37 -05:00
Régis Hanol 269f6e8c30 UX: top referrers headings are not numbers 2017-02-16 15:58:45 +01:00
Jeff Atwood 1444025e9c remove CSS table layout from user prefs page 2017-02-16 02:01:20 -08:00
Jeff Atwood e6c6a9e2d3 minor user card spacing tweak 2017-02-16 01:49:29 -08:00
Jeff Atwood 34223dca4e minor CSS fix for custom user fields on user cards 2017-02-16 01:45:20 -08:00
Jeff Atwood 311b983c59 minor copyedit 2017-02-16 01:31:21 -08:00
Neil Lalonde 3e4dd513c9 show that password is optional on label 2017-02-15 19:59:16 -05:00
Jeff Atwood f831e92c42 copyedit to improved invite page 2017-02-15 16:11:34 -08:00
Sam Saffron 040e10a627 reduce duplication 2017-02-15 17:27:10 -05:00
Neil Lalonde 4b28bfaa15 Merge pull request #4710 from ento/fix-s3-config-check
FIX: admin dashboard shouldn't complain when using IAM profile for S3 access
2017-02-15 17:02:07 -05:00
Neil Lalonde d0fbb27f3e FEATURE: new invite acceptance page, where username can be chosen and password can be set 2017-02-15 16:51:57 -05:00
Sam 3818c196e0 remove disallowed params 2017-02-15 16:47:14 -05:00
Sam 023bd0e9e7 FEATURE: allow client side of topic list to accept custom params
- Also normalize API version to use a version comparison function instead of float
2017-02-15 16:14:43 -05:00
Sam 74d4209d24 FEATURE: allow plugins to register custom topic list filters 2017-02-15 15:25:43 -05:00
Sam 9c51e3e8e7 amend preloader api to supply topic list 2017-02-15 12:04:02 -05:00
Sam 2c59ffeb2c FIX: token rotation not accounting for overlapping tokens correctly
also... freeze_time has no block form, correct all usages and specs
2017-02-15 10:58:18 -05:00
Marica Odagaki a9a585f66a Use && and || consistently so that there's less chance of copy paste errors in the future 2017-02-15 00:25:49 -08:00
Marica Odagaki 3bb1b98b0e FIX: admin dashboard shouldn't complain when using iam profile for s3 access
Previous code wasn't working as intended because it was parsed as

    (bad_keys = (access_key or secret_key)) and !use_iam_profile

because of Ruby's operator precedence: `=` binds more eagerly than `and`.

http://ruby-doc.org/core-2.3.1/doc/syntax/precedence_rdoc.html

See also: https://github.com/bbatsov/ruby-style-guide#no-and-or-or
2017-02-15 00:22:14 -08:00
Sam 8409f42352 Add outlet for injecting custom tags 2017-02-14 17:40:13 -05:00
Sam f2099c3811 adjust API 2017-02-14 16:32:33 -05:00
Sam 89d5e8ab4b FEATURE: allow plugins to preload data in topic list 2017-02-14 16:29:06 -05:00
Sam 5346cd3514 correct the test 2017-02-14 09:34:39 -05:00
Sam c52784f9d2 FIX: race condition when marking tokens as seen
- in rare conditions can lead to users being logged off
2017-02-14 09:34:09 -05:00
Sam 0ab96a7691 FEATURE: add hidden setting for verbose auth token logging
This is only needed to debug auth token issues, will result in lots
of logging
2017-02-13 14:01:09 -05:00
Robin Ward 0e58e393a1 FIX: === and a better constant, thanks @ZogStriP 2017-02-13 13:14:19 -05:00
Robin Ward 9d4405d602 Don't add an empty class to the list elements in the hamburger 2017-02-13 11:28:10 -05:00
Sam 07b9c351a4 Merge pull request #4705 from vinothkannans/dev
new: server plugin outlet for indexable robots.txt
2017-02-13 11:18:51 -05:00
Robin Ward e1d358ffbf FIX: Don't clear the login hint when the system user is saved 2017-02-13 10:54:20 -05:00
Vinoth Kannan 08c14dd689 new: server plugin outlet for indexable robots.txt 2017-02-13 17:31:10 +05:30
Nicolas 1deec95ccb Use `natural` orientation for web app manifest.
The `any` orientation forces the rotation even when the device's screen
 rotation is disabled. Using `natural` respects that and restores the
 expected behaviour.
2017-02-12 18:04:06 +00:00
Jeff Atwood 22c83b0a20 Merge pull request #4700 from gsambrotta/replay-btn-position
fix replay btn position on mobile and desktop
2017-02-11 22:21:11 -08:00
Jeff Atwood 3ee7a9266c Merge pull request #4686 from tgxworld/group_is_visible_if_user_is_group_owner
FIX: Show groups that user is owner of on groups page.
2017-02-11 22:18:44 -08:00
Vinoth Kannan 1b43c209eb 'Article' to 'DiscussionForumPosting' schema type
topic => https://meta.discourse.org/t/invalid-article-schema/57037
Replacing '[Article](https://schema.org/Article)' schema type with '[DiscussionForumPosting](https://schema.org/DiscussionForumPosting)'
2017-02-11 18:44:40 +05:30
Sam 675cb1c715 FEATURE: allow registrations of custom small action icons via plugins 2017-02-10 12:55:21 -05:00
giorgia 8c6d0ecd64 fix replay btn position on mobile and desktop 2017-02-10 17:11:10 +01:00
Sam Saffron 4332f0dde1 FEATURE: allow user search API to restrict to group 2017-02-09 18:45:39 -05:00
Neil Lalonde d68dd5b967 Revert "UX: Observe changes to plugin to hide/show plugin admin link without refresh." 2017-02-09 12:11:53 -05:00
Jeff Atwood 77033f4855 simpler twitter onebox CSS that works everywhere 2017-02-08 17:18:53 -08:00
Jeff Atwood 933af0b40e align onebox twitter date 2017-02-08 17:14:11 -08:00
Jeff Atwood 485c36141c onebox right padding should not be asymmetric 2017-02-08 17:11:19 -08:00
Jeff Atwood fe32c64dd9 FIX: twitter onebox styling was poor on mobile 2017-02-08 17:08:40 -08:00
Jeff Atwood 3b4248b454 add primary class to password reset button 2017-02-08 16:11:24 -08:00
Neil Lalonde e077b3f141 FIX: composer should only feature links to external sites 2017-02-08 15:34:54 -05:00
Neil Lalonde 581d477ff3 add a comment because I can never find the mailing list summary email 2017-02-08 12:13:29 -05:00
Régis Hanol f07b4b310a should not have renamed this setting in 460665895c 2017-02-08 18:11:34 +01:00
Sam 53ea8942e8 action to be reserved for assigned plugin 2017-02-08 12:10:16 -05:00
Arpit Jalan 75f154b177 bump onebox 2017-02-08 12:08:41 +05:30
Jeff Atwood 7c9f8cb245 attempt to manually revert PR https://github.com/discourse/discourse/pull/4600
I hate that PR with the fire of a thousand suns
2017-02-07 17:15:12 -08:00
Neil Lalonde a5dfcddc6c FIX: crawler view of paginated content should have link elements in head for next and previous pages 2017-02-07 16:11:12 -05:00
Sam f34907b523 Merge pull request #4681 from vietqhoang/feature/add-user-title-to-sso-payload
FEATURE: Add user title to SSO payload
2017-02-07 10:25:32 -05:00
Sam 634755113a Merge branch 'new_user_auth' 2017-02-07 09:23:02 -05:00
Sam ff49f72ad9 FEATURE: per client user tokens
Revamped system for managing authentication tokens.

- Every user has 1 token per client (web browser)
- Tokens are rotated every 10 minutes

New system migrates the old tokens to "legacy" tokens,
so users still remain logged on.

Also introduces weekly job to expire old auth tokens.
2017-02-07 09:22:16 -05:00
Neil Lalonde ece979efd1 add tags to webcrawler view of a topic in an ItemList 2017-02-06 18:12:48 -05:00
Neil Lalonde 9ec000407f FIX: tags shouldn't be listed as breadcrumbs in web crawler view 2017-02-06 17:35:54 -05:00
Sam 2dec731da3 SECURITY: correctly validate input when admin searches for screened ips 2017-02-06 16:11:16 -05:00
Neil Lalonde 8643620172 automatically redirect when password reset completes successfully 2017-02-06 15:04:58 -05:00
Arpit Jalan 68653801bc Merge pull request #4690 from techAPJ/pdf-onebox
UX: CSS for pdf onebox
2017-02-07 00:05:57 +05:30
Arpit Jalan 0c0da86e0c UX: CSS for pdf onebox 2017-02-07 00:04:01 +05:30
Neil Lalonde e82240fbd9 autofocus password field on password reset page, and remove static password length message 2017-02-06 12:46:02 -05:00
Régis Hanol 84af84dc52 prevent inactive & staged users from being automatically added to a group 2017-02-06 17:49:27 +01:00
Régis Hanol 27fb9c8804 FIX: bounce webhooks should also use recipient address 2017-02-05 19:06:35 +01:00
Robin Ward f1e7bca3c9 FEATURE: Warn a user when they're replying to the same user too much 2017-02-03 17:00:54 -05:00
Neil Lalonde c4e10f2a9d FEATURE: redesign the change password page to use javascript and validations 2017-02-03 16:09:24 -05:00
Robin Ward b251d11518 FIX: If you make a new banner, clear the old dismissed values 2017-02-03 15:07:38 -05:00
Neil Lalonde ae671355da FIX: add /tags routes to robots.txt 2017-02-03 11:57:00 -05:00
Arpit Jalan 5523d0dbf9 fix the build 2017-02-03 15:35:33 +05:30
Arpit Jalan 26ccf61ab1 FIX: sane error message when inviting an existing user 2017-02-03 14:27:27 +05:30
Guo Xiang Tan 61111a3f9b FIX: Show groups that user is owner of on groups page. 2017-02-03 16:51:32 +08:00
Arpit Jalan 67669c00c5 FIX: incorrect instructions when inviting user to forum 2017-02-03 13:49:07 +05:30
Arpit Jalan 6b8691ecea Merge pull request #4685 from techAPJ/approve-users-invite-fix
FIX: allow existing users to be invited to topic/message when must_approve_users is enabled
2017-02-03 13:22:18 +05:30
Guo Xiang Tan f9255631e3 FIX: Group owners don't see group owner functions when navigating from user page. 2017-02-03 15:31:47 +08:00
Arpit Jalan dc2171960b FIX: allow existing users to be invited to topic/message when must_approve_users is enabled 2017-02-03 13:01:23 +05:30
Guo Xiang Tan ec73224b5e PERF: Remove N+1 query when saving a user. 2017-02-03 15:03:33 +08:00
Guo Xiang Tan 7a243e859e FIX: Search menu widget breaks when context type is `null`. 2017-02-03 09:38:51 +08:00
Neil Lalonde b91cb92af0 FIX: reports for time to first reply and topics without replies were counting whispers and moderator actions 2017-02-02 17:27:41 -05:00
Sam 06570f8e5a UX: less restrictive selector to allow for plugin outlets
Currently plugin outlets in LIs will generate a wrapping SPAN,
this makes an allowence in core for nave extenstions (like solved does)
2017-02-02 12:18:03 -05:00
Robin Ward 44f913b9b8 FIX: Incorrect title on admin reports 2017-02-02 10:56:12 -05:00
Guo Xiang Tan 3c28d94706 FIX: Don't configure Redis connector if Redis slave config is not set. 2017-02-02 13:48:55 +08:00
Rafael dos Santos Silva c34520d384 FIX: eslint was broken 2017-02-02 01:12:49 -02:00
Robin Ward cef8a0af34 Merge pull request #4657 from gdpelican/reopen-widget
Add reopenWidget method
2017-02-01 13:18:55 -05:00
Robin Ward 0f3dabb54c FIX: Hover text was showing incorrect number 2017-02-01 13:16:32 -05:00
Guo Xiang Tan 18007ed34b FIX: Can't use an internal name here if `SiteSetting.convert_pasted_images_to_hq_jpg` is `false`. 2017-02-01 14:51:56 +08:00
Guo Xiang Tan f6d9745c5f Bye bye byebug. 2017-02-01 14:50:14 +08:00
Guo Xiang Tan 6c8c91dca4 UX: Change default filename for images that have been pasted. 2017-02-01 14:44:41 +08:00
Guo Xiang Tan d449f782a3 Revert "FIX: Don't skip callbacks when rebaking posts."
This reverts commit 06c651f8c9.

If site settings are changed, there is a chance that the post
will fail PostValidator's validations.
2017-02-01 10:52:15 +08:00
Viet Hoang 40164ccd4a Add user title to SSO payload 2017-01-31 16:42:27 -08:00
James Kiesel 816a030f78 Bump plugin api to 0.7 2017-02-01 11:05:47 +13:00
Guo Xiang Tan 0f2de4863b Make Eslint happy. 2017-01-31 10:45:04 +08:00
Guo Xiang Tan 058df4329d FIX: Escape escape regexp characters. 2017-01-31 10:39:45 +08:00
Robin Ward d4bbdcd7d6 Raise an error if a widget doesn't have a key but uses state 2017-01-30 12:02:55 -05:00
Arpit Jalan 19f7beaa2c FIX: topic links were getting dropped when post is rebaked 2017-01-30 14:55:53 +05:30
Robin Ward e3670c52fa FIX: Don't route to a weird blank page when public profiles are disabled 2017-01-27 12:45:40 -05:00
Guo Xiang Tan 881986636c Fix "saving" message not dismissing when editing posts. 2017-01-27 21:30:28 +08:00
Leo McArdle c76f6856ea FEATURE: reply as new message to the same recipients 2017-01-27 12:24:31 +08:00
Guo Xiang Tan c01cee4aa6 PERF: N+1 query when saving a user. 2017-01-27 10:53:42 +08:00
Guo Xiang Tan 156a00af47 UX: Show edit button on post revision modal as long as user can edit. 2017-01-27 10:49:17 +08:00
Neil Lalonde 396526621b FIX: reply buttons and tooltips untranslated in all languages 2017-01-26 16:45:40 -05:00
Neil Lalonde 0e8808fbe8 FIX: bulk change tags works with category tag settings 2017-01-26 16:36:53 -05:00
Neil Lalonde 6e47e02738 FIX: edit category modal throws EmberError when allowed tag groups is set 2017-01-26 15:32:24 -05:00
Rafael dos Santos Silva 60f30aa6ad UX: Remove 'no thanks' from remind tomorrow CTA 2017-01-26 17:47:52 -02:00
Sam 06638c78e7 Merge pull request #4617 from claygriffiths/trailingslash-message-bus
Fix: Forced trailing slash on messageBus.baseUrl
2017-01-26 12:03:06 -05:00
Robin Ward 496682c442 Merge pull request #4662 from tgxworld/fix_localized_group_name_change
Fix localized group name change
2017-01-26 10:50:00 -05:00
Robin Ward a7ba69075b Merge pull request #4667 from joebuhlig/user-nav-plugin-outlet
FEATURE: Add user-main-nav plugin outlet
2017-01-26 10:48:24 -05:00
Régis Hanol 810176be5b Merge branch 'master' into master 2017-01-26 10:56:25 +01:00
Jeff Atwood 43a8a7c812 de-emphasize display mode buttons on revision view 2017-01-26 00:02:19 -08:00
Guo Xiang Tan ee7c7c347a Merge pull request #4673 from tgxworld/edit_post_button_wiki_post_revision
Add edit post button to post revision modal for wiki-ed posts.
2017-01-26 13:33:55 +08:00
Guo Xiang Tan bed11dfa0e FIX: Polls permanently broken if post requires approval. 2017-01-26 13:29:43 +08:00
Arpit Jalan 9dd09e453b FEATURE: add explicit confirmation button to accept the invite 2017-01-25 15:50:30 +05:30
Guo Xiang Tan 06c651f8c9 FIX: Don't skip callbacks when rebaking posts. 2017-01-25 17:47:13 +08:00
Guo Xiang Tan ee396edd9c Add edit post button to post revision modal for wiki-ed posts. 2017-01-25 14:36:00 +08:00
Guo Xiang Tan 781d83a46f FIX: Toggling a post's wiki status should not skip revision. 2017-01-25 13:34:55 +08:00
Guo Xiang Tan efc21366ae FIX: Incorrect parameter being passed to component. 2017-01-25 13:12:38 +08:00
Guo Xiang Tan 0a25df67bc Revert "FIX: Incorrect parameter being passed to component."
This reverts commit d354a6f7a4.
2017-01-25 13:12:24 +08:00
Guo Xiang Tan d354a6f7a4 FIX: Incorrect parameter being passed to component. 2017-01-25 13:09:08 +08:00
Neil Lalonde ff508ed75f UX: red notification of flags or pending approvals opens hamburger menu instead of linking to flags page 2017-01-23 14:34:06 -05:00
Régis Hanol 7e52d29a5b Merge pull request #4643 from LeoMcA/fix-pull-img
FIX: Handle img src starting with "//" in pull_hotlinked_images job
2017-01-23 17:56:53 +01:00
Joe Buhlig 60c2787e64 FEATURE: Add user-main-nav plugin outlet 2017-01-20 07:15:07 -06:00
Guo Xiang Tan 32846aad2a FIX: Toggling post's wiki status should not create a new version. 2017-01-20 15:42:33 +08:00
Neil Lalonde 6b93b09404 FIX: when blocking a user results in hiding their posts, only hide posts made in the last 24 hours 2017-01-19 15:56:22 -05:00
Leo McArdle e4ad88019b add category-navigation plugin outlet 2017-01-19 17:35:22 +00:00
Arpit Jalan 0791c2c966 FIX: sso_overrides_avatar should override previously set avatar 2017-01-19 10:52:24 +05:30
Neil Lalonde 61d4c1203e FEATURE: group avatar flair shows on topic participants list, and participant avatars can have custom styles 2017-01-18 11:38:00 -05:00
Jeff Atwood 095ec9cf63 minor css change to user page 2017-01-18 01:11:49 -08:00
Guo Xiang Tan 706b4f6b9f FEATURE: Remap group mentions when group name has been changed. 2017-01-18 13:39:34 +08:00
Guo Xiang Tan 59dfb51a35 FIX: Don't change automatic group name if localized name has been taken. 2017-01-18 12:20:23 +08:00
Neil Lalonde bfc52a8e6f FIX: long titles need a max-width in composer when replying on desktop view 2017-01-17 15:14:58 -05:00
Robin Ward 0c71e37aab Merge pull request #4660 from ryantm/serversideonly
add more SERVER_SIDE_ONLY routes; use pathname in matching
2017-01-17 13:55:40 -05:00
Ryan Mulligan f641655f1b add more SERVER_SIDE_ONLY routes; use pathname in matching 2017-01-17 09:51:39 -08:00
Robin Ward 11641fb3cd Whitelist the alternative `raw` url 2017-01-17 11:11:27 -05:00
Guo Xiang Tan fc52624aac Fix undefined `attrs`. 2017-01-17 16:31:57 +08:00
Guo Xiang Tan ee58c4cd94 FIX: Don't close search menu on link clicked when context is enabled. 2017-01-17 12:35:48 +08:00
Guo Xiang Tan de6ca4f736 FIX: Pressing enter when searchContext is enabled should just trigger a search. 2017-01-17 11:01:33 +08:00
Guo Xiang Tan c76ee788a7 Merge pull request #4656 from tgxworld/dont_display_an_extra_button_for_wiki_post
UX: Display wiki icon on post edits indicator.
2017-01-17 06:34:43 +08:00
Guo Xiang Tan 17da0bd11f UX: Display wiki icon on post edits indicator. 2017-01-17 06:33:58 +08:00
Neil Lalonde 60a9030d25 UX: don't show search and hamburger menus to anon visitors on login-required sites 2017-01-16 16:33:14 -05:00
James Kiesel 1d8882a1dd oops semicolons 2017-01-17 08:20:57 +13:00
James Kiesel 646b49e5ae Expose reopenWidget through plugin api 2017-01-17 08:19:29 +13:00
Régis Hanol fbf9172db8 FIX: log backups download/destroy staff action
FIX: clean up junk left by the specs
RENAME: 'backup_operation' to 'backup_create' to match other backup log types
2017-01-16 19:53:31 +01:00
Rafael dos Santos Silva 116e74325a FIX: Topic Status should display on categories and topic view 2017-01-16 15:04:33 -02:00
Robin Ward 5f7a33efe5 FIX: [object Object] when hovering over view count 2017-01-16 12:02:32 -05:00
Robin Ward 3db3ee65b7 UX: Make it easier for plugins to add stuff before topics on the list 2017-01-16 11:53:09 -05:00
Robin Ward 86c52c72f6 FIX: Deleting a user was not deleting their directory items 2017-01-16 11:46:52 -05:00
James Kiesel 513f570936 Add reopenWidget method 2017-01-17 00:39:23 +13:00
Leo McArdle b60e9b7330 FIX: Handle img src starting with "//" in pull_hotlinked_images job 2017-01-16 10:50:07 +00:00
Guo Xiang Tan 63954c1b33 FIX: Same user record being saved twice causing validation to fail. 2017-01-16 16:41:03 +08:00
Guo Xiang Tan e3b6f9b8ae FIX: Do not update user stats like counts for private messages. 2017-01-16 11:07:53 +08:00
Guo Xiang Tan ed5fa20b0c Revert "FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level"
This reverts commit 9c40657ba4.

Calling this whenever a user is initialize is hurting us bad
on performance.
2017-01-16 09:44:10 +08:00
Jeff Atwood 56abe065bc tighten header margin on onebox 2017-01-14 22:11:46 -08:00
cpradio d0a3dc10d8 FIX: RSS Language should use a dash/hypen instead of underscore 2017-01-14 14:24:21 -05:00
Robin Ward 5f08630c27 Update topic status to use more ES6 features, clean up 2017-01-13 15:49:31 -05:00
Neil Lalonde e8307ac24c FIX: mailing list mode digest emails included whispers 2017-01-13 13:46:33 -05:00
Robin Ward adb73180f7 FEATURE: Let plugins register themes easily 2017-01-13 11:50:52 -05:00
Guo Xiang Tan 0f574f641e UX: Truncate topic link title/URL on desktop to prevent overflow. 2017-01-12 12:24:39 +08:00
Guo Xiang Tan 515f50e42e FEATURE: Log admin action when readonly mode is changed. 2017-01-12 09:41:02 +08:00
Jeff Atwood 240c4870cf FIX: add noopener to website field in user profile 2017-01-11 15:38:37 -08:00
Régis Hanol 887e9af84f FEATURE: new 'max_image_megapixels' site setting 2017-01-11 23:37:12 +01:00
Robin Ward 6c3426d266 Let's not notify for trust levels on Staff, either 2017-01-11 11:25:04 -05:00
Arpit Jalan e793caf3e3 FIX: only allow CSV file to be uploaded for bulk invite 2017-01-11 16:26:01 +05:30
Guo Xiang Tan d6bf5b0e78 Use `any` orientation for web app manifest. 2017-01-11 17:32:24 +08:00
Guo Xiang Tan 1758af9a1d FIX: Perform emoji unescape for topic titles in quotes. 2017-01-11 17:23:13 +08:00
Guo Xiang Tan cdd550e947 Use a different Redis key when PG failover sets site to readonly mode. 2017-01-11 16:38:49 +08:00
Guo Xiang Tan 77045eb1f1 Merge pull request #4644 from olach/tab-size
Display tabs with smaller widths for code blocks
2017-01-11 14:49:16 +08:00
Neil Lalonde 98bd58df61 Don't show email of deleted users in staff action logs 2017-01-10 17:25:36 -05:00
Neil Lalonde fc0a0a76a4 Add more info in staff action logs for blocking a user, and add logging for lock trust level, activate, and deactive user 2017-01-10 17:25:36 -05:00
Robin Ward 7341b0d03c Don't give notifications to admins for trust level notifications 2017-01-10 12:18:48 -05:00
Ola Christensson 82fab2343f Display tabs with smaller widths for code blocks
The default browser behavior is a tab width of 8 characters. This changes the width to 4 characters.
2017-01-10 10:06:53 +01:00
Robin Ward b60bc47a4c Plugins can register providers for global settings 2017-01-09 17:18:58 -05:00
Neil Lalonde d9146de080 FIX: an image can be shown twice in summary emails 2017-01-09 13:27:43 -05:00
Guo Xiang Tan 3d21ccd4a5 FIX: Add validation to disallow censored words in topic title. 2017-01-09 16:55:41 +08:00
Guo Xiang Tan cbc6aee137 UX: Display large numbers with delimiters. 2017-01-09 15:56:02 +08:00
Guo Xiang Tan aa9ac0d8b2 Make eslint happy. 2017-01-09 13:59:00 +08:00
Guo Xiang Tan fed7218deb UX: Observe changes to plugin to hide/show plugin admin link without refresh. 2017-01-09 13:56:15 +08:00
Guo Xiang Tan e721e31699 FIX: Login modal on mobile does not submit on enter. 2017-01-09 13:20:53 +08:00
Guo Xiang Tan 98df6db0eb FIX: Respect site setting to hide username in mailing list summary. 2017-01-09 12:18:30 +08:00
Guo Xiang Tan 4a7d6ea751 Make eslint happy. 2017-01-09 11:24:55 +08:00
Guo Xiang Tan c260a4e34d FIX: Can't add categories when creating a new web hook. 2017-01-09 11:22:35 +08:00
Arpit Jalan c834d591a3 use Ember.set() to set the `dasherized_name` property 2017-01-06 23:13:31 +05:30
Robin Ward 1b92d44fb2 FIX: A component referenced the controller 2017-01-06 10:45:48 -05:00
Guo Xiang Tan 389e1d0bd5 Add acceptance JS tests for group membership button. 2017-01-06 11:56:10 +08:00
Guo Xiang Tan a4e7657bbf FIX: Missing action to show login modal on group page. 2017-01-06 11:40:32 +08:00
Guo Xiang Tan 68300f515c FIX: Return 404 if id is not valid. 2017-01-06 10:39:44 +08:00
Guo Xiang Tan d10fe51b72 Fix broken specs since all urls will be oneboxed. 2017-01-06 10:05:51 +08:00
Neil Lalonde 685e6bdbab FIX: tags canonical url can raise error or be wrong 2017-01-05 15:17:23 -05:00
Robin Ward 7c8095294d FIX: Raw plugin outlets were broken 2017-01-05 11:38:57 -05:00
Claas Augner bec10ada2a
Remove unused email templates from controller 2017-01-05 15:31:14 +01:00
Arpit Jalan 6d26e348b6 FIX: 'add permalink' feature was broken 2017-01-05 18:50:17 +05:30
Régis Hanol 937ea5e9c3 Merge pull request #4636 from caugner/fix-translate-titles-of-email-templates
FIX: Translate titles of email templates
2017-01-05 09:48:12 +01:00
Régis Hanol caf704068c Merge pull request #4635 from caugner/fix-add-emoji-custom-class
FIX: Add emoji-custom class in custom emojis list.
2017-01-05 09:47:30 +01:00
Régis Hanol 6f396a0881 Merge pull request #4637 from caugner/ux-add-icon-for-bookmarks-report
UX: Add icon for bookmarks report
2017-01-05 09:47:05 +01:00
Arpit Jalan 7a1ff59822 FIX: PM email to suspended member was broken 2017-01-05 13:58:14 +05:30
Claas Augner 9710b04c31
UX: Add icon for bookmarks report 2017-01-05 02:07:38 +01:00
Claas Augner ad86d4a3e3
FIX: Translate titles of email templates 2017-01-05 01:26:38 +01:00
Claas Augner 2c723f8323
FIX: Add emoji-custom class in custom emojis list. 2017-01-04 23:54:03 +01:00
Robin Ward 846cd523b6 FIX: Broken plugin outlet 2017-01-04 11:52:19 -05:00
Régis Hanol cbcb9363f4 fix the build 2017-01-04 14:23:21 +01:00
Guo Xiang Tan 5098baee2f FIX: Undefined variable. 2017-01-04 17:37:23 +08:00
Guo Xiang Tan 43d950f813 FIX CSS for autocomplete. 2017-01-04 12:37:02 +08:00
Guo Xiang Tan 43671b1fda UX: Display group fullname in mention autocomplete. 2017-01-04 11:40:14 +08:00
Jeff Atwood 878af4c8b1 add tiny bit of space to email summary 2017-01-03 15:45:29 -08:00
Jeff Atwood 4e44845714 de-emphasize onebox URL field with color 2017-01-03 14:08:56 -08:00
Jeff Atwood b58a6804c2 reduce font size on mobile prog expansion 2017-01-03 11:17:12 -08:00
Neil Lalonde 9c79bf1865 FIX: .bullet + .topic-header-extra pixel perfect vertical alignment 2017-01-03 14:00:14 -05:00
Rafael dos Santos Silva d3fb724578 Merge pull request #4632 from xfalcox/native-app-banner
FEATURE: Opt-in native Discourse app install banner
2017-01-03 16:32:24 -02:00
Robin Ward 1bf912f3ac FIX: Back button was not working in long topics with many deleted 2017-01-03 13:17:11 -05:00
Rafael dos Santos Silva d7c8c2d5e3 FEATURE: Opt-in native Discourse app install banner on Android/iOS 2017-01-03 15:50:45 -02:00
Robin Ward bee8425055 FIX: Don't reply as new topic when quoting a closed topic 2017-01-03 11:49:20 -05:00
Neil Lalonde b72014423e FIX: summary email wrong background colour above popular posts 2017-01-03 11:05:54 -05:00
Arpit Jalan 615fd2eb87 UX: sane max-height for onebox images 2017-01-03 21:06:49 +05:30
Guo Xiang Tan a9a0e626db FIX: Group page tabs not displaying for normal users. 2017-01-03 17:56:13 +08:00
Guo Xiang Tan ad4a96d387 FIX: Only send membership request to the last 5 active group owners. 2017-01-03 15:33:57 +08:00
Guo Xiang Tan 7ce4bc2e90 UX: Show spinning icon while group members load. 2017-01-03 14:58:14 +08:00
Guo Xiang Tan 3aed15c99e FIX: Group membership button now showing properly. 2017-01-03 14:36:56 +08:00
Guo Xiang Tan 761d524024 Merge pull request #4602 from tgxworld/fix_likes_being_quoted
FIX: Only quote `.cooked` text.
2017-01-03 14:02:21 +08:00
Guo Xiang Tan 8a4e9c1940 Merge pull request #4633 from xfalcox/resize-emoji-full-path
FIX: Use full path for emoji resize job
2017-01-03 14:00:00 +08:00
Guo Xiang Tan 980cea7081 FIX: Add length validation for `User#name`. 2017-01-03 13:42:33 +08:00
Guo Xiang Tan 1cf0401e26 Allow option to not include title on emoji images. 2017-01-03 11:07:55 +08:00
Guo Xiang Tan ecb1078343 FIX: `user-card-post-names` outlet should be a `div`. 2017-01-03 10:39:41 +08:00
Guo Xiang Tan 40deef32e3 UX: Automatic width for fontawesome icons on groups page. 2017-01-03 10:07:59 +08:00
Jeff Atwood bbb3217f6a add opacity to quote button 2017-01-02 14:17:09 -08:00
Rafael dos Santos Silva 9ee67ad89c FIX: Use full path for emoji resize job 2017-01-02 13:34:32 -02:00
Régis Hanol c4552ef8c1 slightly shorter regexp for OptimizedImage.safe_path? 2017-01-02 16:28:14 +01:00
Régis Hanol d8be3e8bb1 UX: ensure we only allow images when uploading an avatar, user card background, etc... 2017-01-02 11:37:56 +01:00
Jeff Atwood 5db57abd7f fix onebox header misalignment issue 2017-01-02 02:22:57 -08:00
Jeff Atwood cd5130258d minor tweaks to mobile progress bar overlay 2017-01-02 02:06:26 -08:00
Neil Lalonde 225e6703ba FIX: summary shows 0 new topics even though it shows some topics 2016-12-30 15:18:13 -05:00
Robin Ward 32301f4620 FIX: Forgot Password route was broken 2016-12-30 12:47:04 -05:00
Robin Ward da76dd3d6b REFACTOR: Cleaner `quoteButton` object, and some bug fixes 2016-12-30 12:14:56 -05:00
Neil Lalonde 477b237e45 FIX: use 'other' instead of 'many' for Ukrainian pluralization until translations are fixed 2016-12-30 11:49:25 -05:00
Guo Xiang Tan c8553315b4 UX: Add `min-width` to `.select2-container`. 2016-12-30 14:38:53 +08:00
Guo Xiang Tan dbd0fcc86d UX: Add border to `.modal-header` on mobile. 2016-12-30 13:58:37 +08:00
Guo Xiang Tan f1beef43a8 Merge pull request #4618 from tgxworld/fix_invalid_emails
FIX: Don't allow invalid email to be saved.
2016-12-30 07:11:48 +08:00
Neil Lalonde 0f484e11fe FIX: Popular Posts heading in summary emails was a different style than other headings 2016-12-29 15:33:53 -05:00
Neil Lalonde 0105a406d4 FIX: spacing and alignment of title, category, tags, and featured links in topic page heading on mobile and desktop 2016-12-29 14:59:30 -05:00
Neil Lalonde 9fad338650 FIX: tags weren't showing on /top 2016-12-29 14:07:33 -05:00
Robin Ward 61584f6c0c UX: Improve composer heights in some resolutions 2016-12-29 12:51:57 -05:00
Arpit Jalan a1f0375f1c FIX: correct route for updating user title 2016-12-29 23:07:57 +05:30
Régis Hanol 1debf98d61 Merge pull request #4629 from caugner/fix-user-index-translate-boolean-values
FIX: Translate all boolean values in user index
2016-12-29 14:46:45 +01:00
Régis Hanol f71040dc23 Merge pull request #4630 from caugner/feature-preserve-cursor-in-editor-upload
FEATURE: Preserve cursor in editor upload
2016-12-29 14:46:10 +01:00
Claas Augner 2e9bbccea9
Move cursor/selection algo to lib/utilities. 2016-12-29 10:16:17 +01:00
Claas Augner 43c1dd82f6
Add cursor tests, fix algorithm and extract method. 2016-12-29 09:54:15 +01:00
Guo Xiang Tan 7d307d6f29 Fix incorrect site setting. 2016-12-29 14:03:47 +08:00
Guo Xiang Tan a481bf048f FIX: Incorrect membership action buttons shown for non logged in users. 2016-12-29 12:51:36 +08:00
Guo Xiang Tan 3c4920d234 FIX: Group admin tabs showing for non logged in users. 2016-12-29 11:52:07 +08:00
Guo Xiang Tan 2165d0241e FIX: Only quote `.cooked` text. 2016-12-29 11:33:36 +08:00
Neil Lalonde 9c40657ba4 FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level 2016-12-28 17:36:04 -05:00
Claas Augner ba2db48dbb
Fix refactoring artifacts. 2016-12-28 22:37:07 +01:00
Claas Augner 1a5fcb72d3
FEATURE: Preserve cursor in editor upload 2016-12-28 22:24:52 +01:00
Neil Lalonde 67347432b7 Remove unread counts from last section of summary email, and rename it "New for you" 2016-12-28 14:06:01 -05:00
Neil Lalonde f3b4a889b2 FIX: remove extra space to the right of avatars in summary emails 2016-12-28 13:56:46 -05:00
Neil Lalonde a82182e1e3 FIX: error when trying to create new tag groups 2016-12-28 12:42:51 -05:00
Robin Ward 1ffbd9b4f6 UX: Don't show back button on fullscreen timeline 2016-12-28 12:29:24 -05:00
Robin Ward 471bb5ff61 UX: Back button was no longer centred properly. 2016-12-28 12:24:17 -05:00
Robin Ward 7c32b03364 UX: Try "bouncing" the back button in on progress widget 2016-12-28 11:39:08 -05:00
Robin Ward a297d7598b UX: Better style for back button 2016-12-28 11:22:33 -05:00
Robin Ward 7515f4eec2 Merge pull request #4621 from kgish/master
Toolbar action replaceText
2016-12-28 10:57:13 -05:00
Claas Augner e17bd6174c
Extract helper i18n-yes-no. 2016-12-28 11:45:41 +01:00
Robin Ward 5111611749 UX: Add a down arrow to the back button on the timeline 2016-12-27 17:21:27 -05:00
Robin Ward 889efe48be FIX: Customization templates were not working with Glimmer2 2016-12-27 12:17:30 -05:00
Robin Ward 3786d3679c FIX: Always return the latest API version requested 2016-12-27 11:57:46 -05:00
Robin Ward 98eac4924c FIX: If an audio file is playing, don't cloak it 2016-12-27 11:38:14 -05:00
Robin Ward 732d0ad030 FIX: Find the closest post to jump to if deleted 2016-12-27 10:52:37 -05:00
Robin Ward ee0c41b53a FIX: We can show the back button near the bottom 2016-12-27 10:21:30 -05:00
Claas Augner 8760f13c77
FIX: Translate all boolean values in user index 2016-12-27 11:16:30 +01:00
Arpit Jalan d72cbcb2a4 FEATURE: new setting to validate user website 2016-12-26 21:29:27 +05:30
Robin Ward 27e348c6b4 FIX: if `args` change a connector should update 2016-12-23 12:07:18 -05:00
Kiffin Gish 57284495de Toolbar action replaceText
Should be possible to replace the current contents with some other text.
2016-12-23 12:43:53 +01:00
Angus McLeod 6f0a937fa1 Resolve raw templates in 'javascripts/mobile' and 'javascripts' on mobile 2016-12-22 18:13:26 -05:00
Robin Ward 46f2a11a80 UX: Don't dock back button while dragging 2016-12-22 12:48:02 -05:00
Robin Ward 681f246df8 UX: Show post count in jump to post modal 2016-12-22 12:34:42 -05:00
Robin Ward 962c32edf5 Merge pull request #4597 from ibnesayeed/urdu-support
RTL direction assigned to Urdu language
2016-12-22 11:39:44 -05:00
Robin Ward b9fc9dc9fc FIX: Routing to default homepage with query params was broken 2016-12-22 11:37:17 -05:00
Guo Xiang Tan 5aee2673c7 FIX: Push null fields to last when sorting group members. 2016-12-22 14:55:24 +08:00
Guo Xiang Tan 5605700fa9 UX: Sort groups by name. 2016-12-22 14:46:20 +08:00
Guo Xiang Tan 6955c39c68 UX: Fix width on avatar flair. 2016-12-22 14:30:49 +08:00
Guo Xiang Tan 8551d821a0 FEATURE: Add site setting to disable group directory. 2016-12-22 14:14:22 +08:00
Sam c531f4ded5 remove rails-observers
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.

For example: if we want to upgrade to rails 5 there is no published gem

Internally the usage of observers had quite a few problem.

The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
Sam 019f1a1d06 UserEmailObserver is now removed
no big surprises here was pretty straightforward

after_commit semantics sure are weird though
2016-12-22 16:46:53 +11:00
Sam 2f6a4cc6de remove UserActionObserver, replace with after_save and service
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
Guo Xiang Tan 96c70c74a1 Merge pull request #4619 from tgxworld/group_page_design
UX: Redesign group page to follow user page.
2016-12-22 13:42:28 +08:00
Guo Xiang Tan a5fead3857 UX: Redesign group page to follow user page. 2016-12-22 13:08:59 +08:00
Sam 0a78ae739d Remove SearchObserver, aim is to remove all observers
rails-observers gem is mostly unmaintained and is a pain to carry forward
new implementation contains significantly less magic as a bonus
2016-12-22 13:13:14 +11:00
Robin Ward 31cda7b372 FIX: Can't seem to use ES6 in this file 2016-12-21 16:50:57 -05:00
Robin Ward 89bdca9c8c FIX: Backwards compatibility for controller in raw templates 2016-12-21 16:38:57 -05:00
Robin Ward 1463e9ae46 FIX: Couldn't resolve raw customization 2016-12-21 16:19:04 -05:00
Neil Lalonde eb23a8c173 FIX: when changing category, watch for pasted link in title field 2016-12-21 14:57:12 -05:00
Robin Ward e85904b98f FIX: Clamp last read position to height of the widget 2016-12-21 14:24:15 -05:00
Neil Lalonde 783490f763 FIX: with featured links enabled and uncategorized topic not allowed, allow featued links behaviour before choosing a category 2016-12-21 13:40:05 -05:00
Neil Lalonde b5cc6851cf FIX: tag chooser input was navigating to tag pgaes on some mobile browsers 2016-12-21 12:01:53 -05:00
Robin Ward 44ddc113e7 FIX: Couldn't route to the default route with a query param 2016-12-21 11:18:22 -05:00
Robin Ward ca20560d1f FIX: Should use `RAW_TEMPLATES` scope for header customizations 2016-12-21 10:54:23 -05:00
Guo Xiang Tan c897e5599a FIX: Group mobile nav not updating. 2016-12-21 21:16:52 +08:00
Guo Xiang Tan a37a6f57d9 FIX: Automatic groups should be editable via groups page. 2016-12-21 21:11:49 +08:00
Guo Xiang Tan 5e75d5c1bf PERF: N+1 query on groups page. 2016-12-21 20:59:09 +08:00
Guo Xiang Tan 076a08d8e1 FIX: Unactivated users should not be automatically added into groups as well. 2016-12-21 18:15:01 +08:00
Guo Xiang Tan 7228081820 FIX: Automatic group membership should not add staged or unactivated users. 2016-12-21 18:04:26 +08:00
Guo Xiang Tan 13c6191e89 FIX: Don't allow invalid email to be saved. 2016-12-21 17:47:11 +08:00
Guo Xiang Tan 5d7f3223f0 SECURITY: Users can only bookmark posts which they can see. 2016-12-21 12:01:26 +08:00
Robin Ward 1821a0933d FIX: Missing CSS for back button on progress component 2016-12-20 16:01:15 -05:00
Neil Lalonde c75bebdea2 FIX: uncategorized setting to control whether topic featured links are allowed 2016-12-20 15:55:30 -05:00
Robin Ward 1cbe355c5b FIX: Timeline back button was docking too aggressively 2016-12-20 13:32:54 -05:00
Robin Ward f0f5fbf132 FIX: Never show the last read marker within 1 post of the last 2016-12-20 13:22:22 -05:00
Robin Ward 1be800b673 FIX: Prioritize raw template overrides from plugins 2016-12-20 13:07:09 -05:00
Neil Lalonde 158670ca5e FIX: if categories page is default, redirect to Top was never working 2016-12-20 12:06:58 -05:00
Robin Ward da4e27ca7d FIX: Allow resolution of `javascripts` prefixed raw templates 2016-12-20 11:53:43 -05:00
Robin Ward 16b236899c FIX: `custom-html` tag had broken information 2016-12-20 11:49:30 -05:00
Régis Hanol c302ffe08f FIX: buttons in user admin page weren't working 2016-12-20 12:26:53 +01:00
Régis Hanol 3c3008fec3 FIX: clicking 'Show Email' on admin page wasn't working 2016-12-20 11:35:13 +01:00
Régis Hanol bf9e59eda9 FIX: add option for the oneboxer to be synchronous 2016-12-20 11:18:03 +01:00
Guo Xiang Tan 6461021046 FIX: Only show membership status on index page. 2016-12-20 15:50:12 +08:00
Guo Xiang Tan 9db5d5b6a7 FIX: Incorrect serializer for groups page. 2016-12-20 15:44:22 +08:00
Guo Xiang Tan 7c7c233c1c FIX: Can't update `Groups#allow_membership_requests` in admin. 2016-12-20 15:14:35 +08:00
Guo Xiang Tan c15bf62b43 FIX: Display empty message when no groups can be shown. 2016-12-20 14:47:39 +08:00
Guo Xiang Tan 502e114c60 FIX: Incorrect count when loading more groups. 2016-12-20 14:39:44 +08:00
Guo Xiang Tan 193f8301a4 FIX: Do not show automatic groups to normal users. 2016-12-20 14:26:49 +08:00
Guo Xiang Tan 375f3feeb8 FIX: Topic featured links not getting oneboxed immediately. 2016-12-20 10:27:12 +08:00
Régis Hanol 52cd9972bb FIX: prevent DDoS with lots of _oneboxable_ links
FIX: ensure the onebox route is only allowed to logged in users
FIX: only allow 1 outgoing onebox preview per user
FIX: client should only do 1 preview at a time
2016-12-20 00:31:10 +01:00
Sam 6965079108 Merge pull request #4606 from mabras/fix_arabic_pluralization
Fix Arabic Pluralization Rules for Client
2016-12-20 09:17:59 +11:00
Robin Ward 8757ae3b92 FIX: The docked back button didn't work so well on iPad / short topics 2016-12-19 17:16:42 -05:00
Sam 2b808ad9da Merge pull request #4609 from joebuhlig/category-topics-wiki
FEATURE: Category setting to make all topics wikis
2016-12-20 09:15:51 +11:00
Neil Lalonde a65281d5ea FIX: better support for featured link topics in summary emails 2016-12-19 17:05:49 -05:00
Clay Griffiths d15bfc9880 Forced trailing slash on messageBus.baseUrl 2016-12-19 14:34:19 -07:00
Neil Lalonde 3256620d5d FIX: some blank topics and posts in summary email because they're images 2016-12-19 16:21:31 -05:00
Neil Lalonde 74956694e5 If summary email finds no topics, show topics more than 1 day old from new users 2016-12-19 14:54:08 -05:00
Neil Lalonde 923cf73c6e Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox. 2016-12-19 14:54:07 -05:00
Robin Ward 4dcb29acbf UX: Show Back button above mobile progress widget 2016-12-19 14:06:19 -05:00
Robin Ward 36449aa2f2 UX: Docking back button on topic timeline 2016-12-19 13:33:55 -05:00
Robin Ward 05e99a68ce FIX: Refresh header if topic details are updated 2016-12-19 12:25:28 -05:00
Robin Ward e03d5e2140 Reapply Ember 2.10 for good this time!
This reverts commit ddd299f4aa.
2016-12-19 11:19:10 -05:00
Joe Buhlig 87251fded7 FEATURE: Category setting to make all topics wikis
FEATURE: Category setting to make all topics wikis
2016-12-19 06:42:18 -06:00
Guo Xiang Tan 18c8323987 FIX: Incorrect path for redirect. 2016-12-19 18:12:15 +08:00
Sam e0ff57ca75 SECURITY: prevent reuse of password reset 2016-12-19 18:00:22 +11:00
Sam eb2db23b40 FEATURE: remove email_token_grace_period_hours
The site setting email_token_grace_period_hours just causes confusion and
should not be used anyway.

Out of the box, tokens stop working once confirmed, no need to add complexity here
2016-12-19 17:15:20 +11:00
Sam dd383300b1 FEATURE: rate limit by login on password reset 2016-12-19 11:03:07 +11:00
Sam 0599bd0154 FEATURE: add referrer never tag to password reset page 2016-12-19 11:01:58 +11:00
Sam 15b5fddd49 SECURITY: protect upload params, only allow very strict filenames 2016-12-19 10:16:18 +11:00
Sam 30e0154e5d SECURITY: fix reflected XSS with safe_mode param
(only applies to beta and master)
2016-12-19 10:11:51 +11:00
Mohamad Abras e20e765afe Fix Arabic Pluralization Rules for Client 2016-12-17 17:50:35 +02:00
Jeff Atwood 81956cb1d6 Merge pull request #4590 from xfalcox/css-highligth
Use CSS animations for post and topic highlights
2016-12-16 14:22:25 -08:00
Rafael dos Santos Silva e9fa936389 Uses CSS animation for highlight on mobile too 2016-12-16 19:26:49 -02:00
Guo Xiang Tan d8541c589a FIX: Incorrect route for updating username. 2016-12-17 00:23:12 +08:00
Robin Ward ddd299f4aa Revert "Revert "Revert Ember 2.10+ for a short while""
This reverts commit 76bbc481cb.
2016-12-16 10:29:30 -05:00
Robin Ward 76bbc481cb Revert "Revert Ember 2.10+ for a short while"
This reverts commit 21682fd60b.
2016-12-16 09:52:29 -05:00
Guo Xiang Tan e3213f127d FIX: Regression with request membership button after migrating to component. 2016-12-16 16:07:11 +08:00
Sam d4a0508744 FEATURE: outlet prior to Reply button at the bottom of topics 2016-12-16 17:10:32 +11:00
Sam 61eb134181 FEATURE: setting to allow arbitrary redirects from sso origin
if sso_allows_all_return_paths is set to true you can redirect off-site from sso success
2016-12-16 13:37:44 +11:00
Sam 6ff309aa80 SECURITY: don't grant same privileges to user_api and api access
User API is no longer gets bypasses that standard API gets.
Only bypasses are CSRF and XHR requirements.
2016-12-16 12:05:43 +11:00
Robin Ward 21682fd60b Revert Ember 2.10+ for a short while 2016-12-15 16:43:38 -05:00
Neil Lalonde f01f95d62d FEATURE: new settings to customize some colors in emails 2016-12-15 14:43:53 -05:00
Neil Lalonde 62ba5ea33f Name before username in summary email 2016-12-15 14:43:52 -05:00
Robin Ward d0ddceb4e4 UX: Try improving the back button on the timeline 2016-12-15 14:24:58 -05:00
Robin Ward 250ca11416 Add PluginAPI for registering a connector class 2016-12-15 11:54:37 -05:00
Robin Ward 0348f23f6d FIX: Register a test waiter rather than using hidden properties 2016-12-15 11:36:21 -05:00
Robin Ward 40c944cb36 FIX: Was showing two rows for the title always 2016-12-15 10:47:43 -05:00
Robin Ward d69b782737 FIX: Editing tags was double rendering 2016-12-15 10:40:11 -05:00
Robin Ward 2655be512f FIX: Showing raw email and history were broken 2016-12-15 10:28:15 -05:00
Robin Ward ea3db56d1c FIX: Mobile raw templates were not being resolved 2016-12-15 10:28:15 -05:00
Robin Ward 28699e66d8 Revert "REVERT: Ember 2.10 -- it's not building properly"
This reverts commit 600541c623.
2016-12-15 10:28:15 -05:00
Guo Xiang Tan bbe067e735 Fix eslint. 2016-12-15 16:07:56 +08:00
Guo Xiang Tan 7888a16374 FEATURE: Add membership request to groups page. 2016-12-15 14:39:13 +08:00
Sam 162413862c FEATURE: add `staff` class to HTML body for staff 2016-12-15 16:23:03 +11:00
Sam 98f4a2adcb FIX: on 404 from brotli asset path return a correctly encoded doc
old implementation would cache the 404 for 1 year with incorrect encoding

hilarity would ensue
2016-12-15 16:05:20 +11:00
Sam f867af6bf9 bye bye byebug 2016-12-15 15:52:25 +11:00
Guo Xiang Tan 3666575b46 UX: Improve styling for groups page. 2016-12-15 12:19:13 +08:00
Guo Xiang Tan 3999afc279 FIX: Category logo not showing in navigation. 2016-12-15 12:11:21 +08:00
Guo Xiang Tan b005e1ab58 UX: Left align columns on groups page. 2016-12-15 10:00:37 +08:00
Neil Lalonde a26c3fe2b6 FIX: truncate long topic titles in summary email 2016-12-14 12:59:01 -05:00
Neil Lalonde d23da5b641 FIX: digest email preview error in Persian and other languages 2016-12-14 11:10:32 -05:00
Robin Ward 2164d7d21c FIX: User card spacing was off 2016-12-14 10:46:16 -05:00
Guo Xiang Tan 4b940dc8bd FEATURE: Add groups page. 2016-12-14 17:27:47 +08:00
Guo Xiang Tan 0c9499874d FIX: Missing no members message on group page. 2016-12-14 14:01:19 +08:00
Neil Lalonde 66151b416f FIX: home logo href doesn't respect subfolder 2016-12-13 16:30:21 -05:00
Robin Ward 03bc6f70f9 Better error messages when embedding fails 2016-12-13 14:38:05 -05:00
Neil Lalonde 1f0793ac50 Improvements to automatic topic title based on pasted link 2016-12-13 13:11:52 -05:00
Neil Lalonde 67a0a36362 FIX: topic lists on mobile should include featured links 2016-12-13 13:11:52 -05:00
Juha Leinonen 817f4cd0fc FEATURE: Split Reply-button into 'Reply Post' and 'Reply Topic' 2016-12-13 14:54:45 +02:00
Guo Xiang Tan 2686ee5ab2 FIX: Admin can't add/remove public group users. 2016-12-13 16:39:44 +08:00
Guo Xiang Tan 43ee9f884e FEATURE: Add `Group#full_name`. 2016-12-13 16:16:26 +08:00
Guo Xiang Tan 5a2794a0c7 FIX: `Discourse.ajax` is deprecated. 2016-12-13 15:53:04 +08:00
Guo Xiang Tan fbd3727c7d UX: Improve group edit style for mobile. 2016-12-13 15:26:28 +08:00
Guo Xiang Tan f4af74b7b3 FIX: Incorrect class. 2016-12-13 15:20:59 +08:00
Guo Xiang Tan 0e934a2f2d Make eslint happy. 2016-12-13 15:17:14 +08:00
Guo Xiang Tan 7bfabb029b UX: Move editing group from into an individual tab. 2016-12-13 15:15:20 +08:00
Guo Xiang Tan 5a5aea72b5 Remove icon from group tabs. 2016-12-13 13:12:38 +08:00
Guo Xiang Tan 6dab7f4463 UX: Keep table styles consistent with topic list. 2016-12-13 13:11:34 +08:00
Guo Xiang Tan 69330f8bc2 Add user_updated event to webhooks. 2016-12-13 11:26:26 +08:00
Robin Ward 600541c623 REVERT: Ember 2.10 -- it's not building properly 2016-12-12 16:19:05 -05:00
Robin Ward 749f7071f3 FIX: `Object.assign` isn't available to phantom 2016-12-12 15:23:52 -05:00
Robin Ward c2462e1f2d FIX: Missing plugin outlet 2016-12-12 14:44:29 -05:00
Robin Ward 7b2e4170e9 Safer checkUrl 2016-12-12 14:44:29 -05:00
Robin Ward b6e03116ba Auto discover connector classes. Support a setup method 2016-12-12 14:44:29 -05:00
Robin Ward 9a7998a930 Various fixes for Ember 2.10 2016-12-12 14:44:29 -05:00
Robin Ward 2efe4900cf Plugin Outlets need their arguments to be explicit 2016-12-12 14:44:29 -05:00
Robin Ward a808bcb0b8 Upgrade to Ember 2.10 2016-12-12 14:44:29 -05:00
Robin Ward 765e5e9186 Upgrade to Ember 2.9 2016-12-12 14:44:29 -05:00
Neil Lalonde 239d06b218 add Likes Recieved to possible stats in summary email 2016-12-12 14:20:25 -05:00
Arpit Jalan 70227d37d7 FIX: composing new pre filled topic with tags was broken 2016-12-12 22:27:53 +05:30
Guo Xiang Tan 4a1340b14e Update annotations. 2016-12-12 22:59:40 +08:00
Guo Xiang Tan da7009a968 FEATURE: Add request membership button for allowed groups. 2016-12-12 22:48:08 +08:00
Régis Hanol 664feca199 FIX: don't send emails from muted users in mailing list mode 2016-12-12 15:28:26 +01:00
Guo Xiang Tan 405ffbf5a4 FIX: Don't show logs if user is not an admin or group owner. 2016-12-12 20:30:09 +08:00
Guo Xiang Tan 5db6306218 FIX: Incorrect empty message. 2016-12-12 19:39:58 +08:00
Guo Xiang Tan 9a800107cb FIX: Associate category logo and background to uploads record. 2016-12-12 17:37:28 +08:00
Guo Xiang Tan 05f55dbc10 FEATURE: Group logs. 2016-12-12 17:29:54 +08:00
Guo Xiang Tan 790f1ef9f3 FIX: Permit missing params. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan b5cc5a6fb1 Unify group translations under same key. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan c3b04c3054 Fix: Group avatar flair inputs style. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan be5b5f6bea FEATURE: Public groups. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan 78553151ea Update annotations. 2016-12-12 17:00:30 +08:00
Arpit Jalan 495c8f2794 FIX: bulk invite button was not getting re-enabled after performing upload 2016-12-12 14:08:10 +05:30
Sawood Alam 77ef730f20
RTL direction assigned to Urdu language 2016-12-10 18:57:48 -05:00
Neil Lalonde 17bc42fe85 FIX: box style category badges in emails, and shrink text and some spacing in summary email 2016-12-09 16:59:54 -05:00
Neil Lalonde fb2633366a FIX: featured link topics shouldn't require the same min post length 2016-12-09 15:46:26 -05:00
Neil Lalonde a62b028e16 Remove the open_topic_featured_link_in_external_window setting. Use the user preference. 2016-12-09 13:48:29 -05:00
Neil Lalonde a4c4f13901 Remove the topic_featured_link_onebox setting. We will always try to onebox a link and add it to the body if topic_featured_link_enabled is enabled. 2016-12-09 13:28:12 -05:00
Robin Ward f07443b488 Migrate Discourse Polls to use vdom instead of embedded ember 2016-12-09 10:42:56 -05:00
Sam 02b21a26dd Merge pull request #4585 from ibnesayeed/urdu-support
Add initial Urdu support with RTL direction
2016-12-09 13:01:25 +11:00
Sam 861a91d48a correct styling for tracking button on mobile 2016-12-09 12:20:33 +11:00
Neil Lalonde 03ec8f8089 fix focus after attempting to onebox 2016-12-08 16:27:19 -05:00
Neil Lalonde fbd8e6ed4a FEATURE: pasting a link into the title of the composer can automatically onebox it and update the title 2016-12-08 16:09:46 -05:00
Robin Ward f6f03ac009 FIX: Double clicking full name was broken too 2016-12-08 11:10:10 -05:00
Arpit Jalan 3d4299151c Merge pull request #4596 from techAPJ/composer
FEATURE: show close button instead of maximize in collapsed composer
2016-12-08 21:31:54 +05:30
Arpit Jalan d9459d09ed FEATURE: show close button instead of maximize in collapsed composer 2016-12-08 20:11:58 +05:30
Arpit Jalan 42b14b0d11 SECURITY: escape advanced search term 2016-12-08 14:54:36 +05:30
Sam Saffron b4cafc5e78 UX: add notification level button to mobile 2016-12-08 17:47:57 +11:00
Guo Xiang Tan b9b4b0c175 FIX: Members should be ordered by username. 2016-12-08 14:27:38 +08:00
Arpit Jalan 4381afac1b Merge pull request #4593 from techAPJ/composer
FEATURE: show the reply title and the reply icon in the minimized editor
2016-12-08 11:40:24 +05:30
Arpit Jalan 312a07e452 FEATURE: show the reply title and the reply icon in the minimized editor 2016-12-08 10:30:31 +05:30
Guo Xiang Tan c3f0ec617f FIX: `Object.assign` is not available in PhantomJS. 2016-12-08 11:21:19 +08:00
Guo Xiang Tan 7d8a0b051f Fix QUnit tests. 2016-12-08 11:04:46 +08:00
Guo Xiang Tan a2da2971af FEATURE: Allow columns on group members page to be sortable. 2016-12-08 10:49:12 +08:00
Guo Xiang Tan 7e47fdf8da UX: Fix margins for group name on mobile. 2016-12-08 06:24:32 +08:00
Régis Hanol f4688f74db FIX: emoticons stop summary from being updated 2016-12-07 23:05:14 +01:00
Robin Ward e3a12995c8 FIX: Fake closure actions were not working (replaced in 2.10) 2016-12-07 14:32:33 -05:00
Neil Lalonde ad5d16af8e FIX: summary email popular posts ordering by score, and increase minimum score to qualify as popular 2016-12-07 12:40:44 -05:00
Robin Ward d379f57c58 FIX: Show an error page if `finish-installation` can't run 2016-12-07 11:10:08 -05:00
Guo Xiang Tan 81d333289e FIX: Return 503 when in readonly mode. 2016-12-07 14:04:42 +08:00
Guo Xiang Tan 545dfa7191 FEATURE: Allow group owners to edit title. 2016-12-07 10:26:28 +08:00
Guo Xiang Tan 8c7a0b7684 UX: Display group title if it exists. 2016-12-07 10:20:13 +08:00
Neil Lalonde a7ee72649d FIX: add back support for customizing header in summary email 2016-12-06 12:40:42 -05:00
Neil Lalonde 1f50fcd613 FIX: digest customizations for above/below popular topics were sometimes not being shown 2016-12-06 12:35:02 -05:00
Guo Xiang Tan bad6dbc891 UX: Use mobile nav for group page. 2016-12-06 17:02:28 +08:00
Sam badfda223c FEATURE: add outlet for user stats in summary 2016-12-06 17:26:02 +11:00
Rafael dos Santos Silva 46b3c2e9c5 Use CSS animations for post and topic highlights 2016-12-05 20:20:52 -02:00
Sam 1135e00c83 FIX: regression unable to dismiss unread 2016-12-06 08:49:40 +11:00
Neil Lalonde 007408c285 show featured topic links on categories-with-latest page too 2016-12-05 16:29:27 -05:00
Neil Lalonde 56ee4ffadc Merge pull request #4522 from fantasticfears/featured-link
FEATURE: Allow posting a link with the topic
2016-12-05 16:05:38 -05:00
Robin Ward 9e807896bc FIX: We can route from user cards 2016-12-05 13:45:31 -05:00
Robin Ward 424fc8e2e2 FIX: Don't raise an error if the RSS endpoint is 404 2016-12-05 12:29:14 -05:00
Erick Guan 52763f5115
FEATURE: Allow posting a link with topics 2016-12-05 17:20:54 +01:00
Régis Hanol e82084405e make eslint happy again 2016-12-05 15:24:41 +01:00
Régis Hanol 06469ef0ce FIX: don't extract links from .elided parts 2016-12-05 15:19:15 +01:00
Guo Xiang Tan bea0856f1c FIX: Move title and name out of BasicUserSerializer. 2016-12-05 18:46:33 +08:00
Régis Hanol 9f3eaf4c95 FIX: prevent selectionchanged trigger loop on Safari 2016-12-05 11:33:26 +01:00
Régis Hanol edce052660 FIX: isSafari detection wasn't working with latest Safari 2016-12-05 11:32:38 +01:00
Guo Xiang Tan cdb7e14fa7 PERF: Show excerpt on group page. 2016-12-05 18:15:38 +08:00
Régis Hanol 965b38ff2a FIX: safari would lose selection sometimes 2016-12-05 11:08:30 +01:00
Arpit Jalan 431aa79bb3 Merge pull request #4587 from techAPJ/invite-upload
FIX: simplify CSV file upload
2016-12-05 14:30:13 +05:30
Guo Xiang Tan ce9f24dec9 Merge pull request #4588 from tgxworld/add_new_fields_to_group
Add new fields to group
2016-12-05 09:59:27 +01:00
Guo Xiang Tan 248c5af556 UX: Restyle group pages a little. 2016-12-05 16:58:04 +08:00
Guo Xiang Tan adb7fcb6b3 FEATURE: Add bio to group page. 2016-12-05 16:58:04 +08:00
Arpit Jalan ce974da9e5 FIX: simplify CSV file upload 2016-12-05 14:09:08 +05:30
Sam dab48b7c17 correct regression 2016-12-05 17:40:47 +11:00
Sam 3e099ab2b1 PERF: avoid query on every logged on page load 2016-12-05 17:38:02 +11:00
Guo Xiang Tan 0441ae3e95 Merge pull request #4577 from tgxworld/allow_group_owner_to_edit
FEATURE: Allow group owners to edit group name and avatar flair.
2016-12-05 07:28:55 +01:00
Guo Xiang Tan 1c42d167ec Missing spinner icon on group pages. 2016-12-05 14:27:47 +08:00
Guo Xiang Tan e0c28d6fd5 REFACTOR: Stop mixing users page and groups page CSS. 2016-12-05 14:27:47 +08:00
Guo Xiang Tan 31acd311e5 FEATURE: Allow group owners to edit group name and avatar flair. 2016-12-05 14:27:46 +08:00
Sam c2a17826e7 ship highest staff post number to staff 2016-12-05 17:22:25 +11:00
Erick Guan 0fbb3fb02b FIX: open login modal fails because of missing parameters 2016-12-05 13:22:28 +08:00
Sam dc66f6681a add spec for brotli controller, ensure cached correctly 2016-12-05 16:08:36 +11:00
Sam 8a98d617df correct headers and add better caching 2016-12-05 15:11:07 +11:00
Guo Xiang Tan 55b35a05ed FIX: This should not have been checked in. 2016-12-05 11:49:04 +08:00
Guo Xiang Tan 22059d4df9 Add Rake task to clean up unused multisite Redis keys. 2016-12-05 11:46:34 +08:00
Sam 39a524aac8 FEATURE: brotli cdn bypass for assets
Allow CDNS that strip out brotli encoding to use brotli regardless
2016-12-05 13:57:09 +11:00
Sam bd217bb440 remove ux regression 2016-12-05 12:21:07 +11:00
Sam 1db9d17756 Make removal of topic columns more resilient to deploys 2016-12-05 12:11:46 +11:00
Sam 33d0a23d84 Merge branch 'fix_whisper' 2016-12-05 10:01:03 +11:00
Sawood Alam 49fc54aac6 Add initial Urdu support with RTL direction 2016-12-03 23:17:51 -05:00
Jeff Atwood 8bcdb668c6 fix login disclaimer alignment 2016-12-03 04:24:48 -08:00
Régis Hanol 55437271b0 Merge pull request #4583 from saiqulhaq/master
FIX: filename typo
2016-12-03 00:42:56 +01:00
Jeff Atwood 3c02e49b28 tweak login dialog for narrow mobile phones 2016-12-02 15:29:21 -08:00
M Saiqul Haq a1d34c15c7 FIX: filename typo 2016-12-03 06:16:32 +07:00
Neil Lalonde a5ca41b362 FIX: sort by column headings in topic list when filtered by tag 2016-12-02 16:55:33 -05:00
Neil Lalonde dafd1453d6 FIX: topic list filters for bookmarked, posted, and read now work with tag filter 2016-12-02 15:58:14 -05:00
Neil Lalonde 9db3685823 fix another case of double user name in digest 2016-12-02 13:31:12 -05:00
Neil Lalonde fa395bb43c fix colour bug in summary email 2016-12-02 10:33:12 -05:00
Guo Xiang Tan e51574bea0 FIX: No need to fetch the model. 2016-12-02 17:17:03 +08:00
Guo Xiang Tan 3971f96aa6 Merge pull request #4536 from fantasticfears/webhooks-edit
FIX: missing post and topic edited webhooks
2016-12-02 10:16:19 +01:00
Jeff Atwood d4fd493901 Revert "UX: have webkit safari mobile stop with inner shadows"
This reverts commit 9a685c64ee.
2016-12-02 00:46:37 -08:00
Guo Xiang Tan bc0a8142fe PERF: Only show members count on group page. 2016-12-02 16:28:54 +08:00
Jeff Atwood a93c59abbf UX: normalize mobile <input> styles w/desktop 2016-12-01 23:53:11 -08:00
Sam d5f4f2f5c1 regression composing topics on desktop
caught by smoke test
2016-12-02 18:20:23 +11:00
Sam f57feb2a4b regression composing topics on desktop
caught by smoke test
2016-12-02 18:19:39 +11:00
Sam 9a685c64ee UX: have webkit safari mobile stop with inner shadows
http://stackoverflow.com/questions/3062968/remove-textarea-inner-shadow-on-mobile-safari-iphone
2016-12-02 17:56:37 +11:00
Sam 2793e7bebc UX: have webkit safari mobile stop with inner shadows
http://stackoverflow.com/questions/3062968/remove-textarea-inner-shadow-on-mobile-safari-iphone
2016-12-02 17:56:01 +11:00
Sam 9b885c039a Merge branch 'master' into fix_whisper 2016-12-02 17:44:05 +11:00
Sam 7b5b255168 UX: improve topic composition on mobile
- tighten up space used for composer body
- stop collapsing and expanding so much
2016-12-02 17:43:18 +11:00
Sam 2a19e8f239 UX: improve topic composition on mobile
- tighten up space used for composer body
- stop collapsing and expanding so much
2016-12-02 17:42:27 +11:00
Sam c04d4171ff FIX: whisper no longer experimental
- Regular users are not notified of whispers
- Regular users no longer have "stuck" topics in unread
- Additional tracking for staff highest post number
- Remove a bunch of unused columns in topics table
2016-12-02 17:03:31 +11:00
Guo Xiang Tan 3812c07958 Add query params for site settings filter. 2016-12-02 11:45:57 +08:00
Robin Ward 4f44713e8e Allow untranslated plugins to set modal body titles 2016-12-01 15:37:39 -05:00
Neil Lalonde 576a424130 FEATURE: number of new topics at the end of summary email can be controlled by a new setting, digest_other_topics 2016-12-01 14:20:24 -05:00
Robin Ward 4820ebd76c FIX: Don't modify properties in `didInsertElement` 2016-12-01 14:08:51 -05:00
Neil Lalonde 8a0cf1b90e FIX: if username and name are the same, don't show both in summary emails 2016-12-01 12:17:23 -05:00
Neil Lalonde 985daf5c72 FIX: summary should not include certain post types 2016-12-01 12:01:32 -05:00
Robin Ward 69ff0e48b4 Remove `SortedMixin` 2016-12-01 11:33:33 -05:00
Robin Ward 0dbcb4ec8a FIX: `lookupFactory` doesn't exist on `getOwner` result 2016-12-01 11:24:30 -05:00
Guo Xiang Tan e0803e1f91 Merge pull request #4567 from toumou/master
FIX uploadLocation when window.location.port is empty
2016-12-01 07:19:24 +01:00
Jeff Atwood 61bcc98c0e slightly tighten spacing on digests 2016-11-30 17:13:01 -08:00
cpradio 309e37f0e6 UX: Remove !important from header .discourse-tag
per https://meta.discourse.org/t/planned-tag-color-issue-when-scrolled-down/53582/4?u=cpradio
2016-11-30 19:08:13 -05:00
Neil Lalonde 8cd30cdc8b FIX: respect the enable_names setting, and fix cases when html is invalid 2016-11-30 17:58:07 -05:00
Régis Hanol 453d149182 just checking for existence is enough here 2016-11-30 23:41:07 +01:00
Erick Guan 8c8549b27b
FIX: missing post and topic edited webhooks 2016-11-30 20:49:45 +01:00
Robin Ward 142d35a0a5 Minor Discourse Fixes 2016-11-30 13:45:40 -05:00
Régis Hanol 57d0369894 FIX: don't raise an exception when a link was already extracted 2016-11-30 18:05:59 +01:00
Régis Hanol dec8a861f0 FIX: don't raise exception when a quote was already extracted 2016-11-30 17:18:34 +01:00
Régis Hanol cf9ebb85ec Merge pull request #4578 from vinkas0/fix/plugins-route
fix: adminPlugins:index route is missing
2016-11-30 12:25:58 +01:00
Vinoth Kannan a97c59ed2e fix: adminPlugins:index route missing 2016-11-30 14:36:42 +05:30
Guo Xiang Tan 256a231a0a FIX: Incorrect translation key. 2016-11-30 16:59:22 +08:00
Jeff Atwood 3f3a0d7b14 make counts fixed width for digest/summary 2016-11-29 17:21:51 -08:00
Neil Lalonde 4d52682267 FIX: wrong font of site title in summary email 2016-11-29 17:12:11 -05:00
Neil Lalonde a187932126 Counts at top of summary email are links 2016-11-29 17:10:25 -05:00
Robin Ward ae38a78bb6 FIX: Categories default page was broken 2016-11-29 15:54:28 -05:00
Robin Ward 4e251eaf08 FIX: Support overwriting nested resources 2016-11-29 13:08:24 -05:00
Guo Xiang Tan 06d501ad41 Fix incorrect style for avatar flair icon preview. 2016-11-29 15:32:53 +08:00
Guo Xiang Tan e97efe3ac6 Fix incorrect class and removal unncessary `div`. 2016-11-29 15:31:03 +08:00
Guo Xiang Tan 943e605add REFACTOR: Project's convention is to use dash for classes. 2016-11-29 15:22:24 +08:00
Arpit Jalan 8a18c5be1f FIX: use proper locale for user archive download alerts 2016-11-29 12:48:28 +05:30
Sam b8dc58be90 got to be careful with integrity specs 2016-11-29 18:01:09 +11:00
Sam 266322ce2e FEATURE: add help text for no bookmarks in user page 2016-11-29 17:56:00 +11:00
Guo Xiang Tan efe24f7cc6 Fix style for font-awesome avatar flair. 2016-11-29 14:14:44 +08:00
Guo Xiang Tan 0d4f71e90b FIX: Display group avatar flair on user page. 2016-11-29 13:47:45 +08:00
Sam 1939104d46 Add mapping for Discourse solved
This basically reserved user action 15 for Discourse solved.
2016-11-29 16:17:32 +11:00
Sam 26db5d4c11 FIX: correctly specify outlet adds LI 2016-11-29 16:17:32 +11:00
Guo Xiang Tan dfc383a948 UX: Capitalize group name. 2016-11-29 12:37:40 +08:00
Guo Xiang Tan d95fbd89d0 Enable miniprofiler in development automatically. 2016-11-29 10:59:10 +08:00
Sam 0631a84ca0 Merge pull request #4576 from cpradio/min-posts-search
FEATURE: Add min_post_count search filter
2016-11-29 10:19:33 +11:00
Neil Lalonde 4e0958051e FIX: don't try to show svg's in summary email 2016-11-28 14:35:59 -05:00
cpradio 66ca6d622e FEATURE: Add min_post_count search filter 2016-11-28 11:43:12 -05:00
Robin Ward d9cf9e2fb1 FIX: ace editor was buggy in the latest Ember release 2016-11-28 11:29:56 -05:00
Régis Hanol 6edd3c347c FIX: automatically disable digests when enabling mailing list mode 2016-11-28 15:52:35 +01:00
Régis Hanol 0c791e721e UX: better xkcd oneboxes 2016-11-28 15:14:59 +01:00
Régis Hanol 6768c7fc0b Merge pull request #4563 from vinkas0/vinkas/flatten
Added flatten func for applyDecorators
2016-11-28 10:19:22 +01:00
Régis Hanol ecebc58780 Merge pull request #4571 from cpradio/hide-about-me-suspended
FEATURE: Hide Profile Text from non-staff if user is suspended
2016-11-28 10:08:57 +01:00
Régis Hanol 3406f7ff6a Merge pull request #4572 from joebuhlig/tags-querystring
FIX: Add tags to list options from params
2016-11-28 10:08:20 +01:00
Régis Hanol 6b319f54a3 Merge pull request #4574 from joebuhlig/tags-parameter-persist
FIX: Leave tags parameter in query string of URL when visiting page
2016-11-28 10:07:33 +01:00
Sam add831dbc1 clamp excerpt at 8 lines to avoid cut off 2016-11-28 11:35:32 +11:00
Joe Buhlig b1e8e2a6f6 FIX: Leave tags parameter in query string of URL when visiting page 2016-11-27 14:33:15 -06:00
Jeff Atwood fc68a7f0c6 tighten spacing on digest "new in" 2016-11-27 10:19:23 -08:00
Jeff Atwood 9b363d6df7 tighten spacing on digest email 2016-11-27 10:03:34 -08:00
Jeff Atwood e77dbbacea no vendor specific formatting in digest emails 2016-11-27 09:49:15 -08:00
Joe Buhlig 0390deba40 FIX: Add tags to list options from params 2016-11-26 08:24:52 -06:00
cpradio eb5a5e3a53 FEATURE: Hide Profile Text from non-staff if user is suspended 2016-11-25 19:26:36 -05:00
Neil Lalonde af4f2d000a FIX: translation missing messages in digest when showing more than 5 popular topics 2016-11-25 16:37:06 -05:00
Neil Lalonde 9d5ac320f4 FIX: dates in digest email wrapping when they should have plenty of space on one line 2016-11-25 16:29:01 -05:00
Robin Ward 47a235e06a FIX: Raw plugin outlets were not working properly 2016-11-25 16:17:04 -05:00
Neil Lalonde 655b8a0540 move topic.image_url to same row as avatar in digest email 2016-11-25 15:41:22 -05:00
Robin Ward 6aa5722d2b Remove Ember 1.x specific code 2016-11-25 15:38:45 -05:00
Robin Ward 3bd5ac8015 Fix Wizard unit tests 2016-11-25 14:29:45 -05:00
Guo Xiang Tan 8f70829e8e Merge pull request #4569 from tgxworld/fix_n+1_queries
PERF: Fix N+1 queries when loading groups.
2016-11-25 19:55:43 +01:00
Guo Xiang Tan 559918c6c6 PERF: Add endpoint to check if a group can be mentioned by user. 2016-11-26 02:20:46 +08:00
Guo Xiang Tan 5794f1619d PERF: Fix N+1 queries when loading groups. 2016-11-26 02:20:26 +08:00
Robin Ward d8a69e6bb2 FIX: Use the register within the poll plugin 2016-11-25 11:58:06 -05:00
Régis Hanol e3b47a3998 FIX: hide quote button when the selection is expanded to more than 1 post 2016-11-25 17:55:39 +01:00
Robin Ward 47553f5e57 Remove empty file 2016-11-25 10:29:02 -05:00
Robin Ward 2d3518f475 Enable newer version of Ember 2016-11-25 10:09:58 -05:00
Guo Xiang Tan 712ff01f38 PERF: Remove eager load. 2016-11-25 11:21:08 +08:00
Guo Xiang Tan fbc3fcc4af PERF: Make use of existing index. 2016-11-25 11:19:13 +08:00
Guo Xiang Tan 63a88ee6e7 Merge pull request #4566 from tgxworld/fix_perf_redirect_to_top
Fix perf redirect to top
2016-11-25 03:39:56 +01:00
Sam ed16589b12 correct off by 1 2016-11-25 13:18:56 +11:00
Sam 881eb373c5 improve performance of backfill avoid queuing more than 1 backfill call 2016-11-25 12:33:10 +11:00
Sam 88a46be051 FEATURE: display text excerpts when scrolling on mobile 2016-11-25 11:35:29 +11:00
Neil Lalonde 96daf5431f digest: don't show stats with 0. try to show new posts and new users counts. 2016-11-24 16:28:24 -05:00
Neil Lalonde 6c38053c32 preview digest renders nicely in an iframe 2016-11-24 15:38:22 -05:00
Neil Lalonde f885e5b5e6 fix success response handling of sending digest preview email 2016-11-24 15:05:33 -05:00
Robin Ward 676d585abb FIX: ESLint 2016-11-24 13:17:07 -05:00
Robin Ward bb0ab289b9 Migrate deprecated Ember.ListView to regular components.
This is slower for scrolling but it actually feels reasonably fast to
me? If we find it's a problem we can revisit once Ember 2.4 is fully in
place.
2016-11-24 12:59:20 -05:00
Régis Hanol af387edeb0 FIX: quote button issues
- disappear when moving to another topic
- disappears when clicking outside of the selection
- works even when selecting the last paragraph of a post
- works on all latest mobile OS
2016-11-24 18:23:33 +01:00
Thomas Ferracin c74a5771fd FIX uploadLocation when window.location.port is empty
More information available: https://meta.discourse.org/t/uploaded-video-are-not-embedded-and-display-a-link/53346
2016-11-24 18:01:08 +01:00
Robin Ward 5ba653d604 Allow old plugins without `d-modal-body` to work 2016-11-24 11:24:06 -05:00
Robin Ward 66f68e8faf FIX: correctly bind `this` when sending a widget action 2016-11-24 10:59:15 -05:00
Guo Xiang Tan 84914c5e1f PERF: Fix N+1 query. 2016-11-24 17:47:14 +08:00
Guo Xiang Tan 0b28075c00 Revert "REFACTOR: `ajax` defaults to json data type for GET requests."
This reverts commit af0b6ce53d.
2016-11-24 16:47:18 +08:00
Guo Xiang Tan af0b6ce53d REFACTOR: `ajax` defaults to json data type for GET requests. 2016-11-24 16:20:17 +08:00
Guo Xiang Tan b889bfefbb PERF: Don't calculate the same query twice. 2016-11-24 14:05:26 +08:00
Guo Xiang Tan 857955dd04 Follow our convention of declaring private methods. 2016-11-24 10:26:39 +08:00
Guo Xiang Tan f812415c52 Update annotations. 2016-11-24 10:13:03 +08:00
Neil Lalonde 4efb3069e2 FIX: exception in digest email when last_read_post_number is nil 2016-11-23 17:51:57 -05:00
Neil Lalonde 47aa3d94aa FEATURE: send digest preview to an email address 2016-11-23 17:51:57 -05:00
Robin Ward b8c88dbfe0 Update docs for connector 2016-11-23 16:44:57 -05:00
Robin Ward 9030e40041 FIX: Container appending was broken in Ember 2.4 2016-11-23 14:58:10 -05:00
Robin Ward c5687100b0 Add the ability to connect a component to a Discourse widget 2016-11-23 14:27:47 -05:00
Robin Ward ae4fd06444 Add acceptance tests for `custom-html` 2016-11-23 13:02:22 -05:00
Neil Lalonde 79dc0518c9 FIX: popular posts in digest need to use same restrictions as topics 2016-11-23 11:24:18 -05:00
Guo Xiang Tan 55013be19f FIX: Make sure we clean quoteState when destroying quoteButton. 2016-11-23 14:45:47 +08:00
Robin Ward 9afa55a3fd FIX: Random failing plugin tests 2016-11-22 15:36:18 -05:00
Robin Ward ca5ed77b43 FIX: More robust `afterRender` for the composer 2016-11-22 14:34:41 -05:00
Robin Ward f51bf2358e FIX: Error finding `$fields.position` during tests 2016-11-22 14:28:10 -05:00
Robin Ward 217007ff54 Add acceptance tests for plugin outlets 2016-11-22 14:03:01 -05:00
Neil Lalonde 86deec3528 FIX: exclude popular posts from deleted topics 2016-11-22 13:23:21 -05:00
Neil Lalonde db4b3a7aa4 FIX: show emoji in digest emails 2016-11-22 12:37:22 -05:00
Robin Ward 5b05c8102e FIX: Read posts weren't refreshing on Ember 2.4 2016-11-22 12:17:40 -05:00
Neil Lalonde 71e4fe9c85 FIX: consistent rendering of categories in digest emails 2016-11-21 17:33:19 -05:00
Robin Ward daabdd2ccf FIX: Topic status icons weren't being displayed 2016-11-21 16:18:41 -05:00