e9ea0102a5
FIX: Consistency about our response for invalid user id in `Admin::UsersController`.
2018-12-15 08:01:35 +08:00
ef0e84e3d9
FIX: clear the site_contact_username setting if the user's staff privileges are revoked
2018-12-14 16:52:44 -05:00
0d3c1cde90
FIX: Use find_by_id method to prevent record not found exception
2018-12-15 03:19:45 +05:30
430083019d
UX: Improve dashboard report title copy
...
Make capitalization consistent, and slightly improve clarity of two headings
2018-12-14 17:37:07 +00:00
4ddaceda1a
Version bump to v2.2.0.beta6
2018-12-14 12:21:55 -05:00
1960236822
FIX: Suspicious login detection ( #6772 )
2018-12-14 16:30:34 +00:00
77fe57f923
FEATURE: Rake task to list users which have been staff in the past month
2018-12-14 16:29:12 +00:00
9f3e2a9e34
FIX: Only serialize group membership domains for administrators ( #6771 )
2018-12-14 15:47:00 +00:00
a19f69590a
DEV: add "topic-list-before-relative-date" plugin outlet
2018-12-14 10:39:22 -05:00
124ae46763
Update translations
2018-12-14 10:34:12 -05:00
2f70bd83a3
Increase contrast of pinned excerpt for dark themes
2018-12-14 10:04:44 -05:00
b0c2e9bb05
minor changes to default script-src ( #6770 )
...
- add report-sample to force require a sample of the violating code
- do not whitelist GA/GTM's entire domain
2018-12-14 08:17:31 -05:00
03014b0d05
FEATURE: adds security tab to dashboard ( #6768 )
...
This commit also includes the new staff_logins report
2018-12-14 13:47:59 +01:00
9f89aadd33
FIX: delete all posts in batches without hijack ( #6747 )
2018-12-14 11:04:18 +01:00
05104600ea
FIX: Incorrect translation key on admin search logs.
2018-12-14 17:12:33 +08:00
6553744e50
Fixing topic status alignment in search
2018-12-13 21:49:43 -05:00
6cbcd58603
Lighten lazyload placeholder background
2018-12-13 15:38:33 -05:00
afdd244486
UX: removes superfluous posters column header ( #6765 )
2018-12-13 21:29:00 +01:00
60189e8c92
Mobile alignment fixes
2018-12-13 15:26:52 -05:00
bcf4a17751
FIX: apply original margin-bottom to fix position placeholder ( #6764 )
2018-12-13 18:21:12 +01:00
5cb99d08ed
FIX: define actions on connector class early ( #6763 )
...
This would prevent failure with connectors templates defining actions as closures. In this case action existence is checked at compile time and not runtime.
2018-12-13 15:43:30 +01:00
73c776d881
Update wizard updater spec ( dbbadb5c follow-up)
2018-12-13 11:20:01 +01:00
71ce9ced47
FIX: Incorrect arguments were being passed to `Jobs::ClosePoll`.
...
Also fix spec that wasn't testing anything.
2018-12-13 16:46:00 +08:00
939b82ef0c
DEV: correct intermittent test failure
...
ActionController::BadRequest can not be re-dispatched, under some conditions
we are getting this vs InvalidParameterError in the following test
59c56bd20f/spec/requests/application_controller_spec.rb (L34-L62)
2018-12-13 18:27:13 +11:00
8ef2085585
UX: increase selector specificity so that "inline" lightboxes in quotes don't get backgrounds
...
When a quote is not expanded and it contains lightboxes, those lightboxes are not displayed and instead we show a link that looks like this `[image_title]`
These still have the lightbox CSS class and so they still get the backgrounds we add to lightboxes while they load. Increasing the selector specificity prevents that from happening.
2018-12-13 15:17:08 +08:00
59c56bd20f
DEV: anonymizing should not delete uploads
...
We have another job for upload deletion cause uploads may be shared
2018-12-13 16:43:48 +11:00
7ee9a6a7ec
SECURITY: do not delete avatars uploads when deleting accounts
...
We rely on the clean up uploads job to do this safely
2018-12-13 16:26:07 +11:00
f74ef71130
DEV: add transaction and active check to invalidate job
...
Follows up on 3b76f19668
2018-12-13 14:59:56 +11:00
94b8ba4f8f
FIX: remove slow platform detection from server side
...
Historically due to https://meta.discourse.org/t/why-is-discourse-so-slow-on-android/8823
we decreased page sizes of both home page and topic page on android by half.
This was done on the server side and as a side effect and caused page sizes on android
to mismatch between Android and non Android.
Unfortunately about a year ago googlebot started pretending it is Android,
this cause Google to start indexing pages as what android would see. So
it saw double the amount of pages in the index as what exists on desktop.
This in turn caused double the amount of indexing work and a large amount
of broken links on long topics.
This fix removes all special behavior which is no longer needed due to
other performance work in Discourse including raw handlebars on home page
and virtual dom on topic pages.
I tested we do not need this on Blu Advance 5.0 it has 1.3 GHZ mediatec mt6580
This phone retails for around $50 USD.
If we decide long term that we want any hacks like this we will shift them
to the client side. It can just hold data in memory without rendering.
2018-12-13 13:57:05 +11:00
92df7b212c
rename `visible` to `visibleSiteSettings`
2018-12-13 13:00:13 +11:00
c9279a118e
FIX: always show filtered site settings
2018-12-13 13:00:13 +11:00
59cb907f25
Bump onebox version
...
- update Twitter status icons
2018-12-13 06:25:50 +05:30
3b76f19668
FIX: invalidating inactive admin emails should mark them as not active
2018-12-12 17:07:49 -05:00
a1db15fead
FEATURE: require admins to re-validate their email addresses if they haven't been seen for a number of days, configurable with the invalidate_inactive_admin_email_after_days site setting. Social logins are also revoked. Default is 365 days.
2018-12-12 15:32:38 -05:00
7cac04e1a8
* FEATURE: Adds site setting to let quotes on direct replies.
...
* DEV: Added test.
* FIX: Do not bump topic when removing full quotes.
2018-12-12 15:42:53 +01:00
dbbadb5c35
FEATURE: add short_site_description setting to be included in title tag on homepage
2018-12-12 11:46:58 +01:00
793f1274d1
FIX: makes charts more resilient to resizing ( #6758 )
2018-12-12 11:11:56 +01:00
3a799ed922
FEATURE: Check if draft exists before starting a new one ( #6755 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: zogstrip <regis@hanol.fr>
2018-12-12 10:21:51 +01:00
0ca61242b8
FEATURE: polyfill intersection observer for IE11 / iOS Safari
...
This feature is used for defer loading of images and in future for post cloaking
This gives us a polyfill so we can safely use the feature in problem browsers
The polyfill supports "polling" but it does not appear we need it yet.
If we discover anything odd here, consider setting poll interval per:
https://github.com/w3c/IntersectionObserver/tree/master/polyfill
```
var io = new IntersectionObserver(callback);
io.POLL_INTERVAL = 100; // Time in milliseconds.
```
Keeping the mutation observer cause we often mutate the DOM
2018-12-12 15:36:08 +11:00
e564fe1866
FIX: Sidekiq fails to start if any of the multisite has problems.
2018-12-12 11:30:14 +08:00
6d353a1e47
Alignment & spacing fix for quote controls
2018-12-11 21:17:31 -05:00
86926f4aee
DEV: Let `create!` handle the check for persistence.
...
This is unlikely to fail but we want to know when it does.
2018-12-12 08:36:13 +08:00
6797a710aa
FEATURE: Lazily Load Images as they scroll into the viewport.
...
This feature uses the Intersection Observer API
https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API
It should be compatible with all modern browsers. Non-Edge IE is *NOT*
supported, so in that particular browser images are loaded by default.
2018-12-12 10:12:49 +11:00
5358f25fc6
FIX: Support RTL languages in header menu
2018-12-11 10:33:56 -08:00
d2569f8e77
make linter happy
2018-12-11 09:41:40 -08:00
0f734e2ae2
FIX: Return authenticated=true when reconnecting
...
This prevents a registration popup on the client
2018-12-11 17:40:02 +00:00
71d8807fec
Full height swipe-able menus ( #6566 )
...
* Feature: Full height swipe enabled menus
support pan events on iphone
2018-12-11 09:15:20 -08:00
688755baf2
DEV: Improve specs and handle invalid email token
...
Follow-up to 7977b09025
2018-12-11 18:04:10 +01:00
8c227715ae
$primary-high contrast reduction for dark themes
2018-12-11 10:08:00 -05:00
4cc0a3503b
Adding space between badges for medium-sized viewports
2018-12-11 09:45:49 -05:00
Guo Xiang Tan
Neil Lalonde
Vinoth Kannan
David Taylor
Penar Musaraj
Kris
Kyle Zhao
Joffrey JAFFEUX
Maja Komel
Sam
Joe
Arpit Jalan
Bianca Nenciu
Robin Ward
Jeff Wong
Gerhard Schlager