fc2a511ee2
Build(deps): Bump the rails group with 6 updates
...
Bumps the rails group with 6 updates:
| Package | From | To |
| --- | --- | --- |
| [actionmailer](https://github.com/rails/rails ) | `7.1.4.2` | `7.1.5` |
| [actionpack](https://github.com/rails/rails ) | `7.1.4.2` | `7.1.5` |
| [actionview](https://github.com/rails/rails ) | `7.1.4.2` | `7.1.5` |
| [activerecord](https://github.com/rails/rails ) | `7.1.4.2` | `7.1.5` |
| [activesupport](https://github.com/rails/rails ) | `7.1.4.2` | `7.1.5` |
| [railties](https://github.com/rails/rails ) | `7.1.4.2` | `7.1.5` |
Updates `actionmailer` from 7.1.4.2 to 7.1.5
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v7.2.2/actionmailer/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5 )
Updates `actionpack` from 7.1.4.2 to 7.1.5
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v7.2.2/actionpack/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5 )
Updates `actionview` from 7.1.4.2 to 7.1.5
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v7.2.2/actionview/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5 )
Updates `activerecord` from 7.1.4.2 to 7.1.5
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v7.2.2/activerecord/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5 )
Updates `activesupport` from 7.1.4.2 to 7.1.5
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v7.2.2/activesupport/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5 )
Updates `railties` from 7.1.4.2 to 7.1.5
- [Release notes](https://github.com/rails/rails/releases )
- [Changelog](https://github.com/rails/rails/blob/v7.2.2/railties/CHANGELOG.md )
- [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5 )
---
updated-dependencies:
- dependency-name: actionmailer
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rails
- dependency-name: actionpack
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rails
- dependency-name: actionview
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rails
- dependency-name: activerecord
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rails
- dependency-name: activesupport
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rails
- dependency-name: railties
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rails
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-05 16:15:20 +01:00
415921a106
DEV: Use glint stable ( #29597 )
...
Dependabot had ended up putting some glint packages on the stable version, and some on the unstable version. This made for some very weird behavior.
2024-11-05 15:12:54 +00:00
2aeb529a69
Build(deps-dev): Bump @swc/core from 1.7.42 to 1.8.0 ( #29578 )
...
Bumps [@swc/core](https://github.com/swc-project/swc ) from 1.7.42 to 1.8.0.
- [Release notes](https://github.com/swc-project/swc/releases )
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md )
- [Commits](https://github.com/swc-project/swc/compare/v1.7.42...v1.8.0 )
---
updated-dependencies:
- dependency-name: "@swc/core"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:36:47 +01:00
cc61efbb07
Build(deps): Bump json from 2.7.5 to 2.7.6 ( #29573 )
...
Bumps [json](https://github.com/ruby/json ) from 2.7.5 to 2.7.6.
- [Release notes](https://github.com/ruby/json/releases )
- [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md )
- [Commits](https://github.com/ruby/json/compare/v2.7.5...v2.7.6 )
---
updated-dependencies:
- dependency-name: json
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:16:15 +01:00
0d27c7db70
Build(deps): Bump ace-builds from 1.36.3 to 1.36.4 ( #29579 )
...
Bumps [ace-builds](https://github.com/ajaxorg/ace-builds ) from 1.36.3 to 1.36.4.
- [Release notes](https://github.com/ajaxorg/ace-builds/releases )
- [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.36.3...v1.36.4 )
---
updated-dependencies:
- dependency-name: ace-builds
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:15:20 +01:00
84784d8733
Build(deps-dev): Bump puppeteer-core from 23.6.1 to 23.7.0 ( #29577 )
...
Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer ) from 23.6.1 to 23.7.0.
- [Release notes](https://github.com/puppeteer/puppeteer/releases )
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json )
- [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.6.1...puppeteer-core-v23.7.0 )
---
updated-dependencies:
- dependency-name: puppeteer-core
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:13:27 +01:00
e4e93e0342
Build(deps-dev): Bump concurrently from 9.0.1 to 9.1.0 ( #29576 )
...
Bumps [concurrently](https://github.com/open-cli-tools/concurrently ) from 9.0.1 to 9.1.0.
- [Release notes](https://github.com/open-cli-tools/concurrently/releases )
- [Commits](https://github.com/open-cli-tools/concurrently/compare/v9.0.1...v9.1.0 )
---
updated-dependencies:
- dependency-name: concurrently
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:12:58 +01:00
85c30f4882
Build(deps-dev): Bump rubocop-ast from 1.33.1 to 1.34.0 ( #29574 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.33.1 to 1.34.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.33.1...v1.34.0 )
---
updated-dependencies:
- dependency-name: rubocop-ast
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-05 15:12:35 +01:00
d076ed8c77
DEV: Convert some simple model methods to async/await ( #29594 )
2024-11-05 14:59:51 +01:00
e65367d603
DEV: Add plugin outlet to about.hbs ( #29582 )
...
* DEV: Add plugin outlet to about.hbs
* linter issues
* removed unintended code
2024-11-05 08:33:20 -05:00
c3bc7a6a05
DEV: Add support for image fields in FormKit PageObject ( #29589 )
...
This commit adds an API `upload_image` to `FormKitField` page object for setting an image file on an `Image` field in FormKit. Usage is like this:
```ruby
form.field("image_field").upload_image(image_path)
```
The `value` API also now supports `Image` fields; it returns an `Upload` record if the field has an uploaded image.
2024-11-05 15:35:53 +03:00
a553c9ea0c
FIX: Incorrect reference in TopicListHeaderColumn ( #29593 )
2024-11-05 13:17:41 +01:00
cbfd596b1b
DEV: Remove unnecessary setupController methods ( #29592 )
...
and call super instead of manually setting model
2024-11-05 13:17:32 +01:00
54e7dee6d7
FIX: Chat uploads over-secured in some situations ( #29586 )
...
In the case where:
* Secure uploads were enabled
* Allow unsecure chat uploads was enabled
* For a site with login required enabled
When a chat upload was created, it was being marked as secure. Since
there is no provision for secure uploads in chat, this would lead to
broken uploads/images shown in the channel.
We can use the "public types" functionality of secure uploads to make
sure we never mark chat uploads as secure, and we can revisit this
whenever we get around to allowing secure uploads in chat.
2024-11-05 15:56:30 +10:00
3b0332ef6c
DEV: use Sets for setting lists. ( #29584 )
...
This makes membership checks more efficient
2024-11-05 16:04:24 +11:00
1aa836163e
FIX: poll ranked choice results not showing on first vote ( #28542 )
...
Currently (for Ranked Choice only) a javascript exception is raised on very first vote, preventing the results from being rendered requiring a browser refresh (which doesn't error).
Resolves: TypeError: this.args.rankedChoiceOutcome.round_activity is undefined with simple addition of optional chaining operator.
2024-11-05 09:29:07 +08:00
40a4d55c77
FIX: poll ranked choice voter expansion should append additional voters ( #28432 )
...
Currently, for Ranked Choice results and voter list expansion, the code is replacing the voter list with the newly fetched page of voters instead of appending to the existing voter list. This is resolved in this PR and brings it in line with regular polls.
See: https://meta.discourse.org/t/ranked-choice-poll-does-not-reflect-change-of-votes-in-outcome/321227/18
2024-11-05 09:28:32 +08:00
bba9a99e2e
DEV: Move all experimental settings into new setting category ( #29583 )
...
This will allow admins to easily see all the experiments
in one place. In the future, we would like a full Experiments
config page with descriptions and screenshots, but this will
do for now.
2024-11-05 09:43:12 +10:00
badca20749
DEV: Combine S3 system spec helpers into one ( #29580 )
...
It's annoying to have to do both of these every
time you write an S3 system spec, let's just do them
in one call instead.
2024-11-05 09:28:14 +10:00
1b5a7be3d4
PERF: Replace slow `:has` selectors with body classes ( #29581 )
2024-11-05 10:06:13 +11:00
b124736a1c
DEV: Convert install theme modal to GJS ( #29506 )
...
We will likely get rid of this at some point, but in the meantime
let's make it easier to modify and bring it up to date.
2024-11-05 09:04:33 +10:00
d0a4750caa
DEV: Remove old translations for site settings ( #29536 )
...
For experimental_flags_admin_page_enabled_groups, which was deleted
in 205a2bf0d6
2024-11-05 09:04:17 +10:00
216845e4c7
DEV: Deprecate template overrides ( #29544 )
...
Template overrides have been advised against for a long time, and are increasingly hard to maintain as Discourse's development accelerates. This commit officially deprecates this customization method, which will be removed in the not-too-distant future (likely in the first half of 2025).
2024-11-04 17:38:33 +00:00
9c5fc6f1df
DEV: Add more-topics plugin API ( #29143 )
...
From plugin-api comment:
Registers a new tab to be displayed in "more topics" area at the bottom of a topic page.
```gjs
api.registerMoreTopicsTab({
id: "other-topics",
name: i18n("other_topics.tab"),
component: <template>tbd</template>,
condition: ({ topic }) => topic.otherTopics?.length > 0,
});
```
You can additionally use more-topics-tabs value transformer to conditionally show/hide
specific tabs.
```js
api.registerValueTransformer("more-topics-tabs", ({ value, context }) => {
if (context.user?.aFeatureFlag) {
// Remove "suggested" from the topics page
return value.filter(
(tab) =>
context.currentContext !== "topic" ||
tab.id !== "suggested-topics"
);
}
});
```
2024-11-04 17:32:49 +01:00
7a936da05c
DEV: Auto grid images no longer experimental ( #29572 )
...
Recently we added a new feature for automatically gridding images in the composer (https://github.com/discourse/discourse/pull/29260 ). After testing this feature under a setting for a short period of time, the feature is no longer experimental anymore.
This PR removes the site setting `experimental_auto_grid_images`.
2024-11-04 08:21:40 -08:00
1d637c5243
UX: remove extra margin from PM small actions ( #29571 )
2024-11-04 10:53:35 -05:00
b061fd9cc2
DEV: refactor textarea from d-editor ( #29411 )
...
Refactors the DEditor component making it textarea-agnostic.
2024-11-04 12:48:10 -03:00
6459ab9320
UX: allow anon users to download calendar ( #29551 )
...
Allows anonymous users to download the calendar file. Before, they were given the option, but it would fail silently with a `TypeError: Cannot read properties of null (reading 'user_option')`.
2024-11-04 12:35:45 -03:00
d853b5384b
UX: align PM icon when editing title, allow shrink-to-fit ( #29570 )
2024-11-04 10:31:11 -05:00
380974ce00
DEV: Use `hasAttribute`/`hasAria`/`hasStyle` in tests ( #29568 )
2024-11-04 11:30:38 +01:00
9694d2477a
DEV: Convert more `notOk` assertions ( #29556 )
...
…to either qunit-dom or `strictEqual`
2024-11-04 10:27:30 +01:00
693a4e691b
DEV: Replace `ok(true)` assertions ( #29555 )
...
…with `verifySteps`, `expect(0)`, or by removing it
2024-11-04 10:27:11 +01:00
584a9d98ed
DEV: adds is-disabled modifier to form field container ( #29567 )
...
We already had a data-attribute, but a class feels more natural in this case.
2024-11-04 17:57:40 +09:00
88eb96b315
DEV: sets an icon_upload_id on a channel ( #29566 )
...
There's no UI for it at the moment but when creating a channel or updating it, it's now possible to pass `icon_upload_id` as param. This will be available on the channel as `icon_upload_url`.
2024-11-04 17:19:44 +09:00
932bd6ba85
UX: logs when an automation is destroyed ( #29565 )
...
A `UserHistory` entry will now be created when an automation is destroyed. This is visible in `/admin/logs/staff_action_logs`. id, name, trigger and script will be logged.
This commit also creates a service `DestroyAutomation` to hold all the destroy automation logic.
---------
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
2024-11-04 11:12:18 +09:00
a43bd24c67
Build(deps): Bump @faker-js/faker from 9.1.0 to 9.2.0 ( #29562 )
...
Bumps [@faker-js/faker](https://github.com/faker-js/faker ) from 9.1.0 to 9.2.0.
- [Release notes](https://github.com/faker-js/faker/releases )
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md )
- [Commits](https://github.com/faker-js/faker/compare/v9.1.0...v9.2.0 )
---
updated-dependencies:
- dependency-name: "@faker-js/faker"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 23:18:38 +01:00
f5b8a2d9ad
Build(deps-dev): Bump lint-to-the-future-eslint from 2.1.3 to 2.2.0 ( #29563 )
...
Bumps [lint-to-the-future-eslint](https://github.com/mansona/lint-to-the-future-eslint ) from 2.1.3 to 2.2.0.
- [Release notes](https://github.com/mansona/lint-to-the-future-eslint/releases )
- [Changelog](https://github.com/mansona/lint-to-the-future-eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mansona/lint-to-the-future-eslint/commits )
---
updated-dependencies:
- dependency-name: lint-to-the-future-eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 23:18:23 +01:00
a5cad6640a
Build(deps): Bump date from 3.3.4 to 3.4.0 ( #29561 )
...
Bumps [date](https://github.com/ruby/date ) from 3.3.4 to 3.4.0.
- [Release notes](https://github.com/ruby/date/releases )
- [Commits](https://github.com/ruby/date/compare/v3.3.4...v3.4.0 )
---
updated-dependencies:
- dependency-name: date
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 23:17:57 +01:00
725d2411e5
This commit fixes an undesirable geometric query memory usage introduced in b908abe35a ( #29539 )
...
I have been unable to figure out a way of testing this usefully (as I fear it would require creating several thousands of objects), but existing tests pass and a manual test with ~400k topics succeeds after the fix, while it would hang indefinitely and/or consume all disk space before the fix.
I have reported the initial problem and my findings in https://meta.discourse.org/t/topic-reset-all-highest-exhausts-all-available-disk-space/333837
2024-11-04 09:00:03 +11:00
f4865a4288
Build(deps-dev): Bump rubocop-ast from 1.33.0 to 1.33.1 ( #29560 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.33.0 to 1.33.1.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.33.0...v1.33.1 )
---
updated-dependencies:
- dependency-name: rubocop-ast
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 22:51:05 +01:00
d5595284ea
Build(deps): Bump oj from 3.16.6 to 3.16.7 ( #29558 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.16.6 to 3.16.7.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.16.6...v3.16.7 )
---
updated-dependencies:
- dependency-name: oj
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 22:50:51 +01:00
ce76b88eb2
DEV: start/stop reply implementation ( #29542 )
...
* DEV: join/leave presence chat-reply when streaming
This commit ensures that starting/stopping a chat message with the streaming option will automatically make the creator of the message as present in the chat-reply channel.
* implements start/stop reply
* not needed
2024-11-04 08:14:35 +11:00
279fc846db
FEATURE: adds support for headings in chat ( #29552 )
...
```
```
Will now be converted into their html versions: <h1>, <h2>, <h3>, ...
2024-11-04 08:11:53 +11:00
b81055a6d4
DEV: Convert more `equal` assertions ( #29554 )
...
…to either qunit-dom or `strictEqual`
2024-11-03 21:04:38 +01:00
d2056c7fc6
DEV: Update checklist tests ( #29553 )
2024-11-03 21:04:22 +01:00
ba7f4e3c63
Build(deps-dev): Bump webpack from 5.96.0 to 5.96.1 ( #29545 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.96.0 to 5.96.1.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.96.0...v5.96.1 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-03 16:26:55 +01:00
deeed5b8c1
DEV: Add 'custom' WebHook event type group ( #29549 )
2024-11-01 13:30:37 -05:00
323013d9c7
DEV: restore topic argument for after-topic-status outlet ( #29550 )
...
Followup to dd329d55
2024-11-01 18:25:40 +00:00
4863b2ab7e
DEV: Added value transformers that mutate the value instead of returning it ( #29537 )
2024-11-01 14:23:46 -03:00
723dc1fa55
Dev fix some types ( #29547 )
...
The primary key is usually a bigint column, but the foreign key columns
are usually of integer type. This can lead to issues when joining these
columns due to mismatched types and different value ranges.
This was using a temporary plugin / test API to make tests pass. After
more careful consideration, we concluded that it is safe to alter the
tables directly.
2024-11-01 19:19:25 +02:00
dependabot[bot]
David Taylor
Jarek Radosz
Juan David Martínez Cubillos
Osama Sayegh
Martin Brennan
Sam
Robert
Keegan George
Kris
Renato Atilio
Joffrey JAFFEUX
pgcd
Mark VanLandingham
Sérgio Saquetim
Bianca Nenciu