Ludovic Orban
e7aa3c2e23
explicitly size the listeners array lists
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-05-13 17:38:43 +02:00
Ludovic Orban
87be7b15eb
replace regex match with simple string comparisons
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-05-13 15:14:50 +02:00
Jan Bartel
6527b3b083
Issue #4868 update asm 7.3.1 ( #4869 )
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-05-13 12:12:14 +02:00
Ludovic Orban
f039becb97
Replace HashSet with ArrayList as that has two benefits: ( #4871 )
...
- ArrayList contains() + add() is faster than HashSet add() for small collections
- A heap allocation of the iterator is required when iterating HashSet while iterating ArrayList can do with a stack allocation
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-05-13 09:14:59 +02:00
Joakim Erdfelt
86a40a07d6
Merge pull request #4863 from eclipse/jetty-9.4.x-4860-NullHttpFields
...
Issue #4860 - NPE from HttpFields
2020-05-11 21:04:50 -05:00
Joakim Erdfelt
d127db5186
Merge branch 'jetty-9.4.x-4860-NullHttpFields' of github.com:eclipse/jetty.project into jetty-9.4.x-4860-NullHttpFields
2020-05-11 17:26:05 -05:00
Joakim Erdfelt
4dc024b2b1
Issue #4860 - Fixing test comment
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-05-11 17:25:49 -05:00
Greg Wilkins
59a66158ed
Issue #4860 NPE HttpFields
...
Fixes from review.
Fixed iterator overflow bug
clearer updates of size
better nonNull messages
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-05-11 22:09:19 +02:00
Greg Wilkins
e86977394e
Issue #4828 Buffer Corruption ( #4864 )
...
+ improve synchronization around releaseBuffer
+ improve synchronization around acquireBuffer
+ made acquireBuffer private.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-05-11 21:48:06 +02:00
Joakim Erdfelt
6ae75be9bc
Issue #4860 - Consistency to HttpFields API
...
If a null name (or HttpHeader or HttpField) is used
it should throw an ISE
+ .add() should remain consistent
+ .put() should remain consistent
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-05-11 10:34:52 -05:00
Joakim Erdfelt
90da10dac5
Issue #4860 - Improving testPreventNullField testcase
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-05-11 10:05:56 -05:00
Joakim Erdfelt
2c7c98f469
Eliminate warnings
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-05-11 10:03:12 -05:00
Greg Wilkins
1ac7fe4f9c
Issue #4860 NPE from HttpFields
...
+ Fix bug with list iterator nextIndex
+ List iterator cannot inject null fields
+ minor cleanups
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-05-11 14:00:04 +02:00
Greg Wilkins
6af6af6419
Issue #4860 NPE from HttpFields
...
Improved test coverage
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-05-11 13:58:27 +02:00
Greg Wilkins
c497b61917
Issue #4860 NPE from HttpFields
...
Paranoid catch if sending and exception page throws an exception.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
2020-05-11 13:57:17 +02:00
olivier lamy
933ab641ee
test helper 5.4
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-05-11 15:38:15 +10:00
Simone Bordet
ad72d29f2a
Merge pull request #4856 from lorban/jetty-9.4.x-4847-socket-configuration-properties
...
introduce socket configuration properties in Jetty XML files
2020-05-08 15:14:44 +02:00
Ludovic Orban
409db8d065
introduce socket configuration properties in Jetty XML files
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-05-08 13:14:50 +02:00
Simone Bordet
80f70288d9
Merge pull request #4854 from eclipse/jetty-9.4.x-4789-ShutdownThread
...
Issue #4789 - Name the ShutdownThread
2020-05-08 10:47:43 +02:00
Lachlan
908331acbd
Add jetty to ShutdownThread name.
2020-05-08 18:46:09 +10:00
Lachlan Roberts
bb967cb841
Issue #4789 - Name the ShutdownThread
...
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
2020-05-08 15:07:27 +10:00
olivier lamy
cba05a3db0
increase surefire memory
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-05-08 11:00:49 +10:00
olivier lamy
a818a3551b
a bit more memory to see if that fix heap space issue with jdk14 build
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-05-08 07:31:06 +10:00
olivier lamy
5ee6b67e0a
align with 10.0.x to ease merging
...
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-05-08 07:29:56 +10:00
Olivier Lamy
78992a126c
Start a mongo instance for testing using docker via java code ( #4840 )
...
* remove slow mongo maven plugin which was forking an external process and now run mongodb in a container so we can even now test with different version using -Dmongo.docker.version
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-05-08 07:06:03 +10:00
Ludovic Orban
072cc978fb
add HttpConfiguration.Customizer implementation that sets request attributes containing the real local and remote address:port pairs ( #4849 )
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-05-07 19:53:15 +02:00
Joakim Erdfelt
c50a52a392
Merge pull request #4844 from lorban/jetty-9.4.x-4843-proxyv2-ignored-address-length
...
proxy v2 skip address length bytes when LOCAL command is specified
2020-05-07 10:16:57 -05:00
Joakim Erdfelt
e4fd49dc36
Merge pull request #4838 from eclipse/jetty-9.4.x-4835-gziphandler-flush
...
Issue #4835 - Addressing flush/commit with GzipHttpOutputInterceptor
2020-05-05 09:54:41 -05:00
Ludovic Orban
d34cb2598b
proxy v2 skip address length bytes when LOCAL command is specified
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-05-05 13:51:30 +02:00
Simone Bordet
0ab2b42055
Merge pull request #4823 from eclipse/jetty-9.4.x-4798-recover_selector_failures
...
Issue #4798 - Recover from Selector Failures
2020-05-04 17:43:28 +02:00
Joakim Erdfelt
d58da0f7d2
Issue #4824 - Addressing flush/commit with GzipHttpOutputInterceptor
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-05-04 09:22:08 -05:00
Simone Bordet
2fa161c515
Merge pull request #4790 from eclipse/jetty-9.4.x-4778-sni_with_one_certificate
...
Fixes #4778 - Enforcing SNI when there are only non-wildcards certifi…
2020-05-04 11:35:04 +02:00
Joakim Erdfelt
c645d0f7c4
Issue #4835 - Addressing flush/commit with GzipHttpOutputInterceptor
...
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-05-01 14:42:08 -05:00
Olivier Lamy
abb26d0781
Jetty 9.4.x hazelcast fix non needed dependency ( #4832 )
...
* no need to websocket dependency in jetty-hazelcast
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
* fix dependency
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
2020-05-01 11:21:42 +10:00
Simone Bordet
0a028b663b
Issue #4798 - Better handling of fatal Selector failures.
...
More updates after review.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-04-30 10:55:29 +02:00
Simone Bordet
ac97bc3b31
Merge pull request #4803 from lorban/jetty-9.4.x-channel-recycling-h2
...
Solve lock contention creating HTTP2 streams (#2188 ) …
2020-04-29 15:18:50 +02:00
Ludovic Orban
6729a6f689
Solve lock contention creating HTTP2 streams ( #2188 ) while fixing race condition that breaks http channels recycling ( #4695 )
...
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
2020-04-29 14:25:51 +02:00
Simone Bordet
8c75eeccce
Issue #4798 - Better handling of fatal Selector failures.
...
Updates after review.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
2020-04-29 11:57:06 +02:00
Joakim Erdfelt
3998e657cc
Merge remote-tracking branch 'origin/jetty-9.3.x' into jetty-9.4.x
2020-04-28 13:45:29 -05:00
Joakim Erdfelt
85e3a4b5a6
Merge remote-tracking branch 'origin/jetty-9.2.x' into jetty-9.3.x
2020-04-28 13:44:12 -05:00
Joakim Erdfelt
ce78b195d1
Merge pull request #4811 from eclipse/jetty-9.2.x-old-android-workarounds
...
Issue #4819 - Workarounds for old (pre API 24) Android SDKs
2020-04-28 11:31:12 -05:00
Jan Bartel
e2af6419ae
Issue #4820 jetty-deployer.xml should be jetty-deploy.xml for osgi ( #4821 )
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-04-28 11:38:38 +02:00
Greg Wilkins
8fcbf6d590
Improve Attributes Handling ( #4816 )
...
* Spun out from #4814 Improve Attributes Handling
Improve attribute handling to reduce garbage and improve lookup.
Introduced a Wrapper so that request can remove any layers on reset.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4814 - Exposing AttributeMap.getAttributeNameSet() on Attributes.
The underlying AttributesMap already has a .getAttributeNameSet()
method, expose it on the Attributes interface.
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
* Allow a set to override a secure attribute.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
* Issue #4814 - Attributes.getAttributeNames() is now defaulted
The Attributes.getAttributeNames() will use the
.getAttributeNameSet() by default now.
Updated all Attributes.Wrapper impls to use this new behavior
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-04-28 10:16:29 +02:00
Simone Bordet
8929791e6c
Merge pull request #4791 from eclipse/jetty-9.4.x-4787-mutable_host_port_client_request
...
Fixes #4787 - Make org.eclipse.jetty.client.HttpRequest's host name w…
2020-04-27 23:29:29 +02:00
Simone Bordet
952a20f81c
Issue #4798 - Better handling of fatal Selector failures.
...
Implemented selector recovery by transferring
all keys to a newly created selector.
Updated code so that it does not assume that the
SelectionKey never changes.
2020-04-27 23:19:06 +02:00
Simone Bordet
46ad90598c
Code cleanups.
2020-04-27 22:57:57 +02:00
Jan Bartel
3c1f42c1c7
Issue #4818
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-04-27 16:12:44 +02:00
Joakim Erdfelt
26e6979ce2
Issue #4819 - Rework SSL/TLS methods to allow use on Android API 23 (or older)
...
* Workaround missing SSLEngine.getHandshakeSession()
* Workaround missing SSLParameters.setEndpointIdentificationAlgorithm()
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
2020-04-27 09:00:50 -05:00
Jan Bartel
b593f67048
Issue #4818 Fix jsp doc
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-04-27 15:52:28 +02:00
Jan Bartel
ed486f1d3e
Issue #4817 Fix jsp doco
...
Signed-off-by: Jan Bartel <janb@webtide.com>
2020-04-27 15:32:51 +02:00