Commit Graph

5841 Commits

Author SHA1 Message Date
Yoann Rodière 9616e24c80 HHH-14315 Add optional support for toolchains to the Gradle build
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
2020-11-10 11:02:08 +00:00
Christian Beikov 555299abf1 HHH-14214 Remove unnecessary rule for token type SQL_NODE 2020-11-10 11:43:11 +01:00
Guillaume Smet a393cbd7f5 HHH-14316 Avoid accessing state in DriverManagerConnectionProviderImpl if null 2020-11-09 15:15:06 +00:00
David Ellingsworth 1c6e2b4efb HHH-14216 Add new lines to the end of new files. 2020-11-04 09:25:20 -07:00
David Ellingsworth 24035d7f2c HHH-14216 Implement isDirty for OneToOneType and always check if it is dirty or not. 2020-11-04 09:25:20 -07:00
David Ellingsworth ef5c944c86 HHH-14216 Fix the assemble/disassemble methods of the OneToOneType. 2020-11-04 09:25:20 -07:00
David Ellingsworth aec21d21f8 HHH-14216 Add one-to-one second level cache tests. 2020-11-04 09:25:20 -07:00
Steve Ebersole f45a88cb07 Fixed Javadoc for `BulkOperationCleanupAction.affectedEntity`
- plus minor cleanups
2020-11-03 15:13:09 -06:00
Sanne Grinovero 67fd24ecff Make new EntityLoader buildling methods in AbstractEntityPersister protected for Hibernate Reactive 2020-11-01 23:24:22 +00:00
Sanne Grinovero e6ac4d4876 HHH-14305 Memory optimisations for ReaderCollector implementations 2020-11-01 22:05:57 +00:00
Sanne Grinovero da700f619b HHH-14305 Memory optimisations for EntityMetamodel 2020-11-01 22:05:49 +00:00
Sanne Grinovero 345b503f21 HHH-14305 Memory optimisations for NamedQueryRepository 2020-11-01 22:05:44 +00:00
Sanne Grinovero ad5bec0a54 HHH-14305 Memory optimisations for AbstractEntityPersister#uniqueKeyLoaders 2020-11-01 22:05:40 +00:00
Sanne Grinovero 9f54dae5d2 HHH-14305 Memory optimisation for AbstractPropertyMapping#duplicateIncompatiblePaths 2020-11-01 22:05:35 +00:00
Sanne Grinovero 35c58e9877 HHH-14305 Memory optimisations for AbstractManagedType#declaredPluralAttributes 2020-11-01 22:05:23 +00:00
Sanne Grinovero 2dde4c1710 HHH-14305 Memory optimisation for AbstractEntityPersister#affectingFetchProfileNames 2020-11-01 22:05:16 +00:00
Sanne Grinovero 169a01857c HHH-14305 Reduce memory consumption of AbstractEntityPersister#attributeDefinitions 2020-11-01 22:05:10 +00:00
Sanne Grinovero e9278288a7 HHH-14305 Reduce retained memory consumption of SingleTableEntityPersister 2020-11-01 22:05:03 +00:00
Sanne Grinovero 820fe56aa4 HHH-14305 Memory savings in SingleTableEntityPersister 2020-11-01 22:04:56 +00:00
Sanne Grinovero 0dedcd05db HHH-14305 Avoid referring to an empty ArrayList for AbstractEntityPersister#lobProperties 2020-11-01 22:04:50 +00:00
Sanne Grinovero fb34b720bc HHH-14305 Introduce new method in CollectionsHelper to reduce size of long lived collections 2020-11-01 22:04:47 +00:00
Sanne Grinovero 250db69e8e HHH-14305 Remove unused logger 2020-11-01 22:04:42 +00:00
Sanne Grinovero 81d526e4db HHH-14271 Lazy initialization of UniqueEntityLoader for most LockMode types 2020-11-01 19:31:49 +00:00
Sanne Grinovero c60765a528 HHH-14304 Replacing eager initialization of LockingStrategy within AbstractEntityPersister
And introducing a new ad-hoc collection LazyIndexedMap, useful to
lazily initialize elements which can be indexed by int, such
as the ordinal of enums.
2020-11-01 19:31:43 +00:00
Christian Beikov b24a3cbf2d HHH-14279 Fix join ordering issue that happens for entity key joins when using a WITH/ON clause 2020-10-29 10:26:58 +01:00
Laurent Almeras 4ffb768a7a HHH-14279 Testcase showing key join order is messed up 2020-10-29 10:26:58 +01:00
Sanne Grinovero 6b58d54057 HHH-14293 Reset the ReflectionManager state after SessionFactory is initialized 2020-10-28 16:54:06 +00:00
Sanne Grinovero f3396805d4 HHH-14293 JPAMetadataProvider needs to be able to reset its internal caches 2020-10-28 16:54:01 +00:00
Sanne Grinovero 67a2ed17ca HHH-14292 Avoid defensive copy for keywords set in NormalizingIdentifierHelperImpl 2020-10-28 15:51:49 +00:00
Steve Ebersole 18b3def741 HHH-14291 - Minor changes for NativeQuery and BulkOperationCleanupAction 2020-10-28 10:00:30 -05:00
Sanne Grinovero 503c48cbc7 HHH-14290 Remove capability of loading classes by name from HCANN 2020-10-27 07:13:02 +00:00
Sanne Grinovero a0e4ab72ec HHH-14290 Adjust HCANNHelper to benefit from HCANN-99 2020-10-27 06:34:19 +00:00
Sanne Grinovero abf42f4db0 HHH-14289 Detection of JDBC support for RefCursors was returning false even for Oracle JDBC drivers supporting it 2020-10-26 18:24:23 +00:00
Sanne Grinovero ad6584ff10 HHH-10715 Deleting more dead code 2020-10-25 21:33:30 +00:00
Sanne Grinovero 5b6f3ff3b8 HHH-10715 Remove unused logger instance 2020-10-25 21:33:28 +00:00
Sanne Grinovero e3edcdbe55 HHH-10715 More static and final keywords missing 2020-10-25 21:33:23 +00:00
Sanne Grinovero a7629c4382 HHH-10715 Missing null check after File.listFiles 2020-10-25 21:33:20 +00:00
Sanne Grinovero b518df7da4 HHH-10715 Unreleased statement in IdTableHelper 2020-10-25 21:33:18 +00:00
Sanne Grinovero 96209e0ff6 HHH-10715 A couple of missing final keywords 2020-10-25 21:33:15 +00:00
Sanne Grinovero b13a116a6e HHH-10715 Dead code eliminated 2020-10-25 21:33:13 +00:00
Sanne Grinovero 111e551dcd HHH-10715 Dead code elimination 2020-10-25 21:33:02 +00:00
Sanne Grinovero ba0bf0d619 HHH-10715 Make IdentifierProperty immutable 2020-10-25 21:32:56 +00:00
Sanne Grinovero 7870329b77 HHH-14282 StandardRefCursorSupport can rely on having JDK8 as baseline today 2020-10-25 21:31:17 +00:00
Sanne Grinovero 5091203426 HHH-14278 No longer use the AssertionFailure and StringHelper implementations from HCANN 2020-10-22 20:10:28 +01:00
Andrea Boriero fa5078a915 HHH-14245 ClassCastException for Criteria Collection size selection 2020-10-21 14:45:34 +01:00
Andrea Boriero 98168bd066 HHH-14245 Add test for issue 2020-10-21 14:41:04 +01:00
Scott Marlow dbd13e1389 HHH-14196 Add parsing of persistence.xml/orm.xml documents in the EE 9 namespace
Signed-off-by: Scott Marlow <smarlow@redhat.com>
2020-10-20 15:56:11 +01:00
Sanne Grinovero 97d101b742 HHH-14269 Confusing method names unableToObjectConnectionMetadata and unableToObjectConnectionToQueryMetadata 2020-10-20 12:40:25 +01:00
Daniel Wu d9ec18fad7 HHH-14268 Include stacktrace at WARN level in case of an error occurs when getting the connection metadata 2020-10-20 12:12:48 +01:00
Nathan Xu f17c0f7a03 HHH-14234 fix CI building error on non-H2 dialect 2020-10-19 16:17:37 +02:00
Nathan Xu f8fb0b0069 HHH-14234 fix CI building error on HANA dialect 2020-10-19 08:49:06 +02:00
Nathan Xu 5b8bae5cc7 HHH-14234 fix issue denormalized table should not inherit indexes from parent table 2020-10-18 16:29:08 +02:00
Nathan Xu 962884a8dd HHH-14264 fix bug that entity graph cannot be applied to child entity class 2020-10-18 11:53:16 +02:00
Yanming Zhou 88acc9511b HHH-14253 support ConstraintMode.PROVIDER_DEFAULT
Provide an option to skip foreign key creation for ConstraintMode.PROVIDER_DEFAULT
2020-10-14 09:20:17 +02:00
Jan Schatteman 8d4de09255 HHH-14241 Support ImplicitNamingStrategyComponentPathImpl with IdClass
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
2020-10-09 13:24:17 +02:00
Fabio Massimo Ercoli 03416a8cdd HHH-14241 Test ImplicitNamingStrategyComponentPathImpl with IdClass 2020-10-09 13:24:17 +02:00
Nathan Xu 3a88b1c6b2 HHH-14248 Other minor improvements to ActionQueue 2020-10-08 08:19:49 +01:00
Nathan Xu c3e43ecd11 HHH-14248 Refactor latestBatches from InsertActionSorter's field to temporary variable in its sort method 2020-10-08 08:19:40 +01:00
Andrea Boriero 112d215371 HHH-14249 MultiLineImport fails when script contains blank spaces or tabs at the end of the last sql statement 2020-10-07 08:54:48 +01:00
Andrea Boriero 425ee2d3d5 HHH-14249 Add test for issue 2020-10-07 08:54:48 +01:00
Nathan Xu 05f47ce80b HHH-14227 fix testing failure on Oracle 2020-10-06 08:56:38 +01:00
Nathan Xu d045797aa7 HHH-14227 Add some more tests to cover order of batched insert executions 2020-10-05 13:40:08 +01:00
Nathan Xu 9de5e3e005 HHH-14227 Some additional typos and message improvements 2020-10-05 13:40:08 +01:00
Nathan Xu de6736ba32 HHH-14227 Insert statements are not ordered with entities that use inheritance and reference a subclass 2020-10-05 13:40:08 +01:00
Nathan Xu 733ece81f4 HHH-14231 Fix ClassCastException in ScrollableResultsImpl for primitive array value 2020-09-30 17:56:29 +01:00
Dmitry Gusev 77cf9d5108 HHH-14242 Micro optimisations of ActionQueue: redundant branch evaluation 2020-09-30 17:27:12 +01:00
Sanne Grinovero 71ef49d6b1 Revert "HHH-14240 Stop generating fragments of SQL as uppercase"
This reverts commit 9ac29ab4dc.

See also https://github.com/hibernate/hibernate-orm/pull/3555#issuecomment-701472270
2020-09-30 17:10:42 +01:00
Sanne Grinovero 225e29d2b2 HHH-14217 Minor optimisations in the highlighting formatter implementation 2020-09-30 16:58:29 +01:00
Sanne Grinovero 916513a7eb HHH-14217 Code style 2020-09-30 16:51:27 +01:00
Gavin King cf995a1571 HHH-14217 Add syntax highlighting to the logged SQL
Using ANSI escape codes

Must be explicitly enabled using hibernate.highlight_sql
2020-09-30 16:39:12 +01:00
Gavin King 9ac29ab4dc HHH-14240 Stop generating fragments of SQL as uppercase 2020-09-30 16:17:59 +01:00
Gavin King 7f6479541d HHH-14203 DB2 requires the restrict keyword to drop the schema
The 'restrict' keyword is required on DB2.
2020-09-30 15:55:20 +01:00
Gavin King bc39df2812 HHH-14238 Option to include collection fields in the default fetch group
There is no good reason to lazily-instantiate a collection
wrapper, since that operation never requires access to the
database.

See discussion here:

   https://github.com/hibernate/hibernate-reactive/issues/374
2020-09-30 15:24:48 +01:00
Andrea Boriero 57004cdee7 HHH-14220 Fix failure with Oracle 2020-09-29 08:31:48 +01:00
Andrea Boriero a64f193fae HHH-14220 Skip test when bytecode provider is Javassist 2020-09-28 21:39:44 +01:00
Sanne Grinovero f2a742e3c4 HHH-14236 Improve efficiency of ForeignKeyKey 2020-09-28 16:10:10 +01:00
Andrea Boriero a6eaed2db6 HHH-14220 EnhancementException failure with MappedSuperclass with a un-mapped collection 2020-09-28 17:09:00 +02:00
Andrea Boriero 5b8f5aa756 HHH-14220 Add test for issue 2020-09-28 17:09:00 +02:00
Jan-Willem Gmelig Meyling ad80d0bb41 HHH-14223 - Consider formulaTemplates in ID mapping for formula dereference 2020-09-28 14:26:51 +02:00
kubo ac34d72161 HHH-14223 - nullpointer exception on @JoinFormula with implicit join 2020-09-28 14:26:51 +02:00
Yanming Zhou 23fdfa4d6a HHH-14230 Fix generics to avoid ClassCastException 2020-09-28 11:06:29 +01:00
seregamorph 9934baf90e HHH-13884 Order.reverse() contract 2020-09-28 08:17:59 +02:00
Christian Beikov 6d67efa339 HHH-14212 Rename trigger entity to avoid keyword collision on Oracle 2020-09-22 15:52:40 +02:00
Nathan Xu 99a4edfac0 HHH-14212 fix Fetch Graph by simply returning false in TwoPhaseLoad#getOverridingEager() when Fetch Graph is being enforced 2020-09-22 08:06:49 +02:00
Nathan Xu 39b42c0a6a HHH-14212 revert back HHH-8776 (retaining testing case) 2020-09-22 08:06:49 +02:00
Nathan Xu 7cfdd0609d HHH-14212 revert back HHH-14097 (retaining testing case) 2020-09-22 08:06:49 +02:00
Nathan Xu 4c5f94f917 HHH-14212 revert back HHH-14124 (retaining testing case) 2020-09-22 08:06:49 +02:00
Yanming Zhou 6fb52c4fcd HHH-14219 Fix duplicated rows of sequence table
if generator is shared by multiple entities
2020-09-21 12:23:39 +02:00
Nathan Xu f136dabe18 HHH-14218 fix some typos in code comments 2020-09-20 14:44:45 +02:00
Christian Beikov 7ef5336fec HHH-14201 Fix test issues of NaturalIdDereferenceTest 2020-09-14 17:06:49 +02:00
Christian Beikov 20e5a5659b HHH-14148 Fix ANTLR grammar non-determinism 2020-09-14 17:06:49 +02:00
Nathan Xu 886083ab77 HHH-14201 fix HQL JOIN order issue 2020-09-14 10:04:07 +02:00
Nathan Xu cf94259248 HHH-14148 fix issue mapping order SQL fragment could produce incorrect SQL 2020-09-14 10:00:21 +02:00
Nathan Xu f91ed82757 HHH-14213 fix query numeric literal (integer representation) parsing exception message 2020-09-14 09:43:05 +02:00
Gavin King f203bda5db HHH-14204 Schema validator should be more forgiving of column type mismatches 2020-09-09 18:01:34 +01:00
Nathan Xu 3846001907 HHH-14206 Auto-apply converter not applied to primitives 2020-09-09 16:37:23 +02:00
Falko Modler 1cf99c748a HHH-14031 Update h2 to 1.4.197
Notes:
- h2 1.4.197+ does not support ns precision by default anymore
- h2 DateTimeUtils.resetCalendar() is required for many tests to avoid failures due to h2 internal caching
2020-09-09 10:32:21 +01:00
Yanming Zhou 4499abd9a9 Replace StringBuffer with StringBuilder
avoid unnecessary synchronization
2020-09-09 07:55:00 +02:00
Andrea Boriero 7f6ead80cc HHH-14197 Fix MariaDB failing test 2020-09-07 14:18:42 +01:00
Andrea Boriero 6cc63d9289 HHH-14113 Fix oracle test failure 2020-09-07 09:30:53 +01:00
Nathan Xu 37a60ea8bb HHH-14197 Criteria API doubly-nested subquery generates invalid SQL - missing subquery root 2020-09-07 09:22:18 +02:00
Jan-Willem Gmelig Meyling 17d365ecf8 HHH-14198 - Expose CompositeUserTypes through JPA Metamodel
Composite User Types work like regular Composite Types (like Embeddable) in HQL. However, because they cannot be represented in the JPA metamodel, libraries like [GraphQL for JPA](https://github.com/jcrygier/graphql-jpa) or [Blaze-Persistence](https://persistence.blazebit.com/) cannot fully utilize them. In order to make the composite property names available to these libraries, it would be nice to optionally expose these attributes as embedded attributes. This pull request aims to make that change and makes it configurable through a custom setting.

Composite User Types are a common solution for mapping composite interfaces. A common example is for example `Money` from the Java Money API (JSR-354), for which composite user types are implemented in [Jadira](http://jadira.sourceforge.net/usertype-userguide.html).

I know Composite User Types are currently not consiered in Hibernate 6.x. See also [this](https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/topic/CompositeUserType) Zulip thread. I am not sure if Hibernate 6.x will even have multi column types, which I presume would be a requirement to even introduce Composite User types back at some point. Usually Embeddables are a much easier, suitable mechanism for composite user types. But Embeddables are not always a viable alternative, because Embeddables require the type to be subclassed (as an interface cannot be mapped, and the type may not solely comprise fields that can be mapped to a simple basic type). To deal with this exact problem, `MonetaryAmounts` are still mapped as composite user type. There also have been suggestions to the JPA Spec to consider `AttributeConverters` for Embeddables for pracitcally the same purpose (which I think is going to be a mess of an implementation). See: https://github.com/eclipse-ee4j/jpa-api/issues/105

Anyways, regardless of whether this gets integrated in 5.x, I don't expect it to be integrated in 6.x unless we also reintroduce Composite User Types. I am willing to contribute Composite User Types for 6.x if people see benefit in it and think it can be done in the first place.
2020-09-04 14:53:11 +02:00
Nathan Xu 6365204c48 HHH-13058 fix issue left join root cannot be replaced by correlated parent in subquery 2020-09-03 08:50:19 +02:00
Moritz Becker afd6818e55 HHH-13201 - mark local origin variable as final 2020-09-03 08:42:15 +02:00
Moritz Becker d97db034b4 HHH-13201 - reformat test 2020-09-03 08:42:15 +02:00
Moritz Becker 19af434b21 HHH-13201 - do not set empty text on collection join parent without queryable collection 2020-09-03 08:42:15 +02:00
Nathan Xu 162bc7d9dd HHH-14113 Entity Graph attribute resolution not based on selected entity 2020-09-01 20:20:54 +02:00
Andrea Boriero e8b6bbbef4 HHH-14178 Fix Hana test failures 2020-09-01 14:50:24 +01:00
Andrea Boriero efa7e66c73 HHH-14178 Fix oracle test failures 2020-09-01 11:27:02 +01:00
Nathan Xu 90be61210c HHH-11877 wrap CompoundPredicate's expression list 2020-08-31 16:17:32 +02:00
Nathan Xu e1ff70519a HHH-14178 Fix the issue collections visiting could be skipped (e.g., versioned entity) in AbstractSaveEventListener 2020-08-31 14:43:09 +02:00
Nathan Xu 41161f9fa9 HHH-13908 fix the issue MySQL's 'time' function issue in Criteria 2020-08-31 09:44:17 +02:00
Gavin King 5b9ec29ecb HHH-14153 refactoring after HHH-14153
- avoid use package-scoped instance felds
- remove copy/pasted code

Note: I don't hate package-scoped final fields, but I
know other folks tend to. So let's go with template
methods instead.
2020-08-27 09:53:22 +01:00
Gavin King 5daf440a6c HHH-14153 Make buildAppropriateStatementExecutor() protected
Hibernate Reactive might ultimately need to override
this method, though it doesn't right now.

Relates to HHH-14153.
2020-08-27 09:53:18 +01:00
Gavin King 5173071322 HHH-14153 add test
By NathanQingyangXu

See https://github.com/hibernate/hibernate-orm/pull/3508
2020-08-27 09:53:18 +01:00
Gavin King 423697026d HHH-14153 further optimization for single-table HQL update
This extends the optimization for single-table HQL bulk
updates to the case where the where clause touches multiple
tables and we can use a subselect to collect the ids that
we need to update.
2020-08-27 09:53:18 +01:00
Gavin King 264e71a916 HHH-14153 clean up BasicExecutor and friends
introduces InsertExecutor and UpdateExecutor since we're
going to be introducing specific optimizations relating
to single-table updates

relates to HHH-14153
2020-08-27 09:52:40 +01:00
Gavin King d1119d320a HHH-14153 optimize away temp table for single-table HQL update
When a HQL bulk update query only touches a single table,
use BasicExecutor instead of MultiTableUpdateExecutor.

This is an alternate implementation to the one proposed by
@NathanQingyangXu in #3508 and loosely based on that work.
2020-08-27 00:12:07 +02:00
Sanne Grinovero 59d40c3bf5 HHH-14193 MultipleLinesSqlCommandExtractor should tolerate empty input scripts 2020-08-26 22:29:07 +01:00
Steve Ebersole b9fcc63d84 HHH-14152 sql-script.g fix for antlr non deterministic warning
- Added "system"-style SqlScriptLogging
- Added rule trace logging through SqlScriptLogging
2020-08-26 08:56:19 -05:00
Andrea Boriero fe4a94d90c HHH-14152 sql-script.g fix for antlr non deterministic warning 2020-08-26 08:56:19 -05:00
Sanne Grinovero 28787bc013 HHH-14190 Method StringHelper#moveAndToBeginning could benefit from using the improved helper too 2020-08-26 12:46:12 +01:00
Sanne Grinovero 03a1bb5ac8 HHH-14190 Improve efficiency of StringHelper#isBlank 2020-08-26 12:44:05 +01:00
Gavin King 9c6805fdd3 HHH-14190 Rename isEmptyOrWhitespace() to isBlank()
and use it in more places
2020-08-26 12:44:01 +01:00
Andrea Boriero beabfecb3e HHH-14187 Lazy loading fails if an entity appears twice in the object graph when enhancement as proxy is enabled 2020-08-26 12:24:04 +02:00
Andrea Boriero dbca6a2291 HHH-14187 Add test for issue 2020-08-26 12:24:04 +02:00
Gavin King 9ded66b90f HHH-14181 Fix bug where HQL update/delete query resulted in same table being updated twice
for HQL bulk update/delete against union-subclass mapping

also clean up iterator usage in that section of code
2020-08-24 21:03:36 +01:00
Falko Modler e3063f4858 HHH-14179 fix MultiLineImportExtractorTest on Windows 2020-08-24 20:25:17 +01:00
Gavin King bb5a47086d HHH-14183 LocalTimeJavaDescriptor attempts casting to LocalDate 2020-08-24 19:20:21 +01:00
Jezza 153817f426 HHH-14175 StatefulPersistenceContext#getLoadedCollectionOwnerOrNull could NPE on missing CollectionEntry
Avoids NPE, as the collection entry could not exist.
2020-08-21 11:09:08 +01:00
Gavin King 5ecf45020f expose some private fields via getters for Hibernate Reactive
needed for https://github.com/hibernate/hibernate-reactive/issues/237
2020-08-20 09:30:14 -05:00
Guillaume Smet fe74ad4270 HHH-14160 Use a runtime used class for testing Bean Validation presence 2020-08-20 15:27:08 +01:00
Nathan Xu c778ccb3da HHH-14154 Incorrect SQL generated from Criteria API when concat() and function() methods are used together 2020-08-20 15:36:54 +02:00
Nathan Xu 2ab372027e HHH-14153 reserve end-of-line chars in MultiLineImportExtractor 2020-08-19 12:12:40 +02:00
Christian Beikov e1b821c6fb HHH-14156 - handle all H2 versions properly regarding tuple in subquery syntax 2020-08-18 12:50:48 +02:00
Nathan Xu be64851fee HHH-14156 IN subquery predicate with entity aliases produces wrong SQL "too few columns in subquery" 2020-08-18 12:50:48 +02:00
Nathan Xu 00d9c12f05 HHH-3326 fix temp table collation issue for SQLServer dialect 2020-08-17 15:04:48 +02:00
Sanne Grinovero fe3f27a733 HHH-14149 Improve efficiency of LazyAttributesMetadata#getLazyAttributeNames 2020-08-12 11:28:39 +02:00
Jay Paulsen cd7823a549 HHH-13380 Test for the issue 2020-08-12 10:20:27 +02:00
Sanne Grinovero 1d51898202 HHH-13380 Bytecode enhanced entities might throw LazyInitializationException from custom equals/hashcode implementations
Apparently we trigger the need to invoke equals/hashcode methods on managed entities just before the Session is attached to the BytecodeLazyAttributeInterceptor
2020-08-12 10:20:18 +02:00
Andrea Boriero 509db7cc79 HHH-14126 Add CockroachDB to DefaultDialectSelector and update documentation to mention the new dialect 2020-08-10 15:20:53 +02:00
Oliver Breidenbach e8f310a659 HHH-14109 Use 'in expression count limit' if calculated count is greather than 'in expression count limit' 2020-08-10 13:04:23 +02:00
Andrea Boriero a229590345 HHH-14129 Bidirectional relationship with @NotNull fails to save 2020-08-10 12:08:54 +02:00
Andrea Boriero 358f713700 HHH-14129 Add test for issue 2020-08-10 12:08:54 +02:00
Sanne Grinovero 212ba0fb33 HHH-14143 Detect illegal concurrent usage of LogicalConnectionManagedImpl 2020-08-10 11:57:16 +02:00
Gavin King 5ec07faffd HHH-14142 Make constructor of StatelessSessionImpl public
needed by Hibernate Reactive, see:

https://github.com/hibernate/hibernate-reactive/pull/310
https://hibernate.atlassian.net/browse/HHH-14142
2020-08-09 08:50:22 +02:00
Sanne Grinovero 6da11f4c2a HHH-14137 Some more string check performnance optimisations 2020-08-06 18:22:25 +02:00
Sanne Grinovero 5d4e7d0927 HHH-13974 Test efficiency improvements 2020-08-06 17:17:10 +02:00
Michael Spahn d19bb536ef HHH-13974 FlushMode set through SessionBuilder was never applied 2020-08-06 17:17:10 +02:00
Ihar Sadounikau 0ee25a416d HHH-14137 Empty String check performance improvements 2020-08-06 17:14:33 +02:00
Yoann Rodière 9323d426f1 HHH-14124 Test that the FETCH entitygraph semantic overrides EAGER associations to LAZY for all results 2020-07-30 13:34:41 +01:00
Yoann Rodière 1d965227c4 HHH-14124 Test that the FETCH entitygraph semantic overrides EAGER associations to LAZY 2020-07-30 13:34:41 +01:00
Yoann Rodière 6f6874b8cf HHH-14124 Avoid too many list allocations when hydrating query results
I suspect the original goal of having a single list of hydrated objects
for all rows was to avoid instantiating one list per row, but we did
just that in the fix in the last commit.

This introduces a hack to signal that we're starting to process a new
row while still keeping a flat, single-list structure: we inserting
null elements in the list of hydrated objects.

This is admittedly very ugly, but it's the only solution I can come up
with if we want to keep the number of memory allocations similar to what
we used to have. And hopefully this code will disappear in ORM 6.0.
2020-07-30 13:34:41 +01:00
Yoann Rodière bc26c564a4 HHH-14124 Work around side-effects of TwoPhaseLoad.initializeEntity 2020-07-30 13:34:41 +01:00
Oliver Saggau 20273b81ee HHH-14071 Add test cases for issue 2020-07-27 13:11:56 +01:00
Oliver Saggau f8fe50ad09 HHH-14071 Fix binding for FetchProfile for OneToOne(mappedBy=...) associations 2020-07-27 13:11:39 +01:00
Andrea Boriero e60299c440 HHH-13724 Fix failing tests 2020-07-27 12:49:40 +01:00
Andrea Boriero 0b1072a8a4 HHH-13724 CriteriaLiteralWithSingleQuoteTest#testLiteralProjectionAndGroupBy add @SkipForDialect for CockroachDB Dialect 2020-07-27 12:49:40 +01:00
Rafi Shamim 4655bdbe12 HHH-13724 Add CockroachDB dialects and configs for testing 2020-07-27 12:49:40 +01:00
Andrea Boriero 4df7986108 HHH-13410 - Fix Oracle failing test 2020-07-27 11:05:36 +01:00
Nathan Xu 636ef89fcf HHH-14116 Exception when fetch joining a non-collection when selecting non-query-root 2020-07-26 15:10:26 +02:00
Gail Badner 3e07791683 HHH-14112 : Invalid Pagination COUNT query generated with @Inheritance(strategy = InheritanceType.JOINED) 2020-07-24 08:59:41 +02:00
Gail Badner fb40f8edc0 HHH-14103 : Add test cases showing that an entity's transient attribute can be overridden to be persistent in entity subclasses 2020-07-21 17:32:19 -07:00
Gittenburg ff7aa5328f HHH-14041 - H2Dialect: fix referential integrity constraint constraint name extraction 2020-07-21 20:27:33 +02:00
gajendra.jatav bfef0df089 HHH-13410 Adding test case 2020-07-21 18:31:35 +02:00
gajendra.jatav faf3928043 HHH-13410 Option "order_inserts = true" causes FK Violation when inserting with a Unidirectional Relations between 4 Entities 2020-07-21 18:30:32 +02:00
katiforis f1243a3285 HHH-14093 Make StatefulPersistenceContext#registerInsertedKey and StatefulPersistenceContext#wasInsertedDuringTransaction use HashSet instead of ArrayList 2020-07-21 17:38:54 +02:00
Sanne Grinovero 677a65a8cf HHH-13926 Test for the issue 2020-07-21 14:38:42 +02:00
Sanne Grinovero c8fabbb2b0 HHH-13926 Remove no longer used parameters 2020-07-21 14:38:37 +02:00
Sanne Grinovero 3a2283335e HHH-13926 Propagate the original SQL to the Expectation so it can be logged 2020-07-21 14:38:33 +02:00
Sanne Grinovero 6c787d27bd HHH-13926 Extract JdbcObserver lookup from the batching loop 2020-07-21 14:38:26 +02:00
Gail Badner 06c78087ff HHH-12268 : LazyInitializationException thrown from lazy collection when batch fetching enabled and owning entity refreshed with lock 2020-07-16 10:55:07 -07:00
Gail Badner f5d710b97d HHH-12268 : Added test case 2020-07-16 10:55:07 -07:00
Andrea Boriero 673d3600b8 HHH-14108 PADDED and DYNAMIC Batch loading strategies not compatible with the Enhanced Proxy feature 2020-07-16 16:52:25 +01:00
Andrea Boriero 538689bcd4 HHH-14108 Add test for issue 2020-07-16 16:52:25 +01:00
Andrea Boriero 295eb870a3 HHH-13214 Delete re-firing SQL from previous calls 2020-07-14 21:03:53 +01:00
Andrea Boriero 3fcd4a00a2 HHH-13214 Delete re-firing SQL from previous calls 2020-07-14 15:57:20 +01:00
lining b2ab0b7c71 HHH-13214 Delete re-firing SQL from previous calls 2020-07-14 15:57:20 +01:00
Jens Borrmann 3159c8ff78 HHH-14106 - Return entry from `#parentsByChild` in `StateFulPersistenceContext#getParentsByChild` 2020-07-14 08:34:15 -05:00
Xavier Dury 007f609210 HHH-13931 MissingFormatArgumentException in JpaCompliantLifecycleStrategy.BeanImpl 2020-07-11 10:44:56 +01:00
Nathan Xu 5952c0abc3 HHH-14097 fix bug that redundant SQLs might be issued for 'FETCH' entity graph 2020-07-09 14:08:30 +01:00
Sanne Grinovero 1683bbe900 HHH-14096 Moving the XMLHelper from ORM core into testsuite helpers 2020-07-07 09:37:47 +01:00
Sanne Grinovero 92da3842c8 HHH-14096 Remove unused import for deprecated type XmlDocument and dom4j 2020-07-07 09:37:47 +01:00
yuanhang zheng d1b44560ed HHH-14059 Cannot use full qualified enum name which has two uppercase alphabet prefix 2020-07-06 12:33:41 +01:00
Lefteris Katiforis 4b3171c7e1 HHH-14021 - Add Java Type byte to JDBC Type TINYINT mapping as described in specification in TABLE B-2. 2020-07-06 10:27:51 +01:00
Falko Modler c44150d0d6 HHH-14023 H2Dialect: adjust NUMERIC, DECIMAL & VARBINARY for 1.4.201+ 2020-06-22 11:22:27 +01:00
Falko Modler b44b20ba11 HHH-14023 H2Dialect: SequenceInformationExtractorLegacyImpl for 1.4.201+ 2020-06-22 11:22:27 +01:00
Gail Badner 467203e8c4 HHH-14075 : Changes to loaders and TwoPhaseLoad to allow "internal" loading to be reused by hibernate-reactive 2020-06-22 10:03:34 +01:00
Andrea Boriero 9756b0fba8 HHH-14077 PostgreSQL, skip testLiteralProjectionAndGroupBy (PostgreSQL does not support literals in group by statement) 2020-06-19 17:52:20 +01:00
Andrea Boriero bb9233472b HHH-14081 CompositeIdFkGeneratedValueIdentityTest and CompositeIdFkGeneratedValueTest failures on Oracle db 2020-06-19 14:41:15 +01:00
Gail Badner 3f3c1ab506 HHH-14077 : CVE-2019-14900 SQL injection issue using JPA Criteria API 2020-06-18 12:13:22 -07:00
Gail Badner c1771040c7 HHH-14077 : Added test case 2020-06-18 11:49:09 -07:00
Martin Vietz 180656e9f3 HHH-14064 - Fix documentation for schema-generation 2020-06-09 14:38:55 +01:00
Réda Housni Alaoui 5963dc7fe8 HHH-13980 NullPointerException on AbstractEntityGraphVisitationStrategy.startingCollectionIndex 2020-05-31 07:50:49 -05:00
Gail Badner 6df82bb6a6 HHH-14044 : Extract code from Loader into protected methods 2020-05-29 10:27:37 +01:00
Hannes Rosenögger b9703e33d4 HHH-14022 Revert HHH-13322 Fix Oracle dialect's introduced in 5.4.13 that is causing issues with sequence increment determination 2020-05-29 10:12:34 +01:00
Jason Pyeron 0804de87b4 HHH-10956 reduced runtime complexity, added Component.getProperty(int)
Component.getProperty(String) was looping and comparing, but we already now the position of the property
2020-05-29 08:32:18 +01:00
Andrea Boriero 2db3ce2643 HHH-10956 an exception has to thrown when the composite key is an association and its value is null 2020-05-29 08:32:18 +01:00
Andrea Boriero 114e16f64f HHH-10956 Add additional test 2020-05-29 08:32:18 +01:00
Andrea Boriero cfcd2ac40f HHH-10956 Moved tests using GenerationType#IDENTITY into another class annotated with @RequiresDialectFeature(DialectChecks.SupportsIdentityColumns.class) 2020-05-29 08:32:18 +01:00
Jason Pyeron 42b38b60cf HHH-10956 put one line if in {} 2020-05-29 08:32:18 +01:00
Jason Pyeron e37a8da568 HHH-10956 added more complext tests with self referential FK
* known issue: HHH-13971, test marked as @Ignore
* added some output debugging to help developers review CI/CD logs
* 8 tests, 1 ignored, 0.745s duration
2020-05-29 08:32:18 +01:00
Jason Pyeron e42fe94f65 HHH-10956 fixed failed insertion with IdClass with partial identifier generation
* regression introduced by HHH-4848
* AbstractEntityTuplizer lines 179 and 311 formatting issues, preserved
* bug HHH-9662 blocks testing of Identity insertion
2020-05-29 08:32:18 +01:00
Jason Pyeron da2b24b598 HHH-10956 created test cases IdClass with partial identifier generatiod, all marked @FailureExpected 2020-05-29 08:32:18 +01:00
Andrea Boriero 58fe82e730 Revert "HHH-14022 Oracle-Dialect does not find Sequences outside User-Schema"
This reverts commit ca0ae9bfad.
2020-05-29 07:42:39 +01:00
varun.shrivastava ca0ae9bfad HHH-14022 Oracle-Dialect does not find Sequences outside User-Schema 2020-05-29 07:01:22 +01:00
Sanne Grinovero c013ae12b7 HHH-14047 Expose some methods of EntityManagerFactoryBuilderImpl to extensions 2020-05-28 20:49:25 +01:00
Sanne Grinovero 76e305ba75 HHH-14047 Allow customization of the StandardServiceRegistryBuilder by extending the EntityManagerFactoryBuilderImpl 2020-05-28 20:49:25 +01:00
Sanne Grinovero d7373a86bb HHH-14046 Allow customizing the type of SessionFactory by changing the initial ServiceInitiator list 2020-05-28 20:49:25 +01:00
Andrea Boriero 2baa5fccdc HHH-13959 Add nullability and uniqueness for @OneToOne with @JoinTable 2020-05-28 18:39:16 +01:00
Andrea Boriero 038b3ce487 HHH-13959 Add test for issue 2020-05-28 18:39:16 +01:00
gavinking 1d2d67677f HHH-14049 AbstractEntityPersister make three private methods protected for use in Hibernate Reactive 2020-05-28 18:27:42 +01:00
gavinking b5edf6cabe HHH-14048 Expose lazy property fetching to Hibernate reactive 2020-05-28 18:20:42 +01:00
gavinking 17152bfbba expose a private field to Hibernate Reactive
needed to support Criteria queries
2020-05-26 08:04:40 +01:00
Steve Ebersole 50a5da07c1 HHH-14033 - SQL script parsing problem with multi-line comments
- Better handling of multi-line comments
- Restructured some internal classes to consolidate packages
- Added "system"-style SchemaToolingLogging

This commit:

- removed some temporary logging
- better comments in parsers
2020-05-20 07:13:41 -05:00
Steve Ebersole 7dfb0fdf24 HHH-14033 - SQL script parsing problem with multi-line comments
- Better handling of multi-line comments
- Restructured some internal classes to consolidate packages
- Added "system"-style SchemaToolingLogging

This commit:

- unifies handling of Antlr `-traceParser` across parsers
- adds comment crediting to Terrance Parr for the BLOCK_COMMENT lexer rule in the sql-script grammar
2020-05-20 07:02:20 -05:00
Steve Ebersole b658e903d7 HHH-14033 - SQL script parsing problem with multi-line comments
- Better handling of multi-line comments
- Restructured some internal classes to consolidate packages
- Added "system"-style SchemaToolingLogging
2020-05-19 12:25:34 -05:00
Andrea Boriero 084f713949 HHH-13179 Fix license header 2020-05-18 18:42:31 +01:00
Davide D'Alto e28d77ac33 Revert "HHH-13997 Use functions for the creation of ActionQueue and PersistenceContext"
This reverts commit 00acb1f213.
2020-05-18 15:08:45 +01:00
Davide D'Alto 00acb1f213 HHH-13997 Use functions for the creation of ActionQueue and PersistenceContext 2020-05-18 14:31:53 +01:00
Davide D'Alto 9cd2236fd3 HHH-13997 : Add methods to SessionImpl and StatefulPersistenceContext; make Loader method protected
* Change visibility for Loader#registerNonExists
* Methods for creating PersistenceContext and ActionQueue
* Add StatefulPersistenceContext#initializeNonLazyCollections(Consumer<PersistentCollection> initializeAction)
2020-05-18 14:31:53 +01:00
Sanne Grinovero 2d7022ecec HHH-14029 Generally improve handling of all post-load events 2020-05-18 14:15:34 +01:00
Sanne Grinovero b08ae4cd14 HHH-14029 Improve 2LC post-load event invocations 2020-05-18 14:15:15 +01:00
Lars Karlström 02c3cc9e2e HHH-13179 Fixed code formatting issue 2020-05-18 07:51:57 -05:00
Lars Karlström 4413433ace HHH-13179 Subclass 2nd level caching now works for XML mappings 2020-05-18 07:51:57 -05:00
Davide D'Alto 88a712bab7 HHH-14024 Fix NativeSQLQueryPlanEqualsTest compilation error 2020-05-18 12:53:12 +01:00
gavinking 92b559abda HHH-14024 add QueryPlanCreator functional interface
simplifies customization of HQLQueryPlan instantiation
2020-05-18 06:47:34 -05:00
Davide D'Alto 4a7f9ec0d6 HHH-14026 Change scope to protected for SessionImple#verifyImmutableEntityUpdate 2020-05-18 06:47:34 -05:00
Davide D'Alto 9fd9c0533d HHH-14025 Add method to return the query statements for update queries 2020-05-18 06:47:34 -05:00
Davide D'Alto 42acc81067 HHH-14028 Change scope of various private methods to protected
So that Hibernate Reactive can reuse them.
2020-05-18 06:47:34 -05:00
Davide D'Alto 0633559f9f HHH-14024 Allow the creation of a different QueryPlanCache 2020-05-18 06:47:34 -05:00
Davide D'Alto d914c8aabc HHH-14027 Allow the creation of a different QueryLoader 2020-05-18 06:47:34 -05:00
Davide D'Alto 5968044118 HHH-14024 Allow the creation of a different QueryPlan 2020-05-18 06:47:34 -05:00
Sanne Grinovero e23dad19ca HHH-14019 Adding some comments to the new SPI 2020-05-13 22:29:41 +01:00
gavinking 137c524a14 HHH-14019 Allow customizing the Database target in the Schema Management tool
Add an API allowing Hibernate Reactive to plug in to schema export:
we've decided that HR should not use JDBC for schema export
2020-05-13 22:25:25 +01:00
Sanne Grinovero cb4909a5e1 HHH-14004 Attempt to load from 2LC when initializing an Enhanced Proxy 2020-05-13 21:33:01 +01:00
Sanne Grinovero 947dda618e HHH-14004 Test for Cacheable Enhanced Proxies 2020-05-13 21:33:01 +01:00
Andrea Boriero 0e1713a3a0 HHH-13936 Add additional test 2020-05-12 10:55:39 +01:00
Jonathan Bregler fa4ead1baa HHH-13996: Update documentation for HANA Cloud 2020-05-11 22:39:04 +01:00
Yoann Rodière 1a28fd419e HHH-14006 Test extended bytecode enhancement for mapped superclasses and entity superclasses 2020-05-11 22:15:14 +01:00
Yoann Rodière 5c5b347614 HHH-14006 Take inherited fields into account in extended bytecode enhancement 2020-05-11 22:15:14 +01:00
Sanne Grinovero bc12eee661 Revert "HHH-13950 Update to Bean Validation 3 preview: Hibernate Validator 7.0.0.Alpha1"
This reverts commit b9a24f458c.
2020-05-11 18:00:20 +01:00
Sanne Grinovero 6dd7d09ba0 Revert "HHH-13950 Apply the mass replace script to switch to Jakarta Validation API"
This reverts commit 60abc8aa76.
2020-05-11 18:00:07 +01:00
michiel.hendriks 585ca8e2bf HHH-13936 Call pulseTransactionCoordinator before checking for transaction in flush() 2020-05-11 16:01:43 +01:00
Sanne Grinovero 2c12ca401d HHH-13995 Remove dead code from StandardBasicTypes 2020-04-30 19:20:23 +01:00
Sanne Grinovero 922ec04422 HHH-13994 Bootstrap analysis: avoid initializing unused JtaPlatform classes 2020-04-30 19:20:23 +01:00
Sanne Grinovero 49405effce HHH-13993 Bootstrap analysis: avoid initializing many Dialect classes 2020-04-30 19:20:22 +01:00
Sanne Grinovero 41cd5ab359 HHH-13976 Some javadoc clarifications and code style adjustments 2020-04-30 14:43:33 +01:00
barreiro 4d0bd0f080 HHH-13976 Introduce BEFORE_TRANSACTION_COMPLETION release mode 2020-04-30 14:43:27 +01:00
Andrea Boriero 250160d923 HHH-13986 Fix test failure on MariaDB 2020-04-29 11:12:35 +01:00