Commit Graph

4465 Commits

Author SHA1 Message Date
Guillaume Smet 7067b191b7 HHH-11495 Change the logic to be more efficient
We are optimistic about our chances to find the elements in the cache,
thus avoiding calling computeIfAbsent() if not necessary.

We only store in the cache the elements for which we have a proper
class, thus avoiding filling the cache with random values.
2018-07-03 19:00:13 +02:00
Guillaume Smet e17491a198 HHH-11495 Return a defensive copy of the array 2018-07-03 19:00:13 +02:00
Carlos Aristu 9684afda76 HHH-11495 Reduce criteria overhead by adding an implementors cache 2018-07-03 19:00:12 +02:00
Sanne Grinovero a67c6b9cd4 HHH-12760 Remove no longer needed EqualsHelper and cleanup some equality checks 2018-07-03 10:43:49 +01:00
Sanne Grinovero a3d39bbf96 HHH-12758 Arquillian JVM configuration for integration tests is ignoring system properties 2018-07-02 19:59:45 +01:00
Vlad Mihalcea 6f336b850c HHH-12749 - Avoid setting the isolation level to the same value in C3P0ConnectionProvider 2018-07-02 13:36:23 +03:00
Gail Badner 220f41dc3b HHH-12746 : CacheKeyImplementation objects with different entityOrRoleName and same id/tenantId have the same hashCode 2018-07-02 09:46:11 +02:00
Gail Badner f166b044a6 HHH-12746 : test case 2018-07-02 09:46:11 +02:00
Guillaume Smet 6b0ef0a5c4 HHH-12685 Fix a few warnings 2018-06-29 11:51:54 +02:00
Guillaume Smet 989ff9509f HHH-12685 Move the test where it should have been
Add an additional test for getParameters()
2018-06-29 11:51:54 +02:00
Andrea Boriero 673e4f7d01 HHH-12685 - Add tests 2018-06-29 11:51:54 +02:00
Andrea Boriero d64a9a9000 HHH-12685 - Fix CriteriaQueryTypeQueryAdapter parameters type validation issues 2018-06-29 11:51:54 +02:00
cristhiank d4a46fa93e HHH-12685 Add test case
Signed-off-by: cristhiank <calovi86@gmail.com>
2018-06-29 11:51:54 +02:00
Guillaume Smet 27409b27a3 HHH-12685 Convert the parameters to JPQL ones before calling isBound() 2018-06-29 11:51:54 +02:00
Vlad Mihalcea 07738c4d89 HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup) 2018-06-29 11:09:00 +03:00
Gail Badner 3dcf69c687 HHH-12637 : Improvement to fix for HHH-12592
HHH-12637 : Rename/add new tests; remove sequences from IDs
2018-06-27 11:41:37 -07:00
Sanne Grinovero 06174d8433 HHH-12743 Cleanup some deprecated code from ProviderChecker 2018-06-27 13:42:12 +01:00
Sanne Grinovero 57ba794a62 HHH-12744 Remove no longer necessary jboss-deployment-structure.xml from integration tests 2018-06-27 13:42:12 +01:00
Guillaume Smet 09aa12496f HHH-12741 Add a comment to explain why we add the new keywords here 2018-06-27 13:28:47 +02:00
Yanming Zhou 0a4a609a42 HHH-12741 Register new reserved words added in MySQL 8.0
https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-8-0-A
2018-06-27 13:26:41 +02:00
Vlad Mihalcea b3e0d363bd HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup)
Add test case proving the issue does not replicate for either RESOURCE_LOCAL or JTA transactions
2018-06-27 11:45:02 +03:00
Guillaume Smet 163cab99e2 HHH-12630 Keep the original starting exception and use it as a cause 2018-06-26 18:09:26 +02:00
Sanne Grinovero d0087948ef HHH-12640 Do not fully deprecate the WildFlyStandAloneJtaPlatform so to allow an explicit user choice 2018-06-26 15:44:17 +01:00
Scott Marlow 1a89a167b4 HHH-12640 deprecate WildFlyStandAloneJtaPlatform but still allow apps to reference it until we remove it in the future 2018-06-26 15:33:28 +01:00
Vlad Mihalcea 9fac6747ef HHH-12670 - Allows native SQL queries that take a given resultClass to map the result set to the required type 2018-06-26 15:13:25 +03:00
Florian Lopes 83e4384c3e HHH-12734 Add original exception when selected strategy could not be loaded 2018-06-26 13:28:41 +02:00
Vlad Mihalcea ed34a25769 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issue due to multi-line formatting
2018-06-26 13:49:42 +03:00
Vlad Mihalcea e6ea4828db HHH-12124 - The JPA Metamodel does not allow to retrieve the actual EmbeddableType since all instances are registered by the associated Java type 2018-06-26 13:16:25 +03:00
Vlad Mihalcea 84439af053 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issues
2018-06-26 13:14:16 +03:00
Guillaume Smet afbec8856c HHH-12724 Add javax.activation as a dependency
It is required by JAXB now that JDK 9 does not provide it anymore.
2018-06-26 12:01:06 +02:00
Peter Holvenstot 9728694386 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key 2018-06-26 12:38:09 +03:00
Vlad Mihalcea 9b106cf59c HHH-12688 - Duplicated Error Information Displayed in the Log
Restrict test case to H2 only
2018-06-26 12:37:28 +03:00
Vlad Mihalcea bcb71fcdd6 HHH-12688 - Duplicated Error Information Displayed in the Log 2018-06-26 11:12:29 +03:00
Vlad Mihalcea 62b2af760e HHH-12476 - NativeQuery with EntityGraphs cause a ClassCastException to be thrown 2018-06-26 10:20:28 +03:00
Yoann Rodière e5dc635a52 HHH-12594 Un-ignore BatchFetchBootstrapTest 2018-06-25 15:22:27 +02:00
Yoann Rodière e1bcfc12cf HHH-12594 Do not share AliasResolutionContextImpl between EntityLoadQueryDetails instances
Sharing it results in some tables being aliased twice for the same query
space, but with different aliases, resulting in exceptions.

Ideally we should try to generate the aliases once, and then share the
AliasResolutionContextImpl between EntityLoadQueryDetails instances,
but I'm really not comfortable enough with this code to make that kind
of changes.
2018-06-25 15:22:27 +02:00
Yoann Rodière 80360b1317 HHH-12594 Trim down BatchFetchBootstrapTest to the simplest possible configuration
So that we can investigate without unnecessary complexity getting in the
way.
2018-06-25 14:15:35 +02:00
Andrea Boriero 337646de13 HHH-12723 - Revert the changes applied by HHH-12585 to the DefaultFlushEntityEventListener#invokeInterceptor() method
This reverts commit 9b00aaf9a5.
2018-06-25 10:16:05 +01:00
Vlad Mihalcea a30635f14a HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Make base class abstract
2018-06-22 14:30:48 +03:00
Vlad Mihalcea ffa5eb0e1d HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Add test case proving the issue is caused by the SQL Server JDBC Driver
2018-06-22 14:27:52 +03:00
Vlad Mihalcea 8bbd22967e HHH-12710 - BaseCoreFunctionalTestCase opens an InputStream for mapping files but never closes it 2018-06-20 17:47:47 +03:00
Vlad Mihalcea ebca36a768 HHH-12654 - Throw MappingException if both @Inheritance and @AttributeOverride are used 2018-06-20 17:03:04 +03:00
Vlad Mihalcea d4861fed9f HHH-12700 - Missing property in sample code in documentation of bulk-id strategies 2018-06-18 16:55:36 +03:00
Sanne Grinovero fb473e6a60 Whitespace fixes required by checkstyle 2018-06-18 13:43:01 +01:00
Jan-Willem Gmelig Meyling 2211e61b04 HHH-12671 - Fix persisting generated properties on identity insert 2018-06-18 11:08:22 +03:00
Gail Badner 607e51617e HHH-12687 : ManyToOne associations in embeddable collection elements and composite IDs are always eagerly loaded 2018-06-15 15:12:50 -07:00
Gail Badner 35b908167e HHH-12651 : org.hibernate.Session.*Query(Ljava/lang/String) methods return different types in 5.1 and 5.3 2018-06-14 16:10:24 -07:00
Vlad Mihalcea 30fec4be79 HHH-12662 - JPQL queries fail when using the Java attribute type which has an associated AttributeConverter (only the DB column type works) 2018-06-14 09:29:18 +03:00
Vlad Mihalcea bff9e2e450 Fix test failing on MariaDB 2018-06-14 08:23:11 +03:00
Philippe Marschall 5089a818e2 HHH-12686 Replace EmptyIterator with emptyIterator 2018-06-13 14:20:19 +02:00
Philippe Marschall 4c52764c41 HHH-12604 Replace EqualsHelper.equals with Objects.equals 2018-06-13 14:20:19 +02:00
Jonathan Bregler c1eaf011ad HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery
Fix tests for HANA, Oracle
2018-06-12 19:55:25 +03:00
cristhiank 22973c355a HHH-9403 - AssertionFailure: Fail to process type argument in a generic declaration 2018-06-11 08:04:05 +03:00
Vlad Mihalcea 566a23736d HHH-12561 - bulk_id_strategy does not work with globally_quoted_identifiers 2018-06-08 11:48:51 +03:00
Roland Kurucz b6a16a3678 HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery 2018-06-08 11:26:38 +03:00
Chris Cranford 9ad030aee6 HHH-12668 - Fix JPA 2.2 xsds so they properly validate. 2018-06-07 13:44:06 -04:00
Chris Cranford 736c913f14 HHH-12396 - Fix problem with EnumType resolution on GlassFish platforms. 2018-06-04 13:05:33 -04:00
Guenther Demetz 7a4b38c6b7 HHH-12657 - Fix ClassCastException for cached natural-id entity with subclasses 2018-06-01 13:12:23 -04:00
Vlad Mihalcea b98c02c503 HHH-12609 - Cannot override constaints when using @AttributeOverride annotation
Add test cases to prove the issue does not replicate for @MappedSuperclass
2018-05-31 11:35:32 +03:00
Gail Badner dfecae09c5 HHH-11979 : Invalid SQL when force increment version of inherited entity 2018-05-30 18:22:27 -07:00
Gail Badner cc9b3eb183 HHH-11979 : test case 2018-05-30 18:21:14 -07:00
Guillaume Smet 6a04d7836c HHH-12633 Fix model definition in the test to be PostgreSQL compatible 2018-05-28 12:13:48 +02:00
Guillaume Smet de5bf278f6 HHH-12633 Fix dirty tracking when previous state is unfetched 2018-05-28 11:07:29 +02:00
Scott Marlow 0c52195a7d Revert "HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT"
This reverts commit c886111a79.
2018-05-27 10:10:33 -04:00
Scott Marlow 558cbdd97d HHH-12640 Update to JBossStandAloneJtaPlatform should be backward compatible attempting old names as well 2018-05-27 10:10:00 -04:00
Philippe Marschall 83c6b56fc8 HHH-12606 Container contents are never accessed
https://hibernate.atlassian.net/browse/HHH-12606
2018-05-25 22:21:52 +01:00
Philippe Marschall 3489f75e1d HHH-12605 Boxed variables never null
https://hibernate.atlassian.net/browse/HHH-12605
2018-05-25 22:05:09 +01:00
Gail Badner 01caa5f2b4 HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections. 2018-05-25 17:32:38 +01:00
Gail Badner 6aa8301499 HHH-12592 : Add more tests 2018-05-25 17:32:38 +01:00
Gail Badner e1b08967d9 Revert "HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections."
This reverts commit 4f119105f8.
2018-05-25 17:32:38 +01:00
Gail Badner c3c0cd550f HHH-12592 : add assertions to ensure that the detached and merged collection are not the same, which currently fails 2018-05-25 17:32:38 +01:00
Andrea Boriero 80bf92e32a HHH-12620 fix test dependencies 2018-05-25 11:56:00 -04:00
smarlow b34f615200 HHH-12620 some test dependencies 2018-05-25 11:56:00 -04:00
smarlow c886111a79 HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT 2018-05-25 11:56:00 -04:00
Guillaume Smet 38552103cc HHH-12634 Make EntityPrinter more permissive regarding the parameters passed 2018-05-25 09:47:28 -04:00
Guillaume Smet 9d4d0ae63b HHH-12584 In fact, we can provide a ReflectionOptimizer, just without the fast class instantiator
The fast class instantiator don't make sense for an abstract class or an
interface. I checked the code and we can indeed instantiate a
ReflectionOptimizer without a fast class instantiator.
2018-05-25 09:22:40 -04:00
Guillaume Smet 9a3aa99e83 HHH-12631 Fix invalid tracev calls in DefaultResolveNaturalIdEventListener 2018-05-25 13:13:59 +02:00
nikowitt b96af61566 HHH-12629 Make some methods protected in DefaultLoadListener
And some nice dead code removal.
2018-05-25 11:47:33 +01:00
Guillaume Smet 7c1a737c2a HHH-12627 Fix a debug level message 2018-05-25 10:31:21 +01:00
Gail Badner eee04e2e9a HHH-12599 : Add Javadoc indicating that region names do not include a prefix 2018-05-25 02:16:21 -07:00
Andrea Boriero 83283218dc HHH-12540 - Fix test 2018-05-25 01:04:04 +01:00
Chris Cranford 4f119105f8 HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections. 2018-05-24 19:36:04 -04:00
Chris Cranford e7b338a109 HHH-12592 - Added test case. 2018-05-24 19:36:04 -04:00
Sanne Grinovero d5244de697 HHH-12626 Avoid high CPU contention by not allocating Session UUIDs eagerly 2018-05-24 21:14:59 +01:00
Guillaume Smet dc29e45af3 HHH-12621 Copy the query spaces when initializing a new NativeQueryImpl
This could ultimately lead to ConcurrentModificationException.
2018-05-24 19:42:29 +02:00
Steve Ebersole 9081aaf23b HHH-12622 - ignore markRollbackOnly on inactive transactions 2018-05-24 12:20:50 -05:00
Guillaume Smet 6be4001022 HHH-12579 Rename a variable for consistency with FieldReaderAppender 2018-05-24 17:06:55 +02:00
Guillaume Smet c0652a5359 HHH-12579 Use the field description with type variables resolved to cast the return value of the $$_hibernate_read_<property>() method 2018-05-24 17:06:55 +02:00
Guillaume Smet b4c720871f HHH-12579 Rename variable in preparation of a subsequent commit 2018-05-24 17:06:55 +02:00
Guillaume Smet ea8ec69bac HHH-12584 Do not try to create a reflection optimizer for interfaces and abstract classes
It's already the behavior of the Javassist bytecode provider but the
ByteBuddy one was failing with an exception.
2018-05-24 16:02:17 +02:00
Guillaume Smet 5c6183066e HHH-12618 Use MethodHandle lookup when available 2018-05-24 13:22:22 +02:00
Guillaume Smet 562661e0a2 HHH-12618 Make sure the proxy classes are created in the right package 2018-05-24 13:22:22 +02:00
Guillaume Smet c9f5bc920a HHH-12614 Respect the protection domain when proxying classes 2018-05-24 13:22:22 +02:00
Guillaume Smet 8dfdf8d22b HHH-12615 Make a few AbstractEntityPersister methods protected final
This is useful for OGM. I made them final so that we don't have to
account for child classes overriding them in the future.
2018-05-24 10:41:01 +02:00
Chris Cranford 3b05e92f40 HHH-12581 - Added test case. 2018-05-23 13:57:35 -04:00
Chris Cranford 367cc4c33d HHH-12586 - Fix CI failure with column names on postgres. 2018-05-23 11:32:13 -04:00
Chris Cranford 5919000dc8 HHH-12617 - Fix checkstyle issues with prior commit. 2018-05-23 10:40:14 -04:00
Chris Cranford ae890b4623 HHH-12617 - Improved cache warning on non-root entity configurations. 2018-05-23 09:34:59 -04:00
Sanne Grinovero 97c88a7f11 HHH-12591 Reverting the changes to the logging messages 2018-05-23 12:14:13 +01:00
Chris Cranford 33e9031791 HHH-12586 - Added test case. 2018-05-22 22:38:25 -04:00