Commit Graph

4677 Commits

Author SHA1 Message Date
Martin Simka 2f12913b98 HHH-12824 ASTParserLoadingTest.testComponentNullnessChecks fails with DB2 because it uses legacy-style query parameter 2018-07-18 16:00:41 +02:00
Martin Simka 103de8de84 HHH-12823 CompositeIdTest.testDistinctCountOfEntityWithCompositeId fails on databases that don't support tuple distinct counts because it expects wrong exception
The SQLGrammarException is now wrapped in a PersistenceException, we
should take that into account.
2018-07-18 14:38:45 +02:00
Guillaume Smet dde8744ca3 HHH-12718 Add a comment about the true meaning of interceptorHandledDirtyCheck 2018-07-17 12:10:19 +02:00
Yoann Rodière da2d986efb HHH-12718 Avoid double negations in DefaultFlushEntityEventListener#dirtyCheck 2018-07-17 12:10:19 +02:00
Yoann Rodière e53e0ef790 HHH-12718 Compute dirtiness using whatever method is appropriate after a flush event interception
We used to have a simpler version of the dirtyCheck() method after an
interception, but that's not enough.
2018-07-17 12:10:19 +02:00
Yoann Rodière 47107e3e88 HHH-12718 Test that dirtiness strategies are invoked a second time after a flush interceptor changes the entity state
Bytecode enhancement is harder to test, so I didn't add a test for that,
but since bytecode enhancement dirty checking is called exactly at the
same place, if one works, the other should, too.
2018-07-17 12:10:19 +02:00
Ulrich Bestfleisch a180caecd6 HHH-12718 - Entity changes in @PreUpdate callback are not persisted when lazy loading is active for more than one field 2018-07-17 12:10:19 +02:00
Yoann Rodière af427cb6c5 HHH-12795 Test the flushMode attribute of @NamedQuery and @NamedNativeQuery 2018-07-17 11:07:41 +02:00
Yoann Rodière 36fcadaa6a HHH-12795 Use the exact flush mode specified in @NamedQuery/@NamedNativeQuery when instantiating named queries
... instead of using an approximation in terms of JPA flush mode.
2018-07-17 11:07:41 +02:00
Guillaume Smet e4ae86cce2 HHH-12811 Add @Target annotations to @CreationTimestamp and @UpdateTimestamp 2018-07-17 10:59:39 +02:00
Guillaume Smet 1688c3ff8d HHH-12786 Improve the basic proxy interceptor
Apart from cosmetic changes, we were testing in the equals() method that the
instance == the proxied object which will always be true.

We should use the argument of the equals() method instead to do the
comparison.

And we can do the comparison on the instance, instead of requiring
passing the proxiedObject into the interceptor.
2018-07-16 17:35:15 +02:00
Guillaume Smet 67698b8bdb HHH-12786 Only define the default constructor
We don't need the others, better not create them in the proxy.
2018-07-16 17:35:15 +02:00
Guillaume Smet 0fda6be86e HHH-12786 Allow to call methods when the interceptor is not set yet
Typically, if the constructor calls instrumented methods, the
interceptor is not defined yet and we get a NPE.
2018-07-16 17:35:15 +02:00
Guillaume Smet 297031319d HHH-12786 Properly indent the Bytebuddy DSL
It helps to understand what exactly these calls do.
2018-07-16 17:35:15 +02:00
Guillaume Smet 667b565028 HHH-12804 Don't mock Map in CollectionBinderTest
Apparently, Mockito + ByteBuddy are unable to mock Map on JDK 11.

It might be solved in the future but there's no point in doing it so
let's avoid it.
2018-07-16 15:07:56 +02:00
Guillaume Smet a9e20c18c5 HHH-12801 Adjust the assertion to the new message generated by JDK 11 2018-07-16 15:07:56 +02:00
Guillaume Smet 9d36d1d91f HHH-12800 Use a class loading strategy suitable for the JDK used
The previously chosen strategy used misc.Unsafe which is not possible
anymore with JDK 11.
2018-07-16 15:07:56 +02:00
Gail Badner 7e69797a45 HHH-12802 : Fix test case to recover from exception properly
(cherry picked from commit 9202a5a11d)
2018-07-13 15:53:46 -07:00
Gail Badner 3af8b6235a HHH-12802 : Hibernate does not thrown an exception when more than entity is loaded with the same ID
(cherry picked from commit 926ad5a133)
2018-07-13 14:51:12 -07:00
Gail Badner ff18d904e8 HHH-12802 : test case
(cherry picked from commit 2ef777e3fe)
2018-07-13 14:50:51 -07:00
Vlad Mihalcea 4b51867c44 HHH-12771 - Caused by: java.lang.UnsupportedOperationException: Cache provider [org.hibernate.cache.ehcache.internal.EhcacheRegionFactory@3271ec2a] does not support `transactional` access 2018-07-13 09:43:03 +03:00
Vlad Mihalcea 1192eed560 HHH-12787 - SessionJdbcBatchTest hangs with DB2 2018-07-12 13:41:37 +03:00
Fabio Massimo Ercoli 6d0509bb34 HHH-12793 Upgrade Karaf, pax-exam and reenable the OSGi tests 2018-07-12 12:13:32 +02:00
Vlad Mihalcea 3bba6adac9 HHH-12768 - TimeAndTimestampTest fails with SQL Server and MYSQL 2018-07-12 06:37:20 +03:00
Yoann Rodière fb8e1c1d71 HHH-12695 Restore the getType method in ParameterRegistration
It was removed in 5.3.0.Beta1, but this breaks backward compatibility
with 5.1.
2018-07-11 09:57:25 +02:00
Yoann Rodière 68ad2130e8 HHH-12695 Rename org.hibernate.query.QueryParameter#getType to getHibernateType
Because it conflicts with the Class-returning getType method we want to
re-introduce in ParameterRegistration to restore backward compatibility.
2018-07-11 09:57:25 +02:00
Yoann Rodière c26ac23a7b HHH-12695 Add missing @Overrides in subclasses of javax.persistence.Parameter
Because we are in 2018 and Java 5 is now 14 years old.
2018-07-11 09:57:25 +02:00
Yoann Rodière a0d2f53937 HHH-12695 Explicitly mark contracts as @Incubating, since a comment in QueryParameter implies they are in fact incubating
I did not mark ParameterRegistration as incubating, because it's a
pre-existing interface that we can't reasonably consider as incubating.

It's a bit odd to have a non-incubating contract (ParameterRegistration)
extend an incubating one (ProcedureParameter), though...
2018-07-11 09:57:25 +02:00
Gail Badner 0e1f3d5c94 HHH-12740 : Subselect fetching doesn't work when multiLoad was used
(cherry picked from commit 579ee65fd3)
2018-07-10 18:51:51 -07:00
Robert Rettig b0f2d0fa59 HHH-8805 - [SchemaUpdate] javax.persistence.ForeignKey doesn't respect ConstraintMode.NO_CONSTRAINT 2018-07-10 14:32:37 +03:00
Yoann Rodière 7471aa1589 HHH-7686 Add missing @Overrides in MapProxy 2018-07-09 17:35:01 +02:00
Yoann Rodière 782336faed HHH-7686 Allow lazy loading outside of a transaction after dynamic map proxy deserialization if the proper settings were enabled
In theory, trying to deserialize MapLazyInitializer instances that were
serialized before this patch should still work, although using such
instances (i.e. trying to access any method on the proxy) would still
fail, just like it used to before this patch.
2018-07-09 17:35:01 +02:00
Yoann Rodière bc6c982541 HHH-7686 Test dynamic map proxy serialization 2018-07-09 17:35:01 +02:00
Yoann Rodière f2b4aedc03 HHH-7686 Clarify and test initialization code in the writeReplace() method in proxies
If we copy the behavior of "traditional" (non-map) proxies to the
"dynamic-map" proxies, we'd better know what this behavior is and be
sure it works correctly.
2018-07-09 17:35:01 +02:00
Yoann Rodière e0900b17e2 HHH-12720 Deprecate a useless constructor in AbstractSerializableProxy
A no-arg constructor is only necessary for superclasses of serializable
classes that are not themselves serializable. Here the class is
serializable, so the constructor is useless.
2018-07-09 17:35:01 +02:00
Yoann Rodière 3336489e40 HHH-12720 Allow lazy loading outside of a transaction after proxy deserialization if the proper settings were enabled 2018-07-09 17:35:01 +02:00
Yoann Rodière 500edf4b8a HHH-12720 Test proxy serialization with hibernate.enable_lazy_load_no_trans = true 2018-07-09 17:35:01 +02:00
Guillaume Smet 147476038b HHH-12778 Register the cause when an exception occurs creating a proxy 2018-07-09 15:08:36 +02:00
Guillaume Smet 1d68b1a2d0 Revert "HHH-12670 - Allows native SQL queries that take a given resultClass to map the result set to the required type"
This reverts commit 9fac6747ef.
2018-07-09 13:46:36 +02:00
Gail Badner 9b0c3ba600 HHH-12746 : Remove assertion that hashCodes are not equal from test 2018-07-04 15:55:30 -07:00
Gail Badner b4762fd52c Revert "HHH-12746 : CacheKeyImplementation objects with different entityOrRoleName and same id/tenantId have the same hashCode"
This reverts commit 220f41dc3b.
2018-07-04 15:52:11 -07:00
Gail Badner 8081aaec93 HHH-12729 : Correct Javadoc comments 2018-07-04 15:47:51 -07:00
Gail Badner c143e888d2 HHH-12729 : Binary and behavioral incompatibilities of org.hibernate.Query.getFirstResult(), setFirstResult(), getMaxResults(), setMaxResults() 2018-07-04 15:47:51 -07:00
Vlad Mihalcea 8fff54d6ee HHH-12769 - Rework LockTest#testContendedPessimisticLock so that it can work on Oracle without throwing exceptions 2018-07-04 21:00:11 +03:00
Vlad Mihalcea 6b3e4e6f56 HHH-12767 - Fix tests failing on Oracle 2018-07-04 17:49:42 +03:00
Guillaume Smet 88bfe7e66c HHH-12531 Make the legacy names public so that Infinispan can reuse them 2018-07-04 16:15:41 +02:00
Yoann Rodière 21eac287e9 HHH-12531 Default to using legacy region names when default query caches do not exist in the EhCache and JCache integrations 2018-07-04 10:03:23 +02:00
Yoann Rodière 63cc63b386 HHH-12531 Use short, simple names for the query result and update timestamps caching regions 2018-07-04 10:03:23 +02:00
Yoann Rodière 2649e1372c HHH-12649 Move the created cache warning to org.hibernate.cache.spi.SecondLevelCacheLogger 2018-07-04 09:44:50 +02:00
Guillaume Smet e7145cfe72 HHH-12727 Reduce the accesses to the statement -> result sets map 2018-07-04 09:37:44 +02:00
Guillaume Smet 4c22b52f80 HHH-12699 Resolve once and for all the method mapping in ResultSet proxy 2018-07-04 09:37:44 +02:00
Guillaume Smet 377b3d1fbe HHH-12699 Fix a typo 2018-07-04 09:37:44 +02:00
Yoann Rodière a19fc84320 HHH-12594 Properly share AliasResolutionContextImpl between EntityLoadQueryDetails instances
In particular, avoid contributing the aliases twice for the same
context: this would just trigger exceptions.
2018-07-04 09:22:09 +02:00
Sanne Grinovero 665110452e HHH-12692 Fixing style 2018-07-03 23:41:48 +01:00
Walter White 5f0024feae HHH-12692 SessionImpl#toString - add system identity hashcode
show the instance id in addition to whether the session is open or closed (when trace is not enabled).
2018-07-03 23:38:06 +01:00
Walter White a0633b84fe HHH-12692 SessionImpl#toString - remove overly verbose output
Is toString used, if so, when do we need to see the actionQueue or persistenceContext?
TRACE?
2018-07-03 23:37:50 +01:00
Andrea Boriero a9538ef710 HHH-12247 Verify JPA bootstrap errors are propagated 2018-07-03 19:52:37 +01:00
Sanne Grinovero 2253fad19d HHH-12247 Propagate bootstrapping exceptions rather than logging them at DEBUG level 2018-07-03 19:52:37 +01:00
Martin Simka d79d6267d0 [HHH-12765] don't use SQL Server reserved keyword in test 2018-07-03 19:28:39 +01:00
Yoann Rodière 212d8c01e5 HHH-11495 Update the javadoc of Metamodel#getImplementors to reflect the actual implementation
In particular, the actual implementations may not return all persisted
subtypes if the given type is persisted and "explicit polymorphism" is
enabled. So this really is more about HQL queries than about a class
hierarchy.
2018-07-03 19:00:13 +02:00
Yoann Rodière 600164869b HHH-11495 Add a missing @Override 2018-07-03 19:00:13 +02:00
Guillaume Smet 6c5e71fc40 HHH-11495 Only cache values if the class is mapped somehow 2018-07-03 19:00:13 +02:00
Guillaume Smet 7067b191b7 HHH-11495 Change the logic to be more efficient
We are optimistic about our chances to find the elements in the cache,
thus avoiding calling computeIfAbsent() if not necessary.

We only store in the cache the elements for which we have a proper
class, thus avoiding filling the cache with random values.
2018-07-03 19:00:13 +02:00
Guillaume Smet e17491a198 HHH-11495 Return a defensive copy of the array 2018-07-03 19:00:13 +02:00
Carlos Aristu 9684afda76 HHH-11495 Reduce criteria overhead by adding an implementors cache 2018-07-03 19:00:12 +02:00
Sanne Grinovero a67c6b9cd4 HHH-12760 Remove no longer needed EqualsHelper and cleanup some equality checks 2018-07-03 10:43:49 +01:00
Sanne Grinovero a3d39bbf96 HHH-12758 Arquillian JVM configuration for integration tests is ignoring system properties 2018-07-02 19:59:45 +01:00
Vlad Mihalcea 6f336b850c HHH-12749 - Avoid setting the isolation level to the same value in C3P0ConnectionProvider 2018-07-02 13:36:23 +03:00
Gail Badner 220f41dc3b HHH-12746 : CacheKeyImplementation objects with different entityOrRoleName and same id/tenantId have the same hashCode 2018-07-02 09:46:11 +02:00
Gail Badner f166b044a6 HHH-12746 : test case 2018-07-02 09:46:11 +02:00
Guillaume Smet 6b0ef0a5c4 HHH-12685 Fix a few warnings 2018-06-29 11:51:54 +02:00
Guillaume Smet 989ff9509f HHH-12685 Move the test where it should have been
Add an additional test for getParameters()
2018-06-29 11:51:54 +02:00
Andrea Boriero 673e4f7d01 HHH-12685 - Add tests 2018-06-29 11:51:54 +02:00
Andrea Boriero d64a9a9000 HHH-12685 - Fix CriteriaQueryTypeQueryAdapter parameters type validation issues 2018-06-29 11:51:54 +02:00
cristhiank d4a46fa93e HHH-12685 Add test case
Signed-off-by: cristhiank <calovi86@gmail.com>
2018-06-29 11:51:54 +02:00
Guillaume Smet 27409b27a3 HHH-12685 Convert the parameters to JPQL ones before calling isBound() 2018-06-29 11:51:54 +02:00
Vlad Mihalcea 07738c4d89 HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup) 2018-06-29 11:09:00 +03:00
Gail Badner 3dcf69c687 HHH-12637 : Improvement to fix for HHH-12592
HHH-12637 : Rename/add new tests; remove sequences from IDs
2018-06-27 11:41:37 -07:00
Sanne Grinovero 06174d8433 HHH-12743 Cleanup some deprecated code from ProviderChecker 2018-06-27 13:42:12 +01:00
Sanne Grinovero 57ba794a62 HHH-12744 Remove no longer necessary jboss-deployment-structure.xml from integration tests 2018-06-27 13:42:12 +01:00
Guillaume Smet 09aa12496f HHH-12741 Add a comment to explain why we add the new keywords here 2018-06-27 13:28:47 +02:00
Yanming Zhou 0a4a609a42 HHH-12741 Register new reserved words added in MySQL 8.0
https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-8-0-A
2018-06-27 13:26:41 +02:00
Vlad Mihalcea b3e0d363bd HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup)
Add test case proving the issue does not replicate for either RESOURCE_LOCAL or JTA transactions
2018-06-27 11:45:02 +03:00
Guillaume Smet 163cab99e2 HHH-12630 Keep the original starting exception and use it as a cause 2018-06-26 18:09:26 +02:00
Sanne Grinovero d0087948ef HHH-12640 Do not fully deprecate the WildFlyStandAloneJtaPlatform so to allow an explicit user choice 2018-06-26 15:44:17 +01:00
Scott Marlow 1a89a167b4 HHH-12640 deprecate WildFlyStandAloneJtaPlatform but still allow apps to reference it until we remove it in the future 2018-06-26 15:33:28 +01:00
Vlad Mihalcea 9fac6747ef HHH-12670 - Allows native SQL queries that take a given resultClass to map the result set to the required type 2018-06-26 15:13:25 +03:00
Florian Lopes 83e4384c3e HHH-12734 Add original exception when selected strategy could not be loaded 2018-06-26 13:28:41 +02:00
Vlad Mihalcea ed34a25769 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issue due to multi-line formatting
2018-06-26 13:49:42 +03:00
Vlad Mihalcea e6ea4828db HHH-12124 - The JPA Metamodel does not allow to retrieve the actual EmbeddableType since all instances are registered by the associated Java type 2018-06-26 13:16:25 +03:00
Vlad Mihalcea 84439af053 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issues
2018-06-26 13:14:16 +03:00
Guillaume Smet afbec8856c HHH-12724 Add javax.activation as a dependency
It is required by JAXB now that JDK 9 does not provide it anymore.
2018-06-26 12:01:06 +02:00
Peter Holvenstot 9728694386 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key 2018-06-26 12:38:09 +03:00
Vlad Mihalcea 9b106cf59c HHH-12688 - Duplicated Error Information Displayed in the Log
Restrict test case to H2 only
2018-06-26 12:37:28 +03:00
Vlad Mihalcea bcb71fcdd6 HHH-12688 - Duplicated Error Information Displayed in the Log 2018-06-26 11:12:29 +03:00
Vlad Mihalcea 62b2af760e HHH-12476 - NativeQuery with EntityGraphs cause a ClassCastException to be thrown 2018-06-26 10:20:28 +03:00
Yoann Rodière e5dc635a52 HHH-12594 Un-ignore BatchFetchBootstrapTest 2018-06-25 15:22:27 +02:00
Yoann Rodière e1bcfc12cf HHH-12594 Do not share AliasResolutionContextImpl between EntityLoadQueryDetails instances
Sharing it results in some tables being aliased twice for the same query
space, but with different aliases, resulting in exceptions.

Ideally we should try to generate the aliases once, and then share the
AliasResolutionContextImpl between EntityLoadQueryDetails instances,
but I'm really not comfortable enough with this code to make that kind
of changes.
2018-06-25 15:22:27 +02:00
Yoann Rodière 80360b1317 HHH-12594 Trim down BatchFetchBootstrapTest to the simplest possible configuration
So that we can investigate without unnecessary complexity getting in the
way.
2018-06-25 14:15:35 +02:00
Andrea Boriero 337646de13 HHH-12723 - Revert the changes applied by HHH-12585 to the DefaultFlushEntityEventListener#invokeInterceptor() method
This reverts commit 9b00aaf9a5.
2018-06-25 10:16:05 +01:00
Vlad Mihalcea a30635f14a HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Make base class abstract
2018-06-22 14:30:48 +03:00
Vlad Mihalcea ffa5eb0e1d HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Add test case proving the issue is caused by the SQL Server JDBC Driver
2018-06-22 14:27:52 +03:00
Vlad Mihalcea 8bbd22967e HHH-12710 - BaseCoreFunctionalTestCase opens an InputStream for mapping files but never closes it 2018-06-20 17:47:47 +03:00
Vlad Mihalcea ebca36a768 HHH-12654 - Throw MappingException if both @Inheritance and @AttributeOverride are used 2018-06-20 17:03:04 +03:00
Vlad Mihalcea d4861fed9f HHH-12700 - Missing property in sample code in documentation of bulk-id strategies 2018-06-18 16:55:36 +03:00
Sanne Grinovero fb473e6a60 Whitespace fixes required by checkstyle 2018-06-18 13:43:01 +01:00
Jan-Willem Gmelig Meyling 2211e61b04 HHH-12671 - Fix persisting generated properties on identity insert 2018-06-18 11:08:22 +03:00
Gail Badner 607e51617e HHH-12687 : ManyToOne associations in embeddable collection elements and composite IDs are always eagerly loaded 2018-06-15 15:12:50 -07:00
Gail Badner 35b908167e HHH-12651 : org.hibernate.Session.*Query(Ljava/lang/String) methods return different types in 5.1 and 5.3 2018-06-14 16:10:24 -07:00
Vlad Mihalcea 30fec4be79 HHH-12662 - JPQL queries fail when using the Java attribute type which has an associated AttributeConverter (only the DB column type works) 2018-06-14 09:29:18 +03:00
Vlad Mihalcea bff9e2e450 Fix test failing on MariaDB 2018-06-14 08:23:11 +03:00
Philippe Marschall 5089a818e2 HHH-12686 Replace EmptyIterator with emptyIterator 2018-06-13 14:20:19 +02:00
Philippe Marschall 4c52764c41 HHH-12604 Replace EqualsHelper.equals with Objects.equals 2018-06-13 14:20:19 +02:00
Jonathan Bregler c1eaf011ad HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery
Fix tests for HANA, Oracle
2018-06-12 19:55:25 +03:00
cristhiank 22973c355a HHH-9403 - AssertionFailure: Fail to process type argument in a generic declaration 2018-06-11 08:04:05 +03:00
Vlad Mihalcea 566a23736d HHH-12561 - bulk_id_strategy does not work with globally_quoted_identifiers 2018-06-08 11:48:51 +03:00
Roland Kurucz b6a16a3678 HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery 2018-06-08 11:26:38 +03:00
Chris Cranford 9ad030aee6 HHH-12668 - Fix JPA 2.2 xsds so they properly validate. 2018-06-07 13:44:06 -04:00
Chris Cranford 736c913f14 HHH-12396 - Fix problem with EnumType resolution on GlassFish platforms. 2018-06-04 13:05:33 -04:00
Guenther Demetz 7a4b38c6b7 HHH-12657 - Fix ClassCastException for cached natural-id entity with subclasses 2018-06-01 13:12:23 -04:00
Vlad Mihalcea b98c02c503 HHH-12609 - Cannot override constaints when using @AttributeOverride annotation
Add test cases to prove the issue does not replicate for @MappedSuperclass
2018-05-31 11:35:32 +03:00
Gail Badner dfecae09c5 HHH-11979 : Invalid SQL when force increment version of inherited entity 2018-05-30 18:22:27 -07:00
Gail Badner cc9b3eb183 HHH-11979 : test case 2018-05-30 18:21:14 -07:00
Guillaume Smet 6a04d7836c HHH-12633 Fix model definition in the test to be PostgreSQL compatible 2018-05-28 12:13:48 +02:00
Guillaume Smet de5bf278f6 HHH-12633 Fix dirty tracking when previous state is unfetched 2018-05-28 11:07:29 +02:00
Scott Marlow 0c52195a7d Revert "HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT"
This reverts commit c886111a79.
2018-05-27 10:10:33 -04:00
Scott Marlow 558cbdd97d HHH-12640 Update to JBossStandAloneJtaPlatform should be backward compatible attempting old names as well 2018-05-27 10:10:00 -04:00
Philippe Marschall 83c6b56fc8 HHH-12606 Container contents are never accessed
https://hibernate.atlassian.net/browse/HHH-12606
2018-05-25 22:21:52 +01:00
Philippe Marschall 3489f75e1d HHH-12605 Boxed variables never null
https://hibernate.atlassian.net/browse/HHH-12605
2018-05-25 22:05:09 +01:00
Gail Badner 01caa5f2b4 HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections. 2018-05-25 17:32:38 +01:00
Gail Badner 6aa8301499 HHH-12592 : Add more tests 2018-05-25 17:32:38 +01:00
Gail Badner e1b08967d9 Revert "HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections."
This reverts commit 4f119105f8.
2018-05-25 17:32:38 +01:00
Gail Badner c3c0cd550f HHH-12592 : add assertions to ensure that the detached and merged collection are not the same, which currently fails 2018-05-25 17:32:38 +01:00
Andrea Boriero 80bf92e32a HHH-12620 fix test dependencies 2018-05-25 11:56:00 -04:00
smarlow b34f615200 HHH-12620 some test dependencies 2018-05-25 11:56:00 -04:00
smarlow c886111a79 HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT 2018-05-25 11:56:00 -04:00
Guillaume Smet 38552103cc HHH-12634 Make EntityPrinter more permissive regarding the parameters passed 2018-05-25 09:47:28 -04:00
Guillaume Smet 9d4d0ae63b HHH-12584 In fact, we can provide a ReflectionOptimizer, just without the fast class instantiator
The fast class instantiator don't make sense for an abstract class or an
interface. I checked the code and we can indeed instantiate a
ReflectionOptimizer without a fast class instantiator.
2018-05-25 09:22:40 -04:00
Guillaume Smet 9a3aa99e83 HHH-12631 Fix invalid tracev calls in DefaultResolveNaturalIdEventListener 2018-05-25 13:13:59 +02:00
nikowitt b96af61566 HHH-12629 Make some methods protected in DefaultLoadListener
And some nice dead code removal.
2018-05-25 11:47:33 +01:00
Guillaume Smet 7c1a737c2a HHH-12627 Fix a debug level message 2018-05-25 10:31:21 +01:00
Gail Badner eee04e2e9a HHH-12599 : Add Javadoc indicating that region names do not include a prefix 2018-05-25 02:16:21 -07:00
Andrea Boriero 83283218dc HHH-12540 - Fix test 2018-05-25 01:04:04 +01:00
Chris Cranford 4f119105f8 HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections. 2018-05-24 19:36:04 -04:00
Chris Cranford e7b338a109 HHH-12592 - Added test case. 2018-05-24 19:36:04 -04:00
Sanne Grinovero d5244de697 HHH-12626 Avoid high CPU contention by not allocating Session UUIDs eagerly 2018-05-24 21:14:59 +01:00
Guillaume Smet dc29e45af3 HHH-12621 Copy the query spaces when initializing a new NativeQueryImpl
This could ultimately lead to ConcurrentModificationException.
2018-05-24 19:42:29 +02:00
Steve Ebersole 9081aaf23b HHH-12622 - ignore markRollbackOnly on inactive transactions 2018-05-24 12:20:50 -05:00
Guillaume Smet 6be4001022 HHH-12579 Rename a variable for consistency with FieldReaderAppender 2018-05-24 17:06:55 +02:00
Guillaume Smet c0652a5359 HHH-12579 Use the field description with type variables resolved to cast the return value of the $$_hibernate_read_<property>() method 2018-05-24 17:06:55 +02:00
Guillaume Smet b4c720871f HHH-12579 Rename variable in preparation of a subsequent commit 2018-05-24 17:06:55 +02:00
Guillaume Smet ea8ec69bac HHH-12584 Do not try to create a reflection optimizer for interfaces and abstract classes
It's already the behavior of the Javassist bytecode provider but the
ByteBuddy one was failing with an exception.
2018-05-24 16:02:17 +02:00
Guillaume Smet 5c6183066e HHH-12618 Use MethodHandle lookup when available 2018-05-24 13:22:22 +02:00
Guillaume Smet 562661e0a2 HHH-12618 Make sure the proxy classes are created in the right package 2018-05-24 13:22:22 +02:00
Guillaume Smet c9f5bc920a HHH-12614 Respect the protection domain when proxying classes 2018-05-24 13:22:22 +02:00
Guillaume Smet 8dfdf8d22b HHH-12615 Make a few AbstractEntityPersister methods protected final
This is useful for OGM. I made them final so that we don't have to
account for child classes overriding them in the future.
2018-05-24 10:41:01 +02:00
Chris Cranford 3b05e92f40 HHH-12581 - Added test case. 2018-05-23 13:57:35 -04:00
Chris Cranford 367cc4c33d HHH-12586 - Fix CI failure with column names on postgres. 2018-05-23 11:32:13 -04:00
Chris Cranford 5919000dc8 HHH-12617 - Fix checkstyle issues with prior commit. 2018-05-23 10:40:14 -04:00
Chris Cranford ae890b4623 HHH-12617 - Improved cache warning on non-root entity configurations. 2018-05-23 09:34:59 -04:00
Sanne Grinovero 97c88a7f11 HHH-12591 Reverting the changes to the logging messages 2018-05-23 12:14:13 +01:00
Chris Cranford 33e9031791 HHH-12586 - Added test case. 2018-05-22 22:38:25 -04:00
Philippe Marschall 37467554e7 HHH-12586 Strange date type confusion in JdbcDateTypeDescriptor
https://hibernate.atlassian.net/browse/HHH-12586
2018-05-22 22:38:25 -04:00
Chris Cranford 21bd9a6a9f HHH-12587 - Fix NullPointerException when flushing entity with CacheConcurrencyStrategy.NONE. 2018-05-22 17:45:03 -04:00
Chris Cranford 3aac27d369 HHH-12587 - Added test case. 2018-05-22 17:44:19 -04:00
Chris Cranford a37960a23d HHH-12577 - Remove unnecessary warning for AttributeConverter implementations. 2018-05-22 11:09:48 -04:00
Vlad Mihalcea 5cfb0a508c HHH-12559 - Add support for MySQL 8 SKIP LOCKED and NOWAIT 2018-05-22 12:30:59 +03:00
Sanne Grinovero 2d55060ff6 HHH-12610 Upgrade to Byte Buddy 1.8.11 to improve JDK compatibility 2018-05-21 18:38:24 +01:00
Sanne Grinovero 89305c994e Cleanup duplicate license header 2018-05-21 18:38:24 +01:00
Vlad Mihalcea 4a8951a6b4 HHH-12589 - Add support for registering custom SQL functions when bootstrapping via JPA 2018-05-21 17:49:56 +03:00
Chris Cranford de44e4180d HHH-12569 - Fix ordered inserts constraint violation when using a OneToOne with a JoinColumn. 2018-05-17 15:58:06 -04:00
Chris Cranford 3c3dc88283 HHH-12569 - Added test case. 2018-05-17 15:56:11 -04:00
Vlad Mihalcea ae8930e19f HHH-12594 - Using property "hibernate.default_batch_fetch_size" crashes bootstrapping
Fix test failing in spite of @FailureExpected
2018-05-17 17:41:14 +03:00
Vlad Mihalcea e1cdad36d0 HHH-12594 - Using property "hibernate.default_batch_fetch_size" crashes bootstrapping 2018-05-17 16:05:51 +03:00
Andrea Boriero 99d630bcc2 HHH-12591 - Remove second call to Scope#setSessionFactory(SessionFactoryImplementor) from TypeConfiguration#scope(SessionFactoryImplementor,BootstrapContext) 2018-05-16 22:03:46 +01:00
Andrea Boriero 9b00aaf9a5 HHH-12585 - Improve DefaultFlushEntityEventListener#invokeInterceptor method execution 2018-05-15 20:51:46 +01:00
Andrea Boriero ec75e9a26f HHH-12583 - Deprecate hibernate.proc.param_null_passing setting 2018-05-15 18:16:14 +01:00
Steve Ebersole 4bae1ca810 HHH-12572 - Exclude LockMode.WRITE from loader creation loop 2018-05-14 17:45:35 -05:00
Steve Ebersole 60f4645036 HHH-12558 - Lazy load EntityLoaders to improve memory usage 2018-05-14 16:01:56 -05:00
Guillaume Smet 98cab7aefb HHH-12558 Lazy load entity loaders for the less common lock modes 2018-05-14 16:01:56 -05:00
Steve Ebersole 26bf33abdc HHH-12529 - Some StatisticsImpl methods throw an exception instead of returning null 2018-05-14 13:19:27 -05:00
Steve Ebersole e2ac4eb22f HHH-12565 - checkstyle 2018-05-14 12:25:27 -05:00
Christian Beikov f62cecc62b HHH-12565 Fix that returns the discriminator constant instead of column reference for leaf subtypes 2018-05-14 12:25:27 -05:00
Christian Beikov f972dd4d29 HHH-12565 Test showing TYPE for a TPC hierarchy leaf subtype fails 2018-05-14 12:25:27 -05:00
Andrea Boriero ecd6f503f8 HHH-12540 - Reusing same EntityTransaction with JTA enabled 2018-05-14 12:14:22 -05:00
Andrea Boriero ca86633370 HHH-12540 - Add test for issue 2018-05-14 12:14:22 -05:00
Steve Ebersole 9f4ff8ae90 HHH-8786 - find, refresh, lock should throw LockTimeoutException or PessimisticLockException when lock problems occur
HHH-12570 - MariaDB 10.3 adds support for lock timeouts via WAIT plus NOWAIT
2018-05-14 12:08:06 -05:00
Steve Ebersole 1570c71833 HHH-12472 - WildFly (IronJacamar) - EntityManager#find with roll-back-only leads to exception rather than return null 2018-05-14 07:52:40 -05:00
Steve Ebersole 0695b3ff6e HHH-12519 - Use Forbidden APIs library (Gradle plugin) to check our use of APIs
- initial support; implicit usage of default Locale is a major problem
2018-05-12 20:29:50 -05:00
Steve Ebersole 4208ca0a2f HHH-12463 - Delegate CustomType#equals/hashCode to wrapped UserType 2018-05-12 17:58:40 -05:00
Steve Ebersole 1a4577d1f0 HHH-12560 - Make sure only one Service registration (initiator/provided) exists per role
- additional test - this one needed a minor change.. all tests implicitly use values defined in `hibernate.properties`, which hibernate-core has.  This lead to `#getFallback` being called, which was the intended solution.  The fix for that was simply the next point.
- added the ability to clear the settings contained on StandardServiceRegistryBuilder.  This is used in the test to make sure that no explicit RegionFactory is set.
2018-05-11 15:38:47 -05:00
Steve Ebersole 87c7915a5c HHH-12560 - Make sure only one Service registration (initiator/provided) exists per role
- added test (passed without changes)
- added "graceful shutdown" of services already bound during construction of a registry
2018-05-11 15:00:27 -05:00
Gail Badner 9b98e61e7f HHH-12562 : Remove DefaultSchemaNameResolver#delegate since the value should not be cached 2018-05-10 16:05:56 -07:00
Andrea Boriero c283349f3f HHH-12539 - Fix PostgreSql test failure 2018-05-10 12:08:47 +01:00
Andrea Boriero fdb31045b9 HHH-12539 - NPE in AbstractPropertyMapping.getCommonPersistentClass when creating UnionSubclassEntityPersister for dynamic-map 2018-05-10 10:56:40 +01:00
Andrea Boriero 118e7dc1f2 HHH-12539 - Add test for issue 2018-05-10 10:56:40 +01:00
Guillaume Smet 3834c4d149 HHH-12556 Share data structures between similar LoadPlan based EntityLoaders 2018-05-09 15:30:03 +02:00
Vlad Mihalcea 1c1cd47c08 HHH-12470 - Batching statements fails for delete 2018-05-08 22:03:25 +03:00
David M. Lloyd d3ee9c6ca1 HHH-10435 Create class loaders in a privileged block 2018-05-08 17:19:36 +01:00
Sanne Grinovero 207a8f03af HHH-12554 Make EnhancerImpl more closely match the semantics described in Enhancer javadoc 2018-05-08 17:14:36 +01:00
Sanne Grinovero 2fa5d3ccb8 HHH-12545 ByteBuddy based enhancer not accepting special character in description names 2018-05-08 17:14:36 +01:00
Steve Ebersole 350d330159 HHH-12544 - Add jipijapa hook to plug in specialized caching and transaction services 2018-05-08 10:40:15 -05:00
Rodrigo Turini 14a9c0a56d HHH-12090 - PropertyAccessBuildingException: Could not locate setter for property named XXX for Java 8 default methods 2018-05-07 17:54:53 +03:00
Jonathan Bregler db259df457 HHH-12546: locate function doesn't work on SAP HANA 2018-05-07 17:20:33 +03:00
Jonathan Bregler a01c282288 HHH-12541: Test for SAP HANA calculation views 2018-05-07 16:01:46 +03:00
Jonathan Bregler 8816c5afb2 HHH-12537: Query hint test for SAP HANA
- add org.hibernate.test.queryhint.QueryHintHANATest
2018-05-07 12:44:54 +03:00
Jonathan Bregler f17513f8c5 HHH-12362 - Allow both SQL query hints and comments
- org.hibernate.test.queryhint.QueryHintTest uses
  assertNotNull(String#contains(String)) which always evaluates to true
2018-05-07 11:46:18 +03:00
Jonathan Bregler da14797ba8 HHH-12534: SAP HANA dialects use unqualified dummy table in queries 2018-05-07 09:16:46 +03:00
Jonathan Bregler 2b18e0efa5 HHH-12535: SAP HANA dialect doesn't support circular cascade delete constraints 2018-05-07 08:34:12 +03:00
Vlad Mihalcea 8b190dbbd0 HHH-12470 - Batching statements fails for delete
Add replicating test case
2018-05-03 08:24:02 +03:00
Steve Ebersole 82f2aa0d5d HHH-12474 - Make sure the JPA version is defined by a single property across build files
added HibernateVersion following pattern of JpaVersion
2018-04-30 10:38:34 -05:00
Chris Cranford 7938918518 HHH-12530 - Fix checkstyle concerns. 2018-04-30 09:36:00 -04:00
Chris Cranford f4e83e3a10 HHH-12530 - Fix checkstyle concerns. 2018-04-30 09:34:37 -04:00
Sergey Chernolyas db1d2d177b HHH-12530 add processing of unknown hints 2018-04-30 09:34:37 -04:00
Petteri Pitkänen 15791a84fb HHH-12505 - Add tests 2018-04-30 09:11:30 -04:00
Petteri Pitkänen cb68d60ce3 HHH-12505 - Add possibility to disable metadata scanning 2018-04-30 09:11:30 -04:00
Klauswk 83b2780482 Fix Typo in PersistEvent
Just fixing a typo i found while using Hibernate, feel free to accept or just fix in master.

Cheers.
2018-04-30 08:49:17 -04:00
asutosh936 bb91924a9e HHH-12517 - Updated Javadocs with correct parameter methods 2018-04-28 17:49:46 -05:00
Chris Cranford 1d94549394 HHH-12199 - Ignore static fields when resolving property types via reflection. 2018-04-27 16:08:36 -04:00
Chris Cranford b44001c644 HHH-12199 - Added test case. 2018-04-27 16:07:45 -04:00
Steve Ebersole c6dc398fc5 HHH-8786 - find, refresh, lock should throw LockTimeoutException or PessimisticLockException when lock problems occur 2018-04-27 09:42:09 -05:00
Vlad Mihalcea 43d15578dc HHH-12469 - Add support for IN clause parameter padding to better reuse cached statements 2018-04-27 16:44:22 +03:00
Steve Ebersole 676aebdf51 HHH-8786 - find, refresh, lock should throw LockTimeoutException or PessimisticLockException when lock problems occur 2018-04-27 08:32:47 -05:00
Steve Ebersole 12b79a5938 HHH-12257 - Refreshing an entity clears the lock mode returned from EntityManager.getLockMode 2018-04-26 11:46:43 -07:00
Gail Badner a286232da3 HHH-12257 : Refreshing an entity clears the lock mode 2018-04-26 11:46:43 -07:00
Sanne Grinovero 90b058507e HHH-12521 Take advantage of Java 8 improvements to optimise Statistics 2018-04-26 10:43:20 +01:00
Radim Vansa fb7c1a4598 HHH-12523 - Invoke CacheTransactionSynchronization.transactionCompleting 2018-04-26 11:28:42 +03:00
Gail Badner 9f0c1a751a HHH-12508 : SessionFactoryOptions#isSecondLevelCacheEnabled returns true by default with NoCachingRegionFactory 2018-04-25 11:12:35 -07:00
Gail Badner 66d7196168 HHH-12508 : test cases 2018-04-25 11:12:35 -07:00
Sanne Grinovero 5367a1c8a6 HHH-12515 LocalXsdResolver should attempt local resource loading before attempting it via URL 2018-04-23 14:55:43 +01:00
Sanne Grinovero 2d1bec72c9 HHH-12514 Micro style polishing of XsdDescriptor 2018-04-23 13:59:42 +01:00
Sanne Grinovero 1c14f1a1db HHH-12514 Avoid repeated creations of costly Xsd definitions and definition lookups 2018-04-23 11:55:33 +01:00
Gail Badner 01ba7d9565 HHH-11766 : Accessing lazy basic property on entity loaded from 2nd level cache throws exception 2018-04-20 15:24:06 -07:00
Gail Badner 1c151f956d HHH-11766 : test case
HHH-11766 : Renamed and updated test to be more comprehensive; added another test with a lazy basic value
2018-04-20 15:24:06 -07:00
Sanne Grinovero 0546eaac3b HHH-12511 Make ASTPrinter threadsafe and have code reuse their instances 2018-04-20 12:07:54 +01:00
Sanne Grinovero 782f023a5a HHH-12509 Reduce memory usage of PreparedStatementSpyConnectionProvider 2018-04-20 11:16:53 +01:00
Gail Badner c7ea49a0b3 HHH-12507 : InsertOrderingWithCompositeTypeAssociation test fails on Oracle due to reserved word 2018-04-19 14:14:41 -07:00
Steve Ebersole 385cf9a23c HHH-12504 - SessionBuilder / SharedSessionBuilder (binary compatibility) 2018-04-19 12:32:27 -05:00
Andrea Boriero 291d4a3eea HHH-12487 - Calling getTransaction() on a closed EntityManager 2018-04-19 15:46:50 +01:00
Andrea Boriero 19f78bbd3d HHH-12487 - Add test for issue 2018-04-18 18:38:46 +01:00
Sanne Grinovero 432d3a29fa HHH-12384 Introduce new hibernate.bytecode.enforce_legacy_proxy_classnames configuration property 2018-04-18 13:05:34 +01:00
Sanne Grinovero 1f7457133c HHH-12501 Fallback implementation for BytecodeProvider should match the default 2018-04-18 13:05:34 +01:00
Steve Ebersole d3218581e8 HHH-12495 - Cache statistics (binary compatibility) 2018-04-17 18:59:00 -05:00
Steve Ebersole a63c4fe1d2 HHH-12495 - Cache statistics (binary compatibility) 2018-04-17 18:57:12 -05:00
Steve Ebersole e508d6bee8 HHH-12499 - SQLQuery (binary compatibility) 2018-04-17 18:44:35 -05:00
Steve Ebersole d9cdd58068 ProcedureCallMemento (binary compatibility) 2018-04-17 14:56:58 -05:00
Steve Ebersole 57543a447e HHH-12494 - BasicQueryContract (binary compatability) 2018-04-17 14:10:53 -05:00
Chris Cranford 231dd064a4 HHH-12448 - Fix potential memory leak with Envers and JTA when after-completion callbacks did not fire. 2018-04-17 14:02:41 -04:00
Sanne Grinovero 83cd43d26b HHH-12493 Missing final keyword in Bytebuddy EnhancerImpl 2018-04-17 18:24:16 +01:00
Steve Ebersole f89e82a020 HHH-8944 - ColumnTransformer handling is too aggressive in qualifying "column names"
Limited to H2 because getting a good expression to use for `Staff#kooky` that works on all databases is challenging and really what happens on the "database side" here is not relevant - the issue being tested is how Hibernate applies the table aliases to column references in the expression.
2018-04-17 06:43:45 -05:00