Commit Graph

4786 Commits

Author SHA1 Message Date
Guillaume Smet b1ffde0e94 HHH-13172 Log a warning instead of throwing an exception when
@AttributeOverride is used in conjunction with entity inheritance

(cherry picked from commit 2dd008adb7)
2019-02-07 13:59:34 -08:00
Andrea Boriero 14f5473fef HHH-13076 - Hibernate 'Transaction already active' behaviour with JTA transaction manager
(cherry picked from commit a15dfe0e05)
2019-02-07 13:55:16 -08:00
Andrea Boriero e88e45cf38 HHH-13076 - Add test for issue
(cherry picked from commit 0fa4b50188)
2019-02-07 13:55:16 -08:00
Gail Badner 438733d32c HHH-13129 : Cascaded merge fails for detached bytecode-enhanced entity with uninitialized ToOne
(cherry picked from commit a66ca0463e)
2019-02-07 13:53:10 -08:00
Bolek Ziobrowski fb3b710d99 HHH-13129 - Add test
HHH-13129 : Move and reformat test

HHH-13129 : Add more tests
(cherry picked from commit c62f0a75cd)
2019-02-07 13:53:10 -08:00
Keshavan Santhanam 56f67fb0cd HHH-10891 Support @Any in @Embedded
(cherry picked from commit 64179673a3)
2019-02-07 13:50:38 -08:00
Guillaume Smet e20d66ad49 HHH-10891 Add a test case
(cherry picked from commit ac03494e70)
2019-02-07 13:50:38 -08:00
Andrea Boriero fdab459b82 HHH-13050 - On release of batch it still contained JDBC statements logged
(cherry picked from commit 11e71f6977)
2019-02-07 13:47:47 -08:00
Gail Badner 1642853c89 HHH-13050 : Add test with a batch that fails when addToBatch() is called
(cherry picked from commit a7fccaa377)
2019-02-07 13:47:47 -08:00
Andrea Boriero 6a91c6b0c5 HHH-13050 - Add test for issue
(cherry picked from commit be0ee006ab)
2019-02-07 13:47:47 -08:00
Gail Badner 36877bfd69 HHH-11209 : Log a DEBUG message if collection with queued operations is detached due to rollback; otherwise, log INFO message
(cherry picked from commit e12a688524)
2019-02-07 13:45:18 -08:00
Gail Badner 8c5b1b7740 HHH-11209 : Fix checkstyle error
(cherry picked from commit 741c84a10c)
2019-02-07 13:45:18 -08:00
Gail Badner cf18916444 HHH-11209 : Log a DEBUG message if collection with queued operations is detached due to rollback
(cherry picked from commit 7af7182cc1)
2019-02-07 13:45:18 -08:00
Gail Badner ed55fff92b HHH-11209 : Added test case for testing debug logging when collection is detached during rollback
(cherry picked from commit 22ad668b88)
2019-02-07 13:45:18 -08:00
Gail Badner aea7b31996 HHH-11209 : Test cases
HHH-11209 : NullPointerException in EntityType.replace() with a PersistentBag

HHH-11209 : Add test for merging a detached collection with queued operations

HHH-11209 : Throw UnsupportedOperationException if a detached collection with queued operations is merged

HHH-11209 : Ignore queued operations when merging a detached collection with queued operations; add warnings

HHH-11209 : Fix typo in comment
(cherry picked from commit 6f5b1e5543)
2019-02-07 13:45:18 -08:00
Guillaume Smet 4a564ab45a HHH-13059 Partially revert HHH-12594
The first commit was on the safe side, we decided to go the extra mile
and that was a mistake as we missed all the consequences.

The new issue is about having a shared ReaderCollector: we add the info
there for each batch which leads to collecting the elements several
times.

This reverts commit a19fc84320.

HHH-13059 : Correct Javadoc
(cherry picked from commit e6286e04f4)
2019-01-22 16:39:45 +01:00
Guillaume Smet 7047119061 HHH-13059 Add test
(cherry picked from commit 502fd78c45)
2019-01-22 16:38:48 +01:00
Gail Badner 4137181bb6 HHH-13084 HHH-13114 : Correct test case using reserved word
(cherry picked from commit fa5b632f4e)
2018-12-18 15:16:59 -08:00
Gail Badner b198a42db1 HHH-13084 HHH-13114 : Add test cases
HHH-13084 HHH-13114 : Refactor test cases

HHH-13084 HHH-13114 : Add test cases

HHH-13084 HHH-13114 : Refactor test cases

HHH-13084 HHH-13114 : Add failing test case

(cherry picked from commit 346b3c7f3e)

HHH-13084 HHH-13114 : Bugs querying entity with non-ID property named 'id'

HHH-13084 HHH-13114 : Query 'select count(h) from Human h' fails if a subclass has a non-Id property named 'id'

HHH-13084 HHH-13114 : Update hibernate-core/src/main/java/org/hibernate/hql/internal/ast/tree/FromElement.java

Co-Authored-By: dreab8 <dreborier@gmail.com>

HHH-13084 HHH-13114 - Fix FromElementType method name

HHH-13084 HHH-13114 : Correct generated column names

(cherry picked from commit 7316307d0e)
2018-12-18 09:23:06 -08:00
Guillaume Smet 91ede032c9 HHH-12555 Fix merging of lazy loaded blobs/clobs/nclobs
It's better to avoid pushing UNFETCHED_PROPERTY to the types as it
requires all the types to take it into account.

TypeHelper looks like the only sensible caller that needs change.

(cherry picked from commit 1af878166f)

HHH-12555 Add tests

(cherry picked from commit 4e05953240)

HHH-12555 : Update test to check results

(cherry picked from commit ca6dc226eb)

HHH-12555 : Remove code in LobMergeStrategy implementations that copied original Lob when target is null

(cherry picked from commit 4d0b5dc184)

HHH-12555 Add a DialectCheck for NClob support

(cherry picked from commit 855f34c771)

HHH-12555 Disable NClob test for dialects not supporting NClob

(cherry picked from commit 98249af058)
2018-12-18 09:20:27 -08:00
Andrea Boriero 6f636a8c0b Add 'Use {@link #getTransactionStartTimestamp()}' to SharedSessionContractImplementor#getTimestamp deprecated comment 2018-11-05 16:20:32 +00:00
Guillaume Smet 023db8de0e HHH-12935 Make ExportIdentifierTests extend BaseUnitTestCase 2018-10-16 23:58:10 +02:00
Gail Badner 6257846943 HHH-13011 Fix the tests: use int column in where clause 2018-10-16 23:58:10 +02:00
Guillaume Smet 8f13d226a4 HHH-12935 Require sequence support in ExportIdentifierTests 2018-10-16 23:58:10 +02:00
Guillaume Smet 91d94c7e69 HHH-13011 Fix the tests: use a boolean query 2018-10-16 23:58:10 +02:00
Guillaume Smet b964aae339 HHH-13011 Fix the tests: use a boolean query 2018-10-16 23:58:10 +02:00
Gail Badner 55e430dd43 HHH-13011 : test cases 2018-10-16 15:13:10 +02:00
Gail Badner b5d3826604 HHH-13011 : Add option enabling/disabling use of an entity's mapped where-clause when loading collections of that entity 2018-10-16 15:13:10 +02:00
Gail Badner 98ae615bbe HHH-12104 : Test cases using annotations and hbm.xml 2018-10-16 15:13:10 +02:00
Guillaume Smet d5d1f0781a HHH-12937 Only run the tests with H2Dialect 2018-10-16 14:23:17 +02:00
Gail Badner 5ba82d6691 HHH-12935 : Constraint and AuxiliaryDatabaseObject export identifiers are not qualified by schema or catalog
(cherry picked from commit ba80f0b3dc)
2018-10-16 04:01:30 -07:00
Gail Badner 320772e5ee HHH-12935 : test cases
(cherry picked from commit e3726bc4db)
2018-10-16 04:01:09 -07:00
Gail Badner 8da2daa4f1 HHH-12937 : Remove duplicated line
(cherry picked from commit ae2da95f55)
2018-10-15 23:36:58 -07:00
Gail Badner faabcafa81 HHH-12937 : Where clause for collections of basic, embeddable and "any" elements is ignored when mapped using hbm.xml
(cherry picked from commit eb14b8de6f)
2018-10-15 23:36:44 -07:00
Gail Badner 7c4d18404c HHH-12937 : test cases
(cherry picked from commit da50076afc)
2018-10-15 23:36:34 -07:00
Gail Badner 83a9adbdb8 HHH-13027 : org.hibernate.ejb.HibernatePersistence can no longer be used as a persistence provider name 2018-10-12 23:43:47 +01:00
Gail Badner 15924cb466 HHH-13027 : test case 2018-10-12 12:40:28 -07:00
Guillaume Smet 5f92f028c4 HHH-12784 Fix a regression in Javassist support 2018-09-13 11:21:14 +02:00
Jonathan Bregler 00ec2e4fde HHH-12961 Update HANA dialects Javadoc
- Fix the links
- Add some more information
2018-09-07 16:24:52 +02:00
Guillaume Smet e8fcbe29c3 HHH-12920 Fix a debug message causing an exception at debug level 2018-09-03 15:48:36 +02:00
Guillaume Smet b04de4c9f7 HHH-12932 Execute ByteBuddy code requiring privileges inside a privileged block 2018-08-28 00:43:46 +02:00
Guillaume Smet 56a29af496 HHH-12931 Revert "HHH-12542 - Add necessary privileged action blocks for SecurityManager used on WildFly."
This reverts commit d24685de67.
2018-08-27 17:38:07 +02:00
Dmitry Matveev b8b0fbc13c Fix a typo in a variable name 2018-08-15 18:32:50 +02:00
Guillaume Smet 5ed5656c29 Fix the previous commit to reference #getMaxResults() 2018-08-14 17:01:53 +02:00
Sande Gilda 70381b8c84 Fix Javadocs comments for Query.getHibernateMaxResults() method 2018-08-14 16:58:32 +02:00
Guillaume Smet 5b826c9062 HHH-12905 Improve the error message and update the tests accordingly
Also fix a loose end in the MySQL test: at least with MariaDB, using
a bit(1) as datatype for boolean does not work: it always return true
even if you set it to 0. Using either boolean or tinyint(1) solves
the issue.

As I'm not sure older versions of MySQL supports a real boolean type I
used a tinyint(1).
2018-08-14 13:17:24 +02:00
Guillaume Smet fdfef4f5ce HHH-12905 Fix error message tested in MySQL and PostgreSQL tests 2018-08-14 13:17:24 +02:00
Gail Badner 99b93ae949 HHH-12875 HHH-12882 : Drop tables in proper order in test setup methods
(cherry picked from commit 770ae50e8b)
2018-08-13 23:28:27 -07:00
Gail Badner 9c96641d00 HHH-12875 : Remove "where" clause for Top used by MultiTableTest;
After HHH-12875 is fixed, the "where" clause causes
            MultiTableTest to fail due to HHH-12016

(cherry picked from commit a5fa213658)
2018-08-13 22:00:21 -07:00
Gail Badner 69e7132e91 HHH-12875 : Add comments to clarify how Collection#setWhere and #setManyToManyWhere are used
(cherry picked from commit a3cecf3411)
2018-08-13 22:00:11 -07:00
Gail Badner f381490a49 HHH-12875 HHH-12882 : Class level where="..." clause hbm.xml mappings is not enforced on collections of that class; add parentheses when where clauses get combined in a conjunction (hbm and annotations)
HHH-12882 : correct assertions in ParentChildTest
(cherry picked from commit 27937e5627)
2018-08-13 21:59:59 -07:00
Gail Badner 70a39d91cb HHH-12875 HHH-12882 : test cases
(cherry picked from commit cdf5e45514)
2018-08-13 21:59:48 -07:00
Gail Badner 22c9b2ba0a HHH-12875 : Class level where="..." clause in hbm.xml mappings is not enforced on collections of that class
(cherry picked from commit 10826d8f3a)
2018-08-13 21:59:39 -07:00
Gail Badner 01243a9b0e HHH-12875 : test cases
(cherry picked from commit eef8974877)
2018-08-13 21:59:28 -07:00
Roland Kurucz f062abe72a HHH-12905 - Bind value [null] was not of specified type in StoredProcedureQuery 2018-08-13 18:04:58 +02:00
Guillaume Smet 7eb0cee178 HHH-12907 Avoid creating too many ByteBuddy objects
This commit should reduce the garbage collection pressure as reported at
https://github.com/raphw/byte-buddy/issues/515.
2018-08-13 16:27:02 +02:00
Vlad Mihalcea b65121c557 HHH-12361 - In the User Guide, omit constructors and equals/hashCode for brevity 2018-08-13 15:15:49 +02:00
Guillaume Smet 61bdbabf18 HHH-12906 Add tests 2018-08-13 12:05:10 +02:00
Florian Beaufumé cbd141996a HHH-12906 Used the correct attribute in getAllCollectionRoles() 2018-08-13 12:05:10 +02:00
Guillaume Smet ad4978c36a HHH-10782 Add a comment about what clearing the query plan cache means 2018-08-09 15:53:29 +02:00
Chris Cranford 0b17fc3225 HHH-12871 - Fix test that uses dynamic-map entities which failed.
(cherry picked from commit 8bd79b29cf)
2018-08-07 10:53:36 -04:00
Chris Cranford dc49ef6ef4 HHH-12871 - Fix metamodel to properly exclude dynamic-map based types when using ignoreUnsupported.
(cherry picked from commit b9e0449602)
2018-08-07 10:53:28 -04:00
Chris Cranford 9f3b1cfb5b HHH-12871 - Added test cases.
(cherry picked from commit 6a594712db)
2018-08-07 10:53:21 -04:00
Guillaume Smet a6c7733179 HHH-12196 Implement a naive limit handler for Sybase
It doesn't manage all the corner cases but it should be safe enough as
only triggered in the simple cases.
2018-08-03 17:24:04 +02:00
Guillaume Smet beb623093a HHH-12880 LockModeTest hangs indefinitely with Sybase due to HHH-12847 2018-08-02 14:32:46 +02:00
Guillaume Smet 236033bdaf HHH-12847 Consider LockOptions for getting the LockMode
Otherwise, it leads to null pointer exceptions.
2018-08-02 00:12:11 +02:00
Guillaume Smet 5150fd5d60 HHH-12857 Reuse the TypePool created in EnhancerImpl 2018-08-02 00:10:17 +02:00
Guillaume Smet fdf19f17b4 HHH-12857 Rewrite getDeclaredMethod() calls in static initializers
We rewrite them to run them as privileged blocks.
2018-08-02 00:10:17 +02:00
Guillaume Smet 129530e464 HHH-12857 Avoid using a static ByteBuddy object
In the end, it does not change anything as the BytecodeProvider is still
static but it helps as a general cleanup for the following commits.
2018-08-02 00:10:17 +02:00
Guillaume Smet c9de4b8ce7 HHH-12835 In the end, remove the assertion
It's not really compatible with batch loading, padding and a couple of
other corner cases.

And I don't think it has a lot of value by itself.
2018-08-01 16:16:19 +02:00
Andrea Boriero 7d9ebd262d HHH-12849 - QuotedIdentifierTest fails with ORA-04043 on Oracle12c 2018-08-01 13:42:25 +02:00
Guillaume Smet 0d224e45d6 HHH-12835 Fix an incorrect assertion in BatchFetchQueueHelper 2018-08-01 11:44:53 +02:00
Guillaume Smet 98f46d64e7 HHH-12848 Restore the original Oracle LimitHandler
Oracle does not support using the SQL 2008 standard limit handler with
FOR UPDATE clauses. Thus we need to get back to the old limit handler.
2018-08-01 11:44:53 +02:00
Guillaume Smet 92f194f291 HHH-10603 Avoid doing distinct and comparisons on byte arrays
They are stored as blobs starting with Oracle12cDialect and distinct and
comparisons on blobs are not supported.

Some tests were adapted, some are now skipped with Oracle12cDialect.
2018-08-01 11:44:49 +02:00
Guillaume Smet 6b679c8860 HHH-12730 Remove the deprecated methods previouly added
We don't need them as everything is now dealt with the transformer.
2018-08-01 11:15:39 +02:00
Guillaume Smet 338b97e7b5 HHH-12730 Add missing @Overrides 2018-08-01 11:15:39 +02:00
Guillaume Smet a4dd9a96d9 HHH-12730 Add deprecated constructors taking a SessionImplementor 2018-08-01 11:15:39 +02:00
Gail Badner dfa2bc0685 HHH-12730 : User types built using 5.1 are not binary compatible with 5.3 2018-08-01 11:15:39 +02:00
Guillaume Smet e43c374f30 HHH-12868 Fix NPE when loading entity with CacheConcurrencyStrategy.NONE 2018-07-31 14:53:01 +02:00
Andrea Boriero 9ab285eb58 HHH-12861 SchemaUpdate doesn't work with Sybase 2018-07-31 10:45:48 +01:00
Yoann Rodière b8b7a0f19b HHH-12492 Qualify references to columns from the target table in subqueries in DELETE/UPDATE queries
Don't try to duplicate the logic from
org.hibernate.hql.internal.ast.tree.FromElementType#toColumns(java.lang.String, java.lang.String, boolean, boolean)
in other classes, it's complex enough and already seems to handle all
the cases we might encounter.

In this specific case, we want the table name to be used to qualify
column names, because the target table doesn't have any alias (it's not
supported by every version of every RDBMS), and not qualifying columns
at all may lead to a confusing statement, in particular if tables
referenced in the subquery contain columns with the same name.
Since we use aliases for every other table in the query, referencing the
table should not lead to any conflict.
2018-07-27 15:03:13 +02:00
Yoann Rodière 6cf91c832c HHH-12492 Test HQL Delete query with a subquery referencing the parent query's aliases 2018-07-27 15:03:07 +02:00
Martin Simka 77661b2275 HHH-12863 SchemaUpdateTest should be skipped with Sybase 2018-07-27 14:56:35 +02:00
Martin Simka 3e8b35a370 HHH-12851 ConverterTest fails with SQL Server depending on collation 2018-07-23 18:09:54 +02:00
Chris Cranford 27449d2dc2 HHH-12846 - Merge cascade of collection fails when orphan removal enabled with flush mode commit.
(cherry picked from commit 333c190c82)
2018-07-23 11:08:43 -04:00
Martin Simka 95c11255f8 HHH-12844 Fix HbmWithIdentityTest with Oracle 2018-07-20 14:47:43 +02:00
Martin Simka 88a015368b HHH-12843 Fix CreateDeleteTest and FlushIdGenTest with Oracle 2018-07-20 13:22:56 +02:00
Martin Simka 0caee98355 HHH-12839 Fix EntityProxySerializationTest with Oracle 2018-07-20 11:30:11 +02:00
Guillaume Smet d02ad78eb7 HHH-7404 HHH-6776 Add tests to prevent regressions
The issues have apparently already been fixed but let's add the tests
present in the issue to prevent regressions.
2018-07-20 11:30:11 +02:00
Guillaume Smet 0091169f9d HHH-12666 Only run the tests with H2
We don't need to run them with all our dialects: we just need to check
the mechanism works correctly.

At least TransactionExceptionHandlingTest fails with MariaDB so better
be safe.
2018-07-20 11:30:11 +02:00
Guillaume Smet 0075225ab7 HHH-12832 Make SchemaUpdateHaltOnErrorTest use the CustomRunner
Otherwise @SkipForDialect doesn't work.
2018-07-20 10:38:19 +02:00
Martin Simka ad08bdf513 HHH-12838 Fix AndNationalizedTests with DB2
This is consecutive to the changes made in HHH-12753.
2018-07-20 10:27:51 +02:00
Gail Badner 5fd8b36e34 HHH-12666 : Add test 2018-07-20 10:27:05 +02:00
Gail Badner 0bbacccf8d HHH-12666 : Add documentation 2018-07-20 10:27:05 +02:00
Gail Badner a76dde0ec6 HHH-12666 : Added more tests 2018-07-20 10:27:05 +02:00
Yoann Rodière 566a93d6c7 HHH-12666 Test the current behavior of exception conversion on persist/save/merge/flush/etc.
Original tests by Gail Badner:
09aa6fbce2
2018-07-20 10:27:05 +02:00
Gail Badner e5da120f13 HHH-12666 : Add an option for restoring 5.1 native exception handling 2018-07-20 10:27:05 +02:00
Martin Simka ed03dfb958 HHH-12833 Fix UniqueConstraintDropTest with DB2 2018-07-19 16:06:15 +02:00
Chris Cranford 9ca732cf29 HHH-12753 - Remove an override that was not relevant to this jira.
(cherry picked from commit ad5f96c613)
2018-07-19 10:01:52 -04:00
Chris Cranford 86abe7fd4f HHH-12753 - Fix Nationalized CLOB test failures on DB2.
Force column read/write to use non-nationalized driver methods since the driver does
not implement the nationalized equivalents.

(cherry picked from commit 005d5b7c74)
2018-07-19 09:54:46 -04:00
nikowitt 722ba32f9f HHH-12830 Improve error message when a method is called in a non active
transaction
2018-07-19 15:36:59 +02:00
Guillaume Smet 255a096ee8 HHH-12832 Skip SchemaUpdateHaltOnErrorTest and al. with DB2
DB2 has no issue with reserved keywords in the CREATE TABLE clause so
let's skip these tests.

There is very little value to test them for every dialect anyway.
2018-07-19 15:18:42 +02:00
Guillaume Smet d6f8d2e7a0 HHH-12822 Skip "case when" tests requiring casts for DB2 2018-07-19 15:18:42 +02:00
Guillaume Smet 3747352ec5 HHH-12827 Define a numeric type as decimal for DB2
DB2 converts the numeric type to decimal and returns Types.DECIMAL for a
numeric. We change the type name used so that we have a match when
comparing the type names as last resort.
2018-07-19 15:18:42 +02:00
Guillaume Smet 7174b03a25 HHH-12815 Remove the zeroDateTimeBehavior option
It's useless for this test and it causes compatibility issues.
2018-07-19 15:18:42 +02:00
Guillaume Smet 1945180569 HHH-12791 Cache the Component type to avoid generating one proxy per call
While Javassist only generates one proxy as the name is stable,
ByteBuddy uses random names and thus generates a new proxy for every
call, leading to the generation of 18 different proxies for the other
test of the test class.

We can't do better than using a volatile/synchronized pattern as the
Component is not fully initialized in the constructor.

Maybe we could take the risk of admitting that the getType() method is
called at least once before we pass the element to a multi-threaded
environment but that's a bet I don't want to take alone.
2018-07-19 10:02:03 +02:00
Chris Cranford 4fc2ce7ab7 HHH-12826 - Persist cascade of collection fails when orphan removal enabled with flush mode commit.
(cherry picked from commit 3fe7d6e13e)
2018-07-18 18:10:58 -04:00
Chris Cranford d24685de67 HHH-12542 - Add necessary privileged action blocks for SecurityManager used on WildFly. 2018-07-18 17:50:27 +02:00
Martin Simka d23fc129cc HHH-12825 CriteriaHQLAlignmentTest.testCountReturnValues fails on databases that don't support tuple distinct counts because it expects wrong exception 2018-07-18 16:03:24 +02:00
Martin Simka 2f12913b98 HHH-12824 ASTParserLoadingTest.testComponentNullnessChecks fails with DB2 because it uses legacy-style query parameter 2018-07-18 16:00:41 +02:00
Martin Simka 103de8de84 HHH-12823 CompositeIdTest.testDistinctCountOfEntityWithCompositeId fails on databases that don't support tuple distinct counts because it expects wrong exception
The SQLGrammarException is now wrapped in a PersistenceException, we
should take that into account.
2018-07-18 14:38:45 +02:00
Guillaume Smet dde8744ca3 HHH-12718 Add a comment about the true meaning of interceptorHandledDirtyCheck 2018-07-17 12:10:19 +02:00
Yoann Rodière da2d986efb HHH-12718 Avoid double negations in DefaultFlushEntityEventListener#dirtyCheck 2018-07-17 12:10:19 +02:00
Yoann Rodière e53e0ef790 HHH-12718 Compute dirtiness using whatever method is appropriate after a flush event interception
We used to have a simpler version of the dirtyCheck() method after an
interception, but that's not enough.
2018-07-17 12:10:19 +02:00
Yoann Rodière 47107e3e88 HHH-12718 Test that dirtiness strategies are invoked a second time after a flush interceptor changes the entity state
Bytecode enhancement is harder to test, so I didn't add a test for that,
but since bytecode enhancement dirty checking is called exactly at the
same place, if one works, the other should, too.
2018-07-17 12:10:19 +02:00
Ulrich Bestfleisch a180caecd6 HHH-12718 - Entity changes in @PreUpdate callback are not persisted when lazy loading is active for more than one field 2018-07-17 12:10:19 +02:00
Yoann Rodière af427cb6c5 HHH-12795 Test the flushMode attribute of @NamedQuery and @NamedNativeQuery 2018-07-17 11:07:41 +02:00
Yoann Rodière 36fcadaa6a HHH-12795 Use the exact flush mode specified in @NamedQuery/@NamedNativeQuery when instantiating named queries
... instead of using an approximation in terms of JPA flush mode.
2018-07-17 11:07:41 +02:00
Guillaume Smet e4ae86cce2 HHH-12811 Add @Target annotations to @CreationTimestamp and @UpdateTimestamp 2018-07-17 10:59:39 +02:00
Guillaume Smet 1688c3ff8d HHH-12786 Improve the basic proxy interceptor
Apart from cosmetic changes, we were testing in the equals() method that the
instance == the proxied object which will always be true.

We should use the argument of the equals() method instead to do the
comparison.

And we can do the comparison on the instance, instead of requiring
passing the proxiedObject into the interceptor.
2018-07-16 17:35:15 +02:00
Guillaume Smet 67698b8bdb HHH-12786 Only define the default constructor
We don't need the others, better not create them in the proxy.
2018-07-16 17:35:15 +02:00
Guillaume Smet 0fda6be86e HHH-12786 Allow to call methods when the interceptor is not set yet
Typically, if the constructor calls instrumented methods, the
interceptor is not defined yet and we get a NPE.
2018-07-16 17:35:15 +02:00
Guillaume Smet 297031319d HHH-12786 Properly indent the Bytebuddy DSL
It helps to understand what exactly these calls do.
2018-07-16 17:35:15 +02:00
Guillaume Smet 667b565028 HHH-12804 Don't mock Map in CollectionBinderTest
Apparently, Mockito + ByteBuddy are unable to mock Map on JDK 11.

It might be solved in the future but there's no point in doing it so
let's avoid it.
2018-07-16 15:07:56 +02:00
Guillaume Smet a9e20c18c5 HHH-12801 Adjust the assertion to the new message generated by JDK 11 2018-07-16 15:07:56 +02:00
Guillaume Smet 9d36d1d91f HHH-12800 Use a class loading strategy suitable for the JDK used
The previously chosen strategy used misc.Unsafe which is not possible
anymore with JDK 11.
2018-07-16 15:07:56 +02:00
Gail Badner 7e69797a45 HHH-12802 : Fix test case to recover from exception properly
(cherry picked from commit 9202a5a11d)
2018-07-13 15:53:46 -07:00
Gail Badner 3af8b6235a HHH-12802 : Hibernate does not thrown an exception when more than entity is loaded with the same ID
(cherry picked from commit 926ad5a133)
2018-07-13 14:51:12 -07:00
Gail Badner ff18d904e8 HHH-12802 : test case
(cherry picked from commit 2ef777e3fe)
2018-07-13 14:50:51 -07:00
Vlad Mihalcea 4b51867c44 HHH-12771 - Caused by: java.lang.UnsupportedOperationException: Cache provider [org.hibernate.cache.ehcache.internal.EhcacheRegionFactory@3271ec2a] does not support `transactional` access 2018-07-13 09:43:03 +03:00
Vlad Mihalcea 1192eed560 HHH-12787 - SessionJdbcBatchTest hangs with DB2 2018-07-12 13:41:37 +03:00
Fabio Massimo Ercoli 6d0509bb34 HHH-12793 Upgrade Karaf, pax-exam and reenable the OSGi tests 2018-07-12 12:13:32 +02:00
Vlad Mihalcea 3bba6adac9 HHH-12768 - TimeAndTimestampTest fails with SQL Server and MYSQL 2018-07-12 06:37:20 +03:00
Yoann Rodière fb8e1c1d71 HHH-12695 Restore the getType method in ParameterRegistration
It was removed in 5.3.0.Beta1, but this breaks backward compatibility
with 5.1.
2018-07-11 09:57:25 +02:00
Yoann Rodière 68ad2130e8 HHH-12695 Rename org.hibernate.query.QueryParameter#getType to getHibernateType
Because it conflicts with the Class-returning getType method we want to
re-introduce in ParameterRegistration to restore backward compatibility.
2018-07-11 09:57:25 +02:00
Yoann Rodière c26ac23a7b HHH-12695 Add missing @Overrides in subclasses of javax.persistence.Parameter
Because we are in 2018 and Java 5 is now 14 years old.
2018-07-11 09:57:25 +02:00
Yoann Rodière a0d2f53937 HHH-12695 Explicitly mark contracts as @Incubating, since a comment in QueryParameter implies they are in fact incubating
I did not mark ParameterRegistration as incubating, because it's a
pre-existing interface that we can't reasonably consider as incubating.

It's a bit odd to have a non-incubating contract (ParameterRegistration)
extend an incubating one (ProcedureParameter), though...
2018-07-11 09:57:25 +02:00
Gail Badner 0e1f3d5c94 HHH-12740 : Subselect fetching doesn't work when multiLoad was used
(cherry picked from commit 579ee65fd3)
2018-07-10 18:51:51 -07:00
Robert Rettig b0f2d0fa59 HHH-8805 - [SchemaUpdate] javax.persistence.ForeignKey doesn't respect ConstraintMode.NO_CONSTRAINT 2018-07-10 14:32:37 +03:00
Yoann Rodière 7471aa1589 HHH-7686 Add missing @Overrides in MapProxy 2018-07-09 17:35:01 +02:00
Yoann Rodière 782336faed HHH-7686 Allow lazy loading outside of a transaction after dynamic map proxy deserialization if the proper settings were enabled
In theory, trying to deserialize MapLazyInitializer instances that were
serialized before this patch should still work, although using such
instances (i.e. trying to access any method on the proxy) would still
fail, just like it used to before this patch.
2018-07-09 17:35:01 +02:00
Yoann Rodière bc6c982541 HHH-7686 Test dynamic map proxy serialization 2018-07-09 17:35:01 +02:00
Yoann Rodière f2b4aedc03 HHH-7686 Clarify and test initialization code in the writeReplace() method in proxies
If we copy the behavior of "traditional" (non-map) proxies to the
"dynamic-map" proxies, we'd better know what this behavior is and be
sure it works correctly.
2018-07-09 17:35:01 +02:00
Yoann Rodière e0900b17e2 HHH-12720 Deprecate a useless constructor in AbstractSerializableProxy
A no-arg constructor is only necessary for superclasses of serializable
classes that are not themselves serializable. Here the class is
serializable, so the constructor is useless.
2018-07-09 17:35:01 +02:00
Yoann Rodière 3336489e40 HHH-12720 Allow lazy loading outside of a transaction after proxy deserialization if the proper settings were enabled 2018-07-09 17:35:01 +02:00
Yoann Rodière 500edf4b8a HHH-12720 Test proxy serialization with hibernate.enable_lazy_load_no_trans = true 2018-07-09 17:35:01 +02:00
Guillaume Smet 147476038b HHH-12778 Register the cause when an exception occurs creating a proxy 2018-07-09 15:08:36 +02:00
Guillaume Smet 1d68b1a2d0 Revert "HHH-12670 - Allows native SQL queries that take a given resultClass to map the result set to the required type"
This reverts commit 9fac6747ef.
2018-07-09 13:46:36 +02:00
Gail Badner 9b0c3ba600 HHH-12746 : Remove assertion that hashCodes are not equal from test 2018-07-04 15:55:30 -07:00
Gail Badner b4762fd52c Revert "HHH-12746 : CacheKeyImplementation objects with different entityOrRoleName and same id/tenantId have the same hashCode"
This reverts commit 220f41dc3b.
2018-07-04 15:52:11 -07:00
Gail Badner 8081aaec93 HHH-12729 : Correct Javadoc comments 2018-07-04 15:47:51 -07:00
Gail Badner c143e888d2 HHH-12729 : Binary and behavioral incompatibilities of org.hibernate.Query.getFirstResult(), setFirstResult(), getMaxResults(), setMaxResults() 2018-07-04 15:47:51 -07:00
Vlad Mihalcea 8fff54d6ee HHH-12769 - Rework LockTest#testContendedPessimisticLock so that it can work on Oracle without throwing exceptions 2018-07-04 21:00:11 +03:00
Vlad Mihalcea 6b3e4e6f56 HHH-12767 - Fix tests failing on Oracle 2018-07-04 17:49:42 +03:00
Guillaume Smet 88bfe7e66c HHH-12531 Make the legacy names public so that Infinispan can reuse them 2018-07-04 16:15:41 +02:00
Yoann Rodière 21eac287e9 HHH-12531 Default to using legacy region names when default query caches do not exist in the EhCache and JCache integrations 2018-07-04 10:03:23 +02:00
Yoann Rodière 63cc63b386 HHH-12531 Use short, simple names for the query result and update timestamps caching regions 2018-07-04 10:03:23 +02:00
Yoann Rodière 2649e1372c HHH-12649 Move the created cache warning to org.hibernate.cache.spi.SecondLevelCacheLogger 2018-07-04 09:44:50 +02:00
Guillaume Smet e7145cfe72 HHH-12727 Reduce the accesses to the statement -> result sets map 2018-07-04 09:37:44 +02:00
Guillaume Smet 4c22b52f80 HHH-12699 Resolve once and for all the method mapping in ResultSet proxy 2018-07-04 09:37:44 +02:00
Guillaume Smet 377b3d1fbe HHH-12699 Fix a typo 2018-07-04 09:37:44 +02:00
Yoann Rodière a19fc84320 HHH-12594 Properly share AliasResolutionContextImpl between EntityLoadQueryDetails instances
In particular, avoid contributing the aliases twice for the same
context: this would just trigger exceptions.
2018-07-04 09:22:09 +02:00
Sanne Grinovero 665110452e HHH-12692 Fixing style 2018-07-03 23:41:48 +01:00
Walter White 5f0024feae HHH-12692 SessionImpl#toString - add system identity hashcode
show the instance id in addition to whether the session is open or closed (when trace is not enabled).
2018-07-03 23:38:06 +01:00
Walter White a0633b84fe HHH-12692 SessionImpl#toString - remove overly verbose output
Is toString used, if so, when do we need to see the actionQueue or persistenceContext?
TRACE?
2018-07-03 23:37:50 +01:00
Andrea Boriero a9538ef710 HHH-12247 Verify JPA bootstrap errors are propagated 2018-07-03 19:52:37 +01:00
Sanne Grinovero 2253fad19d HHH-12247 Propagate bootstrapping exceptions rather than logging them at DEBUG level 2018-07-03 19:52:37 +01:00
Martin Simka d79d6267d0 [HHH-12765] don't use SQL Server reserved keyword in test 2018-07-03 19:28:39 +01:00
Yoann Rodière 212d8c01e5 HHH-11495 Update the javadoc of Metamodel#getImplementors to reflect the actual implementation
In particular, the actual implementations may not return all persisted
subtypes if the given type is persisted and "explicit polymorphism" is
enabled. So this really is more about HQL queries than about a class
hierarchy.
2018-07-03 19:00:13 +02:00
Yoann Rodière 600164869b HHH-11495 Add a missing @Override 2018-07-03 19:00:13 +02:00
Guillaume Smet 6c5e71fc40 HHH-11495 Only cache values if the class is mapped somehow 2018-07-03 19:00:13 +02:00
Guillaume Smet 7067b191b7 HHH-11495 Change the logic to be more efficient
We are optimistic about our chances to find the elements in the cache,
thus avoiding calling computeIfAbsent() if not necessary.

We only store in the cache the elements for which we have a proper
class, thus avoiding filling the cache with random values.
2018-07-03 19:00:13 +02:00
Guillaume Smet e17491a198 HHH-11495 Return a defensive copy of the array 2018-07-03 19:00:13 +02:00
Carlos Aristu 9684afda76 HHH-11495 Reduce criteria overhead by adding an implementors cache 2018-07-03 19:00:12 +02:00
Sanne Grinovero a67c6b9cd4 HHH-12760 Remove no longer needed EqualsHelper and cleanup some equality checks 2018-07-03 10:43:49 +01:00
Sanne Grinovero a3d39bbf96 HHH-12758 Arquillian JVM configuration for integration tests is ignoring system properties 2018-07-02 19:59:45 +01:00
Vlad Mihalcea 6f336b850c HHH-12749 - Avoid setting the isolation level to the same value in C3P0ConnectionProvider 2018-07-02 13:36:23 +03:00
Gail Badner 220f41dc3b HHH-12746 : CacheKeyImplementation objects with different entityOrRoleName and same id/tenantId have the same hashCode 2018-07-02 09:46:11 +02:00
Gail Badner f166b044a6 HHH-12746 : test case 2018-07-02 09:46:11 +02:00
Guillaume Smet 6b0ef0a5c4 HHH-12685 Fix a few warnings 2018-06-29 11:51:54 +02:00
Guillaume Smet 989ff9509f HHH-12685 Move the test where it should have been
Add an additional test for getParameters()
2018-06-29 11:51:54 +02:00
Andrea Boriero 673e4f7d01 HHH-12685 - Add tests 2018-06-29 11:51:54 +02:00
Andrea Boriero d64a9a9000 HHH-12685 - Fix CriteriaQueryTypeQueryAdapter parameters type validation issues 2018-06-29 11:51:54 +02:00
cristhiank d4a46fa93e HHH-12685 Add test case
Signed-off-by: cristhiank <calovi86@gmail.com>
2018-06-29 11:51:54 +02:00
Guillaume Smet 27409b27a3 HHH-12685 Convert the parameters to JPQL ones before calling isBound() 2018-06-29 11:51:54 +02:00
Vlad Mihalcea 07738c4d89 HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup) 2018-06-29 11:09:00 +03:00
Gail Badner 3dcf69c687 HHH-12637 : Improvement to fix for HHH-12592
HHH-12637 : Rename/add new tests; remove sequences from IDs
2018-06-27 11:41:37 -07:00
Sanne Grinovero 06174d8433 HHH-12743 Cleanup some deprecated code from ProviderChecker 2018-06-27 13:42:12 +01:00
Sanne Grinovero 57ba794a62 HHH-12744 Remove no longer necessary jboss-deployment-structure.xml from integration tests 2018-06-27 13:42:12 +01:00
Guillaume Smet 09aa12496f HHH-12741 Add a comment to explain why we add the new keywords here 2018-06-27 13:28:47 +02:00
Yanming Zhou 0a4a609a42 HHH-12741 Register new reserved words added in MySQL 8.0
https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-8-0-A
2018-06-27 13:26:41 +02:00
Vlad Mihalcea b3e0d363bd HHH-12738 - Session/EntityManager is closed in ForeignGenerator (JTA setup)
Add test case proving the issue does not replicate for either RESOURCE_LOCAL or JTA transactions
2018-06-27 11:45:02 +03:00
Guillaume Smet 163cab99e2 HHH-12630 Keep the original starting exception and use it as a cause 2018-06-26 18:09:26 +02:00
Sanne Grinovero d0087948ef HHH-12640 Do not fully deprecate the WildFlyStandAloneJtaPlatform so to allow an explicit user choice 2018-06-26 15:44:17 +01:00
Scott Marlow 1a89a167b4 HHH-12640 deprecate WildFlyStandAloneJtaPlatform but still allow apps to reference it until we remove it in the future 2018-06-26 15:33:28 +01:00
Vlad Mihalcea 9fac6747ef HHH-12670 - Allows native SQL queries that take a given resultClass to map the result set to the required type 2018-06-26 15:13:25 +03:00
Florian Lopes 83e4384c3e HHH-12734 Add original exception when selected strategy could not be loaded 2018-06-26 13:28:41 +02:00
Vlad Mihalcea ed34a25769 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issue due to multi-line formatting
2018-06-26 13:49:42 +03:00
Vlad Mihalcea e6ea4828db HHH-12124 - The JPA Metamodel does not allow to retrieve the actual EmbeddableType since all instances are registered by the associated Java type 2018-06-26 13:16:25 +03:00
Vlad Mihalcea 84439af053 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key
Fix indentation issues
2018-06-26 13:14:16 +03:00
Guillaume Smet afbec8856c HHH-12724 Add javax.activation as a dependency
It is required by JAXB now that JDK 9 does not provide it anymore.
2018-06-26 12:01:06 +02:00
Peter Holvenstot 9728694386 HHH-12684 - Hibernate fails when mapping one-to-many collections by non-primary key 2018-06-26 12:38:09 +03:00
Vlad Mihalcea 9b106cf59c HHH-12688 - Duplicated Error Information Displayed in the Log
Restrict test case to H2 only
2018-06-26 12:37:28 +03:00
Vlad Mihalcea bcb71fcdd6 HHH-12688 - Duplicated Error Information Displayed in the Log 2018-06-26 11:12:29 +03:00
Vlad Mihalcea 62b2af760e HHH-12476 - NativeQuery with EntityGraphs cause a ClassCastException to be thrown 2018-06-26 10:20:28 +03:00
Yoann Rodière e5dc635a52 HHH-12594 Un-ignore BatchFetchBootstrapTest 2018-06-25 15:22:27 +02:00
Yoann Rodière e1bcfc12cf HHH-12594 Do not share AliasResolutionContextImpl between EntityLoadQueryDetails instances
Sharing it results in some tables being aliased twice for the same query
space, but with different aliases, resulting in exceptions.

Ideally we should try to generate the aliases once, and then share the
AliasResolutionContextImpl between EntityLoadQueryDetails instances,
but I'm really not comfortable enough with this code to make that kind
of changes.
2018-06-25 15:22:27 +02:00
Yoann Rodière 80360b1317 HHH-12594 Trim down BatchFetchBootstrapTest to the simplest possible configuration
So that we can investigate without unnecessary complexity getting in the
way.
2018-06-25 14:15:35 +02:00
Andrea Boriero 337646de13 HHH-12723 - Revert the changes applied by HHH-12585 to the DefaultFlushEntityEventListener#invokeInterceptor() method
This reverts commit 9b00aaf9a5.
2018-06-25 10:16:05 +01:00
Vlad Mihalcea a30635f14a HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Make base class abstract
2018-06-22 14:30:48 +03:00
Vlad Mihalcea ffa5eb0e1d HHH-12704 - MSSQL executing StoredProcedure on different DB using dot notation throws error
Add test case proving the issue is caused by the SQL Server JDBC Driver
2018-06-22 14:27:52 +03:00
Vlad Mihalcea 8bbd22967e HHH-12710 - BaseCoreFunctionalTestCase opens an InputStream for mapping files but never closes it 2018-06-20 17:47:47 +03:00
Vlad Mihalcea ebca36a768 HHH-12654 - Throw MappingException if both @Inheritance and @AttributeOverride are used 2018-06-20 17:03:04 +03:00
Vlad Mihalcea d4861fed9f HHH-12700 - Missing property in sample code in documentation of bulk-id strategies 2018-06-18 16:55:36 +03:00
Sanne Grinovero fb473e6a60 Whitespace fixes required by checkstyle 2018-06-18 13:43:01 +01:00
Jan-Willem Gmelig Meyling 2211e61b04 HHH-12671 - Fix persisting generated properties on identity insert 2018-06-18 11:08:22 +03:00
Gail Badner 607e51617e HHH-12687 : ManyToOne associations in embeddable collection elements and composite IDs are always eagerly loaded 2018-06-15 15:12:50 -07:00
Gail Badner 35b908167e HHH-12651 : org.hibernate.Session.*Query(Ljava/lang/String) methods return different types in 5.1 and 5.3 2018-06-14 16:10:24 -07:00
Vlad Mihalcea 30fec4be79 HHH-12662 - JPQL queries fail when using the Java attribute type which has an associated AttributeConverter (only the DB column type works) 2018-06-14 09:29:18 +03:00
Vlad Mihalcea bff9e2e450 Fix test failing on MariaDB 2018-06-14 08:23:11 +03:00
Philippe Marschall 5089a818e2 HHH-12686 Replace EmptyIterator with emptyIterator 2018-06-13 14:20:19 +02:00
Philippe Marschall 4c52764c41 HHH-12604 Replace EqualsHelper.equals with Objects.equals 2018-06-13 14:20:19 +02:00
Jonathan Bregler c1eaf011ad HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery
Fix tests for HANA, Oracle
2018-06-12 19:55:25 +03:00
cristhiank 22973c355a HHH-9403 - AssertionFailure: Fail to process type argument in a generic declaration 2018-06-11 08:04:05 +03:00
Vlad Mihalcea 566a23736d HHH-12561 - bulk_id_strategy does not work with globally_quoted_identifiers 2018-06-08 11:48:51 +03:00
Roland Kurucz b6a16a3678 HHH-12661 - Hibernate types (e.g. NumericBooleanType, YesNoType and any implementations of UserType) cannot bind value in StoredProcedureQuery 2018-06-08 11:26:38 +03:00
Chris Cranford 9ad030aee6 HHH-12668 - Fix JPA 2.2 xsds so they properly validate. 2018-06-07 13:44:06 -04:00
Chris Cranford 736c913f14 HHH-12396 - Fix problem with EnumType resolution on GlassFish platforms. 2018-06-04 13:05:33 -04:00
Guenther Demetz 7a4b38c6b7 HHH-12657 - Fix ClassCastException for cached natural-id entity with subclasses 2018-06-01 13:12:23 -04:00
Vlad Mihalcea b98c02c503 HHH-12609 - Cannot override constaints when using @AttributeOverride annotation
Add test cases to prove the issue does not replicate for @MappedSuperclass
2018-05-31 11:35:32 +03:00
Gail Badner dfecae09c5 HHH-11979 : Invalid SQL when force increment version of inherited entity 2018-05-30 18:22:27 -07:00
Gail Badner cc9b3eb183 HHH-11979 : test case 2018-05-30 18:21:14 -07:00
Guillaume Smet 6a04d7836c HHH-12633 Fix model definition in the test to be PostgreSQL compatible 2018-05-28 12:13:48 +02:00
Guillaume Smet de5bf278f6 HHH-12633 Fix dirty tracking when previous state is unfetched 2018-05-28 11:07:29 +02:00
Scott Marlow 0c52195a7d Revert "HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT"
This reverts commit c886111a79.
2018-05-27 10:10:33 -04:00
Scott Marlow 558cbdd97d HHH-12640 Update to JBossStandAloneJtaPlatform should be backward compatible attempting old names as well 2018-05-27 10:10:00 -04:00
Philippe Marschall 83c6b56fc8 HHH-12606 Container contents are never accessed
https://hibernate.atlassian.net/browse/HHH-12606
2018-05-25 22:21:52 +01:00
Philippe Marschall 3489f75e1d HHH-12605 Boxed variables never null
https://hibernate.atlassian.net/browse/HHH-12605
2018-05-25 22:05:09 +01:00
Gail Badner 01caa5f2b4 HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections. 2018-05-25 17:32:38 +01:00
Gail Badner 6aa8301499 HHH-12592 : Add more tests 2018-05-25 17:32:38 +01:00
Gail Badner e1b08967d9 Revert "HHH-12592 - Fix merging detached enhanced entities with orphan-removal collections."
This reverts commit 4f119105f8.
2018-05-25 17:32:38 +01:00
Gail Badner c3c0cd550f HHH-12592 : add assertions to ensure that the detached and merged collection are not the same, which currently fails 2018-05-25 17:32:38 +01:00
Andrea Boriero 80bf92e32a HHH-12620 fix test dependencies 2018-05-25 11:56:00 -04:00
smarlow b34f615200 HHH-12620 some test dependencies 2018-05-25 11:56:00 -04:00
smarlow c886111a79 HHH-12620 Update JBossStandAloneJtaPlatform to use org.wildfly.transaction.client.* TM/UT 2018-05-25 11:56:00 -04:00
Guillaume Smet 38552103cc HHH-12634 Make EntityPrinter more permissive regarding the parameters passed 2018-05-25 09:47:28 -04:00
Guillaume Smet 9d4d0ae63b HHH-12584 In fact, we can provide a ReflectionOptimizer, just without the fast class instantiator
The fast class instantiator don't make sense for an abstract class or an
interface. I checked the code and we can indeed instantiate a
ReflectionOptimizer without a fast class instantiator.
2018-05-25 09:22:40 -04:00
Guillaume Smet 9a3aa99e83 HHH-12631 Fix invalid tracev calls in DefaultResolveNaturalIdEventListener 2018-05-25 13:13:59 +02:00
nikowitt b96af61566 HHH-12629 Make some methods protected in DefaultLoadListener
And some nice dead code removal.
2018-05-25 11:47:33 +01:00
Guillaume Smet 7c1a737c2a HHH-12627 Fix a debug level message 2018-05-25 10:31:21 +01:00