2aa2c686d4
Theme Editor: Fix styling of child theme notice.
...
Props westonruter, melchoyce, ndiego.
See #24048 .
Fixes #42491 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42155
git-svn-id: http://core.svn.wordpress.org/trunk@41986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-11 20:43:53 +00:00
826c589f11
Customize: Restore ability to add Custom Link nav menu items for jump links and other URLs that were previously allowed.
...
Simplify regular expression for checking URL validity to just do basic checks to confirm the value looks like a URL. Leave the complete validation to the server-side logic in `WP_Customize_Nav_Menu_Item_Setting::sanitize()` to avoid having to maintain two separate codebases for validating URLs.
Props westonruter, SergeyBiryukov for testing.
Amends [41697].
See #32816 .
Fixes #42506 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42153
git-svn-id: http://core.svn.wordpress.org/trunk@41984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:41:53 +00:00
e86536afc9
Customize: Prevent nav menu location assignment checkbox change from increasing height by 1px.
...
Props obenland.
Amends [41817].
See #42157 .
Fixes #42492 .
Built from https://develop.svn.wordpress.org/trunk@42152
git-svn-id: http://core.svn.wordpress.org/trunk@41983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 23:01:48 +00:00
67c973f95e
Docs: Correct parameter type documentation for various `__call()` methods.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42151
git-svn-id: http://core.svn.wordpress.org/trunk@41982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:56:47 +00:00
6c6d112e74
Customize: Improve accuracy of message displayed when accessing Customizer with a changeset that is already published or trashed.
...
Amends [38810].
Props dlh.
Fixes #42497 .
Built from https://develop.svn.wordpress.org/trunk@42150
git-svn-id: http://core.svn.wordpress.org/trunk@41981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:51:46 +00:00
016a3f9ecd
Customize: Ensure customization drafts are published instead of trashed when scheduled changeset goes live while non-admin user is authenticated (such as during WP Cron).
...
Props designsimply for testing, dlh for testing, melchoyce for testing.
See #28721 , #34923 , #42220 .
Fixes #42489 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42148
git-svn-id: http://core.svn.wordpress.org/trunk@41979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:44:52 +00:00
10ac2ccd3a
Settings: Replace `count()` call with `empty()` in `get_settings_errors()` to prevent PHP 7.2 warnings when `$wp_settings_errors` is `null`.
...
Props pross, dd32, westonruter.
See #40109 .
Fixes #42498 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42146
git-svn-id: http://core.svn.wordpress.org/trunk@41977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:30:56 +00:00
9db496159e
Customize: Ensure autosave revision is dismissed immediately after implicit restoration notice dismissal as done with explicit notice dismissal.
...
Fixes issue where a drafted/scheduled changeset could inadvertently re-use the previous autosave revision in the preview while a user expects it to have been dismissed.
See #39896 , [41597].
Fixes #42502 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42144
git-svn-id: http://core.svn.wordpress.org/trunk@41975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 21:44:55 +00:00
3be5d4b4f0
Docs: Improve inline docs for the `wp_redirect()` and `wp_safe_redirect()` functions.
...
See #42505 , #42108
Built from https://develop.svn.wordpress.org/trunk@42143
git-svn-id: http://core.svn.wordpress.org/trunk@41974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 13:44:47 +00:00
e8229a25d5
REST API: Add `permalink_structure` to the index endpoint.
...
This allows Gutenberg to implement permalink editing.
Props schlessera.
Fixes #42465 .
Built from https://develop.svn.wordpress.org/trunk@42142
git-svn-id: http://core.svn.wordpress.org/trunk@41973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 06:11:51 +00:00
4bf8081e64
Widgets: Style the Image Widget's link field as invalid when a bad URL is supplied.
...
Fixes issue where user may supply an invalid URL and be unable to save the widget on the Widgets admin screen without being told why.
Amends [41252].
See #41274 .
Fixes #42488 .
Built from https://develop.svn.wordpress.org/trunk@42140
git-svn-id: http://core.svn.wordpress.org/trunk@41971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 01:28:49 +00:00
1ee26acf95
Customize: Fix reliability of just-in-time publishing for changesets that miss their schedule when visiting `customize.php`.
...
When just doing `wp_publish_post()` for the changeset from `customize.php`, any option-based settings will fail to get saved because `WP_Customize_Manager` would have already been loaded with `settings_previewed`, resulting in `update_option()` calls being short-circuited. So an admin-ajax request to `customize_save` is used to work around this.
Props westonruter, jeremyfelt, dlh for testing, LittleBigThing for testing.
Amends [41626].
See #28721 , #39221 .
Fixes #42457 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42138
git-svn-id: http://core.svn.wordpress.org/trunk@41969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:44:47 +00:00
19ec50f92a
Customize: Ensure `autosaving` message gets sent to preview after initial change when `saved` state is first dirty.
...
Amends [41667].
Fixes #42475 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42136
git-svn-id: http://core.svn.wordpress.org/trunk@41967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 04:15:49 +00:00
6c00350575
Settings: Fix date/time format previewing.
...
Props afercia.
Amends [41857].
Fixes #41603 .
Built from https://develop.svn.wordpress.org/trunk@42134
git-svn-id: http://core.svn.wordpress.org/trunk@41965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 03:55:46 +00:00
3c6ce6751f
Customize: Restore search icon to available widgets pane incorrectly removed in [41893].
...
See #42215 .
Fixes #42472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42132
git-svn-id: http://core.svn.wordpress.org/trunk@41963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-09 01:02:47 +00:00
39a3fe9180
Admin Bar: Fix another HTML error introduced in [42128].
...
Props Otto42.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42131
git-svn-id: http://core.svn.wordpress.org/trunk@41962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 23:13:46 +00:00
0a81bcf4ff
External Libraries: Update Random_Compat from 1.2.1 to 2.0.11.
...
Notably this fixes PHP7 parse errors of the files and removes the OpenSSL functionality.
Full Changes: https://github.com/paragonie/random_compat/compare/v1.2.1...v2.0.11
Props jrdelarosa.
See #42439 .
Built from https://develop.svn.wordpress.org/trunk@42130
git-svn-id: http://core.svn.wordpress.org/trunk@41961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 11:48:49 +00:00
e822e4578a
Admin Bar: Fix a HTML error introduced in [42128].
...
Props swissspidy.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42129
git-svn-id: http://core.svn.wordpress.org/trunk@41960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 08:52:48 +00:00
bde3b95936
Admin Bar: Reformat the render methods.
...
The admin bar render methods use some cute tricks which don't come close to the WordPress coding standards. So that we can more easily apply automated code fixing to the codebase, these tricks need to be removed.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42128
git-svn-id: http://core.svn.wordpress.org/trunk@41959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-08 08:35:51 +00:00
d7b49bbc3e
Trunk is now 5.0-alpha
...
Built from https://develop.svn.wordpress.org/trunk@42127
git-svn-id: http://core.svn.wordpress.org/trunk@41958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 05:47:51 +00:00
59fdb7a220
Post WordPress 4.9 RC2 bump.
...
Built from https://develop.svn.wordpress.org/trunk@42125
git-svn-id: http://core.svn.wordpress.org/trunk@41956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 05:26:47 +00:00
f76b491135
WordPress 4.9 RC2.
...
Built from https://develop.svn.wordpress.org/trunk@42124
git-svn-id: http://core.svn.wordpress.org/trunk@41955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:54:47 +00:00
4eda9c7388
About: Hardcoded image sources.
...
We're committed to these images now.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42123
git-svn-id: http://core.svn.wordpress.org/trunk@41954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:26:48 +00:00
e4fe01e2b4
Customize: Fix logic inversion in [42113] which prevented themes from being installed in Customizer.
...
Also fix PHP notice related to parent themes and WordPress.org theme query results.
Props dd32, obenland, celloexpressions, westonruter, atachibana for testing.
See #42406 , #37661 .
Fixes #42442 .
Built from https://develop.svn.wordpress.org/trunk@42122
git-svn-id: http://core.svn.wordpress.org/trunk@41953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:17:47 +00:00
2382232692
About Page: Implement design.
...
Props ryelle, karmatosed, transl8or, obenland, melchoyce.
See #42087 .
Built from https://develop.svn.wordpress.org/trunk@42121
git-svn-id: http://core.svn.wordpress.org/trunk@41952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 04:11:47 +00:00
f71a087b41
Bump Akismet external to 4.0.1.
...
git-svn-id: http://core.svn.wordpress.org/trunk@41950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 03:10:03 +00:00
8255d04abb
WPDB: Check that `AUTH_SALT` is not empty.
...
In `wpdb::placeholder_escape()`, the key for `hash_hmac()` defaults to `AUTH_SALT`, but `hash_hmac()` will return an empty string if the key is empty.
This had the side effect of the string `{}` being incorrectly replaced with a `%` character in queries just about to be run on the database.
Props jsonfry.
Fixes #42431 .
Built from https://develop.svn.wordpress.org/trunk@42120
git-svn-id: http://core.svn.wordpress.org/trunk@41949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 01:09:47 +00:00
002d65112f
WPDB: Fix a PHP notice when `AUTH_SALT` is undefined.
...
In `wpdb::placeholder_escape()`, the key for `hash_hmac()` falls back to `rand()` when `AUTH_SALT` is undefined. `hash_hmac()` requires the key to be a string, however, so we need to cast it as such.
Props mkomar.
Fixes #42401 .
Built from https://develop.svn.wordpress.org/trunk@42119
git-svn-id: http://core.svn.wordpress.org/trunk@41948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-07 00:30:46 +00:00
a74afff787
Customize: Prevent `customize_autosaved=on` from getting added to frontend preview URLs.
...
Amends [41969].
See #39896 , #42450 .
Fixes #42433 .
Built from https://develop.svn.wordpress.org/trunk@42118
git-svn-id: http://core.svn.wordpress.org/trunk@41947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 23:11:53 +00:00
c15b2a0908
Customize: Fall back to ISO date format for date/time control inputs if year, month, or day are missing from the `date_format` option.
...
Amends [42111].
Props dlh, westonruter.
Fixes #42394 .
Built from https://develop.svn.wordpress.org/trunk@42117
git-svn-id: http://core.svn.wordpress.org/trunk@41946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 20:28:48 +00:00
b8de3548d3
Administration: Ensure the new Privacy Policy screen appears when within the Network Admin and User Admin.
...
Props hnle, dd32
Fixes #42443
Built from https://develop.svn.wordpress.org/trunk@42116
git-svn-id: http://core.svn.wordpress.org/trunk@41945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-06 18:17:54 +00:00
65c1468ff5
File Editors: Account for network admin use
...
Fixes a bug where files couldn't be accessed in multisite installs.
Props flixos90, westonruter.
Fixes #42420 .
Built from https://develop.svn.wordpress.org/trunk@42115
git-svn-id: http://core.svn.wordpress.org/trunk@41944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 18:51:49 +00:00
76e01c3562
Customize: Ensure `changeset_uuid` param for autosave auto-draft gets stripped from location after previewing theme switch when not in branching mode.
...
Amends [41597].
See #39896 .
Fixes #42415 .
Built from https://develop.svn.wordpress.org/trunk@42114
git-svn-id: http://core.svn.wordpress.org/trunk@41943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 17:37:52 +00:00
d0608c5585
Customize: Make sure theme switch blocking in the Customizer is consistently applied when changeset is drafted/scheduled.
...
* Consider both `selectedChangesetStatus` and `changesetStatus` states when deciding to disable.
* Factor out common logic into `canSwitchTheme` function on `ThemesPanel`.
* Keep Live Preview and Install buttons disabled in Themes controls and detail overlays when appropriate.
Props westonruter, dlh.
Amends [41788].
See #42126 , #37661 , #39896 .
Fixes #42406 .
Built from https://develop.svn.wordpress.org/trunk@42113
git-svn-id: http://core.svn.wordpress.org/trunk@41942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-03 00:59:47 +00:00
83c29a4d08
Theme Editor: Ensure files listed recursively can be both viewed and edited.
...
Prevent edits to 2-level deep theme files from returning a `disallowed_theme_file` error when attempting to save an edit. Aligns logic for gathering `$allowed_files` in `theme-editor.php` for listing files with the validation logic in `wp_edit_theme_plugin_file()`.
Amends [41806].
See #6531 .
Fixes #42425 .
Built from https://develop.svn.wordpress.org/trunk@42112
git-svn-id: http://core.svn.wordpress.org/trunk@41941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 23:05:48 +00:00
ef272167c4
Customize: Present the date/time control input fields in the same format (and order) as `date_format`.
...
Props westonruter, obenland, atachibana for testing, Mirucon for testing.
See #42373 , #28721 .
Fixes #42394 .
Built from https://develop.svn.wordpress.org/trunk@42111
git-svn-id: http://core.svn.wordpress.org/trunk@41940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 23:00:49 +00:00
99c19a5a82
Codemirror: Unify line endings in csslint.js
...
This is likely a problem caused upstream and will probably be a non-issue once #41870 is merged in a future release.
Fixes #42424 .
Built from https://develop.svn.wordpress.org/trunk@42110
git-svn-id: http://core.svn.wordpress.org/trunk@41939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 22:31:47 +00:00
8902ddba18
Customize: Always use underlying changeset post date as initial date in scheduled date fields if date is future.
...
Prevent user from having to re-enter the previously-supplied future date if they had switched from schedule to draft but wanted to switch back again. Improves parity with behavior of post edit screen.
Props dlh, westonruter, obenland.
See #39896 , #28721 .
Fixes #42413 .
Built from https://develop.svn.wordpress.org/trunk@42109
git-svn-id: http://core.svn.wordpress.org/trunk@41938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 20:00:48 +00:00
fbee634ac7
Customize: Prevent `history.replaceState()` and `history.pushState()` calls from causing error in customize preview before DOM ready.
...
Amends [41597].
See #39896 .
Fixes #42414 .
Built from https://develop.svn.wordpress.org/trunk@42108
git-svn-id: http://core.svn.wordpress.org/trunk@41937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 19:27:47 +00:00
5f16c57782
Customize: Prevent re-importing starter content when changeset is saved as draft or scheduled.
...
Themes cannot currently be switched in Customizer after changeset is saved anyway.
Props dlh, westonruter.
See #40146 , #42411 , #42126 .
Fixes #42395 .
Built from https://develop.svn.wordpress.org/trunk@42107
git-svn-id: http://core.svn.wordpress.org/trunk@41936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 19:00:54 +00:00
7deb33b386
Bundled Themes: Fix fragile `update-theme` phpunit test which broke after version updates in [42105].
...
See #42090 .
Built from https://develop.svn.wordpress.org/trunk@42106
git-svn-id: http://core.svn.wordpress.org/trunk@41935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-02 01:26:48 +00:00
7b74056cf5
Bundled Themes: Bump version numbers and update changelogs for 4.9 release
...
* Also, updates POT files for Twenty Ten and Twenty Eleven.
Props lemacarl, maedahbatool, mrahmadawais, davidakennedy.
Fixes #42090 .
Built from https://develop.svn.wordpress.org/trunk@42105
git-svn-id: http://core.svn.wordpress.org/trunk@41934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-01 22:43:47 +00:00
926f2114f0
Customize: Strip zero padding when setting month to prevent de-selection; add zero-padding for `number` input fields when blurring.
...
Amends [42042].
See #42373 .
Fixes #42392 .
Built from https://develop.svn.wordpress.org/trunk@42104
git-svn-id: http://core.svn.wordpress.org/trunk@41933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-01 21:04:53 +00:00
a2693fd860
Database: Restore numbered placeholders in `wpdb::prepare()`.
...
[41496] removed support for numbered placeholders in queries send through `wpdb::prepare()`, which, despite being undocumented, were quite commonly used.
This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to `wpdb::prepare()`, given the number of placeholders.
See #41925 .
Built from https://develop.svn.wordpress.org/trunk@42056
git-svn-id: http://core.svn.wordpress.org/trunk@41885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 12:00:49 +00:00
6f2db8ea69
Post WordPress 4.9 RC1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@42050
git-svn-id: http://core.svn.wordpress.org/trunk@41884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 04:32:48 +00:00
84c6d74a8c
WordPress 4.9 RC1.
...
Built from https://develop.svn.wordpress.org/trunk@42049
git-svn-id: http://core.svn.wordpress.org/trunk@41883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 03:42:49 +00:00
8a1dc558a1
Customize: Consolidate sourcing of control `params`.
...
Prevent needlessly iterating over `controlConstructor` to find `type` when it is already supplied.
Amends [41750], [41726].
See #42083 .
Built from https://develop.svn.wordpress.org/trunk@42048
git-svn-id: http://core.svn.wordpress.org/trunk@41882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 02:59:47 +00:00
274792f9cd
REST API: JS client - Enumerate endpoints supporting trash.
...
Improve the logic determining which endpoints support the trash by enumerating them. Endpoints that don't support the trash require `force=true` when deleting. The previous approach relied on the `force` argument description, which is a translated string and was fragile. In the future, we can expose whether an endpoint supports the trash as part of its schema and automate this logic.
Props Soean.
Fixes #40672 .
Built from https://develop.svn.wordpress.org/trunk@42047
git-svn-id: http://core.svn.wordpress.org/trunk@41881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 02:54:48 +00:00
b61de38e87
Customize: Spiff up theme updates
...
Fixes UI bugs around theme updates in the Customizer. Theme versions now get updated and users are no longer left alone after a successful update.
Props rinkuyadav999, celloexpressions for initial patch.
Fixes #42365 .
Built from https://develop.svn.wordpress.org/trunk@42046
git-svn-id: http://core.svn.wordpress.org/trunk@41880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 01:33:47 +00:00
8981414082
About page: Tweak the privacy policy language, for clarity.
...
See #40794 .
Built from https://develop.svn.wordpress.org/trunk@42045
git-svn-id: http://core.svn.wordpress.org/trunk@41879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-31 00:21:49 +00:00
Weston Ruter
John Blackbourn
Gary Pendergast
Dion Hulse
Konstantin Obenland
Mel Choyce
David A. Kennedy
Adam Silverstein