When the original block editor styles were added to the existing default themes, the button blocks were styled to match how each theme styled the `button` tag.
However, the styles should respect the block editor's default style, "Rounded", and allow switching to the other styles, like "Outlined" and "Square".
Props laurelfulford.
Merges [44381] to the 5.0 branch.
Fixes#45541.
Built from https://develop.svn.wordpress.org/branches/5.0@44430
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
On pages and posts with featured images, the top level menu items have a slight transparency on hover, which was being inherited by their submenus. This update removes that inheritance, improving readability and consistency in the menu's appearance.
Props kjellr.
Merges [44368] to the 5.0 branch.
Fixes#45689.
Built from https://develop.svn.wordpress.org/branches/5.0@44427
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Twenty Seventeen's original styles for the block editor custom colors had some issues: they weren't being applied to the button blocks due to lack of specificity, and when applied to paragraph blocks, there was no padding in the editor. This update makes sure the colors and related styles work as expected.
Props laurelfulford.
Merges [44402] to the 5.0 branch.
Fixes#45426.
Built from https://develop.svn.wordpress.org/branches/5.0@44425
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The "Continue Reading" link that's generated by the More block is styled to include an arrow next to the text; that arrow shouldn't inherit the text underline style. This update removes it.
Props littlebigthing, kjellr.
Merges [44369] to the 5.0 branch.
Fixes#45715.
Built from https://develop.svn.wordpress.org/branches/5.0@44422
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Removes `file_exist()` checks before calling `load_script_translations()` to let the determined paths be passed to `load_script_translations()` which provides its own file check and the possibility to filter the path.
Merge of [44418] to the 5.0 branch.
Props swissspidy, johnbillion, ocean90.
Fixes#45769.
Built from https://develop.svn.wordpress.org/branches/5.0@44419
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A static variable contains an integer that is incremented with each call. This number is returned with the optional prefix.
As such the returned value is not universally unique, but it is unique across the life of the PHP process.
Props westonruter, dlh.
Merges [43658] and [44406] to the 5.0 branch.
See #44883.
Built from https://develop.svn.wordpress.org/branches/5.0@44407
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In [42523], `trunk` was updated to use explicit context instead of a trailing space for the Edit string in TinyMCE plugins. [43472] later backported this change, but the string in `class-wp-editor.php` was missed. This fixes the `Edit` string so not display as `Edit|button` in the 5.0 branch.
Props dimadin.
See #42543, #44134.
Fixes#44919.
Built from https://develop.svn.wordpress.org/branches/5.0@44401
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In the Classic Editor, the “Add Media” button was outside of the TinyMCE editor. In the Block Editor, the “Add Media” button was moved into the TinyMCE toolbar in the Classic block, but the tooltip was not added to the list of translatable strings. This adds “Add Media” to that list.
The corresponding keyboard shortcut is also specified for the “Add Media” button.
Props afercia.
Merges [44398-44399] to the 5.0 branch.
Fixes#45788.
Built from https://develop.svn.wordpress.org/branches/5.0@44400
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
While the filter is documented to only support a `WP_Error`, it has been a common practice to return true in a validation function if no errors have occurred. This was already caught when the same filter was executed in `WP_Customize_Setting`, it was however missing in `WP_Customize_Manager::validate_setting_values()`.
Props flixos90.
Merges [43578] to the 5.0 branch.
Fixes#44809.
Built from https://develop.svn.wordpress.org/branches/5.0@44392
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.
Props anevins, panchen, kjellr.
Fixes#45510.
Built from https://develop.svn.wordpress.org/branches/5.0@44357
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In [44185], a bug was introduced where hierarchical post types would not display in the correct default order (hierarchically).
This was caused by a `! isset()` check, which returned `false` after [44185], causing the correct default value to not be applied. This switches that conditional to use an `empty()` check, ignoring the new empty string assignment that was added to prevent a PHP notice when `compact()` is called.
Merges [44338] to the 5.0 branch.
Props davidbinda.
Fixes#45711.
Built from https://develop.svn.wordpress.org/branches/5.0@44339
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
* Introduces `pre_load_script_translations` to short-circuit the function.
* Introduces `load_script_translation_file` to filter the file path for loading script translations.
* Introduces `load_script_translations` to filter the JSON-encoded translation data.
Props johnbillion, strategio, swissspidy, dimadin, ocean90.
See #45425.
Built from https://develop.svn.wordpress.org/branches/5.0@44232
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When using the block-based editor in Twenty Sixteen, superscript is displaying below the baseline and subscript is displaying above the baseline. This is the opposite of what should occur. This reverses the two to display correctly.
Props greg-raven, torontodigits, JDTrower.
Fixes: #44776.
Built from https://develop.svn.wordpress.org/branches/5.0@44210
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixes the `load_script_textdomain` function not resolving the md5 hash based on the relative path for WordPress installations in a subdirectory. Also adds a filter to allow sites using CDNs or other alternative asset locations to filter the relative path resolution.
Props akirk, fierevere, swissspidy, mypacecreator, babaevan, tmatsuur, ocean90.
Fixes#45528.
Built from https://develop.svn.wordpress.org/branches/5.0@44209
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Twenty Seventeen’s editor styles contained an Internet Explorer 8 specific fix that stopped images from being scalable in the editor in other browsers. Since the editor no longer supports IE8, this fix can safely be removed.
Props audrasjb, mihaivalentin, subrataemfluence.
Fixes#39738.
Built from https://develop.svn.wordpress.org/branches/5.0@44205
git-svn-id: http://core.svn.wordpress.org/branches/5.0@44035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sergey Biryukov
Dominik Schilling
desrosj
laurelfulford
Gary Pendergast
gziolo
herregroen