WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
39,844 Commits 50 Branches 749 Tags 992 MiB
Commit Graph

39844 Commits

Author SHA1 Message Date
Sergey Biryukov ccba6c4aec Upgrade/Install: Bring some consistency to installation screen styles. 
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.
Built from https://develop.svn.wordpress.org/trunk@45673


git-svn-id: http://core.svn.wordpress.org/trunk@45484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 19:11:55 +00:00
Sergey Biryukov 1d283ef54f Docs: Clarify that `is_network_admin()` does not check if the site is a Multisite network; `is_multisite()` should be used for that. 
Props svovaf, dilipbheda, tazotodua.
Fixes #47415.
Built from https://develop.svn.wordpress.org/trunk@45672


git-svn-id: http://core.svn.wordpress.org/trunk@45483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 15:19:58 +00:00
Sergey Biryukov 8ab7bbe385 Posts, Post Types: Introduce `is_sticky` filter in `is_sticky()` to provide more flexibility for custom sticky post implementations. 
Props dehisok, greenshady.
Fixes #37629.
Built from https://develop.svn.wordpress.org/trunk@45671


git-svn-id: http://core.svn.wordpress.org/trunk@45482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:36:54 +00:00
Sergey Biryukov 316fa4aecb Code Editor: Check for correct `mode` value in `wp.codeEditor.initialize` to enable autocomplete support for PHP. 
Props ediamin.
Fixes #47769.
Built from https://develop.svn.wordpress.org/trunk@45670


git-svn-id: http://core.svn.wordpress.org/trunk@45481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:27:57 +00:00
Sergey Biryukov aee690fd84 Permalinks: Update URLs for "Changing File Permissions" documentation article. 
Props patilswapnilv, ianbelanger, SergeyBiryukov.
Fixes #47768.
Built from https://develop.svn.wordpress.org/trunk@45669


git-svn-id: http://core.svn.wordpress.org/trunk@45480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:18:55 +00:00
Sergey Biryukov 5522be31e7 Coding Standards: Use correct variable in `wp_dropdown_categories()` after [45667]. 
See #45059.
Built from https://develop.svn.wordpress.org/trunk@45668


git-svn-id: http://core.svn.wordpress.org/trunk@45479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:07:54 +00:00
Sergey Biryukov 18bd01985b Coding Standards: Rename `$r` variable used with `wp_parse_args()` to `$parsed_args` for clarity. 
Props freewebmentor.
Fixes #45059.
Built from https://develop.svn.wordpress.org/trunk@45667


git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 00:48:58 +00:00
Gary Pendergast 7112ee7132 Coding Standards: Move the remaining PHPCS errors to report as warnings, and add Travis tests. 
The remaining error-level coding standards issues (specifically, associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`, `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`, `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`, `WordPress.DB.PreparedSQL.NotPrepared`, and `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings, until they're all addressed.

This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.

Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45665


git-svn-id: http://core.svn.wordpress.org/trunk@45476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 07:48:56 +00:00
Gary Pendergast 172117d35f Coding Standards: Fix a filename replacement missed in [45663]. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45664


git-svn-id: http://core.svn.wordpress.org/trunk@45475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 04:42:57 +00:00
Gary Pendergast af0a914d14 Coding Standards: Move `wp-includes/class-oembed.php` to `wp-includes/class-wp-oembed.php`. 
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.

This commit also includes:

- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45663


git-svn-id: http://core.svn.wordpress.org/trunk@45474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 04:32:57 +00:00
Gary Pendergast 971814047f Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php 
This renames the file containing the Custom_Background class to conform to the coding standards.

This commit also includes:

- A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
- Replaces a reference to the old filename with the new filename.

See #47632.

Built from https://develop.svn.wordpress.org/trunk@45662


git-svn-id: http://core.svn.wordpress.org/trunk@45473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 04:02:55 +00:00
Gary Pendergast 744ffe8e00 Coding Standards: Exclude a handful of incorrectly named files that won't be renamed. 
See #47632.

Built from https://develop.svn.wordpress.org/trunk@45661


git-svn-id: http://core.svn.wordpress.org/trunk@45472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 03:50:59 +00:00
Gary Pendergast 1f5fcff132 Coding Standards: Improve spacing of `printf()` calls in the admin About pages. 
Props garrett-eclipse.
Fixes #47734.


Built from https://develop.svn.wordpress.org/trunk@45660


git-svn-id: http://core.svn.wordpress.org/trunk@45471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 00:09:58 +00:00
Sergey Biryukov 1c331e8931 I18N: Make URLs to `https://wordpress.org/about/` and related pages translatable, as they can now be localized on Rosetta sites. 
Props mukesh27.
Fixes #46386.
Built from https://develop.svn.wordpress.org/trunk@45659


git-svn-id: http://core.svn.wordpress.org/trunk@45470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-18 12:41:57 +00:00
Gary Pendergast 22412b1d97 Customizer: Show all widgets when the search field is cleared. 
When clicking the clear button on the widget search field, the search results should refresh to show all widgets.

Props Mahesh901122.
Fixes #47534.

Built from https://develop.svn.wordpress.org/trunk@45658


git-svn-id: http://core.svn.wordpress.org/trunk@45469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-18 05:55:59 +00:00
Sergey Biryukov 7149d65934 Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected. 
This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used.

Props garrett-eclipse, derweili, afercia.
Fixes #47487.
Built from https://develop.svn.wordpress.org/trunk@45657


git-svn-id: http://core.svn.wordpress.org/trunk@45468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-18 01:33:57 +00:00
Sergey Biryukov 4b460d0f80 Coding Standards: Fix WPCS issues in [45655]. 
See #47723.
Built from https://develop.svn.wordpress.org/trunk@45656


git-svn-id: http://core.svn.wordpress.org/trunk@45467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 19:22:56 +00:00
Sergey Biryukov f7c4398ea9 Menus: Trim whitespace from custom link URLs. 
Props majemedia, SergeyBiryukov.
Fixes #47723.
Built from https://develop.svn.wordpress.org/trunk@45655


git-svn-id: http://core.svn.wordpress.org/trunk@45466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 18:45:58 +00:00
Gary Pendergast 24d08a9463 Coding Standards: Move `wp-admin/custom-header.php` to `wp-admin/includes/class-custom-image-header.php` 
This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.

This commit also includes:
- A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45654


git-svn-id: http://core.svn.wordpress.org/trunk@45465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 06:17:56 +00:00
Gary Pendergast 83427a87a9 Coding Standards: Exclude some class names from checks when they can't be renamed. 
Renaming the classes would likely cause back compat issues, so the safest option is to allow this handful to continue unchanged.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45653


git-svn-id: http://core.svn.wordpress.org/trunk@45464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 04:34:55 +00:00
Sergey Biryukov 970fe7d85c Coding Standards: Fix WPCS issues in [45651]. 
See #38195.
Built from https://develop.svn.wordpress.org/trunk@45652


git-svn-id: http://core.svn.wordpress.org/trunk@45463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 01:50:58 +00:00
Sergey Biryukov 6cb424b978 Media: Add "Documents", "Spreadsheets", and "Archives" groups to file type filter in Media Library. 
Props zodiac1978, swissspidy, karmatosed, SergeyBiryukov.
Fixes #38195.
Built from https://develop.svn.wordpress.org/trunk@45651


git-svn-id: http://core.svn.wordpress.org/trunk@45462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 01:22:55 +00:00
Sergey Biryukov 1f256f3fdc Administration: In `admin-ajax.php`, send `X-Robots-Tag` header earlier, so that it applies before `wp_die()` when no action parameter was provided. 
Props robi-bobi, harryfear, garrett-eclipse.
Fixes #47711.
Built from https://develop.svn.wordpress.org/trunk@45650


git-svn-id: http://core.svn.wordpress.org/trunk@45461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 01:11:56 +00:00
Sergey Biryukov 66afb60397 Site Health: Use consistent verbiage for "Learn more" links. 
Props ronakganatra, garrett-eclipse.
Fixes #47302.
Built from https://develop.svn.wordpress.org/trunk@45649


git-svn-id: http://core.svn.wordpress.org/trunk@45460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 22:28:57 +00:00
Sergey Biryukov f600647e22 Site Health: Replace "harddrive" with "device" on Site Health Info screen. 
Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965.
Built from https://develop.svn.wordpress.org/trunk@45648


git-svn-id: http://core.svn.wordpress.org/trunk@45459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 22:19:55 +00:00
Sergey Biryukov e5ad773194 I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings. 
Props ramiy.
Fixes #47252.
Built from https://develop.svn.wordpress.org/trunk@45647


git-svn-id: http://core.svn.wordpress.org/trunk@45458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 22:13:58 +00:00
Sergey Biryukov 2ac05ca7d5 Media: Add a unit test for `wp_get_mime_types()`. 
Props pbearne.
Fixes #47701.
Built from https://develop.svn.wordpress.org/trunk@45646


git-svn-id: http://core.svn.wordpress.org/trunk@45457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 21:52:57 +00:00
Andrew Ozz 5eba5381e6 Media: Sort the new sizes array by priority when creating image sub-sizes. 
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45645


git-svn-id: http://core.svn.wordpress.org/trunk@45456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 21:48:56 +00:00
Sergey Biryukov 6f2fe4da8f Customize: In `WP_Customize_Widgets::capture_filter_pre_update_option()`, return the filtered value instead of `null` when bailing early for ignored options. 
Props dlh.
Fixes #47715.
Built from https://develop.svn.wordpress.org/trunk@45644


git-svn-id: http://core.svn.wordpress.org/trunk@45455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 21:33:57 +00:00
Sergey Biryukov 62216de5d4 Docs: Move the `do_mu_upgrade` DocBlock out of the preceding `if` statement. 
Props ChriCo, dkarfa.
Fixes #47710.
Built from https://develop.svn.wordpress.org/trunk@45643


git-svn-id: http://core.svn.wordpress.org/trunk@45454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 13:15:58 +00:00
Sergey Biryukov 62dc808103 Docs: Correct `@since` tag for `do_mu_upgrade` hook, for consistency with `after_mu_upgrade` and `wpmu_upgrade_site`. 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@45642


git-svn-id: http://core.svn.wordpress.org/trunk@45453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 12:42:59 +00:00
Sergey Biryukov c0e53279b3 Comments: Fix typo in comment reply observer options. 
Props maguiar.
Fixes #47706. See #46260.
Built from https://develop.svn.wordpress.org/trunk@45641


git-svn-id: http://core.svn.wordpress.org/trunk@45452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 16:46:55 +00:00
Gary Pendergast 820ce9c438 Code Modernisation: Revert [45624]. 
Changing the method signatures on `Walker` causes back compat issues.

See #47678.



Built from https://develop.svn.wordpress.org/trunk@45640


git-svn-id: http://core.svn.wordpress.org/trunk@45451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 07:04:59 +00:00
Gary Pendergast a571a7d621 Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays. 
PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.

This change fixes all of these warnings visible in unit tests.

Props jrf.
See #47704.



Built from https://develop.svn.wordpress.org/trunk@45639


git-svn-id: http://core.svn.wordpress.org/trunk@45450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 06:25:57 +00:00
Gary Pendergast bd45c7d3b9 Code Modernisation: Document when the Hash polyfills can be removed. 
The Hash extension cannot be disabled as of PHP 7.4. So, while we can't remove these polyfills yet, we can document when we'll be able to.

Props jrf.
Fixes #47698.


Built from https://develop.svn.wordpress.org/trunk@45638


git-svn-id: http://core.svn.wordpress.org/trunk@45449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 05:14:55 +00:00
Gary Pendergast 21df1bda5b Code Modernisation: Remove the SPL autoloader polyfill. 
As of PHP 5.3, the SPL extension cannot be disabled, so we no longer need this polyfill.

The file is kept with a `_deprecated_file()` call, to alert any plugins or themes that may be loading it directly.

Props jrf, ayeshrajans.
See #47698, #46630.


Built from https://develop.svn.wordpress.org/trunk@45637


git-svn-id: http://core.svn.wordpress.org/trunk@45448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 05:11:56 +00:00
Gary Pendergast 501b5f545b Code Modernisation: Remove the `array_replace_recursive()` polyfill. 
This function was added in PHP 5.3.0, so we no longer need the polyfill.

Props jrf.
See #47698.


Built from https://develop.svn.wordpress.org/trunk@45636


git-svn-id: http://core.svn.wordpress.org/trunk@45447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 05:08:56 +00:00
Gary Pendergast fbdb267634 WPDB: Allow custom data to be added to logged queries. 
This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.

Props CrazyJaco, johnbillion, pento.
Fixes 42151.

Built from https://develop.svn.wordpress.org/trunk@45635


git-svn-id: http://core.svn.wordpress.org/trunk@45446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 04:07:57 +00:00
Sergey Biryukov 83d175cdd0 I18N: Add context for theme filter strings in `WP_MS_Themes_List_Table::get_views()`. 
Props audrasjb.
Fixes #47695.
Built from https://develop.svn.wordpress.org/trunk@45634


git-svn-id: http://core.svn.wordpress.org/trunk@45445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-14 14:47:56 +00:00
Sergey Biryukov 436a9512e2 Upgrade/Install: Remove debugging artifacts from `wp-admin/upgrade.php` added in [1229]. 
Props rahulvaza.
Fixes #47074.
Built from https://develop.svn.wordpress.org/trunk@45633


git-svn-id: http://core.svn.wordpress.org/trunk@45444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-14 14:39:57 +00:00
Sergey Biryukov e85a5c64a3 REST API: Allow `rest_get_avatar_urls()` to accept full user, post, or comment objects, rather than just an email address, to provide better flexibility for alternative avatar data. 
Since the function uses `get_avatar_url()` internally, which already supports it, this should not have any backward compatibility concerns.

Props donmhico, dshanske, pputzer, joehoyle, TimothyBlynJacobs.
Fixes #40030.
Built from https://develop.svn.wordpress.org/trunk@45632


git-svn-id: http://core.svn.wordpress.org/trunk@45443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-14 14:35:56 +00:00
Andrew Ozz ee8813606d TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab. 
See #45307.
Built from https://develop.svn.wordpress.org/trunk@45631


git-svn-id: http://core.svn.wordpress.org/trunk@45442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 03:25:55 +00:00
Gary Pendergast 4d3a84aa9f Code Modernisation: Introduce the spread operator in `wpdb::prepare()`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45630


git-svn-id: http://core.svn.wordpress.org/trunk@45441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:17:57 +00:00
Gary Pendergast 2fe355cdd0 Code Modernisation: Introduce the spread operator in `widgets.php`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45629


git-svn-id: http://core.svn.wordpress.org/trunk@45440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:14:58 +00:00
Gary Pendergast afdbf749d7 Code Modernisation: Introduce the spread operator in `theme.php`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45628


git-svn-id: http://core.svn.wordpress.org/trunk@45439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:10:56 +00:00
Gary Pendergast 1af80c2106 Code Modernisation: Introduce the spread operator in `walk_page_dropdown_tree()`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45627


git-svn-id: http://core.svn.wordpress.org/trunk@45438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:06:55 +00:00
Sergey Biryukov 02c07f23d5 Customize: Fix text direction for color picker in RTL. 
Props vjik for the report.
Fixes #47688. See #23740.
Built from https://develop.svn.wordpress.org/trunk@45626


git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:05:57 +00:00
Gary Pendergast 5fb46ff14b Code Modernisation: Introduce the spread operator in `add_post_type_support()`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45625


git-svn-id: http://core.svn.wordpress.org/trunk@45436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:02:56 +00:00
Gary Pendergast 41ea1f106d Code Modernisation: Introduce the spread operator in `Walker`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45624


git-svn-id: http://core.svn.wordpress.org/trunk@45435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 23:51:56 +00:00
Gary Pendergast 4de2f2f49b Code Modernisation: Introduce the spread operator in `WP_User`. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45623


git-svn-id: http://core.svn.wordpress.org/trunk@45434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 23:48:56 +00:00